1. 11 Jan, 2007 2 commits
    • hyatt's avatar
      Rework positionForCoordinates to be more efficient and to handle... · 6a2ac52c
      hyatt authored
              Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
              adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
              space of the renderer.
      
              positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
              absolute positions over and over again.
      
              Reviewed by darin
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject value]):
              (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
              (-[WebCoreAXObject doAXTextMarkerForPosition:]):
              * dom/Document.cpp:
              (WebCore::Document::prepareMouseEvent):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::contains):
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventDoubleClick):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::EventHandler::sendContextMenuEvent):
              * page/EventHandler.h:
              * page/MouseEventWithHitTestResults.cpp:
              (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
              * page/MouseEventWithHitTestResults.h:
              (WebCore::MouseEventWithHitTestResults::localPoint):
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge _visiblePositionForPoint:]):
              * rendering/EllipsisBox.cpp:
              (WebCore::EllipsisBox::nodeAtPoint):
              * rendering/HitTestResult.h:
              (WebCore::HitTestResult::localPoint):
              (WebCore::HitTestResult::setLocalPoint):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::nodeAtPoint):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::nodeAtPoint):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::hitTestContents):
              (WebCore::RenderBlock::positionForCoordinates):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::nodeAtPoint):
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::positionForCoordinates):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::hitTestLines):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::positionForCoordinates):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::updateHitTestResult):
              * rendering/RenderObject.h:
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::nodeAtPoint):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::positionForCoordinates):
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::nodeAtPoint):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::nodeAtPoint):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::positionForCoordinates):
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::nodeAtPoint):
              (WebCore::RootInlineBox::closestLeafChildForXPos):
              * rendering/RootInlineBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a2ac52c
    • staikos's avatar
      Fix Qt build again · 15d2d71f
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15d2d71f
  2. 10 Jan, 2007 25 commits
    • bdash's avatar
      2007-01-10 Mitz Pettel <mitz@webkit.org> · b1863aa8
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=11775
                'Show URLs in Tool Tips' preference is ignored
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _resetCachedWebPreferences:]):
              (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:.
              Added an assertion that the view is not closed, instead of reopening it.
              Reopening should not occur, now that <http://bugs.webkit.org/show_bug.cgi?id=12087>
              is fixed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1863aa8
    • bdash's avatar
      2007-01-10 Kirby White <KWhiteRight@gmail.com> · 58feef6d
      bdash authored
              Reviewed by Darin.
      
              Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
      
              Set image size to fit alt text when image or input-image element
              has no src attribute, so that those images show their alt text instead
              of showing nothing at all.
      
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::attach):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::setImageSizeForAltText):
              (WebCore::RenderImage::imageChanged):
              * rendering/RenderImage.h:
      
      2007-01-10  Kirby White  <KWhiteRight@gmail.com>
      
              Reviewed by Darin.
      
              New and adjusted test cases for
              http://bugs.webkit.org/show_bug.cgi?id=11841
      
              * fast/dom/HTMLImageElement/image-alt-text-expected.checksum: Added.
              * fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
              * fast/dom/HTMLImageElement/image-alt-text-expected.txt: Added.
              * fast/dom/HTMLImageElement/image-alt-text.html: Added.
              * fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
              * fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
              * fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
              * fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
              * fast/dom/HTMLInputElement/input-image-alt-text.html: Added.
              * fast/dom/HTMLInputElement/resources/blue_rect.jpg: Added.
              * fast/forms/focus2-expected.txt:
              * fast/forms/focus2.html:
              * fast/forms/input-value-expected.checksum:
              * fast/forms/input-value-expected.png:
              * fast/forms/input-value-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58feef6d
    • bdash's avatar
      2007-01-11 Mark Rowe <mrowe@apple.com> · 3b4c7a82
      bdash authored
              Build fix.
      
              * rendering/RenderView.cpp:
              (WebCore::RenderView::printing):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b4c7a82
    • bdash's avatar
      2007-01-10 Mitz Pettel <mitz@webkit.org> · 1dbe9479
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=9284
                Quirksmode (CSS1): Removing inline border styles is impossible
      
              Test: fast/css/remove-shorthand.html
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
              containing a pointer to an array if properties and the array's length.
              (WebCore::PropertyLonghand::properties):
              (WebCore::PropertyLonghand::length):
              (WebCore::initShorthandMap): Initialize the mapping from shorthand
              properties to their dependent properties.
              (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
              if the property being removed is a shorthand, and if so, to remove all
              of its dependent properties.
              (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
              'notifyChanged' boolean parameter which controls whether this method
              calls setChanged() if it actually removes any property.
              * css/CSSMutableStyleDeclaration.h:
      
      2007-01-10  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=9284
                Quirksmode (CSS1): Removing inline border styles is impossible
      
              * fast/css/remove-shorthand-expected.txt: Added.
              * fast/css/remove-shorthand.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dbe9479
    • sfalken's avatar
      2007-01-10 Steve Falkenburg <sfalken@apple.com> · 6f98c4db
      sfalken authored
              Reviewed by Kevin.
      
              Removed unnecessary printing state
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f98c4db
    • andersca's avatar
      Reviewed by Maciej. · f5160cdc
      andersca authored
              Get the Refresh header directly from the ResourceResponse.
              
              * loader/DocumentLoader.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::commitProvisionalLoad):
              * loader/mac/DocumentLoaderMac.mm:
              (WebCore::DocumentLoader::getResponseModifiedHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5160cdc
    • ggaren's avatar
      * coding/coding-style.html: Fixed minor validation error. · 1663150e
      ggaren authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1663150e
    • ggaren's avatar
      Reviewed by Beth Dakin. · 81d58790
      ggaren authored
              
              Updated coding style guidelines to cover a lot of stuff previously absent.
      
              * coding/coding-style.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d58790
    • bdakin's avatar
      WebCore: · bf1713a6
      bdakin authored
              Reviewed by John.
      
              Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
              operates on the current WebView instead of invoking Safari's 
              service
      
              * page/ContextMenuClient.h: New call to the client to search in 
              google.
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected): Call 
              into the client instead of forming a new url string and loading it.
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
      
      WebKit:
              Reviewed by John.
      
              Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
              operates on the current WebView instead of invoking Safari's 
              service
      
              * WebCoreSupport/WebContextMenuClient.h:
              * WebCoreSupport/WebContextMenuClient.mm:
              (WebContextMenuClient::searchWithGoogle): Call into WebView to 
              search in Google.
              * WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu 
              available.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf1713a6
    • aroben's avatar
      Rubberstamped by Darin. · 41254d90
      aroben authored
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
              instead of an empty Event to FrameLoader::load and
              FrameLoader::urlSelected.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41254d90
    • andersca's avatar
      * loader/ResourceLoader.cpp: · 64d1f99f
      andersca authored
              (WebCore::ResourceLoader::~ResourceLoader):
              Disable assertion (I forgot to do this even though I added the comment!)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d1f99f
    • andersca's avatar
      Reviewed and landed by Anders. · 6eb17a95
      andersca authored
              Fix case in vcproj file (the GTK+ port uses the vcproj file).
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6eb17a95
    • lars's avatar
      Make the Qt build compile again after · 23d7feac
      lars authored
      the ResourceLoader was made platform
      independent.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23d7feac
    • andersca's avatar
      Rubber-stamped by Maciej. · 8f7934fb
      andersca authored
              
              Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
              
              * WebCore.xcodeproj/project.pbxproj:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didFinishLoad):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::MainResourceLoader):
              (WebCore::MainResourceLoader::~MainResourceLoader):
              (WebCore::MainResourceLoader::create):
              (WebCore::MainResourceLoader::receivedError):
              (WebCore::MainResourceLoader::didCancel):
              (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
              (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
              (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
              (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
              (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
              (WebCore::MainResourceLoader::addData):
              (WebCore::MainResourceLoader::willSendRequest):
              (WebCore::shouldLoadAsEmptyDocument):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
              (WebCore::MainResourceLoader::didReceiveResponse):
              (WebCore::MainResourceLoader::didReceiveData):
              (WebCore::MainResourceLoader::didFinishLoading):
              (WebCore::MainResourceLoader::didFail):
              (WebCore::MainResourceLoader::loadNow):
              (WebCore::MainResourceLoader::load):
              (WebCore::MainResourceLoader::setDefersLoading):
              * loader/MainResourceLoader.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::~ResourceLoader):
              (WebCore::ResourceLoader::releaseResources):
              (WebCore::ResourceLoader::load):
              (WebCore::ResourceLoader::setDefersLoading):
              (WebCore::ResourceLoader::frameLoader):
              (WebCore::ResourceLoader::addData):
              (WebCore::ResourceLoader::clearResourceData):
              (WebCore::ResourceLoader::willSendRequest):
              (WebCore::ResourceLoader::didReceiveResponse):
              (WebCore::ResourceLoader::didReceiveData):
              (WebCore::ResourceLoader::willStopBufferingData):
              (WebCore::ResourceLoader::didFinishLoading):
              (WebCore::ResourceLoader::didFinishLoadingOnePart):
              (WebCore::ResourceLoader::didFail):
              (WebCore::ResourceLoader::didCancel):
              (WebCore::ResourceLoader::cancel):
              (WebCore::ResourceLoader::response):
              (WebCore::ResourceLoader::cancelledError):
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::willStopBufferingData):
              (WebCore::ResourceLoader::setRequest):
              * loader/mac/FrameLoaderMac.mm:
              * loader/mac/MainResourceLoaderMac.mm: Removed.
              * loader/mac/ResourceLoaderMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f7934fb
    • lars's avatar
      Move files to the correct location, and remove a few · febabbfb
      lars authored
      unused methods from LoaderFunctionsQt.cpp
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      febabbfb
    • aroben's avatar
      Corrected Radar reference. · 13ab4d11
      aroben authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13ab4d11
    • aroben's avatar
      Reviewed by Geoff. · a3e58d98
      aroben authored
              Fix: <rdar://problem/4903003> ContextMenuController leaks Events
      
              No layout tests possible.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
              to manage the lifetime of Shared objects.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3e58d98
    • rwlbuis's avatar
      Reviewed by Sam. · 10b2829c
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12196
              SVGPatternElement should not be locatable
      
              Replace SVGStyledLocatableElement derivation with
              SVGStyledElement.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10b2829c
    • zimmermann's avatar
      Build fix, not reviewed. · bb74237e
      zimmermann authored
      Use correct method name in the ASSERT in RenderSVGText.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb74237e
    • zimmermann's avatar
      Reviewed by Eric. · 1dab1925
      zimmermann authored
      Large SVG dynamic update rework/optimization.
      
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
      Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
      
      Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
      Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
      Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dab1925
    • lars's avatar
      Use the new functionality in Qt 4.3, to make · a5fc7b38
      lars authored
      the methods closer compliant with the Unicode
      spec.
      
      Keep the old code so that it still compiles against
      Qt 4.2.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5fc7b38
    • hyatt's avatar
      Make the selectionRect() method of RenderText better by reusing... · f9a4547e
      hyatt authored
              Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
              the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
      
              Reviewed by bdash
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::selectionRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9a4547e
    • hyatt's avatar
      Make the absolutePosition method multi-column aware. Note that there... · 7fd1dd05
      hyatt authored
              Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
              absoluteRects method, since an object can split across multiple columns and break into multiple rects.
              absolutePosition just returns the top-left corner of the element's box in the first column in which it
              appears.
      
              Reviewed by bdash
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::adjustRectForColumns):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absolutePosition):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::getAbsoluteRepaintRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fd1dd05
    • hyatt's avatar
      Avoid crashing when repainting multiple columns... make sure to use... · f039551e
      hyatt authored
              Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
              not the newly-computed column count.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutColumns):
              (WebCore::RenderBlock::adjustRepaintRectForColumns):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f039551e
    • hyatt's avatar
      Break up painting and hit testing of children into helper methods and... · 750c0ff8
      hyatt authored
              Break up painting and hit testing of children into helper methods and add multi-column versions for both.
              
              Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
              hover works.
      
              Turn off selection gap filling in columns for now until it can be made to work correctly.
      
              Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
              account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
              contents by ensuring it gets all the remaining available height.
      
              Reviewed by mitz
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintColumns):
              (WebCore::RenderBlock::paintContents):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::fillSelectionGaps):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::hitTestColumns):
              (WebCore::RenderBlock::layoutColumns):
              (WebCore::RenderBlock::adjustRepaintRectForColumns):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::getAbsoluteRepaintRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      750c0ff8
  3. 09 Jan, 2007 13 commits
    • ddkilzer's avatar
      WebCore: · 9f892cfc
      ddkilzer authored
              Reviewed by Darin and Eric.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
      
              Don't use memset to set float to 0
      
              * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::cgGradientCallback):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f892cfc
    • hyatt's avatar
      Update overflow tests. Add new overflow test. · 76dc6bbd
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76dc6bbd
    • andersca's avatar
      Reviewed by Brady. · bfdcafaa
      andersca authored
              Add default constructor to SharedBuffer.
      
              * platform/SharedBuffer.cpp:
              (WebCore::SharedBuffer::SharedBuffer):
              * platform/SharedBuffer.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdcafaa
    • hyatt's avatar
      This patch gets rudimentary column layout working. Normal flow... · f3fb815b
      hyatt authored
              This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
              columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
              column rule painting, child layers.
      
              Some work needs to be done on the render tree dumper before column tests will be
              meaningful.
      
              Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
              in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
              by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
              Firefox with this change.
      
              Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
              This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
      
              Reviewed by mitz
      
              * page/Frame.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore:::RenderFlow):
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::paintContents):
              (WebCore::RenderBlock::paintChildren):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::lowestPosition):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::leftmostPosition):
              (WebCore::RenderBlock::avoidsFloats):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::hitTestContents):
              (WebCore::RenderBlock::layoutColumns):
              * rendering/RenderBlock.h:
              (WebCore::RenderBlock::hasOverhangingFloats):
              (WebCore::RenderBlock::hasColumns):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock):
              (WebCore::RenderFlexibleBox::layoutHorizontalBox):
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintLines):
              (WebCore::RenderFlow::lowestPosition):
              (WebCore::RenderFlow::rightmostPosition):
              (WebCore::RenderFlow::leftmostPosition):
              * rendering/RenderFlow.h:
              (WebCore::RenderFlow::hasColumns):
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::paint):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::expandsToEncloseOverflow):
              * rendering/RenderTableCell.h:
              (WebCore::RenderTableCell::expandsToEncloseOverflow):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3fb815b
    • justing's avatar
      Removed some extraneous text from this layout test. It passes now. · 32f826ae
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32f826ae
    • thatcher's avatar
      Reviewed by Darin. · a0aad25b
      thatcher authored
              Rename the now ObjC++ files to be .mm and remove the explicit file types.
      
              * DOM/WebDOMOperations.m: Removed.
              * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
              * English.lproj/StringsNotToBeLocalized.txt:
              * Misc/WebCoreStatistics.m: Removed.
              * Misc/WebElementDictionary.m: Removed.
              * Misc/WebIconDatabase.m: Removed.
              * Misc/WebNSAttributedStringExtras.m: Removed.
              * Misc/WebNSPasteboardExtras.m: Removed.
              * Plugins/WebNetscapePluginEmbeddedView.m: Removed.
              * Plugins/WebNullPluginView.m: Removed.
              * Plugins/WebPluginContainerCheck.m: Removed.
              * WebCoreSupport/WebViewFactory.m: Removed.
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebArchiver.m: Removed.
              * WebView/WebHTMLRepresentation.m: Removed.
              * WebView/WebHTMLView.m: Removed.
              * WebView/WebRenderNode.m: Removed.
              * WebView/WebResource.m: Removed.
              * WebView/WebScriptDebugDelegate.m: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0aad25b
    • darin's avatar
      JavaScriptCore: · b5a0e3df
      darin authored
              - update 2007 Apple copyright for the new company name
      
              * kjs/DateMath.cpp:
      
      WebCore:
      
              - update all 2007 Apple copyrights for the new company name
      
              * css/cssstyleselector.cpp:
              * html/HTMLLIElement.cpp:
              * platform/CharacterNames.h:
              * platform/TextBreakIterator.h:
              * platform/TextBreakIteratorICU.cpp:
              * platform/graphics/ImageBuffer.h:
              * rendering/CounterNode.cpp:
              * rendering/CounterNode.h:
              * rendering/RenderBox.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderCounter.cpp:
              * rendering/RenderCounter.h:
              * rendering/RenderImage.h:
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.h:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              * rendering/RenderStyle.h:
              * rendering/RenderTable.cpp:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableCell.h:
              * rendering/RenderText.cpp:
              * rendering/RenderText.h:
              * rendering/RenderTreeAsText.cpp:
              * rendering/SVGRenderTreeAsText.cpp:
              * rendering/break_lines.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a0e3df
    • justing's avatar
      LayoutTests: · 0a658ca1
      justing authored
              Reviewed by john
      
              * editing/inserting/4840662-expected.checksum: Added.
              * editing/inserting/4840662-expected.png: Added.
              * editing/inserting/4840662-expected.txt: Added.
              * editing/inserting/4840662.html: Added.
              * editing/pasteboard/4840662-expected.checksum: Added.
              * editing/pasteboard/4840662-expected.png: Added.
              * editing/pasteboard/4840662-expected.txt: Added.
              * editing/pasteboard/4840662.html: Added.
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/4840662>
              REGRESSION: Mail crash when dragging text into a link
              
              moveParagraphs fails to move content into a display:block 
              anchor because of code in positionAvoidingSpecialElementBoundary,
              and so it infinitely recurs.
              
              * editing/htmlediting.cpp:
              (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
              that have display:block so that content is inserted in the expected
              paragraph.  This fixes the bug and weird behavior when typing before/after
              anchors with display:block.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a658ca1
    • rwlbuis's avatar
      Reviewed by Darin. · 12090e50
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12145
              Color parsing is too relaxed in strict mode
              http://bugs.webkit.org/show_bug.cgi?id=12166
              REGRESSION (r18480): "336633" is not parsed as a color 
      
              Fix a regression by using String::format return value.
              Also make strict mode more strict for cases where hexcolors
              lack a #.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12090e50
    • darin's avatar
      Reviewed by Maciej. · 79b3b956
      darin authored
              - fixed regression where redirects did not have user-agent any more
      
              Showed up as a failure in one of the http tests, so no new test needed.
      
              * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
              Don't use a copy of the ResourceRequest; pass the original so it can be modified.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79b3b956
    • darin's avatar
      - fix build · a1f8cdf6
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Actually compile it this time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1f8cdf6
    • darin's avatar
      - fix build · eb0f9298
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Change types.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0f9298
    • darin's avatar
      - fix build on platforms where Unicode::UChar is != uint16_t · 1504daad
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Change types.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1504daad