1. 07 Jan, 2011 40 commits
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · 699c679f
      cmarrin@apple.com authored
              Unreviewed.
      
              Added one more API to WKSI to get the user data
              out of the CACFContext.
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
              * win/lib/WebKitSystemInterface_debug.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      699c679f
    • senorblanco@chromium.org's avatar
      2011-01-07 Stephen White <senorblanco@chromium.org> · 1cf67e55
      senorblanco@chromium.org authored
              Unreviewed; test expectations update.
      
              * platform/chromium-gpu/test_expectations.txt:
              Removed some no-longer-failing tests; moved some lines around to
              match the CPU results.
              * platform/chromium/test_expectations.txt:
              Bug assignment and cleanup.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cf67e55
    • commit-queue@webkit.org's avatar
      2011-01-07 Jan Erik Hanssen <jhanssen@sencha.com> · f5e9b910
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Black text on black buttons using a dark theme
              https://bugs.webkit.org/show_bug.cgi?id=35024
      
              Implement RenderThemeQt::systemColor to apply the correct colors from the current Qt style.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::systemColor):
              * platform/qt/RenderThemeQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5e9b910
    • commit-queue@webkit.org's avatar
      2011-01-07 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla... · 02f6410b
      commit-queue@webkit.org authored
      2011-01-07 Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] WebKit2 GNUmakefile is out of date from trunk
              Adding new stub files for compiling on latest revision
              https://bugs.webkit.org/show_bug.cgi?id=51883
      
              * UIProcess/gtk: Added.
              * UIProcess/gtk/TextCheckerGtk.cpp: Added.
              (WebKit::TextChecker::state):
              (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
              (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::setGrammarCheckingEnabled):
              (WebKit::TextChecker::uniqueSpellDocumentTag):
              (WebKit::TextChecker::closeSpellDocumentWithTag):
              (WebKit::TextChecker::checkTextOfParagraph):
              (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
              (WebKit::TextChecker::getGuessesForWord):
              (WebKit::TextChecker::learnWord):
              (WebKit::TextChecker::ignoreWord):
              * UIProcess/gtk/WebInspectorGtk.cpp: Added.
              (WebKit::WebInspectorProxy::platformCreateInspectorPage):
              (WebKit::WebInspectorProxy::platformOpen):
              (WebKit::WebInspectorProxy::platformClose):
              (WebKit::WebInspectorProxy::inspectorPageURL):
              * UIProcess/gtk/WebPageProxyGtk.cpp: Added.
              (WebKit::WebPageProxy::standardUserAgent):
              * UIProcess/gtk/WebPreferencesGtk.cpp: Added.
              (WebKit::WebPreferences::platformInitializeStore):
              (WebKit::WebPreferences::platformUpdateStringValueForKey):
              (WebKit::WebPreferences::platformUpdateBoolValueForKey):
              (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
              * WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Added.
              (WebKit::WebContextMenuClient::lookUpInDictionary):
              (WebKit::WebContextMenuClient::isSpeaking):
              (WebKit::WebContextMenuClient::speak):
              (WebKit::WebContextMenuClient::stopSpeaking):
              * WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Added.
              (WebKit::WebDatabaseManager::databaseDirectory):
              * WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Added.
              (WebKit::WebPopupMenu::setUpPlatformData):
              * WebProcess/WebPage/gtk: Added.
              * WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Added.
              (WebKit::WebInspector::localizedStringsURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f6410b
    • enne@google.com's avatar
      2011-01-05 Adrienne Walker <enne@google.com> · a3de32ec
      enne@google.com authored
              Reviewed by Kenneth Russell.
      
              Add tests for WebGL's lost context events.
              https://bugs.webkit.org/show_bug.cgi?id=51492
      
              * fast/canvas/webgl/context-lost-expected.txt: Added.
              * fast/canvas/webgl/context-lost-restored-expected.txt: Added.
              * fast/canvas/webgl/context-lost-restored.html: Added.
              * fast/canvas/webgl/context-lost.html: Added.
      2011-01-05  Adrienne Walker  <enne@google.com>
      
              Reviewed by Kenneth Russell.
      
              Add WEBKIT_lose_context WebGL extension.
              https://bugs.webkit.org/show_bug.cgi?id=51492
      
              Tests: fast/canvas/webgl/context-lost-restored.html
                     fast/canvas/webgl/context-lost.html
      
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::toJS):
              (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::toV8Object):
              (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
              * html/canvas/WebGLExtension.h:
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
              (WebCore::WebGLRenderingContext::getExtension):
              (WebCore::WebGLRenderingContext::getSupportedExtensions):
              (WebCore::WebGLRenderingContext::forceLostContext):
              (WebCore::WebGLRenderingContext::onLostContext):
              (WebCore::WebGLRenderingContext::getNumberOfExtensions):
              (WebCore::WebGLRenderingContext::getExtensionNumber):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h.
              (WebCore::WebKitLoseContext::WebKitLoseContext):
              (WebCore::WebKitLoseContext::~WebKitLoseContext):
              (WebCore::WebKitLoseContext::getName):
              (WebCore::WebKitLoseContext::create):
              (WebCore::WebKitLoseContext::loseContext):
              * html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
              * html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3de32ec
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · 37521711
      cmarrin@apple.com authored
              Unreviewed.
      
              Build fix for Chromium. Missing include.
      
              * page/animation/AnimationBase.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37521711
    • aroben@apple.com's avatar
      Update react-to-vsprops-changes.py after r74855 · e01b3a6c
      aroben@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e01b3a6c
    • aroben@apple.com's avatar
      Don't ever call ::SetCursor(0) · 8effab9d
      aroben@apple.com authored
      Doing so makes the cursor disappear from the screen.
      
      Fixes <http://webkit.org/b/52024> Mouse cursor flashes when moving it
      around a WKView before the web process has finished launching
      
      Reviewed by Jon Honeycutt.
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::onSetCursor): If we don't have a cursor to set, just
      let Windows do its default thing (which is to set the cursor to the
      window class's cursor, which in our case is the arrow cursor).
      (WebKit::WebView::cursorToShow): Just return 0 when the page has
      crashed so that we'll show the default cursor (which is the arrow
      cursor). This change has no visible effect, but seems slightly better
      conceptually.
      (WebKit::WebView::updateNativeCursor): Don't do anything if we don't
      have a cursor to set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8effab9d
    • aroben@apple.com's avatar
      Fill the WKView with white when the web process hasn't drawn anything yet · 75bf8e69
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52023> WKView accumulates pixel garbage
      before web process has had a chance to draw anything (if Aero is
      disabled)
      
      Reviewed by Jon Honeycutt.
      
      * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
      (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
      * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
      * UIProcess/DrawingAreaProxy.h:
      * UIProcess/LayerBackedDrawingAreaProxy.cpp:
      (WebKit::LayerBackedDrawingAreaProxy::paint):
      * UIProcess/LayerBackedDrawingAreaProxy.h:
      * UIProcess/TiledDrawingAreaProxy.cpp:
      (WebKit::TiledDrawingAreaProxy::paint):
      * UIProcess/TiledDrawingAreaProxy.h:
      * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
      (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
      * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
      (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
      * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
      (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
      * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:
      (WebKit::LayerBackedDrawingAreaProxy::paint):
      Changed these functions to return a boolean indicating whether we
      actually painted anything.
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::onPaintEvent): Fill with white (and don't call
      didDraw) when the DrawingAreaProxy isn't able to paint.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75bf8e69
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · fc0ee8b7
      cmarrin@apple.com authored
              Unreviewed.
      
              Build fix.
      
              * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc0ee8b7
    • barraclough@apple.com's avatar
      Source/JavaScriptCore: [GTK] Port scrollbar painting to GtkStyleContext · d6544ee5
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52051
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-01-07
      Reviewed by Martin Robinson.
      
      * wtf/gobject/GTypedefs.h: Add GtkStyleContext forward
      declaration.
      
      WebCore: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
      
      Reviewed by Geoff Garen.
      
      The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
      destructor early, in order to release wrappers once we know we no longer intend to use them.
      Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
      lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
      A sequence of events that triggers the bug would look like this:
      
      (1) Create a DOMWrapperWorld.
      (2) Register a timer in the world.
      (3) Call unregisterWorld() on the world.
      (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
      (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
          called forgetWorld() none exists.
      (6) Attempt to add a wrapper to a NULL map.
      
      Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
      
      * WebCore.exp.in:
      * bindings/js/DOMWrapperWorld.cpp:
      (WebCore::DOMWrapperWorld::DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
      (WebCore::DOMWrapperWorld::clearWrappers):
      * bindings/js/DOMWrapperWorld.h:
      
      WebKit/mac: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
      
      Reviewed by Geoff Garen.
      
      The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
      destructor early, in order to release wrappers once we know we no longer intend to use them.
      Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
      lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
      A sequence of events that triggers the bug would look like this:
      
      (1) Create a DOMWrapperWorld.
      (2) Register a timer in the world.
      (3) Call unregisterWorld() on the world.
      (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
      (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
          called forgetWorld() none exists.
      (6) Attempt to add a wrapper to a NULL map.
      
      Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
      
      * WebView/WebScriptWorld.mm:
      (-[WebScriptWorld unregisterWorld]):
      
      WebKit/win: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
      
      Reviewed by Geoff Garen.
      
      The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
      destructor early, in order to release wrappers once we know we no longer intend to use them.
      Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
      lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
      A sequence of events that triggers the bug would look like this:
      
      (1) Create a DOMWrapperWorld.
      (2) Register a timer in the world.
      (3) Call unregisterWorld() on the world.
      (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
      (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
          called forgetWorld() none exists.
      (6) Attempt to add a wrapper to a NULL map.
      
      Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
      
      * WebScriptWorld.cpp:
      (WebScriptWorld::unregisterWorld):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6544ee5
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · ed04bb96
      cmarrin@apple.com authored
              Unreviewed.
      
              Adding updated WKSI files missed in http://trac.webkit.org/changeset/75262
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
              * win/lib/WebKitSystemInterface_debug.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed04bb96
    • senorblanco@chromium.org's avatar
      2011-01-07 Stephen White <senorblanco@chromium.org> · 433ad383
      senorblanco@chromium.org authored
              Unreviewed; new test baselines and updated chromium expectations.
      
              * platform/chromium-gpu/test_expectations.txt:
              * platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
              * platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      433ad383
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · 14a3dcfb
      cmarrin@apple.com authored
              Rubber-stamped by Simon Fraser.
      
              Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
              https://bugs.webkit.org/show_bug.cgi?id=49388
      
              Final step in unifying GraphicsLayer logic across Win and Mac. This 
              implements the Windows side classes for PlatformCALayer and supporting
              classes. Also changed MediaPlayer to use new PlatformCALayerClient
              so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
              WKCACFLayerRenderer now does the task of notifying animations of their
              start time. Also commented out an assert in AnimationBase because
              AnimationController's frame time is not in sync with the new 
              AnimationTimeController. I've opened a new bug for that issue:
      
                  https://bugs.webkit.org/show_bug.cgi?id=52037
                  
              This also includes the Mac side changes backed out in 
              http://trac.webkit.org/changeset/75227.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14a3dcfb
    • japhet@chromium.org's avatar
      2011-01-07 Nate Chapin <japhet@chromium.org> · a539e08b
      japhet@chromium.org authored
              Reviewed by Darin Fisher.
      
              Let PingLoader send cookies if FrameLoaderClient permits it.
              https://bugs.webkit.org/show_bug.cgi?id=51898
      
              Test: http/tests/navigation/ping-cookie.html
      
              * loader/PingLoader.cpp:
              (WebCore::PingLoader::PingLoader): Set m_shouldUseCredentialStorage
                  at load start time, since we won't be able to call 
                  FrameLoaderClient::shouldUseCredentialStorage() later.
              * loader/PingLoader.h:
              (WebCore::PingLoader::shouldUseCredentialStorage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a539e08b
    • xan@webkit.org's avatar
      2011-01-07 Xan Lopez <xlopez@igalia.com> · eb3d7d6e
      xan@webkit.org authored
              Unreviewed, rolling out r75256.
              http://trac.webkit.org/changeset/75256
              https://bugs.webkit.org/show_bug.cgi?id=50869
      
              Broke GTK+ canvas tests
      
              * platform/gtk/Skipped:
      2011-01-07  Xan Lopez  <xlopez@igalia.com>
      
              Unreviewed, rolling out r75256.
              http://trac.webkit.org/changeset/75256
              https://bugs.webkit.org/show_bug.cgi?id=50869
      
              Broke GTK+ canvas tests
      
              * platform/graphics/cairo/PathCairo.cpp:
              (WebCore::Path::addArc):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb3d7d6e
    • carlosgc@webkit.org's avatar
      2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> · e6318adc
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Port scrollbar painting to GtkStyleContext
              https://bugs.webkit.org/show_bug.cgi?id=52051
      
              * wtf/gobject/GTypedefs.h: Add GtkStyleContext forward
              declaration.
      2011-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Port scrollbar painting to GtkStyleContext
              https://bugs.webkit.org/show_bug.cgi?id=52051
      
              Use GtkStyleContext API to paint scrollbars when building with
              GTK+ 3.x.
      
              No new tests. This should not change functionality.
      
              * platform/gtk/RenderThemeGtk.h:
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::RenderThemeGtk::gtkScrollbarStyle):
              * platform/gtk/ScrollbarThemeGtk.cpp:
              * platform/gtk/ScrollbarThemeGtk.h:
              * platform/gtk/ScrollbarThemeGtk2.cpp:
              (WebCore::gtkStyleSetCallback):
              (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
              * platform/gtk/ScrollbarThemeGtk3.cpp:
              (WebCore::gtkStyleChangedCallback):
              (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
              (WebCore::ScrollbarThemeGtk::updateThemeProperties):
              (WebCore::ScrollbarThemeGtk::paintTrackBackground):
              (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
              (WebCore::ScrollbarThemeGtk::paintThumb):
              (WebCore::ScrollbarThemeGtk::paintButton):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6318adc
    • jberlin@webkit.org's avatar
      Unreviewed, rolling out r75205. · a113c1b8
      jberlin@webkit.org authored
      http://trac.webkit.org/changeset/75205
      https://bugs.webkit.org/show_bug.cgi?id=52026
      https://bugs.webkit.org/show_bug.cgi?id=52028
      https://bugs.webkit.org/show_bug.cgi?id=52029
      
      The Windows 7 Release Test Bots are fixed.
      
      * platform/win/animations: Removed.
      * platform/win/animations/animation-time-expected.txt: Removed.
      * platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
      * platform/win/fast/css/css3-nth-tokens-script-expected.txt: Removed.
      * platform/win/fast/css/css3-nth-tokens-style-expected.txt: Removed.
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a113c1b8
    • mitz@apple.com's avatar
      <rdar://problem/8783318> Text emphasis marks should not appear over characters... · 151c8374
      mitz@apple.com authored
      <rdar://problem/8783318> Text emphasis marks should not appear over characters that have ruby annotations
      https://bugs.webkit.org/show_bug.cgi?id=51267
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/text/emphasis-avoid-ruby.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::placeBoxesInBlockDirection): Use getEmphasisMarkPosition() to check if
      there are text emphasis marks.
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow): Ditto.
      (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Ditto.
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::getEmphasisMarkPosition): Added. Returns true and sets the emphasis mark
      position if the text is style with emphasis marks and there isn’t a ruby annotation that should
      suppress them. Otherwise returns false.
      (WebCore::InlineTextBox::paint): Use getEmphasisMarkPosition() to check if emphasis marks should
      be painted.
      * rendering/InlineTextBox.h:
      
      LayoutTests: 
      
      * fast/text/emphasis-avoid-ruby-expected.checksum: Added.
      * fast/text/emphasis-avoid-ruby-expected.png: Added.
      * fast/text/emphasis-avoid-ruby-expected.txt: Added.
      * fast/text/emphasis-avoid-ruby.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      151c8374
    • alex@webkit.org's avatar
      2011-01-07 Alejandro G. Castro <alex@igalia.com> · 3e127212
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [cairo] Rendering a lot of arcs on top of each other causes time
              outs in some tests
              https://bugs.webkit.org/show_bug.cgi?id=50869
      
              We avoid the situation where we have to render the same arc
              multiple times over itself. Now it renders just one oval and
              moves to the end angle.
      
              * platform/graphics/cairo/PathCairo.cpp:
              (WebCore::Path::addArc):
      
      2011-01-07  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [cairo] Rendering a lot of arcs on top of each other causes time
              outs in some tests
              https://bugs.webkit.org/show_bug.cgi?id=50869
      
              Unskip canvas-largedraws.html after improving the performance for
              big angles.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e127212
    • carlosgc@webkit.org's avatar
      2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> · 58529d5c
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Port buttons painting to GtkStyleContext
              https://bugs.webkit.org/show_bug.cgi?id=51812
      
              Use GtkStyleContext API to paint buttons when building with GTK+
              3.x.
      
              No new tests. This should not change functionality.
      
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::adjustRectForFocus):
              (WebCore::RenderThemeGtk::adjustRepaintRect):
              (WebCore::RenderThemeGtk::paintButton):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58529d5c
    • zmo@google.com's avatar
      2011-01-07 Zhenyao Mo <zmo@google.com> · cdd23dfa
      zmo@google.com authored
              Unreviewed, build fix.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::copyTexSubImage2D):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdd23dfa
    • jberlin@webkit.org's avatar
      WebKit2: Need WKBundlePagePrivate equivalent of WebKit1's WebViewPrivate's setDefersCallbacks · 948bd328
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52038
      
      Reviewed by Jon Honeycutt.
      
      The implementation of WebKit1's WebViewPrivate's setDefersCallbacks on both Windows and Mac
      calls WebCore::Page::setDefersLoading.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageSetDefersLoading):
      * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setDefersLoading):
      * WebProcess/WebPage/WebPage.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      948bd328
    • zmo@google.com's avatar
      2011-01-06 Zhenyao Mo <zmo@google.com> · c823d6ca
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              copyTexSubImage2D shouldn't have undefined pixels
              https://bugs.webkit.org/show_bug.cgi?id=51559
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::copyTexImage2D): Refactor to share some code with copyTexSubImage2D through helper function clip2D.
              (WebCore::WebGLRenderingContext::copyTexSubImage2D): Initialize undefined pixels to 0.
              (WebCore::WebGLRenderingContext::validateTexFuncLevel): Seperate the validation of level from validateTexFuncParameters.
              (WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebGLTexture.cpp:
              (WebCore::WebGLTexture::getType): Expose the type of a texture.
              * html/canvas/WebGLTexture.h:
      2011-01-06  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              copyTexSubImage2D shouldn't have undefined pixels
              https://bugs.webkit.org/show_bug.cgi?id=51559
      
              * fast/canvas/webgl/uninitialized-test-expected.txt:
              * fast/canvas/webgl/uninitialized-test.html: Add test cases for copyTexSubImage2D.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c823d6ca
    • zmo@google.com's avatar
      2011-01-07 Takashi Toyoshima <toyoshim@google.com> · 9918d14d
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              cleanupAfterGraphicsCall() is never called in
              WebGLRenderingContext::checkFramebufferStatus()
              https://bugs.webkit.org/show_bug.cgi?id=51668
      
              No new tests. This is a trivial bug.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::checkFramebufferStatus):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9918d14d
    • mario@webkit.org's avatar
      2011-01-07 Mario Sanchez Prada <msanchez@igalia.com> · 86390a14
      mario@webkit.org authored
              Reviewed by Chris Fleizach.
      
              GTK: AX: atk tests need to be updated after recent changes
              https://bugs.webkit.org/show_bug.cgi?id=51932
      
              Make sure we can always get the right accesssible parent for an
              AtkObject when traversing the hierarchy bottom up.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (isRootObject): New function to check whether an
              AccessibilityObject is the root one or not, according to the
              latest changes in the hierarchy.
              (atkParentOfRootObject): Gets the appropriate AtkObject from GTK's
              GAIL as the parent of the root AtkObject from WebCore.
              (webkit_accessible_get_parent): Use atkParentOfRootObject.
              (webkit_accessible_get_index_in_parent): Ditto.
              (atkRole): Expose AccessibilityObjects with ScrollAreaRole as
              AtkObject's of role ATK_ROLE_SCROLLED_PANE.
      2011-01-07  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              GTK: AX: atk tests need to be updated after recent changes
              https://bugs.webkit.org/show_bug.cgi?id=51932
      
              Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
              the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.
      
              With the change to support WK2 accessibility, the root object of
              the AX hierarchy is different from what GTK expects as the current
              hirarchy right now includes a new accessible object as the parent
              of the accessible web area (AXScrollView).
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_accessible): Return the first child of the
              wrapper associated to the root accessible object in the document,
              to keep everything in the GTK port working as it used to be.
      
              Re-enable skipped ATK unit tests now they are passing again.
      
              * tests/testatk.c:
              (main): Re-enable skipped tests.
              * tests/testatkroles.c:
              (main): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86390a14
    • zmo@google.com's avatar
      2011-01-07 Zhenyao Mo <zmo@google.com> · 0bd99e3e
      zmo@google.com authored
              Unreviewed, Mac 32-bit build fix.
              Use float instead of double in GL function arguments to avoid implicit type down casting.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::blendColor):
              (WebCore::WebGLRenderingContext::clearColor):
              (WebCore::WebGLRenderingContext::clearDepth):
              (WebCore::WebGLRenderingContext::depthRange):
              (WebCore::WebGLRenderingContext::lineWidth):
              (WebCore::WebGLRenderingContext::polygonOffset):
              (WebCore::WebGLRenderingContext::sampleCoverage):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebGLRenderingContext.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bd99e3e
    • sfalken@apple.com's avatar
    • dbates@webkit.org's avatar
      2011-01-07 Daniel Bates <dbates@rim.com> · b6bf9918
      dbates@webkit.org authored
              Reviewed by Martin Robinson.
      
              Enable PCRE computed gotos when compiling with RCVT 4.0 or greater in GNU mode
              https://bugs.webkit.org/show_bug.cgi?id=52034
      
              Derived from a patch by Eli Fidler.
      
              RVCT 4 or greater in GNU mode supports the computed goto GNU language extension
              as per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/ch03s07s12.html>.
      
              * pcre/pcre_exec.cpp: Modified to check for feature, HAVE(COMPUTED_GOTO), instead
              of hardcoding the GCC compiler.
              * wtf/Platform.h: Define WTF_COMPILER_RVCT4_OR_GREATER if __ARMCC_VERSION >= 400000.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6bf9918
    • beidson@apple.com's avatar
      <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355 · fc699e24
      beidson@apple.com authored
      Change WebKit2 session restoring to restore the full back/forward list.
      
      Reviewed by Darin Adler.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Let the UIProcess register its own
        WebBackForwardListItems in its ID map upon creation.
      * UIProcess/WebProcessProxy.h:
      
      * UIProcess/cf/WebPageProxyCF.cpp:
      (WebKit::WebPageProxy::restoreFromSessionStateData): Register each new list entry in the
        UIProcess ID map.
      
      * WebProcess/WebPage/WebBackForwardListProxy.cpp:
      (WebKit::WebBackForwardListProxy::addItemFromUIProcess): Add this method to register UIProcess
        created items without doing any of the other work normally associated with adding a new back/forward item
        (such as notifying the UIProcess).
      * WebProcess/WebPage/WebBackForwardListProxy.h:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::restoreSession): Map all of the back/forward list entries from the UIProcess then
        cause a load of the current entry.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc699e24
    • senorblanco@chromium.org's avatar
      2011-01-07 Stephen White <senorblanco@chromium.org> · 7cd037ab
      senorblanco@chromium.org authored
              Unreviewed; new test results and expectations updates.
      
              Created new results for tests which do not fail on chrome win (failing
              Safari results were recently checked in).  Also assigned bugs to many
              of my recent test_expectations updates.
      
              * platform/chromium-win/animations/animation-time-expected.txt: Added.
              * platform/chromium-win/fast/css/css3-nth-tokens-script-expected.txt: Added.
              * platform/chromium-win/fast/css/css3-nth-tokens-style-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cd037ab
    • aroben@apple.com's avatar
      Build master fix · d7a75a81
      aroben@apple.com authored
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (RunWebKitTests.start): Don't try to concatenate a list and a string.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7a75a81
    • senorblanco@chromium.org's avatar
      2011-01-07 Stephen White <senorblanco@chromium.org> · be2fa04c
      senorblanco@chromium.org authored
              Unreviewed; chromium test expectations update.
      
              * platform/chromium/test_expectations.txt:
              A few tests that were flaky before are failing more frequently now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2fa04c
    • andreas.kling@nokia.com's avatar
      2011-01-07 Andreas Kling <kling@webkit.org> · f493fdee
      andreas.kling@nokia.com authored
              Reviewed by Adam Barth.
      
              [Qt] Add selectedHtml function to QWebView
              https://bugs.webkit.org/show_bug.cgi?id=35028
      
              Add QWebView::selectedHtml() and QWebPage::selectedHtml()
              which return the current selection range's HTML representation.
      
              * Api/qwebpage.cpp:
              (QWebPage::selectedHtml):
              * Api/qwebpage.h:
              * Api/qwebview.cpp:
              (QWebView::selectedText):
              (QWebView::selectedHtml):
              * Api/qwebview.h:
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::cursorMovements):
              (tst_QWebPage::textSelection):
              (tst_QWebPage::crashTests_LazyInitializationOfMainFrame):
              (tst_QWebPage::findText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f493fdee
    • carlosgc@webkit.org's avatar
      2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com> · 7c6ce438
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Port slider painting to GtkStyleContext
              https://bugs.webkit.org/show_bug.cgi?id=51874
      
              Use GtkStyleContext API to paint sliders when building with GTK+
              3.x. Also move the code to adjust media slider to its own method
              in RenderThemeGtk.cpp since it's common to both gtk 2 and 3.
      
              No new tests. This should not change functionality.
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
              * platform/gtk/RenderThemeGtk.h:
              * platform/gtk/RenderThemeGtk2.cpp:
              (WebCore::RenderThemeGtk::adjustSliderThumbSize):
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::adjustSliderThumbSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6ce438
    • commit-queue@webkit.org's avatar
      2011-01-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 81c35179
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              run-qtwebkit-tests should be able to kill a testsuite.
      
              Add new option in the script that can setup a timeout for a test.
              If the test execution takes more then specified time then the test
              would be terminated.
      
              [Qt] run-qtwebkit-tests needs timeout
              https://bugs.webkit.org/show_bug.cgi?id=51894
      
              * BuildSlaveSupport/build.webkit.org-config/master.cfg:
              * Scripts/run-qtwebkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81c35179
    • ossy@webkit.org's avatar
      Unreviewed fix after r75233. · 27bfad1c
      ossy@webkit.org authored
      Based on idea from Eric Seidel.
      
      Add remote zip file handling to webkitpy.
      https://bugs.webkit.org/show_bug.cgi?id=50901
      
      * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27bfad1c
    • benjamin.poulain@nokia.com's avatar
      2011-01-07 Benjamin Poulain <benjamin.poulain@nokia.com> · 49d54639
      benjamin.poulain@nokia.com authored
              Reviewed by Andreas Kling.
      
              [Qt] [WK2] QtWebKit does not build in debug, FileReader.cpp does not compile
              https://bugs.webkit.org/show_bug.cgi?id=51992
      
              Add the missing header. CString is used in debug by the calls to LOG().
      
              * fileapi/FileReader.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49d54639
    • alex@webkit.org's avatar
      2011-01-07 Alejandro G. Castro <alex@igalia.com> · 23c687cc
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              Cairo's ContextShadow may mis-render some box shadows
              https://bugs.webkit.org/show_bug.cgi?id=51374
      
              The space required for the internal shadow of the corners was not
              correctly considered.
      
              * platform/graphics/cairo/ContextShadowCairo.cpp:
              (WebCore::ContextShadow::drawRectShadow):
      
      2011-01-07  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Cairo's ContextShadow may mis-render some box shadows
              https://bugs.webkit.org/show_bug.cgi?id=51374
      
              Added new test to check rectangular tiled shadows.
      
              * platform/gtk/fast/css/rect-shadow-tiled-expected.checksum: Added.
              * platform/gtk/fast/css/rect-shadow-tiled-expected.png: Added.
              * platform/gtk/fast/css/rect-shadow-tiled-expected.txt: Added.
              * platform/gtk/fast/css/rect-shadow-tiled.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23c687cc
    • kinuko@chromium.org's avatar
      2011-01-07 Kinuko Yasuda <kinuko@chromium.org> · 01689715
      kinuko@chromium.org authored
              Unreviewed; an attempt to fix chromium bot failures by removing failing test line (they must be failing due to modificationTime accuracy error).
      
              * fast/filesystem/op-get-metadata-expected.txt:
              * fast/filesystem/resources/op-tests-helper.js:
              (runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01689715