1. 19 Aug, 2010 40 commits
    • rniwa@webkit.org's avatar
      2010-08-19 Ryosuke Niwa <rniwa@webkit.org> · 69916062
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html
              https://bugs.webkit.org/show_bug.cgi?id=44220
      
              Converted the tests.
      
              * editing/pasteboard/4242293-1-expected.txt: Added.
              * editing/pasteboard/4242293-1.html:
              * editing/pasteboard/copy-paste-bidi-expected.txt: Added.
              * editing/pasteboard/copy-paste-bidi.html:
              * platform/chromium-linux/editing/pasteboard/4242293-1-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/4242293-1-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/4242293-1-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/4242293-1-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/4242293-1-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/4242293-1-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/4242293-1-expected.png: Removed.
              * platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
              * platform/mac/editing/pasteboard/4242293-1-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/4242293-1-expected.png: Removed.
              * platform/mac/editing/pasteboard/4242293-1-expected.txt: Removed.
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
              * platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69916062
    • mrobinson@webkit.org's avatar
      2010-08-19 Martin Robinson <mrobinson@igalia.com> · 7d8bd2de
      mrobinson@webkit.org authored
              [GTK] r65681 broke a couple GTK+ a11y tests
              https://bugs.webkit.org/show_bug.cgi?id=44316
      
              * platform/gtk/Skipped: Skip some newly failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d8bd2de
    • jamesr@google.com's avatar
      2010-08-19 James Robinson <jamesr@chromium.org> · d86ad64a
      jamesr@google.com authored
              Unreviewed. Clean up test_expectations now that tables/hittesting/filltable-* pass on Chromium.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d86ad64a
    • kinuko@chromium.org's avatar
      2010-08-19 Kinuko Yasuda <kinuko@chromium.org> · 286784d8
      kinuko@chromium.org authored
              Reviewed by Darin Fisher.
      
              Add WebKit API for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=43151
      
              Add asynchronous FileSystem interface to WebKit API for
              FileSystem API.
              http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
      
              * WebKit.gyp:
              * public/WebFileError.h: Added.
              * public/WebFileSystem.h: Added.
              * public/WebFileSystemEntry.h: Added.
              * public/WebFileSystemCallbacks.h: Added.
              * public/WebKitClient.h:
              (WebKit::WebKitClient::fileSystem):
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::openFileSystem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      286784d8
    • vangelis@chromium.org's avatar
      2010-08-19 Vangelis Kokkevis <vangelis@chromium.org> · 3ffb2e6b
      vangelis@chromium.org authored
              Reviewed by Kenneth Russell.
      
              [chromium] Rearranging the accelerated compositing code such that the
              layer rendering logic now lives in the layer classes rather than the
              compositor. This lifts the restriction of having one texture per layer
              and significantly cleans up the compositor code. This change mostly
              resulted in a lot of code moving around files. Noteworthy changes
              include:
              * Made LayerChromium a proper based class for layers that mostly handles
                the updates to the layer properties and superlayer / sublayer updates.
              * Introduced a new layer type, ContentLayerChromium, which handles
                layers that require a GraphicsContext to render their content.
              * ImageLayerChromium and VideoLayerChromium now derive from
                ContentLayerChromium as they share the same shader and draw function.
              * Removed TransformLayerChromium as its functionality is now replaced by
                the base LayerChromium class.
              * Re-arranged the order in which the members of LayerChromium are defined
                in the header file to form a more reasonable logical grouping.
              * Changed LayerRendererChromium to use the shader creation and drawing
                methods defined in the layer classes. As a result, a lot of GL code was
                removed from the implementation file.
              * Eliminated randomly dispersed calls to check for GL errors by a macro (GLC)
                which allows turning error testing on/off with a single define (DEBUG_GL_CALLS
                defined in LayerRendererChromium.h)
              * Replaced the previous layer render loop with two traversals of the layer
                hierarchy, the first to update transforms and opacity values and the
                second to render the layers. Eliminated global Z sorting of all layers as
                it was wrong.
              https://bugs.webkit.org/show_bug.cgi?id=44148
      
              Test: Verified that pages using the compositor and compositor
                    layout tests have not regressed.
      
              * WebCore.gypi:
              * platform/graphics/chromium/CanvasLayerChromium.cpp:
              (WebCore::CanvasLayerChromium::SharedValues::SharedValues):
              (WebCore::CanvasLayerChromium::SharedValues::~SharedValues):
              (WebCore::CanvasLayerChromium::updateContents):
              (WebCore::CanvasLayerChromium::draw):
              * platform/graphics/chromium/CanvasLayerChromium.h:
              (WebCore::CanvasLayerChromium::SharedValues::canvasShaderProgram):
              (WebCore::CanvasLayerChromium::SharedValues::shaderSamplerLocation):
              (WebCore::CanvasLayerChromium::SharedValues::shaderMatrixLocation):
              (WebCore::CanvasLayerChromium::SharedValues::shaderAlphaLocation):
              (WebCore::CanvasLayerChromium::SharedValues::initialized):
              * platform/graphics/chromium/ContentLayerChromium.cpp: Added.
              (WebCore::ContentLayerChromium::SharedValues::SharedValues):
              (WebCore::ContentLayerChromium::SharedValues::~SharedValues):
              (WebCore::ContentLayerChromium::create):
              (WebCore::ContentLayerChromium::ContentLayerChromium):
              (WebCore::ContentLayerChromium::~ContentLayerChromium):
              (WebCore::ContentLayerChromium::updateContents):
              (WebCore::ContentLayerChromium::updateTextureRect):
              (WebCore::ContentLayerChromium::draw):
              * platform/graphics/chromium/ContentLayerChromium.h: Added.
              (WebCore::ContentLayerChromium::drawsContent):
              (WebCore::ContentLayerChromium::SharedValues::contentShaderProgram):
              (WebCore::ContentLayerChromium::SharedValues::shaderSamplerLocation):
              (WebCore::ContentLayerChromium::SharedValues::shaderMatrixLocation):
              (WebCore::ContentLayerChromium::SharedValues::shaderAlphaLocation):
              (WebCore::ContentLayerChromium::SharedValues::initialized):
              * platform/graphics/chromium/GraphicsLayerChromium.cpp:
              (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
              (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
              * platform/graphics/chromium/ImageLayerChromium.cpp:
              (WebCore::ImageLayerChromium::ImageLayerChromium):
              (WebCore::ImageLayerChromium::updateContents):
              * platform/graphics/chromium/ImageLayerChromium.h:
              * platform/graphics/chromium/LayerChromium.cpp:
              (WebCore::loadShader):
              (WebCore::LayerChromium::SharedValues::SharedValues):
              (WebCore::LayerChromium::SharedValues::~SharedValues):
              (WebCore::LayerChromium::LayerChromium):
              (WebCore::LayerChromium::~LayerChromium):
              (WebCore::LayerChromium::createShaderProgram):
              (WebCore::LayerChromium::toGLMatrix):
              (WebCore::LayerChromium::drawTexturedQuad):
              (WebCore::LayerChromium::drawDebugBorder):
              (WebCore::LayerChromium::prepareForDraw):
              * platform/graphics/chromium/LayerChromium.h:
              (WebCore::LayerChromium::getSublayers):
              (WebCore::LayerChromium::setPosition):
              (WebCore::LayerChromium::contentsDirty):
              (WebCore::LayerChromium::drawsContent):
              (WebCore::LayerChromium::updateContents):
              (WebCore::LayerChromium::draw):
              (WebCore::LayerChromium::SharedValues::quadVerticesVbo):
              (WebCore::LayerChromium::SharedValues::quadElementsVbo):
              (WebCore::LayerChromium::SharedValues::maxTextureSize):
              (WebCore::LayerChromium::SharedValues::borderShaderProgram):
              (WebCore::LayerChromium::SharedValues::borderShaderMatrixLocation):
              (WebCore::LayerChromium::SharedValues::borderShaderColorLocation):
              (WebCore::LayerChromium::SharedValues::initialized):
              (WebCore::LayerChromium::layerRenderer):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              (WebCore::LayerRendererChromium::~LayerRendererChromium):
              (WebCore::LayerRendererChromium::debugGLCall):
              (WebCore::LayerRendererChromium::useShader):
              (WebCore::LayerRendererChromium::drawLayers):
              (WebCore::LayerRendererChromium::createLayerTexture):
              (WebCore::LayerRendererChromium::updateLayersRecursive):
              (WebCore::LayerRendererChromium::drawLayersRecursive):
              (WebCore::LayerRendererChromium::drawLayer):
              (WebCore::LayerRendererChromium::checkTextureSize):
              (WebCore::LayerRendererChromium::initializeSharedObjects):
              (WebCore::LayerRendererChromium::cleanupSharedObjects):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::projectionMatrix):
              (WebCore::LayerRendererChromium::layerSharedValues):
              (WebCore::LayerRendererChromium::contentLayerSharedValues):
              (WebCore::LayerRendererChromium::canvasLayerSharedValues):
              * platform/graphics/chromium/TransformLayerChromium.cpp: Removed.
              * platform/graphics/chromium/TransformLayerChromium.h: Removed.
              * platform/graphics/chromium/VideoLayerChromium.cpp:
              (WebCore::VideoLayerChromium::VideoLayerChromium):
              (WebCore::VideoLayerChromium::updateContents):
              (WebCore::VideoLayerChromium::createTextureRect):
              * platform/graphics/chromium/VideoLayerChromium.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ffb2e6b
    • simon.fraser@apple.com's avatar
      2010-08-19 Simon Fraser <simon.fraser@apple.com> · 408f1fc5
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Clean up some selection code
              https://bugs.webkit.org/show_bug.cgi?id=44314
      
              Change the concept of "layout" in SelectionController to "updateCaretRect", renaming
              methods accordingly.
      
              Move selection and printing methods in RenderView.h into groups.
      
              No behavioral changes.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::modify):
              (WebCore::SelectionController::setCaretRectNeedsUpdate):
              (WebCore::SelectionController::updateCaretRect):
              (WebCore::SelectionController::localCaretRect):
              (WebCore::SelectionController::recomputeCaretRect): Test m_caretRectNeedsUpdate first.
              (WebCore::SelectionController::invalidateCaretRect):
              * editing/SelectionController.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              * rendering/RenderView.h:
              (WebCore::RenderView::selectionStart):
              (WebCore::RenderView::selectionEnd):
              (WebCore::RenderView::printRect):
              (WebCore::RenderView::setPrintRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      408f1fc5
    • kinuko@chromium.org's avatar
      2010-08-19 Kinuko Yasuda <kinuko@chromium.org> · 1889b402
      kinuko@chromium.org authored
              Reviewed by Jian Li.
      
              [Chromium] Rolls Chromium DEPS forward to 56564
              https://bugs.webkit.org/show_bug.cgi?id=44281
      
              Roll Chromium DEPS forward to 56564 to include WebFileSystem
              implementation changes.
      
              * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1889b402
    • commit-queue@webkit.org's avatar
      2010-08-19 Fady Samuel <fsamuel@chromium.org> · 006b4fee
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Fixed table hit testing layout test issues
              https://bugs.webkit.org/show_bug.cgi?id=44204
      
              Moved expectations to the same directory as tests.
              Expectations were failing due to inconsistent eventSender behavior:
              Switched to using elementFromPoint
      
              * platform/gtk/tables/hittesting/filltable-emptycells-expected.txt: Removed.
              * platform/gtk/tables/hittesting/filltable-levels-expected.txt: Removed.
              * platform/gtk/tables/hittesting/filltable-outline-expected.txt: Removed.
              * platform/gtk/tables/hittesting/filltable-rtl-expected.txt: Removed.
              * platform/gtk/tables/hittesting/filltable-stress-expected.txt: Removed.
              * tables/hittesting/filltable-emptycells-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-emptycells-expected.txt.
              * tables/hittesting/filltable-emptycells.html:
              * tables/hittesting/filltable-levels-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-levels-expected.txt.
              * tables/hittesting/filltable-levels.html:
              * tables/hittesting/filltable-outline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-outline-expected.txt.
              * tables/hittesting/filltable-outline.html:
              * tables/hittesting/filltable-rtl-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-rtl-expected.txt.
              * tables/hittesting/filltable-rtl.html:
              * tables/hittesting/filltable-stress-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-stress-expected.txt.
              * tables/hittesting/filltable-stress.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      006b4fee
    • ddkilzer@apple.com's avatar
      BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins · 88b90920
      ddkilzer@apple.com authored
      WebCore:
      
      * WebCore.exp.in:
      (WebCore::ScrollView::contentsToWindow): Added export.
      
      WebKit2:
      
      * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
      (WebKit::NetscapePlugin::platformPaint): Changed frameRect() to
      m_frameRect.
      
      WebKitTools:
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (decidePolicyForNavigationAction): Updated method signature.
      (decidePolicyForNewWindowAction): Updated method signature.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88b90920
    • abarth@webkit.org's avatar
      2010-08-19 Adam Barth <abarth@webkit.org> · 6ae5067a
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              <style> inside <noscript> is parsed when JavaScript is enabled.
              https://bugs.webkit.org/show_bug.cgi?id=44021
      
              More random bugs fixed by the HTML5 parser.  Time to document with a
              couple tests.  I added both these tests because <noscript> in <body> is
              slightly different than <noscript> before <body>.
      
              * fast/parser/no-style-in-noscript-expected.txt: Added.
              * fast/parser/no-style-in-noscript-with-body-expected.txt: Added.
              * fast/parser/no-style-in-noscript-with-body.html: Added.
              * fast/parser/no-style-in-noscript.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ae5067a
    • ddkilzer@apple.com's avatar
      BUILD FIX #3: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled · 5b71364d
      ddkilzer@apple.com authored
      Still trying to make Qt Linux Release minimal buildbot happy.
      
      WebCore:
      
      * plugins/PluginViewNone.cpp: Compile missing methods for Qt.
      
      WebKit/qt:
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createPlugin): Wrap code that
      handles Netscape plugins in #if ENABLE(NETSCAPE_PLUGIN_API)
      and #endif.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b71364d
    • johnnyg@google.com's avatar
      2010-08-19 Sam Weinig <sam@webkit.org> · 6abb3d64
      johnnyg@google.com authored
              Rubber-stamped by Jon Honeycutt.
      
              Add a few items in the WebKitTestRunner Skipped list.
      
              * platform/mac-wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6abb3d64
    • weinig@apple.com's avatar
      Add a few items in the WebKitTestRunner Skipped list. · 7528067d
      weinig@apple.com authored
      Rubber-stamped by Jon Honeycutt.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7528067d
    • ddkilzer@apple.com's avatar
      BUILD FIX: FrameLoaderClientQt.h should include ResourceError.h · b8558ff4
      ddkilzer@apple.com authored
      * WebCoreSupport/FrameLoaderClientQt.h: Include ResourceError.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8558ff4
    • ddkilzer@apple.com's avatar
      BUILD FIX: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled · 826c0281
      ddkilzer@apple.com authored
      Reviewed by Joseph Pecoraro.
      
      * plugins/PluginView.cpp: Added #if ENABLE(NETSCAPE_PLUGIN_API)
      and #endif macros around the source to fix the Qt Linux Release
      Minimal build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      826c0281
    • aroben@apple.com's avatar
      Send mouse events to windowless plugins on Windows · baa8e645
      aroben@apple.com authored
      This seems to have been the last issue blocking us from playing videos
      on vimeo.com.
      
      Fixes <http://webkit.org/b/44276> <rdar://problem/8330398> Can't click
      play button in vimeo.com Flash video player in WebKit2 on Windows
      
      Reviewed by Sam Weinig.
      
      * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
      (WebKit::toNP): Added. Converts a WebMouseEvent to an NPEvent. Code
      was adapted from WebCore's PluginViewWin.cpp.
      
      (WebKit::NetscapePlugin::platformHandleMouseEvent):
      (WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
      (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
      Convert the WebMouseEvent to an NPEvent and send it to the plugin.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa8e645
    • aroben@apple.com's avatar
      Add support for painting windowless plugins on Windows · 2c233b84
      aroben@apple.com authored
      This gets the video on the front page of vimeo.com painting (though
      you can't make it play because we don't support mouse events yet).
      
      Fixes <http://webkit.org/b/44274> <rdar://problem/8330398> Windowless
      plugins don't paint in WebKit2 on Windows
      
      Reviewed by Sam Weinig.
      
      * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
      (WebKit::NPN_GetValue): Tell the plugin that we support windowless
      mode on Windows.
      (WebKit::NPN_SetValue): Implemented handling of NPPVpluginWindowBool
      by calling through to NetscapePlugin::setIsWindowed.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::NetscapePlugin): Added initialization of
      m_isWindowed. It defaults to false on Mac and true on other platforms,
      matching WebCore's PluginView.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.h: Added m_isWindowed.
      (WebKit::NetscapePlugin::setIsWindowed): Added standard setter.
      
      * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
      (WebKit::NetscapePlugin::platformPaint): Moved Mac-specific context
      translation code here from PluginView::paint.
      
      * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
      (WebKit::NetscapePlugin::platformPaint): Implemented. Code was ported
      from WebCore's PluginViewWin.cpp.
      
      * WebProcess/Plugins/Plugin.h: Updated the comment for Plugin::paint
      to explain the coordinate system of the context.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::paint): Changed to translate the context from
      document to window coordinates. We were previously trying to translate
      to plugin-local coordinates, but this only worked for documents whose
      origin was the same as the window's origin (i.e., the main frame). The
      plugin takes care of any further translations needed. (Mac translates
      the context into plugin-local coordinates, and Windows leaves it in
      window coordinates.)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c233b84
    • aroben@apple.com's avatar
      Implement PluginInfoStore::pluginsDirectories · 542573ee
      aroben@apple.com authored
      This makes WebKit2 able to find and load Flash on Windows.
      
      Note that we aren't yet respecting the MozillaPlugins registry key.
      That's covered by <http://webkit.org/b/44271>.
      
      Fixes <http://webkit.org/b/43510> <rdar://problem/8273827> WebKit2
      should load plugins from the same directories as old-WebKit
      
      Reviewed by Jon Honeycutt and Ada Chan.
      
      * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
      (WebKit::parseVersionString):
      (WebKit::compareVersions):
      (WebKit::safariPluginsDirectory):
      (WebKit::addMozillaPluginDirectories):
      (WebKit::addWindowsMediaPlayerPluginDirectory):
      (WebKit::addQuickTimePluginDirectory):
      (WebKit::addAdobeAcrobatPluginDirectory):
      (WebKit::addMacromediaPluginDirectories):
      (WebKit::PluginInfoStore::pluginsDirectories):
      Ported (and ever-so-slightly cleaned up) code from WebCore's
      PluginDatabaseWin.cpp.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542573ee
    • aroben@apple.com's avatar
      Call NP_GetEntryPoints before NP_Initialize on Windows · e49e92ba
      aroben@apple.com authored
      Doing otherwise will cause Flash and QuickTime to crash inside
      NP_Initialize.
      
      Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
      NP_Initialize when loading QuickTime when running
      plugins/embed-attributes-setting.html in WebKit2 on Windows
      
      Reviewed by Sam Weinig.
      
      WebKit2:
      
      * WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
      (WebKit::NetscapePluginModule::tryLoad): On Windows, first call
      NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
      prevent Silverlight (e.g.) from crashing (see r38858).
      
      WebKitTools:
      
      Test that NP_Initialize and NP_GetEntryPoints are called in the
      correct order
      
      The order differs between Mac and Windows (see r38858).
      
      * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
      a boolean to record whether NP_GetEntryPoints has been called.
      (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
      called yet. This matches Flash and QuickTime's behavior. Crash on Mac
      if NP_GetEntryPoints has been called already. This matches
      Silverlight's behavior.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e49e92ba
    • aroben@apple.com's avatar
      Add NetscapePluginWin.cpp · 08217cf6
      aroben@apple.com authored
      Fixes <http://webkit.org/b/44269> <rdar://problem/8330391>
      NetscapePlugin.h contains functions that should be in
      NetscapePluginWin.cpp
      
      Reviewed by Sam Weinig.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.h: Moved functions from
      here...
      * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: ...to here.
      
      * win/WebKit2.vcproj: Added NetscapePluginWin.cpp and let VS reorder
      the file list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08217cf6
    • aroben@apple.com's avatar
      Make build-webkittestrunner build TestNetscapePlugIn on Windows · 26e053e1
      aroben@apple.com authored
      Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
      
      Reviewed by Sam Weinig.
      
      * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
      Threaded it in between ImageDiff and InjectedBundleGenerated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26e053e1
    • senorblanco@chromium.org's avatar
      2010-08-19 Stephen White <senorblanco@chromium.org> · 243caa23
      senorblanco@chromium.org authored
              Reviewed by Kenneth Russell.
      
              [CHROMIUM] Assert w/canvas image draw
              https://bugs.webkit.org/show_bug.cgi?id=44279
      
              Don't use bitmap->pixelRef()->getPixels() directly; prefer
              bitmap->pixels() and an SkAutoLockPixels.  Also, make sure to set
              the backing store state to Software when it was None.  This handles
              missing draws when the first call is software.  Finally, remove some
              spurious prepareForSoftwareDraw() calls in addPath() and beginPath().
              It's really the fillPath() or strokePath() that matters.
      
              Covered by LayoutTests/fast/canvas/arc360.html and others.
      
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::GraphicsContext::addPath):
              (WebCore::GraphicsContext::beginPath):
              Remove spurious prepareForSoftwareDraw() calls.
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::drawBitmapGLES2):
              Lock SkBitmap's pixels, and use ->getPixels().
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
              Switch backing store state to Software when it was None.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243caa23
    • weinig@apple.com's avatar
      Add modifier key info to policy client functions in WebKit2 · 831f35b6
      weinig@apple.com authored
      <rdar://problem/8185298>
      https://bugs.webkit.org/show_bug.cgi?id=44280
      
      Reviewed by Adam Roben.
      
      * UIProcess/API/C/WKAPICast.h:
      Add conversion function for modifiers and rename an incorrectly named
      toWK to toRef.
      
      * UIProcess/API/C/WKPage.h:
      Add WKEventModifiers enum.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveMessage):
      (WebKit::WebPageProxy::decidePolicyForNavigationAction):
      (WebKit::WebPageProxy::decidePolicyForNewWindowAction):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPolicyClient.cpp:
      (WebKit::WebPolicyClient::decidePolicyForNavigationAction):
      (WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
      * UIProcess/WebPolicyClient.h:
      Pipe through modifier info.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::modifiersForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      Get modifier info out of the NavigationInfo class in the same manner as
      WebKit1.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      831f35b6
    • andreas.kling@nokia.com's avatar
      2010-08-19 Andreas Kling <andreas.kling@nokia.com> · 27c09964
      andreas.kling@nokia.com authored
              Reviewed by Geoffrey Garen.
      
              JSC: Move the static_cast into to(U)Int32 fast case
              https://bugs.webkit.org/show_bug.cgi?id=44037
      
              Do the static_cast<(u)int32_t> inline to avoid the function call overhead
              for easily converted values (within (u)int32_t range.)
      
              * runtime/JSValue.cpp:
              (JSC::toInt32SlowCase):
              (JSC::toUInt32SlowCase):
              * runtime/JSValue.h:
              (JSC::JSValue::toInt32):
              (JSC::JSValue::toUInt32):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27c09964
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled · f270d94c
      ddkilzer@apple.com authored
      Reviewed by Joseph Pecoraro.
      
      WebCore:
      
      * WebCore.exp.in:
      (WebCore::HTMLPlugInElement::getNPObject): Moved from general
      section into ENABLE(NETSCAPE_PLUGIN_API) section.
      (WebCore::FrameView::windowClipRectForLayer): Moved from
      ENABLE(NETSCAPE_PLUGIN_API) section to general section since
      it's used by WebKit2.
      * plugins/PluginView.h: Added #if ENABLE(NETSCAPE_PLUGIN_API)
      and #endif macros as needed to make iOS WebKit build with
      NETSCAPE_PLUGIN_API disabled.
      * plugins/PluginViewNone.cpp: Ditto.
      (WebCore::PluginView::platformGetValueStatic):
      
      WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
      USE(PLUGIN_HOST_PROCESS) to
      USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
      * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
      * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
      * Plugins/Hosted/ProxyInstance.mm: Ditto.
      * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
      * WebCoreSupport/WebChromeClient.mm: Ditto.
      (WebChromeClient::createWindow):
      * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
      (WebFrameLoaderClient::dispatchCreatePage):
      * WebView/WebHTMLView.mm:
      (needsCursorRectsSupportAtPoint): Added #if
      ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
      * WebView/WebView.mm:
      (+[WebView _isNodeHaltedPlugin:]): Ditto.
      (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
      (+[WebView _restartHaltedPluginForNode:]): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f270d94c
    • ojan@chromium.org's avatar
      2010-08-19 Ojan Vafai <ojan@chromium.org> · 07237edd
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              install rietveld's upload script from a versioned url
              https://bugs.webkit.org/show_bug.cgi?id=44291
      
              autoinstall expects the file at a given URL to never change.
              In order to be able to update the file, we need to be able to
              change the path.
      
              * Scripts/webkitpy/thirdparty/__init__.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07237edd
    • johnnyg@google.com's avatar
      2010-08-19 John Gregg <johnnyg@google.com> · 66d0c1b3
      johnnyg@google.com authored
              Unreviewed, chromium test expectations.
      
              Add expected failures for caret-based pixel tests.  See bug 44290.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66d0c1b3
    • ojan@chromium.org's avatar
      2010-08-19 Ojan Vafai <ojan@chromium.org> · 20a2a355
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              add --webkit_patch_id to reitveld uploads
              https://bugs.webkit.org/show_bug.cgi?id=44289
      
              This is the first step in having rietveld store which
              patches have been uploaded and getting rid of the
              in-rietveld flag.
      
              * Scripts/webkitpy/common/net/rietveld.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/postcodereview.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20a2a355
    • johnnyg@google.com's avatar
      2010-08-19 John Gregg <johnnyg@google.com> · de39621b
      johnnyg@google.com authored
              Unreviewed, chromium rebaselines.
      
              Add new baselines after http://trac.webkit.org/changeset/65665/ 
      
              * platform/chromium-linux/svg/custom/pattern-rotate-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/pattern-rotate-expected.png: Added.
              * platform/chromium-linux/svg/transforms: Added.
              * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
              * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
              * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
              * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
              * platform/chromium-win/svg/custom/pattern-rotate-expected.checksum:
              * platform/chromium-win/svg/custom/pattern-rotate-expected.png:
              * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
              * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
              * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
              * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
              * platform/chromium/test_expectations.txt
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de39621b
    • eric@webkit.org's avatar
      2010-08-16 Eric Seidel <eric@webkit.org> · 0cea84ca
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Make DocumentParser safer to use
              https://bugs.webkit.org/show_bug.cgi?id=43055
      
              This also includes a test from
              https://bugs.webkit.org/show_bug.cgi?id=42099
      
              These tests were kindly provided by Nate Chapin and Adam Barth.
      
              * fast/frames/document-write-in-iframe-onload-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
              * fast/frames/document-write-in-iframe-onload.html: Added.
              * fast/frames/resources/set-src-to-javascript-url.html: Added.
              * fast/frames/set-parent-src-synchronously-expected.txt: Added.
              * fast/frames/set-parent-src-synchronously.html: Added.
              * fast/parser/document-close-iframe-load-expected.txt: Added.
              * fast/parser/document-close-iframe-load.html: Added.
              * fast/parser/document-close-nested-iframe-load-expected.txt: Added.
              * fast/parser/document-close-nested-iframe-load.html: Added.
              * fast/parser/iframe-sets-parent-to-javascript-url-expected.txt: Added.
              * fast/parser/iframe-sets-parent-to-javascript-url.html: Added.
              * fast/parser/resources/set-parent-to-javascript-url.html: Added.
      2010-08-17  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Make DocumentParser safer to use
              https://bugs.webkit.org/show_bug.cgi?id=43055
      
              Make DocumentParser and its subclasses RefCounted, and protect
              HTMLDocumentParser during parsing. It's possible for a parser to
              get deleted if certain actions (e.g., a document.write()) occur
              synchronously.
      
              The original version of this patch was written by Nate Chapin.
      
              DocumentParser doesn't actually have to be fully RefCounted, since
              the only two things which should ever hold a reference to it are
              Document and DocumentParser itself.  However using RefCounted and
              RefPtr was easier/cleaner than inventing a custom ref() scheme.
      
              This deploys a new "detach()" method throughout the parsing
              framework.  detach() causes the parser to disconnect from the
              document so that no further modifications will be made to the
              document while any possible DocumentParser stacks are unwound.
      
              The irony of this patch is that the new detach() system is never
              used, since Document always outlives the DocumentParser in all of
              our layout tests.  There is an ASSERT in ~Document() to verify
              that the DocumentParser will not outlive the Document.
      
              However I expect that we will soon either find new test cases, or change
              the architecture in such a way that DocumentParser will outlive
              Document.  At which point, the detach() plumbing will be crucial.
              Right now detach() serves as a safe-guard against use-after-free bugs
              for any case where DocumentParser does outlive the Document.
      
              This also fixes test cases attached to:
              https://bugs.webkit.org/show_bug.cgi?id=42099
      
              Tests: fast/frames/document-write-in-iframe-onload.html
                     fast/frames/set-parent-src-synchronously.html
                     fast/parser/document-close-iframe-load.html
                     fast/parser/document-close-nested-iframe-load.html
                     fast/parser/iframe-sets-parent-to-javascript-url.html
      
              * dom/Document.cpp:
               - Added a new detachParser() call to be used anywhere we
                 used to call m_parser.clear().
                 There is an ASSERT in ~DocumentParser which ensures that
                 we get this right.
              (WebCore::Document::removedLastRef):
              (WebCore::Document::~Document):
              (WebCore::Document::createParser):
              (WebCore::Document::detachParser):
              (WebCore::Document::cancelParsing):
              (WebCore::Document::implicitOpen):
               - removed redundant m_parser.clear()
              (WebCore::Document::implicitClose):
              * dom/Document.h:
              * dom/DocumentParser.cpp:
              (WebCore::DocumentParser::~DocumentParser):
               - ASSERT that callers always call detach() before destruction.
               - This ASSERT might prove too cumbersome, but for now it's useful.
              (WebCore::DocumentParser::detach):
              * dom/DocumentParser.h:
              * dom/RawDataDocumentParser.h:
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::finish):
               - Add a FIXME explaining part of the reason why
                 stopParsing() and detach() are separate concepts.
              * dom/XMLDocumentParser.h:
              (WebCore::XMLDocumentParser::create):
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::XMLDocumentParser::parseDocumentFragment):
              * dom/XMLDocumentParserQt.cpp:
              (WebCore::XMLDocumentParser::parseDocumentFragment):
              * html/HTMLConstructionSite.cpp:
              (WebCore::HTMLConstructionSite::detach):
              (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
              * html/HTMLConstructionSite.h:
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::createParser):
              * html/HTMLDocument.h:
              * html/HTMLDocumentParser.cpp:
               - We need to protect(this) before calling into any code
                 which might cause the parser to be destroyed.
              (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
              (WebCore::HTMLDocumentParser::detach):
              (WebCore::HTMLDocumentParser::resumeParsingAfterYield):
              (WebCore::HTMLDocumentParser::pumpTokenizer):
              (WebCore::HTMLDocumentParser::insert):
              (WebCore::HTMLDocumentParser::append):
              (WebCore::HTMLDocumentParser::end):
              (WebCore::HTMLDocumentParser::finish):
              (WebCore::HTMLDocumentParser::notifyFinished):
              (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):
              (WebCore::HTMLDocumentParser::parseDocumentFragment):
              * html/HTMLDocumentParser.h:
              (WebCore::HTMLDocumentParser::create):
              * html/HTMLScriptRunner.cpp:
              (WebCore::HTMLScriptRunner::detach):
              (WebCore::HTMLScriptRunner::executeParsingBlockingScript):
              (WebCore::HTMLScriptRunner::executeScript):
              (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
              (WebCore::HTMLScriptRunner::runScript):
              * html/HTMLScriptRunner.h:
              * html/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::detach):
              (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
              (WebCore::HTMLTreeBuilder::finished):
              * html/HTMLTreeBuilder.h:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createParser):
              * html/HTMLViewSourceDocument.h:
              * html/HTMLViewSourceParser.cpp:
              (WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
              * html/HTMLViewSourceParser.h:
              (WebCore::HTMLViewSourceParser::create):
              * loader/FTPDirectoryDocument.cpp:
              (WebCore::FTPDirectoryDocumentParser::create):
              (WebCore::FTPDirectoryDocument::createParser):
              * loader/FTPDirectoryDocument.h:
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocumentParser::create):
              (WebCore::ImageDocumentParser::ImageDocumentParser):
              (WebCore::ImageDocument::createParser):
              * loader/ImageDocument.h:
              * loader/MediaDocument.cpp:
              (WebCore::MediaDocumentParser::create):
              (WebCore::MediaDocument::createParser):
              * loader/MediaDocument.h:
              * loader/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::create):
              (WebCore::PluginDocument::createParser):
              * loader/PluginDocument.h:
              * loader/SinkDocument.cpp:
              (WebCore::SinkDocumentParser::create):
              (WebCore::SinkDocument::createParser):
              * loader/SinkDocument.h:
              * loader/TextDocument.cpp:
              (WebCore::TextDocumentParser::create):
              (WebCore::TextDocument::createParser):
              (WebCore::createTextDocumentParser):
              * loader/TextDocument.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cea84ca
    • ddkilzer@apple.com's avatar
      Fix compilation of SelectElement.cpp with ARROW_KEYS_POP_MENU == 0 · 34a0f3d3
      ddkilzer@apple.com authored
      Reviewed by Simon Fraser.
      
      * dom/SelectElement.cpp:
      (WebCore::SelectElement::menuListDefaultEventHandler): Added
      UNUSED_PARAM() macro for htmlForm argument when
      ARROW_KEYS_POP_MENU defined as zero.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34a0f3d3
    • laszlo.1.gombos@nokia.com's avatar
      2010-08-19 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5ec2e864
      laszlo.1.gombos@nokia.com authored
              Reviewed by Simon Hausmann.
      
              [Qt] Disable XSLT for production configuration
              https://bugs.webkit.org/show_bug.cgi?id=37445
      
              Introduce a new CONFIG option to maintain stable configuration for
              the QtWebKit port and disable XSLT for the stable configuration
              because of bug 37445.
      
              No new tests as there is no new functionality.
      
              * features.pri:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ec2e864
    • zmo@google.com's avatar
      2010-08-18 Zhenyao Mo <zmo@google.com> · 02436edc
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Implement strict type checking in js bindings for WebGL functions
              https://bugs.webkit.org/show_bug.cgi?id=44202
      
              Test: fast/canvas/webgl/bad-arguments-test.html
      
              * bindings/js/JSWebGLRenderingContextCustom.cpp: Add type check for wrapper types and DOMString and throw error in case of mismatch.
              (WebCore::JSWebGLRenderingContext::getAttachedShaders):
              (WebCore::JSWebGLRenderingContext::getProgramParameter):
              (WebCore::JSWebGLRenderingContext::getShaderParameter):
              (WebCore::JSWebGLRenderingContext::getUniform):
              (WebCore::dataFunctionf):
              (WebCore::dataFunctioni):
              (WebCore::dataFunctionMatrix):
              * bindings/scripts/CodeGeneratorJS.pm: Ditto.
              * bindings/scripts/CodeGeneratorV8.pm: Ditto.
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Ditto.
              (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
              (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
              (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
              (WebCore::V8WebGLRenderingContext::getUniformCallback):
              (WebCore::vertexAttribAndUniformHelperf):
              (WebCore::uniformHelperi):
              (WebCore::uniformMatrixHelper):
              * html/canvas/WebGLRenderingContext.idl: Add attribute StrictTypeChecking for WebGL functions.
      2010-08-18  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Implement strict type checking in js bindings for WebGL functions
              https://bugs.webkit.org/show_bug.cgi?id=44202
      
              * fast/canvas/webgl/bad-arguments-test-expected.txt: Added.
              * fast/canvas/webgl/bad-arguments-test.html: Added.
              * fast/canvas/webgl/error-reporting-expected.txt: Fix bugs due to strict type checking in the js bindings.
              * fast/canvas/webgl/error-reporting.html: ditto.
              * fast/canvas/webgl/gl-object-get-calls-expected.txt: ditto.
              * fast/canvas/webgl/gl-object-get-calls.html: ditto.
              * fast/canvas/webgl/null-object-behaviour-expected.txt: ditto.
              * fast/canvas/webgl/null-object-behaviour.html: ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02436edc
    • commit-queue@webkit.org's avatar
      2010-08-19 Vincent Scheib <scheib@chromium.org> · 6561538a
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Fixing previous Mac only build breakage with TilingDataTest.cpp
              https://bugs.webkit.org/show_bug.cgi?id=44223
      
              TilingDataTest.cpp included the wrong header, which had a compile
              option around the definition of the WebCore namespace. Without the
              namespace defined, error. Fixed by correctly including TilingData.h,
              which has no conditional compilation.
      
              * WebKit.gyp:
              * tests/TilingDataTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6561538a
    • johnnyg@google.com's avatar
      2010-08-19 John Gregg <johnnyg@google.com> · 9a1c4d57
      johnnyg@google.com authored
              Unreviewed, test expectations.
      
              Add some new exceptions for SVG failures, see
              https://bugs.webkit.org/show_bug.cgi?id=44278
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a1c4d57
    • tony@chromium.org's avatar
      2010-08-19 Tony Chang <tony@chromium.org> · 24208a32
      tony@chromium.org authored
              Reviewed by Adam Barth.
      
              webkit-patch barfed on upload with a new image test result
              https://bugs.webkit.org/show_bug.cgi?id=39097
      
              * PrettyPatch/PrettyPatch.rb: don't use full path to git
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24208a32
    • kbr@google.com's avatar
      2010-08-19 Kenneth Russell <kbr@google.com> · fbd584b0
      kbr@google.com authored
              Reviewed by David Levin.
      
              Adjust my status from committer to reviewer
              https://bugs.webkit.org/show_bug.cgi?id=44277
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbd584b0
    • eric.carlson@apple.com's avatar
      2010-08-19 Eric Carlson <eric.carlson@apple.com> · 9886627d
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              https://bugs.webkit.org/show_bug.cgi?id=33671
              media/video-loop.html fails intermittently on GTK and Chromium bots
      
              Rewrite test to make it less timing dependent.
      
              * media/video-loop-expected.txt:
              * media/video-loop.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9886627d
    • simon.fraser@apple.com's avatar
      2010-08-19 Simon Fraser <simon.fraser@apple.com> · 372e5b18
      simon.fraser@apple.com authored
              Fix Chromium build.
      
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::attributeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      372e5b18
    • johnnyg@google.com's avatar
      2010-08-19 John Gregg <johnnyg@google.com> · a2c415e8
      johnnyg@google.com authored
              Unreviewed; test expectations.
      
              Update chromium-mac expectations for zoom-mask-with-percentages.svg after
              http://trac.webkit.org/changeset/65665/
      
              * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
              * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2c415e8