1. 20 Jan, 2011 40 commits
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, add a bug number to disabled test. · 693bdf5e
      dimich@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      693bdf5e
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · d366cc42
      dpranke@chromium.org authored
              Reviewed by Adam Barth.
      
              Disable the tests that start and stop the http server and web
              server, so that we don't have to worry about port collisions on
              the bots.
      
              https://bugs.webkit.org/show_bug.cgi?id=52861
      
              * Scripts/webkitpy/layout_tests/port/port_testcase.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d366cc42
    • mjs@apple.com's avatar
      2011-01-20 Maciej Stachowiak <mjs@apple.com> · 4f1e1c31
      mjs@apple.com authored
              Reviewed by Darin Adler.
      
              Skip some tests that are failing on the WebKit2 bot
              https://bugs.webkit.org/show_bug.cgi?id=52858
      
              * platform/mac-wk2/Skipped: skip or re-skip some tests that fail
              on the bot for various reasons.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f1e1c31
    • commit-queue@webkit.org's avatar
      2011-01-20 Ben Vanik <ben.vanik@gmail.com> · 2dd86016
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Implementation of the OES_standard_derivatives WebGL extension.
              https://bugs.webkit.org/show_bug.cgi?id=51678
      
              Changes are modeled off of the existing OESTextureFloat extension. New files,
              extension retrieval, etc all match the existing code.
      
              Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
              options. This supports the enabling of the standard derivatives flag when the
              extension is enabled. Refactored the cleanup code to make the destruction of the
              compilers (if they had been created) cleaner.
      
              Tested with the WebGL conformance test:
              https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
              Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.
      
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::toJS):
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::toV8Object):
              * html/canvas/OESStandardDerivatives.cpp: Added.
              (WebCore::OESStandardDerivatives::OESStandardDerivatives):
              (WebCore::OESStandardDerivatives::~OESStandardDerivatives):
              (WebCore::OESStandardDerivatives::getName):
              (WebCore::OESStandardDerivatives::create):
              * html/canvas/OESStandardDerivatives.h: Added.
              * html/canvas/OESStandardDerivatives.idl: Added.
              * html/canvas/WebGLExtension.h:
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension.
              (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled.
              (WebCore::WebGLRenderingContext::getSupportedExtensions):
              (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled.
              (WebCore::WebGLRenderingContext::getNumberOfExtensions):
              (WebCore::WebGLRenderingContext::getExtensionNumber):
              * html/canvas/WebGLRenderingContext.h:
              * platform/graphics/ANGLEWebKitBridge.cpp:
              (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup.
              (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers.
              (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing
              ANGLE settings.
              (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
              * platform/graphics/ANGLEWebKitBridge.h:
              (WebCore::ANGLEWebKitBridge::getResources):
              * platform/graphics/Extensions3D.h: Added enumeration for the extension.
              * platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
              * platform/graphics/opengl/Extensions3DOpenGL.cpp:
              (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the
              GraphicsContext3D to handle resetting the shader compilers.
              (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension,
              so always return true.
              (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
              * platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
              * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
              (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to
              Extensions3DOpenGL.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd86016
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · c6606872
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              nrwt: rewrite google_chrome_unittest to use mock filesystem.
      
              https://bugs.webkit.org/show_bug.cgi?id=52772
      
              * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6606872
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · 88aebec9
      dpranke@chromium.org authored
              Reviewed by Eric Siedel.
      
              nrwt: clean up almost all remaining port references, remove
              unnecessary import clauses. The only remaining references are
              in places where a mock filesystem makes no sense or can't be
              used, and in one routine in port/google_chrome_unittest that
              I'll rewrite in a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=52771
      
              * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
              * Scripts/webkitpy/layout_tests/port/google_chrome.py:
              * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
              * Scripts/webkitpy/layout_tests/port/gtk.py:
              * Scripts/webkitpy/layout_tests/port/mac.py:
              * Scripts/webkitpy/layout_tests/port/port_testcase.py:
              * Scripts/webkitpy/layout_tests/port/qt.py:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/port/win.py:
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88aebec9
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · c95578e8
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
      
              https://bugs.webkit.org/show_bug.cgi?id=52762
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c95578e8
    • jer.noble@apple.com's avatar
      Unreviewed Qt Skipped list update. · eb640587
      jer.noble@apple.com authored
      Skip the test added in r76296 for platform/qt/.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb640587
    • xji@chromium.org's avatar
      2011-01-20 Xiaomei Ji <xji@chromium.org> · 2ce4c298
      xji@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Fix regression(r71566): PDF in RTL block might messes up text directionality.
              https://bugs.webkit.org/show_bug.cgi?id=52776
      
              Test: fast/dom/52776.html
      
              * platform/text/BidiResolver.h:
              (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
              (WebCore::::lowerExplicitEmbeddingLevel):
              (WebCore::::raiseExplicitEmbeddingLevel):
              (WebCore::::createBidiRunsForLine):
      2011-01-20  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Fix regression(r71566): PDF in RTL block might messes up text directionality.
              https://bugs.webkit.org/show_bug.cgi?id=52776
      
              * fast/dom/52776.html: Added.
              * platform/mac/fast/dom/52776-expected.checksum: Added.
              * platform/mac/fast/dom/52776-expected.png: Added.
              * platform/mac/fast/dom/52776-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ce4c298
    • bdakin@apple.com's avatar
      Follow-on for <rdar://problem/8890255> · 95928e5d
      bdakin@apple.com authored
      Reviewed by Anders Carlsson.
      
      This fixes a painting error with ScrollbarPainter scrollers
      and the new drawing area code path.
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::updateArrowPlacement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95928e5d
    • dimich@chromium.org's avatar
      [chromium] Updating test expectations after fixing the bug: · 5afc29f2
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52062
      
      Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
      Reviewed by Dmitry Titov.
      
      * platform/chromium/test_expectations.txt:
      iframe-reparenting-plugins.html is now passing on Windows.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5afc29f2
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · a26e4bd5
      tony@chromium.org authored
              Unreviewed, rebaseline a test added in
              http://trac.webkit.org/changeset/76274
      
              * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
              * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
              * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
              * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a26e4bd5
    • leviw@chromium.org's avatar
      2011-01-20 Levi Weintraub <leviw@chromium.org> · d13be1f6
      leviw@chromium.org authored
              Unreviewed.
      
              Fixing build breakage.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::willBeModified):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d13be1f6
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · 283857fa
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] fix the paths used for the rebaseline tool
              https://bugs.webkit.org/show_bug.cgi?id=52857
      
              Some of the bots were renamed so the path to grab the results zip
              file has changed.
      
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      283857fa
    • commit-queue@webkit.org's avatar
      2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com> · d1eadbfe
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
              https://bugs.webkit.org/show_bug.cgi?id=52835
      
              * WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1eadbfe
    • leviw@chromium.org's avatar
      2011-01-20 Levi Weintraub <leviw@chromium.org> · bd727b85
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
              https://bugs.webkit.org/show_bug.cgi?id=49511
      
              Test: editing/selection/rtl-move-selection-right-left.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::willBeModified):
              Respecting the direction of the containing block when switching selection base and extent in
              RTL content.
      
              (WebCore::SelectionController::modifyMovingRight):
              (WebCore::SelectionController::modifyMovingLeft):
              Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
              correct thing for RTL.
      2011-01-20  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
              https://bugs.webkit.org/show_bug.cgi?id=49511
      
              * editing/editing.js:
              (execMoveSelectionLeftByCharacterCommand):
              (moveSelectionLeftByCharacterCommand):
              (execMoveSelectionRightByCharacterCommand):
              (moveSelectionRightByCharacterCommand):
              (execExtendSelectionLeftByCharacterCommand):
              (extendSelectionLeftByCharacterCommand):
              (execExtendSelectionRightByCharacterCommand):
              (extendSelectionRightByCharacterCommand):
              Adding some left/right selection convenience methods for use with RTL tests.
      
              * editing/selection/rtl-move-selection-right-left-expected.txt: Added.
              * editing/selection/rtl-move-selection-right-left.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd727b85
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · 9cd83e7d
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              Fix bug introduced in r72688 / bug 52768 that broke the
              generation of the output filename links in the results.html
              output. Apparently none of the unit tests actually checked to
              make sure the generated links were correct :(
      
              https://bugs.webkit.org/show_bug.cgi?id=52854
      
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cd83e7d
    • ojan@chromium.org's avatar
      2011-01-20 Ojan Vafai <ojan@chromium.org> · 3a5dae87
      ojan@chromium.org authored
              Reviewed by Oliver Hunt.
      
              Could review tool include style failure info?
              https://bugs.webkit.org/show_bug.cgi?id=49049
      
              This does not handle patches that have old paths (e.g. without the Source prefix).
              Although that would be fairly straightforward to workaround.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a5dae87
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · c020c2bc
      tony@chromium.org authored
              Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c020c2bc
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 02315226
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=52849
              Make window.print work with WebKit2
      
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPage::QWKPage):
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::printFrame):
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.messages.in:
              * UIProcess/WebUIClient.cpp:
              (WebKit::WebUIClient::printFrame):
              * UIProcess/WebUIClient.h:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::print):
              Just pass through deelagte call to a WebKit2 client.
      
              * UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function
              types.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02315226
    • andersca@apple.com's avatar
      2011-01-20 Anders Carlsson <andersca@apple.com> · f51f2f8a
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Keep track of the latest update timestamp in the backing store
              https://bugs.webkit.org/show_bug.cgi?id=52848
      
              * Shared/UpdateInfo.h:
              (WebKit::UpdateInfo::UpdateInfo):
              Initialize timestamp to 0.
      
              * UIProcess/BackingStore.cpp:
              (WebKit::BackingStore::BackingStore):
              Initialize m_latestUpdateTimestamp to 0.
      
              (WebKit::BackingStore::incorporateUpdate):
              If the update is too old, discard it. Otherwise, create a bitmap
              and pass it to platformIncorporateUpdate. Finally update the timestamp.
      
              * UIProcess/BackingStore.h:
              Add m_latestUpdateTimestamp.
      
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::platformIncorporateUpdate):
              Update now that we are already given the shareable bitmap.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f51f2f8a
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · 8462c352
      tony@chromium.org authored
              Unreviewed, chromium test expectation updates.
      
              * platform/chromium-gpu/test_expectations.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8462c352
    • japhet@chromium.org's avatar
      2011-01-20 Nate Chapin <japhet@chromium.org> · 2aa1491b
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=52769.
      
              * fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
              * fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
              * fast/dom/Window/Location/set-location-after-close.html: Added.
      2011-01-20  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Adam Barth.
      
              Null-check m_frame in DOMWindow::setLocation(), since it's
              possible to reach this point without it having been checked
              already.
              https://bugs.webkit.org/show_bug.cgi?id=52769
      
              Test: fast/dom/Window/Location/set-location-after-close.html
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2aa1491b
    • ojan@chromium.org's avatar
      2011-01-20 Ojan Vafai <ojan@chromium.org> · 89140b20
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              handle cases where PrettyPatch.rb doesn't linkify filenames
              https://bugs.webkit.org/show_bug.cgi?id=52834
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89140b20
    • chang.shu@nokia.com's avatar
      2011-01-20 Chang Shu <chang.shu@nokia.com> · a73b559f
      chang.shu@nokia.com authored
              Reviewed by Darin Adler.
      
              setContentEditable with invalid string should throw exception.
              https://bugs.webkit.org/show_bug.cgi?id=52057
      
              Updated expected results after the fix. Also corrected test cases.
      
              * editing/editability/set-invalid-value-expected.txt:
              * editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
              * editing/editability/set-value-caseinsensitive-expected.txt:
              * editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
              * fast/dom/element-attribute-js-null-expected.txt:
              * fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.
      2011-01-20  Chang Shu  <chang.shu@nokia.com>
      
              Reviewed by Darin Adler.
      
              setContentEditable with invalid string should throw exception.
              https://bugs.webkit.org/show_bug.cgi?id=52057
      
              Implemented exception throwing for setContentEditable according to the following spec:
              http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
              Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
              string 'inherit' then the content attribute must be removed, if the new value is an ASCII
              case-insensitive match for the string 'true' then the content attribute must be set to the
              string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
              then the content attribute must be set to the string 'false', and otherwise the attribute
              setter must raise a SYNTAX_ERR exception."
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
              * html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
              * html/HTMLElement.idl: Add exception throwing support for contentEditable setter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a73b559f
    • sullivan@apple.com's avatar
      Shift-tab doesn't cycle through fields in http authentication panel · 2c5dbcb8
      sullivan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52850
      
      Reviewed by Mark Rowe.
      
      * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
      * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
      Re-wired the key loop so that there aren't two views with the same nextKeyView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c5dbcb8
    • enne@google.com's avatar
      2011-01-20 Adrienne Walker <enne@google.com> · f95de30a
      enne@google.com authored
              Reviewed by James Robinson.
      
              [chromium] Add a test for a render surface that the uses alpha channel.
              https://bugs.webkit.org/show_bug.cgi?id=52766
      
              * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
              * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
              * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
              * platform/chromium/compositing/render-surface-alpha-blending.html: Added.
      2011-01-19  Adrienne Walker  <enne@google.com>
      
              Reviewed by James Robinson.
      
              [chromium] Composited render surfaces should allow writes to alpha channel.
              https://bugs.webkit.org/show_bug.cgi?id=52766
      
              Test: LayoutTests/platform/chromium/compositing
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::drawLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f95de30a
    • commit-queue@webkit.org's avatar
      2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com> · 760a8d1a
      commit-queue@webkit.org authored
              Reviewed by Geoffrey Garen.
      
              [Symbian] Fix StackBounds::initialize()
              https://bugs.webkit.org/show_bug.cgi?id=52842
      
              * wtf/StackBounds.cpp:
              (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760a8d1a
    • jer.noble@apple.com's avatar
      2011-01-14 Jer Noble <jer.noble@apple.com> · f0000a8e
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              REGRESSION (r71842): Compass video is not playing in Safari welcome page
              https://bugs.webkit.org/show_bug.cgi?id=52506
      
              Test that a delay between loading and playing video does not break playback.
      
              * media/video-currentTime-delay-expected.txt: Added.
              * media/video-currentTime-delay.html: Added.
      2011-01-14  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              REGRESSION (r71842): Compass video is not playing in Safari welcome page
              https://bugs.webkit.org/show_bug.cgi?id=52506
      
              New test: LayoutTests/media/video-currentTime-delay.html
      
              Call invalidateCachedTime() every time one of the cached property dependencies changes,
              i.e. m_paused and m_playbackRate.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::prepareForLoad):
              (WebCore::HTMLMediaElement::setReadyState):
              (WebCore::HTMLMediaElement::setPlaybackRate):
              (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0000a8e
    • weinig@apple.com's avatar
      Fix build. · 4f5eeeb8
      weinig@apple.com authored
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f5eeeb8
    • commit-queue@webkit.org's avatar
      2011-01-20 Adam Klein <adamk@chromium.org> · 1c713369
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [chromium] Remove deprecated WebKit::nameOfInputElement function
              https://bugs.webkit.org/show_bug.cgi?id=52824
      
              * src/DOMUtilitiesPrivate.cpp:
              * src/DOMUtilitiesPrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c713369
    • weinig@apple.com's avatar
      Fix build. · c156846c
      weinig@apple.com authored
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c156846c
    • bdakin@apple.com's avatar
      Fix for <rdar://problem/8890255> · f76bd26b
      bdakin@apple.com authored
      Reviewed by Geoffrey Garen.
      
      Source/WebCore: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebCore.exp.in:
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::scrollbarMap):
      (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
      (WebCore::ScrollbarThemeMac::registerScrollbar):
      (WebCore::ScrollbarThemeMac::unregisterScrollbar):
      (WebCore::ScrollbarThemeMac::paint):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      
      Source/WebKit/mac: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f76bd26b
    • weinig@apple.com's avatar
      Cleanup Scrollbar/ScrollbarClient relationship · 2a13aa81
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52779
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore: 
      
      Pipe all scrolling through the ScrollbarClient/ScrollAnimator
      rather than through the Scrollbar. The Scrollbar now is just
      a "view" on the scroll position of the scrollable area it is
      attached to.
      
      There are now two ways to scroll a scrollable area:
      - ScrollbarClient::scroll()
      - ScrollbarClient::scrollToOffsetWithoutAnimation()
      
      Both of these go through the ScrollAnimator (updating its state
      or starting an animation). The ScrollAnimator, in turn, now calls
      ScrollbarClient::setScrollOffsetFromAnimation, which tells the
      Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
      and tells the class that derives from ScrollbarClient to scroll
      its contents (via ScrollbarClient::setScrollOffset).
      
      * WebCore.xcodeproj/project.pbxproj:
      Move Scrollbar.cpp to the right place.
      
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::setValue):
      Initiate the scroll through the scrollbar client, rather than the
      scrollbar itself.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollTo):
      * page/FrameView.h:
      Condense the two valueChanged overrides to a single override of the
      scrollTo function.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::scroll):
      (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimator::currentPosition):
      (WebCore::ScrollAnimator::notityPositionChanged):
      * platform/ScrollAnimator.h:
      * platform/ScrollAnimatorWin.cpp:
      (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorWin::animateScroll):
      * platform/ScrollAnimatorWin.h:
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
      and bottleneck all client notification of changed position through a new
      notityPositionChanged() function.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setScrollOffset):
      (WebCore::ScrollView::scrollTo):
      (WebCore::ScrollView::scrollPosition):
      (WebCore::ScrollView::scroll):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      (WebCore::ScrollView::horizontalScrollbar):
      (WebCore::ScrollView::verticalScrollbar):
      Update to scroll via the ScrollbarClient rather than the Scrollbar.
      
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::offsetDidChange):
      (WebCore::Scrollbar::autoscrollPressedPart):
      (WebCore::Scrollbar::moveThumb):
      (WebCore::Scrollbar::mouseMoved):
      * platform/Scrollbar.h:
      (WebCore::Scrollbar::setPressedPos):
      Change the scrollbar to only updates its offset in response to
      an offsetDidChange call.
      
      * platform/ScrollbarClient.cpp:
      (WebCore::ScrollbarClient::scroll):
      (WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
      * platform/ScrollbarClient.h:
      (WebCore::ScrollbarClient::horizontalScrollbar):
      (WebCore::ScrollbarClient::verticalScrollbar):
      Make the increasingly misnamed ScrollbarClient responsible for
      scrolling.
      
      * platform/efl/ScrollbarEfl.cpp:
      (scrollbarEflEdjeMessage):
      * platform/gtk/MainFrameScrollbarGtk.cpp:
      (MainFrameScrollbarGtk::gtkValueChanged):
      * platform/qt/ScrollbarQt.cpp:
      (WebCore::Scrollbar::contextMenu):
      Update to move scrolling through the client.
      
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::scrollToRevealSelection):
      (WebCore::PopupMenuWin::scrollPosition):
      (WebCore::PopupMenuWin::setScrollOffset):
      (WebCore::PopupMenuWin::scrollTo):
      (WebCore::PopupMenuWin::wndProc):
      * platform/win/PopupMenuWin.h:
      (WebCore::PopupMenuWin::verticalScrollbar):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset):
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::setScrollOffset):
      (WebCore::RenderLayer::scrollPosition):
      (WebCore::RenderLayer::updateScrollInfoAfterLayout):
      (WebCore::RenderLayer::scroll):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
      (WebCore::RenderListBox::scroll):
      (WebCore::RenderListBox::logicalScroll):
      (WebCore::RenderListBox::scrollPosition):
      (WebCore::RenderListBox::setScrollOffset):
      (WebCore::RenderListBox::scrollTo):
      (WebCore::RenderListBox::setScrollTop):
      * rendering/RenderListBox.h:
      (WebCore::RenderListBox::verticalScrollbar):
      Update to scroll via the ScrollbarClient rather than the Scrollbar.
      
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::start):
      Simplify initial paint to just do an immediate scroll to the position.
      
      Source/WebKit/chromium: 
      
      * src/WebScrollbarImpl.cpp:
      (WebKit::WebScrollbarImpl::WebScrollbarImpl):
      (WebKit::WebScrollbarImpl::value):
      (WebKit::WebScrollbarImpl::setValue):
      (WebKit::WebScrollbarImpl::scroll):
      (WebKit::WebScrollbarImpl::onMouseDown):
      (WebKit::WebScrollbarImpl::onMouseMove):
      (WebKit::WebScrollbarImpl::onMouseWheel):
      (WebKit::WebScrollbarImpl::onKeyDown):
      (WebKit::WebScrollbarImpl::scrollPosition):
      (WebKit::WebScrollbarImpl::setScrollOffset):
      * src/WebScrollbarImpl.h:
      
      Source/WebKit/qt: 
      
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      Source/WebKit/win: 
      
      * WebScrollBar.cpp:
      (WebScrollBar::WebScrollBar):
      (WebScrollBar::setValue):
      (WebScrollBar::value):
      (WebScrollBar::scroll):
      (WebScrollBar::scrollPosition):
      (WebScrollBar::setScrollOffset):
      * WebScrollBar.h:
      
      Source/WebKit2: 
      
      * UIProcess/win/WebPopupMenuProxyWin.cpp:
      (WebKit::WebPopupMenuProxyWin::scrollPosition):
      (WebKit::WebPopupMenuProxyWin::setScrollOffset):
      (WebKit::WebPopupMenuProxyWin::scrollTo):
      (WebKit::WebPopupMenuProxyWin::onMouseWheel):
      (WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
      * UIProcess/win/WebPopupMenuProxyWin.h:
      (WebKit::WebPopupMenuProxyWin::verticalScrollbar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a13aa81
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · c673baa3
      rniwa@webkit.org authored
              Unreviewed Chromium test expectations fix.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c673baa3
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · 31faaa36
      tony@chromium.org authored
              Unreviewed, another attempt at making the chromium gpu tests go green.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31faaa36
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · b219bee0
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
      
              https://bugs.webkit.org/show_bug.cgi?id=52756
      
              * Scripts/webkitpy/layout_tests/layout_package/printing.py:
              * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b219bee0
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · 0fa1a50d
      jamesr@google.com authored
              Update expectations for tests that need chromium-side changes.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa1a50d
    • commit-queue@webkit.org's avatar
      2011-01-20 Mansi Mithal <mansi.mithal@nokia.com> · 80024169
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              QtTestBrowser should have a seperate menu for Settings
              https://bugs.webkit.org/show_bug.cgi?id=52817
      
              Added a new menu item named "Settings"
              and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::createChrome):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80024169
    • andersca@apple.com's avatar
      2011-01-20 Anders Carlsson <andersca@apple.com> · 42abed10
      andersca@apple.com authored
              Reviewed by Adam Roben.
      
              Add a timestamp to UpdateInfo
              https://bugs.webkit.org/show_bug.cgi?id=52844
      
              * Shared/UpdateInfo.cpp:
              (WebKit::UpdateInfo::encode):
              (WebKit::UpdateInfo::decode):
              * Shared/UpdateInfo.h:
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::setSize):
              (WebKit::DrawingAreaImpl::display):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42abed10