Commits · 692e06e431be79de375930a57894597bac2f0375 · App_Technologies / webkit

01 Oct, 2006 6 commits

2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com> · 692e06e4

ap authored Oct 01, 2006

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
        REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

        No test case added (probably requires new DumpRenderTree functionality)

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged): Added early return if the document is
        being destroyed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

692e06e4

Reviewed by Hyatt. · 932806a9

ap authored Oct 01, 2006

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
        REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
        
        Make sure we only break after a space (and not any other valid line-break) if
        the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
        I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
        twice in quick succession.

        Test: fast/text/line-breaks-after-white-space.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak): 



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

932806a9

Fixed Bugzilla references in ChangeLogs for my previous commit. · 243119ad

ap authored Oct 01, 2006


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

243119ad

Reviewed by Maciej and Darin. · 08a32007

ap authored Oct 01, 2006

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
        JavaScript document.write page form does not submit in Safari

        Test: fast/forms/document-write.html

        * page/Frame.cpp:
        (WebCore::Frame::submitForm): Don't check for parsing().



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

08a32007

Build fix. · 17258d39

ap authored Oct 01, 2006

        * bridge/mac/FrameViewMac.mm: Add missing #imports.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17258d39

Refactor the code that sends the mouse down to scrollbars. · d9530b4c

hyatt authored Oct 01, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d9530b4c

30 Sep, 2006 9 commits

Reviewed by Darin. · ce5ff2a9

weinig authored Sep 30, 2006

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
        Add more SVG Objective-C DOM bindings

        - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
          DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
          DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
          DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
          DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
          DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAElement.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedPoints.idl:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/svg/SVGAnimationElement.idl:
        * ksvg2/svg/SVGCircleElement.idl:
        * ksvg2/svg/SVGClipPathElement.idl:
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGCursorElement.idl:
        * ksvg2/svg/SVGDefsElement.idl:
        * ksvg2/svg/SVGDescElement.idl:
        * ksvg2/svg/SVGDocument.idl:
        * ksvg2/svg/SVGEllipseElement.idl:
        * ksvg2/svg/SVGPointList.idl:
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRect.idl:
        * ksvg2/svg/SVGSVGElement.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ce5ff2a9

Reviewed by Adele. · 97b567ff

mjs authored Sep 30, 2006

        - fix build

        * platform/FloatRect.h:
        (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
        but more appropriate for path-type stuff.
        * platform/cg/PathCG.cpp:
        (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97b567ff

Reviewed by Darin. · e08cbe85

ap authored Sep 30, 2006

        http://bugs.webkit.org/show_bug.cgi?id=11011
        External CSS is parsed as iso-8859-1 even though the main document is utf-8

        Test: fast/encoding/css-charset-default.xhtml

        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setCSSStyleSheet):
        (WebCore::CachedResourceClient::setXSLStyleSheet):
        Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
        takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet):
        (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
        * css/CSSImportRule.h:

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/CSSStyleSheet.h:
        Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
        member. Changed some String parameters to const String&.

        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::StyleSheet):
        * css/StyleSheet.h:
        Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::length):
        (WebCore::StyleSheetList::item):
        * css/StyleSheetList.h:
        Special-casing implicit stylesheets seemed to be dead code, removed.

        * dom/Document.cpp:
        (WebCore::Document::setCSSStyleSheet):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Renamed setStyleSheet() to setCSSStyleSheet().

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        (WebCore::ProcessingInstruction::setXSLStyleSheet):
        (WebCore::ProcessingInstruction::parseStyleSheet):
        * dom/ProcessingInstruction.h:

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
        is not specified.
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLLinkElement.h:

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        Inherit URL and charset from the document.

        * loader/Cache.cpp:
        (WebCore::Cache::requestCSSStyleSheet):
        * loader/Cache.h:
        Adjust for setStyleSheet() renaming.

        * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::deref):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        Pass the encoding to setCSSStyleSheet().

        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::ref):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestCSSStyleSheet):
        * loader/DocLoader.h:
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
        (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet):
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLImportRule.h:
        Adjust for setStyleSheet() renaming.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e08cbe85

Reviewed by eseidel. · 1f4fa6e6

rwlbuis authored Sep 30, 2006

http://bugs.webkit.org/show_bug.cgi?id=11096
Hit testing for polylines fails

Fix Path::contains so it handles filled, non-closed paths too.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1f4fa6e6

Fix win32. · 17fef4eb

hyatt authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17fef4eb

Revert minimum font size pref back to 1. · 9d119447

hyatt authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d119447

Fix win32 bustage caused by a typo. · 17e4dd91

hyatt authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17e4dd91

Fix mac bustage in FrameMac.mm and FrameViewMac.mm · 73068cc5

hyatt authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

73068cc5

Event refactoring. · 3ee17e4a

hyatt authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3ee17e4a

29 Sep, 2006 25 commits

Reviewed by Adele. · 9f2e4b67

adele authored Sep 30, 2006

        Fixes windows bustage:
        http://bugs.webkit.org/show_bug.cgi?id=11093

        * platform/win/PlatformScrollBar.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):
        (ScrollBar::ScrollBar):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9f2e4b67

Bug 11041: fast/dom/isindex-001 needs new results · 17a576b5

thatcher authored Sep 30, 2006

        http://bugs.webkit.org/show_bug.cgi?id=11041

        * fast/dom/isindex-001-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17a576b5

Change the default minimum font size pref to 0 in order to allow · cd308316

hyatt authored Sep 30, 2006

        font-size:0 to work.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cd308316

Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit · 6ba8ab79

hyatt authored Sep 30, 2006

        in RenderObject::NodeInfo (and then propagating that Widget to
        MouseEventWithHitTestResults).

        This allows RenderListBox and RenderBlock to do the same thing when the
        mouse is over the scrollbar.

        Also land fix to support font-size: 0.

        Reviewed by mjs (scrollbar), eric (font-size)

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent):
        * page/Frame.cpp:
        (WebCore::Frame::passWidgetMouseDownEventToWidget):
        * page/FrameView.cpp:
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::dispatchMouseEvent):
        * page/MouseEventWithHitTestResults.cpp:
        (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
        * page/MouseEventWithHitTestResults.h:
        (WebCore::MouseEventWithHitTestResults::scrollbar):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isPointInScrollbar):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::getHiddenBehavior):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::isPointInScrollbar):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::NodeInfo::NodeInfo):
        (WebCore::RenderObject::NodeInfo::scrollbar):
        (WebCore::RenderObject::NodeInfo::setScrollbar):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6ba8ab79

Reviewed by Adele. · 12628dc4

adele authored Sep 30, 2006

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::convertToContainingWindow):
        (WebCore::ScrollView::convertFromContainingWindow):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::convertToContainingWindow):
        (WebCore::Widget::convertFromContainingWindow):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12628dc4

Updated with new argument for PlatformScrollBar. · 110cc417

adele authored Sep 30, 2006

        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

110cc417

Build fix. · 7663ef27

thatcher authored Sep 30, 2006

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7663ef27

Reviewed by Hyatt. · 7a4fb4c3

adele authored Sep 29, 2006

        Fixing build bustage with cast to int.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7a4fb4c3

Fixing accidental include. · 897ffad4

adele authored Sep 29, 2006

        * rendering/RenderListBox.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

897ffad4

Adding RenderListBox files. · f520b80e

adele authored Sep 29, 2006

 


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f520b80e

Fixing typo. No problem in the ned. Just the end. · 4f09628e

bdakin authored Sep 29, 2006


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4f09628e

Reviewed by Adam. · f989049f

adele authored Sep 29, 2006

        Initial implementation of engine-based list box control.

        * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp

        * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
        * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
        (WebCore::FrameMac::FrameMac):
        (WebCore::FrameMac::handleMousePressEvent):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::mouseDown):

        * page/Frame.cpp:
        (WebCore::Frame::handleMouseMoveEvent):
        (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
        (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
        (WebCore::Frame::autoscrollTimerFired): ditto.
        (WebCore::Frame::stopAutoscrollTimer): ditto.
        (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
        * page/Frame.h:
        * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.

        * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::currentMousePosition):
        (WebCore::FrameView::handleMousePressEvent):
        (WebCore::FrameView::handleMouseDoubleClickEvent):
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::handleMouseReleaseEvent):
        * page/FrameView.h:

        * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
        * platform/ScrollBar.h:
        (WebCore::):
        (WebCore::ScrollBar::controlSize):
        * platform/mac/PlatformScrollBar.h:
        * platform/mac/PlatformScrollBarMac.mm:
        (NSControlSizeForScrollBarControlSize):
        (-[WebCoreScrollBar initWithPlatformScrollBar:]):
        (WebCore::PlatformScrollBar::PlatformScrollBar):

        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shouldAutoscroll):
        (WebCore::RenderObject::autoscroll):
        * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):

        * css/html4.css: Added properties for new list boxes.

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
        (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
        * html/HTMLOptionElement.h: Added disabled method.

        * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::lastSelectedListIndex):
        (WebCore::HTMLSelectElement::deselectItems):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::isKeyboardFocusable):
        (WebCore::HTMLSelectElement::isMouseFocusable):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
        (WebCore::HTMLSelectElement::nextSelectableListIndex):
        (WebCore::HTMLSelectElement::previousSelectableListIndex):
        * html/HTMLSelectElement.h:

        * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::supportsFocusRing):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

        * rendering/RenderListBox.cpp: Added.
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::setStyle):
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::calcMinMaxWidth):
        (WebCore::RenderListBox::size):
        (WebCore::RenderListBox::numItems):
        (WebCore::RenderListBox::calcHeight):
        (WebCore::RenderListBox::baselinePosition):
        (WebCore::RenderListBox::itemBoundingBoxRect):
        (WebCore::RenderListBox::paintObject):
        (WebCore::RenderListBox::paintScrollbar):
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        (WebCore::RenderListBox::scrollBarTarget):
        (WebCore::RenderListBox::isPointInScrollbar):
        (WebCore::RenderListBox::optionAtPoint):
        (WebCore::RenderListBox::autoscroll):
        (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
        (WebCore::RenderListBox::scroll):
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderListBox.h: Added.
        (WebCore::RenderListBox::isListBox):
        (WebCore::RenderListBox::selectionChanged):
        (WebCore::RenderListBox::setSelectionChanged):
        (WebCore::RenderListBox::canHaveChildren):
        (WebCore::RenderListBox::renderName):
        (WebCore::RenderListBox::setOptionsChanged):
        (WebCore::RenderListBox::shouldAutoscroll):
        (WebCore::RenderListBox::listIndexIsVisible):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f989049f

Reviewed by Darin. · 9d05e15f

bdakin authored Sep 29, 2006

        We had a bug where html4.css was ignoring Media Queries. In the ned 
        the problem was that we were trying to send a char* to the 
        MediaQueryEvaluator constructor that expects a String, but the 
        char* got interpreted as a bool, the wrong constructor was called, 
        and the media type was never set.

        No test case possible since this only affects html4.css

        * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
        char*
        (WebCore::MediaQueryEvaluator):
        * css/MediaQueryEvaluator.h: Same.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d05e15f

LayoutTests: · eb140e63

ggaren authored Sep 29, 2006

Reviewed by John, Maciej.

Added test for whether a frame element reports its src attribute as a
complete, rather than relative, URL.

* fast/frames/frame-src-attribute-expected.txt: Added.
* fast/frames/frame-src-attribute.html: Added.
* fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

Reviewed by John, Maciej.

Integrated some frame and iframe code. I'm trying to fix up frame ownership
and loading. Reducing the number of different code paths involved
seemed like a good first step.

As a side effect, I fixed a bug where FRAME elements would report their
src attributes as relative, rather than compelete, URLs. (IFRAME elements
had the correct complete URL behavior.)

* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
(WebCore::HTMLFrameElement::openURL):
(1) Removed checks that requestFrame does for us
(2) Added isURLAllowed check, to have one clear bottleneck for it
(3) Added viewsource check, to have one clear bottleneck for it
(WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
method, instead of finding our content frame in our own unique way.
(WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
since openURL does this for us now.
(WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
This is what FF does, and it made no sense to have different behaviors
for FRAME and IFRAME elements.
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
code.
* html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
HTMLFrameElement now does everything we need.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

eb140e63

Reviewed by Hyatt. · 3fbe04f4

rwlbuis authored Sep 29, 2006

        Fix Qt/Linux build.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3fbe04f4

Replace bugzilla.opendarwin.org with bugs.webkit.org. · 61b29d73