1. 05 May, 2008 15 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 692743d4
      justin.garcia@apple.com authored
      2008-05-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
      
              <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
              
              Disable Range mutation on document modifications in Tiger and Leopard Mail,
              since they do their own mutation which interferes with ours.
      
              * WebCore.base.exp:
              * dom/Document.cpp:
              (WebCore::Document::nodeChildrenChanged):
              (WebCore::Document::nodeWillBeRemoved):
              (WebCore::Document::textInserted):
              (WebCore::Document::textRemoved):
              (WebCore::Document::textNodesMerged):
              (WebCore::Document::textNodeSplit):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::disableRangeMutationForOldAppleMail):
              * page/Settings.h:
              (WebCore::Settings::rangeMutationDisabledForOldAppleMail):
      
      WebKit/mac:
      
      2008-05-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
              
              <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
      
              * WebView/WebView.mm:
              (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
              the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
              the two interfere.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692743d4
    • weinig@apple.com's avatar
      WebCore: · 9d3827a7
      weinig@apple.com authored
      2008-05-05  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Tim Hatcher.
      
              Make the Inspector's localizable strings file match the format used by Dashboard widgets.
      
              * English.lproj/InspectorLocalizedStrings.js: Removed.
              * English.lproj/localizedStrings.js: Added.
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * page/inspector/inspector.js:
      
      WebKit/mac:
      
      2008-05-05  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Tim Hatcher.
      
              Make the Inspector's localizable strings file match the format used by Dashboard widgets.
      
              * WebCoreSupport/WebInspectorClient.mm:
              (WebInspectorClient::localizedStringsURL):
      
      WebKit/win:
      
      2008-05-05  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Tim Hatcher.
      
              Make the Inspector's localizable strings file match the format used by Dashboard widgets.
      
              * WebCoreSupport/WebInspectorClient.cpp:
              (WebInspectorClient::localizedStringsURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d3827a7
    • sfalken@apple.com's avatar
      2008-05-05 Steve Falkenburg <sfalken@apple.com> · 14e9c0b4
      sfalken@apple.com authored
              Add WebPreference for application chrome mode.
              
              Reviewed by Dave Hyatt.
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::inApplicationChromeMode):
              (WebPreferences::setApplicationChromeMode):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      
      2008-05-05  Steve Falkenburg  <sfalken@apple.com>
      
              Add support for default button appearance.
              Add WebCore setting for app chrome mode.
              
              Reviewed by Dave Hyatt.
      
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              * css/CSSValueKeywords.in: Added default-button value keyword.
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setApplicationChromeMode):
              * page/Settings.h:
              (WebCore::Settings::inApplicationChromeMode):
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::RenderButton):
              (WebCore::RenderButton::setStyle):
              (WebCore::RenderButton::timerFired):
              * rendering/RenderButton.h:
              * rendering/RenderStyle.h:
              (WebCore::):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::adjustStyle):
              (WebCore::RenderTheme::paint):
              (WebCore::RenderTheme::paintBorderOnly):
              (WebCore::RenderTheme::paintDecorations):
              (WebCore::RenderTheme::isControlStyled):
              (WebCore::RenderTheme::isDefault):
              * rendering/RenderTheme.h:
              (WebCore::):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::determineState):
              (WebCore::RenderThemeSafari::adjustRepaintRect):
              (WebCore::RenderThemeSafari::adjustButtonStyle):
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::supportsFocus):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14e9c0b4
    • adele@apple.com's avatar
      2008-05-05 Adele Peterson <adele@apple.com> · 0188433f
      adele@apple.com authored
              Reviewed by Adam.
      
              Look for the right ImageDiff executable for debug builds.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0188433f
    • ap@webkit.org's avatar
      Reviewed by Darin. · 095e1f6b
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=11947
              nbsps should be converted to entities in innerHTML
      
              https://bugs.webkit.org/show_bug.cgi?id=18769
              replacing &nbsp; with spaces using regexp creates inconsistent result
      
              Tests: fast/dom/innerHTML-nbsp.html
                     fast/dom/innerHTML-escaping-attribute.html
      
              * editing/markup.cpp:
              (WebCore::appendAttributeValue):
              (WebCore::escapeContentText):
              (WebCore::appendEscapedContent):
              Added U+00a0/nbsp to the list of characters to escape.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      095e1f6b
    • hyatt@apple.com's avatar
      WebCore: · 3cb88e1a
      hyatt@apple.com authored
      2008-05-05  David Hyatt  <hyatt@apple.com>
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.
      
              Reviewed by Eric
      
              New tests added in fast/canvas/
      
              * platform/graphics/cg/ImageBufferCG.cpp:
              (WebCore::ImageBuffer::getImageData):
              (WebCore::ImageBuffer::putImageData):
      
      LayoutTests:
      
      2008-05-05  David Hyatt  <hyatt@apple.com>
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.
      
              Reviewed by Eric
      
              * fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
              * fast/canvas/canvas-alphaImageData-behavior.html: Added.
              * fast/canvas/canvas-alphaImageData-behavior.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cb88e1a
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · 0fa4ee57
      darin@apple.com authored
              Reviewed by John Sullivan.
      
              - fix debug-only leak seen on buildbot
      
              * wtf/HashTable.h:
              (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
              deleted value on top of it, call the destructor so the empty value doesn't leak.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa4ee57
    • andersca@apple.com's avatar
      2008-05-05 Anders Carlsson <andersca@apple.com> · 2980bb5a
      andersca@apple.com authored
              Reviewed by Jess.
      
              Apparently preflighting can cause hangs for some reason. Revert this for now.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage _initWithPath:]):
              * Plugins/WebPluginPackage.m:
              (-[WebPluginPackage initWithPath:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2980bb5a
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · 8454f02d
      darin@apple.com authored
              * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
              leak tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8454f02d
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · eb1d25fa
      darin@apple.com authored
              Reviewed by Mitz.
      
              - https://bugs.webkit.org/show_bug.cgi?id=18789
                fix some shouldCloseWithWindow edge cases
      
              * WebView/WebView.mm:
              (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
              NSWindowWillCloseNotification if the view was moved out of the window but still
              had that window set as the host window. Also make sure this function doesn't do
              anything if the WebView is already closed.
              (-[WebView setHostWindow:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb1d25fa
    • mitz@apple.com's avatar
      Rubber-stamped by Adam Roben. · fcc46237
      mitz@apple.com authored
              - fix test failure due to Windows' preference for Mac results over
                generic results
      
              * platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcc46237
    • mitz@apple.com's avatar
      WebCore: · cd6deb7d
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=18809
                Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
      
              Test: fast/block/basic/adding-near-anonymous-block.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::addChildToFlow): When adding a floating or
              positioned object, if it follows an anonymous block, put it
              inside the anonymous block. When adding an inline, check if it comes
              after an anonymous block and put it in the anonymous block.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809
                Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
      
              * fast/block/basic/adding-near-anonymous-block.html: Added.
              * media/video-controls-rendering.html: Changed to work around
              https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this
              test in its original form.
              * platform/mac/css1/box_properties/clear-expected.txt:
              * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
              * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
              * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
              * platform/mac/fast/forms/input-align-image-expected.txt:
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/video-controls-rendering-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6deb7d
    • antti@apple.com's avatar
      2008-05-05 Antti Koivisto <antti@apple.com> · f0dc5ade
      antti@apple.com authored
              Reviewed by Darin.
      
              Speculative fix for <rdar://problem/5906790> 
              Crash in Loader::servePendingRequests() due to hash table being modified during iteration
              
              I don't know how to reproduce this. It would require the load to fail (or succeed)
              synchronously, something that should not usually happen.
      
              * loader/loader.cpp:
              (WebCore::Loader::Loader):
              (WebCore::Loader::load):
              (WebCore::Loader::servePendingRequests):
              (WebCore::Loader::cancelRequests):
              (WebCore::Loader::Host::Host):
              * loader/loader.h:
              (WebCore::Loader::Host::name):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0dc5ade
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · ed762a03
      hausmann@webkit.org authored
      In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
      tests expect to be 480x360)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed762a03
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · 1ce02397
      hausmann@webkit.org authored
      Disable SVG As Image support in the Qt port again, as it
      requires more work. Right now the chrome client is
      assumed to be a ChromeClientQt, which the SVG Image support
      changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce02397
  2. 04 May, 2008 9 commits
  3. 03 May, 2008 6 commits
  4. 02 May, 2008 10 commits
    • andersca@apple.com's avatar
      WebCore: · 2601b732
      andersca@apple.com authored
      2008-05-02  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Mark.
      
              Turns out calling locationInWindow on keyboard events will not throw an exception,
              but the point returned is completely bogus, so remove coordinates from the keyboard event struct.
              
              * bridge/npapi.h:
              (_NPCocoaEvent::):
      
      WebKit/mac:
      
      2008-05-02  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Mark.
      
              Various Cocoa event model and 64-bit plug-in fixes.
              
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
              (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
              Set click count.
              
              (WebNetscapePluginEventHandlerCocoa::flagsChanged):
              (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
              Don't try to get the mouse location for keyboard events.
              
              * Plugins/WebPluginPackage.m:
              (-[WebPluginPackage initWithPath:]):
              Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2601b732
    • andersca@apple.com's avatar
      2008-05-02 Anders Carlsson <andersca@apple.com> · db0ed043
      andersca@apple.com authored
              Reviewed by Mark.
      
              Add an "x86_64" make rule.
              
              * Makefile.shared:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db0ed043
    • alp@webkit.org's avatar
      2008-05-02 Benjamin Otte <otte@gnome.org> · daef1936
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=18856
              [GTK] variable initialization missing
      
              Not initializing the m_needsXEmbed variable could have very funny
              results. Most often those results would be crashes.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::PluginView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daef1936
    • alp@webkit.org's avatar
      2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com> · d06c7c97
      alp@webkit.org authored
              Reviewed by Eric.
      
              https://bugs.webkit.org/show_bug.cgi?id=18811
              Enable dashboard and offline web apps in autotools
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d06c7c97
    • ap@webkit.org's avatar
      Reviewed by Geoffrey Garen. · 7f250f84
      ap@webkit.org authored
              Get rid of static data in nodes.cpp (well, at least of non-debug one).
      
              No measurable change on SunSpider.
      
              * kjs/InitializeThreading.cpp:
              (KJS::initializeThreadingOnce):
              * kjs/nodes.cpp:
              (KJS::newTrackedObjects):
              (KJS::trackedObjectExtraRefCounts):
              (KJS::initializeNodesThreading):
              (KJS::ParserRefCounted::ParserRefCounted):
              (KJS::ParserRefCounted::ref):
              (KJS::ParserRefCounted::deref):
              (KJS::ParserRefCounted::refcount):
              (KJS::ParserRefCounted::deleteNewObjects):
              * kjs/nodes.h:
              Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f250f84
    • andersca@apple.com's avatar
      WebCore: · 8cd7f654
      andersca@apple.com authored
      2008-05-02  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              Name the event union so it will work in plain C.
      
              * bridge/npapi.h:
              (_NPCocoaEvent::):
      
      WebKit/mac:
      
      2008-05-02  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              The event union is now named.
              
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
              (WebNetscapePluginEventHandlerCocoa::drawRect):
              (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
              (WebNetscapePluginEventHandlerCocoa::flagsChanged):
              (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
              (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
              (WebNetscapePluginEventHandlerCocoa::focusChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cd7f654
    • andersca@apple.com's avatar
      2008-05-02 Anders Carlsson <andersca@apple.com> · 1aafb665
      andersca@apple.com authored
              Reviewed by Mark.
      
              Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
              
              Call preflightAndReturnError on the bundle, which will check if any of the architectures
              in the bundle match the current architecture.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage _initWithPath:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aafb665
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6b40fecd
      ap@webkit.org authored
              Move call stack depth counter to global object.
      
              * kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to
              per-thread data.
              * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
              * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.
      
              * kjs/object.cpp:
              (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now
              the only thing in JSObject::call that needs a PIC branch.
              (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth
              tracking.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b40fecd
    • mitz@apple.com's avatar
      Reviewed by Adam Roben. · c68fbd48
      mitz@apple.com authored
              - add an option to svn-apply to set the reviewer name in change logs
      
              * Scripts/svn-apply: Added a [-r|--reviewer name] option.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c68fbd48
    • mitz@apple.com's avatar
      WebCore: · b74d5ba6
      mitz@apple.com authored
              Reviewed by John Sullivan.
      
              - render text shadows with zero offset, as the shadow can be seen behind
                the text if the text is translucent
      
              Test: fast/text/shadow-no-blur.html
      
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the
              shadow offset. Since isEmpty() is also true for sizes that have one or
              more non-positive components, this also ensures that subpixel
              antialiasing of the text is maintained with shadows in all directions.
              (WebCore::Font::drawGlyphs): Ditto.
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs): Ditto.
      
      LayoutTests:
      
              Reviewed by John Sullivan.
      
              - add pixel test for text shadows with zero blur and various offsets,
                including zero offset
      
              * fast/text/shadow-no-blur.html: Added.
              * platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
              * platform/mac/fast/text/shadow-no-blur-expected.png: Added.
              * platform/mac/fast/text/shadow-no-blur-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b74d5ba6