1. 29 Apr, 2010 40 commits
    • agl@chromium.org's avatar
      2010-04-29 Adam Langley <agl@chromium.org> · 69191bba
      agl@chromium.org authored
              Reviewed by David Levin.
      
              This patch adds support for WOFF in Chromium. Since Chromium
              already transcodes all OpenType files for security reasons we
              are adding WOFF support into the transcoder.
      
              https://bugs.webkit.org/show_bug.cgi?id=38217
      
              * css/CSSFontFaceSrcValue.cpp:
              (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
                Recognise "woff" as a font-face format value (guarded by
                ENABLE(OPENTYPE_SANITIZER) at this point)
              * platform/graphics/opentype/OpenTypeSanitizer.cpp:
              (WebCore::OpenTypeSanitizer::sanitize):
                Change so that the transcoded font can be larger than the original.
                (WOFF files are compressed, so the transcoded TTF is typically
                larger.)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69191bba
    • eric@webkit.org's avatar
      2010-04-29 Alex Milowski <alex@milowski.com> · 40acaa9b
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Updates to the Qt build to enable building MathML support.
      
              * WebCore.pri:
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40acaa9b
    • zherczeg@webkit.org's avatar
      Add sqrt() instruction support for ARM assembler (using VFP) · fa3e921d
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38312
      
      Reviewed by Oliver Hunt
      
      * assembler/ARMAssembler.h:
      (JSC::ARMAssembler::):
      (JSC::ARMAssembler::fsqrtd_r):
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerARM::sqrtDouble):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa3e921d
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · 49b16110
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Test webkit_dom_document_get_element_by_id;
      
              * tests/testdomdocument.c:
              (test_dom_document_get_element_by_id):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49b16110
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · 351dddf8
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Test webkit_dom_document_get_elements_by_class_name.
      
              * tests/testdomdocument.c:
              (test_dom_document_get_elements_by_class_name):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      351dddf8
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · 58ee8354
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Test webkit_dom_document_get_elements_by_tag_name.
      
              * tests/testdomdocument.c:
              (test_dom_document_get_elements_by_tag_name):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58ee8354
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · 32967cee
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Add WebKitDOMDocument tests to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2010-04-29  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Move WebKitDOMDocument unit tests to their own file.
      
              * tests/testdomdocument.c: Added.
              (finish_loading):
              (dom_document_fixture_setup):
              (dom_document_fixture_teardown):
              (test_dom_document_title):
              (main):
              * tests/testwebview.c:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32967cee
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · 5144b6a6
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Do not generate unneeded boilerplate in {get,set}_property methods
              when there are no properties to generate code for. This gets rid
              of lots of compiler warnings.
      
              * bindings/scripts/CodeGeneratorGObject.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5144b6a6
    • xan@webkit.org's avatar
      2010-04-29 Xan Lopez <xlopez@igalia.com> · bf955f6a
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] GObject DOM bindings
              https://bugs.webkit.org/show_bug.cgi?id=33590
      
              Include <webkit/webkitdom.h> in the main webkit.h header.
      
              * webkit/webkit.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf955f6a
    • ossy@webkit.org's avatar
      [Qt] Loading of large page can take up to 10 seconds · d122366e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31719
      
      Rubber-stamped by Simon Hausmann.
      
      Followup patch. Update expected files because of minor differences.
      (size of whitespaces, place of linebreaks)
      
      * platform/qt/css1/basic/inheritance-expected.txt:
      * platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
      * platform/qt/css1/box_properties/float_margin-expected.txt:
      * platform/qt/css1/color_and_background/background_attachment-expected.txt:
      * platform/qt/css1/color_and_background/background_repeat-expected.txt:
      * platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
      * platform/qt/css1/font_properties/font-expected.txt:
      * platform/qt/css1/font_properties/font_style-expected.txt:
      * platform/qt/css1/formatting_model/inline_elements-expected.txt:
      * platform/qt/css1/text_properties/line_height-expected.txt:
      * platform/qt/css1/text_properties/text_decoration-expected.txt:
      * platform/qt/css1/text_properties/text_indent-expected.txt:
      * platform/qt/css1/text_properties/vertical_align-expected.txt:
      * platform/qt/css2.1/t1202-counter-01-b-expected.txt:
      * platform/qt/css2.1/t1202-counter-02-b-expected.txt:
      * platform/qt/css2.1/t1202-counter-03-b-expected.txt:
      * platform/qt/css2.1/t1202-counter-04-b-expected.txt:
      * platform/qt/css2.1/t1202-counters-01-b-expected.txt:
      * platform/qt/css2.1/t1202-counters-02-b-expected.txt:
      * platform/qt/css2.1/t1202-counters-03-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
      * platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
      * platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
      * platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
      * platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
      * platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
      * platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
      * platform/qt/fast/backgrounds/size/zero-expected.txt:
      * platform/qt/fast/css/font-face-opentype-expected.txt:
      * platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt:
      * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
      * platform/qt/fast/text/fake-italic-expected.txt:
      * platform/qt/fast/text/international/khmer-selection-expected.txt:
      * platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
      * platform/qt/svg/filters/feColorMatrix-values-expected.txt:
      * platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
      * platform/qt/svg/text/selection-background-color-expected.txt:
      * platform/qt/svg/text/selection-doubleclick-expected.txt:
      * platform/qt/svg/text/selection-styles-expected.txt:
      * platform/qt/svg/text/selection-tripleclick-expected.txt:
      * platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
      * platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d122366e
    • ossy@webkit.org's avatar
      [Qt] Speed up text layouting · dbebc64e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31719
      
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-04-29
      Reviewed by Kenneth Rohde Christiansen.
      
      Use QFontMetrics::width() for the text width calculation instead
      of QTextLayout. This avoids expensive bearing calculations and the
      line breaking code.
      
      * platform/graphics/qt/FontQt.cpp:
      (WebCore::Font::floatWidthForComplexText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbebc64e
    • eric@webkit.org's avatar
      2010-04-29 Kwang Yul Seo <skyul@company100.net> · b611f00e
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [WINCE] Export g_stackBase with JS_EXPORTDATA
              https://bugs.webkit.org/show_bug.cgi?id=37437
      
              Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.
      
              * platform/wince/SharedTimerWince.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b611f00e
    • tkent@chromium.org's avatar
    • eric@webkit.org's avatar
      2010-04-29 Adam Barth <abarth@webkit.org> · 6b3b179f
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Remove custom bindings for PopStateEvent.initPopStateEvent
              https://bugs.webkit.org/show_bug.cgi?id=38311
      
              Our code generation of SerializedScriptValue was slightly buggy, but
              it's easy to fix.  Notice that the conversion to an atomic string is
              handled by the C++ type system and doesn't require logic in the code
              generator.
      
              * bindings/js/JSPopStateEventCustom.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
              (webkit_dom_test_obj_serialized_value):
              * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::):
              (WebCore::jsTestObjPrototypeFunctionSerializedValue):
              * bindings/scripts/test/JS/JSTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj serializedValue:]):
              * bindings/scripts/test/TestObj.idl:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::serializedValueCallback):
              (WebCore::ConfigureV8TestObjTemplate):
              * bindings/v8/custom/V8PopStateEventCustom.cpp:
              * dom/PopStateEvent.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b3b179f
    • eric@webkit.org's avatar
      2010-04-29 Eric Seidel <eric@webkit.org> · 5e08f6d9
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              new-run-webkit-tests can deadlock with Chromium's TestShell
              https://bugs.webkit.org/show_bug.cgi?id=38298
      
              Fix _write_command_and_read_line to never send unicode() to
              test_shell, instead to always encode as utf-8.  This was causing
              random hangs because if test_shell ever encounters a \0 in the
              stream it can deadlock with NRWT.
      
              There is still a deadlock bug to fix in NRWT/test_shell design, however
              this fix should make the deadlock occur less often.
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e08f6d9
    • tkent@chromium.org's avatar
      2010-04-29 Kent Tamura <tkent@chromium.org> · c8834896
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Fix a bug that selection drag-and-drop doesn't work for input/textarea.
              https://bugs.webkit.org/show_bug.cgi?id=38175
      
              * editing/pasteboard/drag-drop-input-textarea-expected.txt: Added.
              * editing/pasteboard/drag-drop-input-textarea.html: Added.
      2010-04-29  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix a bug that selection drag-and-drop doesn't work for input/textarea.
              https://bugs.webkit.org/show_bug.cgi?id=38175
      
              The code supposed the selected region was in the destination text
              field. It is not true in a case of drag-and-drop.
      
              Test: editing/pasteboard/drag-drop-input-textarea.html
      
              * dom/InputElement.cpp:
              (WebCore::InputElement::handleBeforeTextInsertedEvent):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8834896
    • eric@webkit.org's avatar
      2010-04-29 Adam Barth <abarth@webkit.org> · 71cb2ae7
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Remove custom bindings for NodeFilter.acceptNode
              https://bugs.webkit.org/show_bug.cgi?id=38309
      
              This "custom" code was just an instance of the CallWith=ScriptState
              pattern.  Also, it looks like V8 just had a garbage implemenation that
              did nothing.
      
              * WebCore.gypi:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
              * dom/NodeFilter.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71cb2ae7
    • eric@webkit.org's avatar
      2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com> · a2ea118f
      eric@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] QtWebkit doesn't link with 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=38299
      
              Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.
      
              No new tests: build fix
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::isGLES2Compliant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2ea118f
    • zimmermann@webkit.org's avatar
      2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com> · 2377f83d
      zimmermann@webkit.org authored
              Rubber-stamped by Maciej Stachowiak.
      
              Add missing pixel test results for several tests on Mac. Now doesn't create any new files anymore, when running run-webkit-tests -p.
      
              * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Added.
              * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
              * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Added.
              * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.png: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.checksum: Added.
              * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
              * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Added.
              * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Added.
              * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Added.
              * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Added.
              * platform/mac/fast/media/media-query-invalid-value-expected.checksum: Added.
              * platform/mac/fast/media/media-query-invalid-value-expected.png: Added.
              * platform/mac/fast/runin/generated2-expected.checksum: Added.
              * platform/mac/fast/runin/generated2-expected.png: Added.
              * platform/mac/fast/runin/generated3-expected.checksum: Added.
              * platform/mac/fast/runin/generated3-expected.png: Added.
              * platform/mac/fast/runin/generated4-expected.checksum: Added.
              * platform/mac/fast/runin/generated4-expected.png: Added.
              * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.checksum: Added.
              * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2377f83d
    • eric@webkit.org's avatar
      2010-04-29 Rafael Weinstein <rafaelw@chromium.org> · 4720a5c2
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Include WindowFeatures in call to WebViewClient::createView.
      
              https://bugs.webkit.org/show_bug.cgi?id=38301
      
              * public/WebViewClient.h:
              (WebKit::WebViewClient::createView):
              * public/WebWindowFeatures.h:
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4720a5c2
    • hausmann@webkit.org's avatar
      Remove unnecessary call to FrameView::forceLayout() in setViewportSize() · 4e7bf3ac
      hausmann@webkit.org authored
      This prevents a double relayout on resize.
      
      Patch by Andreas Kling <andreas.kling@nokia.com> on 2010-04-29
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=38179
      
      Thanks to Nate Whetsell <nathan.whetsell@gmail.com> for spotting this.
      
      * Api/qwebpage.cpp:
      (QWebPage::setViewportSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e7bf3ac
    • eric@webkit.org's avatar
      2010-04-29 Garret Kelly <gdk@chromium.org> · 5482b57c
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Expose the RuntimeFeature for touch events through the
              WebRuntimeFeatures mechanism.
              https://bugs.webkit.org/show_bug.cgi?id=37486
      
              * public/WebRuntimeFeatures.h:
              * src/WebRuntimeFeatures.cpp:
              (WebKit::WebRuntimeFeatures::enableTouch):
              (WebKit::WebRuntimeFeatures::isTouchEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5482b57c
    • cjerdonek@webkit.org's avatar
      Refactored svn-apply and svn-unapply to use the new · 21256f77
      cjerdonek@webkit.org authored
      parsePatch() subroutine.
      
      Reviewed by Eric Seidel.
      
      https://bugs.webkit.org/show_bug.cgi?id=34033
      
      * Scripts/VCSUtils.pm:
        - Consolidated %diffHash documentation.
        - Added prepareParsedPatch().
      
      * Scripts/svn-apply:
        - Replaced main while loop with calls to parsePatch() and
          prepareParsedPatch().
      
      * Scripts/svn-unapply:
        - Replaced main while loop with calls to parsePatch() and
          prepareParsedPatch().
      
      * Scripts/test-webkitperl:
        - Changed to render relative test paths rather than absolute
          test paths.
      
      * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
        - Added unit tests for prepareParsedPatch().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21256f77
    • eric@webkit.org's avatar
      2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> · faaccfaf
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Refactor qtscriptglobal.h
              https://bugs.webkit.org/show_bug.cgi?id=37953
      
              Use the same pattern in qtscriptglobal.h as in
              qwebkitglobal.h without checking for specific OSs.
      
              * qt/api/qtscriptglobal.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faaccfaf
    • hausmann@webkit.org's avatar
      [Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails · e5f7f9a1
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38316
      
      Reviewed by Tor Arne Vestbø.
      
      Accessing properties of a deleted objects doesn't throw an exception
      anymore.
      
      Continue to expose the QObject class wrapper for objects that
      previously existed but don't exist anymore. QtClass is safe to
      use with a deleted QObject.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::getClass): Return null only if m_class
      doesn't exist yet and there's no m_object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5f7f9a1
    • eric@webkit.org's avatar
      2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com> · 78cfdd4e
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Reverse animations don't work in some use cases
              https://bugs.webkit.org/show_bug.cgi?id=38075
      
              This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
              with the CA implementation. That special case code path is now a bug - and this patch removes it.
      
              http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
              animation correctly.
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::TransformAnimationQt::applyFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78cfdd4e
    • ukai@chromium.org's avatar
      Unreviewed, test expectations update. · b18106f2
      ukai@chromium.org authored
      * platform/chromium/test_expectations.txt: fast/media/media-query-invalid-value.html should be MISSING, not IMAGE.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b18106f2
    • eric@webkit.org's avatar
      2010-04-29 Jan Hanssen <jhanssen@codeaurora.org> · 4d58ff0d
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Test whether HTMLOptionElement::ownerSelectElement() is considering the keygen element.
              https://bugs.webkit.org/show_bug.cgi?id=26016
      
              * fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
              * fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.
      2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>
      
              Reviewed by Adam Barth.
      
              HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
              https://bugs.webkit.org/show_bug.cgi?id=26016
      
              Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.
      
              Test: fast/dom/HTMLKeygenElement/keygen-option-select.html
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::ownerSelectElement):
              Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d58ff0d
    • zimmermann@webkit.org's avatar
      2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com> · d4d2ca67
      zimmermann@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
              https://bugs.webkit.org/show_bug.cgi?id=38307
      
              balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
              We now properly ignored the subtree. s/def/defs/ and the testcase works again.
      
              fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
              Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.
      
              Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
              I can now run those tests with --tolerance 0 without a problem.
      
              * fast/backgrounds/resources/balloon.svg: s/def/defs/
              * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
              * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
              * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
              * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
              * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
              * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
              * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
              * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
              * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
              * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4d2ca67
    • ukai@chromium.org's avatar
      Unreviewed, test expectations update. · e854c722
      ukai@chromium.org authored
      r58479 add fast/media/media-query-invalid-value.html, but it misses
      image expectations.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e854c722
    • eric@webkit.org's avatar
      2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi> · e0cfab42
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add EFL-specific code to Widget.h and move the empty
              frameRectsChanged() definition to Widget.cpp, since the EFL port
              needs to override that.
              http://webkit.org/b/36317
      
              No new tests required.
      
              * WebCore.base.exp:
              * platform/Widget.cpp:
              (WebCore::Widget::frameRectsChanged):
              * platform/Widget.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0cfab42
    • ukai@chromium.org's avatar
      2010-04-29 Fumitoshi Ukai <ukai@chromium.org> · 43380dad
      ukai@chromium.org authored
              Reviewed by David Levin.
      
              wrong filename: LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt
              https://bugs.webkit.org/show_bug.cgi?id=38310
      
              * platform/win/fast/text/international/bold-bengali-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43380dad
    • hausmann@webkit.org's avatar
      [Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes · 86e4591d
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38314
      
      Reviewed by Tor Arne Vestbø.
      
      Make sure that there's always a main frame when returning from createWindow()
      to the caller in WebCore.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86e4591d
    • eric@webkit.org's avatar
      2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> · 113ebd3e
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
              https://bugs.webkit.org/show_bug.cgi?id=38216
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::isGLES2Compliant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      113ebd3e
    • eric@webkit.org's avatar
      2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · d952a8b7
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Small cleanup.
      
              QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
              as a parameter, because it breaks a private / public separation rule.
              QScriptEnginePrivate::get(QScriptEngine*) should return
              a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
              implementation.
      
              [Qt] QScriptValuePrivate class needs some cleanup.
              https://bugs.webkit.org/show_bug.cgi?id=37729
      
              * qt/api/qscriptengine_p.h:
              (QScriptEnginePrivate::get):
              * qt/api/qscriptvalue.cpp:
              (QScriptValue::QScriptValue):
              * qt/api/qscriptvalue_p.h:
              (QScriptValuePrivate::QScriptValuePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d952a8b7
    • eric@webkit.org's avatar
      2010-04-29 Kwang Yul Seo <skyul@company100.net> · 14036ef8
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [WINCE] Export g_stackBase with JS_EXPORTDATA
              https://bugs.webkit.org/show_bug.cgi?id=37437
      
              Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.
      
              * runtime/Collector.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14036ef8
    • eric@webkit.org's avatar
      2010-04-29 Zhenyao Mo <zmo@google.com> · c1f61bb9
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
              https://bugs.webkit.org/show_bug.cgi?id=38235
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
              (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
              (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
              (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
              * html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
              * platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
              * platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
              (WebCore::GraphicsContext3D::texImage2D):
              (WebCore::GraphicsContext3D::texSubImage2D):
      2010-04-29  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
              https://bugs.webkit.org/show_bug.cgi?id=38235
      
              * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f61bb9
    • eric@webkit.org's avatar
      2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com> · dfd4d31d
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
              https://bugs.webkit.org/show_bug.cgi?id=38076
      
              This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
              animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
              is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
              upon stop (updateState) and not upon the object's destruction.
      
              http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
              the animation is toggled frequently.
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::TransformAnimationQt::~TransformAnimationQt):
              (WebCore::TransformAnimationQt::applyFrame):
              (WebCore::TransformAnimationQt::updateState):
              (WebCore::OpacityAnimationQt::~OpacityAnimationQt):
              (WebCore::OpacityAnimationQt::updateState):
              (WebCore::GraphicsLayerQt::removeAnimationsForProperty):
              (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfd4d31d
    • eric@webkit.org's avatar
      2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org> · 5db567f2
      eric@webkit.org authored
              Reviewed by Simon Fraser.
      
              Media queries empty values
              https://bugs.webkit.org/show_bug.cgi?id=38116
      
              Adding isValid() method to MediaQueryExp to make it possible to differentiate
              between queries with empty values and queries with invalid values.
      
              * fast/media/media-query-invalid-value-expected.txt: Added.
              * fast/media/media-query-invalid-value.html: Added.
      2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Simon Fraser.
      
              Media queries empty values
              https://bugs.webkit.org/show_bug.cgi?id=38116
      
              Adding isValid() method to MediaQueryExp to make it possible to differentiate
              between queries with empty values and queries with invalid values.
      
              Test: fast/media/media-query-invalid-value.html
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::MediaQueryEvaluator::eval):
              * css/MediaQueryExp.cpp:
              (WebCore::MediaQueryExp::MediaQueryExp):
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::isValid):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5db567f2
    • cjerdonek@webkit.org's avatar
      2010-04-28 Chris Jerdonek <cjerdonek@webkit.org> · da0f2b5f
      cjerdonek@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added to VCSUtils's parseDiffHeader() support for binary patches.
      
              https://bugs.webkit.org/show_bug.cgi?id=38094
      
              The parseDiffHeader() function is part of new patch-parsing code
              for svn-apply and svn-unapply that will go live in a subsequent
              revision.
      
              * Scripts/VCSUtils.pm:
                - Added logic to parseDiffHeader() to recognize the ending of
                  the header portion of a binary diff.
      
              * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
                - Added unit test cases for SVN and Git binary diffs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da0f2b5f