1. 08 Nov, 2010 40 commits
    • abarth@webkit.org's avatar
      2010-11-08 Adam Barth <abarth@webkit.org> · 67de2e55
      abarth@webkit.org authored
              Update help text to match behavior change.
      
              * code-review.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67de2e55
    • japhet@chromium.org's avatar
      2010-11-08 Nate Chapin <japhet@chromium.org> · 84248c41
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Call ApplicationCacheHost::maybeLoadResource() in
              ResourceLoader::start() instead of ResourceLoader::load().
              maybeLoadResource() might mutate the ResourceRequest, and
              in its current location any modifications are lost.
      
              https://bugs.webkit.org/show_bug.cgi?id=49221
      
              Fixes a couple of http/tests/appcache tests
              failing on chromium.
      
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::load):
              (WebCore::ResourceLoader::start):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84248c41
    • chang.shu@nokia.com's avatar
      2010-11-08 Chang Shu <chang.shu@nokia.com> · 69109ab1
      chang.shu@nokia.com authored
              Reviewed by Antonio Gomes.
      
              Unskip test that is passing now.
              https://bugs.webkit.org/show_bug.cgi?id=49150
      
              * platform/gtk/Skipped:
      2010-11-08  Chang Shu  <chang.shu@nokia.com>
      
              Reviewed by Antonio Gomes.
      
              [GTK] Use Space to toggle arrow key handling for selection change or
              spatial navigation. Put the logic in common code to pass both Qt and
              GTK. Mac won't work because arrow keys trigger the popup.
              https://bugs.webkit.org/show_bug.cgi?id=49150
      
              Existing test: fast/events/spatial-navigation/snav-single-select.html
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::menuListDefaultEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69109ab1
    • commit-queue@webkit.org's avatar
      2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> · bc0712b6
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Link with target name set does not work
              https://bugs.webkit.org/show_bug.cgi?id=48865
      
              When a new page is created with a name (target=myFrame), the new
              mainFrame could not be found because they where not stored in the
              same PageGroup. As PageGroup are not exposed externally so the
              simpliest solution is to use a global page group name. This also fixes
              issue with visited link coloration across pages. After this change the
              private function webkit_web_view_set_group_name() was no longer used
              so it was removed completly.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::closeWindowSoon):
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::openInspectorFrontend):
              * webkit/webkitprivate.h:
              * webkit/webkitwebview.cpp:
              (webkit_web_view_init):
      2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Link with target name set does not work
              https://bugs.webkit.org/show_bug.cgi?id=48865
      
              When a new page is created with a name (target=myFrame), the new
              mainFrame could not be found because they where not stored in the
              same PageGroup. As PageGroup are not exposed externally so the
              simpliest solution is to use a global page group name. This also fixes
              issue with visited link coloration across pages. After this change the
              private function webkit_web_view_set_group_name() was no longer used
              so it was removed completly.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (createWebView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc0712b6
    • commit-queue@webkit.org's avatar
      2010-11-08 Jenn Braithwaite <jennb@chromium.org> · 210f566d
      commit-queue@webkit.org authored
              Reviewed by Pavel Feldman.
      
              _bindResourceURL in ResourceManager.js may not add resource to map
              https://bugs.webkit.org/show_bug.cgi?id=49088
      
              No new tests. pfeldman working on better test harness and tests.
      
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager.prototype._bindResourceURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      210f566d
    • commit-queue@webkit.org's avatar
      2010-11-08 John Knottenbelt <jknotten@chromium.org> · 78873c9b
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Convert to and from DOMTimeStamp with converter functions.
              This is a refactoring only, covered by existing layout tests.
              https://bugs.webkit.org/show_bug.cgi?id=49066
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DOMTimeStamp.h: Added.
              (WebCore::convertSecondsToDOMTimeStamp):
              (WebCore::convertDOMTimeStampToSeconds):
              * dom/Event.cpp:
              (WebCore::Event::Event):
              * dom/Event.h:
              * page/Geolocation.cpp:
              (WebCore::Geolocation::haveSuitableCachedPosition):
              * platform/android/GeolocationServiceAndroid.cpp:
              (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
      2010-11-08  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              Convert to and from DOMTimeStamp with converter functions
              https://bugs.webkit.org/show_bug.cgi?id=49066
      
              * src/WebDataSourceImpl.cpp:
              (WebKit::WebDataSourceImpl::triggeringEventTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78873c9b
    • rniwa@webkit.org's avatar
      2010-11-08 Ryosuke Niwa <rniwa@webkit.org> · 454339dd
      rniwa@webkit.org authored
              Unreviewed. Rebaselines for r71589.
      
              * platform/chromium-linux/editing/deleting/5156801-2-expected.checksum:
              * platform/chromium-linux/editing/deleting/5156801-2-expected.png:
              * platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png:
              * platform/chromium-linux/editing/deleting/delete-br-002-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-br-002-expected.png:
              * platform/chromium-linux/editing/deleting/delete-br-004-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-br-004-expected.png:
              * platform/chromium-linux/editing/deleting/delete-br-005-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-br-005-expected.png:
              * platform/chromium-linux/editing/deleting/delete-line-003-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-line-003-expected.png:
              * platform/chromium-linux/editing/deleting/delete-tab-004-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-tab-004-expected.png:
              * platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
              * platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
              * platform/chromium-linux/editing/execCommand/5482023-expected.checksum:
              * platform/chromium-linux/editing/execCommand/5482023-expected.png:
              * platform/chromium-linux/editing/inserting/4960120-2-expected.checksum:
              * platform/chromium-linux/editing/inserting/4960120-2-expected.png:
              * platform/chromium-linux/editing/inserting/5549929-2-expected.checksum:
              * platform/chromium-linux/editing/inserting/5549929-2-expected.png:
              * platform/chromium-linux/editing/inserting/5549929-3-expected.checksum:
              * platform/chromium-linux/editing/inserting/5549929-3-expected.png:
              * platform/chromium-linux/editing/inserting/editable-inline-element-expected.checksum:
              * platform/chromium-linux/editing/inserting/editable-inline-element-expected.png:
              * platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.png:
              * platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png:
              * platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png:
              * platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-001-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-001-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-002-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-002-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-003-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-003-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-006-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-006-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-008-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-008-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-009-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-009-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png:
              * platform/chromium-linux/editing/inserting/insert-tab-004-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-tab-004-expected.png:
              * platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
              * platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
              * platform/chromium-linux/editing/inserting/line-break-expected.checksum:
              * platform/chromium-linux/editing/inserting/line-break-expected.png:
              * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
              * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
              * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
              * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
              * platform/chromium-linux/editing/inserting/typing-003-expected.checksum:
              * platform/chromium-linux/editing/inserting/typing-003-expected.png:
              * platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
              * platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
              * platform/chromium-linux/editing/pasteboard/4989774-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/4989774-expected.png:
              * platform/chromium-linux/editing/pasteboard/5028447-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/5028447-expected.png:
              * platform/chromium-linux/editing/pasteboard/5601583-1-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/5601583-1-expected.png:
              * platform/chromium-linux/editing/pasteboard/merge-end-1-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png:
              * platform/chromium-linux/editing/pasteboard/merge-end-2-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-table-003-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png:
              * platform/chromium-linux/editing/pasteboard/paste-text-010-expected.checksum:
              * platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png:
              * platform/chromium-linux/editing/selection/5007143-2-expected.checksum:
              * platform/chromium-linux/editing/selection/5007143-2-expected.png:
              * platform/chromium-linux/editing/selection/5007143-expected.checksum:
              * platform/chromium-linux/editing/selection/5007143-expected.png:
              * platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
              * platform/chromium-linux/editing/selection/5234383-2-expected.png:
              * platform/chromium-linux/editing/selection/editable-html-element-expected.checksum:
              * platform/chromium-linux/editing/selection/editable-html-element-expected.png:
              * platform/chromium-linux/editing/selection/move-3875618-fix-expected.checksum:
              * platform/chromium-linux/editing/selection/move-3875618-fix-expected.png:
              * platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
              * platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
              * platform/chromium-linux/editing/selection/move-by-character-002-expected.checksum:
              * platform/chromium-linux/editing/selection/move-by-character-002-expected.png:
              * platform/chromium-linux/editing/selection/move-by-character-003-expected.checksum:
              * platform/chromium-linux/editing/selection/move-by-character-003-expected.png:
              * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
              * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png:
              * platform/chromium-linux/editing/selection/selection-3748164-fix-expected.checksum:
              * platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png:
              * platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.checksum:
              * platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.png:
              * platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.checksum:
              * platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.png:
              * platform/chromium-win/editing/deleting/5156801-2-expected.checksum:
              * platform/chromium-win/editing/deleting/5156801-2-expected.png:
              * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.png:
              * platform/chromium-win/editing/deleting/delete-br-002-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-br-002-expected.png:
              * platform/chromium-win/editing/deleting/delete-br-004-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-br-004-expected.png:
              * platform/chromium-win/editing/deleting/delete-br-005-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-br-005-expected.png:
              * platform/chromium-win/editing/deleting/delete-line-003-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-line-003-expected.png:
              * platform/chromium-win/editing/deleting/delete-tab-004-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-tab-004-expected.png:
              * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
              * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
              * platform/chromium-win/editing/execCommand/5482023-expected.checksum:
              * platform/chromium-win/editing/execCommand/5482023-expected.png:
              * platform/chromium-win/editing/inserting/4960120-2-expected.checksum:
              * platform/chromium-win/editing/inserting/4960120-2-expected.png:
              * platform/chromium-win/editing/inserting/5549929-2-expected.checksum:
              * platform/chromium-win/editing/inserting/5549929-2-expected.png:
              * platform/chromium-win/editing/inserting/5549929-3-expected.checksum:
              * platform/chromium-win/editing/inserting/5549929-3-expected.png:
              * platform/chromium-win/editing/inserting/editable-inline-element-expected.checksum:
              * platform/chromium-win/editing/inserting/editable-inline-element-expected.png:
              * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.png:
              * platform/chromium-win/editing/inserting/insert-3775316-fix-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-3775316-fix-expected.png:
              * platform/chromium-win/editing/inserting/insert-3786362-fix-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png:
              * platform/chromium-win/editing/inserting/insert-3800346-fix-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-3800346-fix-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-001-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-001-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-002-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-002-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-003-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-003-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-004-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-005-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-006-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-006-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-007-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-008-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-008-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-009-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-009-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.png:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.png:
              * platform/chromium-win/editing/inserting/insert-tab-004-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-tab-004-expected.png:
              * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
              * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
              * platform/chromium-win/editing/inserting/line-break-expected.checksum:
              * platform/chromium-win/editing/inserting/line-break-expected.png:
              * platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
              * platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
              * platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
              * platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
              * platform/chromium-win/editing/inserting/typing-003-expected.checksum:
              * platform/chromium-win/editing/inserting/typing-003-expected.png:
              * platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
              * platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
              * platform/chromium-win/editing/pasteboard/4989774-expected.checksum:
              * platform/chromium-win/editing/pasteboard/4989774-expected.png:
              * platform/chromium-win/editing/pasteboard/5028447-expected.checksum:
              * platform/chromium-win/editing/pasteboard/5028447-expected.png:
              * platform/chromium-win/editing/pasteboard/5601583-1-expected.checksum:
              * platform/chromium-win/editing/pasteboard/5601583-1-expected.png:
              * platform/chromium-win/editing/pasteboard/merge-end-1-expected.checksum:
              * platform/chromium-win/editing/pasteboard/merge-end-1-expected.png:
              * platform/chromium-win/editing/pasteboard/merge-end-2-expected.checksum:
              * platform/chromium-win/editing/pasteboard/merge-end-2-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-table-003-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-table-003-expected.png:
              * platform/chromium-win/editing/pasteboard/paste-text-010-expected.checksum:
              * platform/chromium-win/editing/pasteboard/paste-text-010-expected.png:
              * platform/chromium-win/editing/selection/5007143-2-expected.checksum:
              * platform/chromium-win/editing/selection/5007143-2-expected.png:
              * platform/chromium-win/editing/selection/5007143-expected.checksum:
              * platform/chromium-win/editing/selection/5007143-expected.png:
              * platform/chromium-win/editing/selection/5234383-2-expected.checksum:
              * platform/chromium-win/editing/selection/5234383-2-expected.png:
              * platform/chromium-win/editing/selection/editable-html-element-expected.checksum:
              * platform/chromium-win/editing/selection/editable-html-element-expected.png:
              * platform/chromium-win/editing/selection/extend-selection-expected.txt:
              * platform/chromium-win/editing/selection/move-3875618-fix-expected.checksum:
              * platform/chromium-win/editing/selection/move-3875618-fix-expected.png:
              * platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
              * platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
              * platform/chromium-win/editing/selection/move-by-character-002-expected.checksum:
              * platform/chromium-win/editing/selection/move-by-character-002-expected.png:
              * platform/chromium-win/editing/selection/move-by-character-003-expected.checksum:
              * platform/chromium-win/editing/selection/move-by-character-003-expected.png:
              * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
              * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
              * platform/chromium-win/editing/selection/selection-3748164-fix-expected.checksum:
              * platform/chromium-win/editing/selection/selection-3748164-fix-expected.png:
              * platform/chromium-win/editing/unsupported-content/table-delete-001-expected.checksum:
              * platform/chromium-win/editing/unsupported-content/table-delete-001-expected.png:
              * platform/chromium-win/editing/unsupported-content/table-delete-003-expected.checksum:
              * platform/chromium-win/editing/unsupported-content/table-delete-003-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      454339dd
    • kenneth@webkit.org's avatar
      2010-11-08 Kenneth Rohde Christiansen <kenneth@webkit.org> · d8b64db1
      kenneth@webkit.org authored
              Reviewed by Andreas Kling.
      
              Send page scroll requests to the PageClient when scroll delegation is turned on
              https://bugs.webkit.org/show_bug.cgi?id=49171
      
              Implement the IPC and API required for making scroll delegation work
              with WebKit2. This is only used when you have tiling enabled.
      
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::pageDidRequestScroll):
              * UIProcess/API/qt/qwkpage.h:
              * UIProcess/API/qt/qwkpage_p.h:
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::pageDidRequestScroll):
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.messages.in:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::delegatedScrollRequested):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::pageDidRequestScroll):
              * WebProcess/WebPage/WebPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8b64db1
    • mrowe@apple.com's avatar
      <rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebProcess. · a37b8c30
      mrowe@apple.com authored
      Patch by Ivan Krstić <ike@apple.com> on 2010-11-08
      Reviewed by Mark Rowe.
      
      * WebProcess/com.apple.WebProcess.sb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a37b8c30
    • rniwa@webkit.org's avatar
      2010-11-08 Ryosuke Niwa <rniwa@webkit.org> · 92bd01b3
      rniwa@webkit.org authored
              Unreviewed build fix for Chromium Mac for r71590.
      
              * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
              (WebCore::provideStringAndAttributes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bd01b3
    • commit-queue@webkit.org's avatar
      2010-11-08 John Knottenbelt <jknotten@chromium.org> · de91794f
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              WebViewHost::reset() uses placement new.
              https://bugs.webkit.org/show_bug.cgi?id=49069
      
              WebViewHost is using placement destruction / new to simulate a fresh
              WebViewHost object at the same address. This is because the WebView remains
              open across tests and maintains a pointer to the WebViewHost.
              This change resets member variables explictly instead of the placement new dance.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::WebViewHost):
              (WebViewHost::reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de91794f
    • commit-queue@webkit.org's avatar
      2010-11-08 Juha Savolainen <juha.savolainen@weego.fi> · ce484f7d
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Added new methods to QWKHistory and made QWKHistoryItemPrivate to shared object.
              https://bugs.webkit.org/show_bug.cgi?id=49063
      
              Added more functionality to the QWKHistory and changed QWKHistoryItemPrivate to shared object.
              This is needed because we cannot delete the QWKHistoryItemPrivate pointer in destructor of QWKHistoryItem,
              there may have other history instances which share same private implementation.
      
              * UIProcess/API/qt/qwkhistory.cpp:
              (QWKHistoryItemPrivate::~QWKHistoryItemPrivate):
              (QWKHistoryItem::QWKHistoryItem):
              (QWKHistoryItem::QWKHistoryItem::operator=):
              (QWKHistory::currentItem): Added
              (QWKHistory::backItem): Added
              (QWKHistory::forwardItem): Added
              (QWKHistory::itemAt): Added
              (QWKHistory::backItems): Added
              (QWKHistory::forwardItems): Added
              * UIProcess/API/qt/qwkhistory.h:
              * UIProcess/API/qt/qwkhistory_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce484f7d
    • rniwa@webkit.org's avatar
      2010-11-08 Ryosuke Niwa <rniwa@webkit.org> · e1c4a654
      rniwa@webkit.org authored
              Reviewed by Kent Tamura.
      
              dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
              https://bugs.webkit.org/show_bug.cgi?id=49223
      
              Converted editing/inserting/5607069-2.html and editing/inserting/5607069-3.html
              to dump-as-markup tests. Re-enabled them on Qt, Gtk, and Chromium platforms.
      
              * editing/inserting/5607069-2-expected.txt: Added.
              * editing/inserting/5607069-2.html:
              * editing/inserting/5607069-3-expected.txt: Added.
              * editing/inserting/5607069-3.html:
              * platform/chromium-linux/editing/inserting/5607069-2-expected.checksum: Removed.
              * platform/chromium-linux/editing/inserting/5607069-2-expected.png: Removed.
              * platform/chromium-linux/editing/inserting/5607069-2-expected.txt: Removed.
              * platform/chromium-linux/editing/inserting/5607069-3-expected.checksum: Removed.
              * platform/chromium-linux/editing/inserting/5607069-3-expected.png: Removed.
              * platform/chromium-win/editing/inserting/5607069-2-expected.checksum: Removed.
              * platform/chromium-win/editing/inserting/5607069-2-expected.png: Removed.
              * platform/chromium-win/editing/inserting/5607069-2-expected.txt: Removed.
              * platform/chromium-win/editing/inserting/5607069-3-expected.checksum: Removed.
              * platform/chromium-win/editing/inserting/5607069-3-expected.png: Removed.
              * platform/chromium-win/editing/inserting/5607069-3-expected.txt: Removed.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/editing/inserting/5607069-2-expected.checksum: Removed.
              * platform/mac-leopard/editing/inserting/5607069-2-expected.png: Removed.
              * platform/mac-leopard/editing/inserting/5607069-3-expected.checksum: Removed.
              * platform/mac-leopard/editing/inserting/5607069-3-expected.png: Removed.
              * platform/mac/editing/inserting/5607069-2-expected.checksum: Removed.
              * platform/mac/editing/inserting/5607069-2-expected.png: Removed.
              * platform/mac/editing/inserting/5607069-2-expected.txt: Removed.
              * platform/mac/editing/inserting/5607069-3-expected.checksum: Removed.
              * platform/mac/editing/inserting/5607069-3-expected.png: Removed.
              * platform/mac/editing/inserting/5607069-3-expected.txt: Removed.
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1c4a654
    • antonm@chromium.org's avatar
      2010-11-08 Anton Muhin <antonm@chromium.org> · 2c41705b
      antonm@chromium.org authored
              Reviewed by Nate Chapin.
      
              [v8] Get rid of automatically generated named property getter for classes with namedItem method
              https://bugs.webkit.org/show_bug.cgi?id=48770
      
              * platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
              * platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:
      2010-11-08  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Nate Chapin.
      
              [v8] Get rid of automatically generated named property getter for classes with namedItem method
              https://bugs.webkit.org/show_bug.cgi?id=48770
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c41705b
    • benjamin.poulain@nokia.com's avatar
      2010-11-08 Benjamin Poulain <benjamin.poulain@nokia.com> · 0557d7a0
      benjamin.poulain@nokia.com authored
              Reviewed by Andreas Kling.
      
              [Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0
              https://bugs.webkit.org/show_bug.cgi?id=47427
      
              Add a missing guard in order to be able to compile when
              ENABLE(TOUCH_EVENTS) is not defined.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::touchEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0557d7a0
    • dumi@chromium.org's avatar
      Unreviewed, updating Chromium expectations. · cfcedeb9
      dumi@chromium.org authored
      * platform/chromium-linux/editing/selection/home-end-expected.txt: Added.
      * platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
      * platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
      * platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
      * platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
      * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
      * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
      * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
      * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
      * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
      * platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
      * platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
      * platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
      * platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-win/editing/selection/home-end-expected.txt:
      * platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
      * platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
      * platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
      * platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
      * platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
      * platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
      * platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
      * platform/chromium-win/fast/css/text-overflow-ellipsis-bidi-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-explicit-embedding-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/chromium-win/fast/text/international/bidi-override-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfcedeb9
    • andersca@apple.com's avatar
      Add WKDownloadClient API · 9cff7508
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49227
      
      Reviewed by Dan Bernstein.
      
      * Shared/API/c/WKBase.h:
      Add WKDownloadRef.
      
      * UIProcess/API/C/WKAPICast.h:
      Add WKDownloadRef <-> DownloadProxy mapping.
      
      * UIProcess/API/C/WKContext.cpp:
      (WKContextSetDownloadClient):
      Initialize the download client.
      
      * UIProcess/API/C/WKContext.h:
      Add new WKContextDownloadClient API.
      
      * UIProcess/API/C/WKDownload.cpp: Added.
      * UIProcess/API/C/WKDownload.h:
      Add WKDownload files.
      
      * UIProcess/Downloads/DownloadProxy.cpp:
      (WebKit::DownloadProxy::didStart):
      (WebKit::DownloadProxy::didCreateDestination):
      (WebKit::DownloadProxy::didFinish):
      Call down to the the WebDownloadClient.
      
      * UIProcess/Downloads/DownloadProxy.messages.in:
      Rename DidBegin to DidStart.
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::initializeDownloadClient):
      Initialize the download client.
      
      * UIProcess/WebContext.h:
      (WebKit::WebContext::downloadClient):
      Add getter.
      
      * UIProcess/WebDownloadClient.cpp:
      (WebKit::WebDownloadClient::didStart):
      (WebKit::WebDownloadClient::didCreateDestination):
      (WebKit::WebDownloadClient::didFinish):
      Call the relevant WKContextDownloadClient functions.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/Downloads/Download.cpp:
      (WebKit::Download::didStart):
      * WebProcess/Downloads/Download.h:
      * WebProcess/Downloads/mac/DownloadMac.mm:
      (-[WKDownloadAsDelegate downloadDidBegin:]):
      Rename Download::didBegin to Download::didStart.
      
      * win/WebKit2.vcproj:
      Add new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cff7508
    • commit-queue@webkit.org's avatar
      2010-11-08 Ned Holbrook <nholbrook@apple.com> · 457f1a25
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
              https://bugs.webkit.org/show_bug.cgi?id=48886
      
              * WebCore.exp.in:
              * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
              (WebCore::provideStringAndAttributes):
              (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
              * platform/mac/WebCoreSystemInterface.h:
              * platform/mac/WebCoreSystemInterface.mm:
      2010-11-08  Ned Holbrook  <nholbrook@apple.com>
      
              Reviewed by Adam Barth.
      
              Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
              https://bugs.webkit.org/show_bug.cgi?id=48886
      
              * WebCoreSupport/WebSystemInterface.mm:
              (InitWebCoreSystemInterface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      457f1a25
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=49228 · 1ff04429
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      REGRESSION: caret too short when a positive line height is specified.  Now that lineTop no longer
      accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::localCaretRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ff04429
    • xji@chromium.org's avatar
      2010-11-08 Xiaomei Ji <xji@chromium.org> · c76b40b9
      xji@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Rebaesline for GTK after r71566
              https://bugs.webkit.org/show_bug.cgi?id=25321
      
              * platform/gtk/editing/selection/extend-selection-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c76b40b9
    • commit-queue@webkit.org's avatar
      2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> · 5e768386
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Adding hasUserGesture flag to the ResourceRequest
              https://bugs.webkit.org/show_bug.cgi?id=37057
      
              This flag is to be used on the browser side to indicate when a
              download has been user initiated.
      
              No new tests. This change will be tested through a browser UI test.
      
              * platform/network/chromium/ResourceRequest.h:
              (WebCore::ResourceRequest::ResourceRequest):
              (WebCore::ResourceRequest::hasUserGesture):
              (WebCore::ResourceRequest::setHasUserGesture):
      2010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>
      
              Reviewed by Darin Fisher.
      
              [chromium] Adding hasUserGesture flag to the ResourceRequest
              https://bugs.webkit.org/show_bug.cgi?id=37057
      
              This flag is to be used on the browser side to indicate when a
              download has been user initiated.
      
              * public/WebURLRequest.h:
              * src/WebURLRequest.cpp:
              (WebKit::WebURLRequest::hasUserGesture):
              (WebKit::WebURLRequest::setHasUserGesture):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e768386
    • crogers@google.com's avatar
      2010-11-08 Chris Rogers <crogers@google.com> · 1fc82eaf
      crogers@google.com authored
              Reviewed by Kenneth Russell.
      
              Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
              https://bugs.webkit.org/show_bug.cgi?id=49087
      
              No new tests since audio API is not yet implemented.
      
              * platform/audio/Panner.cpp:
              (WebCore::Panner::create):
              * platform/audio/Panner.h:
              * webaudio/AudioPannerNode.h:
              * webaudio/AudioPannerNode.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fc82eaf
    • beidson@apple.com's avatar
      Part of https://bugs.webkit.org/show_bug.cgi?id=49222 · de4de4cf
      beidson@apple.com authored
      Rename "WebContextMenuItem" to "WebContextMenuItemData"
      
      Reviewed by Anders Carlsson.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      * Shared/WebContextMenuItem.cpp: Removed.
      * Shared/WebContextMenuItem.h: Removed.
      * Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.
      (WebKit::WebContextMenuItemData::WebContextMenuItemData):
      (WebKit::WebContextMenuItemData::encode):
      (WebKit::WebContextMenuItemData::decode):
      (WebKit::kitItems):
      * Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.
      (WebKit::WebContextMenuItemData::submenu):
      
      * UIProcess/WebContextMenuProxy.h:
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showContextMenu):
      (WebKit::WebPageProxy::contextMenuItemSelected):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * UIProcess/mac/WebContextMenuProxyMac.h:
      * UIProcess/mac/WebContextMenuProxyMac.mm:
      (-[WebMenuTarget forwardContextMenuAction:]):
      (WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
      (WebKit::nsMenuItemVector):
      (WebKit::WebContextMenuProxyMac::populate):
      (WebKit::WebContextMenuProxyMac::showContextMenu):
      
      * UIProcess/qt/WebContextMenuProxyQt.cpp:
      (WebKit::WebContextMenuProxyQt::showContextMenu):
      * UIProcess/qt/WebContextMenuProxyQt.h:
      
      * UIProcess/win/WebContextMenuProxyWin.cpp:
      (WebKit::WebContextMenuProxyWin::showContextMenu):
      * UIProcess/win/WebContextMenuProxyWin.h:
      
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::itemSelected):
      * WebProcess/WebPage/WebContextMenu.h:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didSelectItemFromActiveContextMenu):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de4de4cf
    • paroga@webkit.org's avatar
      2010-11-08 Patrick Gansterer <paroga@webkit.org> · 9646d8b9
      paroga@webkit.org authored
              Reviewed by Adam Roben.
      
              Merge EditorWinCE.cpp into EditorWin.cpp
              https://bugs.webkit.org/show_bug.cgi?id=49095
      
              * platform/win/EditorWin.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * platform/wince/EditorWinCE.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9646d8b9
    • andersca@apple.com's avatar
      Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay · dc2f1bf1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49219
      <rdar://problem/8569550>
      
      Reviewed by John Sullivan and Dan Bernstein.
      
      * WebProcess/WebPage/FindPageOverlay.cpp:
      (WebKit::FindPageOverlay::bounds):
      Return the bounds of the find page overlay, excluding any scrollbars.
      
      (WebKit::FindPageOverlay::drawRect):
      Call bounds.
      
      (WebKit::FindPageOverlay::mouseEvent):
      Only dismiss the find UI if the mouse down event happens inside the overlay bounds.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc2f1bf1
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=49217 · d350017b
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
      preferring later lines when there is overlap.
      
      WebCore: 
      
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::positionForPoint):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::positionForPoint):
      
      LayoutTests: 
      
      * fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
      * fast/dom/Document/CaretRangeFromPoint/replace-element.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d350017b
    • andersca@apple.com's avatar
      Add the ability to send messages to DownloadProxy objects · d06a84ec
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49213
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make:
      * DerivedSources.pro:
      Add Download.messages.in.
      
      * Platform/CoreIPC/MessageID.h:
      Add MessageClassDownloadProxy message class.
      
      * Platform/CoreIPC/MessageSender.h:
      Include Connection.h directly since it's required.
      
      * UIProcess/Downloads/DownloadProxy.cpp:
      (WebKit::DownloadProxy::didBegin):
      (WebKit::DownloadProxy::didCreateDestination):
      (WebKit::DownloadProxy::didFinish):
      Add stubs.
      
      * UIProcess/Downloads/DownloadProxy.messages.in: Added.
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::didReceiveMessage):
      Handle DownloadProxy messages.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::didReceiveMessage):
      Hand DownloadProxy messages off to the context.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/Downloads/Download.cpp:
      (WebKit::Download::didBegin):
      (WebKit::Download::didReceiveData):
      (WebKit::Download::didCreateDestination):
      (WebKit::Download::didFinish):
      Send messages.
      
      * WebProcess/Downloads/mac/DownloadMac.mm:
      (-[WKDownloadAsDelegate download:didCreateDestination:]):
      Call Download::didCreateDestination.
      
      * win/WebKit2.vcproj:
      Add new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d06a84ec
    • dpranke@chromium.org's avatar
      2010-11-08 Dirk Pranke <dpranke@chromium.org> · 6a1f9591
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
              It turns out that NRWT can't use the code in scm.find_checkout_root()
              because the Chromium bots don't do full checkouts of the WebKit
              tree; they only check out subdirectories like WebKitTools/Scripts.
              Until we can figure out a better approach for this, I've
              restored the base_dir-detecting code from NRWT, which works in
              any directory tree, scm or no.
      
              This also restores the files modified in r71475 and r71474.
      
              https://bugs.webkit.org/show_bug.cgi?id=49151
      
              * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
              * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1f9591
    • hyatt@apple.com's avatar
      Fix build bustage. · 54ad9018
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54ad9018
    • steveblock@google.com's avatar
      2010-11-08 Steve Block <steveblock@google.com> · 3fc03e36
      steveblock@google.com authored
              Reviewed by David Levin.
      
              Building for Android generates several compiler warnings
              https://bugs.webkit.org/show_bug.cgi?id=49175
      
              Fixes these warnings, most of which are trivial.
              - PREFIX_FOR_WEBCORE was previously required for STL's algorithm, but is no
                longer. See
                http://android.git.kernel.org/?p=platform/external/webkit.git;a=commit;h=a47ab5294213cca2741f453b450b02666e08cac8
              - The definition of EXPORT is required only for the JNI entry point in
                WebKit/android, so does not need to be in WebCorePrefix.h
      
              No new tests, fixes compile warnings only.
      
              * WebCorePrefix.h:
              * bridge/jni/jsc/JNIUtilityPrivate.cpp:
              (JSC::Bindings::convertValueToJValue):
              * platform/android/FileSystemAndroid.cpp:
              (WebCore::listDirectory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fc03e36
    • noam.rosenthal@nokia.com's avatar
      Unreviewed bot fix. · 282a8380
      noam.rosenthal@nokia.com authored
      Removed a test that was added without results. Will add again later.
      
      * compositing/layer-creation/many-layers.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      282a8380
    • mitz@apple.com's avatar
      <rdar://problem/8119781> Crash zooming into Word document at office.live.com · 44fdccdb
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49203
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/css/zoom-change-triggering-layout.html
      
      RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
      overrides can trigger layout.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
      the zoom factor changes.
      
      LayoutTests: 
      
      * fast/css/zoom-change-triggering-layout-expected.txt: Added.
      * fast/css/zoom-change-triggering-layout.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44fdccdb
    • ossy@webkit.org's avatar
      Unreviewed rolling out r71567. · b721e69b
      ossy@webkit.org authored
      r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.
      
      * fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
      * fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
      * plugins/navigator-mimeTypes-length-expected.txt: Removed.
      * plugins/navigator-mimeTypes-length.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b721e69b
    • andersca@apple.com's avatar
      Add DownloadProxy object · e4e08e28
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49211
      
      Reviewed by Adam Roben.
      
      DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.
      
      * Shared/APIObject.h:
      Add TypeDownload.
      
      * UIProcess/Downloads/DownloadProxy.cpp:
      (WebKit::generateDownloadID):
      Generate a unique download ID.
      
      (WebKit::DownloadProxy::invalidate):
      Null out the web context.
      
      * UIProcess/Downloads/DownloadProxy.h:
      (WebKit::WebContext::processDidClose):
      Invalidate all downloads.
      
      (WebKit::WebContext::createDownloadProxy):
      Create a WebDownload object.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::receivedPolicyDecision):
      Call createDownloadProxy instead.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      Add new files.
      
      * win/WebKit2Common.vsprops:
      Add new include path.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e08e28
    • senorblanco@chromium.org's avatar
      2010-11-08 Stephen White <senorblanco@chromium.org> · d91c4c3f
      senorblanco@chromium.org authored
              Unreviewed; test expectations update.
      
              Add a test missing results to chromium-gpu test expectations.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91c4c3f
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48587 · 13869a61
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      Make Ruby work with vertical text.  Ruby already nearly does work.  The only big issue I found was with
      flipped lines writing modes.  Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
      the ruby text is on the correct side of the ruby base.
      
      Added fast/blockflow tests of the various writing modes.
      
      WebCore: 
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::baselinePosition):
      (WebCore::RenderBlock::firstLineBoxBaseline):
      (WebCore::RenderBlock::lastLineBoxBaseline):
      * rendering/RenderRubyRun.cpp:
      (WebCore::RenderRubyRun::staticCreateRubyRun):
      
      LayoutTests: 
      
      * fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
      * fast/blockflow/japanese-ruby-vertical-lr.html: Added.
      * fast/blockflow/japanese-ruby-vertical-rl.html: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13869a61
    • eric@webkit.org's avatar
      2010-11-08 Eric Seidel <eric@webkit.org> · 1d684e82
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch failure-reason explodes if a build is missing
              https://bugs.webkit.org/show_bug.cgi?id=49195
      
              This is likely a recent regression.  Adding a unit test for this case.
      
              * Scripts/webkitpy/common/net/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d684e82
    • abarth@webkit.org's avatar
      2010-11-08 Adam Barth <abarth@webkit.org> · a9af6788
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Restore normal meaning of double-click on patch review page?
              https://bugs.webkit.org/show_bug.cgi?id=47641
      
              After this patch, you need to click on the line numbers to add a
              comment.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9af6788
    • bfulgham@webkit.org's avatar
      Unreviewed build correction after @70369/@70846. · e9bcc996
      bfulgham@webkit.org authored
      Please use PLATFORM(CG) to define CG-specific code, not
      PLATFORM(CF).
      
      * platform/image-decoders/ImageDecoder.cpp:
      * platform/image-decoders/ImageDecoder.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9bcc996
    • jamesr@google.com's avatar
      2010-11-08 James Robinson <jamesr@chromium.org> · 079b9e3b
      jamesr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Input element with inner spin button set to display:none causes crash
              https://bugs.webkit.org/show_bug.cgi?id=49121
      
              Adds a test for dispatching mouse events at an <input type="number"> with
              the inner spin button set to display:none does not crash.
      
              * fast/forms/input-number-spinbutton-crash-expected.txt: Added.
              * fast/forms/input-number-spinbutton-crash.html: Added.
      2010-11-08  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Input element with inner spin button set to display:none causes crash
              https://bugs.webkit.org/show_bug.cgi?id=49121
      
              Null check the inner spin button's renderer before dereferencing it.
      
              Test: fast/forms/input-number-spinbutton-crash.html
      
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::forwardEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079b9e3b