1. 22 May, 2007 9 commits
  2. 21 May, 2007 21 commits
    • oliver's avatar
      2007-05-21 Oliver Hunt <oliver@apple.com> · 7fa2f31b
      oliver authored
              Reviewed by Sam.
              Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789
              * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
              * svg/custom/getscreenctm-in-mixed-content.xhtml: Added.
              Reviewed by Sam.
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 
              -- SVGLocatable::getScreenCTM() faulty
              Needed to update SVGLength to handle the case where the SVGElement is
              not the root document element -- we do this by falling back on the 
              renderer for the context.
              For <svg> elements embedded as mixed content in xhtml we consider the
              absolutePosition of the parent to be the origin for the <svg> element.
              * ksvg2/svg/SVGLength.cpp:
              * ksvg2/svg/SVGSVGElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Adam. · 428cde24
      thatcher authored
              <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created
              Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.
              * bindings/objc/DOM.mm:
              (-[DOMNode boundingBox]):
              (-[DOMNode lineBoxRects]):
              (-[DOMRange boundingBox]):
              (-[DOMRange lineBoxRects]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by George Staikos. · 151497a0
      weinig authored
              Fix Qt build.
              * WebCore.pro: add missing IDL files.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
              Reviewed by Darin.
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              * bindings/js/kjs_html.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      WebCore: · dd237c40
      adele authored
              Fix by Darin, reviewed by me.
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
              * platform/mac/WidgetMac.mm:
              (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then 
               set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
              (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
              (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
              (WebCore::Widget::afterMouseDown): ditto.
              Fix by Darin, reviewed by me.
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
              * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
              then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      · b3baea79
      weinig authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make a line gutter backdrop so that tiny view source docs don't look · 52b9b637
      hyatt authored
              Reviewed by aroben
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make sure to distinguish between links to internal resources and · 339df964
      hyatt authored
              real links (anchors) in view source mode.
              Reviewed by aroben
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              * html/HTMLViewSourceDocument.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Making the importance of my last change more clear · 70ce7065
      beidson authored
              * WebView/WebViewPrivate.h: "Leave for Dashboard, people!"
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by Kevin (Sarge) · 274265e3
      beidson authored
              <rdar://problem/5217124> - Re-add mistakenly removed SPI
              * WebView/WebView.mm:
              (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
              * WebView/WebViewPrivate.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · 16885ff7
      weinig authored
              Reviewed by Adam and Darin.
              - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
                to account for new JSHTMLElements that are being autogenerated and
                can now produce constructors.
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
              Reviewed by Adam and Darin.
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
              Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameElementBase.cpp:
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.h:
              * html/HTMLIFrameElement.idl:
              * page/DOMWindow.idl:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      Reviewed by Ada. · 8cb65d5a
      andersca authored
              <rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )
              Null check the request.
              * WebView/WebView.mm:
              (+[WebView _canHandleRequest:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Updating and adding test cases. · f3564481
      lars authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Reviewed by Simon · b2c8d268
      lars authored
              Remove the userHandle methods from QWebnetworkJob again.
              They don't really give us anything and just clutter the API.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hausmann's avatar
      Export the new qt network API. · 9391c471
      hausmann authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Reviewed by Zack. · 31303062
      lars authored
              Add an API layer for network downloads. Basically QWebnetworkInterface
              is an interface class for downloading resources. QWebnetworkJob describes
              the actual object to download.
              QWebNetworkInterface has a default implementation that replaces the
              old ResourceHandleManager class in the Qt port.
              Remove the ResourceHandleManager class, it is now part of 
              QWebNetworkInterface. Adapt ResourceHandle to the new way 
              of things.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Geoff. · 05011d70
      mjs authored
              <rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit
              The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
              empty initial document. However, WebKit still needs the real data source internally, so I also
              added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.
              * Misc/WebNSAttributedStringExtras.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView dataSource]):
              * Plugins/WebNullPluginView.mm:
              (-[WebNullPluginView viewDidMoveToWindow]):
              * Plugins/WebPluginController.mm:
              (-[WebPluginController URLPolicyCheckReferrer]):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge dataSource]):
              (-[WebFrameBridge redirectDataToPlugin:]):
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory bridgeForView:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveFrame:]):
              (+[WebArchiver archiveMainResourceForFrame:]):
              (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
              (+[WebArchiver archiveSelectionInFrame:]):
              * WebView/WebFrame.mm:
              (-[WebFrame _loadURL:referrer:intoChild:]):
              (-[WebFrame _addChild:]):
              (-[WebFrame _dataSource]):
              (-[WebFrame DOMDocument]):
              (-[WebFrame dataSource]):
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
              * WebView/WebRenderNode.mm:
              (-[WebRenderNode initWithWebFrameView:]):
              * WebView/WebView.mm:
              (-[WebView _mainFrameOverrideEncoding]):
              (-[WebView mainFrameURL]):
              (-[WebView mainFrameTitle]):
              (-[WebView mainFrameIcon]):
              (-[WebView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebView replaceSelectionWithArchive:]):
              (-[WebView _isLoading]):
              (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
              (-[WebView _notifyTextSizeMultiplierChanged]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Update test results for improved colgroup span handling. · 60ada7c5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add new layout test for spanning colgroup rules=groups bug. · 870142ec
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Second half of fix for 13793, make sure rules=groups works properly with · 4699f527
      hyatt authored
              spanning colgroups.
              Also make sure colgroups get an actual span of 1 (instead of incorrectly
              giving them a span of 0).
              Reviewed by mitz
              * html/HTMLTableColElement.cpp:
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Half of a fix for 13793, make sure rules=groups and border behave properly · f5fc941d
      hyatt authored
              Reviewed by mitz
              No tests added, two Mozilla table tests now pass that failed before.
              * html/HTMLTableElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 20 May, 2007 6 commits
    • bdash's avatar
      Fix spelling. · a17d2ac0
      bdash authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by Geoose Garen · 2e037c18
      beidson authored
              <rdar://problem/4758919> - Incorrect favicon shown for URL after going back
              When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing 
              shenanigans with the icon url -> page url mapping.  
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
              (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
              (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
              (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Oliver Hunt. · 29df4b01
      darin authored
              - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
              * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
              case where there are no markers. Changed code to iterate over all the nodes in the range
              instead of using TextIterator, which is more efficient.
              * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
              so we don't bother doing work related to spell checking and grammar checking when changing
              the selection in non-editable text. Also rearranged the code so we only compute the old
              word boundaries and sentence boundaries when actually needed, and don't do the sentence
              range checks unless grammar checking is enabled.
              * platform/TextBreakIteratorICU.cpp:
              (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
              (WebCore::characterBreakIterator): Removed local parameter.
              (WebCore::wordBreakIterator): Ditto.
              (WebCore::lineBreakIterator): Ditto.
              (WebCore::sentenceBreakIterator): Ditto.
              * platform/mac/TextBreakIteratorInternalICUMac.mm:
              (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
              (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
              getTextBreakLocale to actually figure it out.
              * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • staikos's avatar
      add -f to cp for some obscure build systems. · 685241da
      staikos authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • staikos's avatar
      Add missing include for auto_ptr · d3ea845a
      staikos authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ddkilzer's avatar
      2007-05-20 David Kilzer <ddkilzer@webkit.org> · eee812d5
      ddkilzer authored
              Reviewed by Adam Roben.
              - fix http://bugs.webkit.org/show_bug.cgi?id=13565
                Change svn-create-patch to put LayoutTests in the end
              In addition to reordering test files under the LayoutTests directory so that they
              appear after source code files, this patch fixes an issue with prepare-ChangeLog
              if the first argument passed to it is a file name instead of a directory name.
              * Scripts/prepare-ChangeLog:
              (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory.
              (isSVN()): Ditto.
              * Scripts/svn-create-patch:
              (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from
              source code files.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 19 May, 2007 4 commits
    • hyatt's avatar
      Fix for bug 13785, O(n^2) counter creation. · 3071affa
      hyatt authored
              Reviewed by darin
              * rendering/RenderCounter.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 97b9586a
      bdash authored
              Reviewed by Dave Hyatt.
              - fix http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
              Tests: fast/repaint/box-shadow-dynamic.html
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
              (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
              (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
              the damage rect intersects.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
              for the "exterior" overflow, add box shadow overflow.
              (WebCore::RenderBlock::overflowWidth): Ditto.
              (WebCore::RenderBlock::overflowLeft): Ditto.
              (WebCore::RenderBlock::overflowTop): Ditto.
              (WebCore::RenderBlock::overflowRect): Ditto.
              (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
              the "exterior" extreme position, add box shadow.
              (WebCore::RenderFlow::rightmostPosition): Ditto.
              (WebCore::RenderFlow::leftmostPosition): Ditto.
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
              the box shadow when an edge with a shadow moves.
              (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
              that expands a given rectangle to encompass outline and box shadow.
              (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
              * rendering/RenderObject.h:
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
              Reviewed by Dave Hyatt.
              - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
              * fast/box-shadow/basic-shadows-expected.checksum:
              * fast/box-shadow/basic-shadows-expected.png:
              * fast/box-shadow/basic-shadows-expected.txt:
              * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
              * fast/repaint/box-shadow-dynamic-expected.png: Added.
              * fast/repaint/box-shadow-dynamic-expected.txt: Added.
              * fast/repaint/box-shadow-dynamic.html: Added.
              * fast/repaint/box-shadow-h-expected.checksum: Added.
              * fast/repaint/box-shadow-h-expected.png: Added.
              * fast/repaint/box-shadow-h-expected.txt: Added.
              * fast/repaint/box-shadow-h.html: Added.
              * fast/repaint/box-shadow-v-expected.checksum: Added.
              * fast/repaint/box-shadow-v-expected.png: Added.
              * fast/repaint/box-shadow-v-expected.txt: Added.
              * fast/repaint/box-shadow-v.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2007-05-20 Mark Rowe <mrowe@apple.com> · 42db1e6f
      bdash authored
              Update test results after r21597.
              * fast/frames/viewsource-attribute-expected.checksum:
              * fast/frames/viewsource-attribute-expected.png:
              * fast/frames/viewsource-attribute-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 357ba6b5
      bdash authored
              Reviewed by Dave Hyatt.
              - fix http://bugs.webkit.org/show_bug.cgi?id=13783
                REGRESSION (r21120): Frame resizers not repainted properly when dragged
              * rendering/RenderFrameSet.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc