Skip to content

GitLab

Switch branch/tag
  1. 09 Apr, 2013 21 commits
    • loki@webkit.org's avatar
      Initialization skipped error on WinCario after r147643 · 667afd9c
      loki@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114258

Reviewed by Csaba Osztrogonác.

Build fix. Adding extra block statement to avoid error C2362 on WinCario

* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      667afd9c
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · ce75559e
      zandobersek@gmail.com authored 
      * platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce75559e
    • rniwa@webkit.org's avatar
      Unreviewed, rolling out r147995. · 21201ec8
      rniwa@webkit.org authored 
      http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261

Wrong gardening. (Requested by gyuyoung on #webkit).


* platform/efl/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21201ec8
    • commit-queue@webkit.org's avatar
      [WK2] Remove build warnings for unused parameters · d19b7347
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114234

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.

Fix build warnings -Wunused-parameter.

Source/WebCore:

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::openInMemory):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
* Modules/indexeddb/IDBLevelDBCoding.h:
(WebCore::IDBLevelDBCoding::encodeIntSafely):
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::canSet):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):

Source/WebKit2:

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoad):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d19b7347
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 61f115b0
      zandobersek@gmail.com authored 
      * platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,
most likely due to libsoup dependency bump.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61f115b0
    • thiago.santos@intel.com's avatar
      [WK2] Drop WebProcess capabilities on Linux using seccomp filters · 0ee9d4d0
      thiago.santos@intel.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=89875

Reviewed by Maciej Stachowiak.

.:

Added the bits to EFL/CMake buildsystem to find the libseccomp
library.

* Source/cmake/FindLibSeccomp.cmake: Added.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.

* PlatformEfl.cmake:

Source/WebKit2:

Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:

- Blocking syscalls that are not used, reducing the size of the attack
surface.
- Trapping sensitive syscalls and delegating the execution of these
syscalls to a separated trusted process subject to a set of policies.

The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.

The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.

Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.

* PlatformEfl.cmake:
* Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):
* Shared/linux/SeccompFilters/OpenSyscall.h: Added.
(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):
* Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):
* Shared/linux/SeccompFilters/SeccompBroker.h: Added.
(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):
* Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):
* Shared/linux/SeccompFilters/SeccompFilters.h: Added.
(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):
* Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.
(WebKit):
(WebKit::SigactionSyscall::createFromContext):
* Shared/linux/SeccompFilters/SigactionSyscall.h: Added.
(WebKit):
(SigactionSyscall):
* Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.
(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):
* Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.
(WebKit):
(SigprocmaskSyscall):
* Shared/linux/SeccompFilters/Syscall.cpp: Added.
(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):
* Shared/linux/SeccompFilters/Syscall.h: Added.
(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):
* Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.
(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
* Shared/linux/SeccompFilters/SyscallPolicy.h: Added.
(WebKit):
(SyscallPolicy):
* Target.pri:
* WebKit2.pri:
* WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
* WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.
(WebKit):
(SeccompFiltersWebProcessEfl):
* WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):
* WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.
(WebKit):
(SeccompFiltersWebProcessQt):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.

We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.

Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):
* efl/jhbuild.modules:
* qmake/mkspecs/features/features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ee9d4d0
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ 32 bit build. · 1a35730e
      carlosgc@webkit.org authored 
      * Source/autotools/symbols.filter: Add some symbols that are
mangled differently in 32 bits due to size_t.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a35730e
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · c4efdb26
      zandobersek@gmail.com authored 
      * platform/gtk/TestExpectations:
* platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
* platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
* platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
* platform/gtk/fast/text/international/003-expected.png:
* platform/gtk/fast/text/international/003-expected.txt:
* platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/gtk/fast/text/international/text-combine-image-test-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4efdb26
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, gardening. · 218f3b60
      gyuyoung.kim@samsung.com authored 
      fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      218f3b60
    • rniwa@webkit.org's avatar
      REGRESSION: Autocorrection doesn't work in DumpRenderTree · f2fca092
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113846

Reviewed by Alexey Proskuryakov.

Tools: 

The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.

Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

LayoutTests: 

Removed failing expectations from tests that require "mesage" to be corrected to "message".

Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).

* platform/mac/TestExpectations:
* platform/mac/editing/spelling/autocorrection-contraction-expected.png:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word-expected.png:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word.html:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
* platform/mac-wk2/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2fca092
    • g.czajkowski@samsung.com's avatar
      [WK2][EFL] Mark not implemented methods in TextCheckerEfl. · 227f0463
      g.czajkowski@samsung.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=112261

Reviewed by Anders Carlsson.

There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.

* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      227f0463
    • paroga@webkit.org's avatar
      Do not set CMAKE_BUILD_TYPE if it is not defined · faf83e24
      paroga@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114243

Reviewed by Geoffrey Garen.

Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf83e24
    • benjamin@webkit.org's avatar
      Remove the gyp files for Tools · ddc26fae
      benjamin@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114248

Reviewed by Ryosuke Niwa.

* DumpRenderTree/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gypi: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddc26fae
    • rniwa@webkit.org's avatar
      Remove yarr.gyp · 29089d62
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114247

Reviewed by Benjamin Poulain.

* yarr/yarr.gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29089d62
    • benjamin@webkit.org's avatar
      Remove gyp from ThirdParty · 07aa50c7
      benjamin@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114244

Rubberstamped by Ryosuke Niwa.

* gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07aa50c7
    • rniwa@webkit.org's avatar
      Remove ANGLE.gyp · 4b3ac027
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114245

Unreviewed. Just removing an empty directory.

* ANGLE.gyp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b3ac027
    • rniwa@webkit.org's avatar
      Remove WebCore.gyp/gypi · a9c9f70c
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114239

Reviewed by Benjamin Poulain.

* WebCore.gyp: Removed.
* WebCore.gyp/.gitignore: Removed.
* WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
* WebCore.gyp/MakeNames.gypi: Removed.
* WebCore.gyp/WebCore.gyp: Removed.
* WebCore.gyp/mac: Removed.
* WebCore.gyp/mac/adjust_visibility.sh: Removed.
* WebCore.gyp/mac/check_objc_rename.sh: Removed.
* WebCore.gyp/scripts: Removed.
* WebCore.gyp/scripts/action_csspropertynames.py: Removed.
* WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
* WebCore.gyp/scripts/action_makenames.py: Removed.
* WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
* WebCore.gyp/scripts/rule_bison.py: Removed.
* WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
* WebCore.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9c9f70c
    • rniwa@webkit.org's avatar
      Remove JavaScriptCore.gyp/gypi · d39ebd88
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114238

Reviewed by Benjamin Poulain.

* JavaScriptCore.gyp: Removed.
* JavaScriptCore.gyp/.gitignore: Removed.
* JavaScriptCore.gypi: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d39ebd88
    • commit-queue@webkit.org's avatar
      Adds fromCharCode intrinsic support. · aa31a5ed
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=104807

Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.

Switch to using fromCharCode intrinsic instead of call operation in some cases.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
* runtime/StringConstructor.h:
(JSC):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa31a5ed
    • rniwa@webkit.org's avatar
      WKR (new-commit-bot) is too slow · 100be7f0
      rniwa@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=110087

Reviewed by Geoffrey Garen.

Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.

Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      100be7f0
    • commit-queue@webkit.org's avatar
      Rollout r147756: performance regression · 57c76062
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=114176

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-08
Reviewed by Alexis Menard.

Source/WebCore:

Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .

No new tests (because this is a rollout patch).

* dom/Element.cpp:
* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/NodeRenderingContext.h:
* dom/PseudoElement.h:
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
* dom/Text.h:
* rendering/FlowThreadController.cpp:
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
* svg/SVGElement.h:

LayoutTests:

* fast/regions/flow-body-in-html-expected.txt: Removed.
* fast/regions/flow-body-in-html.html: Removed.
* fast/regions/region-content-flown-into-region-expected.html: Removed.
* fast/regions/region-content-flown-into-region.html: Removed.
* fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
* fast/regions/universal-selector-children-to-the-same-region.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57c76062
  3. 08 Apr, 2013 19 commits