1. 23 Jan, 2014 1 commit
  2. 14 Jan, 2014 1 commit
    • commit-queue@webkit.org's avatar
      REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89... · 8937cd10
      commit-queue@webkit.org authored
      REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
      https://bugs.webkit.org/show_bug.cgi?id=126702
      
      Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-14
      Reviewed by Alexey Proskuryakov.
      
      Resolve regression and remove a FIXME comment that is already fixed.
      
      * Scripts/webkitpy/common/system/filesystem.py:
      (FileSystem.open_text_file_for_reading):
      * Scripts/webkitpy/common/system/filesystem_unittest.py:
      (RealFileSystemTest.test_read_and_write_file):
      * Scripts/webkitpy/style/filereader.py:
      (TextFileReader._read_lines):
      * Scripts/webkitpy/style/filereader_unittest.py:
      (TextFileReaderTest.test_count_delete_only_file):
      (TextFileReaderTest):
      (TextFileReaderTest.test_process_malformed_file):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8937cd10
  3. 04 Dec, 2013 1 commit
  4. 21 Nov, 2013 1 commit
  5. 17 Nov, 2011 1 commit
  6. 17 Dec, 2010 1 commit
    • mitz@apple.com's avatar
      Rename WebKitTools to Tools · 10955a5a
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49861
      
      Reviewed by Simon Fraser.
      
      .: 
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * MakeFile:
      * MakeFile.shared:
      * Tools: Renamed from WebKitTools.
      * WebKit.pro:
      * cmake/WebKitPackaging.cmake:
      * wscript:
      
      BugsSite: 
      
      * PrettyPatch/PrettyPatch.rb:
      * committers-autocomplete.js:
      
      Tools: 
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      * CodeCoverage/README:
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::initializeFonts):
      * EWSTools/start-commit-queue.sh:
      * EWSTools/start-queue.sh:
      * GNUmakefile.am:
      * MIDLWrapper/MIDLWrapper.cpp:
      (wmain):
      * MiniBrowser/qt/MiniBrowser.pro:
      * Scripts/build-api-tests:
      * Scripts/build-dumprendertree:
      * Scripts/build-webkit:
      * Scripts/build-webkittestrunner:
      * Scripts/generate-coverage-data:
      * Scripts/old-run-webkit-tests:
      * Scripts/run-api-tests:
      * Scripts/run-iexploder-tests:
      * Scripts/run-javascriptcore-tests:
      * Scripts/run-mangleme-tests:
      * Scripts/run-sunspider:
      * Scripts/run-webkit-websocketserver:
      * Scripts/sunspider-compare-results:
      * Scripts/test-webkitperl:
      * Scripts/test-webkitpy:
      * Scripts/update-iexploder-cssproperties:
      * Scripts/update-webkit:
      * Scripts/update-webkit-localizable-strings:
      * Scripts/webkitdirs.pm:
      * Scripts/webkitpy/common/checkout/scm.py:
      * Scripts/webkitpy/common/checkout/scm_unittest.py:
      * Scripts/webkitpy/common/config/committervalidator.py:
      * Scripts/webkitpy/common/config/committervalidator_unittest.py:
      * Scripts/webkitpy/common/config/ports.py:
      * Scripts/webkitpy/common/config/ports_unittest.py:
      * Scripts/webkitpy/common/system/logutils_unittest.py:
      * Scripts/webkitpy/common/system/ospath_unittest.py:
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      * Scripts/webkitpy/layout_tests/port/config.py:
      * Scripts/webkitpy/layout_tests/port/config_unittest.py:
      * Scripts/webkitpy/layout_tests/port/http_server.py:
      * Scripts/webkitpy/layout_tests/port/test.py:
      * Scripts/webkitpy/style/checker.py:
      * Scripts/webkitpy/style/checker_unittest.py:
      * Scripts/webkitpy/tool/bot/feeders_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/steps/steps_unittest.py:
      * WebKitTestRunner/DerivedSources.pro:
      * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
      (WTR::activateFonts):
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * wx/build/build_utils.py:
      
      WebKitSite: 
      
      * asking_questions.html:
      * building/tools.html:
      * coding/scripts.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10955a5a
  7. 05 Aug, 2010 1 commit
  8. 26 Apr, 2010 1 commit
    • cjerdonek@webkit.org's avatar
      2010-04-26 Chris Jerdonek <cjerdonek@webkit.org> · 074e2569
      cjerdonek@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Changed the StyleChecker class to use the new TextFileReader class.
      
              https://bugs.webkit.org/show_bug.cgi?id=37066
      
              This revision separates the code responsible for reading and iterating
              over text files from the rest of check-webkit-style.
      
              * Scripts/check-webkit-style:
                - Changed the script to use the new StyleProcessor and
                  TextFileReader classes instead of the StyleChecker class.
      
              * Scripts/webkitpy/style/checker.py:
                - Added a FIXME to rename many of uses of the word "processor" to
                  "checker".  We did this to clarify the difference between
                  ProcessorBase instances passed to the TextFileReader and
                  classes that process and check lines for style.
                - Added a FIXME to remove FileType.NONE as a possible return value
                  of ProcessorDispatcher._file_type().  This will better consolidate
                  the logic of which files should be skipped.
                - Added a FIXME to delete the StyleChecker class.
                - Added the StyleProcessor class which implements ProcessorBase.
                  This class is responsible for processing lines to check style
                  (but not for reading files).  For each file, this class creates
                  creates both a carriage-return checker and a format-specific
                  style checker (e.g. one of C++, Python, etc).
                - Updated the PatchChecker class to use a TextFileReader instance
                  instead of a StyleChecker.
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
                  tests of the StyleProcessor class.
                - Added the StyleProcessor_CodeCoverageTest to test the
                  StyleProcessor class with more complete code coverage.
                  Unlike the StyleProcessor_EndToEndTest class, this class makes
                  heavy use of mock parameters.
                - Added FIXME's to delete the unit test classes that are no
                  longer needed.
                - Updated the PatchCheckerTest class to use a MockTextFileReader
                  instead of a MockStyleChecker.
      
              * Scripts/webkitpy/style/filereader.py:
                - Updated the TextFileReader class to use the preferred logic
                  of checking file existence at the beginning of the process_file()
                  method instead of in the except block, per
                  https://bugs.webkit.org/show_bug.cgi?id=37122
      
              * Scripts/webkitpy/style/filereader_unittest.py:
                - In the TextFileReaderTest class:
                  - Moved the test_process_file__should_not_process() method.
                  - Added a test_process_file__file_stdin() method to test
                    the file path "-".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      074e2569
  9. 18 Apr, 2010 1 commit
    • cjerdonek@webkit.org's avatar
      Created a class for check-webkit-style that encapsulates iterating · e09d3d36
      cjerdonek@webkit.org authored
      over text files and reading them.
      
      Reviewed by Shinichiro Hamaji.
      
      https://bugs.webkit.org/show_bug.cgi?id=37754
      
      This revision is an intermediate step towards separating our
      style-checking code from the logic of iterating over files and
      reading them.
      
      * Scripts/webkitpy/common/system/logtesting.py:
        - Added a logMessages() method to the LoggingTestCase class.
          This method provides unit tests with access to the raw list
          of log messages in case the tester needs to do something more
          than simply assert the list of existing messages.
      
      * Scripts/webkitpy/style/checker.py:
        - Added a ProcessorBase class that processors of lists of lines
          should eventually inherit from.
        - Also added a FIXME to use the ProcessorBase class and the
          TextFileReader class added below.
      
      * Scripts/webkitpy/style/filereader.py: Added.
        - Created a TextFileReader class that encapsulates reading
          and iterating over text files.
      
      * Scripts/webkitpy/style/filereader_unittest.py: Added.
        - Added a TextFileReaderTest class to unit-test the
          new TextFileReader class.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e09d3d36