1. 29 Nov, 2013 19 commits
    • commit-queue@webkit.org's avatar
      Fix build warnings in WebKit2 · 65e08ce6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125012
      
      Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-29
      Reviewed by Anders Carlsson.
      
      fix unused parameter warnings in the following files:
      
      * Platform/gtk/WorkQueueGtk.cpp:
      (WorkQueue::SocketEventSource::eventCallback):
      * Shared/API/c/WKDeprecatedFunctions.cpp:
      (WKArrayIsMutable):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::didAddHeaderLayer):
      (WebKit::WebChromeClient::didAddFooterLayer):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65e08ce6
    • weinig@apple.com's avatar
      [Cocoa] Add a little template magic to the inline API::Object storage to... · dabfd714
      weinig@apple.com authored
      [Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
      https://bugs.webkit.org/show_bug.cgi?id=125024
      
      Reviewed by Dan Bernstein.
      
      Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
      to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using 
      std::aligned_storage.
      
      * Shared/Cocoa/WKNSArray.mm:
      * Shared/Cocoa/WKNSDictionary.mm:
      * Shared/Cocoa/WKObject.h:
      * UIProcess/API/Cocoa/WKBackForwardList.mm:
      * UIProcess/API/Cocoa/WKBackForwardListItem.mm:
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
      * UIProcess/API/Cocoa/WKNavigationData.mm:
      * UIProcess/API/Cocoa/WKProcessGroup.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dabfd714
    • weinig@apple.com's avatar
      Fix crashing API tests. · 7dd3a0e9
      weinig@apple.com authored
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController dealloc]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd3a0e9
    • weinig@apple.com's avatar
      Fix some style boo-boos. · c6df4a5d
      weinig@apple.com authored
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController loadDelegate]):
      (-[WKBrowsingContextController setLoadDelegate:]):
      (-[WKBrowsingContextController policyDelegate]):
      (-[WKBrowsingContextController setPolicyDelegate:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6df4a5d
    • weinig@apple.com's avatar
      Fix the iOS build. · a329fd72
      weinig@apple.com authored
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController loadDelegate]):
      (-[WKBrowsingContextController policyDelegate]):
      (-[WKBrowsingContextController setPolicyDelegate:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a329fd72
    • weinig@apple.com's avatar
      [Cocoa] Make WKBrowsingContextController work with WKObject wrapping · 0e131da2
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125022
      
      Reviewed by Dan Bernstein.
      
      * Shared/Cocoa/APIObject.mm:
      (API::Object::newObject):
              
      * Shared/mac/ObjCObjectGraphCoders.mm:
      Add support for WKProcessGroup.
      
      (WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
      Replace call to _browsingContextControllerForPageRef: with wrapper.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.
      
      (-[WKBrowsingContextController dealloc]):
      Add explicit destructor call.
      
      (-[WKBrowsingContextController setLoadDelegate:]):
      (-[WKBrowsingContextController setPolicyDelegate:]):
      Lazily set up the load and policy clients only once a delegate has been set to allow
      continued use of the C-SPI clients for WebKitTestRunner.
      
      (-[WKBrowsingContextController _finishInitialization]):
      Move remaining work that was done in the initialize (setting up the observer) here,
      and have the WebPageProxy call it.
      
      * UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
      (WebKit::wrapper):
      Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
      _initWithPageRef: and _browsingContextControllerForPageRef: helpers.
      
      * UIProcess/API/Cocoa/WKProcessGroup.mm:
      (didNavigateWithNavigationData):
      (didPerformClientRedirect):
      (didPerformServerRedirect):
      (didUpdateHistoryTitle):
      Switch to using wrapper().
      
      * UIProcess/API/ios/WKContentView.mm:
      * UIProcess/API/mac/WKView.mm:
      Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
      as the WebPageProxy.
      
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::platformInitialize):
      Inform the wrapper that it is safe to finish initialization.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e131da2
    • mitz@apple.com's avatar
      [Cocoa] Add a way to recover from load errors · ec6a0371
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125020
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
      the given error, adding two keys to the user info dictionary: the context controller under
      the recovery attempter key, and the frame under a private key.
      (didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
      (didFailLoadWithErrorForFrame): Ditto.
      (-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
      WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
      frame from the error.
      
      * UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting
      recovery from errors and declares the error user info dictionary key under which an object
      conforming to this protocol may be stored.
      * UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines
      WKRecoveryAttempterErrorKey.
      
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.
      * UIProcess/WebFrameProxy.h:
      
      * WebKit2.xcodeproj/project.pbxproj: Added references to new files.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec6a0371
    • mitz@apple.com's avatar
      [Cocoa] Expose loadAlternateHTMLString via the API · 4386e33c
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125019
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
      Calls WebPageProxy::loadAlternateHTMLString.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4386e33c
    • weinig@apple.com's avatar
      Move API files shared between Mac and iOS to the Cocoa directory · 06c4e291
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125017
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
      * UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
      * UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
      * UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
      * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
      * UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
      * UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
      * UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
      * UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
      * UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
      * UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
      * UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
      * UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
      * UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
      * UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
      * UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
      * UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
      * UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
      * UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
      * UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
      * UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
      * UIProcess/API/mac/WKBrowsingContextController.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
      * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
      * UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
      * UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
      * UIProcess/API/mac/WKConnection.h: Removed.
      * UIProcess/API/mac/WKConnection.mm: Removed.
      * UIProcess/API/mac/WKConnectionInternal.h: Removed.
      * UIProcess/API/mac/WKProcessGroup.h: Removed.
      * UIProcess/API/mac/WKProcessGroup.mm: Removed.
      * UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
      * UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
      * UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
      * UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
      * UIProcess/API/mac/WKView.h: Removed.
      * UIProcess/API/mac/WKViewPrivate.h: Removed.
      * UIProcess/API/mac/WebKit2.h: Removed.
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06c4e291
    • commit-queue@webkit.org's avatar
      Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports. · 88c9a6dc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124936
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
      Reviewed by Zoltan Herczeg.
      
      The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
      src FPRegister and are likely to be more efficient than the current generic implementation
      using the stack.
      
      * jit/SpecializedThunkJIT.h:
      (JSC::SpecializedThunkJIT::returnDouble):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88c9a6dc
    • commit-queue@webkit.org's avatar
      check-webkit-style should check for extraneous newline between config.h and primary header. · 8c28d218
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124821
      
      Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-29
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_include_line):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (OrderOfIncludesTest.test_check_line_break_after_own_header):
      (OrderOfIncludesTest):
      (OrderOfIncludesTest.test_check_line_break_before_own_header):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c28d218
    • commit-queue@webkit.org's avatar
      Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions. · 99e3760b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124892
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
      Reviewed by Zoltan Herczeg.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
      parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.
      * jit/ThunkGenerators.cpp:
      (JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99e3760b
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 72af06f4
      m.pakula@samsung.com authored
      Accessibility rebaselines after r159848.
      
      * platform/efl-wk1/accessibility/table-detection-expected.txt:
      * platform/efl-wk2/accessibility/table-detection-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72af06f4
    • commit-queue@webkit.org's avatar
      Remove Symbian specific code. · 78c05a31
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124939
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-29
      Reviewed by Zoltan Herczeg.
      
      Symbian is not supported, remove leftover code.
      
      * plugins/npapi.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78c05a31
    • ossy@webkit.org's avatar
      test-webkit-scripts should show the failing tests and use an appropriate exit code · 509f6a88
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124840
      
      Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-29
      Reviewed by Ryosuke Niwa.
      
      A fixme in test-webkit-scripts asked that the script should display success or failiure
      and exit with a 0 or 1 value accordingly after all of the tests have completed.
      
      * Scripts/test-webkit-scripts:
      (ScriptsTester.run_test_script):
      The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
      because at this point we don't need to pass on more information other than success or failiure.
      (ScriptsTester.main):
      The return values are now stored for each script and when all tests have completed successfully,
      the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      509f6a88
    • commit-queue@webkit.org's avatar
      [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk · 0fff9b7e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124923
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-29
      Reviewed by Mario Sanchez Prada.
      
      Tools:
      
      Added missing implementation of isAttributeSettable. Using
      ATK_STATE_EDITABLE for checking whether attribute is settable.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::isAttributeSettable):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::isAttributeSettable):
      
      LayoutTests:
      
      Test could be reused by EFL and GTK as well.
      
      * accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
      * accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fff9b7e
    • commit-queue@webkit.org's avatar
      [cmake] Fix cmake warning: Argument not separated from preceding token by whitespace · ca8c07ef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124899
      
      Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-29
      Reviewed by Gyuyoung Kim.
      
      * Source/cmake/FindCairo.cmake:
      * Source/cmake/FindGStreamer.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca8c07ef
    • commit-queue@webkit.org's avatar
      [EFL] viewport must be same with the size of webview · 39fae4f2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124965
      
      Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2013-11-29
      Reviewed by Gyuyoung Kim.
      
      Currently, size of the viewport is larger than size of webview.
      Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.
      
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::displayTimerFired): Changed to use the (0,0).
      (EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
      (EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39fae4f2
    • commit-queue@webkit.org's avatar
      [CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView. · 294cf41d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118548
      
      Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-28
      Reviewed by Noam Rosenthal.
      
      CoordinatedGraphics uses its own scaling logic - contents scaling - and
      WebView of CoordinatedGraphics maintains contents position by scaling
      with contents scaling factor.
      However transformToScene() and updateViewportSize() of WebView regard
      the contents position as a non-scaled value, so it should be fixed.
      
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::transformToScene):
      (WebKit::WebView::updateViewportSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      294cf41d
  2. 28 Nov, 2013 21 commits