1. 20 Sep, 2012 40 commits
    • fpizlo@apple.com's avatar
      CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it · 658e5ebd
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97260
      
      Rubber stamped by Geoffrey Garen.
              
      Supporting it will become difficult as we add more indexing types. It makes more
      sense to kill, especially since we don't appear to use it or test it, ever.
      
      * runtime/ArrayConventions.h:
      (JSC):
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncSplice):
      * runtime/ArrayStorage.h:
      (JSC::ArrayStorage::copyHeaderFromDuringGC):
      (ArrayStorage):
      * runtime/FunctionPrototype.cpp:
      (JSC::functionProtoFuncBind):
      * runtime/JSArray.cpp:
      (JSC::createArrayButterflyInDictionaryIndexingMode):
      (JSC::JSArray::setLength):
      (JSC::JSArray::pop):
      (JSC::JSArray::push):
      (JSC::JSArray::sortNumeric):
      (JSC::JSArray::sort):
      (JSC::JSArray::compactForSorting):
      * runtime/JSArray.h:
      (JSArray):
      (JSC::createArrayButterfly):
      (JSC::JSArray::tryCreateUninitialized):
      (JSC::constructArray):
      * runtime/JSObject.cpp:
      (JSC::JSObject::putByIndex):
      (JSC::JSObject::createArrayStorage):
      (JSC::JSObject::deletePropertyByIndex):
      (JSC):
      * runtime/JSObject.h:
      (JSC::JSObject::initializeIndex):
      (JSObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      658e5ebd
    • tony@chromium.org's avatar
      [chromium] Enable more clang warnings · 404e130b
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97257
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
      warns on this and it's a common source of error for Chromium patches.
      
      No new tests, should compile cleanly.
      
      * WebCore.gyp/WebCore.gyp:
      
      Source/WebKit/chromium:
      
      * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
      * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
      there are lots of violations in these files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      404e130b
    • mitz@apple.com's avatar
      Kerning never occurs between a space and the following glyph · fd2cf34c
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97269
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      Covered by several existing tests.
      
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to not reset the advance
      of a space, and added a comment about how this also needs to be fixed for other characters
      that are treated as spaces.
      
      LayoutTests: 
      
      * platform/mac/fast/text/emphasis-expected.png:
      * platform/mac/fast/text/emphasis-expected.txt:
      * platform/mac/fast/text/sticky-typesetting-features-expected.png:
      * platform/mac/fast/text/sticky-typesetting-features-expected.txt:
      * platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
      * platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
      * platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
      * platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd2cf34c
    • bashi@chromium.org's avatar
      [Chromium] Improve glyph selection of HarfBuzzShaper · f5c9cef7
      bashi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97164
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Take into account clusters for selection.
      
      Test: fast/text/international/hebrew-selection.html
      
      * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
      (WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Removed m_logClusters.
      m_logCluster is no longer used.
      (WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
      - If targetX is in the left side of the first cluster, return the leftmost character index.
      - If targetX is in the right side of the last cluster, return the rightmost character index.
      - If targetX is between the right side of the cluster N and the left side of the cluster N+1, then:
        - return N+1 for LTR.
        - return N for RTL.
      (WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
      Find the cluster of index in question, then:
      - return the left side boundary of the cluster for LTR.
      - return the right side boundary of the cluster for RTL.
      * platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
      (HarfBuzzRun):
      
      LayoutTests:
      
      Added a test for complex text selection.
      
      * fast/text/international/hebrew-selection-expected.html: Added.
      * fast/text/international/hebrew-selection.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5c9cef7
    • tony@chromium.org's avatar
      Replace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight · 3a2abc74
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97263
      
      Reviewed by Ojan Vafai.
      
      This is part of making computeLogicalHeight virtual so with any RenderBox pointer, one
      can compute the logical height without mutating the RenderBox.
      
      No new tests, this is a refactor and existing list box tests should pass.
      
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::layout): Move layout related logic here.
      (WebCore::RenderListBox::computeLogicalHeight): Use const version and remove layout related code.
      * rendering/RenderListBox.h:
      (RenderListBox): Override computeLogicalHeight.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a2abc74
    • lforschler@apple.com's avatar
      Versioning · 25146e1c
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25146e1c
    • dpranke@chromium.org's avatar
      make Skip, WontFix be the only expectations on a line · c76f2284
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97225
      
      Unreviewed, expectations change.
      
      This change updates all of the expectations files, but doesn't
      actually change the code to issue warnings in this case (that
      will come in a subsequent patch).
      
      * platform/chromium-android/TestExpectations:
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk-wk2/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt-arm/TestExpectations:
      * platform/qt-mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c76f2284
    • dgrogan@chromium.org's avatar
      Fix IndexedDB unit tests · b31dbc36
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97149
      
      Reviewed by Tony Chang.
      
      * tests/IDBDatabaseBackendTest.cpp:
      Specify a desired version of -1 so that no version change transaction
      is run.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b31dbc36
    • commit-queue@webkit.org's avatar
      [Qt] Remove entries for deleted tests from Skipped list · 42125c02
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97213
      
      Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-20
      Reviewed by Simon Hausmann.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42125c02
    • commit-queue@webkit.org's avatar
      CSP reports should send an empty "blocked-uri" rather than nothing. · 7e670c9e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97256
      
      Patch by Mike West <mkwst@chromium.org> on 2012-09-20
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      In cases where a Content Security Policy violation report is generated
      without blocking a resource at a particular URI (inline scripts, for
      example), we currently leave the "blocked-uri" attribute out of the
      report entirely. For the same reason that we included the "referrer"
      attribute in webkit.org/b/97233, we should include an explicitly empty
      "blocked-uri" in these cases.
      
      This new behavior is covered by updates to existing test expectations
      around the reporting functionality.
      
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::reportViolation):
          If the 'blocked-uri' is invalid, add a "blocked-uri" attribute that
          is explicitly empty.
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
          Updating test expectations to include an explicitly empty
          "blocked-uri" as opposed to leaving it off entirely.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e670c9e
    • dpranke@chromium.org's avatar
      roll Chromium to r157829. · 71fc019d
      dpranke@chromium.org authored
      Unreviewed, deps change.
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71fc019d
    • japhet@chromium.org's avatar
      2012-09-20 Nate Chapin <japhet@chromium.org> · 6642a569
      japhet@chromium.org authored
              Unreviewed, chromium win build fix.
              Remove spurious reference to the non-existent
              tests/LayerPainterChromium.h in WebKit.gypi.
      
              * WebKit.gypi:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6642a569
    • paroga@webkit.org's avatar
      Source/WebCore: Add String::numberToFixedPrecisionString() · 19abbf92
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96330
      
      Reviewed by Benjamin Poulain.
      
      * platform/text/TextStream.cpp:
      (WebCore::TextStream::operator<<): Use the new function instead of String::number() with flags.
      
      Source/WebKit2: Add String::numberToStringFixedWidth()
      https://bugs.webkit.org/show_bug.cgi?id=96330
      
      Reviewed by Benjamin Poulain.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      Source/WTF: Add String::numberToStringFixedWidth()
      https://bugs.webkit.org/show_bug.cgi?id=96330
      
      Reviewed by Benjamin Poulain.
      
      Add this new function as replacement for the ShouldRoundDecimalPlaces flag of String::number()
      and remove the now unnecessary branch in String::number() for the old flags.
      
      * wtf/text/WTFString.cpp:
      (WTF::String::number):
      (WTF::String::numberToStringFixedWidth):
      * wtf/text/WTFString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19abbf92
    • adamk@chromium.org's avatar
      Rename ContainerNode::parserAddChild "parserAppendChild" for consistency · f7d1f541
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97254
      
      Reviewed by Adam Barth.
      
      No functional change, all the below changes are simple renames.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      (WebCore::ContainerNode::parserAppendChild):
      * dom/ContainerNode.h:
      (ContainerNode):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * editing/markup.cpp:
      (WebCore::createFragmentForTransformToFragment):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::createContainingTable):
      (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
      (WebCore::HTMLViewSourceDocument::addLine):
      (WebCore::HTMLViewSourceDocument::finishLine):
      (WebCore::HTMLViewSourceDocument::addText):
      (WebCore::HTMLViewSourceDocument::addBase):
      (WebCore::HTMLViewSourceDocument::addLink):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::executeTask):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
      * html/track/WebVTTParser.cpp:
      (WebCore::WebVTTParser::constructTreeFromToken):
      * xml/XMLErrors.cpp:
      (WebCore::createXHTMLParserErrorHeader):
      (WebCore::XMLErrors::insertErrorMessageBlock):
      * xml/parser/XMLDocumentParser.cpp:
      (WebCore::XMLDocumentParser::enterText):
      (WebCore::XMLDocumentParser::parseDocumentFragment):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::startElementNs):
      (WebCore::XMLDocumentParser::processingInstruction):
      (WebCore::XMLDocumentParser::cdataBlock):
      (WebCore::XMLDocumentParser::comment):
      (WebCore::XMLDocumentParser::internalSubset):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parseStartElement):
      (WebCore::XMLDocumentParser::parseProcessingInstruction):
      (WebCore::XMLDocumentParser::parseCdata):
      (WebCore::XMLDocumentParser::parseComment):
      (WebCore::XMLDocumentParser::parseDtd):
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      (WebCore::XMLTreeBuilder::processStartTag):
      (WebCore::XMLTreeBuilder::add):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d1f541
    • simon.fraser@apple.com's avatar
      77f0da79
    • abarth@webkit.org's avatar
      Remove empty directory. · 4a4e22d8
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a4e22d8
    • rniwa@webkit.org's avatar
      Results page should show indivisual value · 77342950
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97178
      
      Reviewed by Tony Chang.
      
      Show indivisual values instead of statistics (min, max, stdev).
      
      * resources/results-template.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77342950
    • jamesr@google.com's avatar
      [chromium] Remove unused copy of chromium compositor implementation files · 4e39fd79
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97255
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Now that use_libcc_for_compositor is set to 1 these files aren't used anywhere.
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * platform/chromium/support/CCThreadImpl.cpp: Removed.
      * platform/chromium/support/CCThreadImpl.h: Removed.
      * platform/chromium/support/WebCompositorImpl.cpp: Removed.
      * platform/chromium/support/WebCompositorImpl.h: Removed.
      * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
      * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Removed.
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
      (WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
      (WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
      * platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
      * platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/ContentLayerChromium.cpp: Removed.
      * platform/graphics/chromium/ContentLayerChromium.h: Removed.
      * platform/graphics/chromium/ContentLayerChromiumClient.h: Removed.
      * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Removed.
      * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/GeometryBinding.cpp: Removed.
      * platform/graphics/chromium/GeometryBinding.h: Removed.
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      * platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp: Removed.
      * platform/graphics/chromium/HeadsUpDisplayLayerChromium.h: Removed.
      * platform/graphics/chromium/IOSurfaceLayerChromium.cpp: Removed.
      * platform/graphics/chromium/IOSurfaceLayerChromium.h: Removed.
      * platform/graphics/chromium/ImageLayerChromium.cpp: Removed.
      * platform/graphics/chromium/ImageLayerChromium.h: Removed.
      * platform/graphics/chromium/LayerChromium.cpp: Removed.
      * platform/graphics/chromium/LayerChromium.h: Removed.
      * platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
      * platform/graphics/chromium/LayerTextureSubImage.h: Removed.
      * platform/graphics/chromium/LayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/PlatformColor.h: Removed.
      * platform/graphics/chromium/ProgramBinding.cpp: Removed.
      * platform/graphics/chromium/ProgramBinding.h: Removed.
      * platform/graphics/chromium/RateLimiter.cpp: Removed.
      * platform/graphics/chromium/RateLimiter.h: Removed.
      * platform/graphics/chromium/RenderSurfaceChromium.cpp: Removed.
      * platform/graphics/chromium/RenderSurfaceChromium.h: Removed.
      * platform/graphics/chromium/ScrollbarLayerChromium.cpp: Removed.
      * platform/graphics/chromium/ScrollbarLayerChromium.h: Removed.
      * platform/graphics/chromium/ShaderChromium.cpp: Removed.
      * platform/graphics/chromium/ShaderChromium.h: Removed.
      * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
      * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
      * platform/graphics/chromium/SolidColorLayerChromium.cpp: Removed.
      * platform/graphics/chromium/SolidColorLayerChromium.h: Removed.
      * platform/graphics/chromium/TextureCopier.cpp: Removed.
      * platform/graphics/chromium/TextureCopier.h: Removed.
      * platform/graphics/chromium/TextureLayerChromium.cpp: Removed.
      * platform/graphics/chromium/TextureLayerChromium.h: Removed.
      * platform/graphics/chromium/TextureLayerChromiumClient.h: Removed.
      * platform/graphics/chromium/ThrottledTextureUploader.cpp: Removed.
      * platform/graphics/chromium/ThrottledTextureUploader.h: Removed.
      * platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
      * platform/graphics/chromium/TiledLayerChromium.h: Removed.
      * platform/graphics/chromium/TreeSynchronizer.cpp: Removed.
      * platform/graphics/chromium/TreeSynchronizer.h: Removed.
      * platform/graphics/chromium/UnthrottledTextureUploader.h: Removed.
      * platform/graphics/chromium/VideoLayerChromium.cpp: Removed.
      * platform/graphics/chromium/VideoLayerChromium.h: Removed.
      * platform/graphics/chromium/cc/CCActiveAnimation.cpp: Removed.
      * platform/graphics/chromium/cc/CCActiveAnimation.h: Removed.
      * platform/graphics/chromium/cc/CCAnimationCurve.cpp: Removed.
      * platform/graphics/chromium/cc/CCAnimationCurve.h: Removed.
      * platform/graphics/chromium/cc/CCAnimationEvents.h: Removed.
      * platform/graphics/chromium/cc/CCAppendQuadsData.h: Removed.
      * platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCCompletionEvent.h: Removed.
      * platform/graphics/chromium/cc/CCDamageTracker.cpp: Removed.
      * platform/graphics/chromium/cc/CCDamageTracker.h: Removed.
      * platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCDebugRectHistory.cpp: Removed.
      * platform/graphics/chromium/cc/CCDebugRectHistory.h: Removed.
      * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Removed.
      * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Removed.
      * platform/graphics/chromium/cc/CCDirectRenderer.cpp: Removed.
      * platform/graphics/chromium/cc/CCDirectRenderer.h: Removed.
      * platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCFontAtlas.cpp: Removed.
      * platform/graphics/chromium/cc/CCFontAtlas.h: Removed.
      * platform/graphics/chromium/cc/CCFrameRateController.cpp: Removed.
      * platform/graphics/chromium/cc/CCFrameRateController.h: Removed.
      * platform/graphics/chromium/cc/CCFrameRateCounter.cpp: Removed.
      * platform/graphics/chromium/cc/CCFrameRateCounter.h: Removed.
      * platform/graphics/chromium/cc/CCGraphicsContext.h: Removed.
      * platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCInputHandler.h: Removed.
      * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp: Removed.
      * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h: Removed.
      * platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerAnimationController.h: Removed.
      * platform/graphics/chromium/cc/CCLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
      * platform/graphics/chromium/cc/CCLayerQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerQuad.h: Removed.
      * platform/graphics/chromium/cc/CCLayerSorter.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerSorter.h: Removed.
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerTilingData.h: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHostClient.h: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
      * platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
      * platform/graphics/chromium/cc/CCMathUtil.h: Removed.
      * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
      * platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.
      * platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Removed.
      * platform/graphics/chromium/cc/CCOverdrawMetrics.h: Removed.
      * platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Removed.
      * platform/graphics/chromium/cc/CCPageScaleAnimation.h: Removed.
      * platform/graphics/chromium/cc/CCPrioritizedTexture.cpp: Removed.
      * platform/graphics/chromium/cc/CCPrioritizedTexture.h: Removed.
      * platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: Removed.
      * platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: Removed.
      * platform/graphics/chromium/cc/CCPriorityCalculator.cpp: Removed.
      * platform/graphics/chromium/cc/CCPriorityCalculator.h: Removed.
      * platform/graphics/chromium/cc/CCProxy.cpp: Removed.
      * platform/graphics/chromium/cc/CCProxy.h: Removed.
      * platform/graphics/chromium/cc/CCQuadCuller.cpp: Removed.
      * platform/graphics/chromium/cc/CCQuadCuller.h: Removed.
      * platform/graphics/chromium/cc/CCQuadSink.h: Removed.
      * platform/graphics/chromium/cc/CCRenderPass.cpp: Removed.
      * platform/graphics/chromium/cc/CCRenderPass.h: Removed.
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCRenderPassSink.h: Removed.
      * platform/graphics/chromium/cc/CCRenderSurface.cpp: Removed.
      * platform/graphics/chromium/cc/CCRenderSurface.h: Removed.
      * platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Removed.
      * platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Removed.
      * platform/graphics/chromium/cc/CCRenderer.h: Removed.
      * platform/graphics/chromium/cc/CCRendererGL.cpp: Removed.
      * platform/graphics/chromium/cc/CCRendererGL.h: Removed.
      * platform/graphics/chromium/cc/CCRenderingStats.h: Removed.
      * platform/graphics/chromium/cc/CCResourceProvider.cpp: Removed.
      * platform/graphics/chromium/cc/CCResourceProvider.h: Removed.
      * platform/graphics/chromium/cc/CCScheduler.cpp: Removed.
      * platform/graphics/chromium/cc/CCScheduler.h: Removed.
      * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
      * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
      * platform/graphics/chromium/cc/CCScopedTexture.cpp: Removed.
      * platform/graphics/chromium/cc/CCScopedTexture.h: Removed.
      * platform/graphics/chromium/cc/CCScopedThreadProxy.h: Removed.
      * platform/graphics/chromium/cc/CCScrollbarAnimationController.cpp: Removed.
      * platform/graphics/chromium/cc/CCScrollbarAnimationController.h: Removed.
      * platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.cpp: Removed.
      * platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.h: Removed.
      * platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp: Removed.
      * platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h: Removed.
      * platform/graphics/chromium/cc/CCScrollbarGeometryStub.cpp: Removed.
      * platform/graphics/chromium/cc/CCScrollbarGeometryStub.h: Removed.
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCSettings.cpp: Removed.
      * platform/graphics/chromium/cc/CCSettings.h: Removed.
      * platform/graphics/chromium/cc/CCSharedQuadState.cpp: Removed.
      * platform/graphics/chromium/cc/CCSharedQuadState.h: Removed.
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Removed.
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h: Removed.
      * platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCSolidColorDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCTexture.cpp: Removed.
      * platform/graphics/chromium/cc/CCTexture.h: Removed.
      * platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCTextureDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCTextureLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Removed.
      * platform/graphics/chromium/cc/CCTextureUpdateController.h: Removed.
      * platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Removed.
      * platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Removed.
      * platform/graphics/chromium/cc/CCThread.h: Removed.
      * platform/graphics/chromium/cc/CCThreadProxy.cpp: Removed.
      * platform/graphics/chromium/cc/CCThreadProxy.h: Removed.
      * platform/graphics/chromium/cc/CCThreadTask.h: Removed.
      * platform/graphics/chromium/cc/CCTileDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCTileDrawQuad.h: Removed.
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCTimeSource.h: Removed.
      * platform/graphics/chromium/cc/CCTimer.cpp: Removed.
      * platform/graphics/chromium/cc/CCTimer.h: Removed.
      * platform/graphics/chromium/cc/CCTimingFunction.cpp: Removed.
      * platform/graphics/chromium/cc/CCTimingFunction.h: Removed.
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Removed.
      * platform/graphics/chromium/cc/CCVideoLayerImpl.h: Removed.
      * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Removed.
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * src/WebAnimationCurveCommon.cpp: Removed.
      * src/WebAnimationCurveCommon.h: Removed.
      * src/WebAnimationImpl.cpp: Removed.
      * src/WebAnimationImpl.h: Removed.
      * src/WebContentLayerImpl.cpp: Removed.
      * src/WebContentLayerImpl.h: Removed.
      * src/WebExternalTextureLayerImpl.cpp: Removed.
      * src/WebExternalTextureLayerImpl.h: Removed.
      * src/WebFloatAnimationCurveImpl.cpp: Removed.
      * src/WebFloatAnimationCurveImpl.h: Removed.
      * src/WebIOSurfaceLayerImpl.cpp: Removed.
      * src/WebIOSurfaceLayerImpl.h: Removed.
      * src/WebImageLayerImpl.cpp: Removed.
      * src/WebImageLayerImpl.h: Removed.
      * src/WebLayerImpl.cpp: Removed.
      * src/WebLayerImpl.h: Removed.
      * src/WebLayerTreeViewImpl.cpp: Removed.
      * src/WebLayerTreeViewImpl.h: Removed.
      * src/WebScrollbarLayerImpl.cpp: Removed.
      * src/WebScrollbarLayerImpl.h: Removed.
      * src/WebSolidColorLayerImpl.cpp: Removed.
      * src/WebSolidColorLayerImpl.h: Removed.
      * src/WebToCCInputHandlerAdapter.cpp: Removed.
      * src/WebToCCInputHandlerAdapter.h: Removed.
      * src/WebTransformAnimationCurveImpl.cpp: Removed.
      * src/WebTransformAnimationCurveImpl.h: Removed.
      * src/WebVideoLayerImpl.cpp: Removed.
      * src/WebVideoLayerImpl.h: Removed.
      * tests/CCActiveAnimationTest.cpp: Removed.
      * tests/CCAnimationTestCommon.cpp: Removed.
      * tests/CCAnimationTestCommon.h: Removed.
      * tests/CCDamageTrackerTest.cpp: Removed.
      * tests/CCDelayBasedTimeSourceTest.cpp: Removed.
      * tests/CCDrawQuadTest.cpp: Removed.
      * tests/CCFrameRateControllerTest.cpp: Removed.
      * tests/CCGeometryTestUtils.cpp: Removed.
      * tests/CCGeometryTestUtils.h: Removed.
      * tests/CCHeadsUpDisplayTest.cpp: Removed.
      * tests/CCKeyframedAnimationCurveTest.cpp: Removed.
      * tests/CCLayerAnimationControllerTest.cpp: Removed.
      * tests/CCLayerImplTest.cpp: Removed.
      * tests/CCLayerIteratorTest.cpp: Removed.
      * tests/CCLayerQuadTest.cpp: Removed.
      * tests/CCLayerSorterTest.cpp: Removed.
      * tests/CCLayerTestCommon.cpp: Removed.
      * tests/CCLayerTestCommon.h: Removed.
      * tests/CCLayerTreeHostCommonTest.cpp: Removed.
      * tests/CCLayerTreeHostImplTest.cpp: Removed.
      * tests/CCLayerTreeHostTest.cpp: Removed.
      * tests/CCMathUtilTest.cpp: Removed.
      * tests/CCOcclusionTrackerTest.cpp: Removed.
      * tests/CCOcclusionTrackerTestCommon.h: Removed.
      * tests/CCPrioritizedTextureTest.cpp: Removed.
      * tests/CCQuadCullerTest.cpp: Removed.
      * tests/CCRenderPassTest.cpp: Removed.
      * tests/CCRenderSurfaceFiltersTest.cpp: Removed.
      * tests/CCRenderSurfaceTest.cpp: Removed.
      * tests/CCRendererGLTest.cpp: Removed.
      * tests/CCResourceProviderTest.cpp: Removed.
      * tests/CCSchedulerStateMachineTest.cpp: Removed.
      * tests/CCSchedulerTest.cpp: Removed.
      * tests/CCSchedulerTestCommon.h: Removed.
      * tests/CCScopedTextureTest.cpp: Removed.
      * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed.
      * tests/CCSolidColorLayerImplTest.cpp: Removed.
      * tests/CCTestCommon.h: Removed.
      * tests/CCTextureUpdateControllerTest.cpp: Removed.
      * tests/CCThreadTaskTest.cpp: Removed.
      * tests/CCThreadedTest.cpp: Removed.
      * tests/CCThreadedTest.h: Removed.
      * tests/CCTiledLayerImplTest.cpp: Removed.
      * tests/CCTiledLayerTestCommon.cpp: Removed.
      * tests/CCTiledLayerTestCommon.h: Removed.
      * tests/CCTimerTest.cpp: Removed.
      * tests/ContentLayerChromiumTest.cpp: Removed.
      * tests/FakeCCLayerTreeHostClient.h: Removed.
      * tests/FakeGraphicsContext3DTest.cpp: Removed.
      * tests/FakeWebScrollbarThemeGeometry.h: Removed.
      * tests/FloatQuadTest.cpp: Removed.
      * tests/GraphicsLayerChromiumTest.cpp:
      * tests/ImageLayerChromiumTest.cpp:
      * tests/LayerChromiumTest.cpp: Removed.
      * tests/MockCCQuadCuller.h: Removed.
      * tests/ScrollbarLayerChromiumTest.cpp: Removed.
      * tests/TextureCopierTest.cpp: Removed.
      * tests/TextureLayerChromiumTest.cpp: Removed.
      * tests/ThrottledTextureUploaderTest.cpp: Removed.
      * tests/TiledLayerChromiumTest.cpp: Removed.
      * tests/TreeSynchronizerTest.cpp: Removed.
      * tests/WebAnimationTest.cpp: Removed.
      * tests/WebFloatAnimationCurveTest.cpp: Removed.
      * tests/WebLayerTest.cpp: Removed.
      * tests/WebLayerTreeViewTest.cpp: Removed.
      * tests/WebTransformAnimationCurveTest.cpp: Removed.
      * tests/WebTransformOperationsTest.cpp: Removed.
      * tests/WebTransformationMatrixTest.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e39fd79
    • simon.fraser@apple.com's avatar
      Mark plugins/netscape-dom-access-and-reload.html as flakey · 919ee0eb
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82752
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      919ee0eb
    • rniwa@webkit.org's avatar
      run-perf-tests should record individual value instead of statistics · d50e412d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97155
      
      Reviewed by Hajime Morita.
      
      PerformanceTests: 
      
      Report the list of values as "values" so that run-perf-tests can parse them.
      
      * resources/runner.js:
      (PerfTestRunner.computeStatistics):
      (PerfTestRunner.printStatistics):
      
      Tools: 
      
      Parse the list of individual value reported by tests and include them as "values".
      We strip "values" from the output JSON when uploading it to the perf-o-matic
      since it doesn't know how to parse "values" or ignore it.
      
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PerfTest):
      (PerfTest.parse_output): Parse and report "values".
      (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
      * Scripts/webkitpy/performance_tests/perftest_unittest.py:
      (MainTest.test_parse_output):
      (MainTest.test_parse_output_with_failing_line):
      (TestPageLoadingPerfTest.test_run):
      * Scripts/webkitpy/performance_tests/perftestsrunner.py:
      (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
      until we update perf-o-matic.
      * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
      (test_run_memory_test):
      (test_run_with_json_output):
      (test_run_with_description):
      (test_run_with_slave_config_json):
      (test_run_with_multiple_repositories):
      
      LayoutTests: 
      
      The expected result now contains individual value.
      
      * fast/harness/perftests/runs-per-second-log-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50e412d
    • mark.lam@apple.com's avatar
      Fixed a missing semicolon in the C++ llint backend. · cb0d16c0
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97252.
      
      Reviewed by Geoff Garen.
      
      * offlineasm/cloop.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb0d16c0
    • ggaren@apple.com's avatar
      Refactored the interpreter and JIT so they don't dictate closure layout · 13e02b9b
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97221
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      Capture may change the location of an argument for space efficiency. This
      patch removes static assumptions about argument location from the interpreter
      and JIT.
      
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::argumentIndexAfterCapture):
      (JSC::ExecState::argumentAfterCapture): Factored out a helper function
      so the compiler could share this logic.
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::BracketAccessorNode::emitBytecode): Don't emit optimized bracket
      access on arguments if a parameter has been captured by name. This case is
      rare and, where I've seen it in the wild, the optimization mostly failed
      anyway due to arguments escape, so I didn't feel like writing and testing
      five copies of the code that would handle it in the baseline engines.
      
      The DFG can still synthesize this optimization even if we don't emit the
      optimized bytecode for it.
      
      * dfg/DFGArgumentsSimplificationPhase.cpp:
      (JSC::DFG::ArgumentsSimplificationPhase::run):
      * dfg/DFGAssemblyHelpers.h:
      (JSC::DFG::AssemblyHelpers::symbolTableFor):
      (AssemblyHelpers): Use the right helper function to account for the fact
      that a parameter may have been captured by name and moved.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock): ASSERT that we haven't inlined
      a .apply on captured arguments. Once we do start inlining such things,
      we'll need to do a little bit of math here to get them right.
      
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile): Added support for bracket access on
      an arguments object where arguments have also been captured by name. We
      load the true index of the argument from a side vector. Arguments elision
      is very powerful in the DFG, so I wanted to keep it working, even in this
      rare case.
      
      * interpreter/Interpreter.cpp:
      (JSC::loadVarargs): Use the right helper function to account for the fact
      that a parameter may have been captured by name and moved.
      
      * jit/JITCall.cpp:
      (JSC::JIT::compileLoadVarargs):
      * jit/JITCall32_64.cpp:
      (JSC::JIT::compileLoadVarargs): Don't use the inline copy loop if some
      of our arguments have moved, since it would copy stale values. (We still
      optimize the actual call, and elide the arguments object.)
      
      LayoutTests: 
      
      * fast/js/dfg-arguments-alias-activation-expected.txt: Added.
      * fast/js/dfg-arguments-alias-activation.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e02b9b
    • hausmann@webkit.org's avatar
      [Qt] Fix production builds · d92ef8f7
      hausmann@webkit.org authored
      Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
      
      Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
      
      * qmake/mkspecs/features/functions.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d92ef8f7
    • tony@chromium.org's avatar
      Implement absolutely positioned flex items · 197c34b6
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93798
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Previously, we treated absolutely positioned flex items as a 0x0 placeholder element.
      Now we position the 0x0 placeholder where the next item would go. This causes the
      following changes:
      - justify-content: space-{around,between} no longer change due to the existence of absolutely positioned flex items.
      - alignment doesn't change the placement of absolutely positioned flex items.
      - auto margins in the alignment direction don't do anything on absolutely positioned flex items.
      
      Test: css3/flexbox/position-absolute-children.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Absolutely positioned flex items should not use this.
      (WebCore::RenderFlexibleBox::updateAutoMarginsInCrossAxis): Absolutely positioned flex items should not use this.
      (WebCore::initialJustifyContentOffset): If there are no flex items, space-around should center an absolutely positioned flex item.
      (WebCore::RenderFlexibleBox::numberOfInFlowPositionedChildren): Helper method for helping to compute space-between and space-around.
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Fix spacing when space-between or space-around.
      (WebCore::RenderFlexibleBox::layoutColumnReverse): Fix spacing when space-between or space-around.
      (WebCore::RenderFlexibleBox::alignChildren): Treat absolutely positioned children like flex-start.
      * rendering/RenderFlexibleBox.h: numberOfInFlowPositionedChildren method.
      
      LayoutTests:
      
      Fix position of absolute flex items and add some additional tests.
      
      * css3/flexbox/align-absolute-child-expected.txt:
      * css3/flexbox/align-absolute-child.html: New test cases and update expectations.
      * css3/flexbox/position-absolute-child.html: Update expectations.
      * css3/flexbox/position-absolute-children-expected.txt: Added.
      * css3/flexbox/position-absolute-children.html: Added. Tests having only absolutely positioned children.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197c34b6
    • ojan@chromium.org's avatar
      Remove now passing test. · 1125f778
      ojan@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1125f778
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r129144. · ae515208
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/129144
      https://bugs.webkit.org/show_bug.cgi?id=97244
      
      causing lots of assertions in tests (Requested by smfr on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-20
      
      * rendering/InlineBox.h:
      (WebCore::InlineBox::markDirty):
      * rendering/InlineTextBox.cpp:
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::start):
      (WebCore::InlineTextBox::end):
      (WebCore::InlineTextBox::len):
      (WebCore::InlineTextBox::offsetRun):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae515208
    • simon.fraser@apple.com's avatar
      0eaae271
    • commit-queue@webkit.org's avatar
      CSP reports should send an empty 'referrer' rather than nothing. · e7cc809f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97233
      
      Patch by Mike West <mkwst@chromium.org> on 2012-09-20
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Currently, if a protected resource doesn't have a referrer, then any
      Content Security Policy violations send a report that doesn't contain
      a referrer attribute. It's arguably friendlier to developers to include
      an explicitly empty attribute.
      
      This new behavior is covered by updates to existing test expectations
      around the reporting functionality.
      
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::reportViolation):
          Drop the 'if', and always write out a referrer.
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
          Adding the empty 'referrer' attribute to the expectations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7cc809f
    • simon.fraser@apple.com's avatar
      Add WK2-specific result for this frame-flattening test (seems to be a scrollbars difference). · 83bcd90f
      simon.fraser@apple.com authored
      Tracked by https://bugs.webkit.org/show_bug.cgi?id=97240.
      
      * platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83bcd90f
    • dpranke@chromium.org's avatar
      REGRESSION: layout test results doesn't show diffs · 64ed7758
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97182
      
      Reviewed by Ojan Vafai.
      
      Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
      so that results.html (and hopefully garden-o-matic) can
      determine which things actually failed. However, we keep mapping
      these results to Failure so that we still only have a single
      expectation type for them.
      
      * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
      (JSONLayoutResultsGenerator):
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectationParser):
      (TestExpectations):
      (TestExpectations.result_was_expected):
      * Scripts/webkitpy/layout_tests/models/test_failures.py:
      (determine_result_type):
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (MainTest.test_missing_and_unexpected_results):
      (MainTest.test_retrying_and_flaky_tests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ed7758
    • dbarton@mathscribe.com's avatar
      [MathML] Increase visual space around fraction parts, italic variables, and operators · bfc6c111
      dbarton@mathscribe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97228
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      This makes MathML more readable, and more in agreement with Firefox and TeX.
      
      Tested by existing tests.
      
      * css/mathml.css:
      (mfrac > :first-child):
      (mfrac > :last-child):
      (mfrac):
      (mi):
      (msub > mi:first-child, msubsup > mi:first-child):
          - Subscripts don't need to move right after an italic <mi>.
      (msubsup > mi:first-child + * + *):
          - Superscripts do need to move right after an italic <mi>.
      (math > mo, mrow > mo, msqrt > mo, mtd > mo):
          - These are ok values for now. It will be better to use different values for different operators, as the FIXME says.
      (math > mo:last-child, mrow > mo:last-child, msqrt > mo:last-child, mtd > mo:last-child):
          - Prefix and postfix operators, including fences, generally get less spacing than infix operators.
              
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::createMathMLOperator):
          - Usually the separator is a comma or semicolon, so we only put space after it for now.
      (WebCore::RenderMathMLFenced::makeFences):
      (WebCore::RenderMathMLFenced::addChild):
      (WebCore::RenderMathMLFenced::styleDidChange):
      * rendering/mathml/RenderMathMLFenced.h:
      (RenderMathMLFenced):
              
      * rendering/mathml/RenderMathMLFraction.cpp:
      (WebCore):
      (WebCore::RenderMathMLFraction::updateFromElement):
          - gDenominatorPad is now handled by mathml.css.
              
      * rendering/mathml/RenderMathMLSubSup.cpp:
      (WebCore):
      (WebCore::RenderMathMLSubSup::fixScriptsStyle):
          - gSubsupScriptMargin is now handled by mathml.css.
      
      LayoutTests: 
      
      * platform/mac/mathml/presentation/attributes-expected.png:
      * platform/mac/mathml/presentation/attributes-expected.txt:
      * platform/mac/mathml/presentation/fenced-expected.png:
      * platform/mac/mathml/presentation/fenced-expected.txt:
      * platform/mac/mathml/presentation/fenced-mi-expected.png:
      * platform/mac/mathml/presentation/fenced-mi-expected.txt:
      * platform/mac/mathml/presentation/fractions-expected.png:
      * platform/mac/mathml/presentation/fractions-expected.txt:
      * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
      * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
      * platform/mac/mathml/presentation/mo-expected.png:
      * platform/mac/mathml/presentation/mo-expected.txt:
      * platform/mac/mathml/presentation/mo-stretch-expected.png:
      * platform/mac/mathml/presentation/mo-stretch-expected.txt:
      * platform/mac/mathml/presentation/mroot-pref-width-expected.png:
      * platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
      * platform/mac/mathml/presentation/over-expected.png:
      * platform/mac/mathml/presentation/over-expected.txt:
      * platform/mac/mathml/presentation/roots-expected.png:
      * platform/mac/mathml/presentation/roots-expected.txt:
      * platform/mac/mathml/presentation/row-alignment-expected.png:
      * platform/mac/mathml/presentation/row-alignment-expected.txt:
      * platform/mac/mathml/presentation/row-expected.png:
      * platform/mac/mathml/presentation/row-expected.txt:
      * platform/mac/mathml/presentation/style-expected.png:
      * platform/mac/mathml/presentation/style-expected.txt:
      * platform/mac/mathml/presentation/sub-expected.txt:
      * platform/mac/mathml/presentation/subsup-expected.png:
      * platform/mac/mathml/presentation/subsup-expected.txt:
      * platform/mac/mathml/presentation/sup-expected.png:
      * platform/mac/mathml/presentation/sup-expected.txt:
      * platform/mac/mathml/presentation/tokenElements-expected.png:
      * platform/mac/mathml/presentation/tokenElements-expected.txt:
      * platform/mac/mathml/presentation/under-expected.txt:
      * platform/mac/mathml/presentation/underover-expected.png:
      * platform/mac/mathml/presentation/underover-expected.txt:
      * platform/mac/mathml/xHeight-expected.png:
      * platform/mac/mathml/xHeight-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc6c111
    • tommyw@google.com's avatar
      MediaStream API: Extend UserMediaRequest with a ownerDocument method · dd466b63
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97095
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Chromium need to know exactly which frame called getUserMedia so that it can
      clean away the stream when the frame goes away.
      Since that information is available in webkit add an accessor method.
      
      Chromium mock class extended to test the added method.
      
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::UserMediaRequest::ownerDocument):
      (WebCore):
      * Modules/mediastream/UserMediaRequest.h:
      (WebCore):
      (UserMediaRequest):
      
      Source/WebKit/chromium:
      
      Chromium need to know exactly which frame called getUserMedia so that it can clean
      away the stream when the frame goes away.
      Since that information is available in webkit add an accessor method.
      
      Also taking the opportunity to remove an unused deprecated method,
      and adding asserts in case the object is empty.
      
      * public/WebUserMediaRequest.h:
      (WebKit):
      (WebUserMediaRequest):
      * src/WebUserMediaRequest.cpp:
      (WebKit::WebUserMediaRequest::ownerDocument):
      
      Tools:
      
      Extending WebUserMediaClientMock to check that the owning document is valid,
      and that the document has a frame.
      
      * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
      (WebKit::WebUserMediaClientMock::requestUserMedia):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd466b63
    • leviw@chromium.org's avatar
      Prevent reading stale data from InlineTextBoxes · a2c0f6c1
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94750
      
      Reviewed by Eric Seidel.
      
      Text from dirty InlineTextBoxes should never be read or used. This change enforces this
      design goal by forcefully zero-ing out the start and length of InlineTextBoxes when 
      they're being marked dirty. It also adds asserts to accessors for those members.
      
      This change involves making markDirty virtual. Running the line-layout performance test
      as well as profiling resizing the html5 spec showed negligable impact with this change.
      
      No new tests as this doesn't change any proper behavior.
      
      * rendering/InlineBox.h:
      (WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
      zero out its start and length.
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::start): Adding an assert when we hit this case.
      (WebCore::InlineTextBox::end): Ditto.
      (WebCore::InlineTextBox::len): Ditto.
      (WebCore::InlineTextBox::offsetRun): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2c0f6c1
    • commit-queue@webkit.org's avatar
      Support paths in Content Security Policy directives. · 699a4584
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89750
      
      Patch by Mike West <mkwst@chromium.org> on 2012-09-20
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      In CSP 1.0, paths are simply ignored: 'script-src
      http://example.com/path/to/a/file' would allow script to be loaded from
      http://example.com/path/to/a/file/javascript.js, but also from
      http://example.com/javascript.js.
      
      This patch is an experimental implementation of more granular path
      support in CSP source lists as proposed in the current editor's draft of
      CSP 1.1. Paths are treated as specifying directories in which resources
      can be found, and are implicitly terminated with a '/': in other words,
      'script-src http://a.com/path' is the same as
      'script-src http://a.com/path/'. Moreover, paths cannot contain either
      '?' or '#' characters.
      
      This is implemented outside the CSP_NEXT flag. All ports will be
      effected.
      
      Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#matching
      
      Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html
             http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html
      
      * page/ContentSecurityPolicy.cpp:
      (WebCore::CSPSource::CSPSource):
          Store a path along with each CSP source.
      (WebCore::CSPSource::matches):
          Check the path when comparing a URL to the source.
      (WebCore::CSPSource::pathMatches):
          Compare the URL-decoded version of the resource to validate against
          the source's stored path. If the resource's path begins with the
          stored path, then it matches! If not, it doesn't.
      (CSPSource):
          Store a path along with each CSP source.
      (WebCore::CSPSourceList::parse):
          Pass a 'path' in when creating CSPSource objects.
      (WebCore::CSPSourceList::parsePath):
          Actually parse the path, flagging errors if '?' or '#' are present,
          URL-decoding the result, and ensuring that a terminal '/' is
          added if necessary.
      (WebCore::CSPSourceList::addSourceSelf):
          Ensure that 'self' sources have an empty path.
      * page/ContentSecurityPolicy.h:
          Dropping the "ignored path component" console warning.
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
      * http/tests/security/contentSecurityPolicy/source-list-parsing-05.html:
      * http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
      * http/tests/security/contentSecurityPolicy/source-list-parsing-06.html:
          The behavior of these tests changes based on the new functionality.
      * http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html: Added.
      * http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html: Added.
          New tests for various path cases.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      699a4584
    • jsbell@chromium.org's avatar
      IndexedDB: Rewrite confusing call sequence layout tests · 08e19373
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97051
      
      Reviewed by Tony Chang.
      
      Rewrite some convoluted and hard to understand/maintain tests in a more idiomatic fashion.
      This patch maintains the bulk of the non-standard output to verify that the tests have not
      changed in behavior; follow-ups will make the output more standard and split the tests
      into separate files.
      
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/resources/factory-deletedatabase-interactions.js:
      * storage/indexeddb/resources/open-close-version.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08e19373
    • commit-queue@webkit.org's avatar
      [GTK] ControlsPanel string is not localized in LocalizedStringsGtk · ee99a937
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96502
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-20
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.
      
      Test: platform/gtk/accessibility/media-controls-panel-title.html
      
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::localizedMediaControlElementString):
      
      LayoutTests:
      
      Added a new test to verify that the accessible object associated with the
      MediaControlsPanel has the expected accessible name.
      
      * platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
      * platform/gtk/accessibility/media-controls-panel-title.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee99a937
    • jonlee@apple.com's avatar
      Safari 6 notifications' onclick handlers can't call window.open() · 2a69abdf
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96959
      <rdar://problem/12132427>
      
      Reviewed by Darin Adler.
      
      Source/WebKit2:
      
      The click is not being treated as a user gesture when the message is sent to the web process.
      
      * WebProcess/Notifications/WebNotificationManager.cpp:
      (WebKit::WebNotificationManager::didClickNotification): Gets called when the user clicks on the
      platform notification. Set UserGestureIndicator to show the click event is due to user gesture.
      
      LayoutTests:
      
      The test shows and clicks a platform notification. The onclick handler calls window.open(),
      which in turn calls a function on the main page to confirm that a window was opened.
      
      * http/tests/notifications/legacy/window-show-on-click-expected.txt: Added.
      * http/tests/notifications/legacy/window-show-on-click.html: Added.
      * http/tests/notifications/resources/window-show-on-click.html: Added.
      * http/tests/notifications/window-show-on-click-expected.txt: Added.
      * http/tests/notifications/window-show-on-click.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a69abdf
    • schenney@chromium.org's avatar
      [Chromium] DRT does not support --dump-all-pixels flag · 24fe2012
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95098
      
      Reviewed by Dirk Pranke.
      
      Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
      of this flag causes pixel results to be created for all tests, regardless of
      individual test options. If an individual test provides a pixel hash it will be used,
      otherwise the hash will be empty. This replaces a previously defined but unused option
      --dump-all-pixels, and is useful primarily when debugging DRT instances.
      
      * DumpRenderTree/chromium/DumpRenderTree.cpp:
      (runTest): Add a parameter and code to force pixel results for the test.
      (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24fe2012
    • carlosgc@webkit.org's avatar
      [GTK] run-api-tests should not buffer test stdout · 10f5a027
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88474
      
      Reviewed by Philippe Normand.
      
      * Scripts/run-gtk-tests:
      (TestRunner._run_test_command): Use os.forkpty() instead of
      subprocess.Popen() so that gtest sends the output with colors to
      stdout. Use common.parse_output_lines() to parse the output and
      write it to stdout while it's read.
      (TestRunner._run_test_command.parse_line): Parse the line to get
      the test pid and write the line to stdout.
      (TestRunner._run_test_command.waitpid): Helper function to call
      waitpid handling EINTR.
      (TestRunner._run_test_command.return_code_from_exit_status):
      Helper function to convert exit status of test commands to a
      return code.
      * gtk/common.py:
      (parse_output_lines): Helper function that uses select to read
      the given file descriptor and call the given callback for every
      line read.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10f5a027
    • jchaffraix@webkit.org's avatar
      Remove isStartColumn in the border collapsing code · c7b2ef03
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97024
      
      Reviewed by Abhishek Arya.
      
      isStartColumn is embedding the same information as prevCell. As we need to compute it
      in most of the cases, we may as well just reuse them.
      
      While touching this code, I cleaned up the code by removing some unneeded checks and renaming
      some variables in preparation for bug 79272.
      
      Refactoring covered by existing collapsing borders tests.
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::computeCollapsedStartBorder):
      Removed |isStartColumn|.
      
      (WebCore::RenderTableCell::computeCollapsedEndBorder):
      Added a comment about why |isEndColumn| is needed. Also cleaned up this code to be
      consistent with computeCollapsedStartBorder.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7b2ef03