1. 29 Oct, 2012 2 commits
  2. 24 Oct, 2012 1 commit
  3. 23 Oct, 2012 3 commits
    • ossy@webkit.org's avatar
      Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText() · 95578f94
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100159
      
      Patch by Simon Fraser <simon.fraser@apple.com> on 2012-10-23
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
      through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.
      
      Test: platform/mac/tiled-drawing/use-tiled-drawing.html
      
      * page/Frame.h:
      * platform/graphics/GraphicsLayer.cpp:
      (showGraphicsLayerTree):
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::tiledBacking):
      * platform/graphics/TiledBacking.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::tiledBacking):
      (WebCore::GraphicsLayerCA::dumpAdditionalProperties):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      * platform/graphics/ca/mac/TileCache.h:
      (WebCore::TileCache::tileCoverageRect):
      (TileCache):
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::computeTileCoverageRect):
      (WebCore::TileCache::revalidateTiles):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::layerTreeAsText):
      * testing/Internals.cpp:
      (WebCore::Internals::layerTreeAsText):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Tools:
      
      Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
      whose path includes "tiled-drawing". It does this by passing around a WKDictionary
      of options, and if the current PlatformWebView doesn't support those options, it will
      create a new one.
      
      * WebKitTestRunner/PlatformWebView.h:
      (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
      (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
      supports the options in the WKDictionaryRef.
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize): Call createWebViewWithOptions() with
      no options in the normal case.
      (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
      so we can call it in two places.
      (WTR::TestController::ensureViewSupportsOptions): If the current view
      doesn't support the given options, throw it away and makea  new one that does.
      * WebKitTestRunner/TestController.h:
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
      (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
      the view supports the given options. No-op for non-Mac platforms.
      (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
      (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
      (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
      a custom value from this method.
      (WTR::PlatformWebView::PlatformWebView):
      (WTR::PlatformWebView::viewSupportsOptions):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      * WebKitTestRunner/win/PlatformWebViewWin.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      
      LayoutTests:
      
      A new test that dumps tile cache data for a large page.
      
      * platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
      * platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95578f94
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r132276. · bbf957ab
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/132276
      https://bugs.webkit.org/show_bug.cgi?id=100189
      
      It broke the Qt-WK2 build intentionally (Requested by
      Ossy_night on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23
      
      Source/WebCore:
      
      * page/Frame.h:
      * platform/graphics/GraphicsLayer.cpp:
      (showGraphicsLayerTree):
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::tiledBacking):
      * platform/graphics/TiledBacking.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::tiledBacking):
      (WebCore::GraphicsLayerCA::dumpAdditionalProperties):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      * platform/graphics/ca/mac/TileCache.h:
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::tileCoverageRect):
      (WebCore::TileCache::revalidateTiles):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::layerTreeAsText):
      * testing/Internals.cpp:
      (WebCore::Internals::layerTreeAsText):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Tools:
      
      * WebKitTestRunner/PlatformWebView.h:
      (PlatformWebView):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      * WebKitTestRunner/TestController.h:
      (TestController):
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR):
      (WTR::TestInvocation::invoke):
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      * WebKitTestRunner/win/PlatformWebViewWin.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      
      LayoutTests:
      
      * platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Removed.
      * platform/mac/tiled-drawing/use-tiled-drawing.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbf957ab
    • simon.fraser@apple.com's avatar
      Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText() · 57525601
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100159
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
      through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.
      
      Test: platform/mac/tiled-drawing/use-tiled-drawing.html
      
      * page/Frame.h:
      * platform/graphics/GraphicsLayer.cpp:
      (showGraphicsLayerTree):
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::tiledBacking):
      * platform/graphics/TiledBacking.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::tiledBacking):
      (WebCore::GraphicsLayerCA::dumpAdditionalProperties):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      * platform/graphics/ca/mac/TileCache.h:
      (WebCore::TileCache::tileCoverageRect):
      (TileCache):
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::computeTileCoverageRect):
      (WebCore::TileCache::revalidateTiles):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::layerTreeAsText):
      * testing/Internals.cpp:
      (WebCore::Internals::layerTreeAsText):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Tools:
      
      Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
      whose path includes "tiled-drawing". It does this by passing around a WKDictionary
      of options, and if the current PlatformWebView doesn't support those options, it will
      create a new one.
      
      * WebKitTestRunner/PlatformWebView.h:
      (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
      (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
      supports the options in the WKDictionaryRef.
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize): Call createWebViewWithOptions() with
      no options in the normal case.
      (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
      so we can call it in two places.
      (WTR::TestController::ensureViewSupportsOptions): If the current view
      doesn't support the given options, throw it away and makea  new one that does.
      * WebKitTestRunner/TestController.h:
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
      (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
      the view supports the given options. No-op for non-Mac platforms.
      (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
      (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
      (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
      a custom value from this method.
      (WTR::PlatformWebView::PlatformWebView):
      (WTR::PlatformWebView::viewSupportsOptions):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      * WebKitTestRunner/win/PlatformWebViewWin.cpp:
      (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
      
      LayoutTests:
      
      A new test that dumps tile cache data for a large page.
      
      * platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
      * platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57525601
  4. 05 Oct, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [EFL] Fix window resizing / moving in WK1 and WKTR · aec28c26
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98486
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-05
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      Fix ChromeClientEfl::windowRect() code to use
      ecore_evas_request_geometry_get() instead of
      evas_object_geometry_get() and therefore avoid
      returning incorrect values when the engine has
      not processed a call to ecore_evas_move_resize()
      yet. This fixes a couple of layout tests.
      
      The code was also refactored a bit for
      consistency with the WebKit2 EFL implementation.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::windowRect):
      (WebCore::ChromeClientEfl::setWindowRect):
      
      Tools:
      
      Fix PlatformWebView::windowFrame() and
      PlatformWebView::setWindowFrame() in EFL's WKTR so
      that it resizes / moves the window, not the view.
      
      The new code matches the implementation in EwkView's
      UIClient.
      
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::windowFrame):
      (WTR::PlatformWebView::setWindowFrame):
      
      LayoutTests:
      
      Unskip 2 window resizing / moving tests now that
      the implementation for those has been fixed in
      WebKit1 EFL.
      
      * platform/efl-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aec28c26
  5. 03 Oct, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner · 94fc25c7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98231
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-03
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      Initialize ecore_x library in ewk_main since it is used by
      WebKitEFL.
      
      * ewk/ewk_main.cpp:
      (ewk_init):
      (ewk_shutdown):
      
      Source/WebKit2:
      
      Initialize ecore_x library in ewk_main instead of
      WebKitTestRunner since WebKit is using ecore_x
      not WebKitTestRunner itself.
      
      * UIProcess/API/efl/ewk_main.cpp:
      (ewk_init):
      (ewk_shutdown):
      
      Tools:
      
      Enable use of X11 in DumpRenderTree / WebKitTestRunner.
      Call ecore_evas_new() instead of ecore_evas_buffer_new()
      in EFL's DumpRenderTree and WebKitTestRunner.
      It is safe to do this now that we are using XvfbDriver
      for the layout tests.
      
      * DumpRenderTree/efl/DumpRenderTree.cpp:
      (parseCommandLineOptions):
      (initEcoreEvas):
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::initEcoreEvas):
      * WebKitTestRunner/efl/main.cpp:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94fc25c7
  6. 28 Sep, 2012 2 commits
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, rolling out r129863. · 324ab95e
      gyuyoung.kim@samsung.com authored
      http://trac.webkit.org/changeset/129863
      https://bugs.webkit.org/show_bug.cgi?id=97173
      
      Source/WebCore:
      
      WK2 layout test on debug is broken by this patch.
      
      * platform/efl/RunLoopEfl.cpp:
      (WebCore::RunLoop::RunLoop):
      (WebCore::RunLoop::~RunLoop):
      
      Source/WebKit2:
      
      Broken debug WK2 layout test
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/EWebKit2.h:
      * UIProcess/API/efl/ewk_context.cpp:
      (_Ewk_Context::_Ewk_Context):
      (_Ewk_Context::~_Ewk_Context):
      * UIProcess/API/efl/ewk_main.cpp:
      (ewk_init):
      (ewk_shutdown):
      * UIProcess/API/efl/ewk_main.h: Added.
      * UIProcess/API/efl/ewk_main_private.h: Removed.
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
      (EWK2UnitTest::EWK2UnitTestBase::SetUp):
      (EWK2UnitTest::EWK2UnitTestBase::TearDown):
      * WebProcess/efl/WebProcessMainEfl.cpp:
      (WebKit::WebProcessMainEfl):
      
      Tools:
      
      Broken debug WK2 layout test
      
      * MiniBrowser/efl/main.c:
      (quit):
      (main):
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::initEcoreEvas):
      (WTR::PlatformWebView::~PlatformWebView):
      * WebKitTestRunner/efl/main.cpp:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      324ab95e
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries. · 190e98b2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97173
      
      Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-28
      Reviewed by Gyuyoung Kim.
      
      Source/WebCore:
      
      Remove codes to initialize and shutdown the EFL libraries from
      RunLoopEfl.cpp. Initialization and shutdown will be done in the
      ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
      process.
      
      No new tests. This patch doesn't change behavior.
      
      * platform/efl/RunLoopEfl.cpp:
      (WebCore::RunLoop::RunLoop):
      (WebCore::RunLoop::~RunLoop):
      
      Source/WebKit2:
      
      Initialize and shutdown the EFL libraries in the ewk_main.cpp for ui
      process and WebProcessMainEfl.cpp for web process.
      Additionally, initialization and shutdown are done when ewk_context is
      created and deleted, so ewk_{init,shutdown} APIs are changed to
      internal function and applications don't have to call them.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/EWebKit2.h:
      * UIProcess/API/efl/ewk_context.cpp:
      (_Ewk_Context::_Ewk_Context):
      (_Ewk_Context::~_Ewk_Context):
      * UIProcess/API/efl/ewk_main.cpp:
      (ewk_init):
      (ewk_shutdown):
      * UIProcess/API/efl/ewk_main.h: Removed.
      * UIProcess/API/efl/ewk_main_private.h: Added.
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
      (EWK2UnitTest::EWK2UnitTestBase::SetUp):
      (EWK2UnitTest::EWK2UnitTestBase::TearDown):
      * WebProcess/efl/WebProcessMainEfl.cpp:
      (WebKit::WebProcessMainEfl):
      
      Tools:
      
      The initialization and shutdown are done inside the webkit, so we don't
      have to call them out of the webkit.
      
      * MiniBrowser/efl/main.c:
      (quit):
      (main):
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::initEcoreEvas):
      (WTR::PlatformWebView::~PlatformWebView):
      * WebKitTestRunner/efl/main.cpp:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      190e98b2
  7. 06 Sep, 2012 1 commit
  8. 25 Jul, 2012 1 commit
  9. 16 Jul, 2012 1 commit
    • ryuan.choi@samsung.com's avatar
      [EFL][WK2] Add APIs to support theme. · 5d21e4db
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90107
      
      Reviewed by Hajime Morita.
      
      Source/WebKit2:
      
      RenderThemeEfl uses edj file to render native theme of form elements.
      This patch provides default theme and a way to change edj theme file for
      WebKit2/Efl.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (ewk_view_base_add):
      (ewk_view_theme_set):
      (ewk_view_theme_get):
      * UIProcess/API/efl/ewk_view.h:
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      * UIProcess/efl/WebPageProxyEfl.cpp:
      (WebKit::WebPageProxy::setThemePath):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/efl/WebPageEfl.cpp:
      (WebKit::WebPage::setThemePath):
      
      Tools:
      
      Override default theme path for MiniBrowser and WebKitTestRunner.
      
      * MiniBrowser/efl/CMakeLists.txt:
      * MiniBrowser/efl/main.c:
      (browserCreate):
      * WebKitTestRunner/PlatformEfl.cmake:
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d21e4db
  10. 05 Jul, 2012 1 commit
    • ryuan.choi@samsung.com's avatar
      [Wk2][EFL] EFL needs a WebKitTestRunner · 8d2c489c
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87659
      
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      * Source/CMakeLists.txt:
      Set compiler flags for WebCoreTestSupport to be linked into TestRunnerInjectedBundle
      shared library.
      * Source/cmake/WebKitMacros.cmake: Remove unnecessary dependency.
      
      Source/WebKit2:
      
      * PlatformEfl.cmake: Added WKImageCairo.cpp in source list.
      
      Tools:
      
      Add an implementation of WebKitTestRunner for Efl port.
      
      * CMakeLists.txt: Includes WebKitTestRunner build script.
      * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
      * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
      (EflPort.setup_environ_for_server):
      * WebKitTestRunner/CMakeLists.txt: Added.
      * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
      * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
      * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
      * WebKitTestRunner/PlatformEfl.cmake: Added.
      * WebKitTestRunner/PlatformWebView.h:
      * WebKitTestRunner/TestController.cpp:
      * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
      * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
      * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
      * WebKitTestRunner/efl/main.cpp: Added.
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2c489c