1. 15 Nov, 2013 26 commits
    • zoltan@webkit.org's avatar
      Move BreakingContext and LineBreaker into their own files · 64be122e
      zoltan@webkit.org authored
      <https://webkit.org/b/124336>
      
      Reviewed by David Hyatt.
      
      In this change I introduced 'line' subdirectory inside 'rendering', this directory will contain all the classes
      which have been refactored from RenderBlockLineLayout.cpp. This change contains the separation of BreakingContext,
      and the separation of LineBreaker classes. Since I wanted to keep the helper functions organized, I also added a
      new file called LineInlineHeaders.h, which contains the functions which used in LineBreaker.h and BreakingContext.h.
      I moved LineInfo class into line directory. It was necessary this time, since I added a cpp for it. I'll move the
      rest of the line layout related helper classes later. (I wanted to minimize merge conflicts.)
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCoreCommon.props:
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::createRun):
      * rendering/line/BreakingContextInlineHeaders.h: Added.
      (WebCore::WordMeasurement::WordMeasurement):
      (WebCore::TrailingObjects::TrailingObjects):
      (WebCore::TrailingObjects::setTrailingWhitespace):
      (WebCore::TrailingObjects::clear):
      (WebCore::TrailingObjects::appendBoxIfNeeded):
      (WebCore::deprecatedAddMidpoint):
      (WebCore::startIgnoringSpaces):
      (WebCore::stopIgnoringSpaces):
      (WebCore::ensureLineBoxInsideIgnoredSpaces):
      (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
      (WebCore::BreakingContext::BreakingContext):
      (WebCore::BreakingContext::currentObject):
      (WebCore::BreakingContext::lineBreak):
      (WebCore::BreakingContext::lineBreakRef):
      (WebCore::BreakingContext::lineWidth):
      (WebCore::BreakingContext::atEnd):
      (WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
      (WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
      (WebCore::BreakingContext::initializeForCurrentObject):
      (WebCore::BreakingContext::increment):
      (WebCore::BreakingContext::handleBR):
      (WebCore::borderPaddingMarginStart):
      (WebCore::borderPaddingMarginEnd):
      (WebCore::shouldAddBorderPaddingMargin):
      (WebCore::previousInFlowSibling):
      (WebCore::inlineLogicalWidth):
      (WebCore::BreakingContext::handleOutOfFlowPositioned):
      (WebCore::BreakingContext::handleFloat):
      (WebCore::shouldSkipWhitespaceAfterStartObject):
      (WebCore::BreakingContext::handleEmptyInline):
      (WebCore::BreakingContext::handleReplaced):
      (WebCore::firstPositiveWidth):
      (WebCore::updateSegmentsForShapes):
      (WebCore::iteratorIsBeyondEndOfRenderCombineText):
      (WebCore::nextCharacter):
      (WebCore::updateCounterIfNeeded):
      (WebCore::measureHyphenWidth):
      (WebCore::textWidth):
      (WebCore::ensureCharacterGetsLineBox):
      (WebCore::tryHyphenating):
      (WebCore::BreakingContext::handleText):
      (WebCore::textBeginsWithBreakablePosition):
      (WebCore::BreakingContext::canBreakAtThisPosition):
      (WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
      (WebCore::checkMidpoints):
      (WebCore::BreakingContext::handleEndOfLine):
      * rendering/line/LineBreaker.cpp: Added.
      (WebCore::LineBreaker::reset):
      (WebCore::LineBreaker::skipTrailingWhitespace):
      (WebCore::LineBreaker::skipLeadingWhitespace):
      * rendering/line/LineBreaker.h: Added.
      (WebCore::LineBreaker::LineBreaker):
      (WebCore::LineBreaker::lineWasHyphenated):
      (WebCore::LineBreaker::positionedObjects):
      (WebCore::LineBreaker::clear):
      * rendering/line/LineInfo.cpp: Added.
      (WebCore::LineInfo::setEmpty):
      * rendering/line/LineInfo.h: Renamed from Source/WebCore/rendering/LineInfo.h.
      (WebCore::LineInfo::LineInfo):
      (WebCore::LineInfo::isFirstLine):
      (WebCore::LineInfo::isLastLine):
      (WebCore::LineInfo::isEmpty):
      (WebCore::LineInfo::previousLineBrokeCleanly):
      (WebCore::LineInfo::floatPaginationStrut):
      (WebCore::LineInfo::runsFromLeadingWhitespace):
      (WebCore::LineInfo::resetRunsFromLeadingWhitespace):
      (WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
      (WebCore::LineInfo::setFirstLine):
      (WebCore::LineInfo::setLastLine):
      (WebCore::LineInfo::setPreviousLineBrokeCleanly):
      (WebCore::LineInfo::setFloatPaginationStrut):
      * rendering/line/LineInlineHeaders.h: Added.
      (WebCore::hasInlineDirectionBordersPaddingOrMargin):
      (WebCore::lineStyle):
      (WebCore::requiresLineBoxForContent):
      (WebCore::shouldCollapseWhiteSpace):
      (WebCore::skipNonBreakingSpace):
      (WebCore::alwaysRequiresLineBox):
      (WebCore::requiresLineBox):
      (WebCore::setStaticPositions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64be122e
    • beidson@apple.com's avatar
      Move execution of IDBTransactionBackendOperations to the IDBServerConnection · 05a35ca3
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124385
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Each IDBOperation has it’s ::perform() moved to a method on IDBServerConnection.
      This almost removes all knowledge of the backing stores from the front end.
      
      * Modules/indexeddb/IDBDatabaseBackend.cpp:
      (WebCore::IDBDatabaseBackend::clearObjectStore):
      (WebCore::IDBDatabaseBackend::runIntVersionChangeTransaction):
      * Modules/indexeddb/IDBDatabaseBackend.h:
      
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::IDBObjectStore::clear):
      
      Add methods to reflect each transaction backend operation:
      * Modules/indexeddb/IDBServerConnection.h:
      
      Schedule certain operations with callbacks:
      * Modules/indexeddb/IDBTransactionBackend.cpp:
      (WebCore::IDBTransactionBackend::scheduleVersionChangeOperation):
      (WebCore::IDBTransactionBackend::schedulePutOperation):
      (WebCore::IDBTransactionBackend::scheduleOpenCursorOperation):
      (WebCore::IDBTransactionBackend::scheduleCountOperation):
      (WebCore::IDBTransactionBackend::scheduleDeleteRangeOperation):
      (WebCore::IDBTransactionBackend::scheduleClearObjectStoreOperation):
      * Modules/indexeddb/IDBTransactionBackend.h:
      
      Make each operation’s perform() method defer to the IDBServerConnection (with a callback):
      * Modules/indexeddb/IDBTransactionBackendOperations.cpp:
      (WebCore::CreateObjectStoreOperation::perform):
      (WebCore::CreateIndexOperation::perform):
      (WebCore::CreateIndexAbortOperation::perform):
      (WebCore::DeleteIndexOperation::perform):
      (WebCore::DeleteIndexAbortOperation::perform):
      (WebCore::GetOperation::perform):
      (WebCore::PutOperation::perform):
      (WebCore::SetIndexesReadyOperation::perform):
      (WebCore::OpenCursorOperation::perform):
      (WebCore::CountOperation::perform):
      (WebCore::DeleteRangeOperation::perform):
      (WebCore::ClearObjectStoreOperation::perform):
      (WebCore::DeleteObjectStoreOperation::perform):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
      (WebCore::CreateObjectStoreAbortOperation::perform):
      
      Add accessors to each operation’s data members so the IDBServerConnection has everything it needs:
      * Modules/indexeddb/IDBTransactionBackendOperations.h:
      (WebCore::CreateObjectStoreOperation::objectStoreMetadata):
      (WebCore::DeleteObjectStoreOperation::objectStoreMetadata):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::create):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::version):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::callbacks):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::databaseCallbacks):
      (WebCore::IDBDatabaseBackend::VersionChangeOperation::VersionChangeOperation):
      (WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
      (WebCore::CreateIndexOperation::objectStoreID):
      (WebCore::CreateIndexOperation::idbIndexMetadata):
      (WebCore::CreateIndexOperation::CreateIndexOperation):
      (WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
      (WebCore::DeleteIndexOperation::objectStoreID):
      (WebCore::DeleteIndexOperation::idbIndexMetadata):
      (WebCore::DeleteIndexOperation::DeleteIndexOperation):
      (WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
      (WebCore::GetOperation::objectStoreID):
      (WebCore::GetOperation::indexID):
      (WebCore::GetOperation::cursorType):
      (WebCore::GetOperation::keyRange):
      (WebCore::GetOperation::callbacks):
      (WebCore::GetOperation::autoIncrement):
      (WebCore::GetOperation::keyPath):
      (WebCore::GetOperation::GetOperation):
      (WebCore::PutOperation::create):
      (WebCore::PutOperation::putMode):
      (WebCore::PutOperation::objectStore):
      (WebCore::PutOperation::key):
      (WebCore::PutOperation::indexIDs):
      (WebCore::PutOperation::indexKeys):
      (WebCore::PutOperation::callbacks):
      (WebCore::PutOperation::value):
      (WebCore::PutOperation::PutOperation):
      (WebCore::OpenCursorOperation::create):
      (WebCore::OpenCursorOperation::objectStoreID):
      (WebCore::OpenCursorOperation::indexID):
      (WebCore::OpenCursorOperation::direction):
      (WebCore::OpenCursorOperation::cursorType):
      (WebCore::OpenCursorOperation::taskType):
      (WebCore::OpenCursorOperation::keyRange):
      (WebCore::OpenCursorOperation::cursorDirection):
      (WebCore::OpenCursorOperation::callbacks):
      (WebCore::OpenCursorOperation::OpenCursorOperation):
      (WebCore::CountOperation::create):
      (WebCore::CountOperation::objectStoreID):
      (WebCore::CountOperation::indexID):
      (WebCore::CountOperation::keyRange):
      (WebCore::CountOperation::callbacks):
      (WebCore::CountOperation::CountOperation):
      (WebCore::DeleteRangeOperation::create):
      (WebCore::DeleteRangeOperation::objectStoreID):
      (WebCore::DeleteRangeOperation::callbacks):
      (WebCore::DeleteRangeOperation::keyRange):
      (WebCore::DeleteRangeOperation::DeleteRangeOperation):
      (WebCore::ClearObjectStoreOperation::create):
      (WebCore::ClearObjectStoreOperation::objectStoreID):
      (WebCore::ClearObjectStoreOperation::callbacks):
      (WebCore::ClearObjectStoreOperation::ClearObjectStoreOperation):
      
      Implement each operation in terms of the appropriate backing store, then perform the callback:
      * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
      (WebCore::IDBServerConnectionLevelDB::createObjectStore):
      (WebCore::IDBServerConnectionLevelDB::createIndex):
      (WebCore::IDBServerConnectionLevelDB::deleteIndex):
      (WebCore::IDBServerConnectionLevelDB::get):
      (WebCore::IDBServerConnectionLevelDB::put):
      (WebCore::IDBServerConnectionLevelDB::openCursor):
      (WebCore::IDBServerConnectionLevelDB::count):
      (WebCore::IDBServerConnectionLevelDB::deleteRange):
      (WebCore::IDBServerConnectionLevelDB::clearObjectStore):
      (WebCore::IDBServerConnectionLevelDB::deleteObjectStore):
      (WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion):
      * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
      
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit2:
      
      * WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05a35ca3
    • timothy_horton@apple.com's avatar
      build.webkit.org/dashboard should provide a way to focus on a subset of bots · a0d14596
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122676
      
      Reviewed by Timothy Hatcher.
      
      Add a small 'hide' button next to every platform logo, and a 'show all'
      button which only appears when at least one platform is hidden. Hidden
      platforms persist using localStorage.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
      (updateHiddenPlatforms):
      (documentReady.unhideButton):
      (documentReady.hideButton):
      (documentReady):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
      (Settings.prototype.setObject):
      (Settings.prototype.getObject):
      (Settings.prototype.addSettingListener):
      (Settings.prototype.fireSettingListener):
      (Settings.prototype.toggleHiddenPlatform):
      (Settings.prototype.clearHiddenPlatforms):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
      (div.cellButton):
      (div.cellButton.hide):
      (.hidden):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0d14596
    • mhahnenberg@apple.com's avatar
      -dealloc callbacks from wrapped Objective-C objects can happen at bad times · ac6f1fd4
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123821
      
      Reviewed by Darin Adler.
      
      Currently with the JSC Obj-C API, JS wrappers for client Obj-C objects retain their associated Obj-C 
      object. When they are swept, they release their Obj-C objects which can trigger a call to that 
      object's -dealloc method. These -dealloc methods can then call back into the same VM, which is not 
      allowed during sweeping or VM shutdown.
      
      We can handle this case by creating our own pool of Obj-C objects to be released when it is safe to do so.
      This is accomplished by using DelayedReleaseScope, an RAII-style object that will retain all objects
      that are unsafe to release until the end of the DelayedReleaseScope.
      
      * API/APIShims.h:
      (JSC::APICallbackShim::APICallbackShim):
      (JSC::APICallbackShim::vmForDropAllLocks):
      (JSC::APICallbackShim::execForDropAllLocks):
      * API/JSAPIWrapperObject.mm:
      (JSAPIWrapperObjectHandleOwner::finalize):
      * API/ObjCCallbackFunction.mm:
      (JSC::ObjCCallbackFunctionImpl::destroy):
      (JSC::ObjCCallbackFunction::destroy):
      * API/tests/testapi.mm:
      (-[TinyDOMNode initWithVirtualMachine:]):
      (-[TinyDOMNode dealloc]):
      (-[TinyDOMNode appendChild:]):
      (-[TinyDOMNode removeChildAtIndex:]):
      (-[EvilAllocationObject initWithContext:]):
      (-[EvilAllocationObject dealloc]):
      (-[EvilAllocationObject doEvilThingsWithContext:]):
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * heap/DelayedReleaseScope.h: Added.
      (JSC::DelayedReleaseScope::DelayedReleaseScope):
      (JSC::DelayedReleaseScope::~DelayedReleaseScope):
      (JSC::DelayedReleaseScope::releaseSoon):
      (JSC::MarkedSpace::releaseSoon):
      * heap/Heap.cpp:
      (JSC::Heap::collectAllGarbage):
      * heap/Heap.h:
      (JSC::Heap::releaseSoon):
      * heap/MarkedAllocator.cpp:
      (JSC::MarkedAllocator::allocateSlowCase):
      * heap/MarkedSpace.cpp:
      (JSC::MarkedSpace::MarkedSpace):
      (JSC::MarkedSpace::lastChanceToFinalize):
      (JSC::MarkedSpace::sweep):
      * heap/MarkedSpace.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac6f1fd4
    • timothy_horton@apple.com's avatar
      Layout Test fast/dom/Geolocation/notimer-after-unload.html is flaky and crashy on Mac WK2 · 53227d60
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124425
      
      * platform/mac-wk2/TestExpectations:
      Mark as crash/pass/fail, since it does all three :(
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53227d60
    • commit-queue@webkit.org's avatar
      Modifying RTCIceCandidate object construction to match the spec · a1366a09
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124369
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-15
      Reviewed by Eric Carlson.
      
      According to the spec the RTCIceCandidateInit parameter in RTCSessionDescription constructor is optional,
      which must not be nullable, and, if passed, must be a valid Dictionary. If the keys are not present, the string
      object that stores them in the RTCIceCandidate class, must be null in those cases. Also, if a key is present
      and its value is not valid an exception must be raised.
      
      Source/WebCore:
      
      Existing test was updated.
      
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCIceCandidate.cpp:
      (WebCore::RTCIceCandidate::create):
      * Modules/mediastream/RTCIceCandidate.idl:
      * UseJSC.cmake:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSRTCIceCandidateCustom.cpp: Added.
      (WebCore::JSRTCIceCandidateConstructor::constructJSRTCIceCandidate):
      
      LayoutTests:
      
      * fast/mediastream/RTCIceCandidate-expected.txt:
      * fast/mediastream/RTCIceCandidate.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1366a09
    • timothy_horton@apple.com's avatar
      Layout Test webgl/1.0.2/conformance/ogles/GL/tan/tan_001_to_006.html fails on Intel · 38f1f6b2
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124424
      
      * platform/mac/TestExpectations:
      Mark as flaky everywhere, since I have no way to mark it as failing on Intel
      and passing elsewhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38f1f6b2
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r159337. · 37afb394
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/159337
      https://bugs.webkit.org/show_bug.cgi?id=124423
      
      broke a bunch of fast/regions tests on EFL/GTK (Requested by
      philn on #webkit).
      
      Source/WebCore:
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::setLayoutOverflow):
      (WebCore::InlineFlowBox::setVisualOverflow):
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paint):
      (WebCore::RenderBlock::paintObject):
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
      (WebCore::RenderBlock::updateRegionRangeForBoxChild):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::hasNextPage):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::positionNewFloatOnLine):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderBoxRectInRegion):
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::addVisualOverflow):
      (WebCore::RenderBox::isUnsplittableForPagination):
      (WebCore::RenderBox::overflowRectForPaintRejection):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxRegionInfo.h:
      (WebCore::RenderBoxRegionInfo::createOverflow):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      (WebCore::RenderFlowThread::checkRegionsWithStyling):
      (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
      (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
      (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
      (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
      * rendering/RenderFlowThread.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::expandClipRectForDescendantsAndReflection):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updatePaintingInfoForFragments):
      (WebCore::RenderLayer::paintForegroundForFragments):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::parentClipRects):
      (WebCore::RenderLayer::calculateRects):
      (WebCore::RenderLayer::intersectsDamageRect):
      (WebCore::RenderLayer::repaintIncludingDescendants):
      * rendering/RenderLayer.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::addOverflowFromChildren):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderNamedFlowFragment.cpp:
      (WebCore::RenderNamedFlowFragment::createStyle):
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderOverflow.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      (WebCore::shouldPaintRegionContentsInPhase):
      (WebCore::RenderRegion::paintObject):
      (WebCore::RenderRegion::hitTestContents):
      (WebCore::RenderRegion::computeOverflowFromFlowThread):
      (WebCore::RenderRegion::repaintFlowThreadContent):
      (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
      (WebCore::RenderRegion::insertedIntoTree):
      (WebCore::RenderRegion::ensureOverflowForBox):
      (WebCore::RenderRegion::rectFlowPortionForBox):
      (WebCore::RenderRegion::addLayoutOverflowForBox):
      (WebCore::RenderRegion::addVisualOverflowForBox):
      (WebCore::RenderRegion::layoutOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
      * rendering/RenderRegion.h:
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paint):
      
      LayoutTests:
      
      * fast/regions/bottom-overflow-out-of-first-region-expected.html:
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
      * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/float-pushed-width-change-2-expected.html:
      * fast/regions/float-pushed-width-change-2.html:
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
      * fast/regions/outline-sides-in-region-expected.html:
      * fast/regions/outline-sides-in-region.html:
      * fast/regions/overflow-first-and-last-regions-expected.html: Removed.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Removed.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Removed.
      * fast/regions/overflow-first-and-last-regions.html: Removed.
      * fast/regions/overflow-last-region-expected.html: Added.
      * fast/regions/overflow-last-region.html: Added.
      * fast/regions/overflow-nested-regions-expected.html: Removed.
      * fast/regions/overflow-nested-regions.html: Removed.
      * fast/regions/overflow-region-float-expected.html: Removed.
      * fast/regions/overflow-region-float.html: Removed.
      * fast/regions/overflow-region-inline-expected.html: Removed.
      * fast/regions/overflow-region-inline.html: Removed.
      * fast/regions/overflow-region-transform-expected.html: Removed.
      * fast/regions/overflow-region-transform.html: Removed.
      * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
      * fast/regions/overflow-scrollable-rotated-fragment.html:
      * fast/regions/top-overflow-out-of-second-region-expected.html: Removed.
      * fast/regions/top-overflow-out-of-second-region.html:
      * fast/regions/webkit-flow-float-unable-to-push-expected.html:
      * fast/regions/webkit-flow-float-unable-to-push.html:
      * fast/repaint/increasing-region-content-height-expected.txt:
      * fast/repaint/increasing-region-content-height.html:
      * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37afb394
    • msaboff@apple.com's avatar
      REGRESSION (r158586): callToJavaScript needs to save return PC to Sentinel frame · 1cd33f8a
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124420
      
      Reviewed by Filip Pizlo.
      
      Save the return PC into the sentinel frame.
      
      * jit/JITStubsMSVC64.asm:
      * jit/JITStubsX86.h:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cd33f8a
    • antti@apple.com's avatar
      Hovering over text using simple line path should not cause switch to line boxes · 52e1a9f3
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124418
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: fast/text/simple-lines-hover.html
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::absoluteRects):
      (WebCore::RenderText::absoluteQuadsClippedToEllipsis):
      (WebCore::RenderText::absoluteQuads):
              
          Collect quads and rects directly from simple lines without requiring the line box switch.
      
      * rendering/SimpleLineLayoutFunctions.cpp:
      (WebCore::SimpleLineLayout::collectTextAbsoluteRects):
      (WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
              
          Add these.
      
      * rendering/SimpleLineLayoutFunctions.h:
      * rendering/SimpleLineLayoutResolver.h:
      (WebCore::SimpleLineLayout::RunResolver::Run::start):
      (WebCore::SimpleLineLayout::RunResolver::Run::end):
              
          For future use.
      
      LayoutTests: 
      
      * fast/text/simple-lines-hover-expected.html: Added.
      * fast/text/simple-lines-hover.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52e1a9f3
    • zoltan@webkit.org's avatar
      [CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html · 17aa01ca
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123808
      
      Reviewed by Mihnea Ovidenie.
      
      Use a rectangle instead of a complex polygon in the test.
      
      * fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html:
      * fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17aa01ca
    • jer.noble@apple.com's avatar
      MediaTime addition and subtraction operators have errors when the rhs is infinite. · 4d56f344
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124413
      
      Reviewed by Eric Carlson.
      
      Source/WTF:
      
      Correctly account for infinities that can occur on the right-hand side of addition or
      subtraction operators.
      
      * wtf/MediaTime.cpp:
      (WTF::MediaTime::operator+):
      (WTF::MediaTime::operator-):
      
      Tools:
      
      Add a test for operator+ and operator- where an infinite value appears
      on the right-hand side:
      * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
      (TestWebKitAPI::TEST):
      
      Add a LLDB summary provider for MediaTime which displays the rational
      time as well as the value in seconds:
      * lldb/lldb_webkit.py:
      (__lldb_init_module):
      (WTFMediaTime_SummaryProvider):
      (WTFHashTableProvider.has_children):
      (WTFMediaTimeProvider):
      (WTFMediaTimeProvider.__init__):
      (WTFMediaTimeProvider.timeValue):
      (WTFMediaTimeProvider.timeScale):
      (WTFMediaTimeProvider.isInvalid):
      (WTFMediaTimeProvider.isPositiveInfinity):
      (WTFMediaTimeProvider.isNegativeInfinity):
      (WTFMediaTimeProvider.isIndefinite):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d56f344
    • timothy_horton@apple.com's avatar
      Make it possible to select revision numbers on build.webkit.org/dashboard · dabad1bf
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124400
      
      Reviewed by Timothy Hatcher.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
      (BuildbotQueueView.prototype.revisionLinksForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
      (.selectable):
      Add a child span to the trac link, which has '-webkit-user-select: all' on it.
      This way, a Dashboard user can highlight revision numbers for easy copying,
      and doesn't even have to be precise about the selection.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dabad1bf
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 0ae08b42
      m.pakula@samsung.com authored
      Add failure test expectations for failing tests.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ae08b42
    • timothy_horton@apple.com's avatar
      results.html should have a link to historical results for a test/all failing tests · e1ccad9e
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124402
      
      Reviewed by Simon Fraser.
      
      * fast/harness/results.html:
      Add a new rightmost column, 'history'.
      Clicking on the column header will open the flakiness dashboard
      for the entire set of failing tests; clicking on the link
      in a particular test's row will open it just for that single test.
      
      * fast/harness/resources/results-test.js:
      Update the harness test to expect the new number of columns.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1ccad9e
    • timothy_horton@apple.com's avatar
      Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons · 0a9adbdb
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124399
      
      Reviewed by Gustavo Noronha Silva.
      
      Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
      with the icons adjusted to have solid backgrounds, to not be squished, and to not
      intersect the ring, similar to the Mac icons.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
      (documentReady.hideButton):
      (documentReady):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
      (table.queue-grid tr.platform.linux-gtk img.logo):
      (table.queue-grid tr.platform.linux-efl img.logo):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a9adbdb
    • commit-queue@webkit.org's avatar
      Fixed incorrectly placed NETWORK_PROCESS guard in NetworkConnectionToWebProcess.cpp · 002680e1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124398
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-15
      Reviewed by Brady Eidson.
      
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      002680e1
    • stavila@adobe.com's avatar
      [CSS Regions] Implement visual overflow for first & last regions · 81613fc9
      stavila@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118665
      
      Source/WebCore:
      
      In order to properly propagate the visual overflow of elements flowed inside regions,
      the responsiblity of painting and hit-testing content inside flow threads has been
      moved to the flow thread layer's level.
      Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
      structure, including one for the flow thread itself. This data is used during
      painting and hit-testing.
      
      Reviewed by David Hyatt.
      
      Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
             fast/regions/overflow-first-and-last-regions.html
             fast/regions/overflow-nested-regions.html
             fast/regions/overflow-region-float.html
             fast/regions/overflow-region-inline.html
             fast/regions/overflow-region-transform.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::setLayoutOverflow):
      (WebCore::InlineFlowBox::setVisualOverflow):
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverflowFromChildren):
      (WebCore::RenderBlock::paint):
      (WebCore::RenderBlock::paintObject):
      (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
      (WebCore::RenderBlock::updateRegionRangeForBoxChild):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::hasNextPage):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::positionNewFloatOnLine):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderBoxRectInRegion):
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::addLayoutOverflow):
      (WebCore::RenderBox::addVisualOverflow):
      (WebCore::RenderBox::isUnsplittableForPagination):
      (WebCore::RenderBox::overflowRectForPaintRejection):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::canHaveOutsideRegionRange):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxRegionInfo.h:
      (WebCore::RenderBoxRegionInfo::createOverflow):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
      (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
      (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
      (WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
      (WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
      (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
      (WebCore::RenderFlowThread::addRegionsVisualOverflow):
      (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
      * rendering/RenderFlowThread.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::expandClipRectForRegionAndReflection):
      (WebCore::expandClipRectForDescendantsAndReflection):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updatePaintingInfoForFragments):
      (WebCore::RenderLayer::paintForegroundForFragments):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::parentClipRects):
      (WebCore::RenderLayer::calculateRects):
      (WebCore::RenderLayer::intersectsDamageRect):
      (WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
      (WebCore::RenderLayer::repaintIncludingDescendants):
      (WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
      (WebCore::RenderLayer::paintFlowThreadIfRegion):
      (WebCore::RenderLayer::hitTestFlowThreadIfRegion):
      * rendering/RenderLayer.h:
      (WebCore::ClipRect::inflateX):
      (WebCore::ClipRect::inflateY):
      (WebCore::ClipRect::inflate):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::addOverflowFromChildren):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderNamedFlowFragment.cpp:
      (WebCore::RenderNamedFlowFragment::createStyle):
      (WebCore::RenderNamedFlowFragment::namedFlowThread):
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderOverflow.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore::RenderRegion::flowThreadPortionLocation):
      (WebCore::RenderRegion::regionContainerLayer):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      (WebCore::RenderRegion::computeOverflowFromFlowThread):
      (WebCore::RenderRegion::repaintFlowThreadContent):
      (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
      (WebCore::RenderRegion::insertedIntoTree):
      (WebCore::RenderRegion::ensureOverflowForBox):
      (WebCore::RenderRegion::rectFlowPortionForBox):
      (WebCore::RenderRegion::addLayoutOverflowForBox):
      (WebCore::RenderRegion::addVisualOverflowForBox):
      (WebCore::RenderRegion::layoutOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBox):
      (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
      * rendering/RenderRegion.h:
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::paint):
      
      LayoutTests:
      
      Rebased some tests due to regions layers changes.
      Updated some tests to increase clarity. Some of them were only passing because two
      regions were close together and the fact that an element was being painted
      inside the wrong region was not visible. Floats are now also unsplittable.
              - bottom-overflow-out-of-first-region
              - float-pushed-width-change-2
              - float-pushed-width-change
              - webkit-flow-float-unable-to-push
      
      Changed top-overflow-out-of-second-region to reftest.
      
      Added new tests for testing the visual overflow in different situations
      (transformed, inline, opacity, floating).
      
      Reviewed by David Hyatt.
      
      * fast/regions/bottom-overflow-out-of-first-region-expected.html:
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
      * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
      * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/float-pushed-width-change-2-expected.html:
      * fast/regions/float-pushed-width-change-2.html:
      * fast/regions/float-pushed-width-change-expected.html:
      * fast/regions/float-pushed-width-change.html:
      * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
      * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
      * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
      * fast/regions/outline-sides-in-region-expected.html:
      * fast/regions/outline-sides-in-region.html:
      * fast/regions/overflow-first-and-last-regions-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
      * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
      * fast/regions/overflow-first-and-last-regions.html: Added.
      * fast/regions/overflow-last-region-expected.html: Removed.
      * fast/regions/overflow-last-region.html: Removed.
      * fast/regions/overflow-nested-regions-expected.html: Added.
      * fast/regions/overflow-nested-regions.html: Added.
      * fast/regions/overflow-region-float-expected.html: Added.
      * fast/regions/overflow-region-float.html: Added.
      * fast/regions/overflow-region-inline-expected.html: Added.
      * fast/regions/overflow-region-inline.html: Added.
      * fast/regions/overflow-region-transform-expected.html: Added.
      * fast/regions/overflow-region-transform.html: Added.
      * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
      * fast/regions/overflow-scrollable-rotated-fragment.html:
      * fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
      * fast/regions/top-overflow-out-of-second-region.html:
      * fast/regions/webkit-flow-float-unable-to-push-expected.html:
      * fast/regions/webkit-flow-float-unable-to-push.html:
      * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
      * platform/mac-wk2/TestExpectations:
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
      * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81613fc9
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 6408b319
      m.pakula@samsung.com authored
      Update TestExpectations files with failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6408b319
    • commit-queue@webkit.org's avatar
      [GStreamer] Add support for Media Source API · 4ce17731
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99065
      
      Source/WebCore:
      
      The patch integrate a Media Source player for the GStreamer backend. The implementented architecture is:
      - MediaPlayerPrivateGStreamer engine is modified to support Media Source URIs (change blob:// to mediasourceblob://), in addition to the existing support for web (http/https/blob) URIs
      - Similar to the existing WebKitWebSrc gstreamer element that handles web URIs, a new gstreamer element named WebKitMediaSrc is implemented to handle Media Source URIs
      - WebKitMediaSrc registers its URI protocol handler, allowing uridecodebin to dynamically create the appropriate source element.
      - The WebKitMediaSrc element creates a bin with 2 appsrc: One for Audio and One for Video. Pads are dynamically linked at the reception of first video and audio buffers.
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      Tests: Activate http/tests/media/media-source and media/media-source tests
      
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::initializeGStreamerAndRegisterWebKitElements):
      (WebCore::MediaPlayerPrivateGStreamer::load):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      * platform/graphics/gstreamer/MediaSourceGStreamer.cpp: Added.
      (WebCore::MediaSourceGStreamer::open):
      (WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::~MediaSourceGStreamer):
      (WebCore::MediaSourceGStreamer::addSourceBuffer):
      (WebCore::MediaSourceGStreamer::setDuration):
      (WebCore::MediaSourceGStreamer::markEndOfStream):
      (WebCore::MediaSourceGStreamer::unmarkEndOfStream):
      * platform/graphics/gstreamer/MediaSourceGStreamer.h: Added.
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp: Added.
      (WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
      (WebCore::SourceBufferPrivateGStreamer::append):
      (WebCore::SourceBufferPrivateGStreamer::abort):
      (WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
      * platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h: Added.
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp: Added.
      (webKitMediaSrcAddSrc):
      (webkit_media_src_init):
      (webKitMediaSrcFinalize):
      (webKitMediaSrcSetProperty):
      (webKitMediaSrcGetProperty):
      (webKitMediaVideoSrcStop):
      (webKitMediaAudioSrcStop):
      (webKitMediaVideoSrcStart):
      (webKitMediaAudioSrcStart):
      (webKitMediaSrcChangeState):
      (webKitMediaSrcQueryWithParent):
      (webKitMediaSrcUriGetType):
      (webKitMediaSrcGetProtocols):
      (webKitMediaSrcGetUri):
      (webKitMediaSrcSetUri):
      (webKitMediaSrcUriHandlerInit):
      (webKitMediaVideoSrcNeedDataMainCb):
      (webKitMediaAudioSrcNeedDataMainCb):
      (webKitMediaVideoSrcNeedDataCb):
      (webKitMediaAudioSrcNeedDataCb):
      (webKitMediaVideoSrcEnoughDataMainCb):
      (webKitMediaAudioSrcEnoughDataMainCb):
      (webKitMediaVideoSrcEnoughDataCb):
      (webKitMediaAudioSrcEnoughDataCb):
      (webKitMediaVideoSrcSeekMainCb):
      (webKitMediaAudioSrcSeekMainCb):
      (webKitMediaVideoSrcSeekDataCb):
      (webKitMediaAudioSrcSeekDataCb):
      (webKitMediaSrcSetMediaPlayer):
      (webKitMediaSrcSetPlayBin):
      (MediaSourceClientGstreamer::MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::~MediaSourceClientGstreamer):
      (MediaSourceClientGstreamer::didReceiveDuration):
      (MediaSourceClientGstreamer::didReceiveData):
      (MediaSourceClientGstreamer::didFinishLoading):
      (MediaSourceClientGstreamer::didFail):
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h: Added.
      
      Tools:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
      Reviewed by Philippe Normand.
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce17731
    • berto@igalia.com's avatar
      [EFL] Leak in ewk_frame_certificate_status_get() · 17edd465
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124401
      
      Reviewed by Carlos Garcia Campos.
      
      The SoupMessage object is being leaked. In in this case that
      object is not even necessary since ResourceRequest already
      provides a way to get the soup flags directly.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_certificate_status_get):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17edd465
    • ossy@webkit.org's avatar
      Cleanup the build from unused parameters in WebKit2 · ba99c3ca
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124201
      
      Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-15
      Reviewed by Darin Adler.
      
      * Shared/Plugins/Netscape/PluginInformation.cpp:
      (WebKit::getPluginModuleInformation):
      * UIProcess/API/C/WKBatteryManager.cpp:
      (WKBatteryManagerSetProvider):
      (WKBatteryManagerProviderDidChangeBatteryStatus):
      (WKBatteryManagerProviderUpdateBatteryStatus):
      * UIProcess/API/C/WKBatteryStatus.cpp:
      (WKBatteryStatusCreate):
      * UIProcess/API/C/WKColorPickerResultListener.cpp:
      (WKColorPickerResultListenerSetColor):
      * UIProcess/API/C/WKContext.cpp:
      (WKContextGetBatteryManager):
      (WKContextGetDatabaseManager):
      (WKContextGetNetworkInfoManager):
      * UIProcess/API/C/WKDatabaseManager.cpp:
      (WKDatabaseManagerSetClient):
      (WKDatabaseManagerGetDatabasesByOrigin):
      (WKDatabaseManagerGetDatabaseOrigins):
      (WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
      (WKDatabaseManagerDeleteDatabasesForOrigin):
      (WKDatabaseManagerDeleteAllDatabases):
      (WKDatabaseManagerSetQuotaForOrigin):
      * UIProcess/API/C/WKNetworkInfo.cpp:
      (WKNetworkInfoCreate):
      * UIProcess/API/C/WKNetworkInfoManager.cpp:
      (WKNetworkInfoManagerSetProvider):
      (WKNetworkInfoManagerProviderDidChangeNetworkInformation):
      * UIProcess/API/C/WKOpenPanelParameters.cpp:
      (WKOpenPanelParametersCopyCapture):
      * UIProcess/API/C/WKVibration.cpp:
      (WKVibrationSetProvider):
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::createNewPage):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setVisibilityState):
      (WebKit::WebPageProxy::unavailablePluginButtonClicked):
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit::ViewClientEfl::didChangeContentsPosition):
      (WebKit::ViewClientEfl::didRenderFrame):
      (WebKit::ViewClientEfl::didChangeViewportAttributes):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setDatabaseQuota):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba99c3ca
    • graouts@apple.com's avatar
      Web Inspector: New color picker · d26f595c
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124354
      
      Reviewed by Timothy Hatcher.
      
      Beginning of a new color picker. The focus of this new picker is to let you pick from
      a color wheel as the primary mean of color picking, with additional slider controls for
      the brightness and the opacity, better matching the default OS X color picker. This is the
      basis for a color picker that will evolve to support the following:
      
      - editable CSS value label (http://webkit.org/b/124356)
      - picking a color anywhere on screen (http://webkit.org/b/124357)
      - swatches based on other colors in page (http://webkit.org/b/124358)
      
      Note also that the color wheel has not been tested on Retina displays
      (see http://webkit.org/b/124355).
      
      * UserInterface/CSSColorPicker.css: Removed.
      * UserInterface/CSSColorPicker.js: Removed.
      Previous color picker, now removed in favor of the new ColorPicker class.
      
      * UserInterface/CSSStyleDeclarationTextEditor.js:
      Adopt new class name for the color picker, add a little padding to the popover
      target frame and set the base color after the picker has been presented.
      
      * UserInterface/Color.js:
      (WebInspector.Color.prototype._hslToRGB):
      Simplified math.
      
      (WebInspector.Color.rgb2hsv):
      (WebInspector.Color.hsv2rgb):
      New utilities to deal with HSV colors used in the ColorWheel.
      
      * UserInterface/ColorPicker.css: Added.
      
      * UserInterface/ColorPicker.js: Added.
      (WebInspector.ColorPicker):
      (WebInspector.ColorPicker.prototype.get element):
      (WebInspector.ColorPicker.prototype.set brightness):
      (WebInspector.ColorPicker.prototype.set opacity):
      (WebInspector.ColorPicker.prototype.get color):
      
      (WebInspector.ColorPicker.prototype.set color):
      We set the _dontUpdateColor flag here such that we don't attempt to
      notify about a color change at this point in case the selected color
      is too saturated to be represented accurately on the color wheel and
      we would end up changing the color by virtue of presenting the popover.
      
      (WebInspector.ColorPicker.prototype.colorWheelColorDidChange):
      (WebInspector.ColorPicker.prototype.sliderValueDidChange):
      (WebInspector.ColorPicker.prototype._updateColor):
      (WebInspector.ColorPicker.prototype._updateSliders):
      
      * UserInterface/ColorWheel.css: Added.
      
      * UserInterface/ColorWheel.js: Added.
      The ColorWheel makes use of three different <canvas> elements to draw itself.
      The "raw" canvas is used to draw the raw, un-tinted color wheel with poor
      aliasing. The "raw" canvas is only drawn when the dimension is changed.
      The "tinted" canvas is used to draw the "raw" canvas with a black overlay
      based on the brightness set on the wheel. The "final" canvas, the only <canvas>
      element attached to the DOM, is used to draw the "tinted" canvas into a circle
      clip of a slightly narrower radius so that the drawn image is visually more pleasing
      and can be displayed above virtually any background color.
      
      We use color math to generate the color wheel, courtesy of Dean Jackson, and also to
      figure out where to position the crosshair for the provided base color as well as
      the opposite operation where we get the color under the mouse pointer.
      
      The color wheel fires a single delegate method call colorWheelColorDidChange(colorWheel),
      the colors themselves being retrieved via the public properties tintedColor and rawColor.
      
      (WebInspector.ColorWheel):
      (WebInspector.ColorWheel.prototype.set dimension):
      (WebInspector.ColorWheel.prototype.get element):
      (WebInspector.ColorWheel.prototype.get brightness):
      (WebInspector.ColorWheel.prototype.set brightness):
      (WebInspector.ColorWheel.prototype.get tintedColor):
      (WebInspector.ColorWheel.prototype.set tintedColor):
      (WebInspector.ColorWheel.prototype.get rawColor):
      (WebInspector.ColorWheel.prototype.handleEvent):
      (WebInspector.ColorWheel.prototype._handleMousedown):
      (WebInspector.ColorWheel.prototype._handleMousemove):
      (WebInspector.ColorWheel.prototype._handleMouseup):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent.angleFromCenterToPoint):
      (WebInspector.ColorWheel.prototype._pointInCircleForEvent.pointOnCircumference):
      (WebInspector.ColorWheel.prototype._updateColorForMouseEvent):
      (WebInspector.ColorWheel.prototype._setCrosshairPosition):
      (WebInspector.ColorWheel.prototype._tintedColorToPointAndBrightness):
      (WebInspector.ColorWheel.prototype._drawRawCanvas):
      (WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
      (WebInspector.ColorWheel.prototype._drawTintedCanvas):
      (WebInspector.ColorWheel.prototype._draw):
      
      * UserInterface/Images/SliderThumb.png: Added.
      * UserInterface/Images/SliderThumb@2x.png: Added.
      * UserInterface/Images/SliderThumbPressed.png: Added.
      * UserInterface/Images/SliderThumbPressed@2x.png: Added.
      Supporting artwork for the new Slider class.
      
      * UserInterface/Main.html:
      Remove the previous color picker class and add the new one, as well as the new Slider class.
      
      * UserInterface/Slider.css: Added.
      
      * UserInterface/Slider.js: Added.
      New slider to match the look of the sliders used in the native OS X color picker. The most
      interesting feature of these sliders is that they can be transformed using CSS in any way
      and will still operate correctly due to always converting the mouse coordinates in the page
      coordinate system to the coordinate system local to the backing element. For instance, the
      color picker uses two sliders transformed to be displayed vertically.
      
      As it stands these slides only support values between 0 and 1 and fire a single delegate
      method call sliderValueDidChange(slider, newValue).
      
      (WebInspector.Slider):
      (WebInspector.Slider.prototype.get element):
      (WebInspector.Slider.prototype.get value):
      (WebInspector.Slider.prototype.set value):
      (WebInspector.Slider.prototype.handleEvent):
      (WebInspector.Slider.prototype._handleMousedown):
      (WebInspector.Slider.prototype._handleMousemove):
      (WebInspector.Slider.prototype._handleMouseup):
      (WebInspector.Slider.prototype._localPointForEvent):
      (WebInspector.Slider.prototype.get _maxX):
      
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      Update file names for the new color picker.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d26f595c
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · eda0878f
      m.pakula@samsung.com authored
      Mark flaky and incorrectly passing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed wrong test expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eda0878f
    • calvaris@igalia.com's avatar
      [GTK] Bumping GStreamer version to 1.2.1 for the dependencies · edbc9d25
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124360
      
      Reviewed by Philippe Normand.
      
      Tools:
      
      * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
      
      LayoutTests:
      
      * platform/gtk/TestExpectations: Flagged
      media/video-canvas-drawing-output.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edbc9d25
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with international text properties need to be rebaselined. · 3608dfdd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124389
      
      Unreviewed, EFL rabaseline.
      
      EFL international text rebaselined after r147668.
      Move some expectation files to efl common place because those files in wk1 are
      in exact accordance with files in wk2, and then delete the files in wk1 and wk2.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-15
      
      * platform/efl-wk1/fast/text/international/003-expected.txt: Removed.
      * platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
      * platform/efl-wk2/TestExpectations:
      * platform/efl/fast/text/international/002-expected.txt:
      * platform/efl/fast/text/international/003-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt.
      * platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
      Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3608dfdd
  2. 14 Nov, 2013 14 commits
    • bfulgham@apple.com's avatar
      [Win] Improve support for command line builds of 64-bit JSC · 4afad6e5
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124380
      
      Patch by Brent Fulgham <bfulgham@apple.com> on 2013-11-14
      Reviewed by David Kilzer.
      
      * Scripts/webkitdirs.pm:
      (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
      'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
      (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
      what the "$configurationForVisualStudio" value is for.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4afad6e5
    • ap@apple.com's avatar
      Update WebCrypto tests · df32d58c
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124388
      
      Reviewed by Anders Carlsson.
      
      Updated tests for newer common.js. Changed some tests from just dumping results
      to comparing them to known expected ones. Fixed a syntax error in
      aes-cbc-invalid-length.html, so it now actually runs.
      
      * crypto/subtle/resources/common.js: Update to a new version from Blink, because
      it's much nicer than the old one, and it's good to be compatible at test level.
      Moved crypto.subtle definition from webkitSubtle here to avoid repeating it in all
      tests. Added a quick and dirty Promise.all implementation.
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-import-jwk-expected.txt:
      * crypto/subtle/aes-cbc-import-jwk.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-cbc-wrong-key-class.html:
      * crypto/subtle/aes-export-key-expected.txt:
      * crypto/subtle/aes-export-key.html:
      * crypto/subtle/argument-conversion-expected.txt:
      * crypto/subtle/argument-conversion.html:
      * crypto/subtle/hmac-export-key-expected.txt:
      * crypto/subtle/hmac-export-key.html:
      * crypto/subtle/hmac-generate-key.html:
      * crypto/subtle/hmac-import-jwk-expected.txt:
      * crypto/subtle/hmac-import-jwk.html:
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
      * crypto/subtle/hmac-sign-verify-empty-key.html:
      * crypto/subtle/hmac-sign-verify-expected.txt:
      * crypto/subtle/hmac-sign-verify.html:
      * crypto/subtle/import-jwk-expected.txt:
      * crypto/subtle/import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
      * crypto/subtle/sha-1-expected.txt:
      * crypto/subtle/sha-1.html:
      * crypto/subtle/sha-224-expected.txt:
      * crypto/subtle/sha-224.html:
      * crypto/subtle/sha-256-expected.txt:
      * crypto/subtle/sha-256.html:
      * crypto/subtle/sha-384-expected.txt:
      * crypto/subtle/sha-384.html:
      * crypto/subtle/sha-512-expected.txt:
      * crypto/subtle/sha-512.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df32d58c
    • commit-queue@webkit.org's avatar
      XMLSerializer escapes < > & correctly inside <script> and <style> tags. · d9eb969a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123914
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: fast/dom/XMLSerializer-entities.html
      
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): vim removed some whitespace.
      (WebCore::MarkupAccumulator::entityMaskForText): Fixed the returned value for <script> etc in XML.
      
      LayoutTests:
      
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: fix incorrect expectations.
      * fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: use CDATA consistently.
      * fast/dom/XMLSerializer-entities-expected.txt: Added.
      * fast/dom/XMLSerializer-entities.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9eb969a
    • bjonesbe@adobe.com's avatar
      ASSERTION FAILED:... · 40a09c02
      bjonesbe@adobe.com authored
      ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463)
      https://bugs.webkit.org/show_bug.cgi?id=124375
      
      Reviewed by Alexandru Chiculita.
      
      When moving the placed floats tree over to LayoutUnit, I forgot to
      update these asserts, which causes issues on ports with subpixel
      layout enabled.
      
      No new tests, no behavior change.
      
      * rendering/FloatingObjects.cpp:
      (WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
      (WebCore::::collectIfNeeded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40a09c02
    • commit-queue@webkit.org's avatar
      Clean up sequence handling in Blob constructor · 933bf408
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124343
      
      Patch by Victor Costan <costan@gmail.com> on 2013-11-14
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Added test case to LayoutTests/fast/files/blob-constructor.html
      
      * bindings/js/JSBlobCustom.cpp:
      (WebCore::JSBlobConstructor::constructJSBlob):
          Handle exceptions in sequences, eliminate double type-checking for
          ArrayBuffer, ArrayBufferView and Blob parts.
      
      LayoutTests:
      
      * fast/files/blob-constructor-expected.txt:
      * fast/files/script-tests/blob-constructor.js:
          Add test with sequence that throws an error on property access.
      (get Object):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      933bf408
    • mitz@apple.com's avatar
      [Cocoa] WKBrowsingContextController's policy client implementation... · d40e29d9
      mitz@apple.com authored
      [Cocoa] WKBrowsingContextController's policy client implementation over-releases WKURLRequests and WKURLResponses
      https://bugs.webkit.org/show_bug.cgi?id=124386
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (setUpPagePolicyClient): Changed to release the Cocoa objects we copy out of the WK objects
      passed into the client callbacks, but not the WK objects themselves, which are not owned by
      the callbacks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d40e29d9
    • oliver@apple.com's avatar
      Make CLoop easier to build, and make it work · 7c1eb76c
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124359
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Add --cloop to build-jsc, build-webkit and friends.
      
      Also make CLoop build and work again - This meant adding a
      couple of missing ENABLE(DFG_JIT) blocks, and fixing a few
      other references.
      
      * Configurations/FeatureDefines.xcconfig:
      * bytecode/BytecodeLivenessAnalysis.cpp:
      (JSC::computeUsesForBytecodeOffset):
      (JSC::computeDefsForBytecodeOffset):
      * bytecode/DFGExitProfile.cpp:
      * dfg/DFGCapabilities.cpp:
      * dfg/DFGCompilationKey.cpp:
      * dfg/DFGCompilationMode.cpp:
      * jit/JITExceptions.cpp:
      (JSC::genericUnwind):
      
      Source/WebCore:
      
      Add cloop configuration info to WebCore FeatureDefines
      so that it's consistent with JSC
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF:
      
      Make building with the CLoop forcibly enabled manually
      disable the JITs
      
      * wtf/Platform.h:
      
      Tools:
      
      Add --cloop support to forcibly enable to CLoop build
      
      * Scripts/build-jsc:
      * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c1eb76c
    • aestes@apple.com's avatar
      Replace calls to deprecated CFPropertyList functions in WebKit2 · 0948cfb1
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124384
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/cf/WebPageProxyCF.cpp:
      (WebKit::WebPageProxy::sessionStateData): Replaced CFPropertyListWriteToStream() with CFPropertyListWrite().
      (WebKit::WebPageProxy::restoreFromSessionStateData): Replaced CFPropertyListCreateFromXMLData() with CFPropertyListCreateWithData().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0948cfb1
    • timothy_horton@apple.com's avatar
      Change Fail->Failure in some recent expectations. · 16cf6054
      timothy_horton@apple.com authored
      Suddenly, everything is clear.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16cf6054
    • lforschler@apple.com's avatar
      Add webkit slave. · a3af40cb
      lforschler@apple.com authored
      Unreviewed.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3af40cb
    • timothy_horton@apple.com's avatar
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow,... · 650c6280
      timothy_horton@apple.com authored
      http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
      https://bugs.webkit.org/show_bug.cgi?id=124373
      
      * platform/mac/TestExpectations:
      Mark test as flaky on Mountain Lion Release bot.
      Marking as slow seems to have no effect on the notifyDone timeout, just the outer timeouts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650c6280
    • commit-queue@webkit.org's avatar
      [Cairo] Avoid extra copy when drawing images · b4822a07
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124209
      
      Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-11-14
      Reviewed by Martin Robinson.
      
      To solve the bug #58309 a cairo subsurface is being used to limit the
      source image boundaries.
      In many cases, when a cairo subsurface is used for drawing an image,
      it occurs an image copy, causing performance penalty. In the case of
      the function PlatformContextCairo::drawSurfaceToContext, the image
      copy always happens.
      So, we should use the subsurface only when it's really necessary.
      In cases where we're drawing the whole image, the subsurface is
      unnecessary.
      
      The proposed patch avoid the use of subsurfaces when sampling the whole
      image.
      
      No new tests. It's an enhancement. Already covered by existing tests.
      
      * platform/graphics/cairo/PlatformContextCairo.cpp:
      (WebCore::PlatformContextCairo::drawSurfaceToContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4822a07
    • timothy_horton@apple.com's avatar
      build.webkit.org/dashboard can’t open different results in two new tabs · ce8889fb
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124383
      
      Reviewed by Alexey Proskuryakov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
      (BuildbotQueueView.prototype.revisionLinksForIteration):
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
      (StatusLineView.prototype._clicked):
      Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
      real pseudo-target and instead acts as a named target and will end up causing all link clicks
      to open in the same secondary tab).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8889fb
    • commit-queue@webkit.org's avatar
      generate-message-receiver.py can't handle nested #ifs · 94dae52d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121877
      
      Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-14
      Reviewed by Darin Adler.
      
      parser.py was modifieded to collect and combine conditions of nested #ifs.
      messages_unittest.py extended to check these modifications.
      
      * Scripts/webkit2/messages_unittest.py:
      (LoadSomething):
      (std):
      (AddEvent):
      (LoadSomethingElse):
      * Scripts/webkit2/parser.py:
      (combine_condition):
      (bracket_if_needed):
      (parse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94dae52d