GitLab

https://bugs.webkit.org/show_bug.cgi?id=118471

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.

Right now all the buffers are uploaded onto the texture. With this
logic pose situations where buffers that will not be painted are
uploaded.

This patch uploads only the buffers that are going to be shown.

With this approach, the buffers may arrive before a GraphicsLayer is
set, so we should be more cautious with GraphicsLayerTextureMapper's
client.

No new tests, covered by existing tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118559

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.

Verify the correctness of the received caps in the video sink, and
also log them for debugging purposes.

No new tests, no behavior change.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkSetCaps):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118714

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Additionally, this patch removes isHTMLSelectElement because not all element subclasses can be checked by a combination of tag names.

Source/WebCore:

* html/HTMLSelectElement.h:
(WebCore::toHTMLSelectElement):
* testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible):

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndex):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):

Source/WebKit2:

* WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::commit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118699

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.

Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(EWK2TextCheckerTest::clickSelectAllWordsWithSpellcheckButton):
(EWK2TextCheckerTest::clickSelectAllWordsWithoutSpellcheckButton):
(EWK2TextCheckerTest::clickSelectSubWordWithSpellcheckButton):
(EWK2TextCheckerTest::showContextMenuWithFirstLineText):
(EWK2TextCheckerTest::showContextMenuWithSecondLineText):
(EWK2TextCheckerTest::selectFirstWordInFirstLineText):
(EWK2TextCheckerTest::selectFirstWordInSecondLineText):
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614

Reviewed by Ryosuke Niwa.

This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision

This crash can be initiated by calling Range.detach() while deleteContents()
is processing the same range. Range::processContents() should save the state
of the range since mutation events can change the state of the range.

Test: fast/dom/Range/detach-range-during-deletecontents.html

* dom/Range.cpp:
(WebCore::Range::processContents):
* dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):

LayoutTests: NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
https://bugs.webkit.org/show_bug.cgi?id=77614

Reviewed by Ryosuke Niwa.

This change is ported from Blink revision 153483:
https://src.chromium.org/viewvc/blink?revision=153483&view=revision

* fast/dom/Range/detach-range-during-deletecontents-expected.txt: Added.
* fast/dom/Range/detach-range-during-deletecontents.html: Added.
* fast/dom/Range/resources/detach-range-during-deletecontents-iframe.xhtml: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118695

Reviewed by Sam Weinig.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::remove): The destructor of StringImpl remove
the string from the string table if it is atomic. This needs to be done
on the same thread as the one on which the string was added (otherwise the original
table would keep a dangling pointer to a dead string).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Input element that becomes visible during a simulated click event from an associated label element doesn't get focused
https://bugs.webkit.org/show_bug.cgi?id=118700

Reviewed by Kent Tamura.

Source/WebCore:

Inspired by https://chromium.googlesource.com/chromium/blink/+/6435f70d53403b250e261a914f30d55142f81476.

The bug was caused by isMouseFocusable() check in HTMLLabelElement::defaultEventHandler not updating the layout even
though the call to dispatchSimulatedClick may have dirtied the render tree.

Explicitly update the layout so that we have up-to-date render tree.

Test: fast/forms/label/label-becomes-visible-while-clicking-on-label.html

* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):

LayoutTests:

Add a regression test.

* fast/forms/label/label-becomes-visible-while-clicking-on-label-expected.txt: Added.
* fast/forms/label/label-becomes-visible-while-clicking-on-label.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118672

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.

Source/WebCore:

* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* dom/Document.cpp:
(WebCore::Document::seamlessParentIFrame):
* html/HTMLIFrameElement.h:
(WebCore::toHTMLIFrameElement):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::viewCleared):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::isSeamless):
(WebCore::RenderIFrame::flattenFrame):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLIFrameElement::contentFrame):

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* editing/pasteboard/paste-noplugin-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
* platform/mac/accessibility/plugin-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=117435

Reviewed by Kenneth Russell.

Source/WebCore:

Adapted from Blink:
https://codereview.chromium.org/15619003/

Please see specification for details:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode

.oversample specifies what type of oversampling (if any) should be used when applying the shaping curve.
The default value is "none", meaning the curve will be applied directly to the input samples.
A value of "2x" or "4x" can improve the quality of the processing by avoiding some aliasing,
with the "4x" value yielding the highest quality.

Tests: webaudio/waveshaper-oversample-2x.html
       webaudio/waveshaper-oversample-4x.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::process):
(WebCore::WaveShaperDSPKernel::processCurve):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::latencyTime):
* Modules/webaudio/WaveShaperDSPKernel.h:
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):
(WebCore::WaveShaperNode::oversample):
* Modules/webaudio/WaveShaperNode.h:
(WebCore::WaveShaperNode::latency):
* Modules/webaudio/WaveShaperNode.idl:
* Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::setOversample):
* Modules/webaudio/WaveShaperProcessor.h:
(WebCore::WaveShaperProcessor::oversample):
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/DownSampler.cpp: Added.
(WebCore::DownSampler::DownSampler):
(WebCore::DownSampler::initializeKernel):
(WebCore::DownSampler::process):
(WebCore::DownSampler::reset):
(WebCore::DownSampler::latencyFrames):
* platform/audio/DownSampler.h: Added.
* platform/audio/UpSampler.cpp: Added.
(WebCore::UpSampler::UpSampler):
(WebCore::UpSampler::initializeKernel):
(WebCore::UpSampler::process):
(WebCore::UpSampler::reset):
(WebCore::UpSampler::latencyFrames):
* platform/audio/UpSampler.h: Added.

LayoutTests:

* webaudio/resources/waveshaper-testing.js: Added.
(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):
* webaudio/waveshaper-oversample-2x-expected.txt: Added.
* webaudio/waveshaper-oversample-2x.html: Added.
* webaudio/waveshaper-oversample-4x-expected.txt: Added.
* webaudio/waveshaper-oversample-4x.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/14209318>

Reviewed by Sam Weinig.
Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSDefaultStyleSheets.cpp:
* css/unavailablePlugIns.css: Added.
Add new Source/WebCore/css/unavailablePlugIns.css stylesheet.

* dom/EventListener.h:
New event listener type to support the creation of an event listener
for the label and icon for missing / blocked plug-in UI.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
Remove explicit event handling since we're now using a DOM event handler
on the label and icon in the shadow root.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Don't populate the shadow root with plugin snapshotting elements
if we're not planning on showing a snapshot, because this means that
the shadow root was created for the unavailable plugin indicator instead.

* page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageIncludeButton):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonDescription):
Set custom text to be displayed in the unavailability indicator.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginButtonClickEvent):
(WebCore::RenderEmbeddedObject::willBeDestroyed):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObjectEventListener::handleEvent):
(WebCore::RenderEmbeddedObjectEventListener::operator==):
Remove the old code used to render the missing / blocked plug-in UI in C++ in favor
of populating a shadow root in setPluginUnavailabilityReason(). We add a DOM event
listener in the shadow root to eventually call into unavailablePluginButtonClicked()
on the ChromeClient.

(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::layout):
Paint and lay out UA shadow root children.

(WebCore::RenderEmbeddedObject::canHaveChildren):
canHaveChildren can use the existence of a UA shadow root to decide
whether a RenderEmbeddedObject can have children.

* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObjectEventListener::create):
(WebCore::RenderEmbeddedObjectEventListener::cast):
(WebCore::RenderEmbeddedObjectEventListener::RenderEmbeddedObjectEventListener):
Create the new event listener class necessary to handle events in the shadow root.

(WebCore::RenderEmbeddedObject::pluginUnavailabilityReasonDescription): Added.

* rendering/RenderWidget.h:
Promote willBeDestroyed() to be public so we may override it in the RenderEmbeddedObject subclass.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)

* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::pluginLoadPolicy):
* UIProcess/WebLoaderClient.h:
Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Plumb the unavailability description through to the WebProcess via
the FindPlugin message.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
Make a strongly referencing copy of the list of PluginProxies, so we can
throw them away without the HashMap being mutated underneath us (see the comment).

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
Invalidate the plug-in's widget before setting the plugin unavailability reason,
because doing so would cause the plug-in's renderer to be torn down, making
invalidate() crash.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.
(WebKit::WebPage::canPluginHandleResponse):
Re-acquire the plugin's renderer, in case setPluginUnavailabilityReason destroyed it.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118701

Unreviewed, changing test expectations

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118690
<rdar://problem/14255963>

Patch by Simon Cooper <scooper@apple.com> on 2013-07-15
Reviewed by Dean Jackson.

Silently deny access to FlashPlayerTrust. This location contains
files containing lists of paths that Flash Player will
"allow" access to (without asking the user). Since the plugin
sandbox won't permit the access to the listed paths it is better
to silently block attempts to read these "whitelists". The
"whitelists" are created by other Adobe "installer" like
applications.

* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Scripts/webkitpy/common/config/contributors.json:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/118681>
<rdar://problem/14446014>

Reviewed by Sam Weinig.

Knock 8 bytes off of Font by packing the members better. Reduces memory consumption by 429 kB when
viewing the full HTML5 spec at <http://whatwg.org/c>

* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=16496

Patch by Rob Buis <rwlbuis@webkit.org> on 2013-07-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce a xml fragment serialization mode as indicated by
http://html5.org/specs/dom-parsing.html#xmlserializer (commit 00b84d2). In this mode
the XML fragment serialization algorithm is respected, the changes in this patch do the following:

- elements are self-closing if otherwise this would lead to invalid xml syntax.
- the resulting xml is XML namespace-well-formed (http://www.w3.org/TR/xml-names11/#Conformance).
This is achieved by always, when in xml fragment serialization mode, attempting to write out the element/attribute namespace,
preventing using the XML namespace as a default namespace and special casing the use of element's in XML namespace by using the xml prefix.

The chosen approach matches FireFox 25 behavior.

Test: fast/dom/dom-serialize-namespace.html

* WebCore.order: Adapt to changed createMarkup signature.
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): makes sure xml namespace/prefix is known so it is never used in namespace declarations.
(WebCore::MarkupAccumulator::appendNamespace): Avoid adding namespace declarations that do not differ from current default namespace.
(WebCore::MarkupAccumulator::appendOpenTag): Print xml prefix if the element's namespace is XML to avoid conflicts.
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Also take into account xmlns attributes with no namespace.
(WebCore::MarkupAccumulator::shouldSelfClose): Force self-closing to create well-formed XML elements.
* editing/MarkupAccumulator.h: Use EFragmentSerialization.
(WebCore::MarkupAccumulator::inXMLFragmentSerialization):
* editing/markup.cpp:
(WebCore::createMarkup):
* editing/markup.h: Add EFragmentSerialization enum.
* xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):

LayoutTests:

The updated tests are progressions and match FF.

* fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
* fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
* fast/dom/XMLSerializer-xml-namespace-expected.txt:
* fast/dom/dom-serialize-namespace-expected.txt: Added.
* fast/dom/dom-serialize-namespace.html: Added.
* fast/xsl/xslt-processor-expected.txt:
* inspector/elements/set-outer-html-expected.txt:
* svg/custom/xlink-prefix-in-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118694

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-07-15
Reviewed by Timothy Hatcher.

* UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118583

Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-15
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 API test if opengl is not available.
So, add fallback to non-opengl evas engine.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118692

Reviewed by Michael Saboff.

Merge https://chromium.googlesource.com/chromium/blink/+/2aa17cc56a807f7e05d386d6eb66cda25e6b0542.

* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118679

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.

No new tests, no behavior change.

* platform/network/NetworkStorageSession.h:
* platform/network/soup/NetworkStorageSessionSoup.cpp:

Source/WebKit/efl:

Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(EWKPrivate::storageSession):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118605

Reviewed by Joseph Pecoraro.

* Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* Tools/PrettyPrinting/Formatter.js:
* Tools/PrettyPrinting/FormatterContentBuilder.js:
* Tools/PrettyPrinting/codemirror.css:
* Tools/PrettyPrinting/codemirror.js:
* Tools/PrettyPrinting/css.js:
* Tools/PrettyPrinting/javascript.js:
* UserInterface/External/CodeMirror/closebrackets.js:
* UserInterface/External/CodeMirror/codemirror.css:
* UserInterface/External/CodeMirror/codemirror.js:
* UserInterface/External/CodeMirror/coffeescript.js:
* UserInterface/External/CodeMirror/comment.js:
* UserInterface/External/CodeMirror/css.js:
* UserInterface/External/CodeMirror/javascript.js:
* UserInterface/External/CodeMirror/matchbrackets.js:
* UserInterface/External/CodeMirror/sql.js:
* UserInterface/External/CodeMirror/xml.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118684

Reviewed by Alexey Proskuryakov.

Source/WebCore: 

Merge https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d.

DOM3 level 3 specifies compositionstart event's data to be the text to be replaced.
http://www.w3.org/TR/DOM-Level-3-Events/#event-type-compositionstart

According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
to the specified behavior.

Test: fast/events/ime-composition-events-001.html

* editing/Editor.cpp:
(WebCore::Editor::setComposition):

LayoutTests: 

Add a test case.

* fast/events/ime-composition-events-001-expected.txt:
* fast/events/ime-composition-events-001.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118693

Reviewed by Michael Saboff.

Merge https://chromium.googlesource.com/chromium/blink/+/5d9b240db74591c3689415c7b7c5180fadb379e9

Prior to this changeset, we were upconverting the entire XML document.
Let xmllib2 parse a document as iso-8859-1 when it's a 8-bit string.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::nativeEndianUTF16Encoding):
(WebCore::xmlDocPtrForString):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubberstamped by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* win/tools/vsprops/FeatureDefines.vsprops: Removed.
* win/tools/vsprops/FeatureDefinesCairo.vsprops: Removed.
* win/tools/vsprops/WinCairo.vsprops: Removed.
* win/tools/vsprops/cURL.vsprops: Removed.
* win/tools/vsprops/common.vsprops: Removed.
* win/tools/vsprops/debug.vsprops: Removed.
* win/tools/vsprops/debug_all.vsprops: Removed.
* win/tools/vsprops/debug_wincairo.vsprops: Removed.
* win/tools/vsprops/production.vsprops: Removed.
* win/tools/vsprops/release.vsprops: Removed.
* win/tools/vsprops/releaseproduction.vsprops: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118669

Patch by Antoine Quint <graouts@apple.com> on 2013-07-15
Reviewed by David Kilzer.

Source/WebCore:

Partial runs may be routed through the complex path in several Font functions. While incomplete,
we can check for a non-NULL run.renderingContext() and exempt runs that have it from being forced
down the complex path. A more thorough fix is already tracked by http://webkit.org/b/100050.

Adding a new testcase which is a copy of svg/text/text-overflow-ellipsis-svgfont.html with kerning
and ligatures turned on explicitly since DRT runs with those off by default and this option is required
to be on for the issue to reproduce.

Fix courtesy of Dan Bernstein.

Test: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html

* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):

LayoutTests:

* platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.png: Added.
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
* svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118649

Reviewed by Joseph Pecoraro.

* UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118575

Reviewed by Joseph Pecoraro.

* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
The original text marker might have been cleared by a style update, in this case we need to
find the new color text marker so we know the right range for the new style color text.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118356

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-15
Reviewed by Brent Fulgham.

If the download target file already exists, it is not replaced after the download has finished.
At this point, the user would have already approved to replace the file, so it should be replaced.

* platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination): Move file and replace it if it already exists.
If the new file is on a different volume, do a copy/delete operation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118613

The operations of creating/removing/updating/clearing weren't in the
right sequence. Changing the order solves the issue because when an image is
replaced the old one is deleted before the new one is created, and IDs are
not unique in cairo (they're based on the image pointer).

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::syncImageBackings):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

* WebCoreSupport/WebNotificationClient.mm:
(-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT.
(-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event.
(-[WebNotificationPolicyListener deny]): Ditto.

Source/WebKit2: Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

When requestPermission() is called, we short-circuit if we know the permission was already set.
The callback handler gets invoked. But now that callbacks are optional, we need to check to make
sure a callback was provided.

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Check for the callback.

LayoutTests: [WK2] Calling Notification.requestPermission() without a callback crashes
https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

* http/tests/notifications/notification-request-permission-expected.txt:
* http/tests/notifications/notification-request-permission.html: Add additional subtests that check
that the call succeeds even after granting or denying permission.

* http/tests/notifications/notification-request-permission-no-callback-expected.txt: Added.
* http/tests/notifications/notification-request-permission-no-callback.html: Added. Similar test to
notification-request-permission, without the callback function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
* Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=117137

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-07-15
Reviewed by Gustavo Noronha Silva.

Sometimes it is difficult to understand why remote inspector fails to deliver the content.
This patch gives an option to show error page with some basic explanation.

* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
* platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png:
* platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118596

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

Fixed memory leak.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getGailTextUtilForAtk):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115166

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-15
Reviewed by Philippe Normand.

* gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118530

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.

In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.

* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152627 268f45cc-cd09-0410-ab3c-d52691b4dbfc