1. 01 Oct, 2006 4 commits
    • ggaren's avatar
      LayoutTests: · fc3c26a8
      ggaren authored
              Added test for the viewource attribute, which applies to <frame> and
              <iframe> elements.
              * fast/frames/viewsource-attribute-expected.txt: Added.
              * fast/frames/viewsource-attribute.html: Added.
              * fast/frames/frameElement-widthheight.html: Removed stray character.
              Reviewed by Maciej.
              More frame/iframe merging.
              - Removed needWidgetUpdate and related code. needWidgetUpdate is always
              false, so this was dead code.
              - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
              than attach(), is the correct place for setInViewSourceMode, because
              openURL() is the function that creates our frame.
              - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
              code that did the same thing in other places.
              - Made FRAME's attach() method suffuciently generic so that IFRAME could
              call up to it, rather than skipping its superclass and calling up directly 
              to ELEMENT.
              - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
              - Replaced ad hoc frame loading code in FRAME::attach() with call to
              openURL(), the designated frame loading function.
              Layout tests pass. I added a layout test for viewsource mode, since I
              broke it in the course of writing this patch.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      LayoutTests: · a2c2e1bf
      harrison authored
              Reviewed by John Sullivan.
              <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
              * fast/text/international/wrap-CJK-001-expected.checksum: Added.
              * fast/text/international/wrap-CJK-001-expected.png: Added.
              * fast/text/international/wrap-CJK-001-expected.txt: Added.
              * fast/text/international/wrap-CJK-001.html: Added.
              Reviewed by John Sullivan.
              <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
              Problem was that the decision to trim was based only on whether the character
              is a soft hyphen, which caused pretty much any Japanese character to go.
              Changed to decide based on whether the character is ignorable whitespace.
              * fast/text/international/wrap-CJK-001.html
              * rendering/bidi.cpp:
              New. Checks whether character is whitespace that can be ignored
              according to the text node's style.
              trimmed from the end of wrapped line.
              Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap's avatar
      Reviewed by Hyatt. · 932806a9
      ap authored
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
              REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
              Make sure we only break after a space (and not any other valid line-break) if
              the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
              I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
              twice in quick succession.
              Test: fast/text/line-breaks-after-white-space.html
              * rendering/bidi.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap's avatar
      Reviewed by Maciej and Darin. · 08a32007
      ap authored
              JavaScript document.write page form does not submit in Safari
              Test: fast/forms/document-write.html
              * page/Frame.cpp:
              (WebCore::Frame::submitForm): Don't check for parsing().
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 30 Sep, 2006 1 commit
    • ap's avatar
      Reviewed by Darin. · e08cbe85
      ap authored
              External CSS is parsed as iso-8859-1 even though the main document is utf-8
              Test: fast/encoding/css-charset-default.xhtml
              * loader/CachedResourceClient.h:
              Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
              takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
              * css/CSSImportRule.h:
              * css/CSSStyleSheet.cpp:
              * css/CSSStyleSheet.h:
              Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
              member. Changed some String parameters to const String&.
              * css/StyleSheet.cpp:
              * css/StyleSheet.h:
              Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
              * css/StyleSheetList.cpp:
              * css/StyleSheetList.h:
              Special-casing implicit stylesheets seemed to be dead code, removed.
              * dom/Document.cpp:
              * dom/Document.h:
              Renamed setStyleSheet() to setCSSStyleSheet().
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
              * dom/ProcessingInstruction.h:
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
              is not specified.
              * html/HTMLLinkElement.h:
              * html/HTMLStyleElement.cpp:
              * ksvg2/svg/SVGStyleElement.cpp:
              Inherit URL and charset from the document.
              * loader/Cache.cpp:
              * loader/Cache.h:
              Adjust for setStyleSheet() renaming.
              * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
              * loader/CachedCSSStyleSheet.cpp:
              Pass the encoding to setCSSStyleSheet().
              * loader/CachedXSLStyleSheet.cpp:
              * loader/DocLoader.cpp:
              * loader/DocLoader.h:
              * page/Frame.cpp:
              * xml/XSLImportRule.cpp:
              * xml/XSLImportRule.h:
              Adjust for setStyleSheet() renaming.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 29 Sep, 2006 5 commits
    • thatcher's avatar
      Bug 11041: fast/dom/isindex-001 needs new results · 17a576b5
      thatcher authored
              * fast/dom/isindex-001-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      LayoutTests: · eb140e63
      ggaren authored
              Reviewed by John, Maciej.
              Added test for whether a frame element reports its src attribute as a
              complete, rather than relative, URL.
              * fast/frames/frame-src-attribute-expected.txt: Added.
              * fast/frames/frame-src-attribute.html: Added.
              * fast/frames/resources/frame-src-attribute-subframe.html: Added.
              Reviewed by John, Maciej.
              Integrated some frame and iframe code. I'm trying to fix up frame ownership
              and loading. Reducing the number of different code paths involved
              seemed like a good first step.
              As a side effect, I fixed a bug where FRAME elements would report their
              src attributes as relative, rather than compelete, URLs. (IFRAME elements
              had the correct complete URL behavior.)
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
                  (1) Removed checks that requestFrame does for us
                  (2) Added isURLAllowed check, to have one clear bottleneck for it
                  (3) Added viewsource check, to have one clear bottleneck for it
              (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
              method, instead of finding our content frame in our own unique way.
              (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
              since openURL does this for us now.
              (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
              This is what FF does, and it made no sense to have different behaviors
              for FRAME and IFRAME elements.
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
              * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
              HTMLFrameElement now does everything we need.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      LayoutTests: · 43f6c9d0
      harrison authored
              Reviewed by John Sullivan.
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
              * fast/text/attributed-substring-from-range-001-expected.txt: Added.
              * fast/text/attributed-substring-from-range-001.html: Added.
              Check attributed string results when starting or ending at a br element.
              Reviewed by John Sullivan.
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
              Test added
              * fast/text/attributed-substring-from-range-001.html
              * bridge/mac/FrameMac.mm:
              Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
              Also, add validation of the range.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rwlbuis's avatar
      I commited old expected results, this one is correct. · 040adbfb
      rwlbuis authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rwlbuis's avatar
      Reviewed by Maciej. · eb9f6717
      rwlbuis authored
              InsertRule can not handle @import statements
              Allow @import as part of a css rule.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 23 Sep, 2006 1 commit
    • ap's avatar
      Reviewed by Eric. · 37b0558e
      ap authored
              XMLHttpRequest fails to throw an exception when there is a security violation
              (mismatching domains)
              Raise an exception if there is a security violation, and also in cases required by
              the current draft of XHR specification.
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
              (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
              reports one, and also if there were too few arguments passed. 
              * bindings/js/kjs_binding.cpp:
              (KJS::setDOMException): Added support for custom XHR exceptions.
              * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
              exception code range for XHR exceptions.
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
              * http/tests/xmlhttprequest/exceptions-expected.txt: Added.
              * http/tests/xmlhttprequest/exceptions.html: Added.
              * http/tests/xmlhttprequest/extra-parameters-expected.txt: Added.
              * http/tests/xmlhttprequest/extra-parameters.html: Added.
              * http/tests/xmlhttprequest/resources/post-echo.cgi: Added.
              Test that passing too many parameters is OK (Firefox behavior; WinIE raises an exception).
              * fast/dom/xmlhttprequest-get-expected.txt: Updated results. 
              * http/tests/xmlhttprequest/zero-length-response-expected.txt:
              * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
              * http/tests/xmlhttprequest/zero-length-response-sync.html:
              * http/tests/xmlhttprequest/zero-length-response.html:
              Updated results and changed state names to match the current spec.
              * http/tests/xmlhttprequest/resources/zero-length.xml: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. 22 Sep, 2006 1 commit
  6. 21 Sep, 2006 1 commit
    • thatcher's avatar
      LayoutTests: · 65653f6d
      thatcher authored
              Reviewed by Adam.
              Bug 10923: Frame scroll layout test failures on the buildbot
              Made this test call layoutTestController.dumpChildFrameScrollPositions().
              * fast/overflow/scrollRevealButton-expected.txt:
              * fast/overflow/scrollRevealButton.html:
              Reviewed by Adam.
              Bug 10923: Frame scroll layout test failures on the buildbot
              Added a new method that will toggle on the recursive dump of
              child frame scroll positions.
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController dumpChildFrameScrollPositions]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 20 Sep, 2006 2 commits
    • aroben's avatar
      Reviewed by timothy. · 937c656d
      aroben authored
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
              Test results for fast/js/window-properties.html should include
              children of window.document.body.firstChild
              * fast/js/window-properties-expected.txt: Regenerate results which now
              include window.document.body.firstChild.*
              * fast/js/window-properties.html: Print out 'null' for null objects
              instead of 'object' for more clarity
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      WebCore: · 4268dc9f
      aroben authored
              Reviewed by Adele.
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
              REGRESSION: file upload control with direction:rtl or text-align:right
              draws button on top of filename/icon
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::setStyle): Force text-align to
              match direction
              (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
              the filename and icon in RTL
              Reviewed by Adele.
              Adding test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
              REGRESSION: file upload control with direction:rtl or text-align:right
              draws button on top of filename/icon
              * fast/forms/file-input-direction-expected.checksum: Added.
              * fast/forms/file-input-direction-expected.png: Added.
              * fast/forms/file-input-direction-expected.txt: Added.
              * fast/forms/file-input-direction.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. 19 Sep, 2006 2 commits
  9. 18 Sep, 2006 2 commits
  10. 17 Sep, 2006 6 commits
  11. 15 Sep, 2006 4 commits
  12. 13 Sep, 2006 1 commit
  13. 12 Sep, 2006 2 commits
  14. 11 Sep, 2006 4 commits
  15. 10 Sep, 2006 2 commits
  16. 09 Sep, 2006 2 commits