1. 01 Oct, 2006 6 commits
    • ggaren's avatar
      LayoutTests: · fc3c26a8
      ggaren authored
              Added test for the viewource attribute, which applies to <frame> and
              <iframe> elements.
      
              * fast/frames/viewsource-attribute-expected.txt: Added.
              * fast/frames/viewsource-attribute.html: Added.
      
              * fast/frames/frameElement-widthheight.html: Removed stray character.
      
      WebCore:
      
              Reviewed by Maciej.
              
              More frame/iframe merging.
              
              - Removed needWidgetUpdate and related code. needWidgetUpdate is always
              false, so this was dead code.
              - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
              than attach(), is the correct place for setInViewSourceMode, because
              openURL() is the function that creates our frame.
              - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
              code that did the same thing in other places.
              - Made FRAME's attach() method suffuciently generic so that IFRAME could
              call up to it, rather than skipping its superclass and calling up directly 
              to ELEMENT.
              - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
              - Replaced ad hoc frame loading code in FRAME::attach() with call to
              openURL(), the designated frame loading function.
      
              Layout tests pass. I added a layout test for viewsource mode, since I
              broke it in the course of writing this patch.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc3c26a8
    • harrison's avatar
      LayoutTests: · a2c2e1bf
      harrison authored
              Reviewed by John Sullivan.
      
              <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
      
              * fast/text/international/wrap-CJK-001-expected.checksum: Added.
              * fast/text/international/wrap-CJK-001-expected.png: Added.
              * fast/text/international/wrap-CJK-001-expected.txt: Added.
              * fast/text/international/wrap-CJK-001.html: Added.
      
      WebCore:
      
              Reviewed by John Sullivan.
      
              <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
      
              Problem was that the decision to trim was based only on whether the character
              is a soft hyphen, which caused pretty much any Japanese character to go.
              Changed to decide based on whether the character is ignorable whitespace.
              
              Test:
              * fast/text/international/wrap-CJK-001.html
      
              * rendering/bidi.cpp:
              (WebCore::isTrimmableChar):
              New. Checks whether character is whitespace that can be ignored
              according to the text node's style.
              trimmed from the end of wrapped line.
              (WebCore::checkMidpoints):
              Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2c2e1bf
    • ap's avatar
      2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com> · 692e06e4
      ap authored
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
              REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
      
              No test case added (probably requires new DumpRenderTree functionality)
      
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::imageChanged): Added early return if the document is
              being destroyed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692e06e4
    • ap's avatar
      Reviewed by Hyatt. · 932806a9
      ap authored
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
              REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
              
              Make sure we only break after a space (and not any other valid line-break) if
              the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
              I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
              twice in quick succession.
      
              Test: fast/text/line-breaks-after-white-space.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak): 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      932806a9
    • ap's avatar
      Fixed Bugzilla references in ChangeLogs for my previous commit. · 243119ad
      ap authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243119ad
    • ap's avatar
      Reviewed by Maciej and Darin. · 08a32007
      ap authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
              JavaScript document.write page form does not submit in Safari
      
              Test: fast/forms/document-write.html
      
              * page/Frame.cpp:
              (WebCore::Frame::submitForm): Don't check for parsing().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08a32007
  2. 30 Sep, 2006 2 commits
    • ap's avatar
      Reviewed by Darin. · e08cbe85
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=11011
              External CSS is parsed as iso-8859-1 even though the main document is utf-8
      
              Test: fast/encoding/css-charset-default.xhtml
      
              * loader/CachedResourceClient.h:
              (WebCore::CachedResourceClient::setCSSStyleSheet):
              (WebCore::CachedResourceClient::setXSLStyleSheet):
              Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
              takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
      
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::setCSSStyleSheet):
              (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
              * css/CSSImportRule.h:
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::CSSStyleSheet):
              * css/CSSStyleSheet.h:
              Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
              member. Changed some String parameters to const String&.
      
              * css/StyleSheet.cpp:
              (WebCore::StyleSheet::StyleSheet):
              * css/StyleSheet.h:
              Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
      
              * css/StyleSheetList.cpp:
              (WebCore::StyleSheetList::length):
              (WebCore::StyleSheetList::item):
              * css/StyleSheetList.h:
              Special-casing implicit stylesheets seemed to be dead code, removed.
      
              * dom/Document.cpp:
              (WebCore::Document::setCSSStyleSheet):
              (WebCore::Document::recalcStyleSelector):
              * dom/Document.h:
              Renamed setStyleSheet() to setCSSStyleSheet().
      
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
              (WebCore::ProcessingInstruction::setCSSStyleSheet):
              (WebCore::ProcessingInstruction::setXSLStyleSheet):
              (WebCore::ProcessingInstruction::parseStyleSheet):
              * dom/ProcessingInstruction.h:
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
              is not specified.
              (WebCore::HTMLLinkElement::setCSSStyleSheet):
              * html/HTMLLinkElement.h:
      
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::childrenChanged):
              * ksvg2/svg/SVGStyleElement.cpp:
              (WebCore::SVGStyleElement::childrenChanged):
              Inherit URL and charset from the document.
      
              * loader/Cache.cpp:
              (WebCore::Cache::requestCSSStyleSheet):
              * loader/Cache.h:
              Adjust for setStyleSheet() renaming.
      
              * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::ref):
              (WebCore::CachedCSSStyleSheet::deref):
              (WebCore::CachedCSSStyleSheet::checkNotify):
              Pass the encoding to setCSSStyleSheet().
      
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::ref):
              (WebCore::CachedXSLStyleSheet::checkNotify):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestCSSStyleSheet):
              * loader/DocLoader.h:
              * page/Frame.cpp:
              (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
              (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
              * xml/XSLImportRule.cpp:
              (WebCore::XSLImportRule::setXSLStyleSheet):
              (WebCore::XSLImportRule::loadSheet):
              * xml/XSLImportRule.h:
              Adjust for setStyleSheet() renaming.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e08cbe85
    • rwlbuis's avatar
      Reviewed by eseidel. · 1f4fa6e6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11096
              Hit testing for polylines fails
      
              Fix Path::contains so it handles filled, non-closed paths too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f4fa6e6
  3. 29 Sep, 2006 6 commits
    • thatcher's avatar
      Bug 11041: fast/dom/isindex-001 needs new results · 17a576b5
      thatcher authored
              http://bugs.webkit.org/show_bug.cgi?id=11041
      
              * fast/dom/isindex-001-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17a576b5
    • ggaren's avatar
      LayoutTests: · eb140e63
      ggaren authored
              Reviewed by John, Maciej.
              
              Added test for whether a frame element reports its src attribute as a
              complete, rather than relative, URL.
      
              * fast/frames/frame-src-attribute-expected.txt: Added.
              * fast/frames/frame-src-attribute.html: Added.
              * fast/frames/resources/frame-src-attribute-subframe.html: Added.
      
      WebCore:
      
              Reviewed by John, Maciej.
              
              Integrated some frame and iframe code. I'm trying to fix up frame ownership
              and loading. Reducing the number of different code paths involved
              seemed like a good first step.
              
              As a side effect, I fixed a bug where FRAME elements would report their
              src attributes as relative, rather than compelete, URLs. (IFRAME elements
              had the correct complete URL behavior.)
      
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
              (WebCore::HTMLFrameElement::openURL):
                  (1) Removed checks that requestFrame does for us
                  (2) Added isURLAllowed check, to have one clear bottleneck for it
                  (3) Added viewsource check, to have one clear bottleneck for it
              (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
              method, instead of finding our content frame in our own unique way.
              (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
              since openURL does this for us now.
              (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
              This is what FF does, and it made no sense to have different behaviors
              for FRAME and IFRAME elements.
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
              code.
              * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
              HTMLFrameElement now does everything we need.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb140e63
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 61b29d73
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61b29d73
    • harrison's avatar
      LayoutTests: · 43f6c9d0
      harrison authored
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              * fast/text/attributed-substring-from-range-001-expected.txt: Added.
              * fast/text/attributed-substring-from-range-001.html: Added.
              
              Check attributed string results when starting or ending at a br element.
      
      WebCore:
      
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              Test added
              * fast/text/attributed-substring-from-range-001.html
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::attributedString):
              Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
              Also, add validation of the range.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43f6c9d0
    • rwlbuis's avatar
      I commited old expected results, this one is correct. · 040adbfb
      rwlbuis authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      040adbfb
    • rwlbuis's avatar
      Reviewed by Maciej. · eb9f6717
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
              InsertRule can not handle @import statements
      
              Allow @import as part of a css rule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9f6717
  4. 28 Sep, 2006 1 commit
    • harrison's avatar
      LayoutTests: · a353c8cb
      harrison authored
              Reviewed by Justin.
      
              Call clearKillRing() so we are guaranteed to start with empty kill ring.
      
              * editing/pasteboard/emacs-cntl-y-001.html:
      
      WebKitTools:
      
              Reviewed by Justin.
              
              Add clearKillRing so we can test emacs support with empty kill ring.
      
              * DumpRenderTree/EventSendingController.m:
              (+[EventSendingController isSelectorExcludedFromWebScript:]):
              (+[EventSendingController webScriptNameForSelector:]):
              (-[EventSendingController clearKillRing]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a353c8cb
  5. 27 Sep, 2006 3 commits
  6. 26 Sep, 2006 5 commits
    • justing's avatar
      LayoutTests: · cdacf131
      justing authored
              Reviewed by john
              
              <rdar://problem/4747695> 
              Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
      
              * editing/deleting/list-item-1-expected.checksum: Added.
              * editing/deleting/list-item-1-expected.png: Added.
              * editing/deleting/list-item-1-expected.txt: Added.
              * editing/deleting/list-item-1.html: Added.
              * editing/execCommand/remove-list-item-1-expected.checksum: Added.
              * editing/execCommand/remove-list-item-1-expected.png: Added.
              * editing/execCommand/remove-list-item-1-expected.txt: Added.
              * editing/execCommand/remove-list-item-1.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <rdar://problem/4747695> 
              Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
              
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
              to select special elements that are fully selected after expansion
              moves to positions that are visually distinct from the originals.
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply): If the content of the list 
              item will be moved into another list, put it in a list item.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdacf131
    • harrison's avatar
      LayoutTests: · 478db1e6
      harrison authored
              Reviewed by John and TimH.
              
              <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty
      
              * editing/pasteboard/emacs-cntl-y-001-expected.checksum: Added.
              * editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
              * editing/pasteboard/emacs-cntl-y-001-expected.txt: Added.
              * editing/pasteboard/emacs-cntl-y-001.html: Added.
      
      WebKit:
      
              Reviewed by John and TimH.
      
              <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty
      
              Use deleteBackward: when the killring string is empty. Was always using insertText:,
              but that ends up early-returning if the string to insert is empty.
              
              * WebView/WebHTMLView.m:
              (-[NSArray yank:]):
              (-[NSArray yankAndSelect:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      478db1e6
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · be2e75ce
      eseidel authored
              Reviewed by Tim H.
              
              viewbox parser does not allow <tab> as a delimiter
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
      
              Test: svg/hixie/viewbox/003.xml
      
              * ksvg2/svg/svgpathparser.cpp:
              (WebCore::isWhitespace): new function
              (WebCore::skipOptionalSpaces):
              (WebCore::skipOptionalSpacesOrComma):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2e75ce
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · 8192b622
      eseidel authored
              Reviewed by Tim H.
      
              SVGDocument::createElement does not create elements in the SVG namespace
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
              
              Test: svg/custom/createelement.svg
      
              * ksvg2/svg/SVGDocument.cpp:
              (WebCore::SVGDocument::createElement):
              * ksvg2/svg/SVGDocument.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8192b622
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · de9f5ab7
      eseidel authored
              Reviewed by Tim H.
              
              RenderPath::nodeAtPoint does not respect stroke width
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
      
              Test: svg/custom/stroke-width-click.svg
      
              * kcanvas/device/quartz/KCanvasItemQuartz.mm:
              (WebCore::RenderPath::strokeContains):
              * kcanvas/device/quartz/QuartzSupport.h:
              * kcanvas/device/quartz/QuartzSupport.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de9f5ab7
  7. 25 Sep, 2006 2 commits
  8. 24 Sep, 2006 2 commits
  9. 23 Sep, 2006 1 commit
    • ap's avatar
      Reviewed by Eric. · 37b0558e
      ap authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
              XMLHttpRequest fails to throw an exception when there is a security violation
              (mismatching domains)
      
              Raise an exception if there is a security violation, and also in cases required by
              the current draft of XHR specification.
      
      WebCore:
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
              (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
              reports one, and also if there were too few arguments passed. 
      
              * bindings/js/kjs_binding.cpp:
              (KJS::setDOMException): Added support for custom XHR exceptions.
      
              * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
              exception code range for XHR exceptions.
      
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::setRequestHeader):
              (WebCore::XMLHttpRequest::getStatus):
              (WebCore::XMLHttpRequest::getStatusText):
              (WebCore::XMLHttpRequest::processSyncLoadResults):
              (WebCore::XMLHttpRequest::receivedAllData):
              (WebCore::XMLHttpRequest::receivedData):
      
      LayoutTests:
              * http/tests/xmlhttprequest/exceptions-expected.txt: Added.
              * http/tests/xmlhttprequest/exceptions.html: Added.
      
              * http/tests/xmlhttprequest/extra-parameters-expected.txt: Added.
              * http/tests/xmlhttprequest/extra-parameters.html: Added.
              * http/tests/xmlhttprequest/resources/post-echo.cgi: Added.
              Test that passing too many parameters is OK (Firefox behavior; WinIE raises an exception).
      
              * fast/dom/xmlhttprequest-get-expected.txt: Updated results. 
      
              * http/tests/xmlhttprequest/zero-length-response-expected.txt:
              * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
              * http/tests/xmlhttprequest/zero-length-response-sync.html:
              * http/tests/xmlhttprequest/zero-length-response.html:
              Updated results and changed state names to match the current spec.
      
              * http/tests/xmlhttprequest/resources/zero-length.xml: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37b0558e
  10. 22 Sep, 2006 2 commits
  11. 21 Sep, 2006 4 commits
    • thatcher's avatar
      Adding more calls to layoutTestController.dumpChildFrameScrollPositions() · 509e0cdf
      thatcher authored
              for tests that need to report child frame scroll positions.
      
              * http/tests/navigation/anchor-frames.html:
              * http/tests/navigation/anchor-subframeload.html:
              * http/tests/navigation/relativeanchor-frames.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      509e0cdf
    • thatcher's avatar
      LayoutTests: · 65653f6d
      thatcher authored
              Reviewed by Adam.
      
              Bug 10923: Frame scroll layout test failures on the buildbot
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
      
              Made this test call layoutTestController.dumpChildFrameScrollPositions().
      
              * fast/overflow/scrollRevealButton-expected.txt:
              * fast/overflow/scrollRevealButton.html:
      
      WebKitTools:
      
              Reviewed by Adam.
      
              Bug 10923: Frame scroll layout test failures on the buildbot
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10923
              
              Added a new method that will toggle on the recursive dump of
              child frame scroll positions.
       
              * DumpRenderTree/DumpRenderTree.m:
              (dumpFrameScrollPosition):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController dumpChildFrameScrollPositions]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65653f6d
    • justing's avatar
      LayoutTests: · f62fcd3a
      justing authored
              Reviewed by john
      
              * editing/pasteboard/subframe-dragndrop-1-expected.checksum: Added.
              * editing/pasteboard/subframe-dragndrop-1-expected.png: Added.
              * editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
              * editing/pasteboard/subframe-dragndrop-1.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
              TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
      
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
              to the position-to-move-to's document, not the fragment's document.  The 
              fragment's document is the document used to create the fragment and is irrelavant.
      
      WebKit:
      
              Reviewed by john
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
              TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
              
              The top level WebHTMLView is responsible for performing dragging operations, but
              the inner view, the view that holds the drag caret, should be consulted to determine
              if the drag is a move drag.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.m:
              (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because
              it's only the top level WebHTMLView that performs this operation.
              (-[WebHTMLView _setInitiatedDrag:]): Added.
              (-[WebHTMLView _initiatedDrag]): Ditto.
              (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag,
              not the top level view.
              (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform
              a move drag, so don't ASSERT _isTopHTMLView.
              (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag.
              (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
              * WebView/WebHTMLViewInternal.h: Added two private SPI so that
              the top level WebHTMLView can set and get the initiatedDrag BOOL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62fcd3a
    • rwlbuis's avatar
      Reviewed by eseidel. · 60fdd61e
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
              new marker code draws end-marker in wrong place
      
              Keep track of the start of the subpath so we can handle
              closeTo/moveTo correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60fdd61e
  12. 20 Sep, 2006 5 commits
    • eseidel's avatar
      2006-09-20 Julien Palmas <julien.palmas@gmail.com> · aed4ff51
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
      
              Test: svg/custom/pattern-y-offset.svg
      
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              (WebCore::KRenderingPaintServerPatternQuartz::setup):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed4ff51
    • justing's avatar
      LayoutTests: · e18e43a0
      justing authored
              Reviewed by harrison
      
              * editing/selection/editable-links.html: Added.
              * editing/selection/editable-links.html-disabled: Removed.
      
      WebCore:
      
              Reviewed by harrison
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
              HTMLElement::isContentEditable just to check the Frame's editability, since
              it calls updateRenderering, which can get us into infinite recursion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e18e43a0
    • aroben's avatar
      Reviewed by timothy. · 937c656d
      aroben authored
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
              Test results for fast/js/window-properties.html should include
              children of window.document.body.firstChild
      
              * fast/js/window-properties-expected.txt: Regenerate results which now
              include window.document.body.firstChild.*
              * fast/js/window-properties.html: Print out 'null' for null objects
              instead of 'object' for more clarity
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      937c656d
    • aroben's avatar
      WebCore: · 4268dc9f
      aroben authored
              Reviewed by Adele.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
              REGRESSION: file upload control with direction:rtl or text-align:right
              draws button on top of filename/icon
      
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::setStyle): Force text-align to
              match direction
              (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
              the filename and icon in RTL
      
      LayoutTests:
              Reviewed by Adele.
      
              Adding test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
              REGRESSION: file upload control with direction:rtl or text-align:right
              draws button on top of filename/icon
      
              * fast/forms/file-input-direction-expected.checksum: Added.
              * fast/forms/file-input-direction-expected.png: Added.
              * fast/forms/file-input-direction-expected.txt: Added.
              * fast/forms/file-input-direction.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4268dc9f
    • eseidel's avatar
      2006-09-20 Eric Seidel <eric@eseidel.com> · b8ca3ac8
      eseidel authored
              Reviewed by hyatt.
              
              Commit two test updates I forgot to commit with:
              Markers should clip to their viewport.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
      
              * svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
              * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
              * svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
              * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8ca3ac8
  13. 19 Sep, 2006 1 commit