- 05 Nov, 2006 2 commits
-
-
darin authored
- more preparation for splitting up Frame into sub-pieces - removed unnecessary includes from Frame.h * page/Frame.h: Removed unneeded includes and forward declarations. Added additional forward declarations. Removed the constant NoXPosForVerticalArrowNavigation, now moved inside SelectionController. Created sections of functions to be moved into Chrome, Editor, EventHandler, FrameLoader, SelectionController, and the Platform directory, as well as marking one function for deletion. * page/FramePrivate.h: Removed the definition of the constructor and destructor and removed unnecessary includes. * page/FrameView.h: Removed unneeded forward declarations and friend declarations. Created a section of functions and data to be moved into EventHandler. * bridge/mac/FrameMac.h: Removed unneeded forward declarations. Created sections of functions and data to be moved into Chrome, Editor, EventHandler, FrameLoader, and the Platform directory. * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment. Removed unused methods areScrollbarsVisible, nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:. * page/Frame.cpp: (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have to include KURL.h just for the KURL default constructor. (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h. (WebCore::FramePrivate::~FramePrivate): Ditto. * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf booleans, scrollbarMoved and cleared funcitons. (WebCore::FrameView::clear): Moved the code from the cleared function in here. (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated for changes to header. * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): Moved NoXPosForVerticalArrowNavigation into this file. * bindings/js/kjs_events.cpp: * bindings/js/kjs_html.cpp: * bindings/js/kjs_window.cpp: * bridge/mac/WebCoreAXObject.mm: * bridge/mac/WebCoreFrameBridge.mm: * css/cssstyleselector.cpp: * dom/Document.cpp: * dom/Element.cpp: * dom/EventTargetNode.cpp: * dom/MouseRelatedEvent.cpp: * dom/XMLTokenizer.cpp: * html/HTMLBaseElement.cpp: * html/HTMLDocument.cpp: * html/HTMLEmbedElement.cpp: * html/HTMLFrameElementBase.cpp: * html/HTMLGenericFormElement.cpp: * html/HTMLObjectElement.cpp: * html/HTMLTokenizer.cpp: * loader/mac/FrameLoaderMac.mm: * page/PageState.cpp: * rendering/RenderApplet.cpp: * rendering/RenderBlock.cpp: * rendering/RenderLayer.cpp: * rendering/RenderObject.cpp: * rendering/RenderPartObject.cpp: * rendering/RenderTreeAsText.cpp: * xml/XSLTProcessor.cpp: Added includes as needed to keep compiling, since there are fewer includes in Frame.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
http://bugs.webkit.org/show_bug.cgi?id=11402 REGRESSION: onChange does not work anymore for 1st item in popup * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::reset): Set m_lastOnChangeIndex to -1. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 04 Nov, 2006 12 commits
-
-
bdash authored
Reviewed by Tim H. Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521 Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open * Drosera/debugger.js: Use .// instead of // so that it doesn't root the search at the document. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Tim H. Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513 Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas. * Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Tim H. Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512 Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup. * Drosera/debugger.js: blur() the function popup when we're done with it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix http://bugs.webkit.org/show_bug.cgi?id=11453 REGRESSION: Status bar always shows cancelled opening the page * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel. Since the subresource owns the resource handle, there's no need to cancel. This arrangement is only temporary, anyway, since Maciej will soon change things so that the subresource loader uses the resource handle and the resource handle doesn't know anything about the subresource loader. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Maciej. - converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones converted most uses of NSURL to KURL and NSEvent to DOM Event in loader classes moved download function out of FrameLoader.h to avoid reference to NSURLConnection added DOM Event parameters to various functions so that the handlers can use the DOM Event instead of the global "current NSEvent"; includes Frame::submitForm, HTMLFormElement::prepareSubmit, HTMLFormElement::submit, FrameLoader::load moved the setMainFrame call that hands ownership to the Page into one of the Frame constructors, and removed it from all the clients removed const from Event parameter to the urlSelected function (we rarely use const with DOM elements) removed some redundant includes and declarations from various header files removed NSURL parameter from userAgent function -- if we need it we can add it back, but converting from NSURL to KURL and back is inefficient enough that it's best to have it out for now (since it's been unused for years) -- if we add it back, we can choose an appropriate parameter type that's always inexpensive to pass did some basic cleanup in the IconLoader class, including removing an unnecessary loop that added icon data a byte at a time renamed safeLoad to load, since it's no different from the other FrameLoader load functions, safety-wise fixed some code that was trying to distinguish null frame name from empty string frame name -- both should be handled the same, but callers were doing it by checking for empty and turning it into null (in a way that was causing extra round trips between NSString and WebCore::String) corrected all uses of "get" and "post" to be uppercase "GET" and "POST" and got rid of case-insensitive compares of methods * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): * bridge/mac/FrameViewMac.mm: * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]): * bridge/mac/WebCorePageBridge.h: * bridge/mac/WebCorePageBridge.mm: * bridge/mac/WebCoreSettings.mm: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): * bridge/win/FrameWin.h: * dom/MouseRelatedEvent.cpp: * dom/MouseRelatedEvent.h: * dom/UIEvent.cpp: (WebCore::UIEvent::~UIEvent): * dom/UIEvent.h: * dom/UIEventWithKeyState.h: * dom/XMLTokenizer.cpp: (WebCore::openFunc): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit): * html/HTMLFormElement.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): * loader/DocumentLoader.h: * loader/FrameLoader.h: * loader/FrameLoaderClient.h: * loader/NavigationAction.h: (WebCore::NavigationAction::event): * loader/icon/IconLoader.cpp: (WebCore::IconLoader::create): (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFinishLoading): * loader/icon/IconLoader.h: * loader/loader.cpp: * loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::URLForHistory): * loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously): * loader/mac/IconLoaderMac.mm: (WebCore::IconLoader::notifyIconChanged): * loader/mac/LoaderFunctionsMac.mm: * loader/mac/MainResourceLoaderMac.mm: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy): * loader/mac/NavigationActionMac.mm: (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction): * loader/mac/ResourceLoaderMac.mm: * loader/mac/SubresourceLoaderMac.mm: * page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::urlSelected): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::endIfNotLoading): (WebCore::Frame::hitTestResultAtPoint): * page/Frame.h: * page/FramePrivate.h: * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): * platform/gdk/FrameGdk.h: * platform/mac/TextFieldMac.mm: * platform/network/HTTPHeaderMap.h: * platform/network/ResourceHandle.h: * platform/network/ResourceHandleClient.h: * platform/network/ResourceHandleInternal.h: * platform/network/mac/ResourceHandleMac.mm: * platform/network/mac/ResourceResponseMac.h: * platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]): * platform/network/win/ResourceHandleWin.cpp: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): * platform/qt/FrameQt.h: * rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::returnPressed): * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): * xml/xmlhttprequest.cpp: WebKit: Reviewed by Maciej. - converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones store the computed user agent string as a WebCore::String instead of an NSString to avoid overhead converting it every time we get it * COM/WebFrame.cpp: (WebFrame::initWithName): * ChangeLog: * Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): (-[WebElementDictionary _targetWebFrame]): * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent): (WebFrameLoaderClient::actionDictionary): * WebCoreSupport/WebPageBridge.mm: (WebCore::if): * WebView/WebDataSource.mm: (-[WebDataSource _URL]): (-[WebDataSource _URLForHistory]): (-[WebDataSource unreachableURL]): * WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (-[WebPDFView _path]): * WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView _cachedResponseForURL:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView userAgentForURL:]): (-[WebView _computeUserAgent]): (-[WebView WebCore::]): * WebView/WebViewInternal.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Darin. Fix use of uninitialized value in pattern match. * Scripts/webkitdirs.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- replaced receivedRedirect with new willSendRequest delegate - removed most mac-specific loader functions - use ResourceResponse more in loader code * WebCore.xcodeproj/project.pbxproj: Add new files. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted for CachedResource method renames. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto. * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): simplified based on ResourceResponse * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): adapt for ResourceResponse * loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): store a ResourceResponse; platform response is now called platformResponse and expiration date is removed. (WebCore::CachedResource::~CachedResource): ditto (WebCore::CachedResource::isExpired): ditto * loader/CachedResource.h: (WebCore::CachedResource::platformResponse): ditto (WebCore::CachedResource::setResponse): ditto (WebCore::CachedResource::canDelete): ditto * loader/LoaderFunctions.h: * loader/loader.cpp: (WebCore::Loader::receivedResponse): Adjusted for renames. (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse in the CachedResource. * loader/loader.h: * loader/mac/FormDataStream.h: * loader/mac/FormDataStream.m: (WebCore::getStreamFormDatas): Rearranged things so it's possible to get a FormData back out of a form data stream. (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::httpBodyFromStream): ditto * loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): s/response/platformResponse/ * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): ditto (WebCore::CachedResource::setPlatformResponse): ditto * loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): send redirect to client appropriately * platform/network/ResourceHandle.h: * platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): new entry point for SubresourceLoader, dispatch to client. * platform/network/ResourceRequest.h: (WebCore::ResourceRequest::allowHTTPCookies): implemented (WebCore::ResourceRequest::setAllowHTTPCookies): ditto * platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): initialize expiration date(!) * platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): Added this, ported from NSURL version. (WebCore::openNextStream): ditto (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::formCanRead): ditto (WebCore::formEventCallback): ditto (WebCore::setHTTPBody): ditto (WebCore::httpBodyFromStream): ditto * platform/network/cf/FormDataStreamCFNet.h: Added. * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): implemented (WebCore::ResourceHandle::start): use new ResourceRequest stuff * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): do nothing for a null response * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client. * platform/network/mac/ResourceRequestMac.h: Added. * platform/network/mac/ResourceRequestMac.mm: Added. (WebCore::getResourceRequest): Added way to convert an NSURLRequest to a ResourceRequest. (WebCore::nsURLRequest): Opposite of the above. * platform/network/cf/ResourceRequestCFNet.h: Added. * platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): Added way to convert an CFURLRequest to a ResourceRequest. (WebCore::cfURLRequest): Opposite of the above. * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect, adjusted. * xml/xmlhttprequest.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix http://bugs.webkit.org/show_bug.cgi?id=11514 REGRESSION (r17438): Repro crash when opening a web archive * bridge/mac/WebCorePageState.mm: (-[WebCorePageState dealloc]): Add null check. (-[WebCorePageState finalize]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson). http://bugs.webkit.org/show_bug.cgi?id=11433 Fixes to get WebKit to run on Windows; implemented AffineTransformCairo. WebCore: * WebCore.vcproj/WebCore/WebCore.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths Created platform/graphics and platform/network filters in hierarchy Moved GraphicsContext and GraphicsTypes to their respective filters Added EditorClient.h Added FrameLoader* files in loader/ Added HitTest* files in rendering/ Added Editor.* files in editing/ Added DeleteButton.* and DeleteButtonController.* in editing/ * bridge/win/ChromeClientWin.h: Added. (WebCore::ChromeClientWin::~ChromeClientWin): * bridge/win/EditorClientWin.h: Added. (WebCore::EditorClientWin::~EditorClientWin): * bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow): * bridge/win/FrameWin.h: Added EditorClient parameter to constructor Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest() Removed openURL() and openURLRequest from class definition * bridge/win/PageWin.cpp: * platform/AffineTransform.h: * platform/cairo/AffineTransformCairo.cpp: Added. (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::m11): (WebCore::AffineTransform::m12): (WebCore::AffineTransform::m21): (WebCore::AffineTransform::m22): (WebCore::AffineTransform::dx): (WebCore::AffineTransform::dy): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::det): (WebCore::AffineTransform::invert): (WebCore::AffineTransform::operator cairo_matrix_t): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator*= ): (WebCore::AffineTransform::operator* ): * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): * platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel): * platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::goBackOrForward): (WebCore::FrameWin::getHistoryLength): (WebCore::FrameWin::historyURL): (WebCore::ServeSynchronousRequest): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::Path::transform): (WebCore::PopupMenu::updateFromElement): (WebCore::ResourceLoader::loadsBlocked): (WebCore::systemBeep): * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): WebKit: * COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::receivedAllData): Use resource handles now. Do not start doc loader by hand anymore. Handle didReceiveData() callback instead of receivedData() which is deprecated in implementation of ResourceHandleClient * COM/WebFrame.h: * COM/WebView.cpp: Applied ResourceLoader --> ResourceHandle renaming * WebKit.vcproj/WebKit.rc: Got rid of MFC dependencies (build fix for VCExpress). * WebKit.vcproj/WebKit.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
http://bugs.webkit.org/show_bug.cgi?id=11448 ⟨ and ⟩ entities are mapped to the incorrect Unicode codepoint WebCore: * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters. LayoutTests: * fast/parser/entities-in-xhtml-expected.checksum: Removed. * fast/parser/entities-in-xhtml-expected.png: Removed. Converted to plain text, the large table in the test didn't nearly fit anyway. * fast/parser/entities-in-xhtml-expected.txt: * fast/parser/entities-in-xhtml.xhtml: Made the test self-consistent again by using actual numeric values for ⟨ and ⟩. * fast/parser/entities-in-html-expected.txt: Added. * fast/parser/entities-in-html.html: Added. An HTML copy of the same test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 03 Nov, 2006 24 commits
-
-
bdash authored
Reviewed by Tim H. Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510 Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item. * Drosera/DebuggerApplication.m: (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Oliver. Update Windows and Qt project files for file removals in r17585. * CMakeLists.txt: * WebCore.vcproj/WebCore/WebCore.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Maciej. The patch fixes text field drawing on the Qt platform. * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField): Use the style to correctly render the text field git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken authored
Fix build * kjs/JSImmediate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver authored
Reviewed by Tim. Correct incorrect call to SetCursor * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Removed DeprecatedRenderSelect and ListBox classes. * WebCore.xcodeproj/project.pbxproj: * css/html4.css: * html/HTMLOptionElement.h: * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::updateListBoxSelection): * html/HTMLSelectElement.h: * platform/ListBox.h: Removed. * platform/mac/FontCacheMac.mm: * platform/mac/ListBoxMac.mm: Removed. * platform/win/TemporaryLinkStubs.cpp: * rendering/DeprecatedRenderSelect.cpp: Removed. * rendering/DeprecatedRenderSelect.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- rolled back more of the accidentall commit that I forgot. * platform/network/mac/ResourceRequestMac.h: Removed. * platform/network/mac/ResourceRequestMac.mm: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596 Bug 9596: [Drosera] add a function popup to the source pane * Drosera/debugger.css: Added styles for function popup * Drosera/debugger.html: Added function popup button and select * Drosera/debugger.js: Added function popup functionality git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- roll back some network changes accidentally committed with a previous patch. * WebCore.xcodeproj/project.pbxproj: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): * loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired): * loader/CachedResource.h: (WebCore::CachedResource::response): * loader/LoaderFunctions.h: * loader/loader.cpp: (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceivedResponse): * loader/loader.h: * loader/mac/FormDataStream.h: * loader/mac/FormDataStream.m: (WebCore::formCreate): (WebCore::formFinalize): * loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setResponse): * loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): * platform/network/ResourceHandle.h: * platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedRedirect): * platform/network/ResourceRequest.h: * platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::redirectedToURL): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedRedirect): * xml/xmlhttprequest.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Rubber-stamped by Oliver. Remove these, they have been merged with SVGRenderTreeAsText. * rendering/SVGRenderAsText.cpp: Removed. * rendering/SVGRenderAsText.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
http://bugs.webkit.org/show_bug.cgi?id=11504 Fix warnings on non 32 bit platforms * kjs/JSImmediate.h: (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits): Rewrite in a way that moves runtime checks to compile-time. (KJS::): (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Build fix. * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
* WebCoreSupport/WebChromeClient.h: Added. * WebCoreSupport/WebChromeClient.mm: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Reviewed by Darin, Beth. First cut at factoring Page's UIDelegate-related functions into Chrome and ChromeClient. Layout tests pass. * bridge/mac/PageMac.mm: Removed platform-specific constructor, added setBridge method to replace it. (WebCore::Page::setBridge): * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact that WebCorePageBridge.h doesn't need to be included by ObjC-only files, and, now that it uses PassRefPtr, can't be. * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm. * page/Page.h: (WebCore::Page::dragCaretController): Made this function non-const so that m_dragCaretController doesn't have to be mutable. WebKit: Reviewed by Darin, Beth. First cut at factoring Page's UIDelegate-related functions into Chrome and ChromeClient. Layout tests pass. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebPageBridge.mm: * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
Reviewed by Maciej. http://bugs.webkit.org/show_bug.cgi?id=9671 * Scripts/wkstyle: Adds astyle sed script formats according to most of the style guidelines. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
http://bugs.webkit.org/show_bug.cgi?id=7323 REGRESSION (10.4.4): ondrag* events don't fire on page in a frame WebCore: * bridge/mac/FrameMac.h: Moved drag source information to a static variable in FrameMac.mm. There can be only one drag active at any moment, and having this information here was making sharing this information between subframes hard. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo. (WebCore::FrameMac::freeClipboard): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::dragSourceMovedTo): (WebCore::FrameMac::dragSourceEndedAt): (WebCore::FrameMac::dispatchDragSrcEvent): Access drag source info via sharedDragInfo - this fixes drag source even dispatching. Also removed some old code that was forwarding mouse events to subviews to make HTML editing work in subframes. * page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): Forward events to subframes for dispatching - this fixes drag target events. WebKitTools: When dragging, do not send EventSendingController's events immediately. Dragging is supposed to be modal, so we need to perform it from within the delegate, without returning to JS to make the next mouse movement. When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent. * DumpRenderTree/EventSendingController.h: * DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (+[EventSendingController saveEvent:]): (+[EventSendingController replaySavedEvents]): * DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): LayoutTests: * fast/events/drag-in-frames-expected.txt: Added. * fast/events/drag-in-frames.html: Added. * fast/events/resources/drag-in-frames-console.html: Added. * fast/events/resources/drag-in-frames-left.html: Added. * fast/events/resources/drag-in-frames-right.html: Added. * editing/selection/expanding-selections.html: * editing/selection/expanding-selections2.html: * fast/dynamic/layer-hit-test-crash.html: * fast/events/event-view-toString.html: * fast/events/resources/drag-outside-window-frame.html: * svg/custom/hover-default-fill.svg: Added missing calls to mouseUp(). * svg/custom/stroke-width-click-expected.txt: * svg/custom/stroke-width-click.svg: Don't attempt to click outside the page, this was confusing DRT. * editing/selection/select-from-textfield-outwards-expected.txt: * editing/selection/select-from-textfield-outwards.html: Removed alerts between dragging steps - they are now useless, as the dragging events are stored and executed at once. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
Reviewed by Tim, landed by George. Fixing compile. * platform/qt/LoaderFunctionsQt.cpp: (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
others. Oops. * editing/inserting/before-after-input-element-expected.txt: * editing/inserting/before-after-input-element.html: * editing/pasteboard/4641033-expected.txt: * editing/pasteboard/input-field-1-expected.txt: * editing/pasteboard/input-field-1.html: * editing/pasteboard/select-element-1-expected.txt: * editing/pasteboard/select-element-1.html: * editing/selection/select-element-paragraph-boundary-expected.txt: * editing/selection/select-element-paragraph-boundary.html: * fast/forms/textarea-no-scroll-on-blur-expected.txt: * fast/forms/textarea-scrollbar-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
Reviewed by Maciej, landed by George. Moving the word/sentence seperators into a file of their own and implementing findWordBoundary. * CMakeLists.txt: * platform/qt/TemporaryLinkStubs.cpp: * platform/qt/TextBoundaries.cpp: Added. (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
Reviewed by Maciej, landed by George. Compile on both KDE and Qt platforms * CMakeLists.txt: add zlib explicitly * platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::self): (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): Integrate both implementations so that moc can parse it (WebCore::ResourceHandleManager::deliverJobData): (WebCore::ResourceHandleManager::remove): * platform/network/qt/ResourceHandleManager.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
Reviewed by Maciej. * collector.cpp: Remove a deprecated pthreads call. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fix a #if to be #ifdef * platform/graphics/svg/cg/SVGResourceImageCg.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Compile on the Qt platform. * ksvg2/misc/KCanvasRenderingStyle.h: * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
Adding setPlatformPen/setPlatformFont/setPlatformFillColor to graphics context to be able to set consistant state on the platform specific painter without having to change fill/stroke/font on every operation. This fixes color/stroke/fill and font handling in the Qt port. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformFont): * platform/graphics/GraphicsContext.h: * platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::penToQPen): (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): * platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent): * platform/qt/ScrollViewCanvasQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 02 Nov, 2006 2 commits
-
-
ggaren authored
Reviewed by Justin Garcia. Used a PERL script to add calls to opt into dumping of editing callbacks in all editing tests that didn't do so already. This is required now that dumping of editing callbacks is opt-in. Updated editing.js so that any test that calls runEditingTest() opt into dumping of editing callbacks. Updated results in all non-editing tests to remove dumping of editing callbacks. Updated results in all editing tests to reflect minor DOM changes due to new <script> elements. [ many tests and results modified ] WebKitTools: Reviewed by Justin Garcia. Made dumping of editing callbacks opt-in, so that editing spew doesn't cloud non-editing tests. * DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController shouldDumpEditingCallbacks]): (runTest): * DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
passed this test.) * fast/js/regexp-unicode-handling-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-