1. 22 Mar, 2013 40 commits
    • rniwa@webkit.org's avatar
      Build fix attempt after r146702. · 6444e4b5
      rniwa@webkit.org authored
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6444e4b5
    • cmuppala@apple.com's avatar
      Add runtime setting for hidden page DOM timer throttling and CSS animation suspension · a756fa61
      cmuppala@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112308
      
      Reviewed by Gavin Barraclough.
      
      Source/WebCore:
      
      No new tests.  Only adding settings to enable/disable existing features
      and hence existing tests suffice.
      
      * WebCore.exp.in:
      * page/Page.cpp:
      (WebCore::Page::setVisibilityState): Check if DOM timer throttling
      and CSS animation suspension are enabled before turning them on.
      (WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
      DOM timer throttling based on page visibility and the new setting state.
      (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
      for CSS animation suspension.
      * page/Page.h:
      * page/Settings.cpp:
      (WebCore::Settings::Settings): Initialize the flags for enabling hidden
      page DOM timer throttling and CSS animation suspension to false.
      (WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
      and notify page that the state of the setting has changed.
      (WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.
      * page/Settings.h:
      (WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
      (WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):
      
      Source/WebKit/mac:
      
      Add private preference for enabling/disabling hidden page DOM timer
      throttling and CSS animation suspension.  The preference should be
      disabled by default to avoid compatibility issues.
      
      * WebView/WebPreferenceKeysPrivate.h:
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      (-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
      (-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
      (-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
      (-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):
      * WebView/WebPreferencesPrivate.h:
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit2:
      
      Add private preference for enabling/disabling hidden page DOM timer
      throttling and CSS animation suspension.  The preference should be
      enabled by default only on Mac, where WebKit2 is a private API and
      hence compatibility is less of a issue.
      
      * Shared/WebPreferencesStore.h:
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
      (WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
      (WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
      (WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):
      * UIProcess/API/C/WKPreferencesPrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
      WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      
      LayoutTests:
      
      Hidden page DOM timer throttling is disabled by default in WebKit1 and
      in WebKit2 for platforms other than Mac.  Override the preference to
      enable it during the test.
      
      * fast/dom/timer-throttling-hidden-page.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a756fa61
    • cmuppala@apple.com's avatar
      Unreviewed. Move self from contributor to committer list. · 1962e61d
      cmuppala@apple.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1962e61d
    • benjamin@webkit.org's avatar
      Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal() · a85445da
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113003
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Fix two unfortunate use of StringHash and use the correct StringImpl function.
      
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::threadSafeEqual):
      * html/parser/HTMLTreeBuilderSimulator.cpp:
      (WebCore::tokenExitsSVG):
      
      Source/WTF: 
      
      StringHash::equal() and CaseFoldingHash::equal() were both testing for
      the nullity of the two input pointers. The catch is: neither traits handle
      null pointers, and any client code would have crashed on hash(), before equal()
      is called.
      Consequently, the two branches had a pass rate of zero when called from a HashMap code.
      
      The function is also never inlined because it is too big (the code of equal() for characters
      is always inlined, causing the function to be quite big).
      
      This patch introduces two new functions in the StringImpl API: equalNonNull() and
      equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
      but make the assumtion the input is never null.
      
      The functions are used for StringHash to avoid the useless branches.
      
      * wtf/text/StringHash.h:
      (WTF::StringHash::equal):
      (WTF::CaseFoldingHash::equal):
      * wtf/text/StringImpl.cpp:
      (WTF::stringImplContentEqual):
      (WTF::equal):
      (WTF::equalNonNull):
      (WTF::equalIgnoringCase):
      (WTF::equalIgnoringCaseNonNull):
      (WTF::equalIgnoringNullity):
      * wtf/text/StringImpl.h:
      (WTF::equalIgnoringCase):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a85445da
    • aestes@apple.com's avatar
      Set the cache partition property on CFURLRequests · 5d777128
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113116
      
      Patch by Jeffrey Pfau
      Reviewed by David Kilzer.
      
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      (WebCore::ResourceRequest::doUpdateResourceRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d777128
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 8b50206f
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      Adding bug numbers for two failing tests.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b50206f
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 22b7dc19
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      The rest.
      
      * platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
      * platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
      * platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
      * platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
      * platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
      * platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
      * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-linux/fast/box-shadow/inset-expected.png:
      * platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
      * platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
      * platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
      * platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
      * platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
      * platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
      * platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
      * platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
      * platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
      * platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
      * platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
      * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
      * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
      * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
      * platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
      * platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
      * platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
      * platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
      * platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
      * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
      * platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
      * platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
      * platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
      * platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
      * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
      * platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
      * platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
      * platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
      * platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
      * platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
      * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
      * platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
      * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-mac/fast/box-shadow/inset-expected.png:
      * platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
      * platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
      * platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
      * platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
      * platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
      * platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
      * platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
      * platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
      * platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
      * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
      * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
      * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
      * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
      * platform/chromium-win/fast/box-shadow/inset-expected.png:
      * platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
      * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
      * platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
      * platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
      * platform/chromium/TestExpectations:
      * platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
      * platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
      * platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
      * platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
      * platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
      * platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
      * platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
      * platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
      * platform/efl/fast/box-shadow/inset-expected.png: Removed.
      * platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22b7dc19
    • rniwa@webkit.org's avatar
      Another build fix (after r146693) for r146682. · 9af4c5c4
      rniwa@webkit.org authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9af4c5c4
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] content-sized row tracks with percentage logical height grid... · 5a559e8c
      jchaffraix@webkit.org authored
      [CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
      https://bugs.webkit.org/show_bug.cgi?id=113085
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      The core issue is that because overrideContainingBlockLogicalHeight() is unset in
      logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
      resolve percentage logical height against the grid element (wrong containing block
      as a grid item's containing block is the grid area).
      
      Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html
             fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::logicalContentHeightForChild):
      Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
      based on resolving (badly) its percentage.
      
      LayoutTests:
      
      * fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:
      Updated the result to pass.
      
      * fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
      * fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
      * fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
      * fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.
      Added more testing to ensure that we properly do the resolution.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a559e8c
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · d454ee2d
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      fast/canvas/...
      fast/css/...
      fast/forms/...
      fast/multicol/...
      
      * platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
      * platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
      * platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
      * platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
      * platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
      * platform/chromium-linux/fast/css/shadow-multiple-expected.png:
      * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
      * platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
      * platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
      * platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
      * platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
      * platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
      * platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
      * platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
      * platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
      * platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
      * platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
      * platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
      * platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
      * platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
      * platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
      * platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
      * platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
      * platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
      * platform/chromium-mac/fast/css/shadow-multiple-expected.png:
      * platform/chromium-mac/fast/dynamic/text-combine-expected.png:
      * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
      * platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
      * platform/chromium-mac/fast/multicol/nested-columns-expected.png:
      * platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
      * platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
      * platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
      * platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
      * platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
      * platform/chromium-win/fast/css/shadow-multiple-expected.png:
      * platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
      * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
      * platform/chromium/TestExpectations:
      * platform/efl-wk2/fast/multicol: Added.
      * platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
      * platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d454ee2d
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 04e215a6
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      fast/repaint/...
      fast/ruby/...
      
      * fast/repaint/moving-shadow-on-container-expected.png: Added.
      * fast/repaint/search-field-cancel-expected.txt: Added.
      * platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
      * platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
      * platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
      * platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
      * platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
      * platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
      * platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
      * platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
      * platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
      * platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
      * platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
      * platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
      * platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
      * platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
      * platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
      * platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
      * platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
      * platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
      * platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
      * platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
      * platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
      * platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
      * platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
      * platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
      * platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
      * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
      * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
      * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
      * platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
      * platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
      * platform/chromium-mac/fast/ruby/position-after-expected.png:
      * platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
      * platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
      * platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
      * platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
      * platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
      * platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
      * platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
      * platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
      * platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
      * platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
      * platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
      * platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
      * platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
      * platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
      * platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
      * platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
      * platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
      * platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
      * platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
      * platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
      * platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
      * platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
      * platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
      * platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04e215a6
    • zmo@google.com's avatar
      Check WEBGL_draw_buffers requirements before exposing the extension · 47e2473e
      zmo@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112359
      
      Reviewed by Kenneth Russell.
      
      * html/canvas/EXTDrawBuffers.cpp:
      (WebCore::EXTDrawBuffers::supported): call satisfies*().
      (WebCore::EXTDrawBuffers::drawBuffersEXT):
      (WebCore):
      (WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.
      * html/canvas/EXTDrawBuffers.h:
      (EXTDrawBuffers):
      * html/canvas/WebGLFramebuffer.cpp:
      (WebCore::WebGLFramebuffer::getDrawBuffer):
      (WebCore):
      * html/canvas/WebGLFramebuffer.h:
      (WebGLFramebuffer):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::initializeNewContext):
      (WebCore::WebGLRenderingContext::getExtension):
      (WebCore::WebGLRenderingContext::getParameter):
      (WebCore::WebGLRenderingContext::getSupportedExtensions):
      (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
      (WebCore::WebGLRenderingContext::getMaxDrawBuffers):
      (WebCore::WebGLRenderingContext::getMaxColorAttachments):
      (WebCore::WebGLRenderingContext::setBackDrawBuffer):
      (WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
      (WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
      (WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()
      * html/canvas/WebGLRenderingContext.h:
      (WebGLRenderingContext):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e2473e
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin build fix. · 6b86b24f
      roger_fong@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
      * JavaScriptCore.vcxproj/copy-files.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b86b24f
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 07214aa7
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      fast/text/...
      
      * platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
      * platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
      * platform/chromium-linux/fast/text/stroking-decorations-expected.png:
      * platform/chromium-linux/fast/text/stroking-expected.png:
      * platform/chromium-linux/fast/transforms/shadows-expected.png:
      * platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
      * platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
      * platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
      * platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
      * platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
      * platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
      * platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
      * platform/chromium-mac-lion/fast/text/stroking-expected.png:
      * platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
      * platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
      * platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
      * platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
      * platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
      * platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
      * platform/chromium-mac/fast/text/stroking-decorations-expected.png:
      * platform/chromium-mac/fast/text/stroking-expected.png:
      * platform/chromium-mac/fast/text/whitespace/024-expected.png:
      * platform/chromium-mac/fast/transforms/shadows-expected.png:
      * platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
      * platform/chromium-win-xp/fast/text/stroking-expected.png:
      * platform/chromium-win/fast/text/international/bold-bengali-expected.png:
      * platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
      * platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
      * platform/chromium-win/fast/text/stroking-decorations-expected.png:
      * platform/chromium-win/fast/text/stroking-expected.png:
      * platform/chromium-win/fast/transforms/shadows-expected.png:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
      * platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
      * platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
      * platform/qt-unknown/fast: Added.
      * platform/qt-unknown/fast/text: Added.
      * platform/qt-unknown/fast/text/international: Added.
      * platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
      * platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07214aa7
    • rniwa@webkit.org's avatar
      EWS should use a human readable port name when uploading layout test archives · add4ad5b
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113099
      
      Reviewed by Dirk Pranke.
      
      Use new port's object's name() method to report human readable port names.
      This will also help us resolving the bug to apply layout test results posted by EWS.
      
      * Scripts/webkitpy/tool/bot/botinfo.py:
      (BotInfo.__init__): Take port's name.
      (BotInfo.summary_text):
      
      * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
      (BotInfoTest.test_summary_text):
      
      * Scripts/webkitpy/tool/bot/flakytestreporter.py:
      (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
      
      * Scripts/webkitpy/tool/commands/queues.py:
      (PatchProcessingQueue.__init__): Initialize self._port.
      (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
      and use that for the attachment filename and the comment posted.
      
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
      "mac-snowleopard" as expected for TestPort.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      add4ad5b
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · db4b45d2
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      One I missed.
      
      * platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
      * platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db4b45d2
    • roger_fong@apple.com's avatar
      Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100. · f2461ee1
      roger_fong@apple.com authored
      Patch by Alexey Proskuryakov.
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2461ee1
    • mhahnenberg@apple.com's avatar
      -[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled · 01534124
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113054
      
      Reviewed by Geoffrey Garen.
      
      * API/tests/testapi.mm:
      (-[TinyDOMNode dealloc]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01534124
    • roger_fong@apple.com's avatar
      Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100. · 3b36fe6a
      roger_fong@apple.com authored
      Patch by Alexey Proskuryakov.
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b36fe6a
    • kov@webkit.org's avatar
      Trivial fixes to the gyp-build autogen.sh script. · 5cac1183
      kov@webkit.org authored
      Reviewed by Martin Robinson (mrobinson).
      
      * gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to
      run the script; deal with automake exiting with an error code because there is no
      Makefile.am for it to work on.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cac1183
    • timothy_horton@apple.com's avatar
      Plugin Snapshotting: Auto-start dominant plugins · 94abbec1
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113111
      <rdar://problem/13475726>
      
      Reviewed by Dean Jackson.
      
      Add a test for http://trac.webkit.org/changeset/146679.
      
      * platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
      * plugins/snapshotting/autoplay-dominant.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94abbec1
    • tony@chromium.org's avatar
      REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap · f2ff2f63
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113071
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
      In combination with r146272, this bug became more visible when nesting multiline flexboxen.
      
      Test: css3/flexbox/multiline-min-preferred-width.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
      flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
      preferred width.
      
      LayoutTests:
      
      * css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
      * css3/flexbox/multiline-min-preferred-width.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ff2f63
    • mvujovic@adobe.com's avatar
      [CSS Shaders] Clamp css_MixColor before the blending and compositing steps · 51b20f9b
      mvujovic@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113088
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      The blending and compositing operations from the spec [1] expect that they are operating on
      valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
      this range to avoid implementation-dependent behavior for invalid color inputs.
      
      [1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
      
      Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
             css3/filters/custom/custom-filter-clamp-css-mix-color.html
      
      * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
      (WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
          Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
          steps.
      
      LayoutTests:
      
      * css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
      * css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
      * css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
      * css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51b20f9b
    • mhahnenberg@apple.com's avatar
      opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData · ad21fd2f
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113086
      
      Reviewed by Geoffrey Garen.
      
      opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to 
      share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause 
      a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move 
      this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.
      
      * API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
      * API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.
      (OpaqueJSClass::contextData):
      * API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
      * API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts
      doesn't cause leaks of the original global object.
      (leakFinalize):
      (nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
      objects and keeping them alive, ruining the test result.
      (testLeakingPrototypesAcrossContexts):
      (main):
      * API/tests/testapi.mm: extern "C" this so we can continue using it here.
      * runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.
      (JSC::JSGlobalData::~JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that 
      clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
      (JSGlobalObject):
      (JSGlobalObjectRareData):
      (JSC::JSGlobalObject::opaqueJSClassData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad21fd2f
    • mrobinson@webkit.org's avatar
      [GTK] Add WebCoreDOM to the gyp build · 675e03dd
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112737
      
      Reviewed by Nico Weber.
      
      * WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      675e03dd
    • mrobinson@webkit.org's avatar
      [GTK] Add WebCoreHTML to the gyp build · c6b5f2df
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112727
      
      Reviewed by Nico Weber.
      
      * WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under
      the HTML directory. This includes splitting off common WebCore dependencies
      into an aggregate target and adding a top-level WebCore target.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6b5f2df
    • timothy_horton@apple.com's avatar
      Plugin Snapshotting: Auto-start dominant plugins · b33e5e04
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113111
      <rdar://problem/13475726>
      
      Reviewed by Dean Jackson.
      
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      Acknowledge the new "Restarting" DisplayState.
      * html/HTMLPlugInElement.h:
      Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
      Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
      Move the plugin to Restarting unless it's already marked as PendingMouseClick.
      (WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
      (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.
      * html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
      (WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
      (WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::didInitializePlugin):
      (WebKit::PluginView::paint):
      (WebKit::PluginView::invalidateRect):
      (WebKit::PluginView::isAcceleratedCompositingEnabled):
      Acknowledge the new "Restarting" DisplayState.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b33e5e04
    • pkasting@chromium.org's avatar
      [chromium] Mark test as expected to timeout. · 0bf551a3
      pkasting@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113114
      
      Unreviewed, test expectations update.
      
      * platform/chromium/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bf551a3
    • mrobinson@webkit.org's avatar
      [GTK] Add support for building the WebCore bindings to the gyp build · 4bf12a55
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112638
      
      Reviewed by Nico Weber.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct
      dependents and fix the indentation of the libjavascriptcore target.
      
      Source/WebCore:
      
      Add targets, actions, and rules for building the WebCore bindings. This is
      the first part of the WebCoreGTK build.
      
      * WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
      * WebCore.gyp/MakeNames.gypi: Added.
      * WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted
      from the Chromium build.
      * WebCore.gypi: Updated list of derived sources files and added a parameter
      for adjusting the location of the built files. We don't want to force the
      Mac build to change, but we'd still like to reuse the scripts that the
      Chromium build uses.
      
      Source/WebKit/gtk:
      
      * gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of
      the WebCore derived sources.
      * gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK
      gyp file the default for the build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf12a55
    • mrobinson@webkit.org's avatar
      [GTK] [gyp] Expose a few more compiler defines for the gyp build · 081a3897
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113109
      
      Reviewed by Gustavo Noronha Silva.
      
      * gyp/Configuration.gypi.in: Expose the version number string and data
      directory to the gyp build as command-line arguments.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      081a3897
    • mrobinson@webkit.org's avatar
      [GTK] [gyp] Feature defines are not space separated · 8f5a4aee
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113108
      
      Reviewed by Gustavo Noronha Silva.
      
      * gyp/configure.ac: Properly export feature defines for gyp during
      configure phase.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f5a4aee
    • commit-queue@webkit.org's avatar
      [BlackBerry] Build fix in InputHandler · 1488d2de
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113092
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1488d2de
    • jer.noble@apple.com's avatar
      After switching to another space and back, video races to catch up with audio · 051dc09b
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113006
      
      Reviewed by Anders Carlsson.
      
      Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
      a visibility update when that notification is observed.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView dealloc]): Unregister the observer.
      (-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
      (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051dc09b
    • commit-queue@webkit.org's avatar
      Add client callbacks to notify of changes of associated from controls · 8756e329
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110375
      
      Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
      Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
      are dynamically created, autofill can know to re-query the autofill server and keep going.
      https://bugs.webkit.org/show_bug.cgi?id=110375
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::didAssociateFormControl):
      (WebCore):
      (WebCore::Document::didAssociateFormControlsTimerFired):
      * dom/Document.h:
      (Document):
      added method didAssociateFormControl, which batches form changes
      and calls out to ChromeClient on a timer.
      * html/FormAssociatedElement.cpp:
      (WebCore::FormAssociatedElement::resetFormOwner):
      (WebCore::FormAssociatedElement::formAttributeChanged):
      (WebCore):
      * html/FormAssociatedElement.h:
      (FormAssociatedElement):
      add calls to Document::didAssociateFormControl when form changes
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::insertedInto):
      (WebCore):
      * html/HTMLFormElement.h:
      add call to Document::didAssociateFormControl
      * loader/EmptyClients.h:
      (EmptyChromeClient):
      (WebCore::EmptyChromeClient::didAssociateFormControls):
      (WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):
      * page/ChromeClient.h:
      (ChromeClient):
      add new method didAssociateFormControls
      
      Source/WebKit/chromium:
      
      Implement form association methods of ChromeClient
      to inform autofill of form changes after a page has loaded
      
      * public/WebAutofillClient.h:
      (WebAutofillClient):
      (WebKit::WebAutofillClient::didAssociateInput):
      (WebKit::WebAutofillClient::didAddForm):
      (WebKit::WebAutofillClient::didAssociateFormControls):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::didAssociateFormControls):
      (WebKit):
      (WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8756e329
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 9e72d68b
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      The next round.
      
      Too many files to list, plus ...
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e72d68b
    • fpizlo@apple.com's avatar
      Fix some minor issues in the DFG's profiling of heap accesses · c5c0fa4e
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113010
      
      Reviewed by Goeffrey Garen.
              
      1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.
      
      2) If a CodeBlock clears a structure stub during GC, it should record this, and
      the DFG should prefer to not inline that access (i.e. treat it as if it had an
      exit site).
      
      3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
      but it chose not to, then assume that it will take slow path.
      
      4) If we frequently exited because of a structure check on a weak constant,
      don't try to inline that access in the future.
      
      5) Treat all exits that were counted as being frequent.
              
      81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::finalizeUnconditionally):
      (JSC):
      (JSC::CodeBlock::resetStubDuringGCInternal):
      (JSC::CodeBlock::reoptimize):
      (JSC::CodeBlock::jettison):
      (JSC::ProgramCodeBlock::jettisonImpl):
      (JSC::EvalCodeBlock::jettisonImpl):
      (JSC::FunctionCodeBlock::jettisonImpl):
      (JSC::CodeBlock::tallyFrequentExitSites):
      * bytecode/CodeBlock.h:
      (CodeBlock):
      (JSC::CodeBlock::tallyFrequentExitSites):
      (ProgramCodeBlock):
      (EvalCodeBlock):
      (FunctionCodeBlock):
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeFor):
      * bytecode/PutByIdStatus.cpp:
      (JSC::PutByIdStatus::computeFor):
      * bytecode/StructureStubInfo.h:
      (JSC::StructureStubInfo::StructureStubInfo):
      (StructureStubInfo):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleGetById):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGOSRExit.cpp:
      (JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
      * dfg/DFGOSRExit.h:
      (JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
      (OSRExit):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * runtime/Options.h:
      (JSC):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5c0fa4e
    • benjamin@webkit.org's avatar
      Name correctly the argument of StringImpl::setIsAtomic() · ba3942d1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113000
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
      Reviewed by Geoffrey Garen.
      
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::setIsAtomic):
      The argument was probably an unfortunate copy-paste from setIsIdentifier().
      Fix the name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba3942d1
    • ap@apple.com's avatar
      Split ResourceHandleMac into multiple files · 6366a11b
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113100
      
              Reviewed by Geoff Garen.
      
              It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
              substantially more complicated yet.
      
              1. Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
              2. Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into
              separate files.
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/SynchronousLoaderClient.cpp: Added.
              * platform/network/SynchronousLoaderClient.h: Added.
              * platform/network/cf/ResourceHandleCFNet.cpp:
              * platform/network/mac/SynchronousLoaderClient.mm: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6366a11b
    • schenney@chromium.org's avatar
      [Chromium] Test expectation after Skia changes · 774064e3
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      SVG and Compositing tests
      
      Too many files to list, plus ...
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774064e3
    • rniwa@webkit.org's avatar