1. 07 Jun, 2008 11 commits
    • darin@apple.com's avatar
      WebCore: · 642f5008
      darin@apple.com authored
      2008-06-07  Darin Adler  <darin@apple.com>
      
              Reviewed by Mitz.
      
              - work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              (WebCore::toHTMLCanvasStyle):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
              * bindings/js/JSNodeFilterCondition.h:
              (WebCore::JSNodeFilterCondition::create):
              * bindings/js/JSNodeFilterCustom.cpp:
              (WebCore::toNodeFilter):
              * bindings/js/JSSVGLazyEventListener.h:
              (WebCore::JSSVGLazyEventListener::create):
              * bindings/js/JSSVGMatrixCustom.cpp:
              (WebCore::JSSVGMatrix::multiply):
              (WebCore::JSSVGMatrix::inverse):
              (WebCore::JSSVGMatrix::translate):
              (WebCore::JSSVGMatrix::scale):
              (WebCore::JSSVGMatrix::scaleNonUniform):
              (WebCore::JSSVGMatrix::rotate):
              (WebCore::JSSVGMatrix::rotateFromVector):
              (WebCore::JSSVGMatrix::flipX):
              (WebCore::JSSVGMatrix::flipY):
              (WebCore::JSSVGMatrix::skewX):
              (WebCore::JSSVGMatrix::skewY):
              * bindings/js/JSSVGPODTypeWrapper.h:
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
              (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
              (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::commonExit):
              (WebCore::commonExitReadOnly):
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::getItem):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::removeItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::getItem):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::removeItem):
              (WebCore::JSSVGTransformList::appendItem):
              * bindings/js/kjs_binding.cpp:
              (WebCore::setDOMException):
              * bindings/js/kjs_events.h:
              (WebCore::JSUnprotectedEventListener::create):
              (WebCore::JSEventListener::create):
              (WebCore::JSLazyEventListener::create):
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::createHTMLEventHandler):
              (WebCore::KJSProxy::createSVGEventHandler):
              * bindings/objc/DOM.mm:
              (WebCore::ObjCNodeFilterCondition::create):
              (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition):
              (WebCore::ObjCNodeFilterCondition::acceptNode):
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForNinePieceImage):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSFontFace.h:
              (WebCore::CSSFontFace::create):
              (WebCore::CSSFontFace::CSSFontFace):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::CSSParser::parseCounterContent):
              (WebCore::CSSParser::parseShape):
              (WebCore::BorderImageParseContext::commitBorderImage):
              * css/CSSSegmentedFontFace.cpp:
              (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
              * css/CSSSegmentedFontFace.h:
              (WebCore::CSSSegmentedFontFace::create):
              * css/Counter.h:
              (WebCore::Counter::create):
              (WebCore::Counter::Counter):
              * css/DashboardRegion.h:
              (WebCore::DashboardRegion::create):
              (WebCore::DashboardRegion::DashboardRegion):
              * css/Rect.h:
              (WebCore::Rect::create):
              (WebCore::Rect::Rect):
              * dom/ChildNodeList.h:
              (WebCore::ChildNodeList::create):
              * dom/ClassNodeList.h:
              (WebCore::ClassNodeList::create):
              * dom/Clipboard.h:
              * dom/DOMCoreException.h:
              (WebCore::DOMCoreException::create):
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::instance):
              * dom/DOMImplementation.h:
              (WebCore::DOMImplementation::DOMImplementation):
              * dom/Document.cpp:
              (WebCore::Document::addWindowEventListener):
              (WebCore::Document::removeWindowEventListener):
              (WebCore::Document::setDecoder):
              (WebCore::Document::images):
              (WebCore::Document::applets):
              (WebCore::Document::embeds):
              (WebCore::Document::plugins):
              (WebCore::Document::objects):
              (WebCore::Document::scripts):
              (WebCore::Document::links):
              (WebCore::Document::forms):
              (WebCore::Document::anchors):
              (WebCore::Document::all):
              (WebCore::Document::windowNamedItems):
              (WebCore::Document::documentNamedItems):
              * dom/Document.h:
              * dom/DynamicNodeList.h:
              * dom/EventException.h:
              (WebCore::EventException::create):
              (WebCore::EventException::EventException):
              * dom/EventListener.h:
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::addEventListener):
              (WebCore::EventTarget::removeEventListener):
              * dom/ExceptionBase.cpp:
              (WebCore::ExceptionBase::ExceptionBase):
              * dom/ExceptionBase.h:
              * dom/NameNodeList.h:
              (WebCore::NameNodeList::create):
              * dom/Node.cpp:
              (WebCore::Node::childNodes):
              (WebCore::Node::getElementsByTagNameNS):
              (WebCore::Node::getElementsByName):
              (WebCore::Node::getElementsByClassName):
              (WebCore::Node::querySelectorAll):
              * dom/NodeFilterCondition.h:
              * dom/NodeList.h:
              * dom/RangeException.h:
              (WebCore::RangeException::create):
              (WebCore::RangeException::RangeException):
              * dom/RegisteredEventListener.h:
              (WebCore::RegisteredEventListener::create):
              * dom/SelectorNodeList.cpp:
              (WebCore::createSelectorNodeList):
              * dom/SelectorNodeList.h:
              * dom/StaticNodeList.cpp:
              (WebCore::StaticNodeList::StaticNodeList):
              * dom/StaticNodeList.h:
              (WebCore::StaticNodeList::adopt):
              * dom/TagNodeList.h:
              (WebCore::TagNodeList::create):
              * history/HistoryItem.cpp:
              (WebCore::defaultNotifyHistoryItemChanged):
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::copy):
              * history/HistoryItem.h:
              (WebCore::HistoryItem::create):
              * html/CanvasGradient.h:
              * html/CanvasPattern.cpp:
              (WebCore::CanvasPattern::CanvasPattern):
              * html/CanvasPattern.h:
              (WebCore::CanvasPattern::create):
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
              (WebCore::CanvasRenderingContext2D::setStrokeColor):
              (WebCore::CanvasRenderingContext2D::setFillColor):
              (WebCore::CanvasRenderingContext2D::createPattern):
              * html/CanvasStyle.cpp:
              (WebCore::CanvasStyle::CanvasStyle):
              * html/CanvasStyle.h:
              (WebCore::CanvasStyle::create):
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::HTMLCollection):
              (WebCore::HTMLCollection::create):
              * html/HTMLCollection.h:
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::children):
              * html/HTMLFormCollection.cpp:
              (WebCore::HTMLFormCollection::create):
              * html/HTMLFormCollection.h:
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::elements):
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::areas):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::load):
              (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
              (WebCore::HTMLMediaElement::willSaveToCache):
              * html/HTMLNameCollection.h:
              (WebCore::HTMLNameCollection::create):
              * html/HTMLOptionsCollection.cpp:
              (WebCore::HTMLOptionsCollection::create):
              * html/HTMLOptionsCollection.h:
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::options):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::rows):
              (WebCore::HTMLTableElement::tBodies):
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::cells):
              * html/HTMLTableRowsCollection.cpp:
              (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
              (WebCore::HTMLTableRowsCollection::create):
              * html/HTMLTableRowsCollection.h:
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::rows):
              * html/MediaError.h:
              (WebCore::MediaError::create):
              (WebCore::MediaError::MediaError):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
              * loader/CachedFont.cpp:
              (WebCore::CachedFont::ensureSVGFontData):
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write):
              (WebCore::FrameLoader::createHistoryItem):
              * loader/ImageDocument.cpp:
              (WebCore::ImageEventListener::create):
              (WebCore::ImageEventListener::ImageEventListener):
              (WebCore::ImageDocument::createDocumentStructure):
              * loader/TextResourceDecoder.h:
              (WebCore::TextResourceDecoder::create):
              * page/Page.cpp:
              (WebCore::Page::userStyleSheet):
              * svg/SVGException.h:
              (WebCore::SVGException::create):
              (WebCore::SVGException::SVGException):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::ConditionEventListener::create):
              (WebCore::ConditionEventListener::ConditionEventListener):
              (WebCore::SVGSMILElement::connectConditions):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::didReceiveData):
              * xml/XMLHttpRequestException.h:
              (WebCore::XMLHttpRequestException::create):
              (WebCore::XMLHttpRequestException::XMLHttpRequestException):
              * xml/XPathException.h:
              (WebCore::XPathException::create):
              (WebCore::XPathException::XPathException):
              * xml/XPathResult.cpp:
              (WebCore::InvalidatingEventListener::create):
              (WebCore::InvalidatingEventListener::InvalidatingEventListener):
              (WebCore::XPathResult::XPathResult):
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::createDocumentFromSource):
      
      WebKit/mac:
      
      2008-06-07  Darin Adler  <darin@apple.com>
      
              Reviewed by Mitz.
      
              - work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * History/WebHistoryItem.mm:
              (-[WebHistoryItem init]):
              (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
              (-[WebHistoryItem initWithURL:target:parent:title:]):
              (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
              * WebView/WebView.mm:
              (+[WebView _decodeData:]):
      
      WebKit/win:
      
      2008-06-07  Darin Adler  <darin@apple.com>
      
              Reviewed by Mitz.
      
              - work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebHistoryItem.cpp:
              (WebHistoryItem::createInstance):
              (WebHistoryItem::initFromDictionaryRepresentation):
              (WebHistoryItem::initWithURLString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      642f5008
    • christian@webkit.org's avatar
      Remove PLATFORM ifdefs from ContextMenu.cpp · 42145091
      christian@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=17324
      
      Reviewed by Alp Toker.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42145091
    • eric@webkit.org's avatar
      Reviewed by ap. · e86c7fe5
      eric@webkit.org authored
              Still more CSSParser cleanup
              - use c++ style member initializers in CSSParser()
              - change m_styleElement to m_styleSheet and make it a CSSStyleSheet
              - finally add my copyright to the files I've been cleaning
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::setupParser):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseDeclaration):
              (WebCore::CSSParser::parseContent):
              (WebCore::CSSParser::parseFillImage):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::createCharsetRule):
              (WebCore::CSSParser::createImportRule):
              (WebCore::CSSParser::createMediaRule):
              (WebCore::CSSParser::createStyleRule):
              * css/CSSParser.h:
              * css/SVGCSSParser.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e86c7fe5
    • eric@webkit.org's avatar
      Reviewed by ap. · b657e623
      eric@webkit.org authored
              More CSSParser cleanup
              - rename CSSParser::id to m_id
              - rename CSSParser::data to m_data
              - fix a few whitespace and argument name issues
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::~CSSParser):
              (WebCore::CSSParser::setupParser):
              (WebCore::CSSParser::parseValue):
              * css/CSSParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b657e623
    • eric@webkit.org's avatar
      Reviewed by ap. · a882f1f2
      eric@webkit.org authored
              Rename CSSParser::strict to m_strict
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseBackgroundColor):
              (WebCore::CSSParser::parseFillPositionXY):
              (WebCore::CSSParser::parseFillSize):
              (WebCore::CSSParser::parseTransitionDuration):
              (WebCore::CSSParser::parseTransitionRepeatCount):
              (WebCore::CSSParser::parseTimingFunctionValue):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::CSSParser::parseShape):
              (WebCore::CSSParser::parseFont):
              (WebCore::CSSParser::parseColorFromValue):
              (WebCore::CSSParser::parseShadow):
              (WebCore::CSSParser::parseReflect):
              (WebCore::CSSParser::parseBorderImage):
              * css/CSSParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a882f1f2
    • eric@webkit.org's avatar
      Reviewed by ap. · 2490c877
      eric@webkit.org authored
              Rename CSSParser::defaultNamespace to m_defaultNamespace
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::parseSheet):
              * css/CSSParser.h:
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::addNamespace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2490c877
    • eric@webkit.org's avatar
      Reviewed by ap. · 8bbb16fe
      eric@webkit.org authored
              Rename CSSParser::important to m_important
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::CSSParser::parseFontFaceUnicodeRange):
              * css/CSSParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bbb16fe
    • eric@webkit.org's avatar
      Reviewed by ap. · 971c22fb
      eric@webkit.org authored
              Yet another cleanup patch for CSSParser
              Rename CSSParser::valueList to m_valueList
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::~CSSParser):
              (WebCore::CSSParser::checkForOrphanedUnits):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseTransitionShorthand):
              (WebCore::CSSParser::parseShorthand):
              (WebCore::CSSParser::parse4Values):
              (WebCore::CSSParser::parseContent):
              (WebCore::CSSParser::parseFillImage):
              (WebCore::CSSParser::parseFillPositionXY):
              (WebCore::CSSParser::parseFillPosition):
              (WebCore::CSSParser::parseFillSize):
              (WebCore::CSSParser::parseFillProperty):
              (WebCore::CSSParser::parseTransitionProperty):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::CSSParser::parseShape):
              (WebCore::CSSParser::parseFont):
              (WebCore::CSSParser::parseFontFamily):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::CSSParser::parseFontFaceUnicodeRange):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseShadow):
              (WebCore::CSSParser::parseReflect):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::parseCounter):
              (WebCore::CSSParser::parseGradient):
              (WebCore::CSSParser::parseCanvas):
              (WebCore::CSSParser::parseTransform):
              (WebCore::CSSParser::parseTransformOrigin):
              * css/CSSParser.h:
              * css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGValue):
              (WebCore::CSSParser::parseSVGStrokeDasharray):
              (WebCore::CSSParser::parseSVGPaint):
              (WebCore::CSSParser::parseSVGColor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      971c22fb
    • eric@webkit.org's avatar
      Reviewed by ap. · 13215bf9
      eric@webkit.org authored
              More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
              Remove CSSParser::current and CSSParser::currentParser and use
              the magic of YYLEX_PARAM instead.
      
              * css/CSSParser.cpp:
              (WebCore::enterGeneratedParser):
              (WebCore::CSSParser::parseSheet):
              (WebCore::CSSParser::parseRule):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseDeclaration):
              (WebCore::CSSParser::parseMediaQuery):
              * css/CSSParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13215bf9
    • jchaffraix@webkit.org's avatar
      WebCore: · 89e71206
      jchaffraix@webkit.org authored
      2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>
      
              Reviewed by Eric.
      
              Part of bug 19200: *.in files should embed more information
              https://bugs.webkit.org/show_bug.cgi?id=19200
      
              - Added XML attributes' parsing.
      
              - Moved (most) capitalization and audio hacks in the *.in files.
      
              * dom/make_names.pl:
              * html/HTMLTagNames.in:
              * svg/svgtags.in:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e71206
    • mitz@apple.com's avatar
      2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk> · fd500120
      mitz@apple.com authored
              With the help of Jonathon Jongsma.
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
              REGRESSION (r32660): Text not redrawn correctly when selection changes
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paint):
              Add a condition for when ePos <= sPos 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd500120
  2. 06 Jun, 2008 8 commits
    • jchaffraix@webkit.org's avatar
      WebCore: · e437cead
      jchaffraix@webkit.org authored
      2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>
      
              Reviewed by Eric.
      
              Part of bug 19200: *.in files should embed more information
              https://bugs.webkit.org/show_bug.cgi?id=19200
      
              - Switched *.in files to XML format.
      
              - Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.
      
              - Updated the build systems to include bindings/scripts when executing make_names.pl
              (for XMLTiny dependency).
      
              - Cleaned-up make_names.pl a little.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * bindings/scripts/XMLTiny.pm: Added.
              * dom/make_names.pl:
              * html/HTMLAttributeNames.in:
              * html/HTMLTagNames.in:
              * svg/svgattrs.in:
              * svg/svgtags.in:
              * svg/xlinkattrs.in:
              * xml/xmlattrs.in:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e437cead
    • mrowe@apple.com's avatar
      2008-06-06 Robert Blaut <webkit@blaut.biz> · cf202254
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
              CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing
      
              Test: fast/css/begin-end-contain-selector-empty-value.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      
      2008-06-06  Robert Blaut  <webkit@blaut.biz>
      
              Reviewed by Darin Adler.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=19407
              CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing.
      
              * fast/css/begin-end-contain-selector-empty-value.html: Added.
              * platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf202254
    • eric@webkit.org's avatar
      Reviewed by mitz. · 99261675
      eric@webkit.org authored
              More cleanup of CSSParser.
              Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseDeclaration):
              (WebCore::CSSParser::addProperty):
              (WebCore::CSSParser::rollbackLastProperties):
              (WebCore::CSSParser::clearProperties):
              (WebCore::CSSParser::parse4Values):
              (WebCore::CSSParser::createStyleRule):
              (WebCore::CSSParser::createFontFaceRule):
              * css/CSSParser.h:
              * css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99261675
    • eric@webkit.org's avatar
      Reviewed by mitz. · f5a04ffe
      eric@webkit.org authored
              More cleanup of CSSParser.
              Rename CSSParser::parsedProperties to m_parsedProperties.
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::~CSSParser):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseDeclaration):
              (WebCore::CSSParser::addProperty):
              (WebCore::CSSParser::rollbackLastProperties):
              (WebCore::CSSParser::clearProperties):
              (WebCore::CSSParser::parse4Values):
              (WebCore::CSSParser::createStyleRule):
              (WebCore::CSSParser::createFontFaceRule):
              * css/CSSParser.h:
              * css/SVGCSSParser.cpp:
              (WebCore::CSSParser::parseSVGValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5a04ffe
    • eric@webkit.org's avatar
      Reviewed by mitz. · 843813e5
      eric@webkit.org authored
              Start the cleanup of CSSParser.
              Rename CSSParser::styleElement to CSSParser::m_styleElement
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::document):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseContent):
              (WebCore::CSSParser::parseFillImage):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::createCharsetRule):
              (WebCore::CSSParser::createImportRule):
              (WebCore::CSSParser::createMediaRule):
              (WebCore::CSSParser::createStyleRule):
              * css/CSSParser.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      843813e5
    • eric@webkit.org's avatar
      Reviewed by adele. Landed by eseidel. · 3fc6a763
      eric@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=18337
      
              Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::typeAheadFind):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fc6a763
    • justin.garcia@apple.com's avatar
      WebCore: · b3f93a16
      justin.garcia@apple.com authored
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
      
              <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
              
              Serialization of font-family:-webkit-monospace when it came from a 
              CSSMutableStyleDeclaration would wrap the value in single quotes but 
              serialization of the same property value pair from a CSSComputedStyleDeclaration 
              wouldn't, which kept code that checked for and removed non-redundant styles from 
              style spans from working correctly.
      
              A redundant style left on a style span would not normally create a rendering 
              difference, but it did in this case because an element with 
              font-family:-webkit-monospace does not appear to inherit font-size.  
              Added a FIXME about how we might need to keep font-size on a style span if its 
              non-redundant styles include font-family:-webkit-monospace, although I couldn't 
              create a test case to produce this scenario.
      
              * css/FontFamilyValue.cpp:
              (WebCore::isValidCSSIdentifier): Don't return false if the String starts
              with a '-'.  This function now appears identical to isCSSTokenizerIdentifier,
              so perhaps we should use a single function.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME.  Removed the
              creation of two Strings that were never used.
      
      LayoutTests:
      
      2008-06-06  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
      
              <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
              
              * editing/deleting/5890684-expected.txt: Added.
              * editing/deleting/5890684.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3f93a16
    • justin.garcia@apple.com's avatar
      WebCore: · 84069e78
      justin.garcia@apple.com authored
      2008-06-06  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=19087>
              Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle
              can destroy insertedPlaceholder if it needs to move it, but it will set an
              endingSelection() at [movedPlaceholder, 0] if it does so.  Re-fetch insertedPlaceholder
              if that happens.  The long term solution for these crashes is to make moveParagraphs
              not copy/destroy/move content, and to make VisiblePositions update themselves on DOM 
              mutations.
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this
              in the future, but ASSERT to catch them in debug builds.
      
      LayoutTests:
      
      2008-06-06  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=19087>
              Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode
              
              * editing/execCommand/19087-expected.txt: Added.
              * editing/execCommand/19087.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84069e78
  3. 05 Jun, 2008 12 commits
    • justin.garcia@apple.com's avatar
      WebCore: · fb7e9f83
      justin.garcia@apple.com authored
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric.
      
              <https://bugs.webkit.org/show_bug.cgi?id=19403>
              ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call
      
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): If the selection was all
              formatting (like an empty list) the format-less text will be empty.
              Early return to avoid the ASSERT that fires if input(...) is called
              with an empty String.
      
      LayoutTests:
      
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric.
              
              <https://bugs.webkit.org/show_bug.cgi?id=19403>
              ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call
              
              * editing/execCommand/19403-expected.txt: Added.
              * editing/execCommand/19403.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb7e9f83
    • alp@webkit.org's avatar
      2008-06-05 Alp Toker <alp@nuanti.com> · 72587f8c
      alp@webkit.org authored
              Build fix for r34387.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72587f8c
    • justin.garcia@apple.com's avatar
      WebCore: · 36f15aff
      justin.garcia@apple.com authored
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric.
      
              <https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints
              
              ApplyStyleCommand::applyInlineStyle does some work and then checks to see
              if the start offset of the Range it's operating on is now past the caretMaxOffset
              of the start container.  If it is, applyInlineStyle updates the position to 
              [startContainer->traverseNextNode(), 0] and then operates on that new start
              position.
              
              caretMaxOffset was incorrect for horizontal rules.  It should be 1 and it was 0.  So,
              if the horizontal rule was the last node in the document, applyInlineStyle would update
              its start position to [0, 0] and then try to operate on that position, assuming it was
              non-null, leading to the ASSERT.
              
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::caretMaxOffset):
      
      LayoutTests:
      
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric.
              
              <https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints
      
              * editing/execCommand/19089-expected.txt: Added.
              * editing/execCommand/19089.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36f15aff
    • cfleizach@apple.com's avatar
      <rdar://problem/5947396> AccessibilityListBoxOptions should return their... · 36e38684
      cfleizach@apple.com authored
      <rdar://problem/5947396> AccessibilityListBoxOptions should return their string as AXValue, not AXTitle
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36e38684
    • justin.garcia@apple.com's avatar
      WebCore: · d66addb7
      justin.garcia@apple.com authored
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Harrison.
      
              <rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice
              <rdar://problem/5831310> CrashTracer: [USER] 4 crashes in Mail at WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion
              <rdar://problem/5480141> GoogleDocs: Attempting to indent content in <td> closes <table> element
              
              A crash would occur when indenting a selection that started just before a table
              and ended inside that table.  With a selection like this, we'd indent the entire
              table, then try and indent paragraphs inside it, but the stored position for the
              next paragraph to indent was inside content that had been removed from the document 
              during the first Indent.
              
              Fixed the crash adjusting the selection to perform the indent on to prepare it
              for paragraph iteration using selectionForParagraphIteration.  We do this adjustment
              for paragraph iteration in InsertList as well.
              
              Also, indenting paragraphs inside table cells would break table structure because 
              we were splitting the DOM all the way up to the root editable element to insert
              a blockquote.  Fixed this by only splitting up to the enclosing table cell.  This 
              matches FF.  Lastly, fixed a bug where indenting several paragraphs inside different 
              table cells would move all the selected text into the same table cell. FF still has 
              this bug.
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
      
      LayoutTests:
      
      2008-06-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Harrison.
              
              <rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice
      
              * editing/execCommand/5658933-1-expected.txt: Added.
              * editing/execCommand/5658933-1.html: Added.
              * editing/execCommand/5658933-2-expected.txt: Added.
              * editing/execCommand/5658933-2.html: Added.
              * editing/execCommand/5658933-3-expected.txt: Added.
              * editing/execCommand/5658933-3.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d66addb7
    • cfleizach@apple.com's avatar
      <rdar://problem/5979998> AXList controls should have AXSelectedChildren and... · 39027b70
      cfleizach@apple.com authored
      <rdar://problem/5979998> AXList controls should have AXSelectedChildren and its children's AXSelected attribute writable
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39027b70
    • eric@webkit.org's avatar
      Reviewed by mjs. · 63057039
      eric@webkit.org authored
              Get rid of Uninitialized Memory Reads (UMRs) in the XPath::Value copy constructor.
      
              No functional changes, thus no tests.
      
              * xml/XPathValue.h:
              (WebCore::XPath::Value::Value): initialize all values in each constructor
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63057039
    • hyatt@apple.com's avatar
      2008-06-04 David Hyatt <hyatt@apple.com> · 84d4e8ea
      hyatt@apple.com authored
              Fix for <rdar://problem/5957994> Height doesn't animate
      
              Improve the behavior when transitions are dynamically changed.  Make sure to leave older transitions
              running and let them obsolete themselves when they finish.
      
              Reviewed by Dan Bernstein
      
              Added WebCore/manual-tests/transitions2.html (must be tested manually)
      
              * manual-tests/transitions.html:
              * manual-tests/transitions2.html: Added.
              * page/AnimationController.cpp:
              (WebCore::ImplicitAnimation::property):
              (WebCore::ImplicitAnimation::setFinished):
              (WebCore::ImplicitAnimation::markedForDeath):
              (WebCore::ImplicitAnimation::setMarkedForDeath):
              (WebCore::ImplicitAnimation::ImplicitAnimation):
              (WebCore::ImplicitAnimation::reset):
              (WebCore::ImplicitAnimation::animate):
              (WebCore::CompositeImplicitAnimation::animate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84d4e8ea
    • eric@webkit.org's avatar
      Reviewed by hyatt. · 5472313a
      eric@webkit.org authored
              No functional changes, thus no tests.
      
              * platform/graphics/Color.h: remove unnecessary bitfield use
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5472313a
    • antti@apple.com's avatar
      WebCore: · 75a2b2a1
      antti@apple.com authored
      2008-06-05  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
              
              Make hasFeature() return true for the animation stuff.
      
              * dom/DOMImplementation.cpp:
              (WebCore::isSVG11Feature):
      
      LayoutTests:
      
      2008-06-05  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
              
              Make hasFeature() return true for the animation stuff.
      
              * svg/custom/svg-features-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75a2b2a1
    • mitz@apple.com's avatar
      WebCore: · f248058d
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19397
                REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius
      
              Test: fast/transforms/shadows.html
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setPlatformShadow): In Core Graphics, shadow
              dimensions are always in device space. Account for that, and apply the
              current context transform to shadow offset, and multiply the blur radius
              by the inverse of the operator norm of the inverse transform (which is
              the radius of the circle inscribed in the transformed unit circle). 
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintBoxShadow): Added 1px separation between
              the edge of the filled shape and the edge of the clipped-out shape,
              because in a transformed context, due to antialiasing, the fill can
              bleed into the clip if they touch.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19397
                REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius
      
              * fast/transforms/shadows.html: Added.
              * platform/mac/fast/transforms/shadows-expected.checksum: Added.
              * platform/mac/fast/transforms/shadows-expected.png: Added.
              * platform/mac/fast/transforms/shadows-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f248058d
    • hausmann@webkit.org's avatar
      2008-06-05 Tor Arne Vestbø <tavestbo@trolltech.com> · f8b7d674
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              Prevent cycles when converting from DOM objects to
              QVariant, due to cycles in the DOM tree.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8b7d674
  4. 04 Jun, 2008 8 commits
    • andersca@apple.com's avatar
      2008-06-04 Anders Carlsson <andersca@apple.com> · a1a4577e
      andersca@apple.com authored
              Reviewed by Mitz.
      
              Get rid of DeprecatedPtrList from StyleSheetList.
              
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              * css/StyleSheetList.cpp:
              (WebCore::StyleSheetList::~StyleSheetList):
              (WebCore::StyleSheetList::length):
              (WebCore::StyleSheetList::item):
              * css/StyleSheetList.h:
              (WebCore::StyleSheetList::swap):
              * dom/Document.cpp:
              (WebCore::Document::recalcStyleSelector):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a4577e
    • andersca@apple.com's avatar
      2008-06-04 Anders Carlsson <andersca@apple.com> · 3f7f4bc1
      andersca@apple.com authored
              Reviewed by Darin.
      
              Convert more classes over to start out with a ref count of 1.
              
              * css/CSSImageGeneratorValue.cpp:
              (WebCore::CSSImageGeneratorValue::generatedImage):
              * css/CSSImageValue.cpp:
              (WebCore::CSSImageValue::cachedImage):
              * css/CSSMediaRule.cpp:
              (WebCore::CSSMediaRule::CSSMediaRule):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFillSize):
              (WebCore::CSSParser::parseCounter):
              (WebCore::CSSParser::createRuleList):
              * css/CSSRuleList.cpp:
              (WebCore::CSSRuleList::CSSRuleList):
              * css/CSSRuleList.h:
              (WebCore::CSSRuleList::create):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::matchRules):
              (WebCore::CSSStyleSelector::styleRulesForElement):
              * css/CSSStyleSelector.h:
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::cssRules):
              (WebCore::CSSStyleSheet::addSubresourceURLStrings):
              * css/CSSStyleSheet.h:
              (WebCore::CSSStyleSheet::rules):
              * css/Pair.h:
              (WebCore::Pair::create):
              (WebCore::Pair::Pair):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::buffered):
              (WebCore::HTMLMediaElement::played):
              (WebCore::HTMLMediaElement::seekable):
              * html/TimeRanges.cpp:
              (TimeRanges::TimeRanges):
              * html/TimeRanges.h:
              (WebCore::TimeRanges::create):
              (WebCore::TimeRanges::TimeRanges):
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::addCursor):
              (WebCore::RenderStyle::clearCursorList):
              * rendering/style/RenderStyle.h:
              (WebCore::StyleImage::~StyleImage):
              (WebCore::StyleImage::StyleImage):
              (WebCore::StyleCachedImage::create):
              (WebCore::StyleCachedImage::StyleCachedImage):
              (WebCore::StyleGeneratedImage::create):
              (WebCore::StyleGeneratedImage::StyleGeneratedImage):
              (WebCore::CursorList::create):
              (WebCore::CursorList::CursorList):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f7f4bc1
    • cfleizach@apple.com's avatar
    • bdakin@apple.com's avatar
      2008-06-03 Beth Dakin <bdakin@apple.com> · 5e581f42
      bdakin@apple.com authored
              Reviewed by Adele.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit 
              Crashing Constantly on Gmail with accessibility turned on
      
              There was a missing null-check!
      
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::roleValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e581f42
    • andersca@apple.com's avatar
      2008-06-04 Anders Carlsson <andersca@apple.com> · 0f509b13
      andersca@apple.com authored
              Reviewed by Sam.
      
              Convert more classes to start with a ref count of 1.
              
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::toVoidCallback):
              * bindings/js/JSCustomVoidCallback.h:
              (WebCore::JSCustomVoidCallback::create):
              * css/StyleSheetList.cpp:
              (WebCore::StyleSheetList::StyleSheetList):
              * css/StyleSheetList.h:
              (WebCore::StyleSheetList::create):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::createNodeIterator):
              (WebCore::Document::createTreeWalker):
              * dom/NodeIterator.h:
              (WebCore::NodeIterator::create):
              * dom/Traversal.cpp:
              (WebCore::Traversal::Traversal):
              * dom/Traversal.h:
              * dom/TreeWalker.h:
              (WebCore::TreeWalker::create):
              * history/CachedPage.cpp:
              (WebCore::CachedPage::create):
              (WebCore::CachedPage::CachedPage):
              * html/CanvasGradient.cpp:
              (WebCore::CanvasGradient::CanvasGradient):
              * html/CanvasGradient.h:
              (WebCore::CanvasGradient::create):
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
              (WebCore::CanvasRenderingContext2D::createLinearGradient):
              (WebCore::CanvasRenderingContext2D::createRadialGradient):
              * html/CanvasRenderingContext2D.h:
              (WebCore::CanvasRenderingContext2D::create):
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::getContext):
              * html/VoidCallback.h:
              (WebCore::VoidCallback::VoidCallback):
              * loader/FormState.cpp:
              (WebCore::FormState::create):
              (WebCore::FormState::FormState):
              * platform/text/RegularExpression.cpp:
              (WebCore::RegularExpression::Private::create):
              (WebCore::RegularExpression::Private::Private):
              (WebCore::RegularExpression::RegularExpression):
              * storage/SQLResultSet.cpp:
              (WebCore::SQLResultSet::SQLResultSet):
              * storage/SQLResultSetRowList.h:
              (WebCore::SQLResultSetRowList::create):
              (WebCore::SQLResultSetRowList::SQLResultSetRowList):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f509b13
    • mitz@apple.com's avatar
      WebCore: · c80c3a7f
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()
      
              Test: fast/multicol/gap-non-negative.html
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Changed to not allow negative
              values for column-gap, per
              <http://www.w3.org/TR/2001/WD-css3-multicol-20010118/#column-gap>.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()
      
              * fast/multicol/gap-non-negative-expected.txt: Added.
              * fast/multicol/gap-non-negative.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c80c3a7f
    • mitz@apple.com's avatar
      WebCore: · 2aedb30f
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()
      
              Test: fast/reflections/table-cell.html
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::computeAbsoluteRepaintRect): Null-check
              parent().
              (WebCore::RenderTableCell::absolutePosition): Ditto.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()
      
              * fast/reflections/table-cell.html: Added.
              * platform/mac/fast/reflections/table-cell-expected.checksum: Added.
              * platform/mac/fast/reflections/table-cell-expected.png: Added.
              * platform/mac/fast/reflections/table-cell-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2aedb30f
    • ap@webkit.org's avatar
      Reviewed by Darin. · faaccdb1
      ap@webkit.org authored
              Fix JSClassCreate to work with old JSCore API threading model.
      
              No change on SunSpider.
      
              * API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Since JSClass is constructed without
              a context, there is no way for it to create Identifiers.
              Also, added initializeThreading(), just for good measure.
      
              * API/JSCallbackObjectFunctions.h: (KJS::::getPropertyNames): Make an Identifier out of the
              string here, because propertyNames.add() needs that.
      
              * kjs/identifier.cpp:
              * kjs/identifier.h:
              (KJS::Identifier::equal):
              * kjs/ustring.cpp:
              (KJS::equal):
              Moved equal() from identifier.h to ustring.h, because it's not really about Identifiers,
              and to make it possible to use it from StrHash.
              Include StrHash.h from ustring.h to avoid having the behavior depend on headers that happen
              to be included.
      
              * wtf/StrHash.h: Removed.
              * kjs/ustring.h: Made RefPtr<UString::Rep> use the same default hash as UString::Rep* (it
              used to default to pointer equality). Moved the whole StrHash header into ustring.h.
      
              * JavaScriptCore.exp: Export equal() for WebCore use (this StrHash is used in c_class.cpp,
              jni_class.cpp, and npruntime.cpp).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faaccdb1
  5. 03 Jun, 2008 1 commit
    • antti@apple.com's avatar
      WebCore: · ead3df6e
      antti@apple.com authored
      2008-06-03  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Darin.
              
              https://bugs.webkit.org/show_bug.cgi?id=19384
              Implement path morphing for SVG animation
              
              You can animate smoothly between paths that have equal number of control points of matching type.
      
              Test: svg/custom/animate-path-morphing.svg
      
              * svg/SVGAnimateElement.cpp:
              (WebCore::SVGAnimateElement::determinePropertyType):
              (WebCore::SVGAnimateElement::calculateAnimatedValue):
              (WebCore::SVGAnimateElement::calculateFromAndToValues):
              (WebCore::SVGAnimateElement::resetToBaseValue):
              (WebCore::SVGAnimateElement::applyResultsToTarget):
              * svg/SVGAnimateElement.h:
              (WebCore::SVGAnimateElement::):
              * svg/SVGPathSegList.cpp:
              (WebCore::blendFunc):
              (WebCore::SVGPathSegList::createAnimated):
              * svg/SVGPathSegList.h:
      
      LayoutTests:
      
      2008-06-03  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Darin.
              
              https://bugs.webkit.org/show_bug.cgi?id=19384
              
              Test for path morphing.
      
              * platform/mac/svg/custom/animate-path-morphing-expected.txt: Added.
              * svg/custom/animate-path-morphing.svg: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ead3df6e