GitLab

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        * bindings/js/JSNodeFilterCondition.h:
        (WebCore::JSNodeFilterCondition::create):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSSVGLazyEventListener.h:
        (WebCore::JSSVGLazyEventListener::create):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        (WebCore::JSSVGMatrix::inverse):
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::flipX):
        (WebCore::JSSVGMatrix::flipY):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
        (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
        (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::commonExit):
        (WebCore::commonExitReadOnly):
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/js/kjs_binding.cpp:
        (WebCore::setDOMException):
        * bindings/js/kjs_events.h:
        (WebCore::JSUnprotectedEventListener::create):
        (WebCore::JSEventListener::create):
        (WebCore::JSLazyEventListener::create):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::createHTMLEventHandler):
        (WebCore::KJSProxy::createSVGEventHandler):
        * bindings/objc/DOM.mm:
        (WebCore::ObjCNodeFilterCondition::create):
        (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition):
        (WebCore::ObjCNodeFilterCondition::acceptNode):
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForNinePieceImage):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::create):
        (WebCore::CSSFontFace::CSSFontFace):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::BorderImageParseContext::commitBorderImage):
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
        * css/CSSSegmentedFontFace.h:
        (WebCore::CSSSegmentedFontFace::create):
        * css/Counter.h:
        (WebCore::Counter::create):
        (WebCore::Counter::Counter):
        * css/DashboardRegion.h:
        (WebCore::DashboardRegion::create):
        (WebCore::DashboardRegion::DashboardRegion):
        * css/Rect.h:
        (WebCore::Rect::create):
        (WebCore::Rect::Rect):
        * dom/ChildNodeList.h:
        (WebCore::ChildNodeList::create):
        * dom/ClassNodeList.h:
        (WebCore::ClassNodeList::create):
        * dom/Clipboard.h:
        * dom/DOMCoreException.h:
        (WebCore::DOMCoreException::create):
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::instance):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::DOMImplementation):
        * dom/Document.cpp:
        (WebCore::Document::addWindowEventListener):
        (WebCore::Document::removeWindowEventListener):
        (WebCore::Document::setDecoder):
        (WebCore::Document::images):
        (WebCore::Document::applets):
        (WebCore::Document::embeds):
        (WebCore::Document::plugins):
        (WebCore::Document::objects):
        (WebCore::Document::scripts):
        (WebCore::Document::links):
        (WebCore::Document::forms):
        (WebCore::Document::anchors):
        (WebCore::Document::all):
        (WebCore::Document::windowNamedItems):
        (WebCore::Document::documentNamedItems):
        * dom/Document.h:
        * dom/DynamicNodeList.h:
        * dom/EventException.h:
        (WebCore::EventException::create):
        (WebCore::EventException::EventException):
        * dom/EventListener.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::addEventListener):
        (WebCore::EventTarget::removeEventListener):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/ExceptionBase.h:
        * dom/NameNodeList.h:
        (WebCore::NameNodeList::create):
        * dom/Node.cpp:
        (WebCore::Node::childNodes):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::getElementsByName):
        (WebCore::Node::getElementsByClassName):
        (WebCore::Node::querySelectorAll):
        * dom/NodeFilterCondition.h:
        * dom/NodeList.h:
        * dom/RangeException.h:
        (WebCore::RangeException::create):
        (WebCore::RangeException::RangeException):
        * dom/RegisteredEventListener.h:
        (WebCore::RegisteredEventListener::create):
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList):
        * dom/SelectorNodeList.h:
        * dom/StaticNodeList.cpp:
        (WebCore::StaticNodeList::StaticNodeList):
        * dom/StaticNodeList.h:
        (WebCore::StaticNodeList::adopt):
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create):
        * history/HistoryItem.cpp:
        (WebCore::defaultNotifyHistoryItemChanged):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::copy):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::create):
        * html/CanvasGradient.h:
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        * html/CanvasPattern.h:
        (WebCore::CanvasPattern::create):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State):
        (WebCore::CanvasRenderingContext2D::setStrokeColor):
        (WebCore::CanvasRenderingContext2D::setFillColor):
        (WebCore::CanvasRenderingContext2D::createPattern):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::CanvasStyle):
        * html/CanvasStyle.h:
        (WebCore::CanvasStyle::create):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection):
        (WebCore::HTMLCollection::create):
        * html/HTMLCollection.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::children):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::create):
        * html/HTMLFormCollection.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::elements):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::areas):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::load):
        (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
        (WebCore::HTMLMediaElement::willSaveToCache):
        * html/HTMLNameCollection.h:
        (WebCore::HTMLNameCollection::create):
        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::create):
        * html/HTMLOptionsCollection.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::options):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::rows):
        (WebCore::HTMLTableElement::tBodies):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::cells):
        * html/HTMLTableRowsCollection.cpp:
        (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
        (WebCore::HTMLTableRowsCollection::create):
        * html/HTMLTableRowsCollection.h:
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows):
        * html/MediaError.h:
        (WebCore::MediaError::create):
        (WebCore::MediaError::MediaError):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::createHistoryItem):
        * loader/ImageDocument.cpp:
        (WebCore::ImageEventListener::create):
        (WebCore::ImageEventListener::ImageEventListener):
        (WebCore::ImageDocument::createDocumentStructure):
        * loader/TextResourceDecoder.h:
        (WebCore::TextResourceDecoder::create):
        * page/Page.cpp:
        (WebCore::Page::userStyleSheet):
        * svg/SVGException.h:
        (WebCore::SVGException::create):
        (WebCore::SVGException::SVGException):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::create):
        (WebCore::ConditionEventListener::ConditionEventListener):
        (WebCore::SVGSMILElement::connectConditions):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequestException.h:
        (WebCore::XMLHttpRequestException::create):
        (WebCore::XMLHttpRequestException::XMLHttpRequestException):
        * xml/XPathException.h:
        (WebCore::XPathException::create):
        (WebCore::XPathException::XPathException):
        * xml/XPathResult.cpp:
        (WebCore::InvalidatingEventListener::create):
        (WebCore::InvalidatingEventListener::InvalidatingEventListener):
        (WebCore::XPathResult::XPathResult):
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem init]):
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem initWithURL:target:parent:title:]):
        (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
        * WebView/WebView.mm:
        (+[WebView _decodeData:]):

WebKit/win:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * WebHistoryItem.cpp:
        (WebHistoryItem::createInstance):
        (WebHistoryItem::initFromDictionaryRepresentation):
        (WebHistoryItem::initWithURLString):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Fix random failures of XSS tests by using window.postMessage().

        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
        * http/tests/security/resources/cross-frame-access.js:
        * http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
        * http/tests/security/resources/cross-frame-iframe.html:
        * platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279
          REGRESSION (r32660): Text not redrawn correctly when selection changes

        * fast/text/selection-painted-separately.html: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.png: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric.

        Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17548>

        * kjs/testkjs.cpp:
        (functionPrint):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam.

        Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17547>

        * kjs/testkjs.cpp:
        (functionPrint):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=17911

        * http/tests/security/resources/iframe-for-synchronous-form.html: Added.
        * http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
        * http/tests/security/xss-DENIED-synchronous-form.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed
        JSGlobalData::threadInstance() for non-multithreaded builds.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCoreSources.bkl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Still more CSSParser cleanup
        - use c++ style member initializers in CSSParser()
        - change m_styleElement to m_styleSheet and make it a CSSStyleSheet
        - finally add my copyright to the files I've been cleaning

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        More CSSParser cleanup
        - rename CSSParser::id to m_id
        - rename CSSParser::data to m_data
        - fix a few whitespace and argument name issues

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        * css/CSSParser.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rename CSSParser::strict to m_strict

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBackgroundColor):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseTransitionDuration):
        (WebCore::CSSParser::parseTransitionRepeatCount):
        (WebCore::CSSParser::parseTimingFunctionValue):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseColorFromValue):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::parseBorderImage):
        * css/CSSParser.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rename CSSParser::defaultNamespace to m_defaultNamespace

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseSheet):
        * css/CSSParser.h:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::addNamespace):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rename CSSParser::important to m_important

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        * css/CSSParser.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Yet another cleanup patch for CSSParser
        Rename CSSParser::valueList to m_valueList

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::checkForOrphanedUnits):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseTransitionShorthand):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransitionProperty):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::BorderImageParseContext::commitBorderImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::parseGradient):
        (WebCore::CSSParser::parseCanvas):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::parseTransformOrigin):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
        Remove CSSParser::current and CSSParser::currentParser and use
        the magic of YYLEX_PARAM instead.

        * css/CSSParser.cpp:
        (WebCore::enterGeneratedParser):
        (WebCore::CSSParser::parseSheet):
        (WebCore::CSSParser::parseRule):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseMediaQuery):
        * css/CSSParser.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Added XML attributes' parsing.

        - Moved (most) capitalization and audio hacks in the *.in files.

        * dom/make_names.pl:
        * html/HTMLTagNames.in:
        * svg/svgtags.in:




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        With the help of Jonathon Jongsma.

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
        REGRESSION (r32660): Text not redrawn correctly when selection changes

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        Add a condition for when ePos <= sPos 



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver.

        Bug 17663: Wrong sequencing of argument list evaluation
        <https://bugs.webkit.org/show_bug.cgi?id=17663>

        SquirrelFish fixed this bug, but we should add a test.

        LayoutTests:

        * fast/js/order-of-operations-expected.txt:
        * fast/js/resources/order-of-operations.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Combine per-thread objects into one, to make it easier to support legacy clients (for
        which they shouldn't be really per-thread).

        No change on SunSpider total.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}

        * kjs/JSGlobalData.cpp: Added.
        (KJS::JSGlobalData::JSGlobalData):
        (KJS::JSGlobalData::~JSGlobalData):
        (KJS::JSGlobalData::threadInstance):
        * kjs/JSGlobalData.h: Added.
        This class encapsulates all data that should be per-thread (or shared between legacy clients).
        It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.

        * kjs/identifier.h:
        (KJS::Identifier::Identifier):
        Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually,
        all of them should, but this will be a separate patch.

        * kjs/identifier.cpp:
        (KJS::IdentifierTable::literalTable):
        (KJS::createIdentifierTable):
        (KJS::deleteIdentifierTable):
        (KJS::Identifier::add):
        (KJS::Identifier::addSlowCase):
        Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.

        * kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.

        * kjs/nodes.cpp:
        (KJS::Node::Node):
        (KJS::EvalFunctionCallNode::emitCode):
        (KJS::ScopeNode::ScopeNode):
        Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a
        temporary measure, they will need to use JSGlobalData explicitly.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::callEval):
        * kjs/CommonIdentifiers.cpp:
        (KJS::CommonIdentifiers::CommonIdentifiers):
        * kjs/CommonIdentifiers.h:
        * kjs/DebuggerCallFrame.cpp:
        (KJS::DebuggerCallFrame::evaluate):
        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        * kjs/ExecState.h:
        (KJS::ExecState::globalData):
        (KJS::ExecState::identifierTable):
        (KJS::ExecState::propertyNames):
        (KJS::ExecState::emptyList):
        (KJS::ExecState::lexer):
        (KJS::ExecState::parser):
        (KJS::ExecState::arrayTable):
        (KJS::ExecState::dateTable):
        (KJS::ExecState::mathTable):
        (KJS::ExecState::numberTable):
        (KJS::ExecState::RegExpImpTable):
        (KJS::ExecState::RegExpObjectImpTable):
        (KJS::ExecState::stringTable):
        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (KJS::JSGlobalObject::head):
        (KJS::JSGlobalObject::globalData):
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Parser.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::getParameterName):
        (KJS::IndexToNameMap::unMap):
        (KJS::globalFuncEval):
        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        * kjs/lexer.cpp:
        (kjsyylex):
        * kjs/lexer.h:
        * kjs/testkjs.cpp:
        (prettyPrintScript):
        Updated for the above changes. Most of threadInstance uses here will need to be replaced with
        explicitly passed pointers to support legacy JSC clients.

        * JavaScriptCore.exp: Removed KJS::parser().



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver.

        Bug 19424: Add support for logging opcode pair counts
        <https://bugs.webkit.org/show_bug.cgi?id=19424>

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::OpcodeStats::OpcodeStats):
        (KJS::compareOpcodeIndices):
        (KJS::compareOpcodePairIndices):
        (KJS::OpcodeStats::~OpcodeStats):
        (KJS::OpcodeStats::recordInstruction):
        (KJS::OpcodeStats::resetLastInstruction):
        * VM/Opcode.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Switched *.in files to XML format.

        - Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.

        - Updated the build systems to include bindings/scripts when executing make_names.pl
        (for XMLTiny dependency).

        - Cleaned-up make_names.pl a little.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/scripts/XMLTiny.pm: Added.
        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:
        * svg/xlinkattrs.in:
        * xml/xmlattrs.in:




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing

        Test: fast/css/begin-end-contain-selector-empty-value.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing.

        * fast/css/begin-end-contain-selector-empty-value.html: Added.
        * platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        More cleanup of CSSParser.
        Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        More cleanup of CSSParser.
        Rename CSSParser::parsedProperties to m_parsedProperties.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Start the cleanup of CSSParser.
        Rename CSSParser::styleElement to CSSParser::m_styleElement

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::document):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=18337

        Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::typeAheadFind):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
        
        Serialization of font-family:-webkit-monospace when it came from a 
        CSSMutableStyleDeclaration would wrap the value in single quotes but 
        serialization of the same property value pair from a CSSComputedStyleDeclaration 
        wouldn't, which kept code that checked for and removed non-redundant styles from 
        style spans from working correctly.

        A redundant style left on a style span would not normally create a rendering 
        difference, but it did in this case because an element with 
        font-family:-webkit-monospace does not appear to inherit font-size.  
        Added a FIXME about how we might need to keep font-size on a style span if its 
        non-redundant styles include font-family:-webkit-monospace, although I couldn't 
        create a test case to produce this scenario.

        * css/FontFamilyValue.cpp:
        (WebCore::isValidCSSIdentifier): Don't return false if the String starts
        with a '-'.  This function now appears identical to isCSSTokenizerIdentifier,
        so perhaps we should use a single function.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME.  Removed the
        creation of two Strings that were never used.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break
        
        * editing/deleting/5890684-expected.txt: Added.
        * editing/deleting/5890684.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle
        can destroy insertedPlaceholder if it needs to move it, but it will set an
        endingSelection() at [movedPlaceholder, 0] if it does so.  Re-fetch insertedPlaceholder
        if that happens.  The long term solution for these crashes is to make moveParagraphs
        not copy/destroy/move content, and to make VisiblePositions update themselves on DOM 
        mutations.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this
        in the future, but ASSERT to catch them in debug builds.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode
        
        * editing/execCommand/19087-expected.txt: Added.
        * editing/execCommand/19087.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        profiler.
        - Change the remaining functions that do not take arguments, from using
        recursion to using iteration.

        * JavaScriptCore.exp:
        * profiler/Profile.cpp:
        (KJS::stopProfiling):
        (KJS::restoreAll):
        (KJS::Profile::stopProfiling): Use foreach instead of recursion.
        (KJS::Profile::restoreAll): Ditto.
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp: Remove recursion.
        (KJS::ProfileNode::stopProfiling):
        (KJS::ProfileNode::restore):
        * profiler/ProfileNode.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Alexey.

        xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
        is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
        called.
        The test was failing because CoreFoundation keeps the data if they are not big enough
        (which led to only 1 progress event dispatched).

        We now generate a big response instead of a small one.

        Warning: this test is not guaranteed to succeed as we cannot guarantee that the server
                 will send responses' sizes that are close for 2 different requests to the same
                 resource.

        * http/tests/xmlhttprequest/resources/big-response.php: Added.
        * http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.

        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a
        warning about the possible failure of the test.
        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Alexey.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): If the selection was all
        formatting (like an empty list) the format-less text will be empty.
        Early return to avoid the ASSERT that fires if input(...) is called
        with an empty String.

LayoutTests:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.
        
        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call
        
        * editing/execCommand/19403-expected.txt: Added.
        * editing/execCommand/19403.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add 'Since' documentation for API versioning functions.

        * webkit/webkitversion.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Build fix for r34387.

        * GNUmakefile.am:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alp Toker.
        
        Fix whitespaces.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin.
        
        Support compiling JavaScriptCore for ARM.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):
        (KJS::otherThreadStackPointer):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin.
        
        Support compiling JavaScriptCore for ARM.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):
        (KJS::otherThreadStackPointer):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34393 268f45cc-cd09-0410-ab3c-d52691b4dbfc