1. 21 May, 2010 1 commit
    • tony@chromium.org's avatar
      2010-05-20 Tony Chang <tony@chromium.org> · 638815b8
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              escape link text when copying or dragging links on win or chromium
              https://bugs.webkit.org/show_bug.cgi?id=39413
      
              * editing/pasteboard/drop-link-expected.txt: Added.
              * editing/pasteboard/drop-link.html:
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.txt: Removed.
      2010-05-20  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              escape link text when copying or dragging links on win or chromium
              https://bugs.webkit.org/show_bug.cgi?id=39413
      
              * editing/markup.cpp:
              (WebCore::urlToMarkup):
              * editing/markup.h:
              * platform/chromium/ClipboardUtilitiesChromium.cpp:
              * platform/chromium/ClipboardUtilitiesChromium.h:
              * platform/win/ClipboardUtilitiesWin.cpp:
              * platform/win/ClipboardUtilitiesWin.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      638815b8
  2. 20 May, 2010 19 commits
    • ukai@chromium.org's avatar
      2010-05-20 Fumitoshi Ukai <ukai@chromium.org> · 8c8c2c00
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
              https://bugs.webkit.org/show_bug.cgi?id=35572
      
              Fix LayoutTests for new WebSocket protocol.
              It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.
      
              * websocket/tests/handshake-error-expected.txt: Update expected data.
              * websocket/tests/handshake-error_wsh.py: Without CRLF, the wsh will sends "ThisWillCauseHandshakeErrorHTTP/1.1 101 WebSocket Protocol Handshake\r\n", which is legal for the first line of draft 76 WebSocket opening handshake. (4.1 Opening Handhshake, step 28 to 30).  To fail handshake, it needs \r\n.
              * websocket/tests/long-invalid-header-expected.txt:  Originally, it expects Upgrade header after status line.  In draft 76, order is not important.  But "pppp..\r\n" would fail because it misses ":" (end of name) before \r.
      2010-05-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
              https://bugs.webkit.org/show_bug.cgi?id=35572
      
              WebSocket opening handshake is changed.  New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
              It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.
      
              * websockets/WebSocketHandshake.cpp:
              (WebCore::extractResponseCode):
              add lineLength parameter to return length of status line.
              (WebCore::hostName): Added.
              (WebCore::generateSecWebSocketKey): Added.
              (WebCore::generateKey3): Added.
              (WebCore::setChallengeNumber): Added.
              (WebCore::generateChallengeResponseExpected): Added.
              (WebCore::WebSocketHandshake::WebSocketHandshake):
               generate challenge response key and expected data.
              (WebCore::WebSocketHandshake::clientLocation):
               use hostName.
              (WebCore::WebSocketHandshake::clientHandshakeMessage):
               changed for draft 76 spec.
              (WebCore::WebSocketHandshake::clientHandshakeRequest):
              (WebCore::WebSocketHandshake::readServerHandshake):
               changed for draft 76 spec.
               m_mode is managed in this method.
              (WebCore::WebSocketHandshake::readHTTPHeaders):
               change error log messages.
              (WebCore::WebSocketHandshake::processHeaders):
               chagned for draft 76 spec.
              (WebCore::WebSocketHandshake::checkResponseHeaders):
               return boolean whether response header is ok or not and not change m_mode in it.
              * websockets/WebSocketHandshake.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8c2c00
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · 9240e28a
      victorw@chromium.org authored
              Unreviewed. Update test expectations for chromium.
      
              * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
              * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Added.
              * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
              * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9240e28a
    • eric@webkit.org's avatar
      2010-05-20 Zhenyao Mo <zmo@google.com> · 595965d0
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              fast/canvas/webgl/texture-npot.html failed on leopard bot
              https://bugs.webkit.org/show_bug.cgi?id=39128
      
              * fast/canvas/webgl/texture-npot-expected.txt: Adding the failed test cases back.
              * fast/canvas/webgl/texture-npot.html:
              * platform/mac-leopard/Skipped: Skip texture-npot.html on leopard for now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      595965d0
    • eric@webkit.org's avatar
      2010-05-20 Zhenyao Mo <zmo@google.com> · d687633b
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
              * fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * src/WebGraphicsContext3DDefaultImpl.cpp:
              (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d687633b
    • mitz@apple.com's avatar
      <rdar://problem/8007953> Textarea using custom font appears blank · 55bf8727
      mitz@apple.com authored
      Reviewed by Dave Hyatt.
      
      WebCore: 
      
      Test: fast/css/font-face-in-shadow-DOM.html
      
      When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
      RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
      RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
      styles that still reference the placeholder font.
      
      The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
      true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
      
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
      * rendering/RenderButton.h:
      (WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
      * rendering/RenderDataGrid.h:
      (WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
      * rendering/RenderFileUploadControl.h:
      (WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
      * rendering/RenderListItem.h:
      (WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMedia.h:
      (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMenuList.h:
      (WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
      * rendering/RenderProgress.h:
      (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
      * rendering/RenderSlider.h:
      (WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
      * rendering/RenderTextControl.h:
      (WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
      
      LayoutTests: 
      
      * fast/css/font-face-in-shadow-DOM.html: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55bf8727
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · a3dd3427
      mrobinson@webkit.org authored
              Not reviewed.
      
              Tests that use Geolocation.getCurrentPosition fail
              https://bugs.webkit.org/show_bug.cgi?id=39454
      
              * platform/gtk/Skipped: Skip failing tests until this bug is resolved.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3dd3427
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · a9776086
      victorw@chromium.org authored
              Unreviewed. Update test expectations for chromium.
      
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9776086
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · d07f9bea
      mrobinson@webkit.org authored
              Not reviewed.
      
              https://bugs.webkit.org/show_bug.cgi?id=39388
              Re-enable geolocation tests on GTK+ now that this bug is closed.
      
              * platform/gtk/Skipped: Re-enable geolocation tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d07f9bea
    • yaar@chromium.org's avatar
      2010-05-20 Justin Schuh <jschuh@chromium.org> · 37eb477c
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-20  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eb477c
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · bf8254cc
      mrobinson@webkit.org authored
              Unreviewed.
      
              editingBehavior settings needs to be set back to a reasonable default between tests
              https://bugs.webkit.org/show_bug.cgi?id=39433
      
              I forgot to revert the expected results for this test after reverting it.
      
              * editing/selection/extend-selection-after-double-click-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8254cc
    • jamesr@google.com's avatar
      2010-05-20 James Robinson <jamesr@chromium.org> · 3ba18e88
      jamesr@google.com authored
              Reviewed by Eric Seidel.
      
              Ensures styles are up-to-date before determining selection
              https://bugs.webkit.org/show_bug.cgi?id=39389
      
              This adds a call to document::updateStyleIfNeeded() to
              Frame::notifyRendererOfSelectionChange(). Without this call, if there
              is a pending style update that will detach part of the DOM and the
              the selection is within that part of the DOM when
              notifyRendererOfSeletionChange is called, the rootEditableElement
              algorithm ends up walking through detached parts of the render tree.
      
              Test: editing/selection/focus-and-display-none.html
      
              * page/Frame.cpp:
              (WebCore::Frame::notifyRendererOfSelectionChange):
      2010-05-20  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Tests putting focus into a textarea and setting display:none
              https://bugs.webkit.org/show_bug.cgi?id=39389
      
              * editing/selection/focus-and-display-none-expected.txt: Added.
              * editing/selection/focus-and-display-none.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ba18e88
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · 3c25fb48
      mrobinson@webkit.org authored
              Reviewed by Ojan Vafai.
      
              editingBehavior settings needs to be set back to a reasonable default between tests
              https://bugs.webkit.org/show_bug.cgi?id=39433
      
              Revert the changes from r59840 to this test until there is a method
              in the WebKit APIs to consistently reset the editingBehavior setting
              to a reasonable default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c25fb48
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · 505fdbc2
      victorw@chromium.org authored
              Unreviewed. Update test expectations from chromium.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      505fdbc2
    • steveblock@google.com's avatar
      2010-05-20 Steve Block <steveblock@google.com> · 2f4e6fc9
      steveblock@google.com authored
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
      
              * Configurations/FeatureDefines.xcconfig:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.
      
              * win/tools/vsprops/FeatureDefines.vsprops:
              * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
      
              * Configurations/FeatureDefines.xcconfig:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Tests: fast/dom/DeviceOrientation/window-property.html
                     fast/dom/Window/window-properties-on-device-orientation.html
      
              Adds bindings for DeviceOrientation as defined in
              http://dev.w3.org/geo/api/spec-source-orientation.html
              This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
              all platforms but Android.
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.mk:
              * Configurations/FeatureDefines.xcconfig:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS):
              * bindings/v8/custom/V8EventCustom.cpp:
              (WebCore::toV8):
              * dom/DeviceOrientationEvent.cpp: Added.
              (WebCore::DeviceOrientationEvent::DeviceOrientationEvent):
              (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
              * dom/DeviceOrientationEvent.h: Added.
              (WebCore::DeviceOrientationEvent::create):
              (WebCore::DeviceOrientationEvent::alpha):
              (WebCore::DeviceOrientationEvent::beta):
              (WebCore::DeviceOrientationEvent::gamma):
              (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
              * dom/DeviceOrientationEvent.idl: Added.
              * dom/Event.cpp:
              (WebCore::Event::isDeviceOrientationEvent):
              * dom/Event.h:
              * dom/EventNames.h:
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
              it is widely supported.
              Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
              type and presence of window.ondeviceorientation.
              Adds new fast/dom/DeviceOrientation directory and initial test.
              Adds all DeviceOrientation tests to all skipped lists.
      
              * fast/dom/DeviceOrientation: Added.
              * fast/dom/DeviceOrientation/script-tests: Added.
              * fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
              * fast/dom/DeviceOrientation/script-tests/window-property.js: Added.
              (hasOnDeviceOrientationProperty):
              * fast/dom/DeviceOrientation/window-property-expected.txt: Added.
              * fast/dom/DeviceOrientation/window-property.html: Added.
              * fast/dom/Window/script-tests/window-property-descriptors.js:
              * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
              * fast/dom/Window/window-properties-on-device-orientation.html: Added.
              * fast/dom/Window/window-properties.html:
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f4e6fc9
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@webkit.org> · 255a8cf1
      mrobinson@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior.
              * editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * public/WebSettings.h:
              (WebKit::WebSettings::): Added an enum for EditingBehavior types.
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setEditingBehavior): Added.
              * src/WebSettingsImpl.h:
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * WebView/WebFrame.mm:
              (core):
              * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
              * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
              (-[WebPreferences editingBehavior]): Added.
              (-[WebPreferences setEditingBehavior:]): Added.
              * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              Expose the EditingBehavior setting in the Windows API.
      
              * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
              * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
              * WebPreferences.cpp:
              (WebPreferences::editingBehavior): Added.
              (WebPreferences::setEditingBehavior): Added.
              * WebPreferences.h: Add method declarations.
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setEditingBehaviorCallback): Added.
              (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior.
              * DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method.
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setEditingBehavior): Ditto
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      255a8cf1
    • agl@chromium.org's avatar
      2010-05-20 Adam Langley <agl@chromium.org> · 207a9d7d
      agl@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] Avoid crash when msttcorefonts aren't provided
      
              https://bugs.webkit.org/show_bug.cgi?id=39015
              http://code.google.com/p/chromium/issues/detail?id=43831
      
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::createFontPlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      207a9d7d
    • zherczeg@webkit.org's avatar
      Unreviewed. Update Qt specific expected file. · aef21388
      zherczeg@webkit.org authored
      * platform/qt/svg/filters/feLighting-crash-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aef21388
    • zherczeg@webkit.org's avatar
      WebCore: Fix a crash caused by feLigthing::apply() · 61cd574c
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39004
      
      Reviewed by Dirk Schulze.
      
      Make FELighting::apply() similar to other filters' applies
      to avoid an assertion fail in putUnmultipliedImageData(),
      when effectDrawingRect has negative location (x or y is less than 0).
      
      Test: svg/filters/feLighting-crash.svg
      
      * svg/graphics/filters/SVGFELighting.cpp:
      (WebCore::FELighting::apply):
      
      LayoutTests: In case of lighting SVG effects, a wider output rectangle
      than the input image size should not cause crash.
      https://bugs.webkit.org/show_bug.cgi?id=39004
      
      Reviewed by Dirk Schulze.
      
      * platform/mac/svg/filters/feLighting-crash-expected.checksum: Added.
      * platform/mac/svg/filters/feLighting-crash-expected.png: Added.
      * platform/mac/svg/filters/feLighting-crash-expected.txt: Added.
      * platform/qt/svg/filters/feLighting-crash-expected.txt: Added.
      * svg/filters/feLighting-crash.svg: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61cd574c
    • morrita@google.com's avatar
      2010-05-20 MORITA Hajime <morrita@google.com> · 034e133e
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              This test passes if it doesn't crash.
      
              * editing/execCommand/35791-expected.txt: Added.
              * editing/execCommand/35791.html: Added.
      2010-05-20  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              2x execCommand ReadAV@NULL
              https://bugs.webkit.org/show_bug.cgi?id=35791
      
              In applyBlockStyle(), a node which is referred from
              nextParagraphStart sometimes removed from the document and goes
              orphan, and that causes an assertion failed. This is because
              moveParagraphs() replaces the node with a new one with some new
              styles applied. So we re-compute nextParagraphStart in that case.
      
              Test: editing/execCommand/35791.html
      
              * dom/Position.h:
              (WebCore::Position::isOrphan):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/VisiblePosition.h:
              (WebCore::VisiblePosition::isOrphan):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      034e133e
  3. 19 May, 2010 20 commits
    • eric@webkit.org's avatar
      2010-05-19 Mario Sanchez Prada <msanchez@igalia.com> · f849d713
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Misleading variable name in a11y test
              https://bugs.webkit.org/show_bug.cgi?id=38465
      
              Use a more appropriate variable name for the return
              value of accessibilityController.rootElement
      
              * accessibility/aria-controls-with-tabs.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f849d713
    • victorw@chromium.org's avatar
      2010-05-19 Victor Wang <victorw@chromium.org> · 6aa66153
      victorw@chromium.org authored
              Unreviewed. Update Chromium test expectations.
      
              * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png: Added.
              * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
              * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
              * platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
              * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png: Added.
              * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt: Added.
              * platform/chromium-win/fast/multicol/nested-columns-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa66153
    • oliver@apple.com's avatar
      2010-05-19 Oliver Hunt <oliver@apple.com> · fc502ee5
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              emitJumpIfNotJSCell should special case constant immediate values
              https://bugs.webkit.org/show_bug.cgi?id=39392
              <rdar://problem/8001324>
      
              Make emitJumpSlowCaseIfNotJSCell special case constant immediate
              values, in addition to the immediate JSCell optimisation.
      
              Also add assertions to make sure no one else produces code that
              attempts to load constants from the register file.
      
              * jit/JITInlineMethods.h:
              (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
              * jit/JSInterfaceJIT.h:
              (JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
              (JSC::JSInterfaceJIT::emitLoadInt32):
              (JSC::JSInterfaceJIT::tagFor):
              (JSC::JSInterfaceJIT::payloadFor):
              (JSC::JSInterfaceJIT::emitLoadDouble):
              (JSC::JSInterfaceJIT::addressFor):
              * jit/ThunkGenerators.cpp:
      2010-05-19  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              emitJumpIfNotJSCell should special case constant immediate values
              https://bugs.webkit.org/show_bug.cgi?id=39392
      
              Add tests for immediate constants being used where cells are expected.
      
              * fast/js/immediate-constant-instead-of-cell-expected.txt: Added.
              * fast/js/immediate-constant-instead-of-cell.html: Added.
              * fast/js/script-tests/immediate-constant-instead-of-cell.js: Added.
              ():
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc502ee5
    • jianli@chromium.org's avatar
      Refactor text encoding detection logic in FileReader. · b9a7ac12
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39131
      
      Reviewed by Alexey Proskuryakov.
      
      WebCore:
      
      Changed FileReader::convertToText to call TextResourceDecoder::decode to
      detect the encoding from BOM and decode the text. Though the File API
      spec says that the supplied encoding should be used if it is valid, we
      choose to ignore this requirement in order to be consistent with how
      WebKit decodes the web content: always has the BOM override the provided
      encoding.
      
      * html/FileReader.cpp:
      (WebCore::FileReader::convertToText):
      * html/FileReader.h:
      
      LayoutTests:
      
      Add more test coverage for FileReader.
      
      * fast/files/file-reader-expected.txt:
      * fast/files/file-reader.html:
      * fast/files/resources/binary-file: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9a7ac12
    • mrobinson@webkit.org's avatar
      Not reviewed. · 0f317229
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39388
      
      Disabling geolocation tests until blockers are fixed.
      
      * platform/gtk/Skipped: Skipping geolocation tests for now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f317229
    • yaar@chromium.org's avatar
      2010-05-19 Abhishek Arya <inferno@chromium.org> · 0a6907d8
      yaar@chromium.org authored
              Reviewed by David Hyatt.
      
              Check that the node is a text node before doing a static cast
              to a Text class pointer.
              https://bugs.webkit.org/show_bug.cgi?id=38626    
      
              Test: fast/text/text-transform-nontext-node-crash.xhtml
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::originalText):
              * rendering/RenderTextFragment.cpp:
              (WebCore::RenderTextFragment::originalText):
              (WebCore::RenderTextFragment::previousCharacter):
      2010-05-19  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by David Hyatt.
      
              Tests that text transformation applied to a non-text node
              does not result in crash.
              https://bugs.webkit.org/show_bug.cgi?id=38626        
      
              * fast/text/text-transform-nontext-node-crash-expected.txt: Added.
              * fast/text/text-transform-nontext-node-crash.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a6907d8
    • mrobinson@webkit.org's avatar
      2010-05-19 Martin Robinson <mrobinson@igalia.com> · 43299bec
      mrobinson@webkit.org authored
              Not reviewed.
      
              Updated multi-column test baselines.
      
              * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Updated.
              * platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Added.
              * platform/gtk/fast/multicol/nested-columns-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43299bec
    • yaar@chromium.org's avatar
      2010-05-19 Yaar Schnitman <yaar@chromium.org> · b4cce0b0
      yaar@chromium.org authored
              Unreviewed, rolling out r59769.
              http://trac.webkit.org/changeset/59769
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Broke GTK again
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Removed.
              * bindings/js/JSMainThreadExecState.h: Removed.
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-19  Yaar Schnitman  <yaar@chromium.org>
      
              Unreviewed, rolling out r59769.
              http://trac.webkit.org/changeset/59769
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Broke GTK again
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4cce0b0
    • dpranke@chromium.org's avatar
      2010-05-19 Dirk Pranke <dpranke@chromium.org> · 1b7b4188
      dpranke@chromium.org authored
              Try again to roll out r58765
      
              * fast/notifications/notifications-replace-expected.txt: Removed.
              * fast/notifications/notifications-replace.html: Removed.
              * fast/notifications/notifications-rtl-expected.txt: Removed.
              * fast/notifications/notifications-rtl.html: Removed.
      2010-05-19  Dirk Pranke  <dpranke@chromium.org>
      
              Try again to roll out r58675.
      
              * notifications/Notification.h:
              * notifications/Notification.idl:
      2010-05-19  Dirk Pranke  <dpranke@chromium.org>
      
              Try again to roll out r58765.
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b7b4188
    • enrica@apple.com's avatar
      WebCore: REGRESSION (r59385) crash destroying inline renderers · 69fdfe2e
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39143
      <rdar://problem/8003662>
              
      Reviewed by Dave Hyatt.
      
      The goal of r59385 was to make sure that the layout of block after all its children had been removed produced the identical result
      as the one of a newly created empty block. In order to do so, we had to make sure that the m_inlineChildren flag was reset to true when
      the block had no children (as it is upon creation).
      I discovered that, by doing that for anonymous blocks it leads removeChild to conclude that the anonymous children can be removed,
      without considering that the anonymous block could be part of a continuation chain. For this reason, when RenderInline::destroy()
      tries to remove the continuations we are effectively deleting a renderer that had been deleted already.
              
      Test: fast/inline-block/anonymous-block-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock): resetting the flag m_inlineChildren only for non anonymous blocks otherwise we incurr in
      a double deletion of the renderer that causes the crash.
      
      LayoutTests: REGRESSION (r59385) crash destroying inline renderers
      https://bugs.webkit.org/show_bug.cgi?id=39143
      <rdar://problem/8003662>
      
      Reviewed by Dave Hyatt.
      
      * fast/inline-block/anonymous-block-crash-expected.txt: Added.
      * fast/inline-block/anonymous-block-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69fdfe2e
    • dpranke@chromium.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 01955d5c
      dpranke@chromium.org authored
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * fast/notifications/notifications-replace-expected.txt: Added.
              * fast/notifications/notifications-replace.html: Added.
              * fast/notifications/notifications-rtl-expected.txt: Added.
              * fast/notifications/notifications-rtl.html: Added.
      2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * notifications/Notification.h:
              (WebCore::Notification::dir):
              (WebCore::Notification::setDir):
              (WebCore::Notification::replaceId):
              (WebCore::Notification::setReplaceId):
              * notifications/Notification.idl:
      2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
              (WebKit::WebNotification::dir):
              (WebKit::WebNotification::replaceId):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01955d5c
    • dpranke@chromium.org's avatar
      2010-05-18 Dirk Pranke <dpranke@chromium.org> · cf58e8c3
      dpranke@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * fast/notifications/notifications-replace-expected.txt: Removed.
              * fast/notifications/notifications-replace.html: Removed.
              * fast/notifications/notifications-rtl-expected.txt: Removed.
              * fast/notifications/notifications-rtl.html: Removed.
      2010-05-18  Dirk Pranke  <dpranke@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * notifications/Notification.h:
              * notifications/Notification.idl:
      2010-05-18  Dirk Pranke  <dpranke@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf58e8c3
    • mrobinson@webkit.org's avatar
      2010-05-19 Martin Robinson <mrobinson@igalia.com> · 78b17a64
      mrobinson@webkit.org authored
              Not reviewed.
      
              Add baselines for new multi-column tests.
      
              * platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Added.
              * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Added.
              * platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78b17a64
    • yaar@chromium.org's avatar
      2010-05-19 Justin Schuh <jschuh@chromium.org> · a4b82d8b
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-19  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4b82d8b
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · cf579f5e
      chang.shu@nokia.com authored
              Reviewed by Darin Adler.
      
              CanvasRenderingContext2D's property getters that return colors should
              serialize them in accordance with the HTML5 spec (4.8.11.1.4)
              Setters should ignore invalid colors.
      
              Also, shadowColor should initially be transparent black (4.8.11.1.6)
      
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string.
      
              Spec links:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
              (WebCore::CanvasRenderingContext2D::shadowColor):
              (WebCore::CanvasRenderingContext2D::setShadowColor):
              (WebCore::CanvasRenderingContext2D::setShadow):
              (WebCore::CanvasRenderingContext2D::clearShadow):
              (WebCore::CanvasRenderingContext2D::applyShadow):
              * html/canvas/CanvasRenderingContext2D.h:
              * html/canvas/CanvasStyle.cpp:
              (WebCore::CanvasStyle::CanvasStyle):
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::applyStrokeColor):
              (WebCore::CanvasStyle::applyFillColor):
              * html/canvas/CanvasStyle.h:
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::color):
              (WebCore::CanvasStyle::):
              (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
              * platform/graphics/Color.cpp:
              (WebCore::Color::serialized):
              * platform/graphics/Color.h:
      
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Darin Adler.
      
              Added a test to verify proper color serialization in CanvasRenderingContext2D's getters.
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
      
              * fast/canvas/canvas-color-serialization-expected.txt: Added.
              * fast/canvas/canvas-color-serialization.html: Added.
              * fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt: Updated baseline.
              * fast/canvas/script-tests/canvas-color-serialization.js: Added.
              (trySettingStrokeStyle):
              (trySettingFillStyle):
              (trySettingShadowColor):
              (trySettingColor):
              (trySettingStrokeColorWithSetter):
              (trySettingFillColorWithSetter):
              (trySettingShadowWithSetter):
              (trySettingColorWithSetter):
              (trySettingFillColorRGBA):
              (trySettingStrokeColorRGBA):
              (trySettingShadowRGBA):
              (trySettingRGBA):
              (trySettingFillColorCMYKA):
              (trySettingStrokeColorCMYKA):
              (trySettingShadowCMYKA):
              (trySettingCMYKA):
              (trySettingFillColorWithOverrideAlpha):
              (trySettingStrokeColorWithOverrideAlpha):
              (trySettingShadowWithOverrideAlpha):
              (trySettingColorWithOverrideAlpha):
              (trySettingFillColorGrayLevel):
              (trySettingStrokeColorGrayLevel):
              (trySettingShadowGrayLevel):
              (trySettingGrayLevel):
              (trySettingFillColorGrayLevelWithAlpha):
              (trySettingStrokeColorGrayLevelWithAlpha):
              (trySettingShadowGrayLevelWithAlpha):
              (trySettingGrayLevelWithAlpha):
              (tryClearShadowAfterSettingColor):
              (checkDefaultValue):
              * fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js:
              * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Updated baseline.
              * fast/dom/canvasContext2d-element-attribute-js-null.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf579f5e
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · 92749a8e
      chang.shu@nokia.com authored
              Reviewed by Simon Hausmann.
      
              [Qt] REGRESSION: CoolClock isn't rendered properly
      
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              CanvasRenderingContext2D's arc() should connect to the previous point
              with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty
              to begin with, we don't want a line back to (0,0)
              This also fixes the rendering artifact discussed in bug 36226.
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
      
              Test: fast/canvas/canvas-arc-connecting-line.html
      
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              Add test to verify that CanvasRenderingContext2D's arc() connects arcs
              by a straight line (unless it's the first element in the path.)
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              * fast/canvas/canvas-arc-connecting-line-expected.txt: Added.
              * fast/canvas/canvas-arc-connecting-line.html: Added.
              * fast/canvas/script-tests/canvas-arc-connecting-line.js: Added.
              (deg2rad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92749a8e
    • abecsi@webkit.org's avatar
      The backtrackParenthesesOnceEnd function should store the start position · a3e99255
      abecsi@webkit.org authored
      of the subpattern's non-greedy match at the place of the subpattern's
      start index in the output array instead of the place of the
      subpattern's end index.
      Add layout test for checking of non-greedy matching of subpattern in
      regular expressions.
      https://bugs.webkit.org/show_bug.cgi?id=39289
      
      Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-05-19
      Reviewed by Darin Adler.
      
      JavaScriptCore: 
      
      * yarr/RegexInterpreter.cpp:
      (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
      
      LayoutTests: 
      
      * fast/js/regexp-non-greedy-parentheses-expected.txt: Added.
      * fast/js/regexp-non-greedy-parentheses.html: Added.
      * fast/js/script-tests/regexp-non-greedy-parentheses.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3e99255
    • eric@webkit.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 1f931caa
      eric@webkit.org authored
              Unreviewed, rolling out r59758.
              http://trac.webkit.org/changeset/59758
              https://bugs.webkit.org/show_bug.cgi?id=39361
      
              This patch adds a test that fails on Leopard (Requested by
              abarth on #webkit).
      
              * fast/canvas/webgl/texture-npot-expected.txt:
              * fast/canvas/webgl/texture-npot.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f931caa
    • eric@webkit.org's avatar
      2010-05-19 Zhenyao Mo <zmo@google.com> · c32d3816
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              fast/canvas/webgl/texture-npot.html failed on leopard bot
              https://bugs.webkit.org/show_bug.cgi?id=39128
      
              * fast/canvas/webgl/texture-npot-expected.txt: Skip pixel (0, 0); print out actual color when failing.
              * fast/canvas/webgl/texture-npot.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32d3816
    • eric@webkit.org's avatar
      2010-05-19 Ben Murdoch <benm@google.com> · 7aa1ae77
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Update the expected results for enumerating the window object
              properties now touch event listeners are no longer marked DontEnum.
      
              * platform/qt/fast/dom/Window/window-properties-expected.txt:
      2010-05-19  Ben Murdoch  <benm@google.com>
      
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Touch events are the only attribute event listeners on the
              window object that are marked DontEnum. For consistency allow
              them to be enumerated.
      
              * page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,
                  touchstart and touchmove attributes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aa1ae77