1. 21 May, 2010 3 commits
    • tony@chromium.org's avatar
      2010-05-20 Tony Chang <tony@chromium.org> · 638815b8
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              escape link text when copying or dragging links on win or chromium
              https://bugs.webkit.org/show_bug.cgi?id=39413
      
              * editing/pasteboard/drop-link-expected.txt: Added.
              * editing/pasteboard/drop-link.html:
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/drop-link-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.png: Removed.
              * platform/mac/editing/pasteboard/drop-link-expected.txt: Removed.
      2010-05-20  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              escape link text when copying or dragging links on win or chromium
              https://bugs.webkit.org/show_bug.cgi?id=39413
      
              * editing/markup.cpp:
              (WebCore::urlToMarkup):
              * editing/markup.h:
              * platform/chromium/ClipboardUtilitiesChromium.cpp:
              * platform/chromium/ClipboardUtilitiesChromium.h:
              * platform/win/ClipboardUtilitiesWin.cpp:
              * platform/win/ClipboardUtilitiesWin.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      638815b8
    • dbates@webkit.org's avatar
      2010-05-20 Daniel Bates <dbates@rim.com> · ac3cf4bd
      dbates@webkit.org authored
              Rubber-stamped by Simon Fraser.
      
              Spelling correction; change "acces" [sic] to "access".
      
              * quality/lifecycle.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac3cf4bd
    • philn@webkit.org's avatar
      2010-05-18 Philippe Normand <pnormand@igalia.com> · a70cf24b
      philn@webkit.org authored
              Reviewed by Eric Carlson.
      
              [GStreamer] PlatformMedia support
              https://bugs.webkit.org/show_bug.cgi?id=39300
      
              Basic support for PlatformMedia in the gst player. The
              PlatformMedia object contains a GStreamerGWorld object. That
              object is empty for now. XOverlay features will be added later
              on for easy review sake.
      
              * GNUmakefile.am:
              * platform/graphics/MediaPlayer.h:
              (WebCore::PlatformMedia::):
              * platform/graphics/gstreamer/GStreamerGWorld.cpp: Added.
              (WebCore::GStreamerGWorld::createGWorld):
              (WebCore::GStreamerGWorld::GStreamerGWorld):
              (WebCore::GStreamerGWorld::~GStreamerGWorld):
              * platform/graphics/gstreamer/GStreamerGWorld.h: Added.
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::platformMedia):
              (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a70cf24b
  2. 20 May, 2010 37 commits
    • eric@webkit.org's avatar
      2010-05-20 Kwang Yul Seo <skyul@company100.net> · 8b587648
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Add dummy SSLKeyGenerator
              https://bugs.webkit.org/show_bug.cgi?id=39403
      
              Add dummy implementation of SSLKeyGenerator.
      
              * platform/brew/SSLKeyGeneratorBrew.cpp: Added.
              (WebCore::WebCore::getSupportedKeySizes):
              (WebCore::WebCore::signedPublicKeyAndChallengeString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b587648
    • mrowe@apple.com's avatar
      <rdar://problem/7848154> Remove the dependency on Foundation's private... · 938177c2
      mrowe@apple.com authored
      <rdar://problem/7848154> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS_2__ define.
      
      Rubber-stamped by Dan Bernstein.
      
      WebCore:
      
      * platform/mac/EmptyProtocolDefinitions.h:
      
      WebKitTools:
      
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      938177c2
    • simon.fraser@apple.com's avatar
      2010-05-20 Simon Fraser <simon.fraser@apple.com> · 9635e4bf
      simon.fraser@apple.com authored
              Build fix, no review.
      
              Fix the non-accelerated-compositing Windows build with some
              #if USE(ACCELERATED_COMPOSITING) loving.
      
              * WebView.cpp:
              * WebView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9635e4bf
    • eric@webkit.org's avatar
      2010-05-20 Kwang Yul Seo <skyul@company100.net> · 8e8dbb73
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Add Editor
              https://bugs.webkit.org/show_bug.cgi?id=39404
      
              Implement Editor::newGeneralClipboard.
      
              * editing/brew/EditorBrew.cpp: Added.
              (WebCore::Editor::newGeneralClipboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e8dbb73
    • simon.fraser@apple.com's avatar
      2010-05-20 Simon Fraser <simon.fraser@apple.com> · 19378b7d
      simon.fraser@apple.com authored
              Reviewed by Adam Roben.
      
              Avoid flushing CA layers when a layout is pending
              https://bugs.webkit.org/show_bug.cgi?id=39463
              <rdar://problem/7999463>
      
              Avoid rendering the compositing layers to the screen if there's a layout pending,
              since the layer tree not in a state that should be presented to the user.
      
              This fixes flashes in some types of content that dynamically add and remove layers.
      
              Do this by adding a WKCACFLayerRendererClient for WKCACFLayerRenderer, which it can
              call through to ask whether now is a good time to render. If not, it schedules
              another render soon.
      
              * platform/graphics/win/WKCACFLayerRenderer.h:
              (WebCore::WKCACFLayerRendererClient::~WKCACFLayerRendererClient):
              * platform/graphics/win/WKCACFLayerRenderer.cpp:
              (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
              (WebCore::WKCACFLayerRenderer::create):
              (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
              (WebCore::WKCACFLayerRenderer::render):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19378b7d
    • eric@webkit.org's avatar
      2010-05-20 Kwang Yul Seo <skyul@company100.net> · 94002a0d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Don't include CoreFoundation.h when building for BREW MP
              https://bugs.webkit.org/show_bug.cgi?id=39405
      
              Add !defined(BUILDING_BREWMP__) guard for CoreFoundation.h.
      
              * WebCorePrefix.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94002a0d
    • eric@webkit.org's avatar
      2010-05-20 Kwang Yul Seo <skyul@company100.net> · 189d8cd8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Use skia as BREW MP's graphics backend.
              https://bugs.webkit.org/show_bug.cgi?id=39407
      
              Define WTF_PLATFORM_SKIA=1 for BREW MP.
      
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      189d8cd8
    • eric@webkit.org's avatar
      2010-05-20 Kwang Yul Seo <skyul@company100.net> · bb771083
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Add ScrollTheme
              https://bugs.webkit.org/show_bug.cgi?id=39406
      
              As BREW MP always uses frame flattening, there is no need to render scorllbars.
              Use the default scrollbar theme with thickness 0.
      
              * platform/brew/ScrollbarThemeBrew.cpp: Added.
              (WebCore::ScrollbarTheme::nativeTheme):
              (WebCore::ScrollbarThemeBrew::~ScrollbarThemeBrew):
              * platform/brew/ScrollbarThemeBrew.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb771083
    • eric@webkit.org's avatar
      2010-05-20 Tony Gentilcore <tonyg@chromium.org> · 12dca6c6
      eric@webkit.org authored
              Reviewed by Daniel Bates.
      
              Look in /proc/registry64 for the Platform SDK on 64-bit Windows.
              https://bugs.webkit.org/show_bug.cgi?id=39296
      
              The build-webkit script failed for me on Vista 64. A web search turned
              up this blog post with a patch that worked for me:
              http://www.nicholaswilson.me.uk/2010/04/hacking-webkit-fail/
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12dca6c6
    • ggaren@apple.com's avatar
      Fixed naming mixup: it's op_call_put_result, not ret_result. · 20037442
      ggaren@apple.com authored
      Reviewed by Beth Dakin.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dump):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20037442
    • jhoneycutt@apple.com's avatar
      REGRESSION(r53637): DivX plug-in fails to start until window is resized · 0db7af26
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39457
      <rdar://problem/8006102>
      
      Before r53637, we called Widget::move() (which caused us to call
      NPP_SetWindow) before painting a plug-in. r53637 removed the call to
      Widget::move(), and we end up never calling NPP_SetWindow for plug-ins
      with the "DeferFirstSetWindowCall" quirk, including the DivX plug-in.
      
      Reviewed by Simon Fraser.
      
      * manual-tests/divx-plugin-fails-to-draw.html: Added.
      
      * plugins/PluginView.cpp:
      (WebCore::PluginView::PluginView):
      Initialize new member to false.
      
      * plugins/PluginView.h:
      Added new member.
      
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::paint):
      Call setNPWindowRect() before painting to ensure that NPP_SetWindow gets
      called.
      (WebCore::PluginView::setNPWindowRect):
      Set m_haveCalledSetWindow.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0db7af26
    • ukai@chromium.org's avatar
      2010-05-20 Fumitoshi Ukai <ukai@chromium.org> · 8c8c2c00
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
              https://bugs.webkit.org/show_bug.cgi?id=35572
      
              Fix LayoutTests for new WebSocket protocol.
              It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.
      
              * websocket/tests/handshake-error-expected.txt: Update expected data.
              * websocket/tests/handshake-error_wsh.py: Without CRLF, the wsh will sends "ThisWillCauseHandshakeErrorHTTP/1.1 101 WebSocket Protocol Handshake\r\n", which is legal for the first line of draft 76 WebSocket opening handshake. (4.1 Opening Handhshake, step 28 to 30).  To fail handshake, it needs \r\n.
              * websocket/tests/long-invalid-header-expected.txt:  Originally, it expects Upgrade header after status line.  In draft 76, order is not important.  But "pppp..\r\n" would fail because it misses ":" (end of name) before \r.
      2010-05-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
              https://bugs.webkit.org/show_bug.cgi?id=35572
      
              WebSocket opening handshake is changed.  New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
              It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.
      
              * websockets/WebSocketHandshake.cpp:
              (WebCore::extractResponseCode):
              add lineLength parameter to return length of status line.
              (WebCore::hostName): Added.
              (WebCore::generateSecWebSocketKey): Added.
              (WebCore::generateKey3): Added.
              (WebCore::setChallengeNumber): Added.
              (WebCore::generateChallengeResponseExpected): Added.
              (WebCore::WebSocketHandshake::WebSocketHandshake):
               generate challenge response key and expected data.
              (WebCore::WebSocketHandshake::clientLocation):
               use hostName.
              (WebCore::WebSocketHandshake::clientHandshakeMessage):
               changed for draft 76 spec.
              (WebCore::WebSocketHandshake::clientHandshakeRequest):
              (WebCore::WebSocketHandshake::readServerHandshake):
               changed for draft 76 spec.
               m_mode is managed in this method.
              (WebCore::WebSocketHandshake::readHTTPHeaders):
               change error log messages.
              (WebCore::WebSocketHandshake::processHeaders):
               chagned for draft 76 spec.
              (WebCore::WebSocketHandshake::checkResponseHeaders):
               return boolean whether response header is ok or not and not change m_mode in it.
              * websockets/WebSocketHandshake.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8c2c00
    • eric@webkit.org's avatar
      2010-05-20 Eric Seidel <eric@webkit.org> · 5da20731
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              ThreadedMessageQueue should use with_statement for exception safety
              https://bugs.webkit.org/show_bug.cgi?id=39233
      
              * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5da20731
    • eric@webkit.org's avatar
      2010-05-20 Viet-Trung Luu <viettrungluu@chromium.org> · 56a60aaa
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Don't rely on focused node to route mouse events to plugins.
              https://bugs.webkit.org/show_bug.cgi?id=39375
              http://crbug.com/43935
      
              On mouse down, do a hit test and check if a plugin was hit. If so, then
              save the node for future mouse events (until mouse up or capture lost).
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::WebViewImpl):
              (WebKit::WebViewImpl::mouseDown):
              (WebKit::WebViewImpl::handleInputEvent):
              (WebKit::WebViewImpl::mouseCaptureLost):
              * src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56a60aaa
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · 9240e28a
      victorw@chromium.org authored
              Unreviewed. Update test expectations for chromium.
      
              * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
              * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Added.
              * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
              * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9240e28a
    • eric@webkit.org's avatar
      2010-05-20 Zhenyao Mo <zmo@google.com> · 595965d0
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              fast/canvas/webgl/texture-npot.html failed on leopard bot
              https://bugs.webkit.org/show_bug.cgi?id=39128
      
              * fast/canvas/webgl/texture-npot-expected.txt: Adding the failed test cases back.
              * fast/canvas/webgl/texture-npot.html:
              * platform/mac-leopard/Skipped: Skip texture-npot.html on leopard for now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      595965d0
    • eric@webkit.org's avatar
      2010-05-20 Dominic Mazzoni <dmazzoni@chromium.org> · ece3d66e
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Add headingLevel and setFocused methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=39238
      
              * public/WebAccessibilityObject.h:
              * src/WebAccessibilityObject.cpp:
              (WebKit::WebAccessibilityObject::headingLevel):
              (WebKit::WebAccessibilityObject::setFocused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece3d66e
    • aroben@apple.com's avatar
      Stop leaking all CACFContexts · efd4b22b
      aroben@apple.com authored
      Fixes <http://webkit.org/b/39466> <rdar://problem/8007141>.
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/win/WKCACFContextFlusher.cpp:
      (WebCore::WKCACFContextFlusher::addContext): Only retain the context
      when we first add it to the m_contexts set. Otherwise we'll retain the
      same context multiple times, causing it to leak.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efd4b22b
    • eric@webkit.org's avatar
      2010-05-20 Diego Gonzalez <diegohcg@webkit.org> · 6501c6fe
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs
              https://bugs.webkit.org/show_bug.cgi?id=38456
      
              * QtTestBrowser/webpage.cpp:
              (WebPage::WebPage):
              (WebPage::authenticationRequired):
              * QtTestBrowser/webpage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6501c6fe
    • ggaren@apple.com's avatar
      2010-05-20 Geoffrey Garen <ggaren@apple.com> · 109a7ea3
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Whittling away at CodeBlock use: Removed a little wonkiness in closure lookup
              https://bugs.webkit.org/show_bug.cgi?id=39444
              
              Calculate all lookup depths at compile time. I'm not sure why we couldn't
              do this before, but whatever the reason, it seems to be gone now.
      
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::findScopedProperty):
              * bytecompiler/BytecodeGenerator.h:
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::resolveSkip):
              (JSC::Interpreter::resolveGlobalDynamic):
              (JSC::Interpreter::privateExecute):
              * jit/JITOpcodes.cpp:
              (JSC::JIT::emit_op_get_scoped_var):
              (JSC::JIT::emit_op_put_scoped_var):
              (JSC::JIT::emit_op_resolve_skip):
              (JSC::JIT::emit_op_resolve_global_dynamic):
              (JSC::JIT::emitSlow_op_resolve_global_dynamic):
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::emit_op_get_scoped_var):
              (JSC::JIT::emit_op_put_scoped_var):
              (JSC::JIT::emit_op_resolve_skip):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      109a7ea3
    • eric@webkit.org's avatar
      2010-05-20 Young Han Lee <joybro@company100.net> · ae9d1dd5
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Create filenameFromString for all ports except GTK and EFL.
              https://bugs.webkit.org/show_bug.cgi?id=39348
      
              * platform/FileSystem.cpp: Added.
              (WebCore::filenameFromString):
              * platform/FileSystem.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae9d1dd5
    • mthole@apple.com's avatar
      When using a scale factor > 1, scrollbars sometimes appear when not necessary · 54bb90b8
      mthole@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39458
      
      Reviewed by Dave Hyatt.
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
      so that they can be compared against the integral document size.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54bb90b8
    • eric@webkit.org's avatar
      2010-05-20 Young Han Lee <joybro@company100.net> · 8a760e02
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Port SharedBuffer to POSIX.
              https://bugs.webkit.org/show_bug.cgi?id=39283
      
              * platform/posix/SharedBufferPOSIX.cpp: Added.
              (WebCore::SharedBuffer::createWithContentsOfFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a760e02
    • eric@webkit.org's avatar
      2010-05-20 Zhenyao Mo <zmo@google.com> · d687633b
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
              * fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * src/WebGraphicsContext3DDefaultImpl.cpp:
              (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d687633b
    • mitz@apple.com's avatar
      <rdar://problem/8007953> Textarea using custom font appears blank · 55bf8727
      mitz@apple.com authored
      Reviewed by Dave Hyatt.
      
      WebCore: 
      
      Test: fast/css/font-face-in-shadow-DOM.html
      
      When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
      RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
      RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
      styles that still reference the placeholder font.
      
      The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
      true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
      
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
      * rendering/RenderButton.h:
      (WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
      * rendering/RenderDataGrid.h:
      (WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
      * rendering/RenderFileUploadControl.h:
      (WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
      * rendering/RenderListItem.h:
      (WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMedia.h:
      (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMenuList.h:
      (WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
      * rendering/RenderProgress.h:
      (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
      * rendering/RenderSlider.h:
      (WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
      * rendering/RenderTextControl.h:
      (WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
      
      LayoutTests: 
      
      * fast/css/font-face-in-shadow-DOM.html: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55bf8727
    • jer.noble@apple.com's avatar
      No review; build fix only. · 7ec68a55
      jer.noble@apple.com authored
      When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
      must include CoreGraphics/CGContext.h.
      
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ec68a55
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · a3dd3427
      mrobinson@webkit.org authored
              Not reviewed.
      
              Tests that use Geolocation.getCurrentPosition fail
              https://bugs.webkit.org/show_bug.cgi?id=39454
      
              * platform/gtk/Skipped: Skip failing tests until this bug is resolved.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3dd3427
    • jer.noble@apple.com's avatar
      2010-05-20 Jer Noble <jer.noble@apple.com> · 657a41a2
      jer.noble@apple.com authored
              Reviewed by Sam Weinig.
      
              Video elements show no video on Windows machines that do not support accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=39446
              rdar://problem/7999794
      
              Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext.  The visual context should
              be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and 
              tearDownVideoRendering, which won't get called in a non-accelerated compositing case).
              
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      657a41a2
    • victorw@chromium.org's avatar
      2010-05-20 Abhishek Arya <inferno@chromium.org> · 96b6e18b
      victorw@chromium.org authored
              Reviewed by Adam Barth.
      
              Added method to WebSecurityOrigin for invoking
              SecurityOrigin::canAccessPasswordManager.
              https://bugs.webkit.org/show_bug.cgi?id=38916
      
              * public/WebSecurityOrigin.h:
              * src/WebSecurityOrigin.cpp:
              (WebKit::WebSecurityOrigin::canAccessPasswordManager):
      2010-05-20  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Added a method to check if the security origin can access
              password manager.
              https://bugs.webkit.org/show_bug.cgi?id=38916
      
              * page/SecurityOrigin.h:
              (WebCore::SecurityOrigin::canAccessPasswordManager):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b6e18b
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · a9776086
      victorw@chromium.org authored
              Unreviewed. Update test expectations for chromium.
      
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9776086
    • darin@apple.com's avatar
      2010-05-20 Darin Adler <darin@apple.com> · 1ec7cbbc
      darin@apple.com authored
              Reviewed by Eric Seidel.
      
              Fix warnings seen on the buildbots today
              https://bugs.webkit.org/show_bug.cgi?id=39368
      
              * profiler/ProfileNode.cpp:
              (JSC::getCount): Removed unneeded initialization of global variable.
              These are all initialized to zero anyway, so no need to try to initialize
              it and get a warning.
      
              * wtf/CurrentTime.cpp:
              (WTF::currentTime): Removed unused global variable.
      2010-05-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Fix warnings seen on the buildbots today
              https://bugs.webkit.org/show_bug.cgi?id=39368
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for
              things being printed with "%lli". There is no guaranteed that int64_t is the
              same thing as long long.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested
              by warnings in newer versions of GCC.
      
              * platform/ContextMenu.cpp: Fix #if around the functions to match the #if
              around the call sites to avoid unused function warning.
      
              * platform/graphics/gtk/ImageGtk.cpp:
              (WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list
              rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline
              is incorrect and won't work properly.
      
              * platform/win/SystemTimeWin.cpp:
              (WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.
      
              * platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style.
              Made functions inline instead of static. It's not correct to have functions with
              internal linkage in a header file. Marking them inline makes more sense.
      
              * plugins/win/PluginMessageThrottlerWin.cpp:
              (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the
              initializers to match the order of the data members from the class definition.
      
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields
              of WINDOWPOS. I know this goes against the traditions of Windows programming,
              but it's correct and silences the warning. Also removed the unneeded separate
              code path for non-WinCE platforms that translates only the corner of the window
              rectangle; the WinCE version is correct for normal Windows as well. Not sure
              why this wasn't caught when the code was originally checked in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ec7cbbc
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · d07f9bea
      mrobinson@webkit.org authored
              Not reviewed.
      
              https://bugs.webkit.org/show_bug.cgi?id=39388
              Re-enable geolocation tests on GTK+ now that this bug is closed.
      
              * platform/gtk/Skipped: Re-enable geolocation tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d07f9bea
    • yaar@chromium.org's avatar
      2010-05-20 Justin Schuh <jschuh@chromium.org> · 37eb477c
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-20  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eb477c
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · 333ad92d
      kdecker@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=39441
              <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
              <rdar://problem/7986109> Youtube video controller UI entirely missing
              <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
               it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
               factors this assumption is false. Accordingly we now convert to the window contentView
              coordinate system when computing bounds in "window" and the visible rect.
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      333ad92d
    • aroben@apple.com's avatar
      Fix an HRGN leak in WKCACFLayerRenderer · 9af8414b
      aroben@apple.com authored
      Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
      (r53686-r55990): Graphics corruption when watching video (affects
      youtube.com)
      
      Reviewed by Darin Adler.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
      That way we don't have to remember to destroy it (as we were
      forgetting to do) when we bail out of this function early.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9af8414b
    • ggaren@apple.com's avatar
      2010-05-20 Geoffrey Garen <ggaren@apple.com> · 544432d4
      ggaren@apple.com authored
              Reviewed by Darin Adler.
      
              Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
              local variable in the Interpreter.
              https://bugs.webkit.org/show_bug.cgi?id=39447
      
              Small speedup on SunSpider in Interpreter mode.
      
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::privateExecute):
              * jsc.cpp:
              * wtf/Platform.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      544432d4
    • darin@chromium.org's avatar
      2010-05-20 Darin Fisher <darin@chromium.org> · 2bb6803c
      darin@chromium.org authored
              Reviewed by Nate Chapin.
      
              [chromium] Provide a way to catch exceptions thrown while interacting
              with a NPObject via WebBindings methods.
              https://bugs.webkit.org/show_bug.cgi?id=39378
      
              This change also includes a small bit of cleanup in V8NPObject and
              friends.  I moved code into the WebCore namespace where appropriate.
              
              In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
              context scope.  I did this to avoid having nested ExceptionCatcher
              objects, which is not strictly necessary, but it seemed cleaner.
              _NPN_Evaluate already takes care of creating a context scope.
      
              * bindings/v8/NPV8Object.cpp:
              (WebCore::v8ObjectToNPObject):
              (WebCore::npCreateV8ScriptObject):
              (_NPN_Invoke):
              (_NPN_InvokeDefault):
              (_NPN_Evaluate):
              (_NPN_EvaluateHelper):
              (_NPN_GetProperty):
              (_NPN_SetProperty):
              (_NPN_RemoveProperty):
              (_NPN_HasProperty):
              (_NPN_HasMethod):
              (_NPN_SetException):
              (_NPN_Enumerate):
              (_NPN_Construct):
              * bindings/v8/NPV8Object.h:
              * bindings/v8/V8NPObject.cpp:
              * bindings/v8/V8NPObject.h:
              * bindings/v8/V8NPUtils.cpp:
              (WebCore::convertV8ObjectToNPVariant):
              (WebCore::pushExceptionHandler):
              (WebCore::popExceptionHandler):
              (WebCore::ExceptionCatcher::ExceptionCatcher):
              (WebCore::ExceptionCatcher::~ExceptionCatcher):
              * bindings/v8/V8NPUtils.h:
              * bindings/v8/npruntime.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bb6803c