1. 04 Sep, 2009 33 commits
    • hyatt@apple.com's avatar
      Remove unused m_sheet variable and setCSSStyleSheet methods. · 632f2238
      hyatt@apple.com authored
      Reviewed by Anders Carlsson.
      
      * dom/Document.cpp:
      * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      632f2238
    • andersca@apple.com's avatar
      (Based on a patch from Adele). · 28eddcfe
      andersca@apple.com authored
              
      Reviewed by David Hyatt and Adele Peterson.
      
      Fix <rdar://problem/7185875>.
              
      * page/Frame.cpp:
      (WebCore::Frame::setView):
      Detach any custom scroll bars from the old view.
              
      * page/FrameView.cpp:
      (WebCore::FrameView::detachCustomScrollbars):
      Simplify the check (and make it work when body is null) by just checking that the scroll bar owner is
      not a RenderPart object.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::destroy):
      ASSERT that frame() is not null here and also add a null check so that release builds won't crash.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28eddcfe
    • hyatt@apple.com's avatar
      Make m_userStyleSheetLoader in Frame an OwnPtr. · 39313aa4
      hyatt@apple.com authored
      Reviewed by Adam Roben.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::~Frame):
      * page/Frame.h:
      * page/mac/FrameMac.mm:
      (WebCore::Frame::setUserStyleSheetLocation):
      (WebCore::Frame::setUserStyleSheet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39313aa4
    • darin@apple.com's avatar
      DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32) · 8a1a5b5c
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28909
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-04
      Reviewed by Geoff Garen.
      
      Part two.
      
      Make some improvements to garbage collection code:
      
          1) Create a runtime assertion that catches any classes that
             override markChildren but have the HasDefaultMark bit set.
          2) Remove checks of the mark bit outside the MarkStack::append
             function; they are redundant.
          3) Improve the efficiency of the asObject and asArray functions
             when called on JSCell* to avoid a round trip to JSValue.
          4) Make more callers use the checked asCell and asObject
             casting functions rather than unchecked casts.
          5) Removed the JSCell::marked function and other GC-related
             functions because these operations are no longer things that
             code other than the core GC code needs to do directly. Fixed
             callers that were calling them.
      
      * runtime/Collector.cpp:
      (JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
      (JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
      bit and call to MarkStack::drain.
      (JSC::Heap::collect): Removed unneeded checks of the mark bit and also
      changed call to SmallStrings::mark to call markChildren instead to match
      the rest of the objects.
      (JSC::typeName): Removed unneeded cast to JSObject*.
      
      * runtime/JSArray.h:
      (JSC::asArray): Added an overload for JSCell* and changed the JSValue
      version to call it. Removed some unneeded casts.
      (JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
      a header, and if not marked inline this could lead to linking problems.
      (JSC::MarkStack::markChildren): Added. This helper function is used by
      the drain function to avoid repating code. Also added the code here to
      check fro default mark violations in debug code. If a markChildren
      function adds something to the mark stack, but the type info claimed
      hasDefaultMark was true, then we will get an assertion now. Also fixed
      the assertion about the mark bit to use the Heap function directly
      because we don't have a JSCell::marked function any more.
      (JSC::MarkStack::drain): Changed a local variable from "v" to "value",
      and from "currentCell" to "cell". Changed to call markChildren in two
      places instead of repeating a chain of if statements twice. Changed
      code that reads and writes the mark bit to use Heap::isCellMarked and
      Heap::markCell so we can eliminate the JSCell::marked and
      JSCell::markCellDirect functions.
      
      * runtime/JSCell.h: Removed JSCell's markCellDirect and marked member
      functions. Added a comment explaining that asCell should be deprecated
      in favor of the JSValue asCell member function.
      (JSC::MarkStack::append): Added the assertion that catches callers
      that have set the HasDefaultMark bit incorrectly. Changed
      code that reads and writes the mark bit to use Heap::isCellMarked and
      Heap::markCell so we can eliminate the JSCell::marked and
      JSCell::markCellDirect functions. Moved the overload of
      MarkStack::append for JSValue here so it can call through to the cell
      version. The old version had a copy of all the code instead, but that
      repeated the conversion from JSValue to JSCell* and the check for
      whether a value is a cell multiple times.
      (JSC::Structure::markAggregate): Moved this function here to avoid
      dependencies for Structure.h, since this calls MarkStack::append.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::markChildren): Added code to clear
      m_isCheckingForDefaultMarkViolation so the marking done by JSObject
      doesn't trigger the assertion.
      
      * runtime/JSValue.h: Moved some stray includes that were outside the
      header guard inside it. Not sure how that happened! Removed the
      GC-related member functions markChildren, hasChildren, marked, and
      markDirect.
      
      * runtime/JSWrapperObject.h: Made markChildren private.
      (JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
      HasDefaultMark bit was set.
      
      * runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and
      initialized it to false. Moved the append function body from here to
      JSCell.h. Added a declaration of a private markChildren function used
      inside the drain function.
      
      * runtime/SmallStrings.cpp:
      (JSC::SmallStrings::markChildren): Changed the name and style of this
      function to match other functions. This allows us to share the normal
      mark stack code path.
      
      * runtime/SmallStrings.h: Changed the name and interface of mark to
      the more-normal markChildren style.
      
      * runtime/Structure.h: Moved the body of markAggregate into the
      JSCell.h to avoid a circular dependency with JSCell.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a1a5b5c
    • darin@apple.com's avatar
      JavaScriptCore: DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32) · 9fb218be
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28909
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-04
      Reviewed by Geoff Garen.
      
      Part one.
      
      Make some improvements to garbage collection code:
      
          1) Fix the two classes that had the default mark bit set but
             should not.
          2) Remove checks of the mark bit outside the MarkStack::append
             function; they are redundant.
          3) Make more callers use the checked asCell and asObject
             casting functions rather than unchecked casts.
          4) Removed some GC-related functions because these operations are
             no longer things that code other than the core GC code needs
             to do directly. Fixed callers that were calling them.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
      bit before calling MarkStack::append.
      
      * interpreter/Register.h: Removed unneeded marked and markChildren
      functions.
      
      * jit/JITStubs.cpp:
      (op_eq): Removed unneeded assertions, instead using checked casting
      functions such as asObject.
      
      * runtime/ArgList.h: Added now-needed forward declaration of MarkStack.
      
      * runtime/GetterSetter.cpp:
      (JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.
      
      * runtime/GlobalEvalFunction.h:
      (JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
      HasDefaultMark bit was set.
      
      * runtime/JSCell.cpp:
      (JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.
      
      * runtime/JSObject.h:
      (JSC::asObject): Added an overload for JSCell* and changed the JSValue
      version to call it.
      (JSC::JSValue::get): Use asObject to avoid a direct static_cast.
      
      * runtime/JSValue.h: Moved some stray includes that were outside the
      header guard inside it. Not sure how that happened! Removed the
      GC-related member functions markChildren, hasChildren, marked, and
      markDirect.
      
      * runtime/JSWrapperObject.h: Made markChildren private.
      (JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
      HasDefaultMark bit was set. Later we may want to optimize this for
      wrapper types that never have cells in their internal values, but there
      is no measured performance regression in SunSpider or V8 doing this
      all the time.
      
      * runtime/MarkStack.cpp: Tweaked formatting.
      
      JavaScriptGlue: * JSValueWrapper.cpp:
      (JSValueWrapper::JSObjectMark): Removed a check of the mark
      bit. It's OK to do more work in this case, and there is no
      longer a public function to access the mark bit.
      
      Reviewed by Geoff Garen.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fb218be
    • kevino@webkit.org's avatar
      wx build fix. Switch USE_ defines over to the compiler so that they can be · 7eae4dec
      kevino@webkit.org authored
      checked by files not including config.h (like WebCorePrefix.h).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eae4dec
    • timothy@apple.com's avatar
      Show color swatches in the Web Inspector before the color text so clicking them will not · acad015d
      timothy@apple.com authored
      shift the swatch. Also makes multiple swatches in the single property toggle the color format.
      
      https://bugs.webkit.org/show_bug.cgi?id=28978
      
      Reviewed by Darin Adler.
      
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Some refactoring to consolidate
      the processing we do on the property value. This eliminated the old nickname code, since the new
      WebInspector.Color class handles this. We could also simplify the color regex since more
      is handled by the Color class. Also no longer uses innerHTML for the linkify code.
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processValue): Helper function to
      process a value given a regex and processor functions.
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): Make an anchor for the
      URL with "url()" syntax surrounding it.
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Makes a color, if
      there was an exception just return a text node.
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay.changeTo):
      Moved from later in the file.
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay): Ditto.
      * inspector/front-end/inspector.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acad015d
    • dglazkov@chromium.org's avatar
      WebCore: · f0234eb3
      dglazkov@chromium.org authored
      2009-09-04  Mark Mentovai  <mark@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=28614
      
              Account for scrollbar state changes that occur during layout.
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::updateScrollbars):
      
              Perform a layout prior to checking whether the scrollbar modes are
              off, on, or automatic.  The modes may change during layout.
      
              * WebCore.base.exp:
              * WebCore.order:
              * page/Frame.cpp:
              (WebCore::Frame::createView):
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView):
              (WebCore::FrameView::resetScrollbars):
              (WebCore::FrameView::layout):
              * page/FrameView.h:
              * platform/ScrollView.h:
      
              Eliminate duplicated (and incorrect) scrollbar mode tracking between
              FrameView and ScrollView.
      
      WebKit/mac:
      
      2009-09-04  Mark Mentovai  <mark@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=28614
      
              Account for scrollbar state changes that occur during layout.
      
              * WebView/WebDynamicScrollBarsView.mm:
              (-[WebDynamicScrollBarsView updateScrollers]):
      
              Perform a layout prior to checking whether the scrollbar modes are
              off, on, or automatic.  The modes may change during layout.
      
              * WebView/WebFrameView.mm:
              (-[WebFrameView _install]):
      
              Eliminate duplicated (and incorrect) scrollbar mode tracking between
              FrameView and ScrollView.
      
      WebKit/qt:
      
      2009-09-04  Mark Mentovai  <mark@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=28614
      
              Account for scrollbar state changes that occur during layout.
      
              * Api/qwebframe.cpp:
              (QWebFrame::setScrollBarPolicy):
      
              Eliminate duplicated (and incorrect) scrollbar mode tracking between
              FrameView and ScrollView.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0234eb3
    • yael.aharon@nokia.com's avatar
      WebCore: hostname and host are mixed up when manipulating anchor elements. · 45792870
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28954
      
      Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-04
      Reviewed by Darin Adler.
      
      Swapped the implementation of host and hostname, and made sure not to return
      the port number if it is default for the given protocol. 
      FireFox also avoids returning the protocol number if it is default.
      
      Test: fast/dom/Element/hostname-host.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45792870
    • andersca@apple.com's avatar
      Fix <rdar://problem/7192902>. · dce1aa69
      andersca@apple.com authored
      Reviewed by Darin Adler and Steve Falkenburg.
      
      Add the necessary plumbing for having QTMovieWin use WebCore timers.
              
      * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
      (WebCore::TaskTimer::initialize):
      Create the timer and call QTMovieWin::setTaskTimerFuncs.
              
      (WebCore::TaskTimer::setTaskTimerDelay):
      Start the timer.
              
      (WebCore::TaskTimer::stopTaskTimer):
      Stop the timer.
              
      (WebCore::TaskTimer::fired):
      Call QTMovieWin::taskTimerFired().
              
      (WebCore::MediaPlayerPrivate::load):
      Initialize the Task timer.
              
      * platform/graphics/win/QTMovieWin.cpp:
      (updateTaskTimer):
      Call the global stopTaskTimer function and setTaskTimerDelay.
              
      (QTMovieWin::taskTimerFired):
      Make this a member function.
              
      (QTMovieWin::setTaskTimerFuncs):
      Set the global function pointers.
              
      (QTMovieWin::initializeQuickTime):
      (DllMain):
      No need to use the QT shared timer.
      * platform/graphics/win/QTMovieWin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dce1aa69
    • levin@chromium.org's avatar
      Fix Chromium Win compile. Missing return statement in · 8ff0102f
      levin@chromium.org authored
      WebCore::RenderThemeChromiumSkia::paintSliderThumb.
      https://bugs.webkit.org/show_bug.cgi?id=28974
      
      Patch by Tony Chang <tony@chromium.org> on 2009-09-04
      Reviewed by David Levin.
      
      No new tests, build fix.
      
      * rendering/RenderThemeChromiumSkia.cpp:
      (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ff0102f
    • aroben@apple.com's avatar
      Make WebView function without a parent window · 6bd487d1
      aroben@apple.com authored
      When WebView has no parent window, it becomes a message-only window,
      which hides it from the screen and prevents it from appearing on the
      taskbar.
      
      Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
      WebView::initWithFrame fails if there's no host window
      
      Reviewed by Dave Hyatt.
      
      * WebView.cpp:
      (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
      our parent window, which will make us a message-only window.
      (WebView::setHostWindow): If he new host window is null, use
      HWND_MESSAGE as our parent window, which will make us a message-only
      window.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bd487d1
    • dglazkov@chromium.org's avatar
      2009-09-04 Dimitri Glazkov <dglazkov@chromium.org> · a893c4b3
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              [Chromium] Rolling out http://trac.webkit.org/changeset/48035, because it broke
              the build.
              https://bugs.webkit.org/show_bug.cgi?id=28696
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a893c4b3
    • andersca@apple.com's avatar
      Fix vcproj file. · 266e3cea
      andersca@apple.com authored
      * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      266e3cea
    • hyatt@apple.com's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work. · 71960d78
      hyatt@apple.com authored
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * WebCore.base.exp:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      * bindings/js/ScriptController.h:
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      * bindings/v8/ScriptController.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::finishedParsing):
      (WebCore::FrameLoader::dispatchDocumentElementAvailable):
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::injectUserScriptsForWorld):
      * page/Frame.h:
      * page/PageGroup.cpp:
      (WebCore::PageGroup::~PageGroup):
      (WebCore::PageGroup::addUserScript):
      (WebCore::PageGroup::removeUserContentForWorld):
      (WebCore::PageGroup::removeAllUserContent):
      * page/PageGroup.h:
      (WebCore::PageGroup::userScripts):
      * page/UserScript.h: Added.
      (WebCore::UserScript::UserScript):
      (WebCore::UserScript::source):
      (WebCore::UserScript::url):
      (WebCore::UserScript::patterns):
      (WebCore::UserScript::worldID):
      (WebCore::UserScript::injectionTime):
      * page/UserScriptTypes.h: Added.
      (WebCore::):
      
      WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * WebView/WebView.mm:
      (+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
      (+[WebView _removeUserContentFromGroup:worldID:]):
      (+[WebView _removeAllUserContentFromGroup:]):
      * WebView/WebViewPrivate.h:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * platform/mac/userscripts: Added.
      * platform/mac/userscripts/script-run-at-end-expected.txt: Added.
      * userscripts: Added.
      * userscripts/script-run-at-end.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71960d78
    • abarth@webkit.org's avatar
      Added missing ; · 96360249
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96360249
    • ap@apple.com's avatar
      Reviewed by Eric Seidel. · 7e34543c
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=26402
              Crashes when using a detached DocumentType node
      
              Test: fast/dom/DOMImplementation/detached-doctype.html
      
              DocumentType nodes are the only one that can have null document(), and they can never have
              children, so they are a degenerate case for NodeLists.
      
              * dom/Node.cpp:
              (WebCore::Node::childNodes): Don't try register node list with document if there's no
              document. Since there are no changes possible for a DocumentType's node list, this is not
              necessary.
              (WebCore::Node::registerDynamicNodeList): Ditto.
              (WebCore::Node::unregisterDynamicNodeList): Ditto. I couldn't find a scenario where this
              was invoked for a DocumentType node, but I also couldn't prove that it can't be (the
              de-registration code path that I saw taken was via Node destructor, and that already has
              a null check for document).
      
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::addEventListener): Bail out if there is no document (just as we already do
              if there is no window).
              (WebCore::JSNode::removeEventListener): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e34543c
    • abarth@webkit.org's avatar
      2009-09-04 Adam Barth <abarth@webkit.org> · 99e9942e
      abarth@webkit.org authored
              Unreviewed attempt at a build fix.
      
              Added missing include.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99e9942e
    • abarth@webkit.org's avatar
      2009-09-04 Adam Barth <abarth@webkit.org> · c88c9502
      abarth@webkit.org authored
              Unreviewed attempt at a build fix.
      
              Fix typo of IWebFrameLoadDelegatePrivate2 and make
              IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
              as requestd by Adam Roben.
      
              * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
      2009-09-04  Adam Barth  <abarth@webkit.org>
      
              Unreviewed build fix.
      
              Update declaration of FrameLoadDelegate to reflect that
              IWebFrameLoadDelegatePrivate2 inherits from
              IWebFrameLoadDelegatePrivate.
      
              * DumpRenderTree/win/FrameLoadDelegate.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c88c9502
    • vestbo@webkit.org's avatar
      [Qt] Fix brainfart in r48050, tests should have paths · 2dbb5378
      vestbo@webkit.org authored
      Rubber-stamped by Simon Hausmann.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dbb5378
    • abarth@webkit.org's avatar
      2009-09-04 Adam Barth <abarth@webkit.org> · 92c46c18
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Plumb mixed content notifications to WebFrameLoadDelegatePrivate.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
              * WebView/WebDelegateImplementationCaching.h:
              * WebView/WebFrameLoadDelegatePrivate.h: Added.
      2009-09-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
      
              * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
              * Interfaces/WebKit.idl:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
              * WebKit.vcproj/Interfaces.vcproj:
      2009-09-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Add testing instrumentation for mixed content.
      
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate webView:]):
              (-[FrameLoadDelegate webView:didRunInsecureContent:]):
              * DumpRenderTree/win/FrameLoadDelegate.cpp:
              (descriptionSuitableForTestResult):
              (FrameLoadDelegate::QueryInterface):
              (FrameLoadDelegate::didDisplayInsecureContent):
              (FrameLoadDelegate::didRunInsecureContent):
              * DumpRenderTree/win/FrameLoadDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c46c18
    • vestbo@webkit.org's avatar
      [Qt] Skip tests failing due to missing DRT features · afc5012e
      vestbo@webkit.org authored
      Rubber-stamped by Simon Hausmann.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afc5012e
    • xan@webkit.org's avatar
      2009-09-04 Xan Lopez <xlopez@igalia.com> · a44d6909
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] loadFinished never emitted
              https://bugs.webkit.org/show_bug.cgi?id=28935
      
              Do not report errors right away from
              ResourceHandle::start. Instead return true and schedule an error
              to be reported in the handle later. Otherwise WebCore gets
              confused and thinks the resource never finished loading, making it
              not emit the finished status.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::startHttp):
              (WebCore::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a44d6909
    • yong.li@torchmobile.com's avatar
      2009-09-03 Yong Li <yong.li@torchmobile.com> · 4b19d5f3
      yong.li@torchmobile.com authored
              Reviewed by David Levin.
      
              Remove unnecessary dependency on unistd.h
              https://bugs.webkit.org/show_bug.cgi?id=28962
      
              * runtime/Completion.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b19d5f3
    • eric@webkit.org's avatar
      2009-09-04 Ben Murdoch <benm@google.com> · 77397fa0
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [V8] DOM Storage bindings: Event Handler should create StorageEvents
              https://bugs.webkit.org/show_bug.cgi?id=28942
      
              Tests:
              Causes the following tests that were failing with V8 to pass:
              * storage/domstorage/localstorage/onstorage-attribute-setwindow.html
              * storage/domstorage/localstorage/complex-keys.html
              * storage/domstorage/localstorage/onstorage-attribute-markup.html
              * storage/domstorage/localstorage/simple-events.html
              * storage/domstorage/localstorage/onstorage-attribute-set-attribute.html
              * storage/domstorage/localstorage/index-get-and-set.html
              * storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html
              * storage/domstorage/sessionstorage/onstorage-attribute-markup.html
              * storage/domstorage/sessionstorage/simple-events.html
              * storage/domstorage/sessionstorage/onstorage-attribute-set-attribute.html
              * storage/domstorage/sessionstorage/index-get-and-set.html
      
              Code changes:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::convertEventToV8Object):  Create StorageEvents.
              * bindings/v8/custom/V8StorageCustom.cpp:
              (WebCore::storageGetter): Check if we are retrieving the length property and return the number of items in the object rather than a property named length when invoking the getItem() member of local/sessionStorage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77397fa0
    • pfeldman@chromium.org's avatar
      2009-09-03 Pavel Feldman <pfeldman@chromium.org> · ff3036ce
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=28911
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::dispatchOnInjectedScript):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.doEvalInWindow):
              (WebInspector.ConsoleView.prototype._formatarray):
              (WebInspector.ConsoleView.prototype._formatnode):
              * inspector/front-end/DOMAgent.js:
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
              (WebInspector.ElementsPanel.prototype.searchCanceled):
              (WebInspector.ElementsPanel.prototype.performSearch):
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.dispatch):
              * inspector/front-end/InjectedScriptAccess.js: Added.
              (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
              (InjectedScriptAccess._installHandler):
              * inspector/front-end/MetricsSidebarPane.js:
              (WebInspector.MetricsSidebarPane.prototype.update):
              (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
              * inspector/front-end/ObjectPropertiesSection.js:
              (WebInspector.ObjectPropertiesSection.prototype.update):
              (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
              (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
              * inspector/front-end/PropertiesSidebarPane.js:
              (WebInspector.PropertiesSidebarPane.prototype.update):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.update):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
              (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted):
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/inspector.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff3036ce
    • eric@webkit.org's avatar
      2009-09-04 Tony Chang <tony@chromium.org> · d6bb514d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement <input type="range"> for Chromium Linux by painting
              the slider and the thumb using skia.
              https://bugs.webkit.org/show_bug.cgi?id=28928
      
              Covered by existing tests (we're currently hitting an assert for them).
      
              * rendering/RenderThemeChromiumLinux.cpp:
              (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
              * rendering/RenderThemeChromiumLinux.h:
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::drawVertLine):
              (WebCore::drawHorizLine):
              (WebCore::drawBox):
              (WebCore::RenderThemeChromiumSkia::paintSliderTrack):
              (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
              * rendering/RenderThemeChromiumSkia.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6bb514d
    • eric@webkit.org's avatar
      2009-09-04 Albert Bachand <albertb@google.com> · 35f825bb
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Modify the condition regarding the key modifier for opening combo
              boxes under GTK from just PLATFORM(GTK) to also look for
              (PLATFORM(CHROMIUM) && PLATFORM(LINUX)).
      
              * WebCore/dom/SelectElement.cpp:
              * WebCore/manual-tests/select-popup-on-spacebar.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f825bb
    • eric@webkit.org's avatar
      2009-09-04 Kent Tamura <tkent@chromium.org> · 56812540
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Tests for <input type=color> validation.
              https://bugs.webkit.org/show_bug.cgi?id=28966
      
              * fast/forms/ValidityState-patternMismatch-unsupported-expected.txt: Added.
              * fast/forms/ValidityState-patternMismatch-unsupported.html: Added.
              * fast/forms/ValidityState-typeMismatch-color-expected.txt: Added.
              * fast/forms/ValidityState-typeMismatch-color.html: Added.
              * fast/forms/resources/ValidityState-patternMismatch-unsupported.js: Added.
              * fast/forms/resources/ValidityState-typeMismatch-color.js: Added.
      2009-09-04  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              - Implement <input type=color> as a text field.
              - ValidityState::typeMismatch supports for type=color.
              https://bugs.webkit.org/show_bug.cgi?id=28966
      
              Tests: fast/forms/ValidityState-patternMismatch-unsupported.html
                     fast/forms/ValidityState-typeMismatch-color.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::valueMissing):
              (WebCore::HTMLInputElement::patternMismatch):
              (WebCore::HTMLInputElement::setInputType):
              (WebCore::HTMLInputElement::formControlType):
              (WebCore::HTMLInputElement::saveFormControlState):
              (WebCore::HTMLInputElement::restoreFormControlState):
              (WebCore::HTMLInputElement::accessKeyAction):
              (WebCore::HTMLInputElement::rendererIsNeeded):
              (WebCore::HTMLInputElement::createRenderer):
              (WebCore::HTMLInputElement::appendFormData):
              (WebCore::HTMLInputElement::valueWithDefault):
              (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
              (WebCore::HTMLInputElement::defaultEventHandler):
              (WebCore::HTMLInputElement::isRequiredFormControl):
              (WebCore::HTMLInputElement::dataList):
              * html/HTMLInputElement.h:
              (WebCore::HTMLInputElement::):
              (WebCore::HTMLInputElement::isTextField):
              * html/ValidityState.cpp:
              (WebCore::ValidityState::typeMismatch):
              (WebCore::ValidityState::isValidColorString):
              * html/ValidityState.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56812540
    • levin@chromium.org's avatar
      [V8] Crash when updating document cache · b8c9e0df
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28965
      
      Patch by Mads Ager <ager@chromium.org> on 2009-09-04
      Reviewed by David Levin.
      
      Initialization of a V8 JavaScript context can fail.  When that
      happens, do not attempt to update the document wrapper cache.
      
      This code path is exercised by http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html.
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::updateDocument):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8c9e0df
    • eric@webkit.org's avatar
      2009-09-04 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 166016a5
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] Fix tst_QWebPage::database autotest failure
              https://bugs.webkit.org/show_bug.cgi?id=28961
      
              Make sure that the test case enables the feature before
              the feature gets tested
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::database):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      166016a5
    • eric@webkit.org's avatar
      2009-09-04 Yaar Schnitman <yaar@chromium.org> · 88886437
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Two bugs:
      
              https://bugs.webkit.org/show_bug.cgi?id=25489
              CSS property background-position is now serialized in shorthand string as
              background-position-x background-position-y, as the specification requires
              (See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).
      
              https://bugs.webkit.org/show_bug.cgi?id=26541
              CSS background-color is now be serialized before other background properties,
              as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).
      
              An existing layout test that accepted wrong order and skipped position test
              had to be modified.
      
              * fast/dom/background-shorthand-csstext-expected.txt:
              * fast/dom/background-shorthand-csstext.html:
      2009-09-04  Yaar Schnitman  <yaar@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Two bugs:
      
              https://bugs.webkit.org/show_bug.cgi?id=25489
              CSS property background-position is now serialized in shorthand string as
              background-position-x background-position-y, as the specification requires
              (See http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-background-position).
      
              https://bugs.webkit.org/show_bug.cgi?id=26541
              CSS background-color is now be serialized before other background properties,
              as CSS specification requires (See http://dev.w3.org/csswg/cssom/#css-value).
      
              An existing layout test that accepted wrong order and skipped position test
              had to be modified.
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88886437
    • eric@webkit.org's avatar
      2009-09-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com> · b94d1c6c
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Any QtWebKit application crashes on exit if the inspector is
              used during the session rather then exiting.
      
              If a QWebView has a QWebPage that is destroyed the QWebView
              does not update its pointer and will crash the next time
              it access the page pointers (such as in its destructor).
      
              InspectorClientView should not call deleteLater when the page
              is destroyed because it does not have a parent and is a top
              level widget.  close() needs to be called so that QApplication
              can exit the application if quitOnLastWindowClosed is set
              and a InspectorClientView is the last window, otherwise
              the application will never exit.
      
              * Api/qwebview.cpp:
              (QWebViewPrivate::_q_pageDestroyed):
              (QWebView::setPage):
              * Api/qwebview.h:
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientView::InspectorClientView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b94d1c6c
  2. 03 Sep, 2009 7 commits
    • eric@webkit.org's avatar
      2009-09-03 Kent Tamura <tkent@chromium.org> · f3cf6a54
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Test for HTMLTextAreaElement.textLength
              https://bugs.webkit.org/show_bug.cgi?id=28929
      
              * fast/forms/resources/textarea-textlength.js: Added.
              * fast/forms/textarea-textlength-expected.txt: Added.
              * fast/forms/textarea-textlength.html: Added.
      2009-09-03  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by David Levin.
      
              Add support for HTMLTextAreaElement.textLength
              https://bugs.webkit.org/show_bug.cgi?id=28929
      
              Test: fast/forms/textarea-textlength.html
      
              * html/HTMLTextAreaElement.h:
              (WebCore::HTMLTextAreaElement::textLength):
              * html/HTMLTextAreaElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3cf6a54
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · a34a697b
      ap@apple.com authored
              <rdar://problem/7180197>, https://bugs.webkit.org/show_bug.cgi?id=28822
              REGRESSION(r31231): Creating document with current document's DOCTYPE causes crashes
      
              Test: fast/dom/DOMImplementation/createDocument-with-used-doctype.html
      
              * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Even though we
              cannot raise an exception immediately out of fear of breaking Acid3, we shouldn't use a
              DocumentType node in two documents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a34a697b
    • beidson@apple.com's avatar
      WebCore: Page Cache should support pages with Frames. · 8c5ddbfe
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Sam Weinig.
      
      Tests: fast/events/pageshow-pagehide-on-back-cached-with-frames.html
             fast/loader/frames-with-unload-handlers-in-page-cache.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::canCachePageContainingThisFrame):
      (WebCore::FrameLoader::logCanCacheFrameDecision):
      
      LayoutTests: Page Cache should support pages with Frames.
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Sam Weinig.
      
      * fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
      * fast/events/pageshow-pagehide-on-back-cached-with-frames.html: Added.
      * fast/events/resources/pageshow-pagehide-subframe-cachable.html: Added.
      * fast/events/resources/pageshow-pagehide-subsubframe-cachable.html: Added.
      * fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
      * fast/loader/frames-with-unload-handlers-in-page-cache.html: Added.
      * fast/loader/resources/notify-done.html: Added.
      * fast/loader/resources/subframe-with-subsubframe-with-unload-handler.html: Added.
      * fast/loader/resources/subframe-with-unload-handler.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c5ddbfe
    • eric@webkit.org's avatar
      2009-09-03 Steve VanDeBogart <vandebo@chromium.org> · 8808efc1
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Check that middle click triggers an onpaste event in Linux.
              https://bugs.webkit.org/show_bug.cgi?id=28696
      
              * platform/gtk/editing/pasteboard: Added.
              * platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt: Added.
              * platform/gtk/editing/pasteboard/resources: Added.
              * platform/gtk/editing/pasteboard/resources/TEMPLATE.html: Added.
              * platform/gtk/editing/pasteboard/resources/middle-click-onpaste.js: Added.
              (handlePaste):
      2009-09-03  Steve VanDeBogart  <vandebo@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Handle middle click in Chromium like QT
              https://bugs.webkit.org/show_bug.cgi?id=28696
      
              Tested by middle-click-onpaste.html.
      
              * platform/Pasteboard.h:
              * platform/chromium/ChromiumBridge.h:
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::getData):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::Pasteboard):
              (WebCore::Pasteboard::isSelectionMode):
              (WebCore::Pasteboard::setSelectionMode):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PasteboardPrivate.h:
              (WebCore::PasteboardPrivate::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8808efc1
    • beidson@apple.com's avatar
      More partial work towards "Page Cache should support pages with Frames" · ecd58f67
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=13631
      
      Reviewed by Sam Weinig.
      
      Fix a bug where subframes weren't asked if they were cacheable.
      
      No new tests, especially since page caching for frames isn't turned on yet.
      A layout test will come in my next patch, which enables frames in the page cache.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::canCachePageContainingThisFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd58f67
    • abarth@webkit.org's avatar
      2009-09-03 Adam Barth <abarth@webkit.org> · 9e7b9fb3
      abarth@webkit.org authored
              Unreviewed build fix.
      
              Change notImplemented() to a FIXME.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e7b9fb3
    • abarth@webkit.org's avatar
      2009-09-03 Adam Barth <abarth@webkit.org> · 294986c3
      abarth@webkit.org authored
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Added mixed content methods to FrameLoaderClient.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::didDisplayInsecureContent):
              (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
              * loader/FrameLoaderClient.h:
      2009-09-03  Adam Barth  <abarth@webkit.org>
      
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Stub implementations of mixed content methods of FrameLoaderClient.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::didDisplayInsecureContent):
              (WebKit::FrameLoaderClient::didRunInsecureContent):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      2009-09-03  Adam Barth  <abarth@webkit.org>
      
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Stub implementations of mixed content methods of FrameLoaderClient.
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
      2009-09-03  Adam Barth  <abarth@webkit.org>
      
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Stub implementations of mixed content methods of FrameLoaderClient.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::didDisplayInsecureContent):
              (WebCore::FrameLoaderClientQt::didRunInsecureContent):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2009-09-03  Adam Barth  <abarth@webkit.org>
      
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Stub implementations of mixed content methods of FrameLoaderClient.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
              * WebCoreSupport/WebFrameLoaderClient.h:
      2009-09-03  Adam Barth  <abarth@webkit.org>
      
              Reviewed by eric@webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Stub implementations of mixed content methods of FrameLoaderClient.
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::didDisplayInsecureContent):
              (WebCore::FrameLoaderClientWx::didRunInsecureContent):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      294986c3