1. 05 Mar, 2008 35 commits
    • kevino@webkit.org's avatar
      Fix the wx build after the bindings move. · 62f191f2
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62f191f2
    • mitz@apple.com's avatar
      Reviewed by Adele Peterson. · 3190ea54
      mitz@apple.com authored
              - fix "background-position: inherit"
      
              * css/CSSStyleSelector.cpp:
              Made HANDLE_MULTILAYER_INHERIT_AND_INITIAL fall through and added
              a return statement in HANDLE_MULTILAYER_VALUE. Also removed an unused
              macro.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3190ea54
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · 814ceb77
      alp@webkit.org authored
              Add a missing make dependency for derived sources to improve
              autotools build dependency tracking.
      
              Issue spotted by Ori Bernstein.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      814ceb77
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · 29183505
      alp@webkit.org authored
              GTK+ build fix for breakage introduced in r30800.
      
              Track moved bridge sources from JavaScriptCore to WebCore.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29183505
    • justin.garcia@apple.com's avatar
      WebCore: · 6dc0b0a5
      justin.garcia@apple.com authored
              Reviewed by Darin.
      
              One part of fix for:
              <rdar://problem/5780697> Copying content with percentage based rules in a style sheet will cause fidelity issues
      
              * editing/markup.cpp:
              (WebCore::appendStartMarkup): Styles from matched rules should take precedence over those in
              inline style declarations, not the other way around. 
      
      LayoutTests:
      
              Reviewed by Darin.
              
              <rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues
      
              * editing/pasteboard/5780697-1-expected.txt: Added.
              * editing/pasteboard/5780697-1.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dc0b0a5
    • alp@webkit.org's avatar
      Another buildbot fix attempt, pass SHELL=/bin/bash · 857869ce
      alp@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      857869ce
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · ef4ce500
      alp@webkit.org authored
              Attempt to get the autotools build working again on the bot with
              build-webkit.
      
              Force the use of /bin/bash since we seem to have bash-isms in the
              configure script right now.
      
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef4ce500
    • mrowe@apple.com's avatar
      Fix typo in ChangeLog. · 49bca807
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49bca807
    • andersca@apple.com's avatar
      Reviewed by Darin. · 98601e46
      andersca@apple.com authored
              Move JNI specific code from runtime_root over to jni_jsobject, where it is used.
      
              * bridge/jni/jni_jsobject.cpp:
              (completedJavaScriptAccess):
              (initializeJavaScriptAccessLock):
              (lockJavaScriptAccess):
              (unlockJavaScriptAccess):
              (dispatchToJavaScriptThread):
              (performJavaScriptAccess):
              (JavaJSObject::initializeJNIThreading):
              (isJavaScriptThread):
              (JavaJSObject::invoke):
              * bridge/jni/jni_jsobject.h:
              * bridge/runtime_root.cpp:
              * bridge/runtime_root.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge init]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98601e46
    • darin@apple.com's avatar
      Reviewed by Sam. · e185d7c7
      darin@apple.com authored
              - add functions giving offsets within a KURL, slated to replace the
                EncodedURL object in CSSStyleSelector (in a future "visited link" change)
              - chagned all KURL data members names to use the traditional m_ prefix
              - initialize all members to 0 in invalid KURLs rather than having all
                functions check m_isValid
      
              * platform/KURL.cpp:
              (WebCore::KURL::invalidate): Added. Initializes all the fields except for
              m_string to the "invalid" values. For use in the empty constructor and
              in the init and parse functions.
              (WebCore::KURL::init): Tweaked comments. Changed all code paths that return
              early to use the invalidate() function. Updated for member variable name
              changes.
              (WebCore::KURL::hasPath): Updated for member variable name changes.
              Remove now-unneeded check of m_isValid.
              (WebCore::KURL::lastPathComponent): Ditto.
              (WebCore::KURL::protocol): Ditto.
              (WebCore::KURL::host): Ditto.
              (WebCore::KURL::port): Ditto.
              (WebCore::KURL::pass): Ditto.
              (WebCore::KURL::user): Ditto.
              (WebCore::KURL::ref): Ditto.
              (WebCore::KURL::hasRef): Ditto.
              (WebCore::KURL::protocolIs): Ditto.
              (WebCore::KURL::query): Ditto.
              (WebCore::KURL::path): Ditto.
              (WebCore::KURL::setProtocol): Ditto.
              (WebCore::KURL::setHost): Ditto.
              (WebCore::KURL::setPort): Ditto.
              (WebCore::KURL::setHostAndPort): Ditto.
              (WebCore::KURL::setUser): Ditto.
              (WebCore::KURL::setPass): Ditto.
              (WebCore::KURL::setRef): Ditto.
              (WebCore::KURL::setQuery): Ditto.
              (WebCore::KURL::setPath): Ditto.
              (WebCore::KURL::prettyURL): Ditto.
              (WebCore::copyPathRemovingDots): Removed braces to match our code style.
              (WebCore::KURL::parse): Changed all code paths that return early to use
              the invalidate function. Moved code to set m_isValid to true to the very
              end of the function. Removed braces to match our code style. Removed an
              extra copy of the path/query/fragment code (there were two identical copies
              in the two sides of an if statement). Removed some commented-out code.
              Reversed an if statment. Added code to set the new m_pathAfterLastSlash
              field. Updated for member variable name changes.
              (WebCore::equalIgnoringRef): Updated for member variable name changes.
              (WebCore::KURL::isHierarchical): Ditto.
      
              * platform/KURL.h: Added a FIXME about ref vs. fragment. Made the empty
              constructor inline and called the new invalidate function. Added new
              pathStart, pathEnd, and pathAfterLastSlash functions, for use in the
              new visited link code. Added an invalidate function. Renamed all the
              data members to use the m_ prefix.
      
              * WebCore.base.exp: Updated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e185d7c7
    • andersca@apple.com's avatar
      Reviewed by Sam. · ed5b3cb7
      andersca@apple.com authored
              * WebCore.xcodeproj/project.pbxproj:
              Change jni_jsobject.cpp to be Obj-C++ for now. The plan is to merge 
              this with jni_objc.mm and create jni_jsobject.mm.
              
              * bridge/jni/jni_jsobject.cpp:
              (createRootObject):
              Move createRootObject here from WebCoreFrameBridge.
              
              (JavaJSObject::createNative):
              Call the newly added createRootObject function.
              
              * bridge/runtime_root.cpp:
              (KJS::Bindings::RootObject::initializeJNIThreading):
              * bridge/runtime_root.h:
              setCreateRootObject no longer takes a root object, rename it to initializeJNIThreading.
      
              * page/mac/FrameMac.mm:
              (WebCore::Frame::createScriptInstanceForWidget):
              Just call Frame::createRootObject here.
              
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge init]):
              Call initializeJNIThreading.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed5b3cb7
    • andersca@apple.com's avatar
      Reviewed by Sam. · 873ec6a0
      andersca@apple.com authored
              Change some static class variables to be regular static variables,
              making it easier to move the chunk of mac-specific code out of runtime_root.[cpp|h]
      
              * bridge/runtime_root.cpp:
              (KJS::Bindings::completedJavaScriptAccess):
              (KJS::Bindings::RootObject::dispatchToJavaScriptThread):
              (KJS::Bindings::performJavaScriptAccess):
              (KJS::Bindings::RootObject::createRootObject):
              (KJS::Bindings::RootObject::runLoop):
              (KJS::Bindings::RootObject::setCreateRootObject):
              * bridge/runtime_root.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      873ec6a0
    • mrowe@apple.com's avatar
      2008-03-05 Brent Fulgham <bfulgham@gmail.com> · 02a10025
      mrowe@apple.com authored
              Reviewed by Adam Roben.
      
              Modify source files to use the USE(SAFARI_THEME) macro, rather than
              USE_SAFARI_THEME.  (http://bugs.webkit.org/show_bug.cgi?id=17683)
      
              * WebCore/platform/win/PlatformScrollBarSafari.cpp
              * WebCore/rendering/RenderThemeSafari.cpp
              * WebCore/rendering/RenderThemeSafari.h
              * config.h: Move definition of WTF_USE_SAFARI_THEME here
      
      2008-03-05  Brent Fulgham  <bfulgham@gmail.com>
      
              Reviewed by Adam Roben.
      
              Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
              because the PLATFORM(CG) flag is not set until config.h has
              already included this file.
      
              * wtf/Platform.h:  Remove useless definition of WTF_USE_SAFARI_THEME
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02a10025
    • beidson@apple.com's avatar
      JavaScriptCore: · a059d6f9
      beidson@apple.com authored
              Reviewed by Alexey and Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
              removing particular items for Databases that were shutting down.
      
              This filtering operation is not atomic, and therefore causes a race condition with the
              MessageQueue waking up and reading from the message queue.  
      
              The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
              seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
              assertion with a crash in a release build is what revealed this bug.
      
              * wtf/MessageQueue.h:
              (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back
                to sleep if the queue was empty - checking m_killed each time it wakes up.
      
      WebCore:
      
              Reviewed by Alexey and Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
              removing particular items for Databases that were shutting down.
      
              This filtering operation is not atomic, and therefore causes a race condition with the
              database thread waking up and reading from the message queue.  
      
              The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
              seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
              assertion with a crash in a release build is what revealed this bug.
      
              The fix for the above symptom was entirely in WTF::MessageQueue in JSCore.  With this fix in 
              place, another crash popped up in the layout tests that was related to dereferencing a 
              deallocated object - simply because SQLTransaction had a raw pointer to it's Database object 
              when it needed to be a ref pointer.
      
              * storage/SQLTransaction.cpp:
              (WebCore::SQLTransaction::runCurrentStatement):
              * storage/SQLTransaction.h: Change m_database to be a RefPtr
              (WebCore::SQLTransaction::database):
      
      LayoutTests:
      
              Reviewed by Alexey + Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              This test takes its best shot at handling two databases on a single database thread at once,
              then having one of those databases go away completely (garbage collection and everything)
      
              * storage/multiple-databases-garbage-collection-expected.txt: Added.
              * storage/multiple-databases-garbage-collection.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a059d6f9
    • ddkilzer@apple.com's avatar
      Remove unused header includes from interpreter.cpp. · b1a25b51
      ddkilzer@apple.com authored
              Reviewed by Darin.
      
              * kjs/interpreter.cpp: Remove unused header includes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1a25b51
    • mrowe@apple.com's avatar
      b0c2aa7e
    • ddkilzer@apple.com's avatar
      Fixed commit date. · 867a6a5e
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      867a6a5e
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · ae87796d
      alp@webkit.org authored
              Re-attempt to switch to the autotools build system for GTK+.
      
              Change scripts to continue when distclean fails.
      
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae87796d
    • aroben@apple.com's avatar
      Remove WebCoreScriptCallFrame · 3c3f775a
      aroben@apple.com authored
               Reviewed by Tim.
      
               * WebView/WebCoreScriptDebugger.h:
                 - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
                 - Replaced -newWrapperForFrame: with
                   -newFrameWithGlobalObject:caller:state:
                 - Removed WebCoreScriptCallFrame interface.
               * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
               with WebScriptCallFrame.
               (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
               -newFrameWithGlobalObject:caller:state.
               (-[WebCoreScriptDebugger _leaveFrame]):
               * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
               _private ivar to be of type WebScriptCallFramePrivate*.
               * WebView/WebScriptDebugDelegate.mm:
                 - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
                 - Added WebScriptCallFramePrivate
               (-[WebScriptDebugger enteredFrame:sourceId:line:]):
               (-[WebScriptDebugger hitStatement:sourceId:line:]):
               (-[WebScriptDebugger leavingFrame:sourceId:line:]):
               (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
               (-[WebScriptCallFramePrivate dealloc]): Added.
               (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
               Code came from WebCoreScriptCallFrame.
               (-[WebScriptCallFrame dealloc]): Added a call to release the _private
               ivar.
               (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
               _private with direct access of _private's ivars.
               (-[WebScriptCallFrame caller]): Ditto.
               (-[WebScriptCallFrame scopeChain]): Ditto.
               (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c3f775a
    • aroben@apple.com's avatar
      Move -_convertValueToObjcValue to WebScriptCallFrame · e90b96e2
      aroben@apple.com authored
               Reviewed by Darin.
      
               * WebView/WebCoreScriptDebugger.h: Removed declaration of
               -_convertValueToObjcValue.
               * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
               * WebView/WebScriptDebugDelegate.mm:
               (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
               from -[WebCoreScriptCallFrame _convertValueToObjcValue].
               (-[WebScriptCallFrame scopeChain]): Changed to call
               -_convertValueToObjcValue on self instead of _private.
               (-[WebScriptCallFrame exception]): Ditto.
               (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e90b96e2
    • aroben@apple.com's avatar
      Move -exception and -evaluateWebScript: to WebScriptCallFrame · 68488677
      aroben@apple.com authored
               Reviewed by Darin.
      
               * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
               and -evaluateWebScript:.
               * WebView/WebCoreScriptDebugger.mm: Removed -exception and
               -evaluateWebScript:.
               * WebView/WebScriptDebugDelegate.mm:
               (-[WebScriptCallFrame exception]): Added. Code came from
               -[WebCoreScriptCallFrame exception].
               (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
               -[WebCoreScriptCallFrame evaluateWebScript:].
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68488677
    • aroben@apple.com's avatar
      Move -scopeChain to WebScriptCallFrame · 66302eb7
      aroben@apple.com authored
               Reviewed by Darin.
      
               * WebView/WebCoreScriptDebugger.h:
                 - Added declarations of -globalObject and -_convertValueToObjcValue:
                   to WebCoreScriptCallFrame
                 - Removed declaration of -scopeChain.
               * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
               within the main WebCoreScriptCallFrame implementation.
               (-[WebCoreScriptCallFrame globalObject]): Added.
               * WebView/WebScriptDebugDelegate.mm:
               (-[WebScriptCallFrame scopeChain]): Added. Code came from
               -[WebCoreScriptCallFrame scopeChain].
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66302eb7
    • aroben@apple.com's avatar
      Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame · 18b8ff51
      aroben@apple.com authored
               Reviewed by Darin.
      
               * WebView/WebCoreScriptDebugger.h:
                 - Removed #else case of #ifdef __cplusplus since this file is only
                   ever used by C++ Objective-C files
                 - Removed 'using KJS::ExecState' statement since we prefer not to
                   have using statements in header files
                 - Consequently prefixed uses of ExecState with KJS::
                 - Added declaration of toNSString method that takes a const
                   UString&
                 - Added declaration of -[WebCoreScriptCallFrame state]
                 - Removed declaration of -[WebCoreScriptCallFrame functionName]
               * WebView/WebCoreScriptDebugger.mm:
               (toNSString): Made this no longer static.
               (-[WebCoreScriptCallFrame state]): Added.
               * WebView/WebScriptDebugDelegate.mm:
               (-[WebScriptCallFrame functionName]): Added. Code came from
               -[WebCoreScriptCallFrame functionName], though I changed some nested
               ifs into early returns.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b8ff51
    • aroben@apple.com's avatar
      Move WebCoreScriptDebugger up to WebKit · 20608310
      aroben@apple.com authored
      WebCore:
      
              Move WebCoreScriptDebugger up to WebKit
      
              Reviewed by Darin.
      
              * WebCore.base.exp: Exported some functions used by
              WebCoreScriptDebugger, and sorted the list.
              * WebCore.xcodeproj/project.pbxproj: Removed
              WebCoreScriptDebugger.{h,mm} from the project and marked
              a few headers private so that WebKit can use them.
              * page/mac/WebCoreScriptDebugger.h: Removed.
              * page/mac/WebCoreScriptDebugger.mm: Removed.
      
      WebKit:
      
              Move WebCoreScriptDebugger to WebKit
      
              Reviewed by Darin.
      
              * WebKit.xcodeproj/project.pbxproj: Added WebCoreScriptDebugger.{h,mm}
              to the project.
      
      WebKit/mac:
      
              Move WebCoreScriptDebugger to WebKit
      
              Reviewed by Darin.
      
              * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
              * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
              (toNSString):
              (toNSURL):
              (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
              (WebCoreScriptDebuggerImp::sourceParsed):
              (WebCoreScriptDebuggerImp::callEvent):
              (WebCoreScriptDebuggerImp::atStatement):
              (WebCoreScriptDebuggerImp::returnEvent):
              (WebCoreScriptDebuggerImp::exception):
              (+[WebCoreScriptDebugger initialize]):
              (-[WebCoreScriptDebugger initWithDelegate:]):
              (-[WebCoreScriptDebugger dealloc]):
              (-[WebCoreScriptDebugger finalize]):
              (-[WebCoreScriptDebugger delegate]):
              (-[WebCoreScriptDebugger _enterFrame:]):
              (-[WebCoreScriptDebugger _leaveFrame]):
              (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
              (-[WebCoreScriptCallFrame _setWrapper:]):
              (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
              (-[WebCoreScriptCallFrame dealloc]):
              (-[WebCoreScriptCallFrame wrapper]):
              (-[WebCoreScriptCallFrame caller]):
              (-[WebCoreScriptCallFrame scopeChain]):
              (-[WebCoreScriptCallFrame functionName]):
              (-[WebCoreScriptCallFrame exception]):
              (-[WebCoreScriptCallFrame evaluateWebScript:]):
              * WebView/WebScriptDebugDelegate.mm: Updated header path.
              * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20608310
    • andersca@apple.com's avatar
      Reviewed by Sam. · f3b9897e
      andersca@apple.com authored
              
              Remove bindings/.
      
              * bindings: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3b9897e
    • andersca@apple.com's avatar
      Build fix. · a90a8444
      andersca@apple.com authored
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a90a8444
    • andersca@apple.com's avatar
      Build bridge/. Copy some headers over to WebKit as part of the post-build step. · 598f63d7
      andersca@apple.com authored
              
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      598f63d7
    • andersca@apple.com's avatar
      Don't build bindings/ anymore. · bcfbd395
      andersca@apple.com authored
              
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcfbd395
    • andersca@apple.com's avatar
      JavaScriptCore: · 74d51542
      andersca@apple.com authored
              Reviewed by Geoff.
      
              Don't build JavaScriptCore/bindings.
              
              * JavaScriptCore.exp:
              Export a couple of new functions. 
              
              * JavaScriptCore.xcodeproj/project.pbxproj:
              Remove bindings/
              
              * kjs/config.h:
              No need to define HAVE_JNI anymore.
              
              * kjs/interpreter.cpp:
              Remove unnecessary include.
      
      WebCore:
      
              Reviewed by Geoff.
      
              * WebCore.base.exp:
              Add the NPN and KJS methods.
              
              * WebCore.xcodeproj/project.pbxproj:
              Bring in bridge/
      
              * config.h:
              Add HAVE_JNI define.
              
              * bindings/js/kjs_html.cpp:
              * bindings/objc/DOMInternal.mm:
              * bindings/objc/DOMUtility.mm:
              * bindings/objc/WebScriptObject.mm:
              * html/HTMLAppletElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * page/Frame.cpp:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.mm:
              * page/mac/WebCoreScriptDebugger.mm:
              * plugins/win/PluginViewWin.cpp:
              Include file changes.
      
      WebKit/mac:
      
              Reviewed by Geoff.
      
              Include file changes.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              * Plugins/WebNetscapePluginPackage.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74d51542
    • ddkilzer@apple.com's avatar
      Allow override of default script file name using command-line argument. · a172de83
      ddkilzer@apple.com authored
              Reviewed by Adele.
      
              * API/minidom.c:
              (main): Allow first command-line argument to override the default script
              file name of "minidom.js".
              * API/testapi.c:
              (main): Allow first command-line argument to override the default script
              file name of "testapi.js".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a172de83
    • andersca@apple.com's avatar
      Reviewed by Sam. · d73bd026
      andersca@apple.com authored
              Rewrite NPRuntime string conversion routines to use WebCore::String
              
              * bridge/NP_jsobject.cpp:
              (_NPN_Evaluate):
              * bridge/c/c_utility.cpp:
              (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback):
              (KJS::Bindings::convertNPVariantToValue):
              (KJS::Bindings::convertNPStringToUTF16):
              (KJS::Bindings::identifierFromNPIdentifier):
              * bridge/c/c_utility.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d73bd026
    • oliver@apple.com's avatar
      Small performance improvement to putImageData (3-5% on assignment in my tests) · 85e8a2ef
      oliver@apple.com authored
      Reviewed by Alexey P
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85e8a2ef
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · 83570297
      alp@webkit.org authored
              Force qmake for the GTK+ build until we get the build bot to succeed
              with autotools (currently dies at make distclean)
      
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83570297
    • weinig@apple.com's avatar
      Reviewed by Adele. · 2141e21d
      weinig@apple.com authored
              * bindings/js/JSXMLHttpRequest.h: Remove unnecessary override of toBoolean.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2141e21d
    • mjs@apple.com's avatar
      WebCore: · 2a58f429
      mjs@apple.com authored
              Reviewed by Sam and Oliver.
      
              - fixed http://bugs.webkit.org/show_bug.cgi?id=16289
              - fixed Acid3 tests 26 and 27 (not exactly the same issue but related)
      
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::mark): When marking a node that's in-document,
              mark the owner document if it hasn't been already. This means holding on
              to a single node from an unreferenced document now keeps the whole document alive.
              
              We are now at 90/100 on Acid3.
      
      LayoutTests:
      
              Reviewed by Sam and Oliver.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16289
              - test for Acid3 tests 26 and 27 (not exactly the same issue but related)
      
              * fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
              * fast/dom/gc-11.html: Added.
              * fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
              * fast/dom/gc-acid3-expected.txt: Added.
              * fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test
              were in conflict with the requirements of Acid3.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a58f429
  2. 04 Mar, 2008 5 commits
    • alp@webkit.org's avatar
      2008-03-04 Alp Toker <alp@atoker.com> · 6d55438c
      alp@webkit.org authored
              Reviewed by Mark Rowe.
      
              Switch the default GTK+ build system from qmake to autotools.
      
              qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
      
              * Scripts/build-webkit:
              * Scripts/run-launcher:
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d55438c
    • weinig@apple.com's avatar
      Qt build fix. · 819d6877
      weinig@apple.com authored
              * page/qt/FrameQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      819d6877
    • weinig@apple.com's avatar
      WebCore: · 730d0a9c
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Rename kjs_window to JSDOMWindowBase.
      
              - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
                JSDOMWindow.h
      
              * ChangeLog:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSCustomVoidCallback.cpp:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/js/JSDOMWindowBase.cpp: Copied from bindings/js/kjs_window.cpp.
              * bindings/js/JSDOMWindowBase.h: Copied from bindings/js/kjs_window.h.
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/js/JSDatabaseCustom.cpp:
              * bindings/js/JSEventTargetBase.cpp:
              * bindings/js/JSEventTargetBase.h:
              * bindings/js/JSEventTargetNode.cpp:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              * bindings/js/JSHistoryCustom.cpp:
              * bindings/js/JSLocation.cpp:
              * bindings/js/JSSQLTransactionCustom.cpp:
              * bindings/js/JSXMLHttpRequest.cpp:
              * bindings/js/ScheduledAction.cpp:
              * bindings/js/kjs_binding.cpp:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_navigator.cpp:
              * bindings/js/kjs_proxy.cpp:
              * bindings/js/kjs_window.cpp: Removed.
              * bindings/js/kjs_window.h: Removed.
              * bindings/scripts/CodeGeneratorJS.pm:
              * history/CachedPage.cpp:
              * loader/FrameLoader.cpp:
              * page/Chrome.cpp:
              * page/InspectorController.cpp:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.mm:
              * page/qt/FrameQt.cpp:
              * page/win/FrameWin.cpp:
              * plugins/win/PluginViewWin.cpp:
      
      WebKit/gtk:
      
              Reviewed by Mark Rowe.
      
              - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
                JSDOMWindow.h
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              * webkit/webkitwebframe.cpp:
      
      WebKit/qt:
      
              Reviewed by Mark Rowe.
      
              - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
                JSDOMWindow.h
      
              * Api/qwebframe.cpp:
              (QWebFrame::addToJSWindowObject):
      
      WebKit/win:
      
              Reviewed by Mark Rowe.
      
              - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
                JSDOMWindow.h
      
              * WebFrame.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730d0a9c
    • timothy@apple.com's avatar
      Fix the Tiger build. · be0b020e
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be0b020e
    • mrowe@apple.com's avatar
      Another go at fixing the Qt build. · 40b02acd
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40b02acd