1. 19 Sep, 2013 40 commits
    • fpizlo@apple.com's avatar
      Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them · 620acab5
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121637
      
      Rubber stamped by Michael Saboff.
              
      Also moved GPRInfo/FPRInfo into jit/.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * bytecode/ValueRecovery.h:
      (JSC::ValueRecovery::dumpInContext):
      * dfg/DFGAssemblyHelpers.cpp: Removed.
      * dfg/DFGAssemblyHelpers.h: Removed.
      * dfg/DFGBinarySwitch.h:
      * dfg/DFGByteCodeParser.cpp:
      * dfg/DFGCCallHelpers.h: Removed.
      * dfg/DFGDisassembler.cpp:
      * dfg/DFGFPRInfo.h: Removed.
      * dfg/DFGGPRInfo.h: Removed.
      * dfg/DFGGraph.cpp:
      * dfg/DFGGraph.h:
      * dfg/DFGJITCompiler.h:
      * dfg/DFGOSRExit.cpp:
      * dfg/DFGOSRExit.h:
      * dfg/DFGOSRExitCompiler.h:
      * dfg/DFGOSRExitCompilerCommon.h:
      * dfg/DFGRegisterBank.h:
      * dfg/DFGRegisterSet.h:
      * dfg/DFGRepatch.cpp:
      * dfg/DFGSilentRegisterSavePlan.h:
      * dfg/DFGThunks.cpp:
      * dfg/DFGVariableEvent.cpp:
      * ftl/FTLCArgumentGetter.h:
      (JSC::FTL::CArgumentGetter::CArgumentGetter):
      (JSC::FTL::CArgumentGetter::loadNext8):
      (JSC::FTL::CArgumentGetter::loadNext32):
      (JSC::FTL::CArgumentGetter::loadNext64):
      (JSC::FTL::CArgumentGetter::loadNextPtr):
      (JSC::FTL::CArgumentGetter::loadNextDouble):
      * ftl/FTLCompile.cpp:
      * ftl/FTLExitThunkGenerator.h:
      * ftl/FTLLink.cpp:
      * ftl/FTLThunks.cpp:
      * jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
      * jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
      (JSC::AssemblyHelpers::AssemblyHelpers):
      (JSC::AssemblyHelpers::debugCall):
      * jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
      * jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
      (WTF::printInternal):
      * jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
      (WTF::printInternal):
      * jit/JIT.cpp:
      (JSC::JIT::JIT):
      * jit/JIT.h:
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      * jit/JSInterfaceJIT.h:
      (JSC::JSInterfaceJIT::JSInterfaceJIT):
      * jit/SpecializedThunkJIT.h:
      (JSC::SpecializedThunkJIT::SpecializedThunkJIT):
      (JSC::SpecializedThunkJIT::finalize):
      * jit/ThunkGenerators.cpp:
      (JSC::linkForGenerator):
      (JSC::virtualForGenerator):
      (JSC::stringLengthTrampolineGenerator):
      (JSC::nativeForGenerator):
      (JSC::arityFixup):
      (JSC::charCodeAtThunkGenerator):
      (JSC::charAtThunkGenerator):
      (JSC::fromCharCodeThunkGenerator):
      (JSC::sqrtThunkGenerator):
      (JSC::floorThunkGenerator):
      (JSC::ceilThunkGenerator):
      (JSC::roundThunkGenerator):
      (JSC::expThunkGenerator):
      (JSC::logThunkGenerator):
      (JSC::absThunkGenerator):
      (JSC::powThunkGenerator):
      (JSC::imulThunkGenerator):
      * llint/LLIntThunks.cpp:
      (JSC::LLInt::generateThunkWithJumpTo):
      * runtime/JSCJSValue.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      620acab5
    • antti@apple.com's avatar
      Add covariant RenderElement* Element::renderer() · 2e751515
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121638
      
      Reviewed by Andreas Kling.
      
      Also add isRenderElement() test and casting functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e751515
    • akling@apple.com's avatar
      Streamline JSMainThreadNullState. · b3696fc4
      akling@apple.com authored
      <https://webkit.org/b/121636>
      
      Reviewed by Anders Carlsson.
      
      JSMainThreadNullState is only used by non-JavaScript bindings and
      thus won't ever call didLeaveScriptContext() on destruction.
      Specialize the class for its use-case instead of sharing code
      with JSMainThreadExecState.
      
      Shrinks the WebCore binary by 82848 bytes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3696fc4
    • akling@apple.com's avatar
      Assume allocator success in Vector unless using try* functions. · 731a17ac
      akling@apple.com authored
      <https://webkit.org/b/121629>
      
      Reviewed by Anders Carlsson.
      
      Turn some Vector::begin() null checking into assertions instead.
      
      We have try* style functions for when an allocation request is so
      large that it might actually fail. fastMalloc() will never return
      null (it will just CRASH() instead.)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      731a17ac
    • betravis@adobe.com's avatar
      CSS_SHAPES not supported on AppleWin port · 7810aa39
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118810
      
      Enabling CSS Shapes on Windows port
      
      Reviewed by Brent Fulgham.
      
      * LayoutTests/Changelog
      * LayoutTEsts/platform/win/TestExpectations
      * Source/WebCore/ChangeLog
      * Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
      * Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
      * Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
      * Source/WebCore/css/CSSPropertyNames.in
      * Source/WebKit/ChangeLog
      * Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
      * WebKitLibraries/ChangeLog
      * WebKitLibraries/win/tools/vsprops/FeatureDefines.props
      * WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7810aa39
    • mitz@apple.com's avatar
      Attempted build fix after r156114. · ec1887ba
      mitz@apple.com authored
      * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec1887ba
    • mitz@apple.com's avatar
      Removed WebCoreSQLite3. It has been unused for years. · fb340d21
      mitz@apple.com authored
      Rubber-stamped by Mark Rowe.
      
      * WebCoreSQLite3: Removed.
      * WebCoreSQLite3/sqlite3.h: Removed.
      * WebCoreSQLite3/sqlite3ext.h: Removed.
      * libWebCoreSQLite3.a: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb340d21
    • dbates@webkit.org's avatar
      [iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED() · 9a40a8e5
      dbates@webkit.org authored
      Rubber-stamped by Joseph Pecoraro.
      
      Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
      the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
      noreturn warning in Clang while simultaneously asserting unreachable code.
      
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emitSlow_op_mod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a40a8e5
    • dbates@webkit.org's avatar
      [iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED() · 6de63140
      dbates@webkit.org authored
      Rubber-stamped by Joseph Pecoraro.
      
      Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
      the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
      noreturn warning in Clang while simultaneously asserting unreachable code.
      
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emitSlow_op_mod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6de63140
    • msaboff@apple.com's avatar
      JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned · 1e6960e7
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121625
      
      Rubber-stamped by Filip Pizlo.
      
      Chenged 16, 32 and 64 bit offsets to be signed.  Kept the original tab indented
      spacing to match the rest of the file.
      
      * disassembler/udis86/udis86_syn-att.c:
      (gen_operand):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6960e7
    • akling@apple.com's avatar
      Add SVGPropertyInfo.cpp · 878d4d1f
      akling@apple.com authored
      <https://webkit.org/b/121622>
      
      Reviewed by Anders Carlsson.
      
      Add a cpp file for this class to make it more hackable.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * svg/properties/SVGPropertyInfo.cpp: Added.
      (WebCore::SVGPropertyInfo::SVGPropertyInfo):
      * svg/properties/SVGPropertyInfo.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      878d4d1f
    • ap@apple.com's avatar
      REGRESSION (r129451): run-safari --no-saved-state is broken · 749baf7e
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121566
      
      Undo a last minute change that doesn't actually work.
      
      * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
      via command line, <rdar://problem/15032886>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      749baf7e
    • eric.carlson@apple.com's avatar
      MediaStream API: update NavigatorUserMediaError object to match spec · fa2d6ab5
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121584
      
      Reviewed by Dean Jackson.
      
      Source/WebCore: 
      
      No new tests, updated getusermedia.html.
      
      * CMakeLists.txt: Add NavigatorUserMediaError.cpp.
      * GNUmakefile.list.am: Ditto.
      
      * Modules/mediastream/NavigatorUserMediaError.cpp: Added.
      * Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
      * Modules/mediastream/NavigatorUserMediaError.idl: Ditto.
      
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
      (WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
      (WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
      (WebCore::UserMediaRequest::videoConstraints): Ditto.
      (WebCore::UserMediaRequest::ownerDocument): Clean up style.
      (WebCore::UserMediaRequest::succeed): 
      (WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
      (WebCore::UserMediaRequest::constraintFailure):  Renamed from failConstraint.
      (WebCore::UserMediaRequest::callSuccessHandler): New.
      (WebCore::UserMediaRequest::callErrorHandler): New.
      * Modules/mediastream/UserMediaRequest.h:
      
      * WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp
      
      * dom/DOMError.h: Make constructor protected.
      
      * platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.
      
      LayoutTests: 
      
      * fast/mediastream/getusermedia-expected.txt:
      * fast/mediastream/getusermedia.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2d6ab5
    • zoltan@webkit.org's avatar
      [CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests · af9be3b0
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121621
      
      Reviewed by Andreas Kling.
      
      * fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9be3b0
    • bjonesbe@adobe.com's avatar
      Fix handling of top margin on float with shape-outside · f492fb85
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121614
      
      Reviewed by Alexandru Chiculita.
      
      Source/WebCore:
      
      When a float has shape outside, the top margin should be treated as if
      there is no shape there, so inline content should be allowed to flow
      into that space. This patch fixes two issues:
      
      1) If the top margin is the same as the line height, a line should be
      able to fit into the margin. Before this patch, that line was being
      treated as if it intersected with the shape.
      
      2) The shape should be positioned (x, y) relative to the box sizing
      box of the float. While the x coordinate was being treated properly,
      the y coordinate was relative to the top of the margin box. This patch
      fixes this behavior.
      
      This patch also includes a simple test for right and left margins, as
      I wrote that test and then discovered the problems listed above.
      
      This patch also removes an unused override of the
      lineOverlapsShapeBounds method.
      
      Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html
             csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html
      
      * rendering/FloatingObjects.cpp:
      (WebCore::FloatingObjects::logicalLeftOffset):
      (WebCore::FloatingObjects::logicalRightOffset):
      * rendering/LineWidth.cpp:
      (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
      * rendering/shapes/ShapeInfo.h:
      * rendering/shapes/ShapeInsideInfo.h:
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
      * rendering/shapes/ShapeOutsideInfo.h:
      
      LayoutTests:
      
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.
          Test for a positive left/right margin.
      
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.
          Test for a positive top margin.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f492fb85
    • mitz@apple.com's avatar
      Add a style guideline regarding spacing in range-based for loops · b5ce977a
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121620
      
      Reviewed by Anders Carlsson.
      
      Tools: 
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_spacing): Added checking that there are spaces around the colon in a range-based for
      loop.
      (CppChecker): Added whitespace/colon to the categories set.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (WebKitStyleTest.test_spacing): Added two tests for the new check.
      
      Websites/webkit.org: 
      
      * coding/coding-style.html: Added the guideline that spaces should be placed
      around the colon in a range-based for loop.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5ce977a
    • rniwa@webkit.org's avatar
      DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up · 47d051a4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121597
      
      Reviewed by Anders Carlsson.
      
      Fixed indentations.
      
      * DoYouEvenBench/benchmark.html:
      * DoYouEvenBench/benchmark.js:
      (SimplePromise.prototype.resolve.else):
      (SimplePromise.prototype.resolve):
      (BenchmarkRunner.waitForElement.resolveIfReady):
      (BenchmarkRunner.waitForElement):
      (BenchmarkRunner._waitAndWarmUp.Fibonacci):
      (BenchmarkRunner._finalize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47d051a4
    • rniwa@webkit.org's avatar
      Add XHR tests checking readyState transition when abort() is invoked in various states · bb5605b5
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121585
      
      Reviewed by Alexey Proskuryakov.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342
      
      * http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
      * http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb5605b5
    • antti@apple.com's avatar
      Add RenderElement · 24f720d4
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121608
      
      Reviewed by Dave Hyatt.
      
      Add a common base class for all Element renderers. The class hierarchy will now look like this
              
      RenderObject
          RenderText
          RenderElement
              RenderLayerModelObject
                  ...
              RenderSVGModelObject
                  ...
              RenderSVGGradientStop
                      
      This will allow tighter typing in both render and DOM trees.
              
      The patch also moves renderer factory function to RenderElement::createFor().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f720d4
    • allan.jensen@digia.com's avatar
      Keep chasing the definition of QAccessibleWidget · 5a501040
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121611
      
      Reviewed by Jocelyn Turcotte.
      
      * WidgetApi/qwebviewaccessible_p.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a501040
    • weinig@apple.com's avatar
      Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools · 973ab786
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121588
      
      Reviewed by Anders Carlsson.
      
      * DumpRenderTree/TestRunner.cpp:
      * ImageDiff/efl/ImageDiff.cpp:
      * TestWebKitAPI/JavaScriptTest.cpp:
      * TestWebKitAPI/PlatformUtilities.cpp:
      * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
      * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      * WebKitTestRunner/StringFunctions.h:
      * WebKitTestRunner/TestInvocation.cpp:
      * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
      * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      973ab786
    • ap@apple.com's avatar
      REGRESSION (r149928): CanvasStyle::operator= leaks everything · e69c6cd4
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121591
      
      Reviewed by Andreas Kling.
      
      * html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e69c6cd4
    • rego@igalia.com's avatar
      Unreviewed. Fix typo in layout test description introduced in r155974. · 36b6ff4b
      rego@igalia.com authored
      * fast/regions/selection-direction-expected.html:
      * fast/regions/selection-direction.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36b6ff4b
    • commit-queue@webkit.org's avatar
      [CSS Masking/Background] Position property should be ignored when using repeat: space · 1b03623c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120623
      
      Source/WebCore:
      
      The background/mask-position should be ignored when using repeat: space,
      unless there is not enough space for two copies of the image. In that case,
      only one image is placed and background/mask-position determines its position.
      
      Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
      Reviewed by Dirk Schulze.
      
      Test: css3/masking/mask-repeat-one-copy.html
      
      * rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      
      LayoutTests:
      
      Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
      Reviewed by Dirk Schulze.
      
      * css3/masking/mask-repeat-one-copy-expected.html:
      * css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
      * css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b03623c
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening. · e1d17a22
      m.pakula@samsung.com authored
      Unskip tests added to platform/efl/Skipped, which now are passing.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1d17a22
    • akling@apple.com's avatar
      CTTE: EllipsisBox::renderer() should return RenderBlock&. · 51ada156
      akling@apple.com authored
      <https://webkit.org/b/121604>
      
      Reviewed by Antti Koivisto.
      
      I missed adding a renderer() overload when fixing up EllipsisBox.
      Flushed out one unnecessary type check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51ada156
    • akling@apple.com's avatar
      CTTE: Tighten renderer types for InlineTextBox and SVGInlineTextBox. · 8ef99b2a
      akling@apple.com authored
      <https://webkit.org/b/121605>
      
      Reviewed by Antti Koivisto.
      
      Codify the following:
      
      - InlineTextBox always has a RenderText.
      - SVGInlineTextBox always has a RenderSVGInlineText.
      
      Removed InlineTextBox::textRenderer() and make renderer() simply
      return a RenderText&/RenderSVGInlineText& instead.
      
      This turns some node() accessors into textNode() and removes a host
      of casts and assertions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ef99b2a
    • antti@apple.com's avatar
    • akling@apple.com's avatar
      CTTE: Tighten renderer types for InlineFlowBox and SVGInlineFlowBox. · 4df94676
      akling@apple.com authored
      <https://webkit.org/b/121603>
      
      Reviewed by Antti Koivisto.
      
      Codify the following:
      
      - InlineFlowBox always has a RenderBoxModelObject.
      - SVGInlineFlowBox always has a RenderSVGInline.
      
      This turns some node() accessors into element(). Neato!
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4df94676
    • commit-queue@webkit.org's avatar
      CSS Unit vmax and vmin in border-width not handled. · c47ed195
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121421
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-19
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Border properties were not applied incase its values
      were given in vmax/vmin units.
      
      Tests: fast/css/viewport-vmax-border.html
             fast/css/viewport-vmin-border.html
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::computeLengthDouble):
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::isViewportPercentageMax):
      (WebCore::CSSPrimitiveValue::isViewportPercentageMin):
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyComputeLength::applyValue):
      Calculating the border values which has been specified in
      vmax/vmin units. 1vmax: 1vw or 1vh, whatever is largest.
      1vmin: 1vw or 1vh, whatever is smallest. The vh/vw units are
      calcultated as percent of viewport height and viewport width respectively.
      
      LayoutTests:
      
      * fast/css/viewport-vmax-border-expected.txt: Added.
      * fast/css/viewport-vmax-border.html: Added.
      * fast/css/viewport-vmin-border-expected.txt: Added.
      * fast/css/viewport-vmin-border.html: Added.
      Added new tests for verifying that border properties are
      applied when its values are given in vmax/vmin units.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c47ed195
    • antti@apple.com's avatar
      [CTTE] RenderText is always anonymous or associated with Text node · 1936a2ba
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121596
      
      Source/WebCore: 
      
      Reviewed by Andreas Kling.
      
      Tighten the node type of RenderText and its subclasses to Text.
      Switch to createAnonymous pattern.
      Switch a bunch of unnecessary StringImpl* use to Strings.
      
      LayoutTests: 
      
      Reviewed by Andreas Kling.
              
      Update some MathML render tree dumps. RenderTexts for these are now anonymous.
      
      * platform/mac/mathml/presentation/mo-expected.txt:
      * platform/mac/mathml/presentation/row-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1936a2ba
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebase after r155957 and 155998. · 8026add2
      zarvai@inf.u-szeged.hu authored
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-19
      
      * platform/qt-wk1/compositing/contents-scale/animating-expected.txt: Added r155998.
      * platform/qt-wk1/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
      * platform/qt-wk1/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
      * platform/qt-wk1/compositing/contents-scale/z-translate-expected.txt: Added r155998.
      * platform/qt-wk2/compositing/contents-scale/animating-expected.txt: Added r155998.
      * platform/qt-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
      * platform/qt-wk2/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
      * platform/qt-wk2/compositing/contents-scale/z-translate-expected.txt: Added r155998.
      * platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt: Rebase after r155957.
      * platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt: Rebase after r155957.
      * platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt: Rebase after r155957.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8026add2
    • rniwa@webkit.org's avatar
      Add an AngularJS test to DoYouEvenBench · c239f9f2
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121595
      
      Reviewed by Antti Koivisto.
      
      * DoYouEvenBench/benchmark.html:
      * DoYouEvenBench/todomvc/architecture-examples/angularjs: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
      * DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c239f9f2
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · bf64fadd
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Adding failure expectations for failing HiDPI and a11y tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf64fadd
    • mihnea@adobe.com's avatar
      a887c44e
    • dbates@webkit.org's avatar
      Remove names of unused arguments from the x86/x86-64 function prototype · 5ca54312
      dbates@webkit.org authored
      for JIT::emitSlow_op_mod()
      
      Rubber-stamped by Ryosuke Niwa.
      
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emitSlow_op_mod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca54312
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Rebaselining after r155957. · 1f9af598
      zandobersek@gmail.com authored
      * platform/gtk/css3/selectors3/html/css3-modsel-179a-expected.txt:
      * platform/gtk/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
      * platform/gtk/css3/selectors3/xml/css3-modsel-179a-expected.txt:
      * platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
      * platform/gtk/fast/css/word-space-extra-expected.txt:
      * platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f9af598
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Rebaselining after r156040. · 03289ad6
      zandobersek@gmail.com authored
      * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
      * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
      * platform/gtk/fast/forms/form-element-geometry-expected.txt:
      * platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
      * platform/gtk/fast/forms/select-baseline-expected.txt:
      * platform/gtk/fast/forms/select-empty-option-height-expected.txt:
      * platform/gtk/fast/forms/selectlist-minsize-expected.txt:
      * platform/gtk/fast/html/keygen-expected.txt:
      * platform/gtk/fast/replaced/three-selects-break-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03289ad6
    • mihnea@adobe.com's avatar
      [CSSRegions] Failed to retrieve named flow ranges for content with inline svg · 8df17aad
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121489
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The inline SVG element behaves like a replaced element in HTML context. When computing the ranges
      that are displayed inside a region for a named flow that contains an inline SVG element, we have
      to treat the SVG as a replaced and run the checks only for the SVG root element, skipping the
      other SVG elements inside.
      
      Test: fast/regions/get-region-flow-ranges-inline-svg.html
      
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::nextNodeInsideContentNode): Add function to retrieve the next node in traversal
      under the contentNode subtree that should be used for getRanges inspection.
      (WebCore::RenderNamedFlowThread::getRanges): Replace NodeTravesal::next with nextNodeInsideContentNode.
      
      LayoutTests:
      
      * fast/regions/get-region-flow-ranges-inline-svg-expected.txt: Added.
      * fast/regions/get-region-flow-ranges-inline-svg.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8df17aad
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Moving GTK-specific baselines for some js/dom/*... · 920735b8
      zandobersek@gmail.com authored
      Unreviewed GTK gardening. Moving GTK-specific baselines for some js/dom/* tests into the proper directory.
      
      * platform/gtk/js/dom: Added.
      * platform/gtk/js/dom-static-property-for-in-iteration-expected.txt: Removed.
      * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Copied from LayoutTests/platform/gtk/js/dom-static-property-for-in-iteration-expected.txt.
      * platform/gtk/js/dom/function-length-expected.txt: Copied from LayoutTests/platform/gtk/js/function-length-expected.txt.
      * platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt.
      * platform/gtk/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-expected.txt.
      * platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt.
      * platform/gtk/js/function-length-expected.txt: Removed.
      * platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
      * platform/gtk/js/global-constructors-attributes-expected.txt: Removed.
      * platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      920735b8