1. 05 Oct, 2012 40 commits
    • wangxianzhu@chromium.org's avatar
      OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux · 61985f74
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97824
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      The issue occurred when a font that contains vert GSUB table but doesn't have
      a DFLT script and the first script doesn't have vert feature. Added logic to
      handle the case.
      
      Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html
      
      * platform/graphics/opentype/OpenTypeVerticalData.cpp:
      (FeatureList):
      (WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
      (WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.
      
      LayoutTests:
      
      Ref test for the change. The punctuations in the vertical text are expected to
      be substituted with the corresponding vertical forms.
      
      * fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
      * fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
      * platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61985f74
    • tony@chromium.org's avatar
      Form controls should always be horizontal · c3459ef9
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98563
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Fix a regression where we didn't force form controls to be horizontal.
      
      Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
             fast/dom/HTMLProgressElement/progress-writing-mode.html
             fast/table/colspanMinWidth-vertical.html
      
      * css/html.css:
      (input, textarea, keygen, select, button, isindex, meter, progress):
      
      LayoutTests:
      
      Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
      fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
      Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
      test as needing a rebaseline on platforms other than Chromium Linux.
      
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/efl/TestExpectations:
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/mac/TestExpectations:
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt/TestExpectations:
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3459ef9
    • commit-queue@webkit.org's avatar
      [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads · fd0d0fe7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98524
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
      Reviewed by Alexey Proskuryakov.
      
      Source/WebKit2:
      
      Add implementation for testRunner.setSerializeHTTPLoads in
      WebKitTestRunner.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetSerialLoadingEnabled):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setSerialLoadingEnabled):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Add implementation for testRunner.setSerializeHTTPLoads in
      WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setSerializeHTTPLoads):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskip tests that are now passing.
      
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0d0fe7
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130556 and r130564. · f583bb1a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130556
      http://trac.webkit.org/changeset/130564
      https://bugs.webkit.org/show_bug.cgi?id=98572
      
      The patch wasn't reviewed by a reviewer and it is breaking
      Chromium Windows (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * css/mediaControls.css:
      (video::-webkit-media-text-track-container):
      (video::-webkit-media-text-track-past-nodes):
      (video::-webkit-media-text-track-future-nodes):
      (video::-webkit-media-text-track-display):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::userIsInterestedInThisLanguage):
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind):
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
      (WebCore::HTMLMediaElement::updateClosedCaptionsControls):
      * html/HTMLMediaElement.h:
      (HTMLMediaElement):
      * html/shadow/MediaControlElements.cpp:
      (WebCore):
      (WebCore::MediaControlTextTrackContainerElement::updateSizes):
      * html/shadow/MediaControlElements.h:
      (MediaControlTextTrackContainerElement):
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::updateTextTrackDisplay):
      * html/shadow/MediaControlRootElement.h:
      (MediaControlRootElement):
      * html/shadow/MediaControls.h:
      (MediaControls):
      * html/track/TextTrack.cpp:
      (WebCore::TextTrack::TextTrack):
      (WebCore::TextTrack::isValidKindKeyword):
      (WebCore::TextTrack::setKind):
      (WebCore::TextTrack::setMode):
      (WebCore::TextTrack::mode):
      * html/track/TextTrack.h:
      (WebCore::TextTrack::create):
      (WebCore::TextTrack::kind):
      (TextTrack):
      (WebCore::TextTrack::label):
      (WebCore::TextTrack::setLabel):
      (WebCore::TextTrack::language):
      (WebCore::TextTrack::setLanguage):
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::TextTrackCueBox):
      (WebCore::TextTrackCueBox::shadowPseudoId):
      (WebCore):
      (WebCore::TextTrackCue::updateDisplayTree):
      * html/track/TextTrackCue.h:
      (TextTrackCueBox):
      (TextTrackCue):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * rendering/CaptionPreferencesChangedListener.h: Removed.
      * rendering/RenderTheme.h:
      (WebCore):
      (RenderTheme):
      * rendering/RenderThemeMac.h:
      (RenderThemeMac):
      * rendering/RenderThemeMac.mm:
      (WebCore):
      (WebCore::RenderThemeMac::RenderThemeMac):
      (WebCore::RenderThemeMac::~RenderThemeMac):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      WebKitLibraries:
      
      * WebKitSystemInterface.h:
      
      LayoutTests:
      
      * media/track/track-cue-rendering-expected.txt:
      * media/track/track-cue-rendering.html:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f583bb1a
    • weinig@apple.com's avatar
      Set the current working directory to TMPDIR when entering the sandbox in the plug-in process. · 430f79e6
      weinig@apple.com authored
      Based on a patch by Ivan Krstić.
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
      (enterSandbox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      430f79e6
    • timothy_horton@apple.com's avatar
      [cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required · ba51c888
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98565
      <rdar://problem/12436468>
      
      Reviewed by Simon Fraser.
      
      On Mountain Lion and above, CG can tell us whether we need to work around incorrect
      shadow offsets. Prior to Mountain Lion, we should assume we need to apply the workaround.
      
      No new tests, as this requires an obscure configuration to test.
      
      * WebCore.exp.in:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::applyShadowOffsetWorkaroundIfNeeded):
      (WebCore::GraphicsContext::setPlatformShadow):
      * platform/mac/WebCoreSystemInterface.h: Add wkCGContextDrawsWithCorrectShadowOffsets.
      * platform/mac/WebCoreSystemInterface.mm: Add wkCGContextDrawsWithCorrectShadowOffsets.
      
      Add wkCGContextDrawsWithCorrectShadowOffsets.
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba51c888
    • andersca@apple.com's avatar
      Try to fix the build. · a4fa9c3e
      andersca@apple.com authored
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::captionsWindowColor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4fa9c3e
    • timothy_horton@apple.com's avatar
      Update WebKitSystemInterface libraries and header. · e11fcece
      timothy_horton@apple.com authored
      Reviewed by Simon Fraser.
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLion.a:
      * libWebKitSystemInterfaceMountainLion.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e11fcece
    • commit-queue@webkit.org's avatar
      TestResultsServer does not display sync_integration_tests results · 0e6c919a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98551
      
      Patch by Richard Larocque <rlarocque@chromium.org> on 2012-10-05
      Reviewed by Ojan Vafai.
      
      Allow builders whose name contains "Sync" to pass through the
      isChromiumWebkitDepsTestRunner filter.
      
      The test expectations in flakiness_dashboard_unittests.js have been
      updated to match the new behaviour.
      
      * TestResultServer/static-dashboards/builders.js:
      (isChromiumDepsGTestRunner):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e6c919a
    • jchaffraix@webkit.org's avatar
      Unreviewed Chromium gardening. · c8c0f2d8
      jchaffraix@webkit.org authored
      * platform/chromium/TestExpectations:
      Updated a wrong bug info and rebaselined 2 tests:
      fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html
      
      * fast/backgrounds/solid-color-context-restore-expected.txt: Added.
      * fast/reflections/inline-crash-expected.txt: Added.
      * platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
      * platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
      * platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
      * platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
      * platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
      * platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
      * platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
      * platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c0f2d8
    • eric@webkit.org's avatar
      Remove needless virtual calls and inline RenderStyle::logical* to make table layout faster · b9508892
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98550
      
      Reviewed by Andreas Kling.
      
      This shaved another 5% (100ms) off of the runtime of resizecol.html microbenchmark:
      http://www.robohornet.org/tests/resizecol.html
      
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::recalcColumn):
      * rendering/style/RenderStyle.cpp:
      * rendering/style/RenderStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9508892
    • roger_fong@apple.com's avatar
      Tests in webkitpy involving child processes are flaky. · 977e63b3
      roger_fong@apple.com authored
      Skipping run_webkit_tests_integrationtest.py.
      https://bugs.webkit.org/show_bug.cgi?id=98559
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (MainTest.test_verbose_in_child_processes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      977e63b3
    • commit-queue@webkit.org's avatar
      [chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS · 8036395c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98526
      
      Patch by Terry Anderson <tdanderson@chromium.org> on 2012-10-05
      Reviewed by Stephen White.
      
      This is causing some problems with picture serialization between chrome
      and the mainline skia tools. (Once this change lands and is gardened in,
      I will make the corresponding change in chromium/skia/skia.gyp)
      
      * features.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8036395c
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Add shape-inside tests for rounded rectangles · 6fff8b1c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96669
      
      Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
      Reviewed by Levi Weintraub.
      
      Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
      to simulate the shape-inside area in the test expectations.
      (See http://www.alistapart.com/articles/sandbags/)
      In general, each line has its own pair of left and right floats (both lineHeight tall),
      to position the text and appropriately limit its width. In the simple, 0 corner radius
      cases, these floats can be merged because they all have the same width on the left and
      right.
      
      * fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating
      a shape-inside, simulating one, and generating content that should roughly fill the
      shape-inside.
      (xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
      distance from center.
      (xInset): The inset of a rounded rectangle from its bounding box.
      (generateString): Generate a string that roughly fills a shape-inside's content area.
      (simulateShape): Create floats to simulate a shape-inside area.
      (simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
      (generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
      with content.
      (generateShapeElement): Create a shape-inside and fill it with content.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:
      Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:
      Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fff8b1c
    • jer.noble@apple.com's avatar
      Allow ports to override text track rendering style · 0846d8de
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97800
      <rdar://problem/12044964>
      
      Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
      Reviewed by Silvia Pfeiffer.
      
      Source/WebCore:
      
      * WebCore.exp.in: Export new WebkitSystemInterface functions.
      * WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.
      
      * css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,
          background, and text independently.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
      (WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
      (WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
      (WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as
          un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.
      (WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
      (WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from
          setClosedCaptionsVisible
      * html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme
          has a captions style sheet override, inject it into the current page group, otherwise
          remove injected sheet.
      (WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member
          variable. Get caption font scale from theme instead of hard coding.
      * html/shadow/MediaControlElements.h:
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
      (WebCore::MediaControlRootElement::updateTextTrackDisplay):
      * html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.
      
      * html/shadow/MediaControls.h:
      (WebCore::MediaControls::userCaptionPreferencesChanged): New.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
      (WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the
          shadow pseudo id so it can be used elsewhere.
      (WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
      (WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the
          shadow pseudo id so it can be used elsewhere.
      (WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
      (WebCore::TextTrackCue::updateDisplayTree):
      * html/track/TextTrackCue.h:
      
      * platform/mac/WebCoreSystemInterface.h: Updated.
      * platform/mac/WebCoreSystemInterface.mm: Ditto.
      
      * rendering/CaptionPreferencesChangedListener.h: Added.
      
      * rendering/RenderTheme.h:
      (WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
      (WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
      (WebCore::RenderTheme::captionFontSizeScale): Ditto.
      (WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
      (WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
      (WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
      
      * rendering/RenderThemeMac.h:
      * rendering/RenderThemeMac.mm:
      (WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
      (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
      (WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
      (WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
      (WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
      (WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
      (WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption
          background color preference.
      (WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
      (WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
      (WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow
          or webkit-text-stroke property.
      (WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property
          with a color value.
      (WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption
          text with the user's preferred text edge stye.
      (WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption
          text with the user's preferred font.
      (WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions
          with the user's preferred style.
      (WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
      (WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
      (WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences
          changes listener.
      (WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences
          changes listener.
      
      Source/WebKit/mac:
      
      Add WCSI support for new WKSI caption functions.
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Initialize new WKSI function pointers.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Initialize new WKSI function pointers.
      
      WebKitLibraries:
      
      Update WKSI header with SPI for getting the user caption appearance preferences.
      
      * WebKitSystemInterface.h:
      
      LayoutTests:
      
      * media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
      * media/track/track-cue-rendering.html:
      * platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0846d8de
    • commit-queue@webkit.org's avatar
      Inline continuations create :after generated content on style recalcs · cc0f04f3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93170
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      The bug is caused by RenderInline::styleDidChange's setContinuation(0).
      RenderObjectChildList uses continuation to know whether the given
      renderer should have AFTER render object or not.
      However, setContinuation(0) makes RenderObjectChildList to
      misunderstand that all continuations are last continuation.
      To avoid the misunderstanding, added a new flag to class
      RenderObejctChildList to enable/disable updating :after content (and
      also :before content).
      
      Tests: fast/css-generated-content/after-with-inline-continuation.html
             fast/css-generated-content/dynamic-apply-after-for-inline.html
      
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      Disable upating :after content for continuations which are not
      the last one during setStyle just after setContinuation(0).
      The setStyle invokes RenderInline::styleDidChange and also invokes
      updateBeforeAfterContent via the styleDidChange. This means,
      the last continuation's updateBeforeAfterContent is also invoked
      after setContinuation(0). We have to update :after for the last
      continuation.
      * rendering/RenderObjectChildList.cpp:
      (WebCore):
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      If s_updateBeforeAfterContent is false, quickly exit
      updateBeforeAfterContent.
      * rendering/RenderObjectChildList.h:
      (RenderObjectChildList):
      Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
      updating :before or :after content.
      
      LayoutTests:
      
      * fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
      * fast/css-generated-content/after-with-inline-continuation.html: Added.
      * fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
      * fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
      * http/tests/misc/acid3-expected.txt:
      The acid3-expected.txt has the duplicate RenderBlock (positioned).
      Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
      exist. So did reset-results for acid3-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc0f04f3
    • simon.fraser@apple.com's avatar
      Don't assume that TileCache layers are opaque · ed65993d
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98555
      
      Reviewed by Dean Jackson.
      
      TileCache previously set all its tile CALayers as opaque.
      However, we will need non-opaque tile caches when we use this
      tile cache for tiled layers, so add a member function to
      control tile opacity.
      
      RenderLayerBacking already calls m_graphicsLayer->setContentsOpaque()
      using the FrameView's notion of opaqueness, so this change will
      cause the main tile cache to be non-opaque if external forces have
      set the FrameView to be non-opaque.
      
      Also tweak the layer border widths on tiled layers.
      
      * platform/graphics/ca/mac/TileCache.h:
      (TileCache):
      (WebCore::TileCache::tilesAreOpaque):
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::TileCache):
      (WebCore::TileCache::setTilesOpaque):
      (WebCore::TileCache::createTileLayer):
      * platform/graphics/ca/mac/WebTileCacheLayer.mm:
      (-[WebTileCacheLayer setOpaque:]):
      (-[WebTileCacheLayer isOpaque]):
      (-[WebTileCacheLayer setBorderWidth:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed65993d
    • tony@chromium.org's avatar
      Fix margin box ascent computation in flexbox · e9f6357d
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98540
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The margin box ascent doesn't depend on the margin below the box.
      
      Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.
             css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::marginBoxAscentForChild):
      
      LayoutTests:
      
      Remove a FIXME and update the results.
      
      * css3/flexbox/flex-align-vertical-writing-mode.html:
      * css3/flexbox/flex-align.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f6357d
    • abarth@webkit.org's avatar
      Unreviewed. · 1d9fcb56
      abarth@webkit.org authored
      Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
      some code that is conditionally compiled and therefore fails in some
      configurations.
      
      * tests/WebFrameTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d9fcb56
    • wjmaclean@chromium.org's avatar
      [chromium] Enhance support for transforms in LinkHighlight. · f28e98cd
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94355
      
      Reviewed by Adrienne Walker.
      
      Improved handling of transformed highlight targets, where the transform goes beyond simple translation.
      
      Source/WebKit/chromium:
      
      * src/LinkHighlight.cpp:
      (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
      (WebKit):
      (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
      (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::bestTouchLinkNode):
      
      LayoutTests:
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f28e98cd
    • jchaffraix@webkit.org's avatar
      Unreviewed build fix after r130545. · 27d5e383
      jchaffraix@webkit.org authored
      * tests/WebFrameTest.cpp:
      Avoid a warning about truncating the double constant on Windows. While touching the variable, changed
      it to be proper camelCase.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27d5e383
    • ojan@chromium.org's avatar
      Deprecated flexboxes subtract scrollbar width/height twice · 7e7af586
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98552
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      This is a regression from http://trac.webkit.org/changeset/119507.
      The problem is that contentHeight subtracts the scrollbar and
      RenderDeprecatedFlexbox subtracts the scrollbar.
      
      -Make it so that we only access override sizes if one has been set.
      I think this makes the calling code more clear.
      -If we don't have one set, grab the height/width - borderAndPadding.
      -Add a FIXME to change this all back to being borderbox sizes.
      There's something trick with making table padding/border work right for that
      though (noted in the original patch).
      
      Test: fast/flexbox/flexing-overflow-scroll-item.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::overrideLogicalContentWidth):
      (WebCore::RenderBox::overrideLogicalContentHeight):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::contentWidthForChild):
      (WebCore):
      (WebCore::contentHeightForChild):
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
      (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
      
      LayoutTests:
      
      * fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
      * fast/flexbox/flexing-overflow-scroll-item.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e7af586
    • eric@webkit.org's avatar
      Make tables which don't use col/row span much faster to layout · 872ec60b
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98221
      
      Reviewed by Julien Chaffraix.
      
      My sense is that most tables on webpages do not use colspan/rowspan
      so I stole another bit from RenderTableCell::m_column to avoid
      having to re-parse the colSpan/rowSpan attributes for every cell
      when doing table layout.
      This made these symbols disappear from biggrid.html/redraw.html (dglazkov's spreadsheets benchmarks)
      as well as moved our robohornet/resizecol.html number from an average of 3221ms to 2608ms (~20%!).
      
      I removed m_hasHTMLTableCellElement (from http://trac.webkit.org/changeset/97691)
      since it was attempting to do the same sort of optimization.
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::RenderTableCell):
      (WebCore::RenderTableCell::parseColSpanFromDOM):
      (WebCore::RenderTableCell::parseRowSpanFromDOM):
      (WebCore::RenderTableCell::layout):
      * rendering/RenderTableCell.h:
      (WebCore::RenderTableCell::colSpan):
      (WebCore::RenderTableCell::rowSpan):
      (RenderTableCell):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      872ec60b
    • commit-queue@webkit.org's avatar
      Source/WebCore: Allow EventHandler to handle longpress gestures, including... · 853e5d1a
      commit-queue@webkit.org authored
      Source/WebCore: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
      https://bugs.webkit.org/show_bug.cgi?id=98173
      
      Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
      Reviewed by Ryosuke Niwa.
      
      Adds handling for GestureLongPress to EventHandler::handleGestureEvent, with a new
      handleGestureLongPress method. On Android, this method selects the closest word
      if the gesture event was over non-link text.
      
      This is tested via a new chromium test WebViewTest.LongPressSelection.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::selectClosestWordFromHitTestResult):
      (WebCore::EventHandler::selectClosestWordFromMouseEvent):
      (WebCore):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureLongPress):
      * page/EventHandler.h:
      (EventHandler):
      
      Source/WebKit/chromium: Allow EventHandler to handle longpress gestures, including longpress selection on Android.
      https://bugs.webkit.org/show_bug.cgi?id=98173
      
      Patch by Oli Lan <olilan@chromium.org> on 2012-10-05
      Reviewed by Ryosuke Niwa.
      
      This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent.
      The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour
      required for Android. This means that a long press gesture performed on word (that is not part of a link)
      selects the word, without generating a context menu event.
      
      A new test, WebViewTest.LongPressSelection has been added to test this.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebViewImpl):
      * tests/WebViewTest.cpp:
      * tests/data/longpress_selection.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      853e5d1a
    • rniwa@webkit.org's avatar
      GTK+ and Qt rebaselines after r130532. · c09a745e
      rniwa@webkit.org authored
      * platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium/svg/custom/delete-text-crash-expected.txt: Removed.
      * platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Removed.
      * platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c09a745e
    • commit-queue@webkit.org's avatar
      [chromium] Support zooming focused node for mobile devices · 24ac11e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97958
      
      Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-05
      Reviewed by Adam Barth.
      
      This unforks the Android version of scrollFocusedNodeIntoRect().A new setting
      autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all
      platforms with ENABLE(GESTURE_EVENTS) want this.
      
      Test: WebFrameTest.DivScrollIntoEditableTest
      
      * public/WebSettings.h:
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::WebSettingsImpl):
      (WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      (WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      * tests/WebFrameTest.cpp:
      * tests/data/get_scale_for_zoom_into_editable_test.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24ac11e9
    • rniwa@webkit.org's avatar
      Chromium and Mac rebaselines after r130532. · c095a2a8
      rniwa@webkit.org authored
      * platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt:
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt:
      * platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
      * platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt:
      * platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt:
      * platform/chromium/svg/custom/delete-text-crash-expected.txt: Added.
      * platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Added.
      * svg/custom/delete-text-crash-expected.txt:
      * svg/custom/delete-text-innerText-crash-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c095a2a8
    • zandobersek@gmail.com's avatar
      [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder · d0f866c2
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91009
      
      Reviewed by Martin Robinson.
      
      Tools: 
      
      Include libxml2 into the jhbuild module. Version 2.8.0 introduces
      a more correct (but not completely correct) behavior in the
      fast/xsl/xslt-missing-namespace-in-xslt.html test.
      
      * gtk/jhbuild.modules:
      
      LayoutTests: 
      
      Update the test's baselines. The output now properly shows the error.
      
      * platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
      * platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0f866c2
    • dpranke@chromium.org's avatar
      Fix lint error in TestExpectations from previous change. · 6455b472
      dpranke@chromium.org authored
      Unreviewed.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6455b472
    • commit-queue@webkit.org's avatar
      <marquee> element forces itself to be at least 1em high, regardless of 'height' declaration · ea7100d9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=18098
      
      Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
      Reviewed by Eric Seidel.
      
      This restriction originally existed to match IE, but IE changed some time ago to be normal instead.
      We're the last browser, afaict, to still enforce this de-facto restriction.
      This patch makes <marquee> instead act like a normal element.
      
      Tests: fast/css/MarqueeLayoutTest.html (rewritten from the older, bad version)
      
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::updateMarqueeStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea7100d9
    • dpranke@chromium.org's avatar
      [chromium] tests failing after r130443. · 0405bf3f
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98545
      
      Unreviewed, expectations change.
      
       [chromium] fast/text/international/text-spliced-font.html and
       fast/writing-mode/Kusa-Makura-background-canvas.html are failing on
       the Mac after r130443 and we're not quite sure why ...
      
      * platform/chromium-linux/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      * platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0405bf3f
    • wjmaclean@chromium.org's avatar
      [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and... · eb4ecaa5
      wjmaclean@chromium.org authored
      [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
      https://bugs.webkit.org/show_bug.cgi?id=97355
      
      Reviewed by Adrienne Walker.
      
      This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
      interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.
      
      Source/WebKit/chromium:
      
      * src/LinkHighlight.cpp:
      (WebKit::LinkHighlight::LinkHighlight):
      (WebKit::LinkHighlight::startHighlightAnimationIfNeeded):
      * src/LinkHighlight.h:
      (LinkHighlight):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebKit::WebViewImpl::enableTouchHighlight):
      
      LayoutTests:
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4ecaa5
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Implement TestRunner.setMockDeviceOrientation · f0f2e6c2
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98542
      
      Reviewed by Antonio Gomes.
      
      PR 120681
      
      Source/WebKit/blackberry:
      
      Provide framework for mock device motion.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      * WebKitSupport/DumpRenderTreeSupport.cpp:
      (toDeviceOrientationClientMock):
      (DumpRenderTreeSupport::setMockDeviceOrientation):
      * WebKitSupport/DumpRenderTreeSupport.h:
      (DumpRenderTreeSupport):
      
      Tools:
      
      This fixes tests in fast/dom/DeviceOrientation.
      
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::setMockDeviceOrientation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0f2e6c2
    • commit-queue@webkit.org's avatar
      [BlackBerry] Fix regression in proxy auth · c2d011e6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98533
      
      Patch by Joe Mason <jmason@rim.com> on 2012-10-05
      Reviewed by Yong Li.
      
      The proxy auth dialog gets the proxy address from
      BlackBerry::Platform::Settings::proxyAddress, which returns
      "host:port", but we try to parse it with a KURL, which expects
      "scheme://host:port".  Since this is an http proxy, add http:// to the
      url to get it to parse.
      
      PR 220567.
      
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::sendRequestWithCredentials):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2d011e6
    • jer.noble@apple.com's avatar
      REGRESSION (r129478-r129480):... · 8d8360da
      jer.noble@apple.com authored
      REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
      https://bugs.webkit.org/show_bug.cgi?id=98527
      
      Unreviewed gardening after r129479.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d8360da
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 9062e6b5
      zandobersek@gmail.com authored
      Removing failure expectation for fast/text/vertical-rl-rtl-linebreak.html
      since the test only needed platform-specific baselines (which were added
      in r130524).
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9062e6b5
    • jer.noble@apple.com's avatar
      No autorelease pool in place, causing buildup of autoreleased objects. · b3fc889d
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98522
      <rdar://problem/11647950>
      
      Reviewed by Alexey Proskuryakov.
      
      Wrap each timer callback in an AutodrainPool, ensuring an autorelease
      pool is present during calls from C/C++ into ObjC.
      
      * platform/cf/RunLoopTimerCF.cpp:
      (WebCore::timerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3fc889d
    • ojan@chromium.org's avatar
      Have perf test assert worst order of magnitude · cb1e5cf2
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98535
      
      Reviewed by Tony Chang.
      
      Really we only care if tests get order of magnitude slower.
      Assert that tests are at least a certain magnitude.
      Hopefully this will reduce flakiness some.
      
      * resources/magnitude-perf.js:
      (Magnitude._run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb1e5cf2
    • rniwa@webkit.org's avatar
      Deleting across multiple paragraphs can change the style of surrounding text · 69e647cc
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97266
      
      Reviewed by Levi Weintraub.
      
      Source/WebCore: 
      
      Preserve editing styles from CSS rules in wrappingStyleForSerialization as well as inline styles
      even when we're not annotating. We don't want to preserve all styles because it's against
      the user expectation to keep borders, etc... when merging paragraphs. We also don't want to copy
      styles from a mail blockquote because that's not a style the user has applied. See the comment
      in EditingStyle::wrappingStyleForSerialization.
      
      Test: editing/deleting/merge-paragraph-with-style-from-rule.html
      
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
      (WebCore::EditingStyle::wrappingStyleForSerialization):
      
      LayoutTests: 
      
      Added a regression test and rebaselined tests.
      
      * editing/deleting/delete-before-block-image-2-expected.txt:
      * editing/deleting/merge-paragraph-from-p-with-style-expected.txt:
      * editing/deleting/merge-paragraph-from-p-with-style.html: We changed the behavior. The editing style of p
      is now preserved when merging paragraphs.
      * editing/deleting/merge-paragraph-with-style-from-rule-expected.txt: Added.
      * editing/deleting/merge-paragraph-with-style-from-rule.html: Added.
      * platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e647cc
    • mitz@apple.com's avatar
      Reversing a GlyphBuffer needlessly queries its size multiple times · 7e225ccf
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98530
      
      Reviewed by Simon Fraser.
      
      No new tests because there is no change in behavior.
      
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForSimpleText): Replaced the condition
      (i < glyphBuffer.size() / 2) with the equivalent test (i < end).
      * platform/graphics/mac/FontComplexTextMac.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForComplexText): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e225ccf