1. 08 Apr, 2008 3 commits
    • aroben@apple.com's avatar
      Move callOnMainThread to WTF · 614f946c
      aroben@apple.com authored
      JavaScriptCore:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              Added new files.
      
              * wtf/MainThread.cpp:
              * wtf/MainThread.h:
              * wtf/gtk/MainThreadGtk.cpp:
              * wtf/mac/MainThreadMac.mm:
              * wtf/qt/MainThreadQt.cpp:
              * wtf/win/MainThreadWin.cpp:
              * wtf/wx/MainThreadWx.cpp:
              Moved here from WebCore/platform. Replaced all instances of "WebCore"
              with "WTF".
      
              * kjs/bool_object.cpp: Touched to force JavaScriptCore.vcproj to
              build.
              to the WTF namespace.
              * wtf/ThreadingWin.cpp:
              (WTF::initializeThreading): Call initializeMainThread.
      
      WebCore:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCoreSources.bkl:
              Removed MainThread files.
      
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              * loader/icon/IconDatabase.cpp:
              (WebCore::iconDatabase):
              * storage/Database.cpp:
              (WebCore::Database::Database):
              * storage/DatabaseTracker.cpp:
              Updated #includes and replaced calls to
              WebCore::initializeThreadingAndMainThread with calls to
              KJS::initializeThreading.
      
              * platform/MainThread.cpp: Removed.
              * platform/MainThread.h: Removed.
              * platform/gtk/MainThreadGtk.cpp: Removed.
              * platform/mac/MainThreadMac.mm: Removed.
              * platform/qt/MainThreadQt.cpp: Removed.
              * platform/win/MainThreadWin.cpp: Removed.
              * platform/wx/MainThreadWx.cpp: Removed.
      
      WebKit/gtk:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * webkit/webkitprivate.cpp: Updated #include.
              (webkit_init): Changed to call KJS::initializeThreading.
      
      WebKit/win:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * WebIconDatabase.cpp: Updated #include
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      614f946c
    • sfalken@apple.com's avatar
      Fix ChangeLog · 4b4fc124
      sfalken@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b4fc124
    • sfalken@apple.com's avatar
      Add missing increment/decrement COM class counts to detect leaks. · 04fc747b
      sfalken@apple.com authored
              
              Reviewed by Adam Roben.
      
              * CFDictionaryPropertyBag.cpp:
              (CFDictionaryPropertyBag::CFDictionaryPropertyBag):
              (CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
              * CFDictionaryPropertyBag.h:
              * HTTPHeaderPropertyBag.cpp:
              (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
              (HTTPHeaderPropertyBag::~HTTPHeaderPropertyBag):
              * HTTPHeaderPropertyBag.h:
              * WebActionPropertyBag.cpp:
              (WebActionPropertyBag::WebActionPropertyBag):
              (WebActionPropertyBag::~WebActionPropertyBag):
              * WebDocumentLoader.cpp:
              (WebDocumentLoader::WebDocumentLoader):
              (WebDocumentLoader::~WebDocumentLoader):
              * WebDropSource.cpp:
              (WebDropSource::WebDropSource):
              (WebDropSource::~WebDropSource):
              * WebDropSource.h:
              * WebElementPropertyBag.cpp:
              (WebElementPropertyBag::WebElementPropertyBag):
              (WebElementPropertyBag::~WebElementPropertyBag):
              * WebTextRenderer.cpp:
              (WebTextRenderer::WebTextRenderer):
              (WebTextRenderer::~WebTextRenderer):
              * WebView.cpp:
              (WebView::updateActiveState):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04fc747b
  2. 07 Apr, 2008 4 commits
  3. 06 Apr, 2008 1 commit
  4. 05 Apr, 2008 6 commits
  5. 04 Apr, 2008 6 commits
  6. 03 Apr, 2008 12 commits
    • mitz@apple.com's avatar
      WebCore: · cd4813bc
      mitz@apple.com authored
      2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
      
              Updated by Dan Bernstein. Reviewed by Dave Hyatt.
      
              - WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>
      
              Build fixes for platforms other than Mac and Windows to come.
      
              * WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
      
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
              return additional weight value keywords 100, 200, 300, 500, 600, 800
              and 900.
      
              * css/CSSFontSelector.cpp:
              (WebCore::hashForFont): Changed the bold parameter into a weight
              parameter and added the weight to the string to be hashed.
              (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS
              weight values to the font description.
              (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to
              go through all weights equal or lighter from the desired weight. For
              SVG, to also consider heavier weights.
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight
              property.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS
              weight values to the font description.
      
              * platform/graphics/Font.h:
              (WebCore::Font::weight): Updated for the change to
              FontDescription::weight().
      
              * platform/graphics/FontCache.cpp:
              (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced
              the bold component of the key with a weight component.
              (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above.
              (WebCore::computeHash): Ditto.
              (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed
              unnecessary parameters.
              (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto.
              (WebCore::FontCache::getCachedFontPlatformData): Updated for the change
              in FontPlatformDataCacheKey.
      
              * platform/graphics/FontDescription.cpp: Added.
              (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS
              font-weight value if there is one, or the lightest value.
              (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS
              font-weight value if there is one, or the heaviest value.
      
              * platform/graphics/FontDescription.h:
              (WebCore::FontWeight): Added this enumeration.
              (WebCore::FontDescription::FontDescription):
              (WebCore::FontDescription::bold): Removed.
              (WebCore::FontDescription::weight): Changed to return a FontWeight.
              (WebCore::FontDescription::setBold): Removed.
              (WebCore::FontDescription::setWeight): Changed to take a FontWeight.
      
              * platform/graphics/mac/FontCacheMac.mm:
              (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit
              font weight scale of 0-15.
              (WebCore::isAppKitFontWeightBold): Added.
              (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight
              instead of the bold trait for custom fonts, and to decide whether to
              synthesize bold based on the weights rather than the bold trait.
              (WebCore::FontCache::fontExists): Updated for the change in
              WebFontCache .
              (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
              decide whether to synthesize bold based on the weights rather than on
              the bold trait.
      
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font
              weight constant.
              (WebCore::isGDIFontWeightBold): Added.
              (WebCore::adjustedGDIFontWeight): Added.
              (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this
              data structure for use by the following callback.
              (WebCore::matchImprovingEnumProc): Added. The logic of this method is a
              simplification of the betterChoice() predicate in WebFontCache.mm, which
              considers only the italic trait and the weight.
              (WebCore::createGDIFont): Added. Similarly to
              +[WebFontCache fontWithFamily:traits:weight:size:], this function
              finds the closest match in the family for the desired italic bit and
              weight.
              (WebCore::FontCache::fontExists): Changed to call createGDIFont().
              (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
              compute the synthetic bold and synthetic italic flags based on weights
              and italic bits and pass them to the FontPlatformData constructor.
      
              * platform/graphics/win/FontPlatformDataWin.cpp:
              (WebCore::FontPlatformData::FontPlatformData): Changed the bold and
              oblique parameters to mean whether these should be synthesized and
              removed the font enumeration code that used to decide that.
      
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the
              synthetic bold and oblique flags from the full-size FontPlatformData to
              the FontPlatformData constructor for the small caps font.
      
              * platform/mac/WebCoreTextRenderer.h:
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreFindFont): Added a weight parameter, which is passed to
              +[WebFontCache fontWithFamily:traits:weight:size:].
      
              * platform/mac/WebFontCache.h:
              * platform/mac/WebFontCache.mm:
              (acceptableChoice):
              (betterChoice): Changed to ignore the bold trait. Changed the logic for
              deciding based on weights to prefer the font whose weight is closer to
              the desired one, or, if both candidates' weights are the same distance
              from the desired weight, the one that is more "off-center". 
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
              check for weight when matching by full name. Changed to pass
              the actual desired weight instead of the constant 5 to
              acceptableChoice() and betterChoice(). Changed to use weights to decide
              whether to synthesize bold.
              (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight
              parameter, which is passed to the internal method.
      
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::paint): Updated for the change to FontDescription.
      
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::updateFromElement): Ditto.
              (WebCore::RenderListBox::paintItemForeground): Ditto.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::toFontWeight): Added. Maps the AppKit font weight range of
              0-15 to the FontWeight range.
              (WebCore::RenderThemeMac::systemFont): Updated for the change to
              FontDescription.
      
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::systemFont): Ditto.
      
      WebKit/mac:
      
      2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
      
              Updated by Dan Bernstein. Reviewed by Dave Hyatt.
      
              - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _styleFromFontAttributes:]):
              (-[WebHTMLView _originalFontB]):
              (-[WebHTMLView _addToStyle:fontA:fontB:]):
      
      WebKit/win:
      
      2008-04-03  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              * DOMCoreClasses.cpp:
              (DOMElement::font): Updated for the change to FontDescription.
              * WebCoreSupport/WebDragClient.cpp:
              (dragLabelFont): Ditto.
              * WebKitGraphics.cpp:
              (makeFont): Ditto.
              * WebKitGraphics.h: Added a FIXME.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd4813bc
    • sfalken@apple.com's avatar
      <rdar://problem/5835382> Calling window.open immediately after... · 1d1ad199
      sfalken@apple.com authored
              <rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created
              
              Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
              just setting a string.
              
              Reviewed by Adam Roben.
      
              * WebView.cpp:
              (WebView::close): Add null check (found via code inspection).
              (WebView::initWithFrame): Store the group name directly in Page.
              (WebView::setGroupName): Store the group name directly in Page.
              (WebView::groupName): Retrieve the group name directly from Page.
              * WebView.h: Removed m_groupName
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d1ad199
    • hausmann@webkit.org's avatar
      9edb7e00
    • hausmann@webkit.org's avatar
      Attempted build fix · 8b3701f1
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b3701f1
    • hausmann@webkit.org's avatar
      2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com> · b545f43d
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              * Change IconDatabase::iconForPageURL to return more information. E.g. if
              an image has been found, or if the loading of an image has been scheduled.
              * Update FrameLoader to use another method to trigger reading from disk
              * Update the QWebFrame and QWebSettings
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b545f43d
    • hausmann@webkit.org's avatar
      Holger Hans Peter Freyther <holger.freyther@trolltech.com> · 742bb279
      hausmann@webkit.org authored
      * Safari is using the IconDatabase the following way (assumption). Before they
        call iconDatabase()->open they "retain" all URLs they are interested in, these
        could come from the history.
      * When opening the iconDatabase() a thread will be started that is going to import
        the URLs, all none manually retained URLs are scheduled for removal. The removal
        is going to happen when the next icon gets stored in the database.
      * We do not have any IconDatabase code, we can not retain the URLs before opening the
        database. To disable the automatic pruning of the icons we will ask the IconDatabase
        to delay this operation. This means our IconDatabase, when used, will grow, so we should
        try to have a IconDatabase class in 4.4.
      * The only way to counter the growth is a call to QWebSettings::clearIconDatabase
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      742bb279
    • hausmann@webkit.org's avatar
      f0b939c5
    • adachan@apple.com's avatar
      Allow WebArchive to be created via COM. · 98102f6d
      adachan@apple.com authored
              Replaced IID_DOMNode with __uuidof(DOMNode).
      
              Reviewed by Adam and Steve.
      
              * DOMCoreClasses.cpp:
              (DOMNode::QueryInterface):
              (DOMNode::isSameNode):
              * DOMCoreClasses.h:
              * ForEachCoClass.h:
              * Interfaces/WebKit.idl:
              * WebArchive.cpp:
              (WebArchive::createInstance):
              * WebArchive.h:
              * WebKitClassFactory.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98102f6d
    • hausmann@webkit.org's avatar
      Benjamin Meyer <bmeyer@trolltech.com> · ca308915
      hausmann@webkit.org authored
      Add a way to get the site icon for a url
      static QPixmap iconForUrl(const QUrl &url);
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca308915
    • hausmann@webkit.org's avatar
      Holger Hans Peter Freyther <holger.freyther@trolltech.com> · 33e1c88c
      hausmann@webkit.org authored
      * Update the Copyright info in QWebSettings
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33e1c88c
    • hausmann@webkit.org's avatar
      Holger Hans Peter Freyther <holger.freyther@trolltech.com> · 263e3541
      hausmann@webkit.org authored
      * The isEmpty check is not needed anymore with the earlier backport
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      263e3541
    • hausmann@webkit.org's avatar
      Holger Hans Peter Freyther <holger.freyther@trolltech.com> · ac7c94f4
      hausmann@webkit.org authored
      * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
        is not exporting enough to create the output in DRT itself. Settle with the approach
        Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
      * run-webkit-tests http/tests(/loading) can now be executed.
      * For tests in loading/ directories we are going to throw away the dirty
        QWebPage to start with something clean.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac7c94f4
  7. 02 Apr, 2008 6 commits
  8. 01 Apr, 2008 2 commits
    • beidson@apple.com's avatar
      WebKit/win: · dfa17df1
      beidson@apple.com authored
              Reviewed by Jon Honeycutt and Cake
      
              Hookup WebArchive API enough to be able to save the archive of a DOMNode
              
              * DOMCoreClasses.h: Add a GUID for DOMNode
      
              * Interfaces/IWebArchive.idl: Add initWithNode()
      
              * WebArchive.cpp:
              (WebArchive::initWithNode):
              (WebArchive::data): Actually return LegacyWebArchive-style data
              * WebArchive.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfa17df1
    • beidson@apple.com's avatar
      WebCore: · 74e89da0
      beidson@apple.com authored
              Reviewed by Adam Roben
      
              Export loader/archive and loader/archive/cf headers for WebKitWin to use
      
              * WebCore.vcproj/WebCore.vcproj:
      
      WebKit/win:
              Reviewed by Adam Roben
      
              Add empty implementations of WebArchive for future work
              
              * WebArchive.cpp: Added.
              (WebArchive::createInstance):
              (WebArchive::WebArchive):
              (WebArchive::~WebArchive):
              (WebArchive::QueryInterface):
              (WebArchive::AddRef):
              (WebArchive::Release):
              (WebArchive::initWithMainResource):
              (WebArchive::initWithData):
              (WebArchive::mainResource):
              (WebArchive::subResources):
              (WebArchive::subframeArchives):
              (WebArchive::data):
              * WebArchive.h: Added.
              
              * WebKit.vcproj/WebKit.vcproj:
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e89da0