1. 08 Apr, 2008 13 commits
    • aroben@apple.com's avatar
      Move callOnMainThread to WTF · 614f946c
      aroben@apple.com authored
      JavaScriptCore:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              Added new files.
      
              * wtf/MainThread.cpp:
              * wtf/MainThread.h:
              * wtf/gtk/MainThreadGtk.cpp:
              * wtf/mac/MainThreadMac.mm:
              * wtf/qt/MainThreadQt.cpp:
              * wtf/win/MainThreadWin.cpp:
              * wtf/wx/MainThreadWx.cpp:
              Moved here from WebCore/platform. Replaced all instances of "WebCore"
              with "WTF".
      
              * kjs/bool_object.cpp: Touched to force JavaScriptCore.vcproj to
              build.
              to the WTF namespace.
              * wtf/ThreadingWin.cpp:
              (WTF::initializeThreading): Call initializeMainThread.
      
      WebCore:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCoreSources.bkl:
              Removed MainThread files.
      
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              * loader/icon/IconDatabase.cpp:
              (WebCore::iconDatabase):
              * storage/Database.cpp:
              (WebCore::Database::Database):
              * storage/DatabaseTracker.cpp:
              Updated #includes and replaced calls to
              WebCore::initializeThreadingAndMainThread with calls to
              KJS::initializeThreading.
      
              * platform/MainThread.cpp: Removed.
              * platform/MainThread.h: Removed.
              * platform/gtk/MainThreadGtk.cpp: Removed.
              * platform/mac/MainThreadMac.mm: Removed.
              * platform/qt/MainThreadQt.cpp: Removed.
              * platform/win/MainThreadWin.cpp: Removed.
              * platform/wx/MainThreadWx.cpp: Removed.
      
      WebKit/gtk:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * webkit/webkitprivate.cpp: Updated #include.
              (webkit_init): Changed to call KJS::initializeThreading.
      
      WebKit/win:
      
              Move callOnMainThread to WTF
      
              Reviewed by Alexey Proskuryakov.
      
              * WebIconDatabase.cpp: Updated #include
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      614f946c
    • mrowe@apple.com's avatar
      2008-04-08 Mark Rowe <mrowe@apple.com> · 7e34adfb
      mrowe@apple.com authored
              Clean up after Brady.
      
              * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e34adfb
    • aroben@apple.com's avatar
      Combine :equal operations with the following operation if they are... · 8a68334f
      aroben@apple.com authored
              Combine :equal operations with the following operation if they are fewer than 3 characters long
      
              This keeps us from showing lots of small changes on long lines, just
              because some letters happened to be the same.
      
              Inspired by
              http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147
      
              * PrettyPatch/PrettyPatch.rb:
              (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
              than 3 characters long. The characters from the removed operations
              become part of the subsequent operation.
              (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
              <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
              @toLineNumber.nil? checks as they are no longer reliable now that
              we're removing operations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a68334f
    • sfalken@apple.com's avatar
      Fix ChangeLog · 4b4fc124
      sfalken@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b4fc124
    • sfalken@apple.com's avatar
      Add missing increment/decrement COM class counts to detect leaks. · 04fc747b
      sfalken@apple.com authored
              
              Reviewed by Adam Roben.
      
              * CFDictionaryPropertyBag.cpp:
              (CFDictionaryPropertyBag::CFDictionaryPropertyBag):
              (CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
              * CFDictionaryPropertyBag.h:
              * HTTPHeaderPropertyBag.cpp:
              (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
              (HTTPHeaderPropertyBag::~HTTPHeaderPropertyBag):
              * HTTPHeaderPropertyBag.h:
              * WebActionPropertyBag.cpp:
              (WebActionPropertyBag::WebActionPropertyBag):
              (WebActionPropertyBag::~WebActionPropertyBag):
              * WebDocumentLoader.cpp:
              (WebDocumentLoader::WebDocumentLoader):
              (WebDocumentLoader::~WebDocumentLoader):
              * WebDropSource.cpp:
              (WebDropSource::WebDropSource):
              (WebDropSource::~WebDropSource):
              * WebDropSource.h:
              * WebElementPropertyBag.cpp:
              (WebElementPropertyBag::WebElementPropertyBag):
              (WebElementPropertyBag::~WebElementPropertyBag):
              * WebTextRenderer.cpp:
              (WebTextRenderer::WebTextRenderer):
              (WebTextRenderer::~WebTextRenderer):
              * WebView.cpp:
              (WebView::updateActiveState):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04fc747b
    • aroben@apple.com's avatar
      Change PrettyPatch to use DiffBuilder for intra-line diffs · 3c78b78b
      aroben@apple.com authored
              This gives us much prettier intra-line diffs, largely because it can
              distinguish multiple changes on the same line. e.g., if a line changes
              from:
      
              const int myConstant = 0;
      
              to
      
              static const unsigned myConstant;
      
              You will see that "static " was inserted, "int" changed to "unsigned",
              and " = 0" was deleted.
      
              This seems to have also gotten rid of some spurious instances of
              "<ins></ins>" and "<del></del>" at the end of a line.
      
              * PrettyPatch/PrettyPatch.rb:
              (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
              setChangeExtentFromLine (which had been copied from Trac's diffing
              code).
              (PrettyPatch::CodeLine):
               - Removed the changeExtent attribute
               - Added the operations attribute
               - Removed the setChangeExtentFromLine method
              (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
              what text to wrap in <ins> and <del> tags.
              * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
              (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
              method, but left out the calls to perform_operation, since we build
              the diff HTML outside of this class.
              (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
              convert_html_to_list_of_words, since we're not diffing HTML.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c78b78b
    • aroben@apple.com's avatar
      Check in diff.rb · ede3083c
      aroben@apple.com authored
              This came from
              http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
              revision 28521
      
              * PrettyPatch/diff.rb: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ede3083c
    • timothy@apple.com's avatar
      Makes the Network timeline graph resource sizes on the bar graph · 092a0052
      timothy@apple.com authored
      when Transfer Size is selected.
      
      http://bugs.webkit.org/show_bug.cgi?id=18351
      
      Reviewed by Adam Roben.
      
      * page/inspector/Resource.js:
      (WebInspector.Resource.CompareByTime): Array sorting function for time.
      Copied from WebInspector.NetworkPanel.timelineEntryCompare.
      
      * page/inspector/ResourcesPanel.js:
      (WebInspector.NetworkPanel): Set the selectedIndex of graphModeSelectElement to
      make Transfer Time the default graph.
      (WebInspector.NetworkPanel.prototype.changeGraphMode): Call calculator.reset,
      _refreshAllResources and _updateGraphDividersIfNeeded.
      (WebInspector.NetworkPanel.prototype.get totalDuration): Removed.
      (WebInspector.NetworkPanel.prototype._updateGraphBoundriesIfNeeded): Removed boundary
      checking code and just call calculator.updateBoundries.
      (WebInspector.NetworkPanel.prototype._updateGraphDividersIfNeeded): Add a force argument.
      Use calculator.boundarySpan when computing the slice. If the slice is NaN, don't make a label.
      Ask the calculator to format the label values for each slice.
      (WebInspector.NetworkPanel.prototype.clearTimeline): Call calculator.reset.
      (WebInspector.NetworkPanel.timelineEntryCompare): Call WebInspector.Resource.CompareByTime.
      
      (WebInspector.NetworkTimelineEntry.prototype.refresh): Ask the panel's calculator to compute
      bar graph percentages for a resource. Use those percentages to change the bar style.
      
      (WebInspector.ResourceCalculator): Renamed from WebInspector.TimelineValueCalculator.
      (WebInspector.ResourceCalculator.prototype.computeSummaryValues): Changed the Array.forEach
      to a normal for loop. Work with resources instead of TimelineEntries.
      (WebInspector.ResourceCalculator.prototype.computeBarGraphPercentages): Return basic bar graph
      percents with start always being zero.
      (WebInspector.ResourceCalculator.prototype.get boundarySpan): Return the difference between
      maximumBoundary and minimumBoundary.
      (WebInspector.ResourceCalculator.prototype.updateBoundries): Update maximumBoundary based on _value.
      The minimumBoundary is always zero.
      (WebInspector.ResourceCalculator.prototype.reset): Delete maximumBoundary and minimumBoundary.
      (WebInspector.ResourceCalculator.prototype._value): Takes a Resource instead of TimelineEntry.
      
      (WebInspector.ResourceTransferTimeCalculator): Renamed from TransferTimeCalculator.
      (WebInspector.ResourceTransferTimeCalculator.prototype.computeSummaryValues): Work with resources
      instead of entries. Changed the Array.forEach to a normal for loop.
      (WebInspector.ResourceTransferTimeCalculator.prototype.computeBarGraphPercentages): Return percents
      just like WebInspector.NetworkTimelineEntry.prototype.refresh was doing before.
      (WebInspector.ResourceTransferTimeCalculator.prototype.updateBoundries): Update minimumBoundary and
      maximumBoundary just like the checks WebInspector.NetworkPanel.prototype._updateGraphBoundriesIfNeeded was doing.
      
      (WebInspector.ResourceTransferSizeCalculator): Renamed from TransferSizeCalculator.
      (WebInspector.ResourceTransferSizeCalculator.prototype._value): Takes a Resource instead of TimelineEntry.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      092a0052
    • beidson@apple.com's avatar
      WebKitTools: · 548a369e
      beidson@apple.com authored
      2008-04-08  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Mitzpettel
      
              Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
              -WebArchive subresources dump in random order, intermittent failures
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (compareResourceURLs): Sorting function based on the resource URLs
              (serializeWebArchiveToXML): Sort the subresource array
      
      LayoutTests:
      
      2008-04-08  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Mitzpettel
      
              Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
              -WebArchive subresources dump in random order, intermittent failures
      
              Now that a DRT fix has set the order, these 3 tests needed new results
      
              * webarchive/test-css-import-expected.txt:
              * webarchive/test-duplicate-resources-expected.txt:
              * webarchive/test-frameset-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      548a369e
    • rwlbuis@webkit.org's avatar
      Fix the SVG build. · 8364eb79
      rwlbuis@webkit.org authored
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::filterEffect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8364eb79
    • alice.liu@apple.com's avatar
      2008-04-08 Alice Liu <alice.liu@apple.com> · a90f5a0b
      alice.liu@apple.com authored
              Reviewed by Dan Bernstein.
              
              fixed http://bugs.webkit.org/show_bug.cgi?id=18329
              REGRESSION: Assertion failure in -[WebViewFactory endOfTextMarkerRange:] 
              when invoking the Dictionary pop-up
      
              * page/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
              In the section of code where WebCore-equivalents of mac-specific types are
              prepared, some functions weren't meant to operate on the default initialized
              values.  Checking for nil in certain places will better maintain the original
              pre-refactoring code path. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a90f5a0b
    • mitz@apple.com's avatar
      2008-04-08 Dan Bernstein <mitz@apple.com> · 5c5b3fff
      mitz@apple.com authored
              - fix most of the Windows layout test regressions from the font-weight patch
      
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::matchImprovingEnumProc): Changed to be symmetric with respect
              to italics: always prefer (reject) a candidate that changes the italics
              trait to (from) the desired value.
              (WebCore::createGDIFont): Added code to set more members of the LOGFONT
              structure before creating the font.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c5b3fff
    • rwlbuis@webkit.org's avatar
      Reviewed by Ollie. · 164bcf54
      rwlbuis@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=18354
              feFlood in attribute should be removed according to SVG 1.1 Errata
      
              Remove the in attribute from SVGFEFlood DOM.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      164bcf54
  2. 07 Apr, 2008 27 commits
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 2e97f8fc
      beidson@apple.com authored
              Rubberstamped by Geoff Garen
      
              Forgot to update these results after I added the Prototype
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e97f8fc
    • alice.liu@apple.com's avatar
      build fix for gtk. hopefully the only one · d2f9b01a
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2f9b01a
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 2332ff01
      beidson@apple.com authored
              I can't fathom why the new storage tests could be hanging, but alas they are on Windows
              Disable until I can figure out why
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2332ff01
    • alice.liu@apple.com's avatar
      I "objeect" to that previous build fix · d9ecef83
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9ecef83
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 47936a4e
      beidson@apple.com authored
              OMG, BUILD - please!
      
              * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47936a4e
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 355c7266
      beidson@apple.com authored
              Touch JSStorageCustom.cpp to try to FORCE a recompile on bots that haven't gotten the message
      
              * bindings/js/JSStorageCustom.cpp:
              (WebCore::JSStorage::customPut):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      355c7266
    • alice.liu@apple.com's avatar
      qt build fix. third time is hopefully the charm. · a69e1700
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a69e1700
    • alice.liu@apple.com's avatar
      attempt at wx build fix · 15c61d6a
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15c61d6a
    • alice.liu@apple.com's avatar
      another attempt at qt build fix · cf6ef1c4
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf6ef1c4
    • alice.liu@apple.com's avatar
      attempt at fixing qt build · 1aa5ee70
      alice.liu@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa5ee70
    • beidson@apple.com's avatar
      WebCore: · d3e87050
      beidson@apple.com authored
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Reviewed by John Honeycutt
      
              ENABLE_DOM_STORAGE for Windows
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/build-generated-files.sh:
      
      WebKit/win:
      
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Reviewed by John Honeycutt
      
              ENABLE_DOM_STORAGE for Windows
      
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3e87050
    • beidson@apple.com's avatar
      JavaScriptCore: · 4d5283d4
      beidson@apple.com authored
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
      
              * Configurations/JavaScriptCore.xcconfig:
      
      WebKit/mac:
      
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
      
              * Configurations/WebKit.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d5283d4
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 4d330957
      beidson@apple.com authored
              Fix build for builds without DOM_STORAGE enabled
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/EventTargetNode.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d330957
    • alice.liu@apple.com's avatar
      2008-04-07 Alice Liu <alice.liu@apple.com> · 55fb47fe
      alice.liu@apple.com authored
              Reviewed by Beth Dakin.
      
              * WebCore.vcproj/WebCore.vcproj:
                  Added a few cross-platform accessibility source files
                  
              * WebCore.xcodeproj/project.pbxproj:
                  Added AXObjectCache.cpp
                  
              * page/AXObjectCache.cpp: Added.
                  These were made cross-platform:
              (WebCore::AXObjectCache::~AXObjectCache):
              (WebCore::AXObjectCache::get):
              (WebCore::AXObjectCache::remove):
              (WebCore::AXObjectCache::childrenChanged):
              
              * page/AXObjectCache.h:
                  These were made platform-specific
              (WebCore::AXObjectCache::isIDinUse):
              (WebCore::AXObjectCache::detachWrapper):
              (WebCore::AXObjectCache::attachWrapper):
              (WebCore::AXObjectCache::postNotificationToElement):
              
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::detach):
                  Since only the mac has a wrapper for now, so temporarily 
                  wrapping this line in #if PLATFORM(MAC)
                  
              (WebCore::AccessibilityObject::removeAXObjectID):
                  Since only the mac has uses Accessibility Object IDs,
                  wrap this line in #if PLATFORM(MAC)
                  
              * page/mac/AXObjectCacheMac.mm:
                  Detaching and attaching the wrapper is platform-specific 
                  since each wrapper class is platform-specific.
              (WebCore::AXObjectCache::detachWrapper):
              (WebCore::AXObjectCache::attachWrapper):        
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55fb47fe
    • beidson@apple.com's avatar
      WebCore: · c2e6fd7e
      beidson@apple.com authored
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Lovingly reviewed by Sam Weinig
      
              <rdar://problem/5797684> - HTML5 SessionStorage and underpinnings for LocalStorage
      
              Tests: storage/domstorage/sessionstorage/iframe-events.html
                     storage/domstorage/sessionstorage/index-get-and-set.html
                     storage/domstorage/sessionstorage/simple-events.html
                     storage/domstorage/sessionstorage/simple-usage.html
                     storage/domstorage/sessionstorage/window-open.html
                     storage/domstorage/window-attributes-exist.html
      
              * Configurations/WebCore.xcconfig: Define to enable DOM_STORAGE
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::mark): Add optionalSessionStorage case
      
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS): Add StorageEvent case
      
              * bindings/js/JSStorageCustom.cpp:
              (WebCore::JSStorage::canGetItemsForName):
              (WebCore::JSStorage::nameGetter): If the property doesn't exist on the object, call through to getItem()
              (WebCore::JSStorage::customPut): If the property doesn't exist on the object, call through to setItem()
      
              * dom/Event.cpp:
              (WebCore::Event::isStorageEvent):
              * dom/Event.h:
      
              * dom/EventNames.h: Add "storage"
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/EventTargetNode.h:
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::createWindow): After a new page has been created, set its SessionStorage object
                to a copy of the previous Page's
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::sessionStorage): Accessor to pull the appropriate OriginStorage out of the Page's
                SessionStorage.
              (WebCore::DOMWindow::localStorage): To be filled in later
              * page/DOMWindow.h:
              (WebCore::DOMWindow::optionalSessionStorage): Return the session Storage object for this window to mark, 
                if any exists
              * page/DOMWindow.idl:
      
              * page/Page.cpp:
              (WebCore::Page::sessionStorage):  Create and/or return the SessionStorage for this Page.
              (WebCore::Page::setSessionStorage): Set the SessionStorage for this Page - used in FrameLoader after a
                Window.open();
              * page/Page.h:
      
              * storage/OriginStorage.cpp: Intermediate layer between individual Storage objects, and shared StorageMap 
                objects.  There is one OriginStorage object per SecurityOrigin in each "unique set of storage areas", such
                as the SessionStorage.  This layer forwards DOM-level calls down to the backing StorageMap, handles 
                copy-on-write along with the StorageMap, fires StorageEvents to the DOM when a value is changed, and will
                eventually handle quota enforcement.
              (WebCore::OriginStorage::create):
              (WebCore::OriginStorage::OriginStorage):
              (WebCore::OriginStorage::~OriginStorage):
              (WebCore::OriginStorage::copy):
              (WebCore::OriginStorage::length):
              (WebCore::OriginStorage::key):
              (WebCore::OriginStorage::getItem):
              (WebCore::OriginStorage::setItem):
              (WebCore::OriginStorage::removeItem):
              (WebCore::OriginStorage::contains):
              (WebCore::OriginStorage::dispatchStorageEvent):
              * storage/OriginStorage.h:
      
              * storage/SessionStorage.cpp: From the HTML5 spec:
                "Each top-level browsing context has a unique set of session storage areas, one for each origin."
                This object represents that "unique set of session storage areas", and creates or returns the Storage
                object for the requested SecurityOrigin
              (WebCore::SessionStorage::create):
              (WebCore::SessionStorage::SessionStorage):
              (WebCore::SessionStorage::copy):
              (WebCore::SessionStorage::originStorage):
              * storage/SessionStorage.h:
              (WebCore::SessionStorage::page):
      
              * storage/Storage.cpp: Representation of the DOM-level object, wrapped by JSStorage.  There is a unique
                Storage object per Window (per-Frame) that wraps a specific shared OriginStorage object.
              (WebCore::Storage::create):
              (WebCore::Storage::Storage):
              (WebCore::Storage::length):
              (WebCore::Storage::key):
              (WebCore::Storage::getItem):
              (WebCore::Storage::setItem):
              (WebCore::Storage::removeItem):
              (WebCore::Storage::contains):
              * storage/Storage.h:
              * storage/Storage.idl:
      
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.h:
              (WebCore::StorageEvent::isStorageEvent):
      
              * storage/StorageMap.cpp: The physical map of key/value pairs that is shared between OriginStorage objects, 
                and implements copy-on-write semantics whenever a value is changed
              (WebCore::StorageMap::create):
              (WebCore::StorageMap::StorageMap):
              (WebCore::StorageMap::copy):
              (WebCore::StorageMap::invalidateIterator): Used to support the key(unsigned i) part of the API
              (WebCore::StorageMap::setIteratorToIndex): Ditto
              (WebCore::StorageMap::length):
              (WebCore::StorageMap::key):
              (WebCore::StorageMap::getItem):
              (WebCore::StorageMap::setItem):
              (WebCore::StorageMap::removeItem):
              (WebCore::StorageMap::contains):
              * storage/StorageMap.h:
      
      LayoutTests:
      
      2008-04-07  Brady Eidson  <beidson@apple.com>
      
              Begrudgingly reviewed by Sam Weinig
      
              Initial suite of layout tests for HTML5 key/value SessionStorage (<rdar://problem/5797684>)
      
              * fast/dom/Window/window-properties-expected.txt:
              * storage/domstorage: Added.
              * storage/domstorage/localstorage: Added.
              * storage/domstorage/sessionstorage: Added.
              * storage/domstorage/sessionstorage/iframe-events-expected.txt: Added.
              * storage/domstorage/sessionstorage/iframe-events.html: Added.
              * storage/domstorage/sessionstorage/index-get-and-set-expected.txt: Added.
              * storage/domstorage/sessionstorage/index-get-and-set.html: Added.
              * storage/domstorage/sessionstorage/resources: Added.
              * storage/domstorage/sessionstorage/resources/clearSessionStorage.js: Added.
              * storage/domstorage/sessionstorage/resources/iframe-events-second.html: Added.
              * storage/domstorage/sessionstorage/resources/window-open-second.html: Added.
              * storage/domstorage/sessionstorage/simple-events-expected.txt: Added.
              * storage/domstorage/sessionstorage/simple-events.html: Added.
              * storage/domstorage/sessionstorage/simple-usage-expected.txt: Added.
              * storage/domstorage/sessionstorage/simple-usage.html: Added.
              * storage/domstorage/sessionstorage/window-open-expected.txt: Added.
              * storage/domstorage/sessionstorage/window-open.html: Added.
              * storage/domstorage/window-attributes-exist-expected.txt: Added.
              * storage/domstorage/window-attributes-exist.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2e6fd7e
    • timothy@apple.com's avatar
      Renamed various functions that are internal to the Console object to have an underscore prefix. · f02a7bed
      timothy@apple.com authored
      Rubber-stamped by Adam Roben.
      
      * page/inspector/Console.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f02a7bed
    • timothy@apple.com's avatar
      Renamed various functions and properties that are internal to an object to... · dee8e986
      timothy@apple.com authored
      Renamed various functions and properties that are internal to an object to have an underscore prefix.
      
      Rubber-stamped by Adam Roben.
      
      * page/inspector/Resource.js:
      * page/inspector/ResourcesPanel.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dee8e986
    • aroben@apple.com's avatar
      Windows build fix · 1527713a
      aroben@apple.com authored
              * wtf/ThreadingWin.cpp: Back out some changes I didn't mean to land.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1527713a
    • timothy@apple.com's avatar
      Fixes coding style for two utility getters. · fc31cea8
      timothy@apple.com authored
      * page/inspector/utilities.js: Fix coding style for the
      totalOffsetLeft and totalOffsetTop getters.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc31cea8
    • sullivan@apple.com's avatar
      2008-04-07 John Sullivan <sullivan@apple.com> · ac65fe30
      sullivan@apple.com authored
              Reviewed by Tim
              
              - made the JavaScript text input panel not block Quit (part of 4133196)
      
              * English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib:
              * English.lproj/WebJavaScriptTextInputPanel.nib/info.nib:
              * English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:
              Made the panel be a NonBlockingPanel
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac65fe30
    • aroben@apple.com's avatar
      Export some more WTF functions from WebKit.dll · 5f28cd98
      aroben@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f28cd98
    • aroben@apple.com's avatar
      Add WTF::isMainThread · a3af6a64
      aroben@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              * wtf/Threading.h: Declare the new function.
              * wtf/ThreadingGtk.cpp:
              (WTF::initializeThreading): Initialize the main thread identifier.
              (WTF::isMainThread): Added.
              * wtf/ThreadingNone.cpp: Ditto ThreadingGtk.cpp.
              (WTF::initializeThreading):
              (WTF::isMainThread):
              * wtf/ThreadingPthreads.cpp: Ditto.
              (WTF::initializeThreading):
              (WTF::isMainThread):
              * wtf/ThreadingWin.cpp: Ditto.
              (WTF::initializeThreading):
              (WTF::isMainThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3af6a64
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 7cda5b10
      mitz@apple.com authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=18311
                <rdar://problem/5842980> REGRESSION (r31620): Font variants (e.g. Helvetica Neue *Light*) don't render correctly
      
              * platform/mac/WebFontCache.mm:
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
              match by family name first, and only if that fails, look for a match by
              full (PostScript) name. Reverted the full name-based match logic to only
              distinguish between the broad categories of "bold" and "not bold".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cda5b10
    • timothy@apple.com's avatar
      When the WebInspector.currentFocusElement changes, move the caret selection to... · 7e1bec54
      timothy@apple.com authored
      When the WebInspector.currentFocusElement changes, move the caret selection to be inside the focused element. This makes sure the caret moves in and out of the console when the focus changes.
      
      Reviewed by Adam Roben.
      
      * page/inspector/TextPrompt.js:
      (TextPrompt.prototype.isCaretInsidePrompt): Just call isInsertionCaretInside.
      * page/inspector/inspector.js:
      (WebInspector.set currentFocusElement): Make a caret selection inside
      the focused element if there isn't a range selection and there isn't
      already a caret selection inside.
      * page/inspector/utilities.js:
      (Element.prototype.isInsertionCaretInside): Added. Tests if the
      selection is collapsed and is inside the element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e1bec54
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · f65c9fae
      beidson@apple.com authored
              Reviewed by Tim Hatcher
      
              Add 1 more empty file for upcoming work, as a separate step, to keep all build-systems working
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
      
              * bindings/js/JSStorageCustom.cpp: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f65c9fae
    • ap@webkit.org's avatar
      Reviewed by Dan Bernstein. · b5383bee
      ap@webkit.org authored
              <rdar://problem/5574946> Inline frame ISO-8859-1 even though parent character set is UTF-8
      
              Test: fast/loader/inherit-charset-to-empty-frame.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write): Treat an empty m_encoding the same as null one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5383bee
    • timothy@apple.com's avatar
      Rename some Inspector panel objects to facilitate the up-coming · 75cbef39
      timothy@apple.com authored
      UI refresh changes.
      
      Reviewed by Adam Roben.
      
      * page/inspector/DatabasesPanel.js: Renamed ResourcePanel to ResourceView.
      * page/inspector/ElementsPanel.js: Renamed SourcePanel to SourceView.
      * page/inspector/FontView.js: Renamed FontPanel to FontView.
      * page/inspector/ImageView.js: Renamed ImagePanel to ImageView.
      * page/inspector/Resource.js: Instantiate the new "View" named objects.
      * page/inspector/ResourceView.js: Renamed ResourcePanel to ResourceView.
      * page/inspector/SourceView.js: Renamed SourcePanel to SourceView.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75cbef39