1. 28 Mar, 2013 1 commit
    • caseq@chromium.org's avatar
      Web Inspector: factor out node search controller from inspector.js · 60f0dce4
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112689
      
      Reviewed by Pavel Feldman.
      
      This just extracts the existing logic of toggling node search
      from inspector.js into a class of its own, InspectElementModeController.
      Drive-by: add CtrlOrMeta+Shift+C to help screen.
      
      * English.lproj/localizedStrings.js:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * inspector/compile-front-end.py:
      * inspector/front-end/InspectElementModeController.js: Added.
      (WebInspector.InspectElementModeController):
      (WebInspector.InspectElementModeController.createShortcut):
      (WebInspector.InspectElementModeController.prototype.enabled):
      (WebInspector.InspectElementModeController.prototype.disable):
      (WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
      (WebInspector.InspectElementModeController.prototype.toggleSearch):
      (WebInspector.InspectElementModeController.prototype.handleShortcut):
      * inspector/front-end/InspectorFrontendAPI.js:
      (InspectorFrontendAPI.enterInspectElementMode):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      (WebInspector._createGlobalStatusBarItems):
      (WebInspector._registerShortcuts):
      (WebInspector.documentKeyDown):
      (WebInspector._updateFocusedNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60f0dce4
  2. 26 Mar, 2013 1 commit
    • ch.dumez@sisa.samsung.com's avatar
      Code duplication between HTTPParsers and HTTPValidation · 3855a916
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113283
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
      HTTPParsers.h. They were doing exactly the same thing and their
      implementation was almost the same.
      
      Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
      seems like the proper place and it seems odd to keep HTTPValidation for
      just one function.
      
      No new tests, no behavior change for layout tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/network/HTTPParsers.cpp:
      (WebCore::isValidHTTPHeaderValue):
      (WebCore):
      (WebCore::isValidHTTPToken): Implementation is slightly simplified based on
      isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 || c == 0x7F) is
      replaced by (c >= 0x7F). (c <= 0x1F ||  c == ' ' || c == '\t') is replaced
      by (c <= 0x20). Those expressions are shorter but equivalent.
      (WebCore::contentDispositionType):
      * platform/network/HTTPParsers.h:
      * platform/network/HTTPValidation.cpp: Removed.
      * platform/network/HTTPValidation.h: Removed.
      * xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.
      
      Source/WebKit/chromium:
      
      * src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead
      of HTTPValidation.h to use isValidHTTPToken().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3855a916
  3. 25 Mar, 2013 1 commit
  4. 22 Mar, 2013 4 commits
    • ap@apple.com's avatar
      Split ResourceHandleMac into multiple files · 6366a11b
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113100
      
              Reviewed by Geoff Garen.
      
              It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
              substantially more complicated yet.
      
              1. Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
              2. Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into
              separate files.
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/SynchronousLoaderClient.cpp: Added.
              * platform/network/SynchronousLoaderClient.h: Added.
              * platform/network/cf/ResourceHandleCFNet.cpp:
              * platform/network/mac/SynchronousLoaderClient.mm: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6366a11b
    • commit-queue@webkit.org's avatar
      Use generated bindings for the Coordinates type used by Geolocation · e25524f8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112975
      
      Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
      Reviewed by Kentaro Hara.
      
      No new tests, refactoring only.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/geolocation/Coordinates.cpp: Renamed from Source/WebCore/bindings/js/JSCoordinatesCustom.cpp.
      (WebCore):
      (WebCore::Coordinates::altitude):
      (WebCore::Coordinates::altitudeAccuracy):
      (WebCore::Coordinates::heading):
      (WebCore::Coordinates::speed):
      * Modules/geolocation/Coordinates.h:
      (Coordinates):
      * Modules/geolocation/Coordinates.idl:
      * Target.pri:
      * UseJSC.cmake:
      * UseV8.cmake:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSBindingsAllInOne.cpp:
      * bindings/v8/custom/V8CoordinatesCustom.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e25524f8
    • commit-queue@webkit.org's avatar
      Move GeolocationClient.h to Modules/geolocation/ · aceea69d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112997
      
      Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
      Reviewed by Kentaro Hara.
      
      No new tests, no functional change.
      
      * GNUmakefile.list.am:
      * Modules/geolocation/GeolocationClient.h: Renamed from Source/WebCore/page/GeolocationClient.h.
      (WebCore):
      (GeolocationClient):
      (WebCore::GeolocationClient::~GeolocationClient):
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aceea69d
    • commit-queue@webkit.org's avatar
      Move page/Coordinates.[h|idl] to Modules/geolocation/ · 1a06ddd9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112945
      
      Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
      Reviewed by Kentaro Hara.
      
      No new tests, no functional change.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Modules/geolocation/Coordinates.h: Renamed from Source/WebCore/page/Coordinates.h.
      (WebCore):
      (Coordinates):
      (WebCore::Coordinates::create):
      (WebCore::Coordinates::isolatedCopy):
      (WebCore::Coordinates::latitude):
      (WebCore::Coordinates::longitude):
      (WebCore::Coordinates::altitude):
      (WebCore::Coordinates::accuracy):
      (WebCore::Coordinates::altitudeAccuracy):
      (WebCore::Coordinates::heading):
      (WebCore::Coordinates::speed):
      (WebCore::Coordinates::canProvideAltitude):
      (WebCore::Coordinates::canProvideAltitudeAccuracy):
      (WebCore::Coordinates::canProvideHeading):
      (WebCore::Coordinates::canProvideSpeed):
      (WebCore::Coordinates::Coordinates):
      * Modules/geolocation/Coordinates.idl: Renamed from Source/WebCore/page/Coordinates.idl.
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a06ddd9
  5. 21 Mar, 2013 4 commits
    • roger_fong@apple.com's avatar
      Move common props files for VS2010 solution to WebKitLibraries folder and... · 356fb46a
      roger_fong@apple.com authored
      Move common props files for VS2010 solution to WebKitLibraries folder and update all projects accordingly.
      
      * WebKit.vcxproj/FeatureDefines.props: Removed.
      * WebKit.vcxproj/FeatureDefinesCairo.props: Removed.
      * WebKit.vcxproj/WebKit/cURL.props: Removed.
      * WebKit.vcxproj/WinCairo.props: Removed.
      * WebKit.vcxproj/common.props: Removed.
      * WebKit.vcxproj/debug.props: Removed.
      * WebKit.vcxproj/debug_wincairo.props: Removed.
      * WebKit.vcxproj/debugsuffix.props: Removed.
      * WebKit.vcxproj/production.props: Removed.
      * WebKit.vcxproj/release.props: Removed.
      * win/tools/vsprops/FeatureDefines.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefines.props.
      * win/tools/vsprops/FeatureDefinesCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefinesCairo.props.
      * win/tools/vsprops/WinCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/WinCairo.props.
      * win/tools/vsprops/cURL.props: Copied from ../Source/WebKit/WebKit.vcxproj/WebKit/cURL.props.
      * win/tools/vsprops/common.props: Copied from ../Source/WebKit/WebKit.vcxproj/common.props.
      * win/tools/vsprops/debug.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug.props.
      * win/tools/vsprops/debug_wincairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug_wincairo.props.
      * win/tools/vsprops/debugsuffix.props: Copied from ../Source/WebKit/WebKit.vcxproj/debugsuffix.props.
      * win/tools/vsprops/production.props: Copied from ../Source/WebKit/WebKit.vcxproj/production.props.
      * win/tools/vsprops/release.props: Copied from ../Source/WebKit/WebKit.vcxproj/release.props.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      356fb46a
    • ap@apple.com's avatar
      Move non-trivial virtual functions out of ResourceHandleClient.h · 47ed39b0
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=112950
      
              Reviewed by Brady Eidson.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/ResourceHandleClient.cpp: Added.
              (WebCore::ResourceHandleClient::ResourceHandleClient):
              (WebCore::ResourceHandleClient::~ResourceHandleClient):
              (WebCore::ResourceHandleClient::didReceiveBuffer):
              (WebCore::ResourceHandleClient::getBuffer):
              * platform/network/ResourceHandleClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47ed39b0
    • fmalita@chromium.org's avatar
      [SVG] Remove explicit LightSource dispatchers · 96b9c2db
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112827
      
      Reviewed by Stephen Chenney.
      
      Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
      altogether.
      
      No new tests: refactoring only.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/filters/DistantLightSource.h:
      (DistantLightSource):
      * platform/graphics/filters/LightSource.cpp: Removed.
      * platform/graphics/filters/LightSource.h:
      (WebCore::LightSource::setAzimuth):
      (WebCore::LightSource::setElevation):
      (WebCore::LightSource::setX):
      (WebCore::LightSource::setY):
      (WebCore::LightSource::setZ):
      (WebCore::LightSource::setPointsAtX):
      (WebCore::LightSource::setPointsAtY):
      (WebCore::LightSource::setPointsAtZ):
      (WebCore::LightSource::setSpecularExponent):
      (WebCore::LightSource::setLimitingConeAngle):
      * platform/graphics/filters/PointLightSource.h:
      (PointLightSource):
      * platform/graphics/filters/SpotLightSource.h:
      (SpotLightSource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b9c2db
    • rniwa@webkit.org's avatar
      Merge MainResourceLoader into DocumentLoader · b1242489
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104969
      
      Patch by Nate Chapin <japhet@chromium.org> on 2013-03-21
      Reviewed by Adam Barth.
      
      No new tests, refactor only.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::DocumentLoader):
      (WebCore::DocumentLoader::mainResourceLoader):
      (WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
          ~MainResourceLoader.
      (WebCore::DocumentLoader::mainResourceData):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
      (WebCore):
      (WebCore::DocumentLoader::finishedLoading):
      (WebCore::DocumentLoader::handleSubstituteDataLoadNow):
      (WebCore::DocumentLoader::redirectReceived):
      (WebCore::DocumentLoader::continueAfterNavigationPolicy):
      (WebCore::DocumentLoader::responseReceived):
      (WebCore::DocumentLoader::continueAfterContentPolicy):
      (WebCore::DocumentLoader::reportMemoryUsage):
      (WebCore::DocumentLoader::dataReceived):
      (WebCore::DocumentLoader::clearMainResourceLoader):
      (WebCore::DocumentLoader::setDefersLoading):
      (WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
      (WebCore::DocumentLoader::addSubresourceLoader):
      (WebCore::DocumentLoader::maybeLoadEmpty):
      (WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
           for normal and empty loads, just use a single boolean.
      * loader/DocumentLoader.h:
      (WebCore::DocumentLoader::isLoadingMainResource):
      * loader/MainResourceLoader.cpp: Removed.
      * loader/MainResourceLoader.h: Removed.
      * loader/mac/DocumentLoaderMac.cpp:
      (WebCore::DocumentLoader::schedule):
      (WebCore::DocumentLoader::unschedule):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1242489
  6. 20 Mar, 2013 2 commits
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed VS2010 build correction. · 1ac1ff78
      bfulgham@webkit.org authored
      * WebCore.vcxproj/WebCore.vcxproj: Enable build of NetworkStorageSessionStub.cpp
      for WinCairo port.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Correct build type of
      CookieJarCurl from 'custom' to 'C++ source file'
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ac1ff78
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r146301. · 12613f59
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/146301
      https://bugs.webkit.org/show_bug.cgi?id=112776
      
      Caused hundreds of tests to hit assertions on Windows debug
      bots (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::DocumentLoader):
      (WebCore::DocumentLoader::mainResourceLoader):
      (WebCore::DocumentLoader::~DocumentLoader):
      (WebCore::DocumentLoader::mainResourceData):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::finishedLoading):
      (WebCore::DocumentLoader::handleSubstituteDataLoadNow):
      (WebCore::DocumentLoader::continueAfterNavigationPolicy):
      (WebCore::DocumentLoader::responseReceived):
      (WebCore::DocumentLoader::continueAfterContentPolicy):
      (WebCore::DocumentLoader::reportMemoryUsage):
      (WebCore::DocumentLoader::receivedData):
      (WebCore::DocumentLoader::clearMainResourceLoader):
      (WebCore::DocumentLoader::setDefersLoading):
      (WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
      (WebCore::DocumentLoader::addSubresourceLoader):
      (WebCore::DocumentLoader::isLoadingMainResource):
      (WebCore):
      (WebCore::DocumentLoader::maybeLoadEmpty):
      (WebCore::DocumentLoader::startLoadingMainResource):
      * loader/DocumentLoader.h:
      (WebCore):
      (DocumentLoader):
      * loader/MainResourceLoader.cpp: Added.
      (WebCore):
      (WebCore::MainResourceLoader::MainResourceLoader):
      (WebCore::MainResourceLoader::~MainResourceLoader):
      (WebCore::MainResourceLoader::create):
      (WebCore::MainResourceLoader::clearResource):
      (WebCore::MainResourceLoader::frameLoader):
      (WebCore::MainResourceLoader::request):
      (WebCore::MainResourceLoader::resourceData):
      (WebCore::MainResourceLoader::redirectReceived):
      (WebCore::MainResourceLoader::responseReceived):
      (WebCore::MainResourceLoader::dataReceived):
      (WebCore::MainResourceLoader::notifyFinished):
      (WebCore::MainResourceLoader::reportMemoryUsage):
      (WebCore::MainResourceLoader::load):
      (WebCore::MainResourceLoader::setDefersLoading):
      (WebCore::MainResourceLoader::defersLoading):
      (WebCore::MainResourceLoader::setDataBufferingPolicy):
      (WebCore::MainResourceLoader::loader):
      (WebCore::MainResourceLoader::identifier):
      * loader/MainResourceLoader.h: Added.
      (WebCore):
      (MainResourceLoader):
      (WebCore::MainResourceLoader::cachedMainResource):
      (WebCore::MainResourceLoader::documentLoader):
      * loader/mac/DocumentLoaderMac.cpp:
      (WebCore::DocumentLoader::schedule):
      (WebCore::DocumentLoader::unschedule):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12613f59
  7. 19 Mar, 2013 5 commits
    • japhet@chromium.org's avatar
      Merge MainResourceLoader into DocumentLoader · 939359fc
      japhet@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104969
      
      Reviewed by Adam Barth.
      
      No new tests, refactor only.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::DocumentLoader):
      (WebCore::DocumentLoader::mainResourceLoader):
      (WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
          ~MainResourceLoader.
      (WebCore::DocumentLoader::mainResourceData):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
      (WebCore):
      (WebCore::DocumentLoader::finishedLoading):
      (WebCore::DocumentLoader::handleSubstituteDataLoadNow):
      (WebCore::DocumentLoader::redirectReceived):
      (WebCore::DocumentLoader::continueAfterNavigationPolicy):
      (WebCore::DocumentLoader::responseReceived):
      (WebCore::DocumentLoader::continueAfterContentPolicy):
      (WebCore::DocumentLoader::reportMemoryUsage):
      (WebCore::DocumentLoader::dataReceived):
      (WebCore::DocumentLoader::clearMainResourceLoader):
      (WebCore::DocumentLoader::setDefersLoading):
      (WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
      (WebCore::DocumentLoader::addSubresourceLoader):
      (WebCore::DocumentLoader::maybeLoadEmpty):
      (WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
           for normal and empty loads, just use a single boolean.
      * loader/DocumentLoader.h:
      (WebCore::DocumentLoader::isLoadingMainResource):
      * loader/MainResourceLoader.cpp: Removed.
      * loader/MainResourceLoader.h: Removed.
      * loader/mac/DocumentLoaderMac.cpp:
      (WebCore::DocumentLoader::schedule):
      (WebCore::DocumentLoader::unschedule):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      939359fc
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed build correction for WebCore library. · b4cea9fa
      bfulgham@webkit.org authored
      * WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific frame source
      from WinCairo build.
      * WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Pass correct
      parameter to build-generated-files.sh for WinCairo build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4cea9fa
    • commit-queue@webkit.org's avatar
      Web Inspector: split Console into two entities, a web-facing bound object and page console. · 7195ba53
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111578
      
      Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-19
      Reviewed by Vsevolod Vlasov.
      
      Otherwise, a lot of logging in WebCore needs to go through the DOMWindow which is unnecessary.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * dom/Document.cpp:
      (WebCore::Document::addConsoleMessage):
      (WebCore::Document::addMessage):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::muteConsole):
      (WebCore::PageDebuggerAgent::unmuteConsole):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::muteConsole):
      (WebCore::PageRuntimeAgent::unmuteConsole):
      * page/Console.cpp:
      (WebCore::internalAddMessage):
      * page/Console.h:
      (WebCore):
      (Console):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::pageConsole):
      (WebCore):
      (WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
      (WebCore::DOMWindow::printErrorMessage):
      * page/DOMWindow.h:
      (WebCore):
      (DOMWindow):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (WebCore):
      (WebCore::Page::console):
      (Page):
      * page/PageConsole.cpp: Added.
      (WebCore::PageConsole::PageConsole):
      (WebCore):
      (WebCore::PageConsole::~PageConsole):
      (WebCore::PageConsole::printSourceURLAndLine):
      (WebCore::PageConsole::printMessageSourceAndLevelPrefix):
      (WebCore::PageConsole::addMessage):
      (WebCore::PageConsole::mute):
      (WebCore::PageConsole::unmute):
      (WebCore::PageConsole::shouldPrintExceptions):
      (WebCore::PageConsole::setShouldPrintExceptions):
      * page/PageConsole.h: Copied from Source/WebCore/page/Console.h.
      (WebCore):
      (PageConsole):
      (WebCore::PageConsole::create):
      (WebCore::PageConsole::page):
      * xml/XSLStyleSheetLibxslt.cpp:
      (WebCore::XSLStyleSheet::parseString):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      (WebCore::docLoaderFunc):
      
      Source/WebKit/mac:
      
      * Misc/WebCoreStatistics.mm:
      (+[WebCoreStatistics shouldPrintExceptions]):
      (+[WebCoreStatistics setShouldPrintExceptions:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7195ba53
    • loislo@chromium.org's avatar
      Web Inspector: move OverviewGrid and OverviewWindow into separate file. · de159407
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112693
      
      Reviewed by Yury Semikhatsky.
      
      It is the third patch for the meta bug "Web Inspector: meta bug: extract OverviewGrid from TimelineOverviewPane"
      It just moves the OverviewGrid and the related classes into its own file.
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * inspector/compile-front-end.py:
      * inspector/front-end/OverviewGrid.js: Added.
      (WebInspector.OverviewGrid):
      (WebInspector.OverviewGrid.prototype.itemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.insertBeforeItemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.clientWidth):
      (WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.updateDividers):
      (WebInspector.OverviewGrid.prototype.addEventDividers):
      (WebInspector.OverviewGrid.prototype.removeEventDividers):
      (WebInspector.OverviewGrid.prototype.setWindowPosition):
      (WebInspector.OverviewGrid.prototype.reset):
      (WebInspector.OverviewGrid.prototype.windowLeft):
      (WebInspector.OverviewGrid.prototype.windowRight):
      (WebInspector.OverviewGrid.prototype.setWindow):
      (WebInspector.OverviewGrid.prototype.addEventListener):
      (WebInspector.OverviewGrid.Window):
      (WebInspector.OverviewGrid.Window.prototype.reset):
      (WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
      (WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
      (WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
      (WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
      (WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
      (WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
      (WebInspector.OverviewGrid.Window.prototype._windowDragging):
      (WebInspector.OverviewGrid.Window.prototype._endWindowDragging):
      (WebInspector.OverviewGrid.Window.prototype._moveWindow):
      (WebInspector.OverviewGrid.Window.prototype._resizeWindowLeft):
      (WebInspector.OverviewGrid.Window.prototype._resizeWindowRight):
      (WebInspector.OverviewGrid.Window.prototype._resizeWindowMaximum):
      (WebInspector.OverviewGrid.Window.prototype._setWindow):
      (WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
      (WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
      (WebInspector.OverviewGrid.Window.prototype._zoom):
      (WebInspector.OverviewGrid.WindowSelector):
      (WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
      (WebInspector.OverviewGrid.WindowSelector.prototype._close):
      (WebInspector.OverviewGrid.WindowSelector.prototype._updatePosition):
      * inspector/front-end/TimelineOverviewPane.js:
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de159407
    • commit-queue@webkit.org's avatar
      Web Inspector: [CodeMirror] add smart braces functionality · 13012b3c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112138
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
      Reviewed by Vsevolod Vlasov.
      
      No new tests.
      
      Add closebrackets add-on to codemirror which implements smart braces
      functionality and guard this setting with the "Text Editor smart
      braces" experiment.
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * inspector/front-end/CodeMirrorTextEditor.js:
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/cm/closebrackets.js: Added.
      (.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13012b3c
  8. 18 Mar, 2013 4 commits
  9. 13 Mar, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Implement FontLoader interface · d7e6fa24
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98395
      
      Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-13
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This patch implements the FontLoader interface defined in CSS Font
      Load Events Module Level 3.[1] It adds fontloader attribute to
      Document, and adds two interfaces, FontLoader and
      CSSFontFaceLoadEvent to WebCore.
      
      [1]: http://dev.w3.org/csswg/css-font-load-events-3/
      
      This feature is guarded by FONT_LOAD_EVENTS compiler flag and
      RuntimeEnabledFeatures::fontLoadEventsEnabled() runtime flag.
      
      Tests: fast/css/fontloader-download-error.html
             fast/css/fontloader-events.html
             fast/css/fontloader-loadingdone.html
             fast/css/fontloader-multiple-faces-download-error.html
             fast/css/fontloader-multiple-faces.html
             fast/css/fontloader-multiple-families.html
             http/tests/webfont/fontloader-loading-attribute.html
      
      * CMakeLists.txt: Adding FontLoader/CSSFontFaceLoadEvent files.
      * DerivedSources.cpp: Ditto.
      * DerivedSources.make: Ditto.
      * DerivedSources.pri: Ditto.
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * bindings/js/JSDictionary.cpp:
      (WebCore::JSDictionary::convertValue): Add convertValue() for CSSFontFaceRule, DOMError, and VoidCallback.
      * bindings/js/JSDictionary.h: Ditto.
      * bindings/v8/Dictionary.cpp: Add get() for CSSFontFaceRule, DOMError, and VoidCallback.
      (WebCore::Dictionary::get):
      * bindings/v8/Dictionary.h: Ditto.
      (Dictionary):
      * css/CSSFontFace.cpp: Notifies FontLoader as load progresses.
      (WebCore::CSSFontFace::fontLoaded):
      (WebCore::CSSFontFace::getFontData):
      (WebCore::CSSFontFace::notifyFontLoader):
      (WebCore::CSSFontFace::notifyLoadingDone):
      * css/CSSFontFace.h: Add two member variables. m_rule stores CSSFontFaceRule for the fontface. m_loadState holds current state of the fontface in terms of FontLoader.
      (WebCore::CSSFontFace::create): Takes additional parameter of type CSSFontFaceRule.
      (WebCore::CSSFontFace::loadState):
      (WebCore::CSSFontFace::CSSFontFace):
      * css/CSSFontFaceLoadEvent.cpp: Added.
      (WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
      (WebCore::CSSFontFaceLoadEvent::~CSSFontFaceLoadEvent):
      (WebCore::CSSFontFaceLoadEvent::interfaceName):
      * css/CSSFontFaceLoadEvent.h: Added.
      (CSSFontFaceLoadEventInit):
      (CSSFontFaceLoadEvent):
      (WebCore::CSSFontFaceLoadEvent::create):
      (WebCore::CSSFontFaceLoadEvent::createForFontFaceRule):
      (WebCore::CSSFontFaceLoadEvent::createForError):
      (WebCore::CSSFontFaceLoadEvent::fontface):
      (WebCore::CSSFontFaceLoadEvent::error):
      * css/CSSFontFaceLoadEvent.idl: Added.
      * css/CSSFontFaceRule.idl: Add JSGenerateToJSObject and JSGenerateToNativeObject as JSC binding needs them.
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::isDecodeError): Added.
      (WebCore::CSSFontFaceSource::ensureFontData): Added.
      * css/CSSFontFaceSource.h:
      (CSSFontFaceSource):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::addFontFaceRule): Pass a CSSFontFaceRule to CSSFontFace::create().
      (WebCore::CSSFontSelector::getFontData): Moved logic for creating a CSSSegmentedFontFace to a helper function getFontFace().
      (WebCore::CSSFontSelector::getFontFace): Added.
      * css/CSSFontSelector.h:
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::CSSSegmentedFontFace::fontLoaded): Fires callbacks when load is completed.
      (WebCore::CSSSegmentedFontFace::isLoading): Returns true if any fonts are still loading.
      (WebCore::CSSSegmentedFontFace::checkFont): Returns true if all fonts are loaded.
      (WebCore::CSSSegmentedFontFace::loadFont): Starts load by calling getFontData().
      * css/CSSSegmentedFontFace.h:
      (CSSSegmentedFontFace): Declares new functions and a vector to store callbacks.
      (LoadFontCallback):
      (WebCore::CSSSegmentedFontFace::LoadFontCallback::~LoadFontCallback):
      * css/FontLoader.cpp: Added.
      (LoadFontCallback): Holds callback functions of FontLoader.loadFont().
      (WebCore::LoadFontCallback::create):
      (WebCore::LoadFontCallback::createFromParams):
      (WebCore::LoadFontCallback::LoadFontCallback):
      (WebCore::LoadFontCallback::notifyLoaded):
      (WebCore::LoadFontCallback::notifyError):
      (WebCore::FontLoader::FontLoader):
      (WebCore::FontLoader::~FontLoader):
      (WebCore::FontLoader::eventTargetData):
      (WebCore::FontLoader::ensureEventTargetData):
      (WebCore::FontLoader::interfaceName):
      (WebCore::FontLoader::scriptExecutionContext):
      (WebCore::FontLoader::didLayout): Fires pending events and callbacks. This is called when layout have completed.
      (WebCore::FontLoader::scheduleEvent): Defers event dispatching until layout completes.
      (WebCore::FontLoader::firePendingEvents): Dispatches pending events.
      (WebCore::FontLoader::beginFontLoading): Schedules loading/loadstart events. This is called from CSSFontFace.
      (WebCore::FontLoader::fontLoaded): Schedules load/loadingdone events. This is called from CSSFontFace.
      (WebCore::FontLoader::loadError): Schedules error/loadingdone events. This is called from CSSFontFace.
      (WebCore::FontLoader::notifyWhenFontsReady): Implements fontloader.notifyWhenFontsReady().
      (WebCore::FontLoader::loadingDone): Fires callbacks of notifyWhenFontsReady.
      (WebCore::FontLoader::loadFont): Implements fontloader.loadFont().
      (WebCore::FontLoader::checkFont): Implements fontloader.checkFont().
      (WebCore::FontLoader::resolveFontStyle): Parses the given font parameter using the syntax of CSS 'font' property and creates Font object. The logic is taken from CanvasRenderingContext2D::setFont().
      * css/FontLoader.h: Added.
      (FontLoader):
      (WebCore::FontLoader::create):
      (WebCore::FontLoader::loading):
      (WebCore::FontLoader::document):
      (WebCore::FontLoader::refEventTarget):
      (WebCore::FontLoader::derefEventTarget):
      * css/FontLoader.idl: Added.
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::fontloader): Added.
      * dom/Document.h:
      (Document): Add m_fontloader and fontloader().
      * dom/Document.idl: Add fontloader attribute.
      * dom/EventNames.h: Add loading and loadingdone events.
      * dom/EventNames.in: Add CSSFontFaceLoadEvent.
      * dom/EventTargetFactory.in: Add FontLoader.
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks): Calls FontLoader::didLayout().
      
      Tools:
      
      Enable FontLoadEvents runtime flag for TestShell.
      
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
      (WebTestRunner::TestInterfaces::TestInterfaces):
      
      LayoutTests:
      
      Add tests for document.fontloader. Since the feature is currently enabled
      only for chromium, the tests are expected to fail on the other ports.
      
      * fast/css/fontloader-download-error-expected.txt: Added.
      * fast/css/fontloader-download-error.html: Added.
      * fast/css/fontloader-events-expected.txt: Added.
      * fast/css/fontloader-events.html: Added.
      * fast/css/fontloader-loadingdone-expected.txt: Added.
      * fast/css/fontloader-loadingdone.html: Added.
      * fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
      * fast/css/fontloader-multiple-faces-download-error.html: Added.
      * fast/css/fontloader-multiple-faces-expected.txt: Added.
      * fast/css/fontloader-multiple-faces.html: Added.
      * fast/css/fontloader-multiple-families-expected.txt: Added.
      * fast/css/fontloader-multiple-families.html: Added.
      * http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.
      * http/tests/webfont/fontloader-loading-attribute.html: Added.
      * platform/chromium/fast/css/fontloader-download-error-expected.txt: Added.
      * platform/chromium/fast/css/fontloader-events-expected.txt: Added.
      * platform/chromium/fast/css/fontloader-loadingdone-expected.txt: Added.
      * platform/chromium/fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
      * platform/chromium/fast/css/fontloader-multiple-faces-expected.txt: Added.
      * platform/chromium/fast/css/fontloader-multiple-families-expected.txt: Added.
      * platform/chromium/http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e6fa24
    • kinuko@chromium.org's avatar
      Quota API: Update IDL to make it match the latest WD · 5c3424aa
      kinuko@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88396
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
      to make the code match with the latest Quota API WD:
      http://www.w3.org/TR/quota-api/
      
      Tests: storage/storagequota-query-usage.html
             storage/storagequota-request-quota.html
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::webkitStorageInfo): Added a deprecate warning message for the old interface.
      * Modules/quota/NavigatorStorageQuota.cpp: Added for the new interface.
      * Modules/quota/NavigatorStorageQuota.h: Added for the new interface.
      * Modules/quota/NavigatorStorageQuota.idl: Added for the new interface.
      * Modules/quota/StorageErrorCallback.cpp:
      (WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
      (WebCore::StorageErrorCallback::CallbackTask::performTask):
      * Modules/quota/StorageErrorCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.h.
      (WebCore):
      (StorageErrorCallback):
      (WebCore::StorageErrorCallback::~StorageErrorCallback):
      (WebCore::StorageErrorCallback::CallbackTask::create):
      * Modules/quota/StorageErrorCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.idl.
      * Modules/quota/StorageInfo.cpp: Added code to relay requests to the new StorageQuota implementation.
      * Modules/quota/StorageInfo.h:
      * Modules/quota/StorageInfo.idl:
      * Modules/quota/StorageQuota.cpp: Added for the new interface.
      * Modules/quota/StorageQuota.h:
      (WebCore::StorageQuota::create):
      * Modules/quota/StorageQuota.idl: Copied from Source/WebCore/Modules/quota/StorageInfo.idl.
      * Modules/quota/StorageQuotaCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.h.
      * Modules/quota/StorageQuotaCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.idl.
      * Modules/quota/StorageUsageCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.h.
      * Modules/quota/StorageUsageCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.idl.
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * page/FeatureObserver.h:
      
      Source/WebKit/chromium:
      
      Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
      to make the code match with the latest Quota API WD:
      http://www.w3.org/TR/quota-api/
      
      * WebKit.gyp:
      * src/AssertMatchingEnums.cpp:
      * src/StorageQuotaChromium.cpp: Renamed from Source/WebKit/chromium/src/StorageInfoChromium.cpp.
      (WebCore):
      (WebCore::StorageQuota::queryUsageAndQuota):
      (WebCore::StorageQuota::requestQuota):
      * src/WebStorageQuotaCallbacksImpl.cpp:
      (WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
      * src/WebStorageQuotaCallbacksImpl.h:
      (WebCore):
      (WebStorageQuotaCallbacksImpl):
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      * storage/storagequota-query-usage-expected.txt: Added.
      * storage/storagequota-query-usage.html: Added.
      * storage/storagequota-request-quota-expected.txt: Added.
      * storage/storagequota-request-quota.html: Added.
      
      Rebaselines:
      * platform/chromium/fast/dom/everything-to-string-expected.txt: Added.
      * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
      * platform/chromium/fast/js/global-constructors-expected.txt:
      * platform/chromium/http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
      * platform/chromium/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3424aa
  10. 12 Mar, 2013 2 commits
  11. 08 Mar, 2013 1 commit
    • eric@webkit.org's avatar
      BackgroundHTMLParser should be able to atomize well-known strings · 81db328c
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107337
      
      Reviewed by Adam Barth.
      
      Testing this patch easily requires applying bug 107236 locally
      to remove all the rendering noise from Parser/html-threaded-parser.html.
      
      This patch adds a new class HTMLIdentifier which allows us to avoid
      allocating strings for known tag/attribute names from HTMLNames.
      
      There is still a lot of meat on this bone, but I think it's important to
      land something "smallish" to start and iterate from there.
      
      This took Parser/html-threaded-parser.html from:
      median= 443.726500002 ms, stdev= 7.25002679952 ms, min= 430.244000047 ms, max= 455.511000007 ms
      to:
      median= 427.849500004 ms, stdev= 9.96967058292 ms, min= 417.914000049 ms, max= 461.528000014 ms
      on my MBP.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * html/parser/AtomicHTMLToken.h:
      (WebCore::AtomicHTMLToken::AtomicHTMLToken):
      * html/parser/BackgroundHTMLParser.cpp:
      (WebCore::tokenExitsForeignContent):
      (WebCore::tokenExitsSVG):
      (WebCore::tokenExitsMath):
      (WebCore::BackgroundHTMLParser::simulateTreeBuilder):
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore::CSSPreloadScanner::scan):
      * html/parser/CSSPreloadScanner.h:
      (WebCore):
      (CSSPreloadScanner):
      * html/parser/CompactHTMLToken.cpp:
      (SameSizeAsCompactHTMLToken):
      (WebCore::CompactHTMLToken::CompactHTMLToken):
      * html/parser/CompactHTMLToken.h:
      (WebCore::CompactHTMLToken::Attribute::Attribute):
      (Attribute):
      (WebCore::CompactHTMLToken::data):
      (WebCore::CompactHTMLToken::publicIdentifier):
      (CompactHTMLToken):
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::startBackgroundParser):
      * html/parser/HTMLIdentifier.cpp: Added.
      (WebCore):
      (WebCore::identifierTable):
      (WebCore::HTMLIdentifier::hasIndex):
      (WebCore::HTMLIdentifier::findIndex):
      (WebCore::nameForIndex):
      (WebCore::HTMLIdentifier::asString):
      (WebCore::HTMLIdentifier::asStringImpl):
      (WebCore::HTMLIdentifier::addNames):
      (WebCore::HTMLIdentifier::init):
      * html/parser/HTMLIdentifier.h: Added.
      (WebCore):
      (HTMLIdentifier):
      (WebCore::HTMLIdentifier::HTMLIdentifier):
      (WebCore::HTMLIdentifier::isSafeToSendToAnotherThread):
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::threadSafeEqual):
      (WebCore::threadSafeMatch):
      * html/parser/HTMLParserIdioms.h:
      (WebCore):
      (WebCore::threadSafeHTMLNamesMatch):
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::TokenPreloadScanner::tagIdFor):
      (WebCore::TokenPreloadScanner::StartTagScanner::match):
      (TokenPreloadScanner::StartTagScanner):
      (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
      * html/parser/HTMLPreloadScanner.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81db328c
  12. 07 Mar, 2013 1 commit
    • keishi@webkit.org's avatar
      Add clear button to date/time input types · 85f0e7f8
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111319
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      We want to remove the clear button from the calendar picker (Bug 109439)
      so we are adding the clear button to the right side of the input element.
      
      Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html
             fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html
             fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html
             fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html
             fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html
      
      * CMakeLists.txt: Added ClearButtonElement.cpp
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * css/html.css:
      (input::-webkit-clear-button): Styles for the clear button.
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::requiredAttributeChanged): Hide clear button if the value is required.
      (WebCore):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectClearButtonOwner): Called on mouse down on clear button.
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldClearButtonRespondToMouseEvents):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::clearValue):
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateClearButtonVisibility): We want to hide the clear button if the value is required or the value is empty.
      * html/BaseMultipleFieldsDateAndTimeInputType.h:
      (BaseMultipleFieldsDateAndTimeInputType):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateClearButtonVisibility):
      (WebCore):
      (WebCore::HTMLInputElement::requiredAttributeChanged):
      * html/HTMLInputElement.h:
      (HTMLInputElement):
      * html/InputType.cpp:
      (WebCore::InputType::requiredAttributeChanged): Notifies the InputType that the required attribute has changed.
      (WebCore):
      (WebCore::InputType::updateClearButtonVisibility):
      * html/InputType.h:
      (InputType):
      * html/shadow/ClearButtonElement.cpp: Added.
      (WebCore):
      (WebCore::ClearButtonElement::ClearButtonElement):
      (WebCore::ClearButtonElement::create):
      (WebCore::ClearButtonElement::detach):
      (WebCore::ClearButtonElement::releaseCapture): Stop capturing mouse events.
      (WebCore::ClearButtonElement::defaultEventHandler):
      * html/shadow/ClearButtonElement.h: Added.
      (WebCore):
      (ClearButtonElement):
      (ClearButtonOwner):
      (WebCore::ClearButtonElement::ClearButtonOwner::~ClearButtonOwner):
      (WebCore::ClearButtonElement::removeClearButtonOwner):
      (WebCore::ClearButtonElement::isMouseFocusable):
      
      LayoutTests:
      
      * fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
      * fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Added.
      * fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt:
      * fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:
      * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
      * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Added.
      * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt:
      * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:
      * fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
      * fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Added.
      * fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt:
      * fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:
      * fast/forms/resources/common-clearbutton-change-and-input-events.js: Added.
      (.testInput.onchange):
      (.testInput.oninput):
      (testClearButtonChangeAndInputEvents):
      * fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt:
      * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:
      * fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
      * fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
      * fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Added.
      * fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt:
      * fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85f0e7f8
  13. 06 Mar, 2013 1 commit
    • tkent@chromium.org's avatar
      Rename WebCore/editing/visible_units.* to VisibleUnits.* · 8c35c12b
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111426
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      No new tests. Just a refactoring.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityObject.cpp:
      * accessibility/AccessibilityRenderObject.cpp:
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      * dom/Position.cpp:
      * dom/Range.cpp:
      * editing/AlternativeTextController.cpp:
      * editing/ApplyBlockElementCommand.cpp:
      * editing/ApplyStyleCommand.cpp:
      * editing/CompositeEditCommand.cpp:
      * editing/DeleteSelectionCommand.cpp:
      * editing/EditingAllInOne.cpp:
      * editing/EditingStyle.cpp:
      * editing/Editor.cpp:
      * editing/FormatBlockCommand.cpp:
      * editing/FrameSelection.cpp:
      * editing/IndentOutdentCommand.cpp:
      * editing/InsertLineBreakCommand.cpp:
      * editing/InsertListCommand.cpp:
      * editing/InsertParagraphSeparatorCommand.cpp:
      * editing/InsertTextCommand.cpp:
      * editing/ReplaceSelectionCommand.cpp:
      * editing/SurroundingText.cpp:
      * editing/TextCheckingHelper.cpp:
      * editing/TextIterator.cpp:
      * editing/TypingCommand.cpp:
      * editing/VisiblePosition.cpp:
      * editing/VisibleSelection.cpp:
      * editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
      * editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
      * editing/htmlediting.cpp:
      * editing/markup.cpp:
      * editing/visible_units.cpp: Removed.
      * editing/visible_units.h: Removed.
      * page/Frame.cpp:
      * page/mac/FrameMac.mm:
      * platform/win/EditorWin.cpp:
      
      Source/WebKit/mac: 
      
      * WebView/WebFrame.mm:
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/mac/WebPageMac.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c35c12b
  14. 05 Mar, 2013 3 commits
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin VS2010 build fix. · 377105f5
      roger_fong@apple.com authored
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * rendering/RenderingAllInOne.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      377105f5
    • ap@apple.com's avatar
      Make AsyncFileReader work without ScriptExecutionContext · 6bb2a247
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111376
      
              Reviewed by Anders Carlsson.
      
              * WebCore.xcodeproj/project.pbxproj: Added MainThreadTask.h.
      
              * dom/ScriptExecutionContext.cpp:
              * dom/ScriptExecutionContext.h:
              Removed fileThread(). Creating a thread for every context that acesses files appears
              wasteful and unnecessary.
      
              * fileapi/AsyncFileStream.h:
              * fileapi/AsyncFileStream.cpp:
              (WebCore::createFileThread): FileThread is now a singleton.
              (WebCore::fileThread): Ditto.
              (WebCore::AsyncFileStream::AsyncFileStream):
              (WebCore::AsyncFileStream::create):
              (WebCore::didStart):
              (WebCore::AsyncFileStream::startOnFileThread):
              (WebCore::AsyncFileStream::stop):
              (WebCore::derefProxyOnMainThread):
              (WebCore::AsyncFileStream::stopOnFileThread):
              (WebCore::didGetSize):
              (WebCore::AsyncFileStream::getSizeOnFileThread):
              (WebCore::didOpen):
              (WebCore::AsyncFileStream::openForReadOnFileThread):
              (WebCore::AsyncFileStream::openForWriteOnFileThread):
              (WebCore::didRead):
              (WebCore::AsyncFileStream::readOnFileThread):
              (WebCore::didWrite):
              (WebCore::AsyncFileStream::writeOnFileThread):
              (WebCore::didTruncate):
              (WebCore::AsyncFileStream::truncateOnFileThread):
              Use callOnMainThread() instead of posting messages through a context. We never used
              other threads, and don't plan to.
      
              * loader/ResourceLoader.cpp:
              * loader/ResourceLoader.h:
              We no longer need this pseudo-client call to create an AsyncFileStream, now that
              we don't need to get a ScriptExecutionContext somewhere.
      
              * platform/MainThreadTask.h: Added. This implements callOnMainThread with multiple
              strongly typed arguments. Closely based on CrossThreadTask.h.
      
              * platform/network/BlobResourceHandle.cpp:
              (WebCore::BlobResourceHandle::BlobResourceHandle): Create AsyncFileStream directly.
      
              * platform/network/ResourceHandleClient.h: Removed createAsyncFileStream().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bb2a247
    • mark.lam@apple.com's avatar
      Improve robustness of WebSQL quota management. · f009ae4c
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110600.
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore: 
      
      1. Introduced the OriginLock for synchronizing write access to the
         database origin directory. This allows us to more accurately
         compute the disk usage.
      
         The OriginLock uses a mutex to provide mutual exclusion between
         threads and a file lock for mutual exclusion between processes.
         The file lock part is conditional on USE(FILE_LOCK).
      
         The mutex mutual exclusion also serves to ensure that only 1 thread
         can write to a sqlite database at one time.
      
      2. Change the SQLTransactionCoordinator to only allow one write
         transaction to an origin instead of one write transaction per
         database. This is needed in order to accurately compute the
         disk usage. It is also necessary so that the OriginLock does not
         deadlock itself (as would be the case if concurrent write transactions
         to different databases in the same origin are allowed).
      
      3. Fix DatabaseTracker::getMaxSizeForDatabase() to check for when
         disk usage may exceed the quota, and ensure that we will return
         an appropriate max database size.
      
         Disk usage can exceed the usage if it is already near the quota limit
         but have not exceeded it yet. If a new database is opened in that
         origin, it may bump the usage above the quota, but should not
         continually repeat this. Subsequent attempts to open a database
         will find that the quota is already exhausted and fail.
      
         There is still a race condition pertaining to the tracker database
         getting out of sync that may still enable runaway growth in the
         database sizes. That issue only manifest in a multi-process
         environment, and will be fixed in another changeset.
      
      4. Fixed a bug in SQLStatement to check if the errorCallback exists
         before invoking it.
      
      No new layout tests. A quota-test.html was attached to bugzilla for manual
      testing of multi-tab concurrent consumption of storage resource, and also
      to test handling situations when the user deletes the database files while
      the script is still using the database.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/webdatabase/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::getMaxSizeForDatabase):
      (WebCore::DatabaseTracker::originLockFor):
      (WebCore::DatabaseTracker::deleteOriginLockFor):
      (WebCore::DatabaseTracker::deleteOrigin):
      * Modules/webdatabase/DatabaseTracker.h:
      * Modules/webdatabase/OriginLock.cpp: Added.
      (WebCore::OriginLock::lockFileNameForPath):
      (WebCore::OriginLock::OriginLock):
      (WebCore::OriginLock::~OriginLock):
      (WebCore::OriginLock::lock):
      (WebCore::OriginLock::unlock):
      * Modules/webdatabase/OriginLock.h: Added.
      * Modules/webdatabase/SQLStatement.cpp:
      (WebCore::SQLStatement::performCallback):
      * Modules/webdatabase/SQLTransactionBackend.cpp:
      (WebCore::SQLTransactionBackend::doCleanup):
      (WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
      (WebCore::SQLTransactionBackend::openTransactionAndPreflight):
      (WebCore::SQLTransactionBackend::postflightAndCommit):
      (WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
      (WebCore::SQLTransactionBackend::acquireOriginLock):
      (WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
      * Modules/webdatabase/SQLTransactionBackend.h:
      (SQLTransactionBackend):
      * Modules/webdatabase/SQLTransactionCoordinator.cpp:
      (WebCore::getDatabaseIdentifier):
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * config.h:
      * platform/FileSystem.h:
      * platform/posix/FileSystemPOSIX.cpp:
      (WebCore::lockFile):
      (WebCore::unlockFile):
      
      LayoutTests: 
      
      * storage/websql/multiple-databases-garbage-collection.js:
      - This test runs 2 transactions on 2 databases (1 each). The 2 databases
        are named "persistent" and "forgotten". The test executes the
        transaction on "persistent" first, but expects the transaction on
        "forgotten" to finish first. This is because "forgotten"'s transaction
        is a smaller one. The new changes to SQLTransactionCoordinator now
        ensures that a write transaction must completes before another is
        started for databases in the same origin. Hence, the previously expected
        result will no longer be true.
      
        Regardless, the purpose of the test is not to test the order of
        completion but that resources are reclaimed. So, I'm changing the test
        to start the "forgotten" transaction first followed by the "persistent"
        transaction. This ensures that the test will yield consistent results
        even when run on ports that may allow more than one write transaction
        to run at the same time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f009ae4c
  15. 04 Mar, 2013 2 commits
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin build fix. · 6de3a341
      roger_fong@apple.com authored
      * WebKit.vcxproj/FeatureDefines.props:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6de3a341
    • loislo@chromium.org's avatar
      Web Inspector: implement Flame Chart for CPU profiler. · 62a37a72
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111162
      
      Reviewed by Yury Semikhatsky.
      
      It is an initial implementation. The next step is to provide
      function names and other stats about the hovered item.
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * inspector/compile-front-end.py:
      * inspector/front-end/CPUProfileView.js:
      (WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
      * inspector/front-end/FlameChart.js: Added.
      (WebInspector.FlameChart):
      (WebInspector.FlameChart.prototype._onMouseMove):
      (WebInspector.FlameChart.prototype.findNodeCallback):
      (WebInspector.FlameChart.prototype._coordinatesToNode):
      (WebInspector.FlameChart.prototype.onResize):
      (WebInspector.FlameChart.prototype._rootNodes):
      (WebInspector.FlameChart.prototype.draw):
      (WebInspector.FlameChart.prototype._drawNode):
      (WebInspector.FlameChart.prototype._forEachNode):
      (WebInspector.FlameChart.prototype._drawBar):
      (WebInspector.FlameChart.prototype.update):
      * inspector/front-end/Settings.js:
      (WebInspector.ExperimentsSettings):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/flameChart.css: Added.
      (.flame-chart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62a37a72
  16. 03 Mar, 2013 1 commit
    • abarth@webkit.org's avatar
      Unreviewed rollout of http://trac.webkit.org/r144530 · fa616dd3
      abarth@webkit.org authored
      As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
      https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
      large number of ASSERTs in chromium-win.
      
      Source/WebCore: 
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      (WebCore):
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      (WebCore):
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      (WebCore):
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      (WebCore):
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore):
      * loader/cache/CachedResourceHandle.h:
      (WebCore):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore):
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      (WebCore):
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore):
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      (WebCore):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      (WebCore):
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk: 
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa616dd3
  17. 01 Mar, 2013 4 commits
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
    • bfulgham@webkit.org's avatar
      [Windows] Unreviewed VS2010 build fix. · 94c4d61e
      bfulgham@webkit.org authored
      * WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor
        files to the project.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94c4d61e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  18. 28 Feb, 2013 1 commit