1. 04 Jan, 2011 22 commits
  2. 03 Jan, 2011 18 commits
    • tkent@chromium.org's avatar
      2011-01-03 Kent Tamura <tkent@chromium.org> · f519dc45
      tkent@chromium.org authored
              Unreviewed, test expectation update
      
              Add expectations of r74954 tests for Chromium.
      
              * platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
              * platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
              * platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
              * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
              * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
              * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
              * platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
              * platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
              * platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
              * platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
              * platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
              * platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
              * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
              * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
              * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
              * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
              * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
              * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f519dc45
    • ddkilzer@apple.com's avatar
      WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml · 3c25011b
      ddkilzer@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48596
      
      Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
      Reviewed by Darin Adler.
      
      border attribute was not parsed in HTMLObjectElement.
      I added code for it as HTMLImageElement handled.
      
      new test:fast/html/object-border.html
      
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parseMappedAttribute):
      
      LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
      https://bugs.webkit.org/show_bug.cgi?id=48596
      
      Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
      Reviewed by Darin Adler.
      
      * fast/html/object-border-expected.txt: Added.
      * fast/html/object-border.html: Added.
      * fast/html/resources/images/blue-border.png: Added.
      * fast/html/resources/images/blue.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c25011b
    • darin@apple.com's avatar
      Try to fix Chromium build. · 2e91ccf2
      darin@apple.com authored
      * history/HistoryItem.cpp:
      (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
      Not sure this ever will be used with V8.
      (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e91ccf2
    • darin@apple.com's avatar
      Try to fix Leopard build. · a48d8731
      darin@apple.com authored
      * history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
      size variable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48d8731
    • inferno@chromium.org's avatar
      2011-01-01 Abhishek Arya <inferno@chromium.org> · 947af308
      inferno@chromium.org authored
              Reviewed by Darin Adler.
      
              Fixes before child calculation when adding anonymous childs to table parts.
              https://bugs.webkit.org/show_bug.cgi?id=50932
      
              Fix in r74364 was incomplete. When before child is equal to the table part(to
              which the new child is getting added), it confuses the table part to add it
              incorrectly as an after child. The patch fixes by passing the before child as
              the table part's first child.
      
              Tests: fast/css-generated-content/table-before-after-child-add.html
                     fast/css-generated-content/table-cell-before-after-child-add.html
                     fast/css-generated-content/table-row-before-after-child-add.html
                     fast/css-generated-content/table-row-before-after-child-add.html
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::addChild):
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::addChild):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild):
      2010-12-20  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Darin Adler.
      
              Tests that "before" and "after" childs are added to table correctly.
              https://bugs.webkit.org/show_bug.cgi?id=50932
      
              * fast/css-generated-content/table-before-after-child-add.html: Added.
              * fast/css-generated-content/table-before-child-add.html: Removed.
              * fast/css-generated-content/table-cell-before-after-child-add.html: Added.
              * fast/css-generated-content/table-row-before-after-child-add.html: Added.
              * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
              * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
              * platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
              * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
              * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
              * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
              * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
              * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
              * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      947af308
    • mitz@apple.com's avatar
      Shrink HTMLTableCellElement · 4e2e580d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51858
      
      Reviewed by Simon Fraser.
      
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
      m_col.
      * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e2e580d
    • darin@apple.com's avatar
      Fix build. · 2de5bd4f
      darin@apple.com authored
      * platform/network/FormData.cpp:
      (WebCore::FormData::create): Roll back uint8_t change.
      (WebCore::FormData::flatten): Ditto.
      (WebCore::FormData::flattenToString): Ditto.
      (WebCore::encode): Ditto.
      (WebCore::decode): Ditto.
      (WebCore::FormData::encodeForBackForward):
      * platform/network/FormData.h: Ditto.
      * platform/network/mac/FormDataStreamMac.mm:
      (WebCore::advanceCurrentStream): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2de5bd4f
    • darin@apple.com's avatar
      2011-01-03 Darin Adler <darin@apple.com> · 2e4eb267
      darin@apple.com authored
              Reviewed by Brady Eidson.
      
              Add code to encode/decode the back/forward tree
              https://bugs.webkit.org/show_bug.cgi?id=51853
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::encodeBackForwardTree): Added.
              (WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
              (WebCore::HistoryItem::decodeBackForwardTree): Added.
              * history/HistoryItem.h: Added functions above.
      
              * platform/network/FormData.cpp:
              (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
              Vector<char>. This type is used in our newer code for vectors of bytes.
              (WebCore::FormData::flatten): Ditto.
              (WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
              (WebCore::FormData::encodeForBackForward): Added.
              (WebCore::FormData::decodeForBackForward): Added.
              * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
              Vector<char>. Also made some single-argument constructors explicit.
              Also added the new functions.
      
              * platform/network/mac/FormDataStreamMac.mm:
              (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e4eb267
    • simon.fraser@apple.com's avatar
      2011-01-03 Simon Fraser <simon.fraser@apple.com> · 0127b431
      simon.fraser@apple.com authored
              Attempt to fix GTK build.
      
              * platform/graphics/gtk/FontGtk.cpp:
              (WebCore::drawGlyphsShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0127b431
    • psolanki@apple.com's avatar
      Mac build fix. Define WTF_USE_CFNETWORK for Windows build only. · f4a36c4f
      psolanki@apple.com authored
      * WebCoreSupport/WebInspectorClientCF.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4a36c4f
    • bweinstein@apple.com's avatar
      Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF. · eb6f96ae
      bweinstein@apple.com authored
      * WebCoreSupport/WebInspectorClientCF.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb6f96ae
    • commit-queue@webkit.org's avatar
      2011-01-03 Helder Correia <helder@sencha.com> · 6a1fb1a5
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              ContextShadow can avoid code duplication for getting the CTM
              https://bugs.webkit.org/show_bug.cgi?id=51799
      
              ContextShadow defines its own getTransformationMatrixFromContext()
              which does exactly the same as GraphicsContext::getCTM().
      
              Existing tests: fast/canvas/canvas*shadow*html
      
              * platform/graphics/ContextShadow.cpp:
              (WebCore::ContextShadow::mustUseContextShadow):
              (WebCore::ContextShadow::adjustBlurDistance):
              (WebCore::ContextShadow::calculateLayerBoundingRect):
              * platform/graphics/ContextShadow.h:
              * platform/graphics/cairo/ContextShadowCairo.cpp:
              (WebCore::ContextShadow::beginShadowLayer):
              (WebCore::ContextShadow::endShadowLayer):
              (WebCore::ContextShadow::drawRectShadowWithoutTiling):
              * platform/graphics/cairo/FontCairo.cpp:
              (WebCore::drawGlyphsShadow):
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::drawPathShadow):
              * platform/graphics/cairo/ImageCairo.cpp:
              (WebCore::BitmapImage::draw):
              * platform/graphics/gtk/FontGtk.cpp:
              (WebCore::drawGlyphsShadow):
              * platform/graphics/qt/ContextShadowQt.cpp:
              (WebCore::ContextShadow::beginShadowLayer):
              (WebCore::ContextShadow::endShadowLayer):
              * platform/graphics/qt/FontQt.cpp:
              (WebCore::drawTextCommon):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              * platform/graphics/qt/ImageQt.cpp:
              (WebCore::BitmapImage::draw):
              * platform/graphics/qt/StillImageQt.cpp:
              (WebCore::StillImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1fb1a5
    • darin@apple.com's avatar
      2011-01-03 Darin Adler <darin@apple.com> · d61c6e59
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              InsertTextCommand::m_charactersAdded is unused
              https://bugs.webkit.org/show_bug.cgi?id=51849
      
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
              (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
              * editing/InsertTextCommand.h: Removed charactersAdded function and
              m_charactersAdded data member.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d61c6e59
    • commit-queue@webkit.org's avatar
      2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com> · a726db2d
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
              https://bugs.webkit.org/show_bug.cgi?id=51832
      
              Method paintMenuListButton() contains code common to both gtk 2
              and 3, so it can be moved to RenderThemeGtk.cpp instead of
              duplicating it.
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::paintMenuListButton):
              * platform/gtk/RenderThemeGtk2.cpp:
              * platform/gtk/RenderThemeGtk3.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a726db2d
    • xan@webkit.org's avatar
      2011-01-03 Xan Lopez <xlopez@igalia.com> · e8f45632
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              * autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env
              variable (like jhbuild).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8f45632
    • psolanki@apple.com's avatar
      2011-01-03 Pratik Solanki <psolanki@apple.com> · 8ca237bb
      psolanki@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=51850
              Put CFNetwork loader code inside USE(CFNETWORK)
      
              Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
              files to the WebCore Xcode project.
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/cf/ResourceLoaderCFNet.cpp:
              * loader/mac/ResourceLoaderMac.mm:
              * platform/network/cf/AuthenticationCF.cpp:
              * platform/network/cf/AuthenticationCF.h:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/CookieStorageCFNet.cpp:
              * platform/network/cf/CookieStorageCFNet.h:
              * platform/network/cf/CredentialStorageCFNet.cpp:
              * platform/network/cf/FormDataStreamCFNet.cpp:
              * platform/network/cf/FormDataStreamCFNet.h:
              * platform/network/cf/LoaderRunLoopCF.cpp:
              * platform/network/cf/LoaderRunLoopCF.h:
              * platform/network/cf/ResourceError.h:
              * platform/network/cf/ResourceHandleCFNet.cpp:
              * platform/network/cf/ResourceRequest.h:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.h:
              * platform/network/cf/ResourceResponse.h:
              * platform/network/cf/ResourceResponseCFNet.cpp:
              * platform/network/mac/AuthenticationMac.h:
              * platform/network/mac/AuthenticationMac.mm:
              * platform/network/mac/FormDataStreamMac.h:
              * platform/network/mac/FormDataStreamMac.mm:
              * platform/network/mac/ResourceError.h:
              * platform/network/mac/ResourceHandleMac.mm:
              * platform/network/mac/ResourceRequest.h:
              * platform/network/mac/ResourceRequestMac.mm:
              * platform/network/mac/ResourceResponse.h:
              * platform/network/mac/ResourceResponseMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ca237bb
    • xan@webkit.org's avatar
      2011-01-03 Xan Lopez <xlopez@igalia.com> · 3d6bfc32
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Use autoreconf instead of calling manually all the usual commands.
      
              * autogen.sh: call autoreconf instead of
              aclocal/autoheader/autoconf/automake/libtoolize.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d6bfc32
    • commit-queue@webkit.org's avatar
      2011-01-03 Yi Shen <yi.4.shen@nokia.com> · 84ffa4ae
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              [Qt] Add SelectAll option to the context menu for the editor
              https://bugs.webkit.org/show_bug.cgi?id=50049
      
              Set shortcut for the SelectAll action.
      
              * QtTestBrowser/mainwindow.cpp:
              (MainWindow::buildUI):
      2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Adam Barth.
      
              [Qt] Add SelectAll option to the context menu for the editor
              https://bugs.webkit.org/show_bug.cgi?id=50049
      
              Enable SelectAll for the Qt context menu.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::populate):
              * platform/ContextMenuItem.h:
              * platform/LocalizationStrategy.h:
              * platform/LocalizedStrings.cpp:
              (WebCore::contextMenuItemTagSelectAll):
              * platform/LocalizedStrings.h:
      2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Adam Barth.
      
              [Qt] Add SelectAll option to the context menu for the editor
              https://bugs.webkit.org/show_bug.cgi?id=50049
      
              Enable SelectAll for the Qt context menu.
      
              * Api/qwebpage.cpp:
              (webActionForContextMenuAction):
              (QWebPage::action):
              * WebCoreSupport/WebPlatformStrategies.cpp:
              (WebPlatformStrategies::contextMenuItemTagSelectAll):
              * WebCoreSupport/WebPlatformStrategies.h:
      2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Adam Barth.
      
              [Qt] Add SelectAll option to the context menu for the editor
              https://bugs.webkit.org/show_bug.cgi?id=50049
      
              Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.
      
              * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
              (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
              * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84ffa4ae