- 04 Jan, 2011 22 commits
-
-
dbates@webkit.org authored
Reviewed by Adam Roben. LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails https://bugs.webkit.org/show_bug.cgi?id=51860 * wtf/ThreadingWin.cpp: (WTF::createThreadInternal): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74983 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bfulgham@webkit.org authored
* win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from Debug_Cairo_CFLite/Release_Cario_CFLite builds. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
laszlo.1.gombos@nokia.com authored
Reviewed by Ariya Hidayat. [Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian https://bugs.webkit.org/show_bug.cgi?id=31273 On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers are included before platform headers. On all other platforms continue to use INCLUDEPATH (as before). This is a continuation of r65877. No new tests as there is no new functionality. * JavaScriptCore.pri: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74978 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
* wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing of conditional includes. (WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer. (WTF::createThreadInternal): Tweaked #if to not need separate macro. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list. The tracking bug 51884 (https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74976 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dbates@webkit.org authored
Reviewed by Adam Roben. Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android https://bugs.webkit.org/show_bug.cgi?id=51855 Both the Apple Windows and Android ports implement a similar adapter structure, called ThreadFunctionInvocation and ThreadData respectively, as part of their thread creation process. Instead, we should share such an adapter structure and remove duplicate code. * JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h. * wtf/ThreadFunctionInvocation.h: Added. (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation): * wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation. (WTF::runThreadWithRegistration): (WTF::createThreadInternal): * wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that it can be shared with the Android implementation of createThreadInternal(). (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74975 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
laszlo.1.gombos@nokia.com authored
Reviewed by Laszlo Gombos. [Qt] [Symbian] Do not remove 0 byte sized files from productDir On Symbian productDir points to the source directory. Removing all the empty files from the productDir directory corrupts the svn repository. * Scripts/build-webkit: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74974 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dbates@webkit.org authored
Reviewed by Darin Adler. Use __builtin_expect when compiling using RVCT in GNU mode https://bugs.webkit.org/show_bug.cgi?id=51866 Derived from a patch by Dave Tapuska. * wtf/AlwaysInline.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74973 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonyg@chromium.org authored
Unreviewed build fix. Include glib-object.h for GObject https://bugs.webkit.org/show_bug.cgi?id=51876 * bindings/gobject/DOMObjectCache.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74972 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
rniwa@webkit.org authored
Reviewed by Dan Bernstein. Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side. https://bugs.webkit.org/show_bug.cgi?id=50992 Fixed the bug by interchanging the offset when the direction of inline text box and the containing block does not match. Reused the code added by http://trac.webkit.org/changeset/73553. Test: editing/selection/caret-bidi-first-and-last-letters.html * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition): 2011-01-04 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Dan Bernstein. Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side. https://bugs.webkit.org/show_bug.cgi?id=50992 Added a test to ensure WebKit places the caret on the side user clicked even when text's natural direction and the containing block's direction do not match. * editing/selection/caret-bidi-first-and-last-letters-expected.txt: Added. * editing/selection/caret-bidi-first-and-last-letters.html: Added. * editing/selection/resources/caret-edge-shared.js: Avoid calling verify() outside of DRT. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74971 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
beidson@apple.com authored
Pass encoded back/forward tree data from the WebProcess to the UIProcess Reviewed by Darin Adler. Remove the WKBackForwardListItemCopyOriginalURL API as it's not needed: * UIProcess/API/C/WKBackForwardListItem.cpp: * UIProcess/API/C/WKBackForwardListItem.h: * UIProcess/API/qt/qwkhistory.cpp: * UIProcess/API/qt/qwkhistory.h: * UIProcess/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::WebBackForwardListItem): * UIProcess/WebBackForwardListItem.h: (WebKit::WebBackForwardListItem::create): (WebKit::WebBackForwardListItem::setBackForwardData): (WebKit::WebBackForwardListItem::backForwardData): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::addBackForwardItem): * UIProcess/WebProcessProxy.h: * UIProcess/WebProcessProxy.messages.in: * WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74970 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonyg@chromium.org authored
Reviewed by Darin Adler. Remove 2 unnecessary includes from Document.h https://bugs.webkit.org/show_bug.cgi?id=51727 No new tests because no changed functionality. * dom/Document.cpp: * dom/Document.h: * editing/Editor.cpp: * editing/SpellChecker.h: * editing/SplitTextNodeCommand.cpp: * editing/TextCheckingHelper.cpp: * page/FrameView.cpp: * page/Page.cpp: * rendering/HitTestResult.cpp: * rendering/InlineTextBox.cpp: * rendering/InlineTextBox.h: * rendering/svg/SVGInlineFlowBox.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74969 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
paroga@webkit.org authored
Unreviewed WinCE build fix. * CMakeListsWinCE.txt: Added missing include directories, files and libraries. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74968 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kbalazs@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt][WK2] Incomplete clean up on termination https://bugs.webkit.org/show_bug.cgi?id=51474 Do not kill the web process to force it's termination. Fix object destruction and cleanup logic and make the cleanup more reliable. Do not try to cleanup on crash because it is not reliable. * Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Do not delete the socket if we do not own it. This is the case with a server connection. * Platform/qt/MappedMemoryPool.cpp: Turn MappedMemoryPool into a QObject so the CleanupHandler can destruct it in the same way as the other objects. (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::~MappedMemoryPool): * Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemoryPool::MappedMemoryPool): * Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): No need to care about QCoreApplication::aboutToQuit. It is handled by the CleanupHandler. (WebKit::SharedMemory::~SharedMemory): Ditto. * Shared/qt/CleanupHandler.cpp: Renamed from WebKit2/Shared/qt/CrashHandler.cpp. No longer try to handle crash but just normal termination. (WebKit::CleanupHandler::CleanupHandler): Connect deleteObjects with QCoreApplication::aboutToQuit. Ensure appropriate thread affinity. (WebKit::CleanupHandler::sigTermHandler): Stop the main event loop. (WebKit::CleanupHandler::deleteObjects): Use deleteLater instead of delete since it is more reliable. * Shared/qt/CleanupHandler.h: Renamed from WebKit2/Shared/qt/CrashHandler.h. (WebKit::CleanupHandler::instance): (WebKit::CleanupHandler::markForCleanup): (WebKit::CleanupHandler::unmark): * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Do not kill the web process immidiately but give it a chance to cleanup. Use QLocalServer::removeServer for assuring that the socket file will be removed. (WebKit::ProcessLauncherHelper::serverName): (WebKit::cleanupAtExit): Renamed from cleanupProcesses. Only kill the web process when it times out terminating. Fixed the bug of changing the list while iterating it over by disconnecting from the processStateChanged slot. (WebKit::QtWebProcess::QtWebProcess): Added missing meta type registration of QProcess::ProcessState. (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): No need to add the the instance to the CleanupHandler because we will remove the socket file in cleanupAtExit. (WebKit::ProcessLauncherHelper::instance): (WebKit::ProcessLauncher::terminateProcess): * WebKit2.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74967 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
paroga@webkit.org authored
Unreviewed WinCE build fix. * WebCoreSupport/ChromeClientWinCE.cpp: (WebKit::ChromeClientWinCE::exceededDatabaseQuota): Added missing semicolon. (WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota): * WebCoreSupport/ChromeClientWinCE.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74966 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Simon Hausmann. Provide an interface to require using fullscreen mediaplayer https://bugs.webkit.org/show_bug.cgi?id=51133 Only video should be displayed in fullscreen when requiresFullscreenForVideoPlayback is specified. No new tests because no client implements requiresFullscreenForVideoPlayback yet. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74965 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
benjamin.poulain@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2 https://bugs.webkit.org/show_bug.cgi?id=51825 Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the platform independent menu informations. * platform/qt/ContextMenuQt.cpp: (WebCore::contextMenuItemVector): 2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2 https://bugs.webkit.org/show_bug.cgi?id=51825 Implement the necessary methods to get a basic context menu working for Qt. Only 4 basic WebAction have been added on the UIProcess side: back, forward, stop and reload. * UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate): * UIProcess/API/qt/qgraphicswkview.h: * UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy): * UIProcess/API/qt/qwkpage.h: * UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu): * UIProcess/qt/WebContextMenuProxyQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74964 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed, rolling out r74960. http://trac.webkit.org/changeset/74960 https://bugs.webkit.org/show_bug.cgi?id=51868 Rollout since we hit an assert after this patch. (Requested by krit on #webkit). * svg/custom/recursive-use-expected.txt: Removed. * svg/custom/recursive-use.svg: Removed. 2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r74960. http://trac.webkit.org/changeset/74960 https://bugs.webkit.org/show_bug.cgi?id=51868 Rollout since we hit an assert after this patch. (Requested by krit on #webkit). * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74963 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
philn@webkit.org authored
Unreviewed, rolling out r74961. http://trac.webkit.org/changeset/74961 https://bugs.webkit.org/show_bug.cgi?id=51867 breaks 32/64-bits debug bots build (Requested by philn-tp on #webkit). * platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74962 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
philn@webkit.org authored
Rubber-stamped by Eric Seidel. [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30 https://bugs.webkit.org/show_bug.cgi?id=51810 Based on a patch by Mart Raudsepp. No new tests, build fix only. * platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74961 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Dirk Schulze. Malformed SVG causes crash in updateContainerOffset https://bugs.webkit.org/show_bug.cgi?id=44610 Test case for recursive svg <use>. This test case passes if no crash occurs. * svg/custom/recursive-use-expected.txt: Added. * svg/custom/recursive-use.svg: Added. 2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn> Reviewed by Dirk Schulze. Malformed SVG causes crash in updateContainerOffset https://bugs.webkit.org/show_bug.cgi?id=44610 We should check recursive <use> at the begining of WebCore::SVGUseElement::buildInstanceTree instead of at the end of it because the target element's children may cause infinite recursive <use>. Test: svg/custom/recursive-use.svg * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74960 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tkent@chromium.org authored
Unreviewed, build fix. Try to fix Clang build. * css/CSSParser.cpp: (WebCore::valueFromSideKeyword): (WebCore::CSSParser::parseLinearGradient): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 03 Jan, 2011 18 commits
-
-
tkent@chromium.org authored
Unreviewed, test expectation update Add expectations of r74954 tests for Chromium. * platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added. * platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added. * platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added. * platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added. * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added. * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added. * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added. * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added. * platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added. * platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added. * platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added. * platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added. * platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added. * platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added. * platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added. * platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added. * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added. * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added. * platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added. * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added. * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added. * platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added. * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added. * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added. * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added. * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added. * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added. * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74958 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ddkilzer@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=48596 Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03 Reviewed by Darin Adler. border attribute was not parsed in HTMLObjectElement. I added code for it as HTMLImageElement handled. new test:fast/html/object-border.html * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml https://bugs.webkit.org/show_bug.cgi?id=48596 Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03 Reviewed by Darin Adler. * fast/html/object-border-expected.txt: Added. * fast/html/object-border.html: Added. * fast/html/resources/images/blue-border.png: Added. * fast/html/resources/images/blue.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here. Not sure this ever will be used with V8. (WebCore::HistoryItem::decodeBackForwardTree): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* history/HistoryItem.cpp: Use a consistent type, uint64_t, for the size variable. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Reviewed by Darin Adler. Fixes before child calculation when adding anonymous childs to table parts. https://bugs.webkit.org/show_bug.cgi?id=50932 Fix in r74364 was incomplete. When before child is equal to the table part(to which the new child is getting added), it confuses the table part to add it incorrectly as an after child. The patch fixes by passing the before child as the table part's first child. Tests: fast/css-generated-content/table-before-after-child-add.html fast/css-generated-content/table-cell-before-after-child-add.html fast/css-generated-content/table-row-before-after-child-add.html fast/css-generated-content/table-row-before-after-child-add.html * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): 2010-12-20 Abhishek Arya <inferno@chromium.org> Reviewed by Darin Adler. Tests that "before" and "after" childs are added to table correctly. https://bugs.webkit.org/show_bug.cgi?id=50932 * fast/css-generated-content/table-before-after-child-add.html: Added. * fast/css-generated-content/table-before-child-add.html: Removed. * fast/css-generated-content/table-cell-before-after-child-add.html: Added. * fast/css-generated-content/table-row-before-after-child-add.html: Added. * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added. * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added. * platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added. * platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed. * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added. * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added. * platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added. * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added. * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added. * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added. * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added. * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added. * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74954 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=51858 Reviewed by Simon Fraser. * html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and m_col. * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* platform/network/FormData.cpp: (WebCore::FormData::create): Roll back uint8_t change. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. (WebCore::encode): Ditto. (WebCore::decode): Ditto. (WebCore::FormData::encodeForBackForward): * platform/network/FormData.h: Ditto. * platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Brady Eidson. Add code to encode/decode the back/forward tree https://bugs.webkit.org/show_bug.cgi?id=51853 * history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Added. (WebCore::HistoryItem::encodeBackForwardTreeNode): Added. (WebCore::HistoryItem::decodeBackForwardTree): Added. * history/HistoryItem.h: Added functions above. * platform/network/FormData.cpp: (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of Vector<char>. This type is used in our newer code for vectors of bytes. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. Had to add a cast here. (WebCore::FormData::encodeForBackForward): Added. (WebCore::FormData::decodeForBackForward): Added. * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of Vector<char>. Also made some single-argument constructors explicit. Also added the new functions. * platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Changed to use uint8_t to match above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74951 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Attempt to fix GTK build. * platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74950 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
psolanki@apple.com authored
* WebCoreSupport/WebInspectorClientCF.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
* WebCoreSupport/WebInspectorClientCF.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Simon Fraser. ContextShadow can avoid code duplication for getting the CTM https://bugs.webkit.org/show_bug.cgi?id=51799 ContextShadow defines its own getTransformationMatrixFromContext() which does exactly the same as GraphicsContext::getCTM(). Existing tests: fast/canvas/canvas*shadow*html * platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect): * platform/graphics/ContextShadow.h: * platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): (WebCore::ContextShadow::drawRectShadowWithoutTiling): * platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow): * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): * platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): * platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow): * platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): * platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw): * platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74947 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
Reviewed by Dan Bernstein. InsertTextCommand::m_charactersAdded is unused https://bugs.webkit.org/show_bug.cgi?id=51849 * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded. (WebCore::InsertTextCommand::input): Don't update m_charactersAdded. * editing/InsertTextCommand.h: Removed charactersAdded function and m_charactersAdded data member. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74946 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Martin Robinson. [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp https://bugs.webkit.org/show_bug.cgi?id=51832 Method paintMenuListButton() contains code common to both gtk 2 and 3, so it can be moved to RenderThemeGtk.cpp instead of duplicating it. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMenuListButton): * platform/gtk/RenderThemeGtk2.cpp: * platform/gtk/RenderThemeGtk3.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74945 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xan@webkit.org authored
Reviewed by Martin Robinson. * autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env variable (like jhbuild). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74944 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
psolanki@apple.com authored
Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=51850 Put CFNetwork loader code inside USE(CFNETWORK) Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork files to the WebCore Xcode project. * WebCore.xcodeproj/project.pbxproj: * loader/cf/ResourceLoaderCFNet.cpp: * loader/mac/ResourceLoaderMac.mm: * platform/network/cf/AuthenticationCF.cpp: * platform/network/cf/AuthenticationCF.h: * platform/network/cf/CookieJarCFNet.cpp: * platform/network/cf/CookieStorageCFNet.cpp: * platform/network/cf/CookieStorageCFNet.h: * platform/network/cf/CredentialStorageCFNet.cpp: * platform/network/cf/FormDataStreamCFNet.cpp: * platform/network/cf/FormDataStreamCFNet.h: * platform/network/cf/LoaderRunLoopCF.cpp: * platform/network/cf/LoaderRunLoopCF.h: * platform/network/cf/ResourceError.h: * platform/network/cf/ResourceHandleCFNet.cpp: * platform/network/cf/ResourceRequest.h: * platform/network/cf/ResourceRequestCFNet.cpp: * platform/network/cf/ResourceRequestCFNet.h: * platform/network/cf/ResourceResponse.h: * platform/network/cf/ResourceResponseCFNet.cpp: * platform/network/mac/AuthenticationMac.h: * platform/network/mac/AuthenticationMac.mm: * platform/network/mac/FormDataStreamMac.h: * platform/network/mac/FormDataStreamMac.mm: * platform/network/mac/ResourceError.h: * platform/network/mac/ResourceHandleMac.mm: * platform/network/mac/ResourceRequest.h: * platform/network/mac/ResourceRequestMac.mm: * platform/network/mac/ResourceResponse.h: * platform/network/mac/ResourceResponseMac.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74943 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xan@webkit.org authored
Reviewed by Martin Robinson. Use autoreconf instead of calling manually all the usual commands. * autogen.sh: call autoreconf instead of aclocal/autoheader/autoconf/automake/libtoolize. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74942 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Adam Barth. [Qt] Add SelectAll option to the context menu for the editor https://bugs.webkit.org/show_bug.cgi?id=50049 Set shortcut for the SelectAll action. * QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): 2011-01-03 Yi Shen <yi.4.shen@nokia.com> Reviewed by Adam Barth. [Qt] Add SelectAll option to the context menu for the editor https://bugs.webkit.org/show_bug.cgi?id=50049 Enable SelectAll for the Qt context menu. * page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate): * platform/ContextMenuItem.h: * platform/LocalizationStrategy.h: * platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagSelectAll): * platform/LocalizedStrings.h: 2011-01-03 Yi Shen <yi.4.shen@nokia.com> Reviewed by Adam Barth. [Qt] Add SelectAll option to the context menu for the editor https://bugs.webkit.org/show_bug.cgi?id=50049 Enable SelectAll for the Qt context menu. * Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::action): * WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagSelectAll): * WebCoreSupport/WebPlatformStrategies.h: 2011-01-03 Yi Shen <yi.4.shen@nokia.com> Reviewed by Adam Barth. [Qt] Add SelectAll option to the context menu for the editor https://bugs.webkit.org/show_bug.cgi?id=50049 Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt. * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
