1. 11 May, 2011 40 commits
    • oliver@apple.com's avatar
      2011-05-11 Oliver Hunt <oliver@apple.com> · 60de6041
      oliver@apple.com authored
              Reviewed by Darin Adler.
      
              Protect JSC from WebCore executing JS during JS wrapper finalization
              https://bugs.webkit.org/show_bug.cgi?id=60672
              <rdar://problem/9350997>
      
              Detect when we're trying to execute JS during GC and prevent the
              execution from happening.  We also assert that this isn't happening
              as it implies incorrect behaviour of an object's destructor.
      
              * JavaScriptCore.exp:
              * heap/Heap.cpp:
              * heap/Heap.h:
              (JSC::Heap::isBusy):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::execute):
              (JSC::Interpreter::executeCall):
              (JSC::Interpreter::executeConstruct):
              * runtime/JSGlobalData.h:
              (JSC::JSGlobalData::isCollectorBusy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60de6041
    • alexis.menard@openbossa.org's avatar
      2011-05-11 Alexis Menard <alexis.menard@openbossa.org> · 818c82f1
      alexis.menard@openbossa.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Implements a disable appearance for Media Elements of Qt port.
              https://bugs.webkit.org/show_bug.cgi?id=60561
      
              Implements a disable appearance for the media controls of the Qt port
              when the media is not yet available.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::mediaElementCanPlay):
              (WebCore::RenderThemeQt::getMediaControlForegroundColor):
              (WebCore::RenderThemeQt::paintMediaSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818c82f1
    • tkent@chromium.org's avatar
      2011-05-11 Kent Tamura <tkent@chromium.org> · 571f6811
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              input type=email is too strict
              https://bugs.webkit.org/show_bug.cgi?id=55988
      
              * fast/forms/resources/ValidityState-typeMismatch-email.js:
              * fast/forms/ValidityState-typeMismatch-email-expected.txt:
      2011-05-11  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              input type=email is too strict
              https://bugs.webkit.org/show_bug.cgi?id=55988
      
              Follow the updated specification.
      
              * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      571f6811
    • cdn@chromium.org's avatar
      2011-05-11 Cris Neckar <cdn@chromium.org> · eba45b97
      cdn@chromium.org authored
              Reviewed by David Levin.
      
              Adding Cris Neckar to the Webkit Security Group site.
              https://bugs.webkit.org/show_bug.cgi?id=60668
      
              * security/security-group-members.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eba45b97
    • weinig@apple.com's avatar
      2011-05-11 Sam Weinig <sam@webkit.org> · 8b6ac572
      weinig@apple.com authored
              Reviewed by Gavin Barraclough.
      
              WebKit2 doesn't build on Mac with strict PassOwnPtr
              https://bugs.webkit.org/show_bug.cgi?id=60655
      
              * Platform/CoreIPC/HandleMessage.h:
              (CoreIPC::handleMessageDelayed):
              Add explicit adoptPtr to indicate that the constructor is taking ownership.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b6ac572
    • jpu@apple.com's avatar
      2011-05-11 Jia Pu <jpu@apple.com> · fd2014cc
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              See WebCore/ChangeLog for detail.
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.
      2011-05-11  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              This patch intends to alleviate the issue of repetitively applying the same autocorrection
              when user delete and retype the same word at the same location. This scenario is especially
              common when autocorrection modifies the first letter of the word.
      
              This patch consists following major changes:
              1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that
                 precedes a deleted autocorrection. If the user later types the same original word at after
                 this whitespace, the autocorrection will not be applied again.
              2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the
                 autocorrection that has just been deleted.
              3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress
                 autocorrection when necessary.
              4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers.
                 Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text
                 after the whitespace.
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html
      
              * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection.
              (WebCore::DocumentMarker::AllMarkers::AllMarkers):
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
              * dom/DocumentMarkerController.h:
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting
                 the original string if we are deleting an autocorrection.
              (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.
              * editing/DeleteSelectionCommand.h:
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining
                 when to suppress an autocorrection into SpellingCorrectionController.
              (WebCore::Editor::deletedAutocorrectionAtPosition):
              * editing/Editor.h:
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              (WebCore::SpellingCorrectionController::respondToAppliedEditing):
              (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition):
              (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
              (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
              * editing/SpellingCorrectionController.h:
              (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
              * editing/visible_units.cpp:
              (WebCore::isStartOfWord):
              * editing/visible_units.h:
              * manual-tests/autocorrection/spell-checking-after-reversion.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd2014cc
    • oliver@apple.com's avatar
      2011-05-11 Oliver Hunt <oliver@apple.com> · 450024ac
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Enable gc mark validation in temporarily in release builds
              https://bugs.webkit.org/show_bug.cgi?id=60678
      
              Make it easier to turn the gc mark validation on and off, and
              temporarily turn it on for all builds.
      
              * heap/MarkStack.cpp:
              * heap/MarkStack.h:
              (JSC::MarkStack::append):
              (JSC::MarkStack::internalAppend):
              * runtime/WriteBarrier.h:
              (JSC::MarkStack::appendValues):
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      450024ac
    • mitz@apple.com's avatar
      <rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com · 7adc5cf0
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60677
      
      Reviewed by Darin Adler.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
      animation, if the new scroll offset computed here is different from the current scroll offset.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7adc5cf0
    • tkent@chromium.org's avatar
      2011-05-11 Kent Tamura <tkent@chromium.org> · af2085d1
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              <input pattern="1|10" value="10"> doesn't work correctly.
              https://bugs.webkit.org/show_bug.cgi?id=60619
      
              Add test cases and update the result.
      
              * fast/forms/ValidityState-patternMismatch-expected.txt:
              * fast/forms/ValidityState-patternMismatch.html:
      2011-05-11  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              <input pattern="1|10" value="10"> doesn't work correctly.
              https://bugs.webkit.org/show_bug.cgi?id=60619
      
              Fixes a bug that patternMismatch returns a wrong result if
               - a whole value matches to a pattern,
               - a sub-string of the value also matches to the pattern, and
               - the sub-string matching has priority.
      
              * html/BaseTextInputType.cpp:
              (WebCore::BaseTextInputType::patternMismatch):
                Enclose the specified pattern with ^( and )$.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af2085d1
    • commit-queue@webkit.org's avatar
      2011-05-11 Zelidrag Hornung <zelidrag@chromium.org> · 6e126984
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Prevented DOMFileSystemBase from imposing file naming restrictions on
              external file systems.
      
              https://bugs.webkit.org/show_bug.cgi?id=60583
      
              There are no new tests for this change since it requires the presence
              of external file system provider which is specific to the platform host
              process. Chromium implementation will test this within its extension API
              test suite.
      
              * fileapi/DOMFileSystemBase.cpp:
              (WebCore::pathToAbsolutePath):
              (WebCore::DOMFileSystemBase::getFile):
              (WebCore::DOMFileSystemBase::getDirectory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e126984
    • commit-queue@webkit.org's avatar
      2011-05-11 Antoine Labour <piman@chromium.org> · 7e4ad0a0
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
              loaded resource.
              https://bugs.webkit.org/show_bug.cgi?id=60656
      
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::loadRequest):
              Pass the shouldBufferData to the resource load scheduler, forcing it to true for the
              preflight request.
              * loader/ResourceLoadScheduler.cpp:
              (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
              Pass through shouldBufferData to SubresourceLoader::create
              * loader/ResourceLoadScheduler.h:
      
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::create):
              Set shouldBufferData on the newly created loader
      
              * loader/SubresourceLoader.h:
      
              * loader/ThreadableLoader.h:
              (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
              Add shouldBufferData to the options, defaulting to true.
      2011-05-11  Antoine Labour  <piman@chromium.org>
      
              Reviewed by David Levin.
      
              Don't buffer data for resources loaded by AssociatedURLLoader.
              https://bugs.webkit.org/show_bug.cgi?id=60656
      
              * src/AssociatedURLLoader.cpp:
              (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e4ad0a0
    • jcivelli@chromium.org's avatar
      2011-05-11 Jay Civelli <jcivelli@chromium.org> · e48e949e
      jcivelli@chromium.org authored
              Reviewed by Adam Barth.
      
              Adding a Content-Type parser. This is needed for MHTML support.
              https://bugs.webkit.org/show_bug.cgi?id=60637
      
              (WebCore::ScriptController::disableEval):
              * platform/network/ContentTypeParser.cpp: Added.
              * platform/network/ContentTypeParser.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e48e949e
    • eric@webkit.org's avatar
      2011-05-11 Eric Seidel <eric@webkit.org> · 4bf72665
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Teach validate-committer-lists how to validate committers bugzilla_email()
              https://bugs.webkit.org/show_bug.cgi?id=60651
      
              It turns out we currently have 9 committers with invalid values for their
              bugzilla_email field (meaning we don't know what email is their bugzilla account).
              "Alexander Kellett" <lypanov@mac.com>
              "Andre Boule" <aboule@apple.com>
              "Cameron McCormack" <cam@webkit.org>
              "Chris Petersen" <cpetersen@apple.com>
              "Eli Fidler" <eli@staikos.net>
              "Matt Lilek" <webkit@mattlilek.com>
              "Pierre d'Herbemont" <pdherbemont@free.fr>
              "Scott Violet" <sky@chromium.org>
              "Adam Treat" <treat@kde.org>
      
              Most of those haven't committed in a very long time, so it's not suprising
              that we haven't noticed that their bugzilla emails are bogus.
      
              * Scripts/validate-committer-lists:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf72665
    • levin@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=59561 · 011ea55e
      levin@chromium.org authored
      Switch TestWebKitAPI to GTest
      
      Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11
      Reviewed by David Levin.
      
      Fixes Makefiles and WinCairo build as well
      
      .:
      
      * Source/ThirdParty/gtest/README.WebKit:
      * Source/ThirdParty/gtest/msvc/gtest-md.vcproj:
      * Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
      * Source/ThirdParty/gtest/xcode/Makefile: Added.
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKit.sln:
      
      Tools:
      
      * Makefile:
      * Scripts/build-api-tests:
      * Scripts/run-api-tests:
      * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
      * TestWebKitAPI/Test.h:
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/TestsController.cpp:
      (TestWebKitAPI::TestsController::TestsController):
      (TestWebKitAPI::TestsController::dumpTestNames):
      (TestWebKitAPI::TestsController::runTestNamed):
      (TestWebKitAPI::TestsController::runAllTests):
      * TestWebKitAPI/TestsController.h:
      * TestWebKitAPI/mac/main.mm:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      011ea55e
    • ademar.reis@openbossa.org's avatar
      2011-05-11 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> · 4daa00ef
      ademar.reis@openbossa.org authored
              Reviewed by Mark Rowe.
      
              Update Qt/Nokia Security contacts
              https://bugs.webkit.org/show_bug.cgi?id=60650
      
              Ademar (me) replaced Simon as the release manager and primary security
              contact for QtWebKit. See:
              http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html
      
              * security/security-group-members.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4daa00ef
    • jberlin@webkit.org's avatar
      [Windows WebKit2] Use cookies set in WebKit1 · fcf9f8dd
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60274
      
      Reviewed by Steve Falkenburg.
      
      Source/WebCore: 
      
      Share the default storage session between the UI and Web Processes.
      
      * platform/network/cf/CookieStorageCFNet.cpp:
      (WebCore::defaultSessionCookieStorage):
      Keep track of the default storage session cookie storage.
      (WebCore::currentCookieStorage):
      Call defaultCookieStorage to get the default cookie storage.
      (WebCore::defaultCookieStorage):
      If there is a default storage session cookie storage, prefer that over getting the default
      cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
      without specifying a storage session will not get the cookie storage being shared by the UI
      and Web Processes.
      
      * platform/network/ResourceHandle.h:
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::willSendRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session (which is not the one shared
      with the UI Process).
      (WebCore::makeFinalRequest):
      Ditto.
      (WebCore::ResourceHandle::willSendRequest):
      Ditto.
      (WebCore::ResourceHandle::currentStorageSession):
      If there is a Private Browsing storage session, return that.
      If not, on Windows return the default storage session that is being shared with the UI
      Process and on Mac return 0.
      (WebCore::defaultCFURLStorageSession):
      (WebCore::ResourceHandle::setDefaultStorageSession):
      (WebCore::ResourceHandle::defaultStorageSession):
      
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session (which is not the one shared
      with the UI Process).
      
      Source/WebKit/win: 
      
      * WebView.cpp:
      (WebView::setCacheModel):
      Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
      
      Source/WebKit2: 
      
      Share the default storage session between the UI and Web Processes.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      Only encode the session parameter if it is valid.
      (WebKit::WebProcessCreationParameters::decode):
      Don't try to decode a null session data. 
      * Shared/WebProcessCreationParameters.h:
      Add a parameter for a serialized default storage session, used only on Windows.
      
      * Shared/win/WebCoreArgumentCodersWin.cpp:
      (CoreIPC::decodeResourceRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session.
      
      * UIProcess/win/WebContextWin.cpp:
      (WebKit::WebContext::platformInitializeWebProcess):
      Serialize the default storage session in the UI Process and add it to the
      WebProcessCreationParameters.
      
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::cachedResponseForURL):
      Use the cache associated with the current storage session and make sure the request has the
      current storage session set on it before doing anything with it.
      
      * WebProcess/win/WebProcessWin.cpp:
      (WebKit::WebProcess::platformSetCacheModel):
      Use the default storage session.
      (WebKit::WebProcess::platformClearResourceCaches):
      Ditto.
      (WebKit::WebProcess::platformInitializeWebProcess):
      Deserialize the default storage session passed in by the UI Process and hand it to the
      ResourceHandle.
      
      WebKitLibraries: 
      
      Take 3 after rolling out KB2465367 from my system.
      
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcf9f8dd
    • commit-queue@webkit.org's avatar
      2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi> · d11df501
      commit-queue@webkit.org authored
              Reviewed by David Kilzer.
      
              Remove wml directory from include lists
              https://bugs.webkit.org/show_bug.cgi?id=60646
      
              Remove wml dir from CMake, Autotools and qmake build systems since WML
              was removed in r85256.
      
              No new tests since no change in functionality.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d11df501
    • commit-queue@webkit.org's avatar
      2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi> · 6c51b914
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [CMAKE] Move EFL-specific file to CMakeListsEfl.txt
              https://bugs.webkit.org/show_bug.cgi?id=60642
      
              Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
              having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
              calls, since they depend on lists that now may change inside a port
              like WebCore_USER_AGENT_STYLE_SHEETS.
      
              No new tests since no change in functionality.
      
              * CMakeLists.txt: remove css file specific to EFL port.
              * CMakeListsEfl.txt: move file here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c51b914
    • eric@webkit.org's avatar
      2011-05-11 Eric Seidel <eric@webkit.org> · b254a44c
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Add Luke Macpherson to committers.py as a Contributor
              https://bugs.webkit.org/show_bug.cgi?id=60639
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b254a44c
    • jpu@apple.com's avatar
      2011-05-11 Jia Pu <jpu@apple.com> · ca72090a
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              CorrectionPanel sometimes hangs in dismissSoon().
              https://bugs.webkit.org/show_bug.cgi?id=60599
              <rdar://problem/9313628>
      
              Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
              to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
              for condition checking.
      
              * WebCoreSupport/CorrectionPanel.h:
              * WebCoreSupport/CorrectionPanel.mm:
              (CorrectionPanel::CorrectionPanel):
              (CorrectionPanel::show):
              (CorrectionPanel::dismissSoon):
              (CorrectionPanel::dismissInternal):
              (CorrectionPanel::handleAcceptedReplacement):
      2011-05-11  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              CorrectionPanel sometimes hangs in dismissSoon().
              https://bugs.webkit.org/show_bug.cgi?id=60599
              <rdar://problem/9313628>
      
              Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
              to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
              for condition checking.
      
              * UIProcess/mac/CorrectionPanel.h:
              * UIProcess/mac/CorrectionPanel.mm:
              (WebKit::CorrectionPanel::CorrectionPanel):
              (WebKit::CorrectionPanel::show):
              (WebKit::CorrectionPanel::dismissSoon):
              (WebKit::CorrectionPanel::dismissInternal):
              (WebKit::CorrectionPanel::handleAcceptedReplacement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca72090a
    • inferno@chromium.org's avatar
      2011-05-11 Abhishek Arya <inferno@chromium.org> · 9e852f43
      inferno@chromium.org authored
              Unreviewed.
      
              More rebaselines after r86261.
      
              * platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
              * platform/chromium-mac-leopard/fast/forms/slider-padding-expected.png: Added.
              * platform/chromium-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png:
              * platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
              * platform/chromium-mac/fast/forms/slider-padding-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e852f43
    • commit-queue@webkit.org's avatar
      2011-05-11 Tao Bai <michaelbai@chromium.org> · eeaac5fd
      commit-queue@webkit.org authored
              Reviewed by David Kilzer.
      
              Return empty Favicon URL instead of default one when the frame isn't top level one
              https://bugs.webkit.org/show_bug.cgi?id=60527
              This issue was discovered by chromium browser test.
      
              * dom/Document.cpp:
              (WebCore::Document::setIconURL):
              Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::iconURLs):
              (WebCore::FrameLoader::fillIconURL):
              Restored original logic, the empty URL should be returned instead of default one. The client (at
              least chromium) may rely on the returned value to decided whether the favicon should be changed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eeaac5fd
    • commit-queue@webkit.org's avatar
      2011-05-11 Nat Duca <nduca@chromium.org> · 72e44f58
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              [chromium] Make throttling of WebGL based on webgl frames, not compositor frames
              https://bugs.webkit.org/show_bug.cgi?id=60508
      
              When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need
              to prevent WebGL from running too far ahead of the GPU process. The current
              throttling mechanism relies on prepareTexture being called for every WebGL frame.
              However, in a non-requestAnimFrame application, multiple frames might get created
              before the compositor runs and calls prepareTexture on the surface.
      
              To address this, we post a task that calls a special rate limiting GL extension on
              the WebGL context after every WebGL "frame." When the compositor runs, it calls
              prepareTexture as usual.
      
              * platform/graphics/chromium/Extensions3DChromium.h:
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::setIsAnimating):
              (WebCore::LayerRendererChromium::isAnimating):
              * platform/graphics/chromium/WebGLLayerChromium.cpp:
              (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask):
              (WebCore::WebGLLayerChromiumRateLimitTask::run):
              (WebCore::WebGLLayerChromiumRateLimitTask::cancel):
              (WebCore::WebGLLayerChromium::WebGLLayerChromium):
              (WebCore::WebGLLayerChromium::~WebGLLayerChromium):
              (WebCore::WebGLLayerChromium::setTextureUpdated):
              (WebCore::WebGLLayerChromium::setContext):
              * platform/graphics/chromium/WebGLLayerChromium.h:
              (WebCore::WebGLLayerChromium::context):
      2011-05-11  Nat Duca  <nduca@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              [chromium] Make throttling of WebGL based on webgl frames, not compositor frames
              https://bugs.webkit.org/show_bug.cgi?id=60508
      
              Tell LayerRendererChromium when the requestAnimFrame-callbacks are running.
      
              * public/WebGraphicsContext3D.h:
              (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
              * src/Extensions3DChromium.cpp:
              (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
              * src/GraphicsContext3DChromium.cpp:
              * src/GraphicsContext3DInternal.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::animate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72e44f58
    • inferno@chromium.org's avatar
      2011-05-11 Abhishek Arya <inferno@chromium.org> · 00d40a86
      inferno@chromium.org authored
              Unreviewed.
      
              Rebaselines after r86261.
      
              * platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png:
              * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00d40a86
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · 8dc1643b
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).
              1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
              2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
              3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
      
              * Api/qwebframe.cpp:
              (QWebFramePrivate::renderCompositedLayers):
              * Api/qwebframe.h:
              * Api/qwebframe_p.h:
              (QWebFramePrivate::QWebFramePrivate):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::attachRootGraphicsLayer):
              * WebCoreSupport/PageClientQt.cpp:
              (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt):
              (WebCore::TextureMapperNodeClientQt::scroll):
              (WebCore::TextureMapperNodeClientQt::setTextureMapper):
              (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt):
              (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect):
              (WebCore::TextureMapperNodeClientQt::syncRootLayer):
              (WebCore::TextureMapperNodeClientQt::rootNode):
              (WebCore::PageClientQWidget::setRootGraphicsLayer):
              (WebCore::PageClientQWidget::syncLayers):
              (WebCore::PageClientQWidget::~PageClientQWidget):
              (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
              (WebCore::PageClientQGraphicsWidget::update):
              (WebCore::PageClientQGraphicsWidget::syncLayers):
              (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
              (WebCore::PageClientQGraphicsWidget::markForSync):
              * WebCoreSupport/PageClientQt.h:
              (WebCore::PageClientQWidget::PageClientQWidget):
              (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
              (WebCore::PageClientQGraphicsWidget::syncLayersTimeout):
      
      2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation
              mechanism happens inside TextureMapper, and we interpolate right before we paint.
      
              No new tests. Tests in LayoutTests/compositing cover this.
      
              * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
              (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
              (WebCore::GraphicsLayerTextureMapper::syncCompositingState):
              (WebCore::GraphicsLayerTextureMapper::addAnimation):
              (WebCore::GraphicsLayerTextureMapper::pauseAnimation):
              (WebCore::GraphicsLayerTextureMapper::removeAnimation):
              (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired):
              * platform/graphics/texmap/TextureMapperNode.cpp:
              (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
              (WebCore::normalizedAnimationValue):
              (WebCore::TextureMapperNode::applyOpacityAnimation):
              (WebCore::solveEpsilon):
              (WebCore::solveCubicBezierFunction):
              (WebCore::solveStepsFunction):
              (WebCore::applyTimingFunction):
              (WebCore::TextureMapperNode::applyTransformAnimation):
              (WebCore::TextureMapperNode::applyAnimationFrame):
              (WebCore::TextureMapperNode::applyAnimation):
              (WebCore::TextureMapperNode::hasRunningOpacityAnimation):
              (WebCore::TextureMapperNode::hasRunningTransformAnimation):
              (WebCore::TextureMapperNode::syncAnimations):
              (WebCore::copyTimingFunction):
              (WebCore::copyAnimationValue):
              (WebCore::TextureMapperAnimation::TextureMapperAnimation):
              * platform/graphics/texmap/TextureMapperNode.h:
              (WebCore::TextureMapperAnimation::create):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dc1643b
    • commit-queue@webkit.org's avatar
      2011-05-11 John Bauman <jbauman@chromium.org> · 5f7de36c
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Don't send zeros in TexImage if GL implementation handles that
              https://bugs.webkit.org/show_bug.cgi?id=60581
      
              Chromium already handles zeroing textures upon creation, so don't
              bother zeroing them in WebKit, as that causes some unnecessary memcpys
              of zeros.
      
              No new tests as functionality is the same.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::texImage2DBase):
              * platform/graphics/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3D::texImage2DResourceSafe):
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
              * platform/graphics/mac/GraphicsContext3DMac.mm:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
      2011-05-11  John Bauman  <jbauman@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Don't send zeros in TexImage if GL implementation handles that
              https://bugs.webkit.org/show_bug.cgi?id=60581
      
              Chromium already handles zeroing textures upon creation, so don't
              bother zeroing them in WebKit, as that causes some unnecessary memcpys
              of zeros.
      
              * src/GraphicsContext3DChromium.cpp:
              (WebCore::GraphicsContext3D::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f7de36c
    • simon.fraser@apple.com's avatar
      2011-05-11 Simon Fraser <simon.fraser@apple.com> · e20a6fec
      simon.fraser@apple.com authored
              Attempt to fix Chromium Mac build.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e20a6fec
    • dbates@webkit.org's avatar
      2011-05-11 Daniel Bates <dbates@rim.com> · 6b2ac8b1
      dbates@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Extract code to set mouse event modifiers into common function
              https://bugs.webkit.org/show_bug.cgi?id=60649
      
              Consolidate code to set the keyboard modifiers for a mouse event into a common
              function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount)
              and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code.
      
              No functionality was changed. So, no new tests.
      
              * platform/qt/PlatformMouseEventQt.cpp:
              (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added.
              (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b2ac8b1
    • leviw@chromium.org's avatar
      2011-05-11 Levi Weintraub <leviw@chromium.org> · b8a64c8c
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
              https://bugs.webkit.org/show_bug.cgi?id=60591
      
              Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect.
      
              No new tests since there is no functionality change.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintBoxDecorations):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBoxDecorationsWithSize):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBorder):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintBoxDecorations):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintBoxDecorations):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8a64c8c
    • commit-queue@webkit.org's avatar
      2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com> · bae22046
      commit-queue@webkit.org authored
              Unreviewed, rolling out r86255.
              http://trac.webkit.org/changeset/86255
              https://bugs.webkit.org/show_bug.cgi?id=60660
      
              REGRESSION (r86255): Lots of tests crashing in
              CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
              (WebKit2 Tests) (Requested by aroben on #webkit).
      
              * platform/network/ResourceHandle.h:
              * platform/network/cf/CookieStorageCFNet.cpp:
              (WebCore::currentCookieStorage):
              (WebCore::defaultCookieStorage):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::willSendRequest):
              (WebCore::makeFinalRequest):
              (WebCore::ResourceHandle::willSendRequest):
              * platform/network/cf/ResourceRequestCFNet.cpp:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
      2011-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r86255.
              http://trac.webkit.org/changeset/86255
              https://bugs.webkit.org/show_bug.cgi?id=60660
      
              REGRESSION (r86255): Lots of tests crashing in
              CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
              (WebKit2 Tests) (Requested by aroben on #webkit).
      
              * WebView.cpp:
              (WebView::setCacheModel):
      2011-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r86255.
              http://trac.webkit.org/changeset/86255
              https://bugs.webkit.org/show_bug.cgi?id=60660
      
              REGRESSION (r86255): Lots of tests crashing in
              CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
              (WebKit2 Tests) (Requested by aroben on #webkit).
      
              * Shared/WebProcessCreationParameters.cpp:
              (WebKit::WebProcessCreationParameters::encode):
              (WebKit::WebProcessCreationParameters::decode):
              * Shared/WebProcessCreationParameters.h:
              * Shared/win/WebCoreArgumentCodersWin.cpp:
              (CoreIPC::decodeResourceRequest):
              * UIProcess/win/WebContextWin.cpp:
              (WebKit::WebContext::platformInitializeWebProcess):
              * WebProcess/WebPage/win/WebPageWin.cpp:
              (WebKit::cachedResponseForURL):
              * WebProcess/win/WebProcessWin.cpp:
              (WebKit::WebProcess::platformSetCacheModel):
              (WebKit::WebProcess::platformClearResourceCaches):
              (WebKit::WebProcess::platformInitializeWebProcess):
      2011-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r86255.
              http://trac.webkit.org/changeset/86255
              https://bugs.webkit.org/show_bug.cgi?id=60660
      
              REGRESSION (r86255): Lots of tests crashing in
              CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
              (WebKit2 Tests) (Requested by aroben on #webkit).
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bae22046
    • weinig@apple.com's avatar
      Frequent crashes beneath WebCore::ScriptElement::prepareScript · 50cb724c
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60559
      
      Reviewed by Eric Seidel.
      
      * html/parser/HTMLScriptRunner.cpp:
      (WebCore::HTMLScriptRunner::runScript):
      Add null check and explanation that we are keeping the ASSERT to help
      track down the cause and produce a test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50cb724c
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · 4d0ca76e
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 5/12: Implement the new TextureMapper functions for the Qt backend.
              This allow non-rectangular clipping, some stub functions, and getting a unique
              id for an image.
      
              No new tests. Tests in LayoutTests/compositing cover this.
      
              * platform/graphics/qt/TextureMapperQt.cpp:
              (WebCore::TextureMapperQt::beginClip):
              (WebCore::TextureMapperQt::endClip):
              (WebCore::TextureMapperQt::viewportSize):
              (WebCore::TextureMapperQt::setGraphicsContext):
              (WebCore::TextureMapperQt::graphicsContext):
              (WebCore::TextureMapperQt::drawTexture):
              (WebCore::TextureMapperQt::beginPainting):
              (WebCore::TextureMapperQt::endPainting):
              (WebCore::RGBA32PremultimpliedBufferQt::beginPaint):
              (WebCore::uidForImage):
              * platform/graphics/qt/TextureMapperQt.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d0ca76e
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · fddf920d
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
              attributes.
      
              * Api/qwebsettings.cpp:
              (qt_networkAccessAllowed):
              (QWebSettingsPrivate::apply):
      2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
      
              * Scripts/build-webkit:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fddf920d
    • bweinstein@apple.com's avatar
      REGRESSION (r86161): WKPreferences API test failing on Windows · aa4a21ef
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60658
      
      Reviewed by Adam Roben.
      
      * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
      (TestWebKitAPI::TEST):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa4a21ef
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · c6568d23
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 3/12: TextureMapper shouldn't depend on OpenGL, but rather only allow the GL backend when
              OpenGL is present.
      
              No new tests. This is a build fix.
      
              * WebCore.pri:
              * WebCore.pro:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6568d23
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · 03c6238d
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 2/12: Add a few functions to the TextureMapper API, allowing:
              1. an entry/exit point for painting (beginPaint/endPaint)
              2. Clipping with a matrix, since we use stencil instead of scissors
              3. Draw a texture directly with an ID
              4. Remove offset, since we're using real tiling
              5. numberOfBytes calculation for textures, for memory management
      
              No new tests. Tests in LayoutTests/compositing test this.
      
              * platform/graphics/texmap/TextureMapper.h:
              (WebCore::BitmapTexture::destroy):
              (WebCore::BitmapTexture::allowOfflineTextureUpload):
              (WebCore::BitmapTexture::bpp):
              (WebCore::BitmapTexture::numberOfBytes):
              (WebCore::TextureMapper::viewportSize):
              (WebCore::TextureMapper::setViewportSize):
              (WebCore::TextureMapper::allowPartialUpdates):
              (WebCore::TextureMapper::isOpenGLBacked):
              (WebCore::TextureMapper::setTransform):
              (WebCore::TextureMapper::transform):
              (WebCore::TextureMapper::beginPainting):
              (WebCore::TextureMapper::endPainting):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03c6238d
    • noam.rosenthal@nokia.com's avatar
      2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com> · a63ad9fe
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
              https://bugs.webkit.org/show_bug.cgi?id=60439
      
              Patch 1/12: Change the TextureMapperPlatformLayer API to allow a 3D-context or a
              media player to decide how to paint into the TextureMapper, rather than mandate specific
              types of platform layers.
      
              No new tests. Tests in LayoutTests/compositing test this.
      
              * platform/graphics/GraphicsLayer.h:
              * platform/graphics/texmap/TextureMapperPlatformLayer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a63ad9fe
    • ggaren@apple.com's avatar
      <rdar://problem/9331651> REGRESSION: RPRVT grows by 1MB / sec @ dvd2blu.com · 0df9dfc5
      ggaren@apple.com authored
              
      Reviewed by Oliver Hunt.
      
      SunSpider reports no change.
      
      This bug was caused by changing Structure and Executable to being GC
      objects, and by a long-standing bug that would thrash the global object
      between dictionary and non-dictionary states.
      
      * runtime/BatchedTransitionOptimizer.h:
      (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): Don't
      eagerly transition to dictionary -- this can cause pathological dictionary
      churn, and it's not necessary, since objects know how to automatically
      transition to dictionary when necessary.
      
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::compileInternal):
      (JSC::ProgramExecutable::compileInternal):
      (JSC::FunctionExecutable::compileForCallInternal):
      (JSC::FunctionExecutable::compileForConstructInternal): Be sure to report
      extra cost from compilation, because it can be quite high. This is especially
      important for program code, since DOM timers can repeatedly allocate
      program code without allocating any other objects.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::removeDirect): Don't transition to the uncacheable state
      if the thing we're trying to remove doesn't exist. This can happen during
      compilation, since the compiler needs to ensure that no pre-existing
      conflicting definitions exist for certain declarations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0df9dfc5
    • simon.fraser@apple.com's avatar
      2011-05-11 Simon Fraser <simon.fraser@apple.com> · 10039517
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              Flesh out RenderLayer's ScrollableArea implementation a little more
              https://bugs.webkit.org/show_bug.cgi?id=60593
      
              Override a few more ScrollableArea methods on RenderLayer
              as a baby-step towards animating overflow div scrolling.
      
              * platform/ScrollableArea.h:
              (WebCore::ScrollableArea::visibleContentRect):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollPosition):
              (WebCore::RenderLayer::minimumScrollPosition):
              (WebCore::RenderLayer::maximumScrollPosition):
              (WebCore::RenderLayer::visibleContentRect):
              (WebCore::RenderLayer::overhangAmount):
              (WebCore::RenderLayer::didCompleteRubberBand):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::shouldSuspendScrollAnimations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10039517
    • simon.fraser@apple.com's avatar
      2011-05-11 Simon Fraser <simon.fraser@apple.com> · 493a14f4
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              <rdar://problem/9421781> Slider thumb draws upside-down in WebKit2
              <rdar://problem/9418025> Slider thumb has odd appearance
      
              Fix two issues drawing the slider thumb.
      
              To fix <rdar://problem/9421781>, if we detect that we're in WebKit2
              by virtual of the FrameView not having a documentView, then flip
              the graphics context.
      
              To fix <rdar://problem/9418025>, we call -drawInteriorWithFrame:inView:
              rather than -drawWithFrame:inView: so that AppKit doesn't draw a section
              of track behind the thumb.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      493a14f4