Skip to content
GitLab
Switch branch/tag
  1. 01 Dec, 2009 7 commits
    • pfeldman@chromium.org's avatar
      2009-12-01 Pavel Feldman <pfeldman@chromium.org> · 60dcf092
      pfeldman@chromium.org authored 
              Not reviewed: fix windows build via unexcluding generated files from
        project.

        * WebCore.vcproj/WebCore.vcproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60dcf092
    • mrowe@apple.com's avatar
      Stop copying IDL files in to the WebCore framework wrapper. · 72f046a4
      mrowe@apple.com authored 
      * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72f046a4
    • mrowe@apple.com's avatar
      Fix the Tiger build by making the Xcode project compatible with Xcode 2.4. · 2008e4a9
      mrowe@apple.com authored 
      This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2008e4a9
    • pfeldman@chromium.org's avatar
      2009-12-01 Pavel Feldman <pfeldman@chromium.org> · e11fd0e1
      pfeldman@chromium.org authored 
              Not reviewed: windows build fix (bad vcproj in r51528).

        * WebCore.vcproj/WebCore.vcproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e11fd0e1
    • pfeldman@chromium.org's avatar
      2009-11-27 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com> · 87861d02
      pfeldman@chromium.org authored 
              Reviewed by Timothy Hatcher.

        Web Inspector: Split InspectorBackend into three parts: backend,
        injected script host and frontend host.
        
        https://bugs.webkit.org/show_bug.cgi?id=31888

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInspectorBackendCustom.cpp: Removed.
        * bindings/js/JSInspectorFrontendHostCustom.cpp: Added.
        (WebCore::JSInspectorFrontendHost::search):
        (WebCore::JSInspectorFrontendHost::setting):
        (WebCore::JSInspectorFrontendHost::setSetting):
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::set):
        * bindings/js/ScriptObject.h:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::set):
        * bindings/v8/ScriptObject.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/InjectedScriptHost.cpp: Added.
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::copyText):
        (WebCore::InjectedScriptHost::nodeForId):
        (WebCore::InjectedScriptHost::wrapObject):
        (WebCore::InjectedScriptHost::unwrapObject):
        (WebCore::InjectedScriptHost::pushNodePathToFrontend):
        (WebCore::InjectedScriptHost::addNodesToSearchResult):
        (WebCore::InjectedScriptHost::currentCallFrame):
        (WebCore::InjectedScriptHost::databaseForId):
        (WebCore::InjectedScriptHost::selectDatabase):
        (WebCore::InjectedScriptHost::selectDOMStorage):
        (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
        (WebCore::InjectedScriptHost::inspectorDOMAgent):
        (WebCore::InjectedScriptHost::inspectorFrontend):
        * inspector/InjectedScriptHost.h: Added.
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::inspectorController):
        (WebCore::InjectedScriptHost::disconnectController):
        * inspector/InjectedScriptHost.idl: Added.
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::InspectorBackend):
        (WebCore::InspectorBackend::storeLastActivePanel):
        (WebCore::InspectorBackend::toggleNodeSearch):
        (WebCore::InspectorBackend::resourceTrackingEnabled):
        (WebCore::InspectorBackend::debuggerEnabled):
        (WebCore::InspectorBackend::enableDebugger):
        (WebCore::InspectorBackend::disableDebugger):
        (WebCore::InspectorBackend::addBreakpoint):
        (WebCore::InspectorBackend::updateBreakpoint):
        (WebCore::InspectorBackend::removeBreakpoint):
        (WebCore::InspectorBackend::pauseInDebugger):
        (WebCore::InspectorBackend::resumeDebugger):
        (WebCore::InspectorBackend::stepOverStatementInDebugger):
        (WebCore::InspectorBackend::stepIntoStatementInDebugger):
        (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
        (WebCore::InspectorBackend::pauseOnExceptions):
        (WebCore::InspectorBackend::setPauseOnExceptions):
        (WebCore::InspectorBackend::profilerEnabled):
        (WebCore::InspectorBackend::enableProfiler):
        (WebCore::InspectorBackend::disableProfiler):
        (WebCore::InspectorBackend::startProfiling):
        (WebCore::InspectorBackend::stopProfiling):
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        (WebCore::InspectorBackend::currentCallFrame):
        (WebCore::InspectorBackend::highlightDOMNode):
        (WebCore::InspectorBackend::hideDOMNodeHighlight):
        (WebCore::InspectorBackend::getCookies):
        (WebCore::InspectorBackend::deleteCookie):
        (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
        (WebCore::InspectorBackend::nodeForId):
        * inspector/InspectorBackend.h:
        (WebCore::InspectorBackend::create):
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorFrontendHost):
        (WebCore::InspectorController::injectedScriptHost):
        * inspector/InspectorFrontendHost.cpp: Added.
        (WebCore::InspectorFrontendHost::InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::loaded):
        (WebCore::InspectorFrontendHost::attach):
        (WebCore::InspectorFrontendHost::detach):
        (WebCore::InspectorFrontendHost::closeWindow):
        (WebCore::InspectorFrontendHost::windowUnloading):
        (WebCore::InspectorFrontendHost::setAttachedWindowHeight):
        (WebCore::InspectorFrontendHost::moveWindowBy):
        (WebCore::InspectorFrontendHost::localizedStringsURL):
        (WebCore::InspectorFrontendHost::hiddenPanels):
        (WebCore::InspectorFrontendHost::platform):
        (WebCore::InspectorFrontendHost::port):
        (WebCore::InspectorFrontendHost::addResourceSourceToFrame):
        (WebCore::InspectorFrontendHost::addSourceToFrame):
        * inspector/InspectorFrontendHost.h: Added.
        (WebCore::InspectorFrontendHost::create):
        (WebCore::InspectorFrontendHost::inspectorController):
        (WebCore::InspectorFrontendHost::disconnectController):
        * inspector/InspectorFrontendHost.idl: Added.
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint.prototype.set condition):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.getChildNodesAsync):
        (WebInspector.DOMAgent.prototype.setAttributeAsync):
        (WebInspector.DOMAgent.prototype.removeAttributeAsync):
        (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
        (WebInspector.Cookies.getCookiesAsync):
        (WebInspector.EventListeners.getEventListenersForNodeAsync):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorage.prototype.getEntries):
        (WebInspector.DOMStorage.prototype.setItem):
        (WebInspector.DOMStorage.prototype.removeItem):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.getTableNames):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.hide):
        (WebInspector.ElementsPanel.prototype.reset):
        (WebInspector.ElementsPanel.prototype.handleCopyEvent):
        (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
        ():
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript._evaluateAndWrap):
        (InjectedScript.performSearch.addNodesToResults):
        (InjectedScript.getCallFrames):
        (InjectedScript._callFrameForId):
        (InjectedScript._clearConsoleMessages):
        (InjectedScript._inspectObject):
        (InjectedScript._copy):
        (InjectedScript._ensureCommandLineAPIInstalled):
        (InjectedScript._window):
        (InjectedScript._nodeForId):
        (InjectedScript._objectForId):
        (InjectedScript.pushNodeToFrontend):
        (InjectedScript.executeSql):
        (InjectedScript.executeSql.errorCallback):
        (InjectedScript.executeSql.queryTransaction):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/InspectorBackendStub.js: Added.
        (.WebInspector.InspectorBackendStub):
        (.WebInspector.InspectorBackendStub.prototype.wrapCallback):
        (.WebInspector.InspectorBackendStub.prototype.platform):
        (.WebInspector.InspectorBackendStub.prototype.port):
        (.WebInspector.InspectorBackendStub.prototype.closeWindow):
        (.WebInspector.InspectorBackendStub.prototype.attach):
        (.WebInspector.InspectorBackendStub.prototype.detach):
        (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel):
        (.WebInspector.InspectorBackendStub.prototype.clearMessages):
        (.WebInspector.InspectorBackendStub.prototype.searchingForNode):
        (.WebInspector.InspectorBackendStub.prototype.search):
        (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch):
        (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight):
        (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted):
        (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame):
        (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame):
        (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode):
        (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode):
        (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight):
        (.WebInspector.InspectorBackendStub.prototype.inspectedWindow):
        (.WebInspector.InspectorBackendStub.prototype.loaded):
        (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL):
        (.WebInspector.InspectorBackendStub.prototype.windowUnloading):
        (.WebInspector.InspectorBackendStub.prototype.hiddenPanels):
        (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
        (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
        (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableDebugger):
        (.WebInspector.InspectorBackendStub.prototype.disableDebugger):
        (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions):
        (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions):
        (.WebInspector.InspectorBackendStub.prototype.resumeDebugger):
        (.WebInspector.InspectorBackendStub.prototype.profilerEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableProfiler):
        (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
        (.WebInspector.InspectorBackendStub.prototype.startProfiling):
        (.WebInspector.InspectorBackendStub.prototype.stopProfiling):
        (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders):
        (.WebInspector.InspectorBackendStub.prototype.getProfile):
        (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot):
        (.WebInspector.InspectorBackendStub.prototype.databaseTableNames):
        (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.setSetting):
        (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript):
        (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
        (.WebInspector.InspectorBackendStub.prototype.setting):
        * inspector/front-end/InspectorControllerStub.js:
        * inspector/front-end/InspectorFrontendHostStub.js: Added.
        (.WebInspector.InspectorFrontendHostStub):
        (.WebInspector.InspectorFrontendHostStub.prototype.platform):
        (.WebInspector.InspectorFrontendHostStub.prototype.port):
        (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
        (.WebInspector.InspectorFrontendHostStub.prototype.attach):
        (.WebInspector.InspectorFrontendHostStub.prototype.detach):
        (.WebInspector.InspectorFrontendHostStub.prototype.search):
        (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
        (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
        (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame):
        (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame):
        (.WebInspector.InspectorFrontendHostStub.prototype.loaded):
        (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
        (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
        (.WebInspector.InspectorFrontendHostStub.prototype.setSetting):
        (.WebInspector.InspectorFrontendHostStub.prototype.setting):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView):
        (WebInspector.CPUProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        (WebInspector.ProfilesPanel.prototype._enableProfiling):
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
        (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype.addScript):
        (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype.canShowResource):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
        (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
        (WebInspector.ScriptsPanel.prototype._enableDebugging):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.ScriptsPanel.prototype._togglePause):
        (WebInspector.ScriptsPanel.prototype._stepOverClicked):
        (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
        (WebInspector.ScriptsPanel.prototype._stepOutClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
        (WebInspector.SourceView.prototype.performSearch):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
        * inspector/front-end/TestController.js:
        (WebInspector.TestController.prototype.notifyDone):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
        (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.pendingDispatches.0.get platform):
        (WebInspector.get port):
        (WebInspector.set currentPanel):
        (WebInspector._createPanels):
        (WebInspector._loadPreferences):
        (WebInspector.set attached):
        (WebInspector._updateHoverHighlight):
        (WebInspector.loaded):
        (windowLoaded):
        (WebInspector.windowUnload):
        (WebInspector.close):
        (WebInspector.toolbarDrag):
        (WebInspector.UIString):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87861d02
    • hamaji@chromium.org's avatar
      2009-11-30 Shinichiro Hamaji <hamaji@chromium.org> · 382642ba
      hamaji@chromium.org authored 
              Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264
        css2.1/t1205-c565-list-pos-00-b.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23263

        Ignore whitespaces after list markers.
        Rendering of this was already done for the case where inside=false.
        This fixes the rendering of inside=true case and calcInlinePrefWidths.

        Test: fast/lists/calc-width-with-space.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):
2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264

        * editing/pasteboard/copy-crash-expected.txt:
        * fast/lists/calc-width-with-space-expected.txt: Added.
        * fast/lists/calc-width-with-space.html: Added.
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
        * platform/mac/fast/repaint/list-marker-expected.checksum:
        * platform/mac/fast/repaint/list-marker-expected.png:
        * platform/mac/fast/repaint/list-marker-expected.txt:
        * platform/qt/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      382642ba
    • abarth@webkit.org's avatar
      2009-11-30 Adam Barth <abarth@webkit.org> · 43c50352
      abarth@webkit.org authored 
              Reviewed by Eric Seidel.

        check-webkit-style is slightly too verbose
        https://bugs.webkit.org/show_bug.cgi?id=32010

        check-webkit-style prints out a bunch of "done" lines that seem redundant,
        especially for the style-queue.

        * Scripts/modules/cpp_style.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43c50352
  3. 30 Nov, 2009 33 commits
    • eric@webkit.org's avatar
      2009-11-30 Alejandro G. Castro <alex@igalia.com> · 5214a6b5
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        [GTK] Moved the functions that are closing the result log of the
        tests to the last line of the runTest function, this avoids
        reporting crashes in the wrong test if there is a problem when
        reseting the state after the test.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):
        (runTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5214a6b5
    • ukai@chromium.org's avatar
      2009-11-30 Fumitoshi Ukai <ukai@chromium.org> · 317a5e7c
      ukai@chromium.org authored 
              Unreviewed Chromium build fix introduced by r51212

        Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
        as the first argument.
        Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
        Add debuggerWorld() and pluginWorld() in ScriptState.h.

        * bindings/v8/ScriptController.cpp:
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::scriptStateFromNode):
        (WebCore::scriptStateFromPage):
        (WebCore::mainThreadNormalWorld):
        * bindings/v8/ScriptState.h:
        (WebCore::debuggerWorld):
        (WebCore::pluginWorld):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      317a5e7c
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=31286 · bb56753a
      weinig@apple.com authored 
      fast/js/date-proto-generic-invocation breaks another test

Reviewed by Geoffrey Garen.

Don't cache JSClassRefs, a change to the prototype chain will
last between tests.

* DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::getJSClass):
* DumpRenderTree/GCController.cpp:
(GCController::getJSClass):
* DumpRenderTree/GCController.h:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::getJSClass):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb56753a
    • enrica@apple.com's avatar
      WebCore: Can focus but not type into content editable block that contains only... · 429c6e2b
      enrica@apple.com authored 
      WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
        
Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

* WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
* dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
* dom/Position.h:
(WebCore::Position::):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
* rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
* rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

* editing/selection/5825350-1-expected.txt:
* editing/selection/5825350-1.html: Modified to use caret rectangle.
* editing/selection/5825350-2-expected.txt:
* editing/selection/5825350-2.html: Modified to use caret rectangle.
* editing/selection/mixed-editability-10-expected.txt: Added.
* editing/selection/mixed-editability-10.html: Added.
* platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429c6e2b
    • eric@webkit.org's avatar
      2009-11-30 Yuzo Fujishima <yuzo@google.com> · cb0075b0
      eric@webkit.org authored 
              Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.2.1.
        This is to fix a bug that some messages are logged to stderr even when the log file is specified.
        https://bugs.webkit.org/show_bug.cgi?id=31976

        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb0075b0
    • kevino@webkit.org's avatar
      wx build fix, add header needed for wx build. · 326e8dea
      kevino@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      326e8dea
    • mrowe@apple.com's avatar
      <rdar://problem/7424387> WebCore binary missing symbols when built for x86_64... · 384efa6a
      mrowe@apple.com authored 
      <rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
be performed against the x86_64 architecture.

* DerivedSources.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      384efa6a
    • eric@webkit.org's avatar
      2009-11-30 Adam Barth <abarth@webkit.org> · 39598035
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        [bzt] Generate pass messages for style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31995

        With this change, the style-queue posts "pass" messages to bugs as
        well.  Also, added more information to the state store w.r.t. passing
        and failing.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39598035
    • bdakin@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in · 70c2e451
      bdakin@apple.com authored 
      Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used 
as a divisor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

* fast/multicol/huge-column-gap-crash-expected.txt: Added.
* fast/multicol/huge-column-gap-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70c2e451
    • ap@apple.com's avatar
      Reviewed by Oliver Hunt. · 53c40236
      ap@apple.com authored 
              https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53c40236
    • eric@webkit.org's avatar
      2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com> · e1dd094e
      eric@webkit.org authored 
              Reviewed by Simon Hausmann.

        [Qt][Symbian] Report SymbianOS in user agent string for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31961

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1dd094e
    • barraclough@apple.com's avatar
      Windows Build fix. Reviewed by NOBODY. · ca49f604
      barraclough@apple.com authored 
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca49f604
    • mrowe@apple.com's avatar
      Use the correct path to Info.plist to avoid creating an empty file at the top... · 5a35b872
      mrowe@apple.com authored 
      Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a35b872
    • barraclough@apple.com's avatar
      Bug 31859 - Make world selection for JSC IsolatedWorlds automagical. · 6539bbe2
      barraclough@apple.com authored 
      Reviewed by Geoff Garen.

JavaScriptCore: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
        
Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:

WebCore: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

* WebCore.base.exp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
* dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
* dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
* dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac: 

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6539bbe2
    • eric.carlson@apple.com's avatar
      2009-11-30 Eric Carlson <eric.carlson@apple.com> · 8fec90f7
      eric.carlson@apple.com authored 
              Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::noneSupported):
        (WebCore::HTMLMediaElement::mediaEngineError):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::userCancelledLoad):
            Call scheduleEvent instead of scheduleProgressEvent.
        (WebCore::HTMLMediaElement::progressEventTimerFired):
            Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
            after scheduling a 'progress' event so the controller will update download
            progress indicator.
        * html/HTMLMediaElement.h:
            Remove scheduleProgressEvent prototype.

2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513
        
        Remove progress event tests.

        * media/progress-event-at-least-one-expected.txt: Removed.
        * media/progress-event-at-least-one.html: Removed.
        * media/progress-event-expected.txt: Removed.
        * media/progress-event-total-expected.txt: Removed.
        * media/progress-event-total.html: Removed.
        * media/progress-event.html: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fec90f7
    • aroben@apple.com's avatar
      Fix double-free of BSTRs passed to WebNavigationData::createInstance · 391d91e9
      aroben@apple.com authored 
      WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

* WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
* WebNavigationData.h:
Changed to take const WebCore::Stri...
      391d91e9
    • ap@apple.com's avatar
      It was me who reviewed the patch, not Eric! Alas, some tools we use cause... · 6d23a697
      ap@apple.com authored 
      It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d23a697
    • ap@apple.com's avatar
      2009-11-30 Yuzo Fujishima <yuzo@google.com> · 87995de7
      ap@apple.com authored 
              Reviewed by Eric Seidel.

        In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
        https://bugs.webkit.org/show_bug.cgi?id=31465

        * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to
        Skipped list, and filed bug 31659 to investigate.

        * websocket/tests/handshake-error_wsh.py: Call write() on a correct object.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87995de7
    • joepeck@webkit.org's avatar
      Remove file git invisibly added · 0edf8337
      joepeck@webkit.org authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0edf8337
    • joepeck@webkit.org's avatar
      2009-11-30 Joseph Pecoraro <joepeck@webkit.org> · 723f16eb
      joepeck@webkit.org authored 
              Reviewed by Pavel Feldman.

        Web Inspector: Wrong console output for Regexp escape sequence
        https://bugs.webkit.org/show_bug.cgi?id=31538

        Updated inspector/console-format.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement): style issues.
        (WebInspector.ConsoleView.createFilterElement): style issues.
        (WebInspector.ConsoleView): added _customFormatters table.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
        (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
        (WebInspector.ConsoleView.prototype._formatobject):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._printArray):
        (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
        (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/InjectedScript.js: simplified regex formatting.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass): update inaccurate comment.
        (String.prototype.trimURL): converted new RegExp to literal for performance benefits.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      723f16eb
    • eric@webkit.org's avatar
      2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5c6ee644
      eric@webkit.org authored 
              Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove obsolete PLATFORM(KDE) code
        https://bugs.webkit.org/show_bug.cgi?id=31958

        KDE is now using unpatched QtWebKit.

        * parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
        * wtf/Platform.h: Remove PLATFORM(KDE) definition and code
        section that is guarded with it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c6ee644
    • kov@webkit.org's avatar
      Skipping test that fails because of broken DND, and some tests · f4d1ccff
      kov@webkit.org authored 
      requiring new results.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4d1ccff
    • kov@webkit.org's avatar
      Rubber-stamped by Xan Lopez. · 2a1f73ca
      kov@webkit.org authored 
      Make sure we distribute and install GObject Introspection files.

* GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a1f73ca
    • eric@webkit.org's avatar
      2009-11-30 Erik Arvidsson <arv@chromium.org> · 10fcdba8
      eric@webkit.org authored 
              Reviewed by Adam Barth.

        Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=31895

        No new tests. This is already covered by:
                fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                fast/dom/CSSStyleDeclaration/css-style-item.html

        * bindings/v8/V8Collection.h:
        (WebCore::collectionStringIndexedPropertyGetter):
        (WebCore::setCollectionStringIndexedGetter):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10fcdba8
    • sfalken@apple.com's avatar
      WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld... · 18e1477d
      sfalken@apple.com authored 
      WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18e1477d
    • kov@webkit.org's avatar
      Reviewed by Simon Fraser. · a9abbee5
      kov@webkit.org authored 
      Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9abbee5
    • eric@webkit.org's avatar
      2009-11-30 Steve Block <steveblock@google.com> · 2b92f0e3
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
        https://bugs.webkit.org/show_bug.cgi?id=31932

        Build fix only, no new tests.

        * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b92f0e3
    • eric@webkit.org's avatar
      2009-11-30 Steve Block <steveblock@google.com> · 4caafb76
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        Adds PassOwnPtr include to ScriptExecutionContext.h.
        https://bugs.webkit.org/show_bug.cgi?id=31929

        Build fix only, no new tests.

        * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4caafb76
    • eric@webkit.org's avatar
      2009-11-30 Dirk Schulze <krit@webkit.org> · 5b0c5989
      eric@webkit.org authored 
              Reviewed by Nikolas Zimmermann.

        Complex test of mask with every combination of maskUnits and maskContentUnits
        as well as different values for size and position of the mask and it's content.

        * platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
        * svg/custom/mask-with-all-units.svg: Added.
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
        [https://bugs.webkit.org/show_bug.cgi?id=31980]

        It turns out, that we did not handle maskUnits="userSpaceOnUse"
        correctly. We just need to move the context of the maskImage
        if maskContentUnits="objectBoundingBox". The context gets scaled
        on this unit combination, so we have to substract the position of
        the targetRect. On userSpaceOnUse the position just depends on the
        position of the mask element.
        I added a test with some senseless and reasonable values for size
        and postion of the mask and it's contents. I also used every
        combination of maskUnits and maskContentUnits to be sure, that it
        is fixed this time.

        Test: svg/custom/mask-with-all-units.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b0c5989
    • eric@webkit.org's avatar
      2009-11-30 Steve Block <steveblock@google.com> · 54abffc6
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31928

        Build fix only, no new tests.

        * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54abffc6
    • eric@webkit.org's avatar
      2009-11-30 Yaar Schnitman <yaar@chromium.org> · 1c1a18c1
      eric@webkit.org authored 
              Reviewed by Dimitri Glazkov.

        update-webkit --chromium forces gclient sync

        https://bugs.webkit.org/show_bug.cgi?id=31967

        * Scripts/update-webkit-chromium:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c1a18c1
    • eric@webkit.org's avatar
      2009-11-30 Steve Block <steveblock@google.com> · 70a4bba4
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=31926

        Build fix only, no new tests.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a4bba4
    • eric@webkit.org's avatar
      2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com> · 9c8c379e
      eric@webkit.org authored 
              Reviewed by Kenneth Rohde Christiansen.

        Chrome::contentsSizeChanged() is called when the content size has not changed
        https://bugs.webkit.org/show_bug.cgi?id=31978

        Do not trigger contentsSizeChaned() is the new size is the same as the old one.

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8c379e