1. 16 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 60d3e9f9
      darin@apple.com authored
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebCore.base.exp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              (WebCore::JSCustomSQLStatementCallback::handleEvent):
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::JSCustomVoidCallback::handleEvent):
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::allowPopUp):
              (WebCore::createWindow):
              (WebCore::windowProtoFuncOpen):
              (WebCore::toJS):
              (WebCore::toJSDOMWindow):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::toJS):
              (WebCore::toJSDOMWindowShell):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::navigateIfAllowed):
              (WebCore::JSLocation::reload):
              * bindings/js/JSNodeFilterCondition.cpp:
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_html.cpp:
              (WebCore::runtimeObjectImplementsCall):
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * bridge/jni/jni_jsobject.mm:
              (createRootObject):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              * dom/Document.cpp:
              (WebCore::Document::nodeWillBeRemoved):
              (WebCore::Document::createHTMLEventListener):
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::dispatchGenericEvent):
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::startElementNs):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::respondToChangedSelection):
              (WebCore::DeleteButtonController::enable):
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::selectionForCommand):
              (WebCore::Editor::canEdit):
              (WebCore::Editor::canEditRichly):
              (WebCore::Editor::canDHTMLCut):
              (WebCore::Editor::canDHTMLCopy):
              (WebCore::Editor::canCopy):
              (WebCore::Editor::canDelete):
              (WebCore::Editor::deleteWithDirection):
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::selectedRange):
              (WebCore::Editor::tryDHTMLCopy):
              (WebCore::Editor::tryDHTMLCut):
              (WebCore::Editor::fontForSelection):
              (WebCore::Editor::selectionUnorderedListState):
              (WebCore::Editor::selectionOrderedListState):
              (WebCore::Editor::increaseSelectionListLevel):
              (WebCore::Editor::increaseSelectionListLevelOrdered):
              (WebCore::Editor::increaseSelectionListLevelUnordered):
              (WebCore::Editor::decreaseSelectionListLevel):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::applyStyleToSelection):
              (WebCore::Editor::applyParagraphStyleToSelection):
              (WebCore::Editor::selectionHasStyle):
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::unappliedEditing):
              (WebCore::Editor::reappliedEditing):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::paste):
              (WebCore::Editor::selectComposition):
              (WebCore::Editor::confirmComposition):
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::getCompositionSelection):
              (WebCore::Editor::transpose):
              * editing/EditorCommand.cpp:
              (WebCore::expandSelectionToGranularity):
              (WebCore::executeDeleteToMark):
              (WebCore::executeMoveBackward):
              (WebCore::executeMoveBackwardAndModifySelection):
              (WebCore::executeMoveDown):
              (WebCore::executeMoveDownAndModifySelection):
              (WebCore::executeMoveForward):
              (WebCore::executeMoveForwardAndModifySelection):
              (WebCore::executeMoveLeft):
              (WebCore::executeMoveLeftAndModifySelection):
              (WebCore::executeMovePageDown):
              (WebCore::executeMovePageDownAndModifySelection):
              (WebCore::executeMovePageUp):
              (WebCore::executeMovePageUpAndModifySelection):
              (WebCore::executeMoveRight):
              (WebCore::executeMoveRightAndModifySelection):
              (WebCore::executeMoveToBeginningOfDocument):
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::executeMoveToBeginningOfLine):
              (WebCore::executeMoveToBeginningOfLineAndModifySelection):
              (WebCore::executeMoveToBeginningOfParagraph):
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::executeMoveToBeginningOfSentence):
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfDocument):
              (WebCore::executeMoveToEndOfDocumentAndModifySelection):
              (WebCore::executeMoveToEndOfSentence):
              (WebCore::executeMoveToEndOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfLine):
              (WebCore::executeMoveToEndOfLineAndModifySelection):
              (WebCore::executeMoveToEndOfParagraph):
              (WebCore::executeMoveToEndOfParagraphAndModifySelection):
              (WebCore::executeMoveParagraphBackwardAndModifySelection):
              (WebCore::executeMoveParagraphForwardAndModifySelection):
              (WebCore::executeMoveUp):
              (WebCore::executeMoveUpAndModifySelection):
              (WebCore::executeMoveWordBackward):
              (WebCore::executeMoveWordBackwardAndModifySelection):
              (WebCore::executeMoveWordForward):
              (WebCore::executeMoveWordForwardAndModifySelection):
              (WebCore::executeMoveWordLeft):
              (WebCore::executeMoveWordLeftAndModifySelection):
              (WebCore::executeMoveWordRight):
              (WebCore::executeMoveWordRightAndModifySelection):
              (WebCore::executeSelectAll):
              (WebCore::executeSelectToMark):
              (WebCore::executeSetMark):
              (WebCore::executeSwapWithMark):
              (WebCore::executeUnselect):
              (WebCore::enabledAnySelection):
              (WebCore::enabledAnySelectionAndMark):
              (WebCore::enabledInRichlyEditableText):
              (WebCore::enabledRangeInEditableText):
              (WebCore::enabledRangeInRichlyEditableText):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              (WebCore::HTMLAnchorElement::setActive):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::createNPObject):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::evaluateScript):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::processToken):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::executeScript):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::userGestureHint):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::dispatchWindowObjectAvailable):
              (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::createFromSelection):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::selection):
              (WebCore::AccessibilityRenderObject::setSelectedTextRange):
              (WebCore::AccessibilityRenderObject::isFocused):
              (WebCore::AccessibilityRenderObject::doAXTextMarkerRangeForLine):
              (WebCore::AccessibilityRenderObject::doSetAXSelectedTextMarkerRange):
              (WebCore::AccessibilityRenderObject::doAXRangeForLine):
              (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorNode):
              (WebCore::DOMSelection::baseNode):
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::focusNode):
              (WebCore::DOMSelection::extentNode):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::extentOffset):
              (WebCore::DOMSelection::isCollapsed):
              (WebCore::DOMSelection::type):
              (WebCore::DOMSelection::rangeCount):
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::collapseToEnd):
              (WebCore::DOMSelection::collapseToStart):
              (WebCore::DOMSelection::empty):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::modify):
              (WebCore::DOMSelection::extend):
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::removeAllRanges):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::toString):
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::setSelectionToDragCaret):
              (WebCore::DragController::concludeDrag):
              (WebCore::prepareClipboardForImageDrag):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventDoubleClick):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::nodeIsNotBeingEdited):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::sendContextMenuEvent):
              (WebCore::EventHandler::handleKeyboardSelectionMovement):
              (WebCore::EventHandler::handleDrag):
              * page/FocusController.cpp:
              (WebCore::FocusController::setFocusedFrame):
              (WebCore::clearSelectionIfNeeded):
              (WebCore::FocusController::setActive):
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              (WebCore::Frame::script):
              (WebCore::Frame::setDocument):
              (WebCore::Frame::selectedText):
              (WebCore::Frame::selection):
              (WebCore::Frame::animation):
              (WebCore::Frame::notifyRendererOfSelectionChange):
              (WebCore::Frame::invalidateSelection):
              (WebCore::Frame::clearCaretRectIfNeeded):
              (WebCore::Frame::setFocusedNodeIfNeeded):
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::paintCaret):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::updateSecureKeyboardEntryIfActive):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::bindingRootObject):
              (WebCore::Frame::windowScriptNPObject):
              (WebCore::Frame::clearScriptController):
              (WebCore::Frame::selectionTextRects):
              (WebCore::Frame::currentForm):
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::revealCaret):
              (WebCore::Frame::clearTimers):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::findString):
              (WebCore::Frame::pageDestroyed):
              (WebCore::Frame::respondToChangedSelection):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/InspectorController.cpp:
              (WebCore::canPassNodeToJavaScript):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              * page/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
              * page/Page.cpp:
              (WebCore::Page::findString):
              (WebCore::Page::selection):
              (WebCore::Page::setDebugger):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::baseWritingDirectionForSelectionStart):
              (WebCore::Frame::dragImageForSelection):
              (WebCore::Frame::createScriptInstanceForWidget):
              (WebCore::Frame::windowScriptObject):
              * page/win/FrameWin.cpp:
              (WebCore::Frame::dragImageForSelection):
              * platform/ContextMenu.cpp:
              (WebCore::selectionContainsPossibleWord):
              (WebCore::ContextMenu::populate):
              (WebCore::ContextMenu::checkOrEnableIfNeeded):
              * plugins/PluginView.cpp:
              (WebCore::PluginView::performRequest):
              (WebCore::PluginView::bindingInstance):
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::isSelected):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::paintItemForeground):
              (WebCore::RenderListBox::paintItemBackground):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::selectionBackgroundColor):
              (WebCore::RenderObject::selectionForegroundColor):
              (WebCore::RenderObject::setAnimatableStyle):
              (WebCore::RenderObject::destroy):
              (WebCore::RenderObject::animation):
              * rendering/RenderObject.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionStart):
              (WebCore::RenderTextControl::selectionEnd):
              (WebCore::RenderTextControl::setSelectionRange):
              (WebCore::RenderTextControl::selectionChanged):
              (WebCore::RenderTextControl::capsLockStateMayHaveChanged):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isFocused):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::destroy):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::createSVGEventListener):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::deselectAll):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      WebKit/gtk:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::handleKeyboardEvent):
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::windowObjectCleared):
              * webkit/webkitwebframe.cpp:
              * webkit/webkitwebview.cpp:
      
      WebKit/mac:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * Plugins/WebPluginController.mm:
              (-[WebPluginController webPlugInContainerSelectionColor]):
              * WebView/WebFrame.mm:
              (-[WebFrame _attachScriptDebugger]):
              (-[WebFrame _hasSelection]):
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
              (-[WebFrame _convertToNSRange:]):
              (-[WebFrame _convertToDOMRange:]):
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
              (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
              (-[WebFrame _selectedNSRange]):
              (-[WebFrame _selectNSRange:]):
              (-[WebFrame globalContext]):
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _selectedRange]):
              (-[WebHTMLView _hasSelection]):
              (-[WebHTMLView _hasSelectionOrInsertionPoint]):
              (-[WebHTMLView _hasInsertionPoint]):
              (-[WebHTMLView _isEditable]):
              (-[WebHTMLView _updateFocusedAndActiveState]):
              (-[WebHTMLView readSelectionFromPasteboard:]):
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView maintainsInactiveSelection]):
              (-[WebHTMLView paste:]):
              (isTextInput):
              (-[WebHTMLView inputContext]):
              (-[WebTextCompleteController doCompletion]):
              (-[WebHTMLView selectAll]):
              (-[WebHTMLView deselectAll]):
              (-[WebHTMLView selectedAttributedString]):
              * WebView/WebView.mm:
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
              (-[WebView setSelectedDOMRange:affinity:]):
              (-[WebView selectedDOMRange]):
              (-[WebView selectionAffinity]):
      
      WebKit/qt:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateJavaScript):
              * Api/qwebpage.cpp:
              (QWebPagePrivate::focusInEvent):
              (QWebPagePrivate::focusOutEvent):
              (QWebPage::inputMethodQuery):
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      
      WebKit/win:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebFrame.cpp:
              (WebFrame::globalContext):
              (WebFrame::windowObjectCleared):
              * WebView.cpp:
              (WebView::handleContextMenuEvent):
              (WebViewWndProc):
              (WebView::updateFocusedAndActiveState):
              (WebView::hasSelectedRange):
              (WebView::replaceSelectionWithText):
              (WebView::clearSelection):
              (WebView::prepareCandidateWindow):
              (WebView::onIMERequestCharPosition):
              (WebView::onIMERequestReconvertString):
      
      WebKit/wx:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::handleKeyboardEvent):
              * WebView.cpp:
              (wxWebView::RunScript):
              (wxWebView::OnSetFocus):
              (wxWebView::OnKillFocus):
      
      WebKitTools:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              * Scripts/do-webcore-rename: Updated for the latest round of renaming.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60d3e9f9
  2. 14 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 48ac3c40
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCore.base.exp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              (WebCore::JSSVGMatrix::multiply):
              (WebCore::JSSVGMatrix::inverse):
              (WebCore::JSSVGMatrix::translate):
              (WebCore::JSSVGMatrix::scale):
              (WebCore::JSSVGMatrix::scaleNonUniform):
              (WebCore::JSSVGMatrix::rotate):
              (WebCore::JSSVGMatrix::rotateFromVector):
              (WebCore::JSSVGMatrix::flipX):
              (WebCore::JSSVGMatrix::flipY):
              (WebCore::JSSVGMatrix::skewX):
              (WebCore::JSSVGMatrix::skewY):
              * bindings/js/JSSVGPODTypeWrapper.h:
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
              (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
              (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGPointList::clear):
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::getItem):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::removeItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGTransformList::clear):
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::getItem):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::removeItem):
              (WebCore::JSSVGTransformList::appendItem):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::CSSFontSelector):
              (WebCore::CSSFontSelector::~CSSFontSelector):
              * css/CSSFontSelector.h:
              (WebCore::CSSFontSelector::create):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Attribute.cpp:
              (WebCore::Attribute::clone):
              * dom/Attribute.h:
              (WebCore::Attribute::create):
              (WebCore::Attribute::Attribute):
              * dom/BeforeTextInsertedEvent.h:
              (WebCore::BeforeTextInsertedEvent::create):
              * dom/BeforeUnloadEvent.h:
              (WebCore::BeforeUnloadEvent::create):
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::dispatchModifiedEvent):
              * dom/ClipboardEvent.cpp:
              (WebCore::ClipboardEvent::ClipboardEvent):
              * dom/ClipboardEvent.h:
              (WebCore::ClipboardEvent::create):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::removeChild):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/Document.cpp:
              (WebCore::Document::createTextNode):
              (WebCore::Document::createComment):
              (WebCore::Document::createCDATASection):
              (WebCore::Document::createProcessingInstruction):
              (WebCore::Document::createEntityReference):
              (WebCore::Document::createEditingTextNode):
              (WebCore::Document::createEvent):
              (WebCore::Document::createAttributeNS):
              (WebCore::Document::finishedParsing):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::createAttribute):
              * dom/Element.h:
              * dom/Event.cpp:
              (WebCore::Event::Event):
              * dom/Event.h:
              (WebCore::Event::create):
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
              (WebCore::EventTargetNode::dispatchWindowEvent):
              (WebCore::EventTargetNode::dispatchUIEvent):
              (WebCore::EventTargetNode::dispatchKeyEvent):
              (WebCore::EventTargetNode::dispatchMouseEvent):
              (WebCore::EventTargetNode::dispatchWheelEvent):
              (WebCore::EventTargetNode::dispatchHTMLEvent):
              (WebCore::EventTargetNode::dispatchProgressEvent):
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/KeyboardEvent.h:
              (WebCore::KeyboardEvent::create):
              * dom/MappedAttribute.cpp:
              (WebCore::MappedAttribute::clone):
              * dom/MappedAttribute.h:
              (WebCore::MappedAttribute::create):
              (WebCore::MappedAttribute::setDecl):
              (WebCore::MappedAttribute::MappedAttribute):
              * dom/MessageEvent.cpp:
              (WebCore::MessageEvent::MessageEvent):
              * dom/MessageEvent.h:
              (WebCore::MessageEvent::create):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              (WebCore::MouseEvent::initMouseEvent):
              * dom/MouseEvent.h:
              (WebCore::MouseEvent::create):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              * dom/MouseRelatedEvent.h:
              * dom/MutationEvent.cpp:
              (WebCore::MutationEvent::MutationEvent):
              (WebCore::MutationEvent::initMutationEvent):
              * dom/MutationEvent.h:
              (WebCore::MutationEvent::create):
              * dom/OverflowEvent.h:
              (WebCore::OverflowEvent::create):
              * dom/ProgressEvent.h:
              (WebCore::ProgressEvent::create):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::getMappedAttributeDecl):
              (WebCore::StyledElement::setMappedAttributeDecl):
              (WebCore::StyledElement::removeMappedAttributeDecl):
              (WebCore::StyledElement::createAttribute):
              * dom/StyledElement.h:
              * dom/TextEvent.cpp:
              (WebCore::TextEvent::TextEvent):
              (WebCore::TextEvent::initTextEvent):
              * dom/TextEvent.h:
              (WebCore::TextEvent::create):
              * dom/UIEvent.cpp:
              (WebCore::UIEvent::UIEvent):
              (WebCore::UIEvent::initUIEvent):
              * dom/UIEvent.h:
              (WebCore::UIEvent::create):
              * dom/UIEventWithKeyState.h:
              (WebCore::UIEventWithKeyState::ctrlKey):
              (WebCore::UIEventWithKeyState::shiftKey):
              (WebCore::UIEventWithKeyState::altKey):
              (WebCore::UIEventWithKeyState::metaKey):
              (WebCore::UIEventWithKeyState::UIEventWithKeyState):
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              (WebCore::WheelEvent::initWheelEvent):
              * dom/WheelEvent.h:
              (WebCore::WheelEvent::create):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand):
              * editing/AppendNodeCommand.h:
              (WebCore::AppendNodeCommand::create):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::create):
              * editing/BreakBlockquoteCommand.h:
              (WebCore::BreakBlockquoteCommand::create):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::applyStyle):
              (WebCore::CompositeEditCommand::applyStyledElement):
              (WebCore::CompositeEditCommand::removeStyledElement):
              (WebCore::CompositeEditCommand::insertParagraphSeparator):
              (WebCore::CompositeEditCommand::insertLineBreak):
              (WebCore::CompositeEditCommand::insertNodeBefore):
              (WebCore::CompositeEditCommand::appendNode):
              (WebCore::CompositeEditCommand::removeNode):
              (WebCore::CompositeEditCommand::removeNodePreservingChildren):
              (WebCore::CompositeEditCommand::splitTextNode):
              (WebCore::CompositeEditCommand::splitElement):
              (WebCore::CompositeEditCommand::mergeIdenticalElements):
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan):
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement):
              (WebCore::CompositeEditCommand::joinTextNodes):
              (WebCore::CompositeEditCommand::inputText):
              (WebCore::CompositeEditCommand::insertTextIntoNode):
              (WebCore::CompositeEditCommand::deleteTextFromNode):
              (WebCore::CompositeEditCommand::replaceTextInNode):
              (WebCore::CompositeEditCommand::deleteSelection):
              (WebCore::CompositeEditCommand::removeCSSProperty):
              (WebCore::CompositeEditCommand::removeNodeAttribute):
              (WebCore::CompositeEditCommand::setNodeAttribute):
              (WebCore::CompositeEditCommand::appendBlockPlaceholder):
              (WebCore::CompositeEditCommand::insertBlockPlaceholder):
              (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/CompositeEditCommand.h:
              (WebCore::CompositeEditCommand::isFirstCommand):
              * editing/CreateLinkCommand.h:
              (WebCore::CreateLinkCommand::create):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * editing/DeleteFromTextNodeCommand.h:
              (WebCore::DeleteFromTextNodeCommand::create):
              * editing/DeleteSelectionCommand.h:
              (WebCore::DeleteSelectionCommand::create):
              * editing/EditCommand.h:
              (WebCore::SimpleEditCommand::SimpleEditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::removeFormattingAndStyle):
              (WebCore::Editor::clearLastEditCommand):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::indent):
              (WebCore::Editor::outdent):
              (WebCore::dispatchEditableContentChangedEvents):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertFragment):
              (WebCore::executeCreateLink):
              (WebCore::executeFormatBlock):
              (WebCore::executeIndent):
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertUnorderedList):
              (WebCore::executeOutdent):
              (WebCore::executeUnlink):
              * editing/FormatBlockCommand.h:
              (WebCore::FormatBlockCommand::create):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/IndentOutdentCommand.h:
              (WebCore::IndentOutdentCommand::create):
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * editing/InsertIntoTextNodeCommand.h:
              (WebCore::InsertIntoTextNodeCommand::create):
              * editing/InsertLineBreakCommand.h:
              (WebCore::InsertLineBreakCommand::create):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::create):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              * editing/InsertNodeBeforeCommand.h:
              (WebCore::InsertNodeBeforeCommand::create):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.h:
              (WebCore::InsertParagraphSeparatorCommand::create):
              * editing/InsertTextCommand.h:
              (WebCore::InsertTextCommand::create):
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
              * editing/JoinTextNodesCommand.h:
              (WebCore::JoinTextNodesCommand::create):
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              * editing/MergeIdenticalElementsCommand.h:
              (WebCore::MergeIdenticalElementsCommand::create):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/MoveSelectionCommand.h:
              (WebCore::MoveSelectionCommand::create):
              * editing/RemoveCSSPropertyCommand.cpp:
              (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * editing/RemoveCSSPropertyCommand.h:
              (WebCore::RemoveCSSPropertyCommand::create):
              * editing/RemoveFormatCommand.h:
              (WebCore::RemoveFormatCommand::create):
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * editing/RemoveNodeAttributeCommand.h:
              (WebCore::RemoveNodeAttributeCommand::create):
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand):
              * editing/RemoveNodeCommand.h:
              (WebCore::RemoveNodeCommand::create):
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              (WebCore::RemoveNodePreservingChildrenCommand::doApply):
              * editing/RemoveNodePreservingChildrenCommand.h:
              (WebCore::RemoveNodePreservingChildrenCommand::create):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd):
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::ReplaceSelectionCommand::create):
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * editing/SetNodeAttributeCommand.h:
              (WebCore::SetNodeAttributeCommand::create):
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand):
              * editing/SplitElementCommand.h:
              (WebCore::SplitElementCommand::create):
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
              * editing/SplitTextNodeCommand.h:
              (WebCore::SplitTextNodeCommand::create):
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * editing/SplitTextNodeContainingElementCommand.h:
              (WebCore::SplitTextNodeContainingElementCommand::create):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
              (WebCore::TypingCommand::insertParagraphSeparator):
              (WebCore::TypingCommand::insertTextRunWithoutNewlines):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::smartDelete):
              * editing/UnlinkCommand.h:
              (WebCore::UnlinkCommand::create):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              * editing/WrapContentsInDummySpanCommand.h:
              (WebCore::WrapContentsInDummySpanCommand::create):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
              (WebCore::HTMLTableElement::addSharedCellBordersDecl):
              (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
              (WebCore::HTMLTableElement::addSharedGroupDecls):
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              (WebCore::HTMLViewSourceDocument::addLine):
              (WebCore::HTMLViewSourceDocument::addLink):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didOpenURL):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::callListener):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
              (WebCore::PostMessageTimer::fired):
              (WebCore::DOMWindow::postMessage):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::handleTextInputEvent):
              * page/Frame.cpp:
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::shouldClose):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::currentKeyboardEvent):
              * page/mac/FrameMac.mm:
              * platform/DeprecatedValueListImpl.cpp:
              (WebCore::DeprecatedValueListImpl::Private::Private):
              (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl):
              (WebCore::DeprecatedValueListImpl::copyOnWrite):
              * platform/graphics/FontSelector.h:
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage):
              * platform/graphics/GlyphPageTreeNode.h:
              (WebCore::GlyphPage::create):
              (WebCore::GlyphPage::GlyphPage):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateReflectionStyle):
              * rendering/style/RenderStyle.h:
              (WebCore::TransformOperation::~TransformOperation):
              (WebCore::ScaleTransformOperation::create):
              (WebCore::ScaleTransformOperation::ScaleTransformOperation):
              (WebCore::RotateTransformOperation::create):
              (WebCore::RotateTransformOperation::RotateTransformOperation):
              (WebCore::SkewTransformOperation::create):
              (WebCore::SkewTransformOperation::operator==):
              (WebCore::SkewTransformOperation::SkewTransformOperation):
              (WebCore::TranslateTransformOperation::create):
              (WebCore::TranslateTransformOperation::operator==):
              (WebCore::TranslateTransformOperation::TranslateTransformOperation):
              (WebCore::MatrixTransformOperation::create):
              (WebCore::MatrixTransformOperation::MatrixTransformOperation):
              (WebCore::StyleReflection::create):
              (WebCore::StyleReflection::StyleReflection):
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.h:
              (WebCore::StorageEvent::create):
              (WebCore::StorageEvent::StorageEvent):
              * svg/SVGAngle.cpp:
              (WebCore::SVGAngle::SVGAngle):
              * svg/SVGAngle.h:
              (WebCore::SVGAngle::create):
              * svg/SVGAnimatedTemplate.h:
              (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
              (WebCore::lookupOrCreateWrapper):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible):
              * svg/SVGElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::SVGMarkerElement):
              (WebCore::SVGMarkerElement::parseMappedAttribute):
              (WebCore::SVGMarkerElement::setOrientToAngle):
              * svg/SVGMarkerElement.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::createSVGAngle):
              * svg/SVGSVGElement.h:
              * svg/SVGZoomEvent.h:
              (WebCore::SVGZoomEvent::create):
              * svg/graphics/SVGImage.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener):
              (WebCore::XMLHttpRequest::dispatchProgressEvent):
              * xml/XMLHttpRequestProgressEvent.cpp:
              * xml/XMLHttpRequestProgressEvent.h:
              (WebCore::XMLHttpRequestProgressEvent::create):
              (WebCore::XMLHttpRequestProgressEvent::position):
              (WebCore::XMLHttpRequestProgressEvent::totalSize):
              (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):
      
      WebKit/mac:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebView/WebFrame.mm:
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ac3c40
  3. 19 Mar, 2008 1 commit
  4. 04 Feb, 2008 1 commit
    • harrison@apple.com's avatar
      Reviewed by Darin Adler. · 8726960f
      harrison@apple.com authored
              <rdar://problem/5607381> CrashTracer: [REGRESSION] 1748 crashes in Safari at com.apple.WebCore: WebCore::Image::width const + 24
      
              Use an empty image when the local image file could not be loaded.
      
              No test case because it would require forcing tiff load failure.
              
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::createDeletionUI):
              Do not present the deletion UI in the (odd) event that the delete button could not be loaded.
              
              * platform/graphics/mac/ImageMac.mm:
              (WebCore::Image::loadPlatformResource):
              Return an empty image instead of 0 if the load fails.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8726960f
  5. 13 Dec, 2007 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · deed90d0
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
              
              The code that checks the selected Range to see if it's inside an anchor
              checks ancestors of the Range's commonAncestor() but not the
              commonAncestor() itself, and so we'd fail to add markup for the enclosing
              anchor to the pasteboard.
              
              Some enclosing element getters check the node passed to the getter and some
              don't.  There were a few places where we incorrectly assumed that enclosing 
              element getters check the node passed to the getter, but this is the only 
              case that I'm able to write a test case for at the moment.
              
              In this patch I've:
              Changed enclosingNodeWithType and enclosingNodeWithTag to take in positions,
              like the newer enclosing element getters.  This is important because we must
              soon add code to the getters so that they understand that some editing positions
              inside nodes don't actually refer to positions inside those nodes but positions
              before and after them.  Like [table, 0].
              Changed enclosingNodeWithType and enclosingNodeWithTag to check nodes starting with
              n where [n, o] is the position passed to the getter, instead of starting the the parent
              of n.  This makes all but a few of the enclosing element getters behave consistently.
              Changed enclosingNodeWithType and enclosingNodeWithTag to not return non-editable 
              nodes if the input position was editable.  This fixes a bug that that the above change
              exposed.
              Changed enclosingTableCell to simply call enclosingNodeWithType.  We should do
              this for the rest of the getters, or simply remove them in favor of enclosingNodeWithType
              unless doing so would affect readability, like it would in the case of enclosingTableCell.
              Ditto for enclosingBlock.
      
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::doApply):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
              * editing/Editor.cpp:
              (WebCore::Editor::selectionUnorderedListState):
              (WebCore::Editor::selectionOrderedListState):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::shouldMerge):
              (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
              (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
              * editing/TextIterator.cpp:
              * editing/htmlediting.cpp:
              (WebCore::enclosingBlock):
              (WebCore::enclosingNodeWithTag):
              (WebCore::enclosingNodeOfType):
              (WebCore::enclosingTableCell):
              (WebCore::isTableCell):
              * editing/htmlediting.h:
              * editing/markup.cpp:
              (WebCore::appendStartMarkup):
              (WebCore::createMarkup):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
      
              * editing/pasteboard/5601583-1.html: Added.
              * platform/mac/editing/pasteboard/5601583-1-expected.checksum: Added.
              * platform/mac/editing/pasteboard/5601583-1-expected.png: Added.
              * platform/mac/editing/pasteboard/5601583-1-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deed90d0
  6. 30 Oct, 2007 1 commit
    • justing's avatar
      WebCore: · 94b6f9f4
      justing authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData
              
              We were trying to insert a tab into a br, after the br incorrectly ended up inside
              a tab span.
              
              * editing/DeleteButtonController.cpp: 
              (WebCore::isDeletableElement): Changed to take in a const Node* instead of a Node*.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::isTableRow): Ditto.
              * editing/IndentOutdentCommand.cpp:
              (WebCore::isIndentBlockquote): Ditto.
              (WebCore::isListOrIndentBlockquote): Ditto.
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Added, moved code from
              doApply here.
              (WebCore::InsertLineBreakCommand::doApply): 
              Don't upstream() the insertion position.  upstream()ing it will only have an effect
              when the insertion position is the first in its paragraph (since we canonicalize
              VisiblePositions to the upstream() candidate).  In this start of paragraph case, 
              upstream() can move outside inline elements like tab spans or elements that might
              have a different whitespace mode (added two test cases to cover these).
              Moved code to decide whether to insert a br or a '\n' to its own method.
              Removed special case code for inserting at a position inside a tab span.  We instead
              adjust the insertion position before insertion if it is inside a tab span and
              handle insertion in the appropriate if-block.  This fixes a bug where we would 
              only insert one line break when two were needed (added a testcase).
              Removed special case code for inserting before and after tables and horizontal
              rules.  We handle these insertions in the appropriate if-block.
              * editing/InsertLineBreakCommand.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::isMailPasteAsQuotationNode): Change to take in a const Node*.
              * editing/htmlediting.cpp:
              (WebCore::isContentEditable): Ditto.
              (WebCore::isBlock): Ditto.
              (WebCore::enclosingNodeOfType): Changed to take a function pointer to a function
              that takes in a const Node*.
              (WebCore::isTabSpanTextNode): Check to see that the node actually a text node,
              and not, say, a br.
              * editing/htmlediting.h:
              * editing/markup.cpp:
              (WebCore::styleFromMatchedRulesAndInlineDecl): Changed to take in a const Node*.
              (WebCore::elementHasTextDecorationProperty): Ditto.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5549929> CrashTracer: [USER] 35 crashes at WebCore::CharacterData::insertData
      
              * editing/inserting/5549929-1-expected.txt: Added.
              * editing/inserting/5549929-1.html: Added.
              * editing/inserting/5549929-2.html: Added.
              * editing/inserting/5549929-3.html: Added.
              * platform/mac/editing/inserting/5549929-2-expected.checksum: Added.
              * platform/mac/editing/inserting/5549929-2-expected.png: Added.
              * platform/mac/editing/inserting/5549929-2-expected.txt: Added.
              * platform/mac/editing/inserting/5549929-3-expected.checksum: Added.
              * platform/mac/editing/inserting/5549929-3-expected.png: Added.
              * platform/mac/editing/inserting/5549929-3-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94b6f9f4
  7. 10 Sep, 2007 1 commit
    • justing's avatar
      WebCore: · 91d64cca
      justing authored
              Reviewed by Darin.
      
              <rdar://problem/5467405> 
              Revert back behavior of -webkit-user-select to fix widget selection problems
              
              Rolled out r25086 and r25057.  I will be re-opening:
              <rdar://problem/5333725> -webkit-user-select: none makes selection difficult
              Which we will either to defer or fix by introducing a new value of -webkit-user-select.
              <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
              Which we will either defer or fix with Adele's patch that doesn't involve making 
              -webkit-user-select inherited.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::selectAll):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::canMouseDownStartSelect):
              * page/EventHandler.h:
              * rendering/RenderObject.cpp:
              (WebCore::selectStartNode):
              (WebCore::RenderObject::canSelect):
              (WebCore::RenderObject::shouldSelect):
              (WebCore::RenderObject::draggableNode):
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
              (WebCore::StyleRareNonInheritedData::operator==):
              (WebCore::StyleRareInheritedData::StyleRareInheritedData):
              (WebCore::StyleRareInheritedData::operator==):
              (WebCore::RenderStyle::diff):
              * rendering/RenderStyle.h:
              (WebCore::):
              (WebCore::RenderStyle::userSelect):
              (WebCore::RenderStyle::setUserSelect):
              (WebCore::RenderStyle::initialUserSelect):
      
      LayoutTests:
      
              Reviewed by Darin.
              
              <rdar://problem/5467405> 
              Revert back behavior of -webkit-user-select to fix widget selection problems
      
              * editing/selection/5333725.html: Removed.
              * editing/selection/5333725.html-disabled: Added.
              * editing/selection/user-select-text-inside-user-select-ignore.html: Removed.
              * editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Added.
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91d64cca
  8. 31 Aug, 2007 1 commit
    • aliceli1's avatar
      WebCore: · 3fe7bd33
      aliceli1 authored
              Reviewed by Tim Hatcher.
      
              Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show):
              Factored out the code in ::show() that created and styled the elements of the Deletion UI
      
              (WebCore::DeleteButtonController::createDeletionUI):
              Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
              of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a 
              bloated table deletion UI which was slow to show and hide. 
      
              * editing/DeleteButtonController.h:
              (WebCore::DeleteButtonController::enabled):
              Restore this function to how it used to be pre-r25305, sans asserts
      
              * editing/EditCommand.cpp:
              Add disable/enable sandwich when undoing/redoing commands too
              (WebCore::EditCommand::unapply):
              (WebCore::EditCommand::reapply):
      
      LayoutTests:
      
              Reviewed by Tim Hatcher.
      
              Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
      
              * editing/deleting/deletionUI-single-instance.html: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fe7bd33
  9. 29 Aug, 2007 1 commit
    • aliceli1's avatar
      fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() · 1e25b1e2
      aliceli1 authored
                                             after dropping a selected image over container's close box
      
              Reviewed by Darin and Maciej.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show):
              (WebCore::DeleteButtonController::hide):
              * editing/DeleteButtonController.h:
              (WebCore::DeleteButtonController::enabled):
              General changes made to DeleteButtonController: when hiding, it's not necessary to clear out 
              the m_containerElement and m_target, especially since to fix this bug we need to keep 
              their values around.  It's sufficient to just detach the container from target.
      
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand):
              Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.
      
              * editing/Editor.cpp:
              (WebCore::Editor::rangeForPoint):
              Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.
      
              * editing/htmlediting.cpp:
              * editing/htmlediting.h:
              (WebCore::avoidIntersectionWithNode):
              Moved function that operates on Range from markup.cpp to here
              Added new implementation for function that operates on Selection
      
              * editing/markup.cpp:
              (WebCore::createMarkup):
              Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e25b1e2
  10. 14 Aug, 2007 1 commit
    • justing's avatar
      LayoutTests: · 27d51d36
      justing authored
              Reviewed by Tim.
              
              <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
      
              * editing/deleting/5408255.html: Added.
              * editing/deleting/5408255-expected.checksum: Added.
              * editing/deleting/5408255-expected.png: Added.
              * editing/deleting/5408255-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Tim.
      
              <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for
              the deletion UI.
      
      WebKitTools:
      
              Reviewed by Tim.
              
              <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
      
              * DumpRenderTree/EditingDelegate.m:
              (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
              only for elements with the class needsDeletionUI.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27d51d36
  11. 01 Aug, 2007 1 commit
    • thatcher's avatar
      Reviewed by Justin. · 939e97ec
      thatcher authored
              <rdar://problem/5376156> Mail crash in DeleteButtonController::hide() when dropping selected image on DIV's border
      
              Add the container element back so the selection can not touch the deletion UI nodes. The container
              has style to prevent user selection, user drag and user modification.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show): Make the container node, and append the button and outline elements.
              (WebCore::DeleteButtonController::hide): Remove the container elements and null out the other nodes.
              * editing/DeleteButtonController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      939e97ec
  12. 31 Jul, 2007 1 commit
    • harrison's avatar
      Reviewed by Justin. · e8f3c547
      harrison authored
              <rdar://problem/5362659> CrashTracer: [USER] 11 crashes in Mail at WebCore::InsertLineBreakCommand::doApply()
      
              The problem was that deleting with the X control leaves the selection inside the fragment that was deleted.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              Because the deletion UI only appears when the selection is entirely
              within the target, we unconditionally update the selection to be
              a caret where the target had been.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8f3c547
  13. 25 Jul, 2007 1 commit
    • thatcher's avatar
      Reviewed by Brady. · d20da3f4
      thatcher authored
              <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
      
              Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
              This made the container element redundant, so it has been removed. Now the outline element and the delete button
              both get appended to the target element and positioned based on that container element. This removes the need
              to update the width and height when the target contents changed.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show): Change the style properties and remove the container element.
              (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
              * editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d20da3f4
  14. 16 Nov, 2006 1 commit
  15. 15 Nov, 2006 1 commit
    • thatcher's avatar
      Reviewed by Harrison. · 8faa90ab
      thatcher authored
              <rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
      
              * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
                by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
      
              * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
                the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
      
              * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::DeleteButtonController):
              (WebCore::isDeletableElement):
              (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
              (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
              (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
              (WebCore::DeleteButtonController::deleteTarget): check the enabled state
              * editing/DeleteButtonController.h:
              (WebCore::DeleteButtonController::disable):
              (WebCore::DeleteButtonController::enable):
              (WebCore::DeleteButtonController::enabled):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
              (WebCore::EditCommand::unapply): ditto
              (WebCore::EditCommand::reapply): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8faa90ab
  16. 10 Nov, 2006 1 commit
    • thatcher's avatar
      Reviewed by Adam. · 96cb9c10
      thatcher authored
              <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
      
              Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * rendering/RenderStyle.h:
              (WebCore::BorderValue::isVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96cb9c10
  17. 30 Oct, 2006 2 commits
  18. 27 Oct, 2006 1 commit
    • thatcher's avatar
      Reviewed by Darin. · 0af48ecc
      thatcher authored
              <rdar://problem/4478625> HTML Editing: Basic table editing and culling
      
              Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              (WebCore::enclosingDeletableElement):
              (WebCore::DeleteButtonController::respondToChangedSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0af48ecc
  19. 26 Oct, 2006 1 commit
    • thatcher's avatar
      Reviewed by Adam. · 8e9854be
      thatcher authored
              <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
      
              The main table at nytimes.com has a fixed width of 874px, but the table ends
              up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
              this. The other bug was a missing top and left of 0px on the container element,
              causing the deletion UI to sometimes be offset below the table.
      
              Now check for the element's renderer at the beginning of show() and
              return early if it is null.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::updateOutlineStyle):
              (WebCore::DeleteButtonController::show):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e9854be
  20. 21 Oct, 2006 3 commits
    • darin's avatar
      * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): · ecdbf639
      darin authored
              Oops, edited this before landing it and introduced a null-deref! This fixes it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecdbf639
    • darin's avatar
      Reviewed by Anders. · 22a95f23
      darin authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=11379
                assertion failure seen in editing tests (in new DeleteButtonController)
      
              I cleaned up the relationship between the Frame, Editor, EditorClient, and
              DeleteButtonController a bit while also making the simple change to fix the
              assertion failure.
      
              * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
              * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
      
              * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
              * page/Frame.cpp:
              (WebCore::Frame::Frame): Ditto.
              (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents
              function, and moved it to Editor rather than right on the DeleteButtonController.
              (WebCore::Frame::unappliedEditing): Ditto.
              (WebCore::Frame::reappliedEditing): Ditto.
              * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
      
              * editing/DeleteButtonController.h:
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*.
              The general pattern is that we always use the Frame* as the frame identifier. See FrameTree,
              for example.
              (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection
              function. Includes an additional check for whether the container is contentEditable, which
              was missing from the old version. This prevents the assertion failure. Also added a check that
              the table itself is editable.
              (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper.
              (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary
              selection parameter. No need to pass in the state of the frame since we can get it if we need it.
              (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
      
              * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be
              formatted on multiple lines as usual.
              (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller.
              (WebCore::Editor::respondToChangedContents): Ditto.
              (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
      
              * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being
              defined inline to decouple so that we don't have to include DeleteButtonController.h. That way
              changes to DeleteButtonController.h cause very little to recompile.
      
              * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
              Updated to call the editor instead of the delete button controller for the selection change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a95f23
    • thatcher's avatar
      WebCore: · f780fa7a
      thatcher authored
              Reviewed by Geoff.
      
              <rdar://problem/4478625> HTML Editing: Basic table editing and culling
      
              Initial implementaltion of table deletion user interface:
              * Interface shows up on the nearest table containing the entire selection.
              * Shows a Dashboard style close button in the top left corner.
              * Shows a 60% opaque black outline around the table.
              * Adds a new EditorClient function shouldShowDeleteInterface.
      
              Also adds a new constructor CachedImage and setter functions on
              HTMLImageElement and HTMLImageLoader allowing an Image object to be set
              and image element in the page. This change also paves the way to allow an
              NSImage setter on DOMHTMLImageElement. 
      
              * Resources/deleteButton.tiff: Added.
              * Resources/deleteButtonPressed.tiff: Added.
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/EditorClient.h:
              * editing/DeleteButton.cpp: Added.
              (WebCore::DeleteButton::DeleteButton):
              (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
              * editing/DeleteButton.h: Added.
              * editing/DeleteButtonController.cpp: Added.
              (WebCore::DeleteButtonController::DeleteButtonController):
              (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
              (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
              (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
              (WebCore::DeleteButtonController::show): shows the interface on a new element
              (WebCore::DeleteButtonController::hide): hides the existing interface
              (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
              * editing/DeleteButtonController.h: Added.
              (WebCore::DeleteButtonController::target): getter for the current target
              * editing/Editor.cpp:
              (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
              (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
              (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
              * editing/Editor.h:
              (WebCore::Editor::frame): new getter
              (WebCore::Editor::deleteButtonController): ditto
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
              * html/HTMLImageElement.h:
              (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::setImage): ditto
              * html/HTMLImageLoader.h:
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage): new constructor that takes an Image
              * loader/CachedImage.h: ditto
              * page/Frame.cpp:
              (WebCore::Frame::selectionController): cleanup coding style
              (WebCore::Frame::editor): ditto
              (WebCore::Frame::command): ditto
              (WebCore::Frame::appliedEditing): tell the delete button outline to update
              (WebCore::Frame::unappliedEditing): ditto
              (WebCore::Frame::reappliedEditing): ditto
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
      
      WebKit:
      
              Reviewed by Geoff.
      
              <rdar://problem/4478625> HTML Editing: Basic table editing and culling
      
              Initial implementaltion of table deletion user interface:
              * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
              * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
      
              * DefaultDelegates/WebDefaultEditingDelegate.m:
              (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::WebEditorClient):
              (WebEditorClient::shouldDeleteRange):
              (WebEditorClient::shouldShowDeleteInterface):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebEditingDelegatePrivate.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f780fa7a