1. 05 Apr, 2013 2 commits
  2. 15 Mar, 2013 1 commit
    • anilsson@rim.com's avatar
      [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration... · 5463b8da
      anilsson@rim.com authored
      [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
      https://bugs.webkit.org/show_bug.cgi?id=112467
      
      Reviewed by Rob Buis.
      
      PR 293208
      
      This patch contains contributions from many members of the BlackBerry
      WebKit team:
      
      Mike Lattanzio
      Arvid Nilsson
      Jakob Petsovits
      Konrad Piascik
      Jeff Rogers
      Filip Spacek
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
      (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
      (BlackBerry::WebKit::BackingStorePrivate::tileSize):
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
      * Api/WebOverlay.h:
      * Api/WebOverlayClient.h:
      * Api/WebOverlay_p.h:
      (WebOverlayPrivate):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
      (WebOverlayLayerCompositingThreadClient):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
      (WebOverlayPrivateCompositingThread):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
      * WebKitSupport/BackingStoreTile.cpp:
      (BlackBerry::WebKit::TileBuffer::~TileBuffer):
      (BlackBerry::WebKit::TileBuffer::nativeBuffer):
      (BlackBerry::WebKit::TileBuffer::paintBackground):
      * WebKitSupport/DefaultTapHighlight.cpp:
      (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
      (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
      * WebKitSupport/DefaultTapHighlight.h:
      (DefaultTapHighlight):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.cpp:
      (BlackBerry::WebKit::SelectionOverlay::draw):
      (BlackBerry::WebKit::SelectionOverlay::hide):
      (BlackBerry::WebKit::SelectionOverlay::paintContents):
      (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
      * WebKitSupport/SelectionOverlay.h:
      (SelectionOverlay):
      * WebKitSupport/SurfacePool.cpp:
      (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
      (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
      (BlackBerry::WebKit::SurfacePool::waitForBuffer):
      (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
      (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
      * WebKitSupport/SurfacePool.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5463b8da
  3. 05 Nov, 2012 1 commit
    • simon.fraser@apple.com's avatar
      Fix layer borders to cleaning appear and disappear on switching · e2605d52
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101136
      
      Source/WebCore:
      
      Reviewed by Sam Weinig.
      
      GraphicsLayers decided whether to show layer borders based
      on a callback through the GraphicsLayerClient. This made it
      hard to manage state, resulting in a failure to cleanly
      hide layers when toggled off via the preference.
      
      Changed the layer border and repaint counter visibility to be bits
      stored on GraphicsLayer just like other properties, with getters
      and setters. RenderLayerBacking now updates these debug
      indicators when we update other compositing layer properties.
      
      In GraphicsLayerCA, avoid calling updateDebugIndicators() explicitly
      in several places by setting the change flag DebugIndicatorsChanged
      for properties whose values affect the appearance of the debug border.
      
      Removed the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter() which are no longer required.
      
      * platform/graphics/GraphicsLayer.cpp:
      (WebCore::GraphicsLayer::GraphicsLayer):
      (WebCore::GraphicsLayer::updateDebugIndicators):
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::setShowDebugBorder):
      (WebCore::GraphicsLayer::isShowingDebugBorder):
      (WebCore::GraphicsLayer::setShowRepaintCounter):
      (WebCore::GraphicsLayer::isShowingRepaintCounter):
      (WebCore::GraphicsLayer::repaintCount):
      (WebCore::GraphicsLayer::incrementRepaintCount):
      * platform/graphics/GraphicsLayerClient.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::GraphicsLayerCA):
      (WebCore::GraphicsLayerCA::setMasksToBounds):
      (WebCore::GraphicsLayerCA::setDrawsContent):
      (WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
      (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
      (WebCore::GraphicsLayerCA::updateMasksToBounds):
      (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
      (WebCore::GraphicsLayerCA::updateDebugBorder):
      (WebCore::GraphicsLayerCA::setShowDebugBorder):
      (WebCore::GraphicsLayerCA::setShowRepaintCounter):
      (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
      (WebCore::GraphicsLayerCA::setupContentsLayer):
      (WebCore::GraphicsLayerCA::cloneLayer):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      (WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateDebugIndicators):
      * rendering/RenderLayerBacking.h:
      (RenderLayerBacking):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateBacking):
      * rendering/RenderLayerCompositor.h:
      (RenderLayerCompositor):
      
      Source/WebKit/blackberry:
      
      Reviewed by Sam Weinig.
      
      Remove the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter().
      
      * Api/WebOverlay_p.h:
      (WebOverlayPrivateWebKitThread):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
      * Api/WebPage_p.h:
      * WebKitSupport/DefaultTapHighlight.cpp:
      * WebKitSupport/DefaultTapHighlight.h:
      (DefaultTapHighlight):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.cpp:
      * WebKitSupport/SelectionOverlay.h:
      (SelectionOverlay):
      
      Source/WebKit/chromium:
      
      Reviewed by Sam Weinig.
      
      Remove the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter().
      
      * src/NonCompositedContentHost.cpp:
      * src/NonCompositedContentHost.h:
      (NonCompositedContentHost):
      * src/PageOverlay.cpp:
      * tests/GraphicsLayerChromiumTest.cpp:
      * tests/ImageLayerChromiumTest.cpp:
      
      Source/WebKit/gtk:
      
      Reviewed by Sam Weinig.
      
      Remove the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter().
      
      * WebCoreSupport/AcceleratedCompositingContext.h:
      (AcceleratedCompositingContext):
      * WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
      * WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
      * WebCoreSupport/AcceleratedCompositingContextGL.cpp:
      
      Source/WebKit/win:
      
      Reviewed by Sam Weinig.
      
      Remove the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter().
      
      * WebView.cpp:
      * WebView.h:
      
      Source/WebKit2:
      
      Reviewed by Sam Weinig.
      
      Remove the GraphicsLayerClient methods showDebugBorders() and
      showRepaintCounter().
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
      (LayerTreeCoordinator):
      * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
      * WebProcess/WebPage/ca/LayerTreeHostCA.h:
      (LayerTreeHostCA):
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
      (LayerTreeHostGtk):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      (TiledCoreAnimationDrawingArea):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2605d52
  4. 04 Oct, 2012 1 commit
    • simon.fraser@apple.com's avatar
      Final part of "sync" to "flush" renaming · df44c011
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98430
      
      Reviewed by Tim Horton.
      
      Change method names on GraphicsLayer and GraphicsLayerClient that
      refer to "sync" to use the term "flush" instead, to be consistent
      with the rest of the code.
      
      Source/WebCore:
      
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::flushCompositingState):
      (WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):
      * platform/graphics/GraphicsLayerClient.h:
      (GraphicsLayerClient):
      * platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
      (WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):
      * platform/graphics/blackberry/LayerWebKitThread.cpp:
      (WebCore::LayerWebKitThread::setNeedsCommit):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::flushCompositingState):
      (WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
      (WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
      (WebCore::GraphicsLayerCA::positionForCloneRootLayer):
      (WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
      (WebCore::GraphicsLayerTextureMapper::notifyChange):
      (WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
      (WebCore::GraphicsLayerTextureMapper::flushCompositingState):
      * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
      (GraphicsLayerTextureMapper):
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::flushCompositingState):
      (WebCore::TextureMapperLayer::flushCompositingStateSelf):
      * platform/graphics/texmap/TextureMapperLayer.h:
      (TextureMapperLayer):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::notifyFlushRequired):
      * rendering/RenderLayerBacking.h:
      (RenderLayerBacking):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
      * rendering/RenderLayerCompositor.h:
      (WebCore::RenderLayerCompositor::notifyFlushRequired):
      
      Source/WebKit/blackberry:
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
      * Api/WebOverlay_p.h:
      (WebOverlayPrivateWebKitThread):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebKitSupport/DefaultTapHighlight.cpp:
      (BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
      * WebKitSupport/DefaultTapHighlight.h:
      (DefaultTapHighlight):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      (BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.cpp:
      (BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
      * WebKitSupport/SelectionOverlay.h:
      (SelectionOverlay):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
      (WebCore::AcceleratedCompositingContext::syncLayersNow):
      (WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/AcceleratedCompositingContext.h:
      (AcceleratedCompositingContext):
      * WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
      (WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
      (WebKit::AcceleratedCompositingContext::resizeRootLayer):
      (WebKit::AcceleratedCompositingContext::syncLayersNow):
      (WebKit::AcceleratedCompositingContext::notifyFlushRequired):
      * WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
      (WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
      (WebKit::AcceleratedCompositingContext::notifyFlushRequired):
      * WebCoreSupport/AcceleratedCompositingContextGL.cpp:
      (WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
      (WebKit::AcceleratedCompositingContext::notifyFlushRequired):
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::TextureMapperLayerClientQt::syncRootLayer):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::notifyFlushRequired):
      (WebView::flushPendingGraphicsLayerChanges):
      * WebView.h:
      
      Source/WebKit2:
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
      (WebKit::LayerTreeRenderer::paintToCurrentGLContext):
      (WebKit::LayerTreeRenderer::flushLayerChanges):
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
      (WebKit::LayerTreeRenderer::notifyFlushRequired):
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
      (WebCore::CoordinatedGraphicsLayer::didChangeLayerState):
      (WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
      (WebCore::CoordinatedGraphicsLayer::didChangeChildren):
      (WebCore::CoordinatedGraphicsLayer::didChangeFilters):
      (WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
      (WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
      (WebCore::CoordinatedGraphicsLayer::flushCompositingState):
      (WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
      (CoordinatedGraphicsLayer):
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
      (WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
      (WebKit::LayerTreeCoordinator::notifyFlushRequired):
      * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
      (LayerTreeCoordinator):
      * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
      (WebKit::LayerTreeHostCA::notifyFlushRequired):
      (WebKit::LayerTreeHostCA::flushPendingLayerChanges):
      * WebProcess/WebPage/ca/LayerTreeHostCA.h:
      (LayerTreeHostCA):
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      (WebKit::LayerTreeHostGtk::notifyFlushRequired):
      (WebKit::LayerTreeHostGtk::flushPendingLayerChanges):
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
      (LayerTreeHostGtk):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      (TiledCoreAnimationDrawingArea):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::notifyFlushRequired):
      (WebKit::TiledCoreAnimationDrawingArea::flushLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df44c011
  5. 13 Sep, 2012 1 commit
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport · 8a63f7f1
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96689
      
      Reviewed by Antonio Gomes.
      
      Rename to InspectorClientBlackBerry to avoid include problems.
      
      * WebCoreSupport/InspectorClientBlackBerry.h:
      * WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
      (WebKit):
      (BlackBerry::WebKit::InspectorOverlay::create):
      (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
      (BlackBerry::WebKit::InspectorOverlay::paintContents):
      (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
      (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
      (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::clear):
      (BlackBerry::WebKit::InspectorOverlay::update):
      * WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
      (WebCore):
      (WebKit):
      (InspectorOverlay):
      (InspectorOverlayClient):
      (BlackBerry::WebKit::InspectorOverlay::setClient):
      (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a63f7f1
  6. 07 Aug, 2012 1 commit
    • kpiascik@rim.com's avatar
      [BlackBerry] InspectorOverlay class duplicated in WebCore · 2f3c8d90
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=93124
      
      Reviewed by Rob Buis.
      
      Source/WebKit:
      
      Updated InspectorOverlay build path.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Moved files to better align with namespace names.
      
      * WebKitSupport/InspectorOverlay.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp.
      (WebKit):
      (BlackBerry::WebKit::InspectorOverlay::create):
      (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
      (BlackBerry::WebKit::InspectorOverlay::paintContents):
      (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
      (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
      (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::clear):
      (BlackBerry::WebKit::InspectorOverlay::update):
      * WebKitSupport/InspectorOverlay.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h.
      (WebCore):
      (WebKit):
      (InspectorOverlay):
      (InspectorOverlayClient):
      (BlackBerry::WebKit::InspectorOverlay::setClient):
      (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f3c8d90
  7. 03 Aug, 2012 1 commit
    • kpiascik@rim.com's avatar
      [BlackBerry] InspectorOverlay class duplicated in WebCore · b66c8115
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=93124
      
      Reviewed by Rob Buis.
      
      Changed namespace of InspectorOverlay from WebCore to
      BlackBerry::WebKit
      
      * Api/WebPage.cpp:
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebCoreSupport/InspectorClientBlackBerry.h:
      * WebCoreSupport/InspectorOverlay.cpp:
      (BlackBerry::WebKit::InspectorOverlay::create):
      (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
      (BlackBerry::WebKit::InspectorOverlay::paintContents):
      (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
      (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
      (BlackBerry::WebKit::InspectorOverlay::contentsVisible):
      (BlackBerry::WebKit::InspectorOverlay::update):
      * WebCoreSupport/InspectorOverlay.h:
      (WebKit):
      (InspectorOverlayClient):
      (InspectorOverlay):
      (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b66c8115
  8. 02 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add default implementation of GraphicsLayerClient::contentsVisible() · 1cb72f64
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93036
      
      Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-02
      Reviewed by George Staikos.
      
      Source/WebCore:
      
      Returning true by default would cause memory usage to balloon, because
      the LayerTiler would believe every tile is visible and always needs to
      be rendered. Instead, we choose to return false by default, relying
      entirely on reactive rendering through render jobs.
      
      However this revealed a subtle bug. If the entire layer was invalidated
      every frame, checkerboard would never resolve with this default
      implementation.
      
      Fixed by not clearing render jobs when the entire layer is invalidated,
      thus making us robust against an incomplete contentsVisible
      implementation.
      
      Also removed dead code related to the deprecated
      LayerTiler::m_tilesWebKitThread mechanism, which has been replaced by
      the implicit visibility management resulting from render jobs.
      
      With m_tilesWebKitThread out of the way, rename m_tilesCompositingThread
      to be simply m_tiles.
      
      PR 187458
      
      This is not currently testable using BlackBerry testing infrastructure.
      
      * platform/graphics/GraphicsLayerClient.h:
      (WebCore::GraphicsLayerClient::contentsVisible): Gets a default implementation instead of being pure virtual.
      * platform/graphics/blackberry/LayerTile.cpp:
      (WebCore::LayerTile::LayerTile): Merged LayerTileData into LayerTile now that m_tilesWebKitThread is gone.
      * platform/graphics/blackberry/LayerTile.h:
      (LayerTile):
      * platform/graphics/blackberry/LayerTiler.cpp:
      (WebCore::LayerTiler::~LayerTiler):
      (WebCore::LayerTiler::updateTextureContentsIfNeeded): Bug fix to make us robust against the new default implementation of GraphicsLayerClient::contentsVisible()
      (WebCore::LayerTiler::shouldPerformRenderJob):
      (WebCore::LayerTiler::layerVisibilityChanged):
      (WebCore::LayerTiler::uploadTexturesIfNeeded):
      (WebCore::LayerTiler::drawTexturesInternal):
      (WebCore::LayerTiler::deleteTextures):
      (WebCore::LayerTiler::pruneTextures):
      (WebCore::LayerTiler::bindContentsTexture):
      * platform/graphics/blackberry/LayerTiler.h:
      (LayerTiler):
      
      Source/WebKit/blackberry:
      
      Remove implementation of GraphicsLayerClient::contentsVisible() now
      that it has a default implementation.
      
      This also fixes a bug where memory usage for the inspector highlight
      overlay would balloon because it returned true from contentsVisible()
      which would cause the LayerTiler to populate all tiles. The default
      implementation returns false instead.
      
      PR 187458, 184377
      
      * WebCoreSupport/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::showRepaintCounter):
      * WebCoreSupport/InspectorOverlay.h:
      (InspectorOverlay):
      * WebKitSupport/DefaultTapHighlight.h:
      * WebKitSupport/SelectionOverlay.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cb72f64
  9. 30 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight. · f94b94cd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81001
      
      Source/WebKit:
      
      Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
      Reviewed by Antonio Gomes
      
      Added new InspectorOverlay class
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
      Reviewed by Antonio Gomes.
      
      Implemented InspectorOverlay using WebOverlayAPI.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::renderContents):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
      (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
      (BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
      (WebKit):
      * Api/WebPage_p.h:
      (WebCore):
      (WebPagePrivate):
      * WebCoreSupport/InspectorClientBlackBerry.cpp:
      (WebCore::InspectorClientBlackBerry::highlight):
      (WebCore::InspectorClientBlackBerry::hideHighlight):
      (WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
      (WebCore):
      * WebCoreSupport/InspectorClientBlackBerry.h:
      (InspectorClientBlackBerry):
      * WebCoreSupport/InspectorOverlay.cpp: Added.
      (WebCore):
      (WebCore::InspectorOverlay::create):
      (WebCore::InspectorOverlay::InspectorOverlay):
      (WebCore::InspectorOverlay::notifySyncRequired):
      (WebCore::InspectorOverlay::paintContents):
      (WebCore::InspectorOverlay::showDebugBorders):
      (WebCore::InspectorOverlay::showRepaintCounter):
      (WebCore::InspectorOverlay::contentsVisible):
      (WebCore::InspectorOverlay::~InspectorOverlay):
      (WebCore::InspectorOverlay::clear):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::paintWebFrame):
      (WebCore::InspectorOverlay::invalidateWebFrame):
      * WebCoreSupport/InspectorOverlay.h: Added.
      (WebKit):
      (WebCore):
      (InspectorOverlay):
      (InspectorOverlayClient):
      (WebCore::InspectorOverlay::setClient):
      (WebCore::InspectorOverlay::notifyAnimationStarted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f94b94cd