- 11 Jan, 2011 40 commits
-
-
mihaip@chromium.org authored
Unreviewed; chromium test expectations update. Remove failing expectations for tests that pass after r75515. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
Reviewed by Anders Carlsson and Sam Weinig. * UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): The drawing area is no longer initialized before the WebView is created and the first onSize is receieved. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. commit-queue should know how to upload archived results (for test flakes or general failures) https://bugs.webkit.org/show_bug.cgi?id=52048 I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops. This fixes an exception seen on the commit-queue when attempting to report flaky tests. * Scripts/webkitpy/common/system/workspace.py: * Scripts/webkitpy/common/system/workspace_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Reviewed by Dimitri Glazkov. RefPtr text node in setOuterText since calling appendData on a text node can fire away dom event listener which might remove the text node from underneath. https://bugs.webkit.org/show_bug.cgi?id=52163 Test: fast/dom/text-node-append-data-remove-crash.html * html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText): 2011-01-11 Abhishek Arya <inferno@chromium.org> Reviewed by Dimitri Glazkov. Tests that calling append data on a text node which removes its sibling text node does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=52163 * fast/dom/text-node-append-data-remove-crash-expected.txt: Added. * fast/dom/text-node-append-data-remove-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
Unreviewed; chromium-gpu test expectations update. Remove now-passing tests from text_expectations.txt. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Darin Adler. Microoptimization in ~JSString https://bugs.webkit.org/show_bug.cgi?id=52222 The case where m_fibers is 0 seems to be the most common one (almost 1/2 of the time, followed at some distance by m_fibers = 1 in 1/4 of the cases in a typical SunSpider execution). We can save one comparison in this common case by doing a bit of refactoring in the JSString destructor; overall a 0.3% progression, but only the string tests show improvement. * runtime/JSString.h: (JSC::RopeBuilder::~JSString): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Dan Bernstein. Automatically reinitialize the web page on relaunch https://bugs.webkit.org/show_bug.cgi?id=52224 <rdar://problem/8765695> * UIProcess/API/mac/WKView.mm: (-[WKView _didRelaunchProcess]): Remove call to reinitializeWebPage. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relaunch): Call initializeWebPage(). (WebKit::WebPageProxy::initializeWebPage): Assert that the web page is valid here. * UIProcess/WebPageProxy.h: Remove reinitializeWebPage. * UIProcess/win/WebView.cpp: (WebKit::WebView::didRelaunchProcess): Remove call to reinitializeWebPage. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed; new and updated mac-leopard baselines. Update stale or missing Leopard baselines (tests currently pass on Snow Leopard). * platform/chromium/test_expectations.txt: * platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum: * platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png: * platform/mac-leopard/fast/dom/focus-contenteditable-expected.checksum: Added. * platform/mac-leopard/fast/dom/focus-contenteditable-expected.png: Added. * platform/mac-leopard/fast/forms/fieldset-align-expected.checksum: Added. * platform/mac-leopard/fast/forms/fieldset-align-expected.png: Added. * platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.checksum: Added. * platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png: Added. * platform/mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added. * platform/mac-leopard/fast/text/capitalize-boundaries-expected.png: Added. * platform/mac-leopard/fast/text/softHyphen-expected.checksum: Added. * platform/mac-leopard/fast/text/softHyphen-expected.png: Added. * platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.checksum: * platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ojan@chromium.org authored
Reviewed by Adam Barth. convert back to unified from sidebyside diff https://bugs.webkit.org/show_bug.cgi?id=52180 Remove url fragment stuff. Having it be per-filediff is too complicated. * PrettyPatch/PrettyPatch.rb: * code-review.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Unskipping fast/multicol/span/double-merge-anonymous-block-crash.html. We have been unsuccessful reproducing the crash locally or on the bots. * platform/gtk/Skipped: Unskipping test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. Pass the view size to the DrawingAreaProxy constructor https://bugs.webkit.org/show_bug.cgi?id=52189 * UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewSize): * UIProcess/WebPageProxy.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed. Update .gitignore with new Chromium dependency. ui/ was added with http://crrev.com/70743, we picked that up with a Chromium roll in r75311. Also alphabetizes the dependency list. * .gitignore: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by Geoffrey Garen. ASSERTION Failure in JSC::binaryChop https://bugs.webkit.org/show_bug.cgi?id=25614 Changed JITStubs::cti_register_file_check() to use the current stack's return PC to find the bytecode for handling the exception in the prior frame. Also added the appropriate arrity check routine call to the JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock. * jit/JIT.cpp: (JSC::JIT::privateCompile): Changed the arrity check call location so that it gets added to the m_calls list so that it's included in CodeBlock::m_callReturnIndexVector. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC. 2011-01-11 Michael Saboff <msaboff@apple.com> Reviewed by Geoffrey Garen. ASSERTION Failure in JSC::binaryChop https://bugs.webkit.org/show_bug.cgi?id=25614 Added new test to check for proper handling of stack overflow exceptions and arrity exceptions while close to the top of the stack. * fast/js/script-tests/stack-overflow-arrity-catch.js: Added. (fWithTwoArgs): (test): * fast/js/script-tests/stack-overflow-catch.js: Added. (test): * fast/js/stack-overflow-arrity-catch-expected.txt: Added. * fast/js/stack-overflow-arrity-catch.html: Added. * fast/js/stack-overflow-catch-expected.txt: Added. * fast/js/stack-overflow-catch.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
Unreviewed; new chromium GPU test baselines. These tests required rebaselining after the skia roll in http://src.chromium.org/viewvc/chrome?view=rev&revision=70835. * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum: * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: * platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum: * platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum: * platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: * platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt: * platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum: * platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt: * platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum: * platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: * platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
WebKit2: Roll r75460 back in with build fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. [GTK] Add support for <meter> element https://bugs.webkit.org/show_bug.cgi?id=48713 * platform/gtk/Skipped: * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added. 2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com> Reviewed by Martin Robinson. [GTK] Add support for <meter> element https://bugs.webkit.org/show_bug.cgi?id=48713 * GNUmakefile.am: Enable meter element. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbalazs@webkit.org authored
Reviewed by Andreas Kling. Work towards having the WebPageProxy decide when to create the DrawingAreaProxy https://bugs.webkit.org/show_bug.cgi?id=52184 Qt part made my Balazs Kelemen. * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy]. (WebKit::PageClientImpl::setViewNeedsDisplay): Call setNeedsDisplayInRect on the WKView. * UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore. (-[WKView _createDrawingAreaProxy]): Create a chunked update drawing area proxy for now. * UIProcess/API/qt/qgraphicswkview.cpp: Added a QGraphicsItem* member that is initialized in init to the accociated view. Implement the new functions. This is a temporary solution, in the long term the view and the page should be decoupled. (QGraphicsWKView::QGraphicsWKView): * UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay): * UIProcess/API/qt/qwkpage.h: * UIProcess/API/qt/qwkpage_p.h: * UIProcess/PageClient.h: Add new pure virtual member functions. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy. * UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore. (WebKit::WebView::createDrawingAreaProxy): Create a chunked update drawing area proxy for now. (WebKit::WebView::setViewNeedsDisplay): Invalidate the window. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt][V8] Add missing include for debug build. * loader/cache/CachedResourceLoader.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
Unreviewed; yet another gpu test_expectations update. All glory to the hypnotoad. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: redirects are lost from the network panel upon navigation. https://bugs.webkit.org/show_bug.cgi?id=52210 * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Remove uses of QFuture since it isn't supported on all platforms. https://bugs.webkit.org/show_bug.cgi?id=51204 * platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::localCookiesForUrl): (WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache): * platform/network/qt/QtNAMThreadSafeProxy.h: (WebCore::QtNAMThreadSafeProxy::cookiesForUrl): (WebCore::QtNAMThreadSafeProxy::willLoadFromCache): 2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Remove uses of QFuture since it isn't supported on all platforms. https://bugs.webkit.org/show_bug.cgi?id=51204 * QtTestBrowser/webpage.h: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run): 2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Remove uses of QFuture since it isn't supported on all platforms. https://bugs.webkit.org/show_bug.cgi?id=51204 * tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pvarga@webkit.org authored
Unreviewed. Add myself to committers' list. * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: recreate script view after live edit. https://bugs.webkit.org/show_bug.cgi?id=51751 * inspector/front-end/Script.js: (WebInspector.Script.prototype.set source): * inspector/front-end/ScriptView.js: (WebInspector.ScriptView): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype.viewRecreated): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._doEditLine): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager. https://bugs.webkit.org/show_bug.cgi?id=52205 * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.frameDetachedFromParent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: "Audit present state" always disabled https://bugs.webkit.org/show_bug.cgi?id=52199 Removed all traces of resource tracking checks, as we have it no more. * English.lproj/localizedStrings.js: * inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI): * inspector/front-end/AuditsPanel.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: move delayed search implementation to SourceFrame. https://bugs.webkit.org/show_bug.cgi?id=51753 * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype.cancelFindSearchMatches): * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
[Chromium] Fix bad baselines https://bugs.webkit.org/show_bug.cgi?id=52207 It looks like https://bugs.webkit.org/show_bug.cgi?id=51865 didn't quite get the baselines right. Ran the rebaseline tool to get these. * platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Removed. * platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Removed. * platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: * platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: innerFirstChild has a side effect which should be called explicitly. If a node is a frame's owner then innerFirstChild method subscribes DOMAgent instance to the frame's doc's events. I think this should be done explicitly when we meet with the node for the first time. As I understand it happens in buildArrayForContainerChildren method. https://bugs.webkit.org/show_bug.cgi?id=52204 * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListeningFrameDoc): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerFirstChild): * inspector/InspectorDOMAgent.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
These have been unused since r75262 * platform/graphics/win/WKCACFLayer.cpp: Removed. * platform/graphics/win/WKCACFLayer.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* platform/mac-leopard/fast/js/large-expressions-expected.txt: * platform/win/fast/js/large-expressions-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt] DRT sideeffect revealed by r63657 and r75305 https://bugs.webkit.org/show_bug.cgi?id=42578 After r75305 24 tests fail. Add them to the Skipped list temporarily to make buildbot happy. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: [regression] Cookies view does not allow columns resize. https://bugs.webkit.org/show_bug.cgi?id=51877 * inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by James Robinson. [chromium] canvas.toDataURL("image/jpeg") should composite onto black. https://bugs.webkit.org/show_bug.cgi?id=51237 canvas/philip/tests/toDataURL.jpeg.alpha.html only fails on chromium-mac now, tracked by bug http://webkit.org/b/40147. * platform/chromium/test_expectations.txt: win & linux pass. 2011-01-11 Noel Gordon <noel.gordon@gmail.com> Reviewed by James Robinson. [chromium] canvas.toDataURL("image/jpeg") should composite onto black. https://bugs.webkit.org/show_bug.cgi?id=51237 The Canvas specification requires that the canvas image is composited using the Porter-Duff operator source-over onto a black background; the resultant image should be JPEG encoded and returned as a dataURL. To composite image A and background B, for any Porter-Duff operator, produce pixels I with I = c(A)F(A) + c(B)F(B) where, F(X) is the fraction [0.0-1.0] contributed to the composite by image X, and c(X) are the premultiplied RGB color components of image X. Note by definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB color components of the canvas image to the JPEG encoder. Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html * platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Code cleaning in rendering/mathml/RenderMathMLFraction.cpp https://bugs.webkit.org/show_bug.cgi?id=52201 Replace unneeded doubles by floats and remove unneeded casts. * rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint): * rendering/mathml/RenderMathMLFraction.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Chromium DevTools: get rid of APU-related code in WebKit/chromium. https://bugs.webkit.org/show_bug.cgi?id=52152 * inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setInjectedScriptSource): * inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): * inspector/InspectorState.h: * inspector/front-end/inspector.js: 2011-01-11 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Chromium DevTools: get rid of APU-related code in WebKit/chromium. https://bugs.webkit.org/show_bug.cgi?id=52152 * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): * src/WebDevToolsAgentImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: [REGRESSION] Load timing is requested for all resources (not only for the main one). https://bugs.webkit.org/show_bug.cgi?id=51749 * inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): * loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antonm@chromium.org authored
Remove now unnecessary Chromium overrides. * platform/chromium-mac/fast/regex/malformed-escapes-expected.txt: Removed. * platform/chromium-win/fast/regex/malformed-escapes-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. [Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed. https://bugs.webkit.org/show_bug.cgi?id=51865 * platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.checksum: Added. * platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.png: Added. * platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Added. * platform/chromium-linux/svg/custom/getPresentationAttribute-expected.checksum: Added. * platform/chromium-linux/svg/custom/getPresentationAttribute-expected.png: Added. * platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Added. * platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum: * platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.png: * platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: Added. * platform/chromium-win/svg/custom/getPresentationAttribute-expected.checksum: * platform/chromium-win/svg/custom/getPresentationAttribute-expected.png: * platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-