1. 12 Nov, 2010 40 commits
    • commit-queue@webkit.org's avatar
      2010-11-12 James Simonsen <simonjam@chromium.org> · 6000d4c1
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * fast/dom/Window/window-properties-performance-expected.txt: Class names changed.
      2010-11-12  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * page/Performance.cpp:
              (WebCore::Performance::navigation):
              (WebCore::Performance::timing):
              * page/Performance.h:
              * page/Performance.idl:
              * page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp.
              (WebCore::PerformanceNavigation::PerformanceNavigation):
              (WebCore::PerformanceNavigation::frame):
              (WebCore::PerformanceNavigation::disconnectFrame):
              (WebCore::PerformanceNavigation::type):
              (WebCore::PerformanceNavigation::redirectCount):
              * page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h.
              (WebCore::PerformanceNavigation::create):
              * page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl.
              * page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp.
              (WebCore::toIntegerMilliseconds):
              (WebCore::getPossiblySkewedTimeInKnownRange):
              (WebCore::PerformanceTiming::PerformanceTiming):
              (WebCore::PerformanceTiming::frame):
              (WebCore::PerformanceTiming::disconnectFrame):
              (WebCore::PerformanceTiming::navigationStart):
              (WebCore::PerformanceTiming::unloadEventEnd):
              (WebCore::PerformanceTiming::redirectStart):
              (WebCore::PerformanceTiming::redirectEnd):
              (WebCore::PerformanceTiming::fetchStart):
              (WebCore::PerformanceTiming::domainLookupStart):
              (WebCore::PerformanceTiming::domainLookupEnd):
              (WebCore::PerformanceTiming::connectStart):
              (WebCore::PerformanceTiming::connectEnd):
              (WebCore::PerformanceTiming::requestStart):
              (WebCore::PerformanceTiming::requestEnd):
              (WebCore::PerformanceTiming::responseStart):
              (WebCore::PerformanceTiming::responseEnd):
              (WebCore::PerformanceTiming::domLoading):
              (WebCore::PerformanceTiming::domInteractive):
              (WebCore::PerformanceTiming::domContentLoaded):
              (WebCore::PerformanceTiming::domComplete):
              (WebCore::PerformanceTiming::loadEventStart):
              (WebCore::PerformanceTiming::loadEventEnd):
              (WebCore::PerformanceTiming::documentLoader):
              (WebCore::PerformanceTiming::documentTiming):
              (WebCore::PerformanceTiming::documentLoadTiming):
              (WebCore::PerformanceTiming::resourceLoadTiming):
              (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
              * page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h.
              (WebCore::PerformanceTiming::create):
              * page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl.
      2010-11-12  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * src/WebPerformance.cpp:
              (WebKit::WebPerformance::navigationType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6000d4c1
    • eric.carlson@apple.com's avatar
      2010-11-12 Eric Carlson <eric.carlson@apple.com> · 49dca9dc
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              Remove unused code from HTMLMediaElement
              https://bugs.webkit.org/show_bug.cgi?id=49451
      
              Just removing code, so no new tests.
      
              * html/HTMLMediaElement.cpp: Removed unused functions.
              * html/HTMLMediaElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49dca9dc
    • rniwa@webkit.org's avatar
      2010-11-12 Ryosuke Niwa <rniwa@webkit.org> · c6bbb07e
      rniwa@webkit.org authored
              Unreviewed XCode project fix.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6bbb07e
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · 17fd47d0
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Mark fast/canvas/canvas-arc-360-winding.html as failing on Linux and
              Windows.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17fd47d0
    • ap@apple.com's avatar
      Reviewed by Simon Fraser. · 68e6d6c9
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=49473
      
              No change in behavior, so no tests.
      
              * css/WebKitCSSMatrix.cpp:
              (WebCore::WebKitCSSMatrix::WebKitCSSMatrix): We don't inherit from StyleBase any more, so
              no need to initialize always-null parent.
              (WebCore::WebKitCSSMatrix::setMatrixValue): Since there was never a parent, useStrictParsing()
              just returned true.
      
              * css/WebKitCSSMatrix.h: Just inherit from RefCounted<WebKitCSSMatrix>. Removed unused default
              constructor and copy constructor.
      
              * html/canvas/WebGLRenderingContext.h: Removed an unnneded forward declaration.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68e6d6c9
    • commit-queue@webkit.org's avatar
      2010-11-12 Jacob Dinu <dinu.jacob@nokia.com> · b9e8c2ae
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Update .def file for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=49456
      
              Added missing symbols from revisions r69825, r70470, r71806
      
              * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e8c2ae
    • dglazkov@chromium.org's avatar
      2010-11-12 Dimitri Glazkov <dglazkov@chromium.org> · bf4b434a
      dglazkov@chromium.org authored
              Because of r71945, events from shadow DOM elements now bubble correctly
              unless handled, which trips over the old issue in GTK.
              https://bugs.webkit.org/show_bug.cgi?id=40601
      
              * platform/gtk/Skipped: Added media/controls-right-click-on-timebar.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf4b434a
    • zmo@google.com's avatar
      2010-11-12 Zhenyao Mo <zmo@google.com> · a572a740
      zmo@google.com authored
              Reviewed by James Robinson.
      
              WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
              https://bugs.webkit.org/show_bug.cgi?id=48282
      
              Simple fix for a regression introduced in r71793.
      
              * src/WebGraphicsContext3DDefaultImpl.cpp:
              (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a572a740
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · c6adf9b9
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Fix typo.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6adf9b9
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · 58e939dd
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Mark some more tests as flaky.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58e939dd
    • benjamin.poulain@nokia.com's avatar
      [Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2 · 8a44513b
      benjamin.poulain@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48764
      
      WebKit/qt:
      
      Reviewed by Andreas Kling.
      
      Add the missing error.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
      
      WebKit2:
      
      Reviewed by NOBODY (OOPS!).
      
      Add the missing error to Qt support.
      
      * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
      (WebKit::pluginWillHandleLoadError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a44513b
    • sullivan@apple.com's avatar
      Fixed Target for WKBundlePageOverlay.cpp. · 90aeb31b
      sullivan@apple.com authored
      Reviewed by Anders Carlsson.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Changed Target for WKBundlePageOverlay.cpp from WebProcess to WebKit2.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90aeb31b
    • commit-queue@webkit.org's avatar
      2010-11-12 Helder Correia <helder@sencha.com> · 04f643f4
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Path::addArc() does not set right angle direction on full arcs
              https://bugs.webkit.org/show_bug.cgi?id=49138
      
              New test for nonzero winding rule correctness for full arc paths.
      
              * fast/canvas/canvas-arc-360-winding-expected.txt: Added.
              * fast/canvas/canvas-arc-360-winding.html: Added.
              * fast/canvas/script-tests/canvas-arc-360-winding.js: Added.
      2010-11-12  Helder Correia  <helder@sencha.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] Path::addArc() does not set right angle direction on full arcs
              https://bugs.webkit.org/show_bug.cgi?id=49138
      
              Ensure correctness of nonzero winding rule for full arc paths.
              Invert the sign of the span if the direction is counterclockwise.
      
              Test: fast/canvas/canvas-arc-360-winding.html
      
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04f643f4
    • andersca@apple.com's avatar
      Need a way that WKBundlePageOverlayRef clients can make sure they only... · ed874f08
      andersca@apple.com authored
      Need a way that WKBundlePageOverlayRef clients can make sure they only uninstall the overlay they installed
      https://bugs.webkit.org/show_bug.cgi?id=49461
      <rdar://problem/8662760>
      
      Reviewed by John Sullivan.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageUninstallPageOverlay):
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::findString):
      (WebKit::FindController::hideFindUI):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::uninstallPageOverlay):
      * WebProcess/WebPage/WebPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed874f08
    • dglazkov@chromium.org's avatar
      2010-11-05 Dimitri Glazkov <dglazkov@chromium.org> · 22000f6d
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              Added more test coverage around events crossing shadow DOM boundaries and tweaked existing tests.
      
              * fast/events/shadow-boundary-crossing-2-expected.txt: Added.
              * fast/events/shadow-boundary-crossing-2.html: Added.
              * fast/events/shadow-boundary-crossing.html: Tuned to better reflect its point:
                  the event should indeed fire (it used to be swallowed), but its target
                  should be a non-shadow node.
              * media/audio-delete-while-slider-thumb-clicked.html :  Tweaked to actually click on
                  the scrubber thumb (it was off by 2 pixels).
      2010-11-05  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              Test: fast/events/shadow-boundary-crossing-2.html
      
              This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
              for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
      
              This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
              appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
      
              * Android.mk: Added EventContext, WindowEventContext files.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
              * dom/EventContext.cpp: Added.
              * dom/EventContext.h: Added.
              * dom/Node.cpp:
              (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware.
              (WebCore::Node::createRendererIfNeeded): Ditto.
              (WebCore::Node::parentOrHostNode): Added new helper method.
              (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware.
              (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one.
              (WebCore::Node::getEventAncestors): Renamed and refactored to collect a vector of EventContexts.
              (WebCore::Node::topEventContext): Added.
              (WebCore::eventHasListeners): Changed to use EventContexts.
              (WebCore::Node::dispatchGenericEvent): Ditto.
              * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
                  and changed signature of eventAncestors to use EventContexts.
              * dom/Text.cpp:
              (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
              * dom/WindowEventContext.cpp: Added.
              * dom/WindowEventContext.h: Added.
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Removed event invocation that's
                  no longer necessary.
              * rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent
              is deleted.
              * rendering/TextControlInnerElements.cpp:
              (WebCore::TextControlInnerTextElement::defaultEventHandler): Flipped the condition back
                  from where it was prior to r60418.
              * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
              * svg/SVGElement.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22000f6d
    • commit-queue@webkit.org's avatar
      2010-11-12 Ryuan Choi <ryuan.choi@samsung.com> · 228ba220
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Remove unnecessary header for FontPlatformDataPango.cpp
              https://bugs.webkit.org/show_bug.cgi?id=46029
      
              Remove unnecessary header includes.
              No new tests, as there's no functionality.
      
              * platform/graphics/pango/FontPlatformDataPango.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      228ba220
    • andersca@apple.com's avatar
      Allow MessageSender to override sendMessage · bcdfed81
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49457
      
      Reviewed by Sam Weinig.
      
      Change MessageSender::send to encode the message and then call sendMessage.
      This allows for clients to override sendMessage, something which WebProcessProxy
      will be able to take advantage of.
      
      * Platform/CoreIPC/MessageSender.h:
      (CoreIPC::MessageSender::send):
      (CoreIPC::MessageSender::sendMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcdfed81
    • andersca@apple.com's avatar
      CoreIPC cleanup · b6ba463e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49455
      
      Reviewed by Sam Weinig.
      
      Add a static create function to ArgumentEncoder.
      Factor sync message argument encoder creation out into a new function,
      createSyncMessageArgumentEncoder.
      
      * Platform/CoreIPC/ArgumentEncoder.cpp:
      (CoreIPC::ArgumentEncoder::create):
      * Platform/CoreIPC/ArgumentEncoder.h:
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::createSyncMessageArgumentEncoder):
      (CoreIPC::Connection::dispatchSyncMessage):
      * Platform/CoreIPC/Connection.h:
      (CoreIPC::Connection::send):
      (CoreIPC::Connection::sendSync):
      * UIProcess/WebProcessProxy.h:
      (WebKit::WebProcessProxy::send):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6ba463e
    • weinig@apple.com's avatar
      ASSERTION when converting some WKStringRefs returned from willSubmitForm to CFStringRef · fbd2b6bb
      weinig@apple.com authored
      <rdar://problem/8662180>
      https://bugs.webkit.org/show_bug.cgi?id=49454
      
      Reviewed by Anders Carlsson.
      
      Enforce the invariant that a WebString never contains a null WTF::String at a
      lower level, in the WebString constructor, instead of relying on the callers of
      WebString::create to do it.
      
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toAPI):
      (WebKit::toCopiedAPI): Remove null string check...
      
      * Shared/WebString.h:
      (WebKit::WebString::WebString): ... and move it to the constructor.
      
      * Shared/API/c/WKURL.cpp:
      (WKURLCopyString): Use toCopiedAPI() instead of calling WebString directly
      to match other similar uses.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbd2b6bb
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · bc773167
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Mark http/tests/media/video-cookie.html as flaky.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc773167
    • tony@chromium.org's avatar
      2010-11-12 Tony Chang <tony@chromium.org> · 3f0b97c1
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] Load a blank page when closing DRT WebViewHosts
              https://bugs.webkit.org/show_bug.cgi?id=49417
      
              * platform/chromium/drt_expectations.txt: Fix 2 tests in DRT.
      2010-11-12  Tony Chang  <tony@chromium.org>
      
              Reviewed by Kent Tamura.
      
              [chromium] Load a blank page when closing DRT WebViewHosts
              https://bugs.webkit.org/show_bug.cgi?id=49417
      
              In test_shell, when we close a window, we first load about:blank
              and run GC to fire the destruction logic of the page.  In test_shell,
              this happens in ~TestShell.  In DRT, we manage virtual windows as
              WebViewHosts, so we need to replicate this logic in ~WebViewHost.
      
              Managing focus is a bit trickier, since normally you would get window
              events to reset the focus to the right window.  We do it manually
              instead.
      
              This fixes 2 plugin tests on DRT.
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::~TestShell): Move window close logic to ~WebViewHost.
              (TestShell::closeWindow): Move widget close() to WVH destructor and
                  manage focus manually.
              (TestShell::closeRemainingWindows): Comment typo.
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::closeWidget):
              (invokeCloseWidget):
              (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
                  test_shell).
              (WebViewHost::~WebViewHost):
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f0b97c1
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · dd491022
      mihaip@chromium.org authored
              Unreviewed Chromium rebaseline.
      
              Accumulated rebaselines that were missed due to lots of tests having
              expected failures because of bug 48634.
      
              * platform/chromium-linux/fast/css/input-search-padding-expected.checksum: Added.
              * platform/chromium-linux/fast/css/input-search-padding-expected.png: Added.
              * platform/chromium-linux/fast/css/input-search-padding-expected.txt: Added.
              * platform/chromium-mac/fast/css/input-search-padding-expected.checksum: Added.
              * platform/chromium-mac/fast/css/input-search-padding-expected.png: Added.
              * platform/chromium-mac/fast/lists/markers-in-selection-expected.checksum: Added.
              * platform/chromium-mac/fast/lists/markers-in-selection-expected.png:
              * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
              * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
              * platform/chromium-win/fast/css/input-search-padding-expected.checksum: Added.
              * platform/chromium-win/fast/css/input-search-padding-expected.png: Added.
              * platform/chromium-win/fast/css/input-search-padding-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd491022
    • levin@chromium.org's avatar
      cpp.py needs some tidying. · 5cd928a2
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49443
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
        Fix parameter ordering for iteratively_replace_matches_with_char
        to mirror other similar functions (and improved comments, etc.)
        Also, use a python-ism (for/else) to get rid of a variable that
        was there to determine if something had been found in the loop.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cd928a2
    • inferno@chromium.org's avatar
      2010-11-11 Abhishek Arya <inferno@chromium.org> · 1d255ef5
      inferno@chromium.org authored
              Reviewed by Adam Barth.
      
              Not allow drag and drop across different origins.
              https://bugs.webkit.org/show_bug.cgi?id=49098
      
              Test: http/tests/security/drag-drop-different-origin.html
      
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canDropOnTarget):
              * page/SecurityOrigin.h:
      2010-11-10  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Check that drag and drop is not allowed across different origins.
              https://bugs.webkit.org/show_bug.cgi?id=49098
        
              * http/tests/security/drag-drop-different-origin-expected.txt: Added.
              * http/tests/security/drag-drop-different-origin.html: Added.
              * http/tests/security/resources/drag-drop.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d255ef5
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · 9d1e661e
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Now that we know better what is causing bug bug 48634, we can just
              skip fast/images/size-failure.html instead of the 100+ tests that follow
              it.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d1e661e
    • andersca@apple.com's avatar
      CString(const char*) crashes when passed a null pointer · 7260e540
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49450
      
      Reviewed by Adam Roben.
      
      * wtf/text/CString.cpp:
      (WTF::CString::CString):
      Return early if str is null.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7260e540
    • apavlov@chromium.org's avatar
      2010-11-11 Alexander Pavlov <apavlov@chromium.org> · e97e7f18
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Inspect element tooltip obscures element metrics
              https://bugs.webkit.org/show_bug.cgi?id=47822
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::drawNodeHighlight):
              (WebCore::InspectorController::drawElementTitle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e97e7f18
    • commit-queue@webkit.org's avatar
      2010-11-12 Robert Kroeger <rjkroege@chromium.org> · 8030893d
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              [Chromium/DRT] Make EventSendingController send complete touch events.
              https://bugs.webkit.org/show_bug.cgi?id=49285
      
              * DumpRenderTree/chromium/EventSender.cpp:
              (EventSender::addTouchPoint):
              (EventSender::updateTouchPoint):
              (EventSender::sendCurrentTouchEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8030893d
    • commit-queue@webkit.org's avatar
      2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org> · d9e0c060
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Button's background style from default Qt Mobile Theme  is overriding facebook's button style
              https://bugs.webkit.org/show_bug.cgi?id=48198
      
              Instead of creating gradients that goes from white to grey and cover the whole element the gradients
              are created by varying the alpha channel of a dark color. This way the effect will not override the
              background color of the elements.
      
              * css/themeQtMobile.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9e0c060
    • andreas.kling@nokia.com's avatar
      2010-11-12 Andreas Kling <kling@webkit.org> · 16f8d430
      andreas.kling@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt][WK2] Fix leaking of mapped files
      
              MappedMemory::fileName was never set on the receiving side, which led
              the MappedMemoryPool to call QFile::map() again when reusing an existing file.
      
              * Platform/qt/MappedMemoryPool.cpp:
              (WebKit::MappedMemoryPool::mapFile):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16f8d430
    • jschuh@chromium.org's avatar
      2010-11-12 Justin Schuh <jschuh@chromium.org> · 7d96bb5f
      jschuh@chromium.org authored
              Reviewed by Adam Barth.
      
              Use a RefPtr inside ContainerNode::willRemove loop
              https://bugs.webkit.org/show_bug.cgi?id=49237
      
              Test: fast/innerHTML/innerHTML-iframe.html
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::willRemove):
      2010-11-12  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Use a RefPtr inside ContainerNode::willRemove loop
              https://bugs.webkit.org/show_bug.cgi?id=49237
      
              * fast/innerHTML/innerHTML-iframe-expected.txt: Added.
              * fast/innerHTML/innerHTML-iframe.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d96bb5f
    • yurys@chromium.org's avatar
      2010-11-12 Pavel Feldman <pfeldman@chromium.org> · cce62745
      yurys@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
              https://bugs.webkit.org/show_bug.cgi?id=49130
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype.debuggerPaused):
              (WebInspector.Breakpoint.jsBreakpointId):
              (WebInspector.Breakpoint.prototype.get id):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.EventListenerBreakpointsSidebarPane):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype._breakpointHit): don't call populateStatusMessage for JS breakpoints
              since there is no specific message in that case.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/inspector.css:
              (#elements-sidebar):
              (.pane > .body):
              (#scripts-sidebar):
              (li.breakpoint-hit .breakpoint-hit-marker):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cce62745
    • mihaip@chromium.org's avatar
      2010-11-12 Mihai Parparita <mihaip@chromium.org> · 45bf5abe
      mihaip@chromium.org authored
              Unreviewed rollout of r71858.
      
              Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
              NaCl tests.
      
              * Scripts/webkitpy/layout_tests/port/config.py:
              * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
              * Scripts/webkitpy/layout_tests/port/config_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45bf5abe
    • yael.aharon@nokia.com's avatar
      2010-11-12 Yael Aharon <yael.aharon@nokia.com> · b7355ab8
      yael.aharon@nokia.com authored
              Reviewed by Antonio Gomes.
      
              Spatial Navigation: Need better way to control size of content in tests.
              https://bugs.webkit.org/show_bug.cgi?id=49398
      
              Add an image and use it in a layout test to define fixed size for all ports.
              This also fixes https://bugs.webkit.org/show_bug.cgi?id=43030
      
              * fast/events/spatial-navigation/resources/green.png: Added.
              * fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
              * fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7355ab8
    • aroben@apple.com's avatar
      Skip a timing-out test on Windows XP · b6a11a75
      aroben@apple.com authored
      * platform/win-xp/Skipped: Added. Skip
      fast/workers/storage/change-version-handle-reuse-worker.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a11a75
    • aroben@apple.com's avatar
      Land new Windows results for tests added in r71851 · 2143d354
      aroben@apple.com authored
      * platform/win/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
      * platform/win/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
      * platform/win/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
      * platform/win/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
      * platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
      * platform/win/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2143d354
    • bulach@chromium.org's avatar
      2010-11-12 Marcus Bulach <bulach@chromium.org> · 889684bc
      bulach@chromium.org authored
              Not reviewed, Chromium test expectation update.
      
              Update chromium baselines for svg following r71908 (missed mac in r71910).
              https://bugs.webkit.org/show_bug.cgi?id=49447
      
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      889684bc
    • caseq@chromium.org's avatar
      2010-11-12 Andrey Kosyakov <caseq@chromium.org> · b21bdca9
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
              Adjusting the order of properties in API interfaces dumps in the expectations.
              https://bugs.webkit.org/show_bug.cgi?id=49441
      
              * inspector/extensions-api-expected.txt:
              * inspector/extensions-audits-api-expected.txt:
              * inspector/extensions-expected.txt:
      2010-11-12  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
              https://bugs.webkit.org/show_bug.cgi?id=49441
      
              * inspector/front-end/ExtensionAPI.js:
              (WebInspector.injectedExtensionAPI.PanelImpl):
              (WebInspector.injectedExtensionAPI):
              (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPane):
              (WebInspector.injectedExtensionAPI.AuditCategoryImpl):
              (WebInspector.injectedExtensionAPI.AuditResultImpl):
              (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity):
              (WebInspector.injectedExtensionAPI.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b21bdca9
    • bulach@chromium.org's avatar
      2010-11-12 Marcus Bulach <bulach@chromium.org> · c937ccce
      bulach@chromium.org authored
              Not reviewed, Chromium test expectation update.
      
              Update chromium baselines for svg following r71908
              https://bugs.webkit.org/show_bug.cgi?id=49440
      
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
              * platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c937ccce
    • aroben@apple.com's avatar
      Windows build fix · 76922618
      aroben@apple.com authored
      * win/WebKit2Generated.make: Copy WKBundlePageOverlay.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76922618