Commits · 5fbf1940df6b056dc26c57dd4054a09c6319a88a · App_Technologies / webkit

06 Jun, 2011 1 commit

2011-06-06 Shishir Agrawal <shishir@chromium.org> · 5fbf1940

commit-queue@webkit.org authored Jun 06, 2011

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * fast/events/page-visibility-transition-test-expected.txt:
        * fast/events/page-visibility-transition-test.html:
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * page/PageVisibilityState.cpp:
        (WebCore::pageVisibilityStateString):
        * page/PageVisibilityState.h:
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * public/WebPageVisibilityState.h:
        * src/AssertMatchingEnums.cpp:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setVisibilityState):
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setPageVisibility):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5fbf1940

09 May, 2011 2 commits

2011-05-09 Tony Gentilcore <tonyg@chromium.org> · 245b8649

tonyg@chromium.org authored May 09, 2011

        Reviewed by Darin Adler.

        Style fix: Function names must begin with lowercase letter and should not use "get".
        https://bugs.webkit.org/show_bug.cgi?id=60475

        * dom/Document.cpp:
        (WebCore::Document::webkitVisibilityState):
        * page/PageVisibilityState.cpp:
        (WebCore::pageVisibilityStateString): Renamed.
        * page/PageVisibilityState.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

245b8649

2011-05-09 Shishir Agrawal <shishir@chromium.org> · 084ff96e

commit-queue@webkit.org authored May 09, 2011

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * fast/events/page-visibility-iframe-delete-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-delete-test.html: Added.
        * fast/events/page-visibility-iframe-move-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-move-test.html: Added.
        * fast/events/page-visibility-iframe-propagation-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-propagation-test.html: Added.
        * fast/events/page-visibility-transition-test-expected.txt: Added.
        * fast/events/page-visibility-transition-test.html: Added.
        * fast/events/resources/page-visibility-iframe-delete-test-frame.html: Added.
        * fast/events/resources/page-visibility-iframe-move-new-page.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        Tests: fast/events/page-visibility-iframe-delete-test.html
               fast/events/page-visibility-iframe-move-test.html
               fast/events/page-visibility-iframe-propagation-test.html
               fast/events/page-visibility-transition-test.html

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::visibilityState):
        (WebCore::Document::webkitVisibilityState):
        (WebCore::Document::webkitIsVisible):
        (WebCore::Document::dispatchVisibilityStateChangeEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/EventNames.h:
        * page/Frame.cpp:
        (WebCore::Frame::dispatchVisibilityStateChangeEvent):
        * page/Frame.h:
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::setVisibilityState):
        (WebCore::Page::visibilityState):
        * page/Page.h:
        * page/PageVisibilityState.cpp: Added.
        (WebCore::GetPageVisibilityStateString):
        * page/PageVisibilityState.h: Added.
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * WebKit.gyp:
        * public/WebPageVisibilityState.h: Added.
        * public/WebView.h:
        (WebKit::WebView::setVisibilityState):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::visibilityState):
        * src/AssertMatchingEnums.cpp:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::setVisibilityState):
        * src/WebViewImpl.h:
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * DumpRenderTree/LayoutTestController.cpp:
        (setPageVisibilityCallback):
        (resetPageVisibilityCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::setPageVisibility):
        (LayoutTestController::resetPageVisibility):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::resetPageVisibility):
        (LayoutTestController::setPageVisibility):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

084ff96e

13 Apr, 2011 1 commit

2011-04-13 Kinuko Yasuda <kinuko@chromium.org> · 9e826054

kinuko@chromium.org authored Apr 13, 2011

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
https://bugs.webkit.org/show_bug.cgi?id=57927

Added plumbing code for the quota API, that is based on the
discussion on public-webapps:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

* WebKit.gyp: Added new file entries.
* src/StorageInfoChromium.cpp: Added.
* src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of
WebStorageQuotaCallbacks.
* src/WebStorageQuotaCallbacksImpl.h: Added.
2011-04-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
https://bugs.webkit.org/show_bug.cgi?id=57927

Added mock implementation and some plumbing code for the quota API,
that is based on the discussion on public-webapps:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

No new tests: tests will be added when we expose the API.

* CMakeLists.txt: Added new file entries.
* DerivedSources.cpp: Added new file entries.
* DerivedSources.make: Added new file entries.
* GNUmakefile.am: Added new file entries.
* WebCore.gypi: Added new file entries.
* WebCore.pro: Added new file entries.
* WebCore.vcproj/WebCore.vcproj: Added new file entries.
* WebCore.xcodeproj/project.pbxproj: Added new file entries.
* storage/StorageInfo.cpp: Added.
* storage/StorageInfo.h: Added.
* storage/StorageInfoErrorCallback.h: Added.
* storage/StorageInfoQuotaCallback.h: Added.
* storage/StorageInfoUsageCallback.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9e826054

16 Mar, 2011 1 commit

2011-03-16 Mikhail Naganov <mnaganov@chromium.org> · 82aef340

mnaganov@chromium.org authored Mar 16, 2011

        Reviewed by Pavel Feldman.

        [Chromium] Report object groups and single DOM-related objects
        to the new heap profiler.
        https://bugs.webkit.org/show_bug.cgi?id=53659

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * WebCore.pro:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/RetainedDOMInfo.cpp: Added.
        (WebCore::RetainedDOMInfo::RetainedDOMInfo):
        * bindings/v8/RetainedDOMInfo.h: Added.
        * bindings/v8/RetainedObjectInfo.h: Added.
        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::retainedDOMInfo):
        (WebCore::ScriptProfiler::initialize):
        * bindings/v8/ScriptProfiler.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        * bindings/v8/V8GCController.cpp:
        (WebCore::GroupId::GrouperItem::GrouperItem):
        (WebCore::GroupId::GrouperItem::groupId):
        (WebCore::GroupId::GrouperItem::createRetainedObjectInfo):
        (WebCore::calculateGroupId):
        (WebCore::GrouperVisitor::visitDOMWrapper):
        (WebCore::GrouperVisitor::applyGrouping):
        * bindings/v8/WrapperTypeInfo.h:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotConstructorNode):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDiffNode):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
        (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot):
        (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotNode.prototype.get className):
        (WebInspector.HeapSnapshot.prototype._buildAggregates):
        (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
        (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
        * inspector/front-end/heapProfiler.css:
        (.detailed-heapshot-view .retaining-paths-view .title > span):
        (.detailed-heapshot-view .retaining-paths-to-windows):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

82aef340

07 Mar, 2011 1 commit

2011-03-07 Daniel Cheng <dcheng@chromium.org> · d3fc3e91

dcheng@chromium.org authored Mar 08, 2011

        Reviewed by David Levin.

        Add support for DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=55115

        Layout test to verify that the basic properties of dataTransfer.items function as expected.

        * editing/pasteboard/data-transfer-items-expected.txt: Added.
        * editing/pasteboard/data-transfer-items.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-07  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add support for DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=55115

        This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
        basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
        all functionality on the DataTransferItems collection has been implemented.
        This change does not actually hook up DataTransferItems to reflect the actual contents of a
        drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
        enabled via several followup patches.

        Test: editing/pasteboard/data-transfer-items.html

        * Android.mk:
        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
        (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
        * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
        * dom/Clipboard.h:
        (WebCore::Clipboard::policy):
        * dom/Clipboard.idl:
        * dom/DataTransferItem.cpp: Added.
        * dom/DataTransferItem.h: Added.
        (WebCore::DataTransferItem::~DataTransferItem):
        * dom/DataTransferItem.idl: Added.
        * dom/DataTransferItems.h: Added.
        (WebCore::DataTransferItems::~DataTransferItems):
        * dom/DataTransferItems.idl: Added.
        * dom/StringCallback.cpp: Added.
        (WebCore::StringCallback::scheduleCallback):
        * dom/StringCallback.h: Added.
        (WebCore::StringCallback::~StringCallback):
        * dom/StringCallback.idl: Added.
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::items):
        * platform/chromium/ClipboardChromium.h:
        * platform/chromium/DataTransferItemChromium.cpp: Added.
        (WebCore::DataTransferItemChromium::create):
        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
        (WebCore::DataTransferItemChromium::kind):
        (WebCore::DataTransferItemChromium::type):
        (WebCore::DataTransferItemChromium::getAsString):
        * platform/chromium/DataTransferItemChromium.h: Added.
        * platform/chromium/DataTransferItemsChromium.cpp: Added.
        (WebCore::DataTransferItemsChromium::create):
        (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
        (WebCore::DataTransferItemsChromium::length):
        (WebCore::DataTransferItemsChromium::item):
        (WebCore::DataTransferItemsChromium::deleteItem):
        (WebCore::DataTransferItemsChromium::clear):
        (WebCore::DataTransferItemsChromium::add):
        * platform/chromium/DataTransferItemsChromium.h: Added.
2011-03-07  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add support for DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=55115

        Add new runtime enabled flag for data transfer items feature.

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableDataTransferItems):
        (WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):
2011-03-07  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by David Levin.

        Add support for DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=55115

        Enable data transfer items in DRT.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d3fc3e91

03 Feb, 2011 1 commit

2011-02-03 Mikhail Naganov <mnaganov@chromium.org> · 1ef122a5

mnaganov@chromium.org authored Feb 03, 2011

        Reviewed by Pavel Feldman.

        Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
        https://bugs.webkit.org/show_bug.cgi?id=53592

        In JSC there is no limit, thus 'undefined' value is returned.
        For V8, the limit reported by the VM is returned.

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSMemoryInfoCustom.cpp: Added.
        * bindings/js/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/js/ScriptGCEvent.h:
        * bindings/v8/ScriptGCEvent.cpp:
        (WebCore::ScriptGCEvent::getHeapSize):
        * bindings/v8/ScriptGCEvent.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
        * page/MemoryInfo.cpp:
        (WebCore::MemoryInfo::MemoryInfo):
        * page/MemoryInfo.h:
        (WebCore::MemoryInfo::jsHeapSizeLimit):
        * page/MemoryInfo.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1ef122a5

08 Jan, 2011 1 commit

Move WebCore into Source · 1f839a2d

abarth@webkit.org authored Jan 08, 2011

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1f839a2d

01 Oct, 2009 1 commit

2009-10-01 Vitaly Repeshko <vitalyr@chromium.org> · 76d2a71c

eric@webkit.org authored Oct 01, 2009

        Reviewed by Dimitri Glazkov.

        [V8] Refactored V8 event listeners:
        (This change should fix http://crbug.com/21079 and
        https://bugs.webkit.org/show_bug.cgi?id=29093.)
         o All listeners use weak handles to JS objects to avoid creating
           cycles and leaking memory.
         o "Object" variants of listeners removed.
         o All event accessor callbacks are generated.
         o Custom event accessors removed.
         o All wrappers have hidden dependencies on their listeners to
           prevent listeners from being collected.
         o All variats of getEventListener function grouped in V8DOMWrapper.
         o Pointers to C++ EventListener wrappers are stored in JS objects
           instead of event listener lists.
        https://bugs.webkit.org/show_bug.cgi?id=29825

        * WebCore.gypi: Removed "Object" listeners.
        * bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
        * bindings/v8/DOMObjectsInclude.h:

        V8AbstractEventListener manages weak JS handle:
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::weakEventListenerCallback):
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::handleEvent):
        (WebCore::V8AbstractEventListener::disposeListenerObject):
        (WebCore::V8AbstractEventListener::setListenerObject):
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::cast):
        (WebCore::V8AbstractEventListener::isLazy):
        (WebCore::V8AbstractEventListener::getListenerObject):
        (WebCore::V8AbstractEventListener::getExistingListenerObject):
        (WebCore::V8AbstractEventListener::hasExistingListenerObject):
        (WebCore::V8AbstractEventListener::disconnectFrame):
        (WebCore::V8AbstractEventListener::disconnected):
        (WebCore::V8AbstractEventListener::prepareListenerObject):
        (WebCore::V8AbstractEventListener::lineNumber):
        (WebCore::V8AbstractEventListener::virtualisAttribute):

        Grouped getEventListener functions:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::getEventListener):
        * bindings/v8/V8DOMWrapper.h:

        Removed most event listener objects bookkeeping:
        * bindings/v8/V8EventListenerList.cpp:
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findWrapper):
        (WebCore::V8EventListenerList::clearWrapper):
        (WebCore::V8EventListenerList::doFindWrapper):
        (WebCore::V8EventListenerList::getHiddenProperty):
        (WebCore::V8EventListenerList::findOrCreateWrapper):

        Added hidden properties for storing EventListener wrappers:
        * bindings/v8/V8HiddenPropertyName.cpp:
        (WebCore::V8HiddenPropertyName::listener):
        (WebCore::V8HiddenPropertyName::attributeListener):
        * bindings/v8/V8HiddenPropertyName.h:

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        (WebCore::V8LazyEventListener::callListenerFunction):
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::isLazy):
        * bindings/v8/V8ObjectEventListener.cpp: Removed.
        * bindings/v8/V8ObjectEventListener.h: Removed.
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::disconnectFrame):
        (WebCore::V8Proxy::disconnectEventListeners):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::reportError):
        (WebCore::V8WorkerContextEventListener::getReceiverObject):
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
        * bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        (WebCore::V8EventListener::getListenerFunction):
        (WebCore::V8EventListener::callListenerFunction):
        * bindings/v8/custom/V8CustomEventListener.h:
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

76d2a71c

18 Jul, 2009 1 commit

2009-07-18 Adam Barth <abarth@webkit.org> · 93b96c98

abarth@webkit.org authored Jul 18, 2009

        Reviewed by Darin Fisher.

        [V8] Move event listener methods from V8Proxy to V8EventListenerList
        https://bugs.webkit.org/show_bug.cgi?id=27408

        Move some event listener code out of V8Proxy and into the event
        listener list.

        I'd like to remove these methods from V8Proxy entirely and just expose
        getters for the lists themselves, but I'll do that in a follow up
        patch.

        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::findWrapper):
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findOrCreateWrapper):
        * bindings/v8/V8ObjectEventListener.cpp:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::findV8EventListener):
        (WebCore::V8Proxy::findOrCreateV8EventListener):
        (WebCore::V8Proxy::removeV8EventListener):
        (WebCore::V8Proxy::findObjectEventListener):
        (WebCore::V8Proxy::findOrCreateObjectEventListener):
        (WebCore::V8Proxy::removeObjectEventListener):
        * bindings/v8/V8Proxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

93b96c98

07 May, 2009 1 commit

2009-05-07 Antony Sargent <asargent@chromium.org> · fdc093dd

darin@chromium.org authored May 07, 2009

        Reviewed by Darin Fisher.

        Fix a memory leak in V8EventListenerList::remove.

        https://bugs.webkit.org/show_bug.cgi?id=25618

        No new functionality so no new tests. 

        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::remove):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fdc093dd

05 May, 2009 1 commit

2009-05-05 Antony Sargent <asargent@chromium.org> · d0382629

eric@webkit.org authored May 06, 2009

        Reviewed by Dimitri Glazkov.

        Switch V8EventListenerList to use HashTable<T>.
        https://bugs.webkit.org/show_bug.cgi?id=25496

        This avoids some tricky issues with event listener removal in the
        current implementation and has slightly better performance.

        No new functionality so no new tests.

        * bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::size):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d0382629

24 Apr, 2009 1 commit

2009-04-24 David Levin <levin@chromium.org> · 7b221adc

levin@chromium.org authored Apr 24, 2009

        Reviewed by NOBODY (chromium build fix).

        Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::add):
        (WebCore::V8EventListenerList::remove):
        (WebCore::V8EventListenerList::clear):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::virtualisAttribute):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):
        (WebCore::V8EventListener::virtualisAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7b221adc

14 Apr, 2009 1 commit

2009-04-14 Antony Sargent <asargent@chromium.org> · 410bb05a

dimich@chromium.org authored Apr 14, 2009

        Reviewed by Dimitri Glazkov.

        This is some cleanup motivated by the crash in http://crbug.com/9775 , which
        happens because of calling window.open inside a window.onload handler.

        These changes are just part of the fix, along with some asserts to help prevent
        breakage on future changes.

        https://bugs.webkit.org/show_bug.cgi?id=25132

        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::add):
        (WebCore::V8EventListenerList::remove):
        (WebCore::V8EventListenerList::clear):
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::size):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

410bb05a

02 Apr, 2009 1 commit

2009-04-02 Jian Li <jianli@chromium.org> · 3b05e5ff

dimich@chromium.org authored Apr 02, 2009

        Reviewed by Darin Fisher.

        Upstream V8EventListenerList for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25004

        * bindings/v8/V8EventListenerList.cpp: Added.
        * bindings/v8/V8EventListenerList.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3b05e5ff