1. 30 Dec, 2010 22 commits
    • mihaip@chromium.org's avatar
      2010-12-30 Mihai Parparita <mihaip@chromium.org> · 5f1b7d22
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Mark a few inspector tests as slow, they occasionally time out with
              debug builds.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f1b7d22
    • jschuh@chromium.org's avatar
      2010-12-30 Justin Schuh <jschuh@chromium.org> · 98296bbc
      jschuh@chromium.org authored
              Unreviewed.
      
              chromium test expectations after r74788 for svg/dom/length-list-parser.html
      
              * platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98296bbc
    • paroga@webkit.org's avatar
      2010-12-30 Patrick Gansterer <paroga@webkit.org> · c8ddfc6c
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
              https://bugs.webkit.org/show_bug.cgi?id=51743
      
              Most of the ifdefs belong to windows and not to the MSVC compiler.
      
              * wtf/FastMalloc.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ddfc6c
    • yael.aharon@nokia.com's avatar
      REGRESSION: fast/dom/cssTarget-crash.html fails · 79f6905c
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=20342
      
      Reviewed by Adam Barth.
      
      WebCore: 
      
      Do not reload the page when submitting a form, using "GET" method, and the
      form action url matches the location url, except for the fragment.
            
      Test: fast/forms/submit-change-fragment.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::shouldScrollToAnchor):
      * loader/FrameLoader.h:
      
      LayoutTests: 
      
      * fast/forms/submit-change-fragment-expected.txt: Added.
      * fast/forms/submit-change-fragment.html: Added.
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f6905c
    • darin@apple.com's avatar
      2010-12-30 Darin Adler <darin@apple.com> · 7fa6b382
      darin@apple.com authored
              Reviewed by Adam Barth.
      
              Move security logic out of the JavaScript binding for location into the DOM class
              https://bugs.webkit.org/show_bug.cgi?id=51714
      
              * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
              and JSBinding.h. Later, we'll remove them from other project files and delete
              the source files.
      
              * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
      
              * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
              function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
              function, unused toLexicalFrame function, unused completeURL function, unused
              getCachedDOMStructure and cacheDOMStructure overloads, and unused
              getCachedDOMConstructor and cacheDOMConstruction functions.
              (WebCore::activeDOMWindow): Added.
              (WebCore::firstDOMWindow): Added.
              (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
              JSBindingState, since the latter is an unneeded abstraction.
              (WebCore::processingUserGesture): Changed to call ScriptController's function
              rather than calling through JSBindingState, which is an unneeded abstraction
      
              * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
              activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
              named allowsAccessFromFrame functions, which answer the question of whether
              script is allowed access *to* a frame.
      
              * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
              (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
              activeDOMWindow and firstDOMWindow functions.
              (WebCore::JSDOMWindow::open): Ditto.
              (WebCore::JSDOMWindow::showModalDialog): Ditto.
              (WebCore::JSDOMWindow::postMessage): Ditto.
      
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
              to the Location::setHref function, with it doing the rest of the work. This moves
              work out of the DOM binding that belongs in the DOM itself. Eventually such functions
              could even be automatically generated by the bindings script.
              (WebCore::JSLocation::setProtocol): Ditto.
              (WebCore::JSLocation::setHost): Ditto.
              (WebCore::JSLocation::setHostname): Ditto.
              (WebCore::JSLocation::setPort): Ditto.
              (WebCore::JSLocation::setPathname): Ditto.
              (WebCore::JSLocation::setSearch): Ditto.
              (WebCore::JSLocation::setHash): Ditto.
              (WebCore::JSLocation::replace): Ditto.
              (WebCore::JSLocation::reload): Ditto.
              (WebCore::JSLocation::assign): Ditto.
      
              * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
              * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
              to use this function for Location::replace, which is the same as setLocation except that
              it locks both history and the back/forward list.
              * page/DOMWindow.h: Ditto.
      
              * page/Location.cpp:
              (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
              logic there does not have to be repeated or even refactored.
              (WebCore::Location::setProtocol): Ditto.
              (WebCore::Location::setHost): Ditto.
              (WebCore::Location::setHostname): Ditto.
              (WebCore::Location::setPort): Ditto.
              (WebCore::Location::setPathname): Ditto.
              (WebCore::Location::setSearch): Ditto.
              (WebCore::Location::setHash): Ditto.
              (WebCore::Location::assign): Ditto.
              (WebCore::Location::replace): Ditto.
              (WebCore::Location::reload): Added. Security logic was refactored from the code in
              JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
              possibly unneeded.
      
              * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
              (WebCore::Location::create):
              (WebCore::Location::frame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa6b382
    • apavlov@chromium.org's avatar
      2010-12-30 Alexander Pavlov <apavlov@chromium.org> · a25484c3
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Pasting a style property with value should automatically split it into prop/value
              https://bugs.webkit.org/show_bug.cgi?id=51581
      
              The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
              of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
              and the edit focus is transferred to the value field.
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype.selectElement):
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/inspector.js:
              (WebInspector.completeURL): Drive-by: return full URLs as-is.
              (WebInspector.startEditing.cleanUpAfterEditing):
              (WebInspector.startEditing):
              (WebInspector.startEditing.pasteEventListener):
              (WebInspector.startEditing.keyDownEventListener):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a25484c3
    • podivilov@chromium.org's avatar
      2010-12-30 Pavel Podivilov <podivilov@chromium.org> · 49f89112
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
              https://bugs.webkit.org/show_bug.cgi?id=51745
      
              * inspector/front-end/Breakpoint.js:
              (WebInspector.Breakpoint.prototype.set enabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f89112
    • podivilov@chromium.org's avatar
      2010-12-30 Pavel Podivilov <podivilov@chromium.org> · 4cdcdc71
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
              https://bugs.webkit.org/show_bug.cgi?id=51748
      
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update):
              (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
              (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
              (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cdcdc71
    • philn@webkit.org's avatar
      2010-12-30 Philippe Normand <pnormand@igalia.com> · 5516511c
      philn@webkit.org authored
              Unreviewed, unskip the test, it's running fine locally.
      
              media/audio-delete-while-slider-thumb-clicked.html fails
              https://bugs.webkit.org/show_bug.cgi?id=37546
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5516511c
    • mnaganov@chromium.org's avatar
      2010-12-30 Mikhail Naganov <mnaganov@chromium.org> · d5027fe5
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
      
              https://bugs.webkit.org/show_bug.cgi?id=51713
      
              * WebCore.gypi:
              * WebCore.pro:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::memoryAccessorGetter):
              * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
              (WebCore::V8Performance::memoryAccessorGetter):
              * page/Console.idl:
              * page/Performance.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5027fe5
    • steveblock@google.com's avatar
      2010-12-30 Steve Block <steveblock@google.com> · c3d23e03
      steveblock@google.com authored
              Reviewed by Sam Weinig.
      
              Visiting macnn.com often causes SQL spew via geolocation database
              https://bugs.webkit.org/show_bug.cgi?id=51557
      
              If the Geolocation position cache database path has not been set, early-out
              rather than using an empty path and thus failing to open the database.
              This avoids SQL log spew.
      
              Also, avoid starting the database thread until the path has been set, and
              shorten the thread name to avoid warnings due to exceeding 30 characters.
      
              No new tests, implementation clean-up only.
      
              * page/GeolocationPositionCache.cpp:
              (WebCore::GeolocationPositionCache::addUser):
              (WebCore::GeolocationPositionCache::removeUser):
              (WebCore::GeolocationPositionCache::setDatabasePath):
              (WebCore::GeolocationPositionCache::startBackgroundThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3d23e03
    • philn@webkit.org's avatar
      2010-12-30 Philippe Normand <pnormand@igalia.com> · f27b1069
      philn@webkit.org authored
              Unreviewed, skipping another editing flacky test.
      
              * platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27b1069
    • philn@webkit.org's avatar
      2010-12-29 Philippe Normand <pnormand@igalia.com> · 2e69c919
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] minimal build fails at link time due to missing sqlite3 symbols
              https://bugs.webkit.org/show_bug.cgi?id=51327
      
              * configure.ac: Error out if SQLite3 wasn't found while at least
              one of the features depending on it has been enabled.
      
      WebCore:
      
              Reviewed by Martin Robinson.
      
              [GTK] minimal build fails at link time due to missing sqlite3 symbols
              https://bugs.webkit.org/show_bug.cgi?id=51327
      
              Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
      
              No new tests, build fix only.
      
              * platform/sql/SQLiteAuthorizer.cpp:
              * platform/sql/SQLiteDatabase.cpp:
              * platform/sql/SQLiteFileSystem.cpp:
              * platform/sql/SQLiteStatement.cpp:
              * platform/sql/SQLiteTransaction.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e69c919
    • hamaji@chromium.org's avatar
      2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com> · 84880c0d
      hamaji@chromium.org authored
              Chromium test expectation update for svg/dom/length-list-parser.html
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84880c0d
    • hamaji@chromium.org's avatar
      2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com> · ea76fb49
      hamaji@chromium.org authored
              Chromium test expectation update for media/video-element-other-namespace-crash.html
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea76fb49
    • inferno@chromium.org's avatar
      2010-12-30 Abhishek Arya <inferno@chromium.org> · 5f2ea743
      inferno@chromium.org authored
              Unreviewed.
      
              Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.
      
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f2ea743
    • jschuh@chromium.org's avatar
      2010-12-30 Justin Schuh <jschuh@chromium.org> · e1265371
      jschuh@chromium.org authored
              Reviewed by Dirk Schulze.
      
              Prevent stringToLengthType() from skipping past end-of-string on invalid length unit. 
              https://bugs.webkit.org/show_bug.cgi?id=51692
      
              * svg/SVGLength.cpp:
              (WebCore::stringToLengthType):
              (WebCore::SVGLength::setValueAsString):
      2010-12-30  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Dirk Schulze.
      
              Adding long float string to improve test coverage.
              https://bugs.webkit.org/show_bug.cgi?id=51692
      
              * svg/dom/length-list-parser.html:
              * svg/dom/length-list-parser-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1265371
    • inferno@chromium.org's avatar
      2010-12-30 Abhishek Arya <inferno@chromium.org> · 90bec5da
      inferno@chromium.org authored
              Reviewed by Eric Seidel.
      
              Create a helper function for finding descendent video elements for a node.
              https://bugs.webkit.org/show_bug.cgi?id=51696
      
              Test: media/video-element-other-namespace-crash.html
      
              * html/MediaDocument.cpp:
              (WebCore::descendentVideoElement): helper function.
              (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
              (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
      2010-12-30  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Tests that we do not crash when trying to find video elements in the media document.
              https://bugs.webkit.org/show_bug.cgi?id=51696
      
              * media/video-element-other-namespace-crash-expected.txt: Added.
              * media/video-element-other-namespace-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90bec5da
    • inferno@chromium.org's avatar
      2010-12-29 Abhishek Arya <inferno@chromium.org> · ace92ba2
      inferno@chromium.org authored
              Unreviewed.
      
              Add 'PASS' to layout test since test failing on chromium due to empty expectations.
              Filed webkit bug 51734 to track gtk test failure and skipping test for now.
      
              * fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
              * fast/multicol/span/double-merge-anonymous-block-crash.html:
              * platform/gtk/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ace92ba2
    • pfeldman@chromium.org's avatar
      2010-12-29 Pavel Feldman <pfeldman@chromium.org> · 075ed242
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
              https://bugs.webkit.org/show_bug.cgi?id=51707
      
              This change brushes up storage agents + removes redundant InspectorBackend class.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              * inspector/Inspector.idl:
              * inspector/InspectorBackend.cpp: Removed.
              * inspector/InspectorBackend.h: Removed.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              (WebCore::InspectorController::didUseDOMStorage):
              (WebCore::InspectorController::setInjectedScriptSource):
              (WebCore::InspectorController::dispatchOnInjectedScript):
              (WebCore::InspectorController::releaseWrapperObjectGroup):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMStorageAgent.cpp: Added.
              (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
              (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
              (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
              * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDOMStorageAgent::create):
              (WebCore::InspectorDOMStorageAgent::frontend):
              * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
              (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              (WebCore::InspectorDatabaseAgent::databaseForId):
              (WebCore::InspectorDatabaseAgent::selectDatabase):
              (WebCore::InspectorDatabaseAgent::clearFrontend):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDatabaseAgent::create):
              (WebCore::InspectorDatabaseAgent::frontend):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
              (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075ed242
    • paroga@webkit.org's avatar
      2010-12-29 Patrick Gansterer <paroga@webkit.org> · 26fe82ad
      paroga@webkit.org authored
              Unreviewed WinCE buildfix.
      
              * WinCELauncher/main.cpp: Add missing include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26fe82ad
    • krit@webkit.org's avatar
      2010-12-29 Dirk Schulze <krit@webkit.org> · 8409fd11
      krit@webkit.org authored
              Unreviewed fix of the misspelled email address in commit 74782.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8409fd11
  2. 29 Dec, 2010 18 commits
    • krit@webkit.org's avatar
      2010-12-29 Dirk Schulze <krit@wbekit.org> · 7a31472d
      krit@webkit.org authored
              Reviewed by Darin Adler.
      
              Cleanup SVG code according to the webkit style rules 3
              https://bugs.webkit.org/show_bug.cgi?id=51490
      
              Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
              Just one file can't be fixed for check-webkit-style.
              * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
      
              No changes of functionality, so no new tests. 
      
              * svg/SVGAllInOne.cpp:
              * svg/SVGImage.cpp:
              * svg/SVGLength.cpp:
              (WebCore::SVGLength::setValue):
              * svg/SVGPolygonElement.h:
              * svg/SVGPolylineElement.h:
              * svg/SVGPreserveAspectRatio.cpp:
              (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
              (WebCore::SVGPreserveAspectRatio::transformRect):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::viewport):
              * svg/SVGSetElement.h:
              * svg/SVGStylable.h:
              (WebCore::SVGStylable::~SVGStylable):
              * svg/SVGStyledLocatableElement.h:
              (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
              (WebCore::SVGStyledLocatableElement::isStyledLocatable):
              * svg/SVGStyledTransformableElement.cpp:
              (WebCore::SVGStyledTransformableElement::isKnownAttribute):
              * svg/SVGSwitchElement.cpp:
              (WebCore::SVGSwitchElement::childShouldCreateRenderer):
              * svg/SVGTests.cpp:
              (WebCore::SVGTests::parseMappedAttribute):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::isKnownAttribute):
              * svg/SVGTextPathElement.cpp:
              * svg/SVGTextPathElement.h:
              * svg/SVGTitleElement.h:
              (WebCore::SVGTitleElement::rendererIsNeeded):
              * svg/SVGTransformDistance.cpp:
              (WebCore::SVGTransformDistance::SVGTransformDistance):
              (WebCore::SVGTransformDistance::scaledDistance):
              (WebCore::SVGTransformDistance::addSVGTransforms):
              (WebCore::SVGTransformDistance::addSVGTransform):
              (WebCore::SVGTransformDistance::addToSVGTransform):
              (WebCore::SVGTransformDistance::isZero):
              * svg/SVGTransformList.cpp:
              * svg/SVGURIReference.cpp:
              (WebCore::SVGURIReference::getTarget):
              * svg/SVGVKernElement.h:
              * svg/SVGViewSpec.cpp:
              (WebCore::SVGViewSpec::parseViewSpec):
              * svg/SVGZoomAndPan.h:
              (WebCore::SVGZoomAndPan::SVGZoomAndPan):
              (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
              (WebCore::SVGZoomAndPan::zoomAndPan):
              * svg/SVGZoomEvent.h:
              (WebCore::SVGZoomEvent::create):
              * svg/animation/SMILTime.cpp:
              (WebCore::operator*):
              * svg/animation/SMILTime.h:
              (WebCore::SMILTime::SMILTime):
              (WebCore::SMILTime::unresolved):
              (WebCore::SMILTime::indefinite):
              (WebCore::SMILTime::operator=):
              (WebCore::SMILTime::value):
              (WebCore::SMILTime::isFinite):
              (WebCore::SMILTime::isIndefinite):
              (WebCore::SMILTime::isUnresolved):
              (WebCore::operator==):
              (WebCore::operator!): new operator checks for 0 or infinite values.
              (WebCore::operator!=):
              (WebCore::operator>):
              (WebCore::operator<):
              (WebCore::operator>=):
              (WebCore::operator<=):
              * svg/animation/SMILTimeContainer.h:
              (WebCore::SMILTimeContainer::create):
              (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::ConditionEventListener::operator==):
              (WebCore::SVGSMILElement::repeatingDuration):
              (WebCore::SVGSMILElement::resolveInterval):
              (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
              * svg/animation/SVGSMILElement.h:
              (WebCore::SVGSMILElement::timeContainer):
              (WebCore::SVGSMILElement::intervalBegin):
              (WebCore::SVGSMILElement::intervalEnd):
              (WebCore::SVGSMILElement::previousIntervalBegin):
              (WebCore::SVGSMILElement::documentOrderIndex):
              (WebCore::SVGSMILElement::setDocumentOrderIndex):
              * svg/graphics/SVGImage.h:
              (WebCore::SVGImage::create):
              (WebCore::SVGImage::destroyDecodedData):
              (WebCore::SVGImage::decodedSize):
              (WebCore::SVGImage::frameAtIndex):
              * svg/graphics/filters/SVGFilterBuilder.h:
              (WebCore::SVGFilterBuilder::create):
              (WebCore::SVGFilterBuilder::lastEffect):
              (WebCore::SVGFilterBuilder::getEffectReferences):
              (WebCore::SVGFilterBuilder::addBuiltinEffects):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a31472d
    • inferno@chromium.org's avatar
      2010-12-29 Abhishek Arya <inferno@chromium.org> · 3b358ec4
      inferno@chromium.org authored
              Reviewed by Darin Adler.
      
              ASSERT(oldchild->parent() == owner) fails.
              https://bugs.webkit.org/show_bug.cgi?id=50480
      
              In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
              is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
              assertion failure when removeChildNode executes on the child(equal to prev or next).
              Fix a typo in canMergeContiguousAnonymousBlocks.
      
              Test: fast/multicol/span/double-merge-anonymous-block-crash.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
              (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
      2010-12-29  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Darin Adler.
      
              Tests that we do not crash when merging anonymous blocks. 
              https://bugs.webkit.org/show_bug.cgi?id=50480
      
              * fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
              * fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b358ec4
    • dbates@webkit.org's avatar
      2010-12-29 Daniel Bates <dbates@rim.com> · c9aca449
      dbates@webkit.org authored
              Reviewed by Darin Adler.
      
              svn-apply updates date of wrong change log entry for a change log diff that
              contains two consecutive entries with the same author and date
              https://bugs.webkit.org/show_bug.cgi?id=46061
      
              Fixes an issue where the date of the wrong change log entry may be modified.
              Moreover, changes fixChangeLogPatch() to move entries inserted earlier
              in a ChangeLog file to the top of the file.
      
              Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
              diff when it detects that the diff inserts a change log entry earlier in a
              ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
              change. With the advent of the commit-queue this functionality of bailing out
              and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
              Instead, we should always move the change log entry to the top of the ChangeLog file.
      
              A side-effect of this change is that setChangeLogDateAndReviewer() now updates
              the date line of the correct change log entry in a ChangeLog diff.
      
              * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
      
              * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
                Updated the following unit tests now that we move entries inserted earlier to the top:
                - "fixChangeLogPatch: New entry inserted in middle."
                  (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
      
                - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
                  (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
      
              * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9aca449
    • jschuh@chromium.org's avatar
      2010-12-29 Justin Schuh <jschuh@chromium.org> · 4c4fae74
      jschuh@chromium.org authored
              Reviewed by Darin Adler.
      
              Check SVG element type in FrameView::scrollToAnchor
              https://bugs.webkit.org/show_bug.cgi?id=51718
      
              Test: svg/custom/scroll-to-anchor-in-symbol.svg
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollToAnchor):
      2010-12-29  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Darin Adler.
      
              Check SVG element type in FrameView::scrollToAnchor
              https://bugs.webkit.org/show_bug.cgi?id=51718
      
              * svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
              * svg/custom/scroll-to-anchor-in-symbol.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c4fae74
    • antonm@chromium.org's avatar
      2010-12-29 Anton Muhin <antonm@chromium.org> · aeb83933
      antonm@chromium.org authored
              Reviewed by Eric Seidel.
      
              [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
              https://bugs.webkit.org/show_bug.cgi?id=51704
      
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/V8DOMWindowShell.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeb83933
    • zmo@google.com's avatar
      2010-12-29 Zhenyao Mo <zmo@google.com> · 43d0745f
      zmo@google.com authored
              Reviewed by Eric Seidel.
      
              drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
              https://bugs.webkit.org/show_bug.cgi?id=51726
      
              * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
              * fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43d0745f
    • commit-queue@webkit.org's avatar
      2010-12-29 Konstantin Tokarev <annulen@yandex.ru> · 77f7b241
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] Fixed compatibility with gold linker on X11 platforms
              https://bugs.webkit.org/show_bug.cgi?id=51700
      
              * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
              Linked TestNetscapePlugin with libX11 on Unix platforms
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77f7b241
    • commit-queue@webkit.org's avatar
      2010-12-29 Kenichi Ishibashi <bashi@google.com> · 47509533
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Use a HashMap for m_continuation to save memory
              https://bugs.webkit.org/show_bug.cgi?id=43716
      
              Saving memory consumption by applying a HashMap convention to
              continuation pointers of RenderInline and RenderBlock classes.
      
              * rendering/RenderBlock.cpp: Removed m_continuation.
              (WebCore::RenderBlock::RenderBlock):
              (WebCore::RenderBlock::destroy):
              (WebCore::RenderBlock::inlineElementContinuation):
              (WebCore::RenderBlock::blockElementContinuation):
              * rendering/RenderBlock.h: Removed m_continuation.
              * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
              (WebCore::RenderBoxModelObject::destroy): Added an assertion.
              (WebCore::RenderBoxModelObject::continuation): Added.
              (WebCore::RenderBoxModelObject::setContinuation): Added.
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderInline.cpp: Removed m_continuation.
              (WebCore::RenderInline::RenderInline):
              (WebCore::RenderInline::destroy):
              (WebCore::RenderInline::inlineElementContinuation):
              * rendering/RenderInline.h: Removed m_continuation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47509533
    • commit-queue@webkit.org's avatar
      2010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org> · a90a9248
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Circular dependency in webkitpy.common.checkout.changelog module
              https://bugs.webkit.org/show_bug.cgi?id=50475
      
              Remove automatic import of api.Checkout module when any checkout/
              submodule is imported (e.g.: when checkout.scm.Git is imported).
      
              * Scripts/webkitpy/common/checkout/__init__.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a90a9248
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · a27a77a8
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Remove failing expectations for three Mac tests that no longer fail.
              Remove failing expectations for two canvas tests that no longer crash
              (r74561, which caused the failing assert, was rolled out with r74587).
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a27a77a8
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · 7704d1e3
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
              fast/js/numeric-escapes-in-string-literals.html fails because V8 does
              not support ECMAScript strict mode.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7704d1e3
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · a41d414f
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update. Mark two more inspector tests
              as flaky.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a41d414f
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · 8f6532e5
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update. Mark a few more tests as flaky.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f6532e5
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · a30aa46a
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a30aa46a
    • mihaip@chromium.org's avatar
      2010-12-29 Mihai Parparita <mihaip@chromium.org> · 3d9cb8ab
      mihaip@chromium.org authored
              Unreviewed Chromium expectations update.
      
              Make expectation for http/tests/media/reload-after-dialog.html not
              trigger a duplication error for the debug Linux builder.
      
              Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
              was removed in r74346.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9cb8ab
    • barraclough@apple.com's avatar
      Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9. · f7cdf368
      barraclough@apple.com authored
      Reviewed by Sam Weinig.
      
      JavaScriptCore: 
      
      * parser/Lexer.cpp:
      (JSC::Lexer::parseString):
      
      LayoutTests: 
      
      * fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
      * fast/js/numeric-escapes-in-string-literals.html: Added.
      * fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.
      (test):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7cdf368
    • mrobinson@webkit.org's avatar
      2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla ... · 59b9ac1d
      mrobinson@webkit.org authored
      2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Enable building whatever already exists of WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=37369
      
              No new functionality added or deleted. Only makefile change. Hence, no tests added.
      
              * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
              added them to WebKit/gtk/GNUmakefile.am
              * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
              and declare WEBKIT_API directly
      2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Enable building whatever already exists of WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=37369
      
              * GNUmakefile.am: Added.
              * WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header
              file for WebKit2 sources files.
              * gtk: Added.
              * gtk/webkit2.pc.in: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59b9ac1d
    • mrobinson@webkit.org's avatar
      2010-12-29 Martin Robinson <mrobinson@igalia.com> · 0fd1cb93
      mrobinson@webkit.org authored
              Build fix for GTK+.
      
              * webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd1cb93