1. 14 Nov, 2002 14 commits
    • hyatt's avatar
      Fix spinner.com mislayout on the PLT. Make sure · 5ee8b596
      hyatt authored
      	<input type=image> honors the width attribute and
      	make sure that its render object calls updateFromElement.
              * khtml/html/html_formimpl.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Move text measurement and layout beyond onload. This · d4a14ac7
      hyatt authored
      	shoudl speed up i-bench substantially and morrison's
      	PLT test slightly.  Note that the adjustFrames layout
      	stuff has been removed from isLoadComplete.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]):
              (-[WebFrame _isLoadComplete]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Move text measurement and layout beyond onload. This · 5159d9c2
      hyatt authored
      	shoudl speed up i-bench substantially and morrison's
      	PLT test slightly.
      	Also allow <table>s as children of <p> and <h1>-<h6>.
      	This fixes floats on slashdot.org (the left side) and
      	the floating tables in articles on wired.com.
              * khtml/html/dtd.cpp:
              * khtml/html/html_documentimpl.cpp:
              * khtml/html/html_documentimpl.h:
              * khtml/html/htmlparser.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fixed 3099505. With the recent white space changes, multiple slaves may · 852d80b2
      rjw authored
              be created for contiguous text on the same line.  The fix changes the
              iteration order of over the slave array.  Now, when searching for the end
              point of a line we'll always find the last slave on a line first.
              * khtml/khtml_part.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3095854 -- small select boxes get no scrollbar · 5e10a7c6
      darin authored
              * kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
      	Always use a minimum of 4 lines.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebFoundation: · 726fa2c5
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * English.lproj/Localizable.strings: Updated to include the new
      	error messages that Maciej just added. I wonder what effect this
      	will have if we see those errors in Alex-32?
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sheridan's avatar
      Alex-32 stamp · 98191978
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3101243 -- excite passes date that can't be parsed, results in bogus... · 64f2d797
      darin authored
      	- fixed 3101243 -- excite passes date that can't be parsed, results in bogus date at top right corner
              * kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Handle errors from strtol
      	by checking errno. Check the "string in a haystack" to be sure it's a multiple
      	of 3. Add case that allows year to be after time.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3101191 -- REGRESSION: Hang loading excite.com · 4fb58d6d
      darin authored
              * kjs/date_object.cpp:
              (mktimeUsingCF): Pick an arbitrary cutoff of 3000, and return -1 if the
      	year passed in is that big so we don't infinite loop. Also validate the
      	rest of the date with CFGregorianDateIsValid.
              (DateProtoFuncImp::call): Handle a -1 result from mktime.
              (DateObjectImp::construct): Check for NaN before calling mktime, and also
      	handle a -1 result from mktime.
              (DateObjectFuncImp::call): Check for NaN before calling mktime, and also
      	handle a -1 result from mktime.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • gramps's avatar
      * WebView.subproj/WebControllerPolicyDelegate.h: · 76387d3c
      gramps authored
      Added missing semi-colon in definition of WebPolicyDecisionListener to
      fix build error.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      WebKit: · 61d1c337
      mjs authored
      	Combined file URL policy with content policy. We don't actually
      	bother to ask earlier for file URLs yet, since that will make
      	things more complicated.
              * Misc.subproj/WebKitErrors.h:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _handleUnimplementablePolicy:errorCode:forURL:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              * WebView.subproj/WebView.m:
              (+[WebView initialize]):
      	Combined file URL policy with content policy. Also adjusted error
      	handling to continue to handle file errors well.
              * BrowserWebController.m:
              (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
              * LocationChangeError.m:
              (-[LocationChangeHandler specializedTitleForError:]):
              (-[LocationChangeHandler specializedMessageForError:]):
              * LocationChangeHandler.m:
              (-[LocationChangeHandler locationChangeDone:forDataSource:]):
              * WebBrowser.pbproj/project.pbxproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 043758d8
      darin authored
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      	Don't force all redirects to be reloads, because the ones from JavaScript must
      	not be. Maybe a better solution post-Alex-32 will be to pass a flag that distinguishes
      	redirects from other location changes.
              * khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Don't ignore the anchor when
      	comparing URLs to see if they should be a reload. We'll still do a reload if the URLs
      	are actually equal, but if they differ in anchor we will just go to the anchor.
      	This is the bug fix.
              * kwq/WebCoreBridge.h: Add reload parameter.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:]): Stuff the reload
      	parameter into the URLArgs.
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      	Make the reload flag pass across the bridge.
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Pass a reload flag, based on the load type, to the bridge.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Pass a
      	reload flag of NO in the anchor case. Preserve reload load types even when
      	doing client redirects (have to talk with Trey about this tomorrow).
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 3866e312
      darin authored
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
              * kwq/WebCoreBridge.h: Add needsLayout.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render
      	tree root says "layouted" is false. It would be more elegant to use more of this
      	WebCore layout logic and have less of our own on the WebKit side.
              * WebCore.pbproj/project.pbxproj: Oh, that Project Builder.
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
      	If the WebCore side needs layout, then do layout before trying to draw.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      Fixed client redirects, some more. The upshot is that they do not · 3a55cfde
      trey authored
      	generate two items in the back-forward list.  iBench still works.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge reportClientRedirectTo:delay:fireDate:]):  Call straight to the frame for all impl.
              (-[WebBridge reportClientRedirectCancelled]):  Call straight to the frame for all impl.
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
      	clientRedirect param removed when sending _loadURL: to frame.
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
      	clientRedirect param  removed. Check our own ivar to know if we are in client redirect case.
              (-[WebFrame _loadURL:intoChild:]):
      	clientRedirect param removed when sending _loadURL: .
              (-[WebFrame _clientRedirectedTo:delay:fireDate:]):
      	Note that we are doing a redirect if time=0 and we're not completed.  Also includes
      	previous impl moved from Bridge.
              (-[WebFrame _clientRedirectCancelled]):  Previous impl moved from Bridge.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 13 Nov, 2002 16 commits
    • darin's avatar
      - fixed 3100895 -- REGRESSION: Crash (was assertion) on http://www.w3.org/Style/CSS/ · 53a8ad15
      darin authored
              * khtml/rendering/render_text.h: Add an optional arena parameter to deleteSlaves.
              * khtml/rendering/render_text.cpp:
              (RenderText::detach): Pass the render arena in to deleteSlaves.
              (RenderText::deleteSlaves): Use the passed-in arena.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebFoundation: · 82240090
      darin authored
              * Misc.subproj/WebAssertions.m: (vprintf_stderr_objc):
      	Don't use displayableString. Makes us able to build on Panther.
              * WebFoundation.pbproj/project.pbxproj: Project Builder wanted to touch this.
      	- fixed another crash on http://www.w3.org/Style/CSS/, but still not done
              * khtml/rendering/render_box.cpp: (RenderBox::setStyle): Call renderArena()
      	from RenderObject rather than going at the document directly. Safer because
      	it works even when we don't have a node yet.
              * khtml/rendering/render_flow.cpp: (RenderFlow::addChild): Ditto.
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::paint): Ditto.
              (RenderLayer::nodeAtPoint): Ditto.
              (RenderLayer::constructZTree): Ditto.
              * khtml/rendering/render_list.cpp:
              (RenderListItem::setStyle): Ditto.
              * khtml/rendering/render_text.cpp:
              (RenderText::deleteSlaves): Ditto.
              (RenderText::position): Ditto. This is the one that actually crashed.
              * khtml/misc/makeattrs: Fixed handling of failure case.
              * khtml/misc/maketags: Ditto.
              * WebCore.pbproj/project.pbxproj: Project Builder wanted to touch this.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3100895 -- REGRESSION: Assertion on http://www.w3.org/Style/CSS/ · aed62356
      darin authored
      	A few arena-related fixes.
              * khtml/rendering/bidi.h: Don't define the operator new without the arena parameter.
      	That way, we get a link failure if we use it by accident, rather than an assert at runtime.
      	It would be even better to get a compile-time error, but I don't know how to make that happen.
              * khtml/rendering/render_layer.h: Ditto.
              * khtml/rendering/render_object.h: Ditto.
              * khtml/rendering/render_text.h: Ditto.
              * khtml/rendering/render_container.cpp:
              (RenderContainer::addChild): Create the RenderTable with the appropriate arena.
              (RenderContainer::insertPseudoChild): Create the RenderFlow objects with the appropriate arena.
              * khtml/rendering/render_text.cpp: (RenderText::deleteSlaves): Don't try to get the arena
      	when there are no slaves. This can happen after the element is nil, and in that case we will
      	do a nil-dereference.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 9aa61f37
      darin authored
              * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
      	Use the "0" instead of the "x" as the canonical character for width.
      	This is slightly wider and is better for credit card numbers, for example.
              * WebCore.pbproj/project.pbxproj: Tweak.
              * English.lproj/StringsNotToBeLocalized.txt: Let the script sort this file.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3099930 -- dates/times without time zones are parsed as UTC by kjs, · 65d708f3
      darin authored
      	local time by other browsers
              * kjs/date_object.cpp:
              (DateProtoFuncImp::call): Handle the NaN case better, like Mozilla and OmniWeb.
              (DateObjectFuncImp::call): Return NaN rather than Undefined() for bad dates.
              (KJS::parseDate): Return NaN rather than Undefined() or 0 for bad dates.
              (KJS::KRFCDate_parseDate): Return -1 rather than 0 for bad dates.
      	Assume local time if no time zone is passed. Don't return 1 if we parse 0.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      WebKit: · 065a97f9
      mjs authored
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • vicki's avatar
      tiny change made by rjw to fix build breakage · f44c6e70
      vicki authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · aa70db1b
      darin authored
      	- fixed 3083982 -- Logging into AOL gives null view
      	Turns out AOL was using a refresh header, which we were not supporting.
              * khtml/khtml_part.h: Declare receivedFirstData, a private member function.
              * khtml/khtml_part.cpp:
              (KHTMLPart::receivedFirstData): Separate out the part of slotData we
      	want to share, which really seems kinda separate anyway.
              (KHTMLPart::slotData): More of the same.
              * kwq/KWQKHTMLPart.h: Declare addMetaData.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same
      	thing ourselves.
              (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job.
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling
      	openURL: but meant to call loadURL:.
              * kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh.
      	This method is big enough that I should probably move the guts to KWQKHTMLPart.
      	- other things
              * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something
      	while doing my "bug fix" in here a while back. Change an assignment statement
      	to an assert.
      	- fixed 3083982 -- Logging into AOL gives null view
      	Turns out AOL was using a refresh header, which we were not supporting.
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Call openURL: and pass headers in.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
      	Pass nil for headers in this case, since we know it's just an anchor change.
      	- other things
              * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource
      	methods. We try to keep the bridge methods down to actual bridging.
              * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether,
      	and move dataSource up in the file.
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we
      	don't need to ask the bridge for it.
              (-[WebHTMLRepresentation documentSource]): Use it here.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for floats. Force relayout if collapsing margins · c6ead7fe
      hyatt authored
      	have to adjust the position of an object.
              * khtml/rendering/render_flow.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page · 3795ae7e
      trey authored
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]):  Make the rep before _transitionToCommitted.  This is the way it used to be.
              (-[WebDataSource _makeRepresentation]):  Don't make the docView here.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted]):  Make the docView here, after we save the scroll state but before notifying the delegate.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Rewrite cellpadding to not use the style system at all and · 80844874
      hyatt authored
      	to make table cells just get the padding from the table
      	itself (overriding style).
              * khtml/html/html_tableimpl.cpp:
              * khtml/html/html_tableimpl.h:
              * khtml/rendering/bidi.cpp:
              * khtml/rendering/render_box.cpp:
              * khtml/rendering/render_flow.cpp:
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_table.cpp:
              * khtml/rendering/render_table.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kocienda's avatar
      Bump WebCore cache to 4 MB (was 1 MB). · 28b09116
      kocienda authored
              * khtml/misc/loader.cpp
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3073230 -- JavaScript time calls do I/O by lstat()ing /etc/localtime · 8b276747
      darin authored
              * kjs/date_object.cpp:
              (formatDate): Added.
              (formatTime): Added.
              (formatLocaleDate): Added.
              (formatLocaleTime): Added.
              (DateProtoFuncImp::call): Changed to use the above functions instead of
      	using strftime.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3100013 -- REGRESSION: Can't get results from i-Bench anymore · 6208ff60
      darin authored
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
      	Don't set the state to WebFrameStateComplete if it has already been set
      	to WebFrameStateProvisional. If it has, that means we already began a new
      	load; that one is not yet complete.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      2002-11-13 John Sullivan <sullivan@apple.com> · ce6f6df4
      sullivan authored
      	- fixed 3099922 -- REGRESSION: Back button always pops up menu
              * Misc.subproj/WebNSViewExtras.h:
              * Misc.subproj/WebNSViewExtras.m:
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]:
      	Fixed a copy/paste error I made yesterday -- this method was never
      	noticing the mouse-up events because it was checking the event type
      	against the wrong number. Also changed the hysteresis values from
      	unsigneds to floats (unsigned was just wrong).
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      WebCore: · 368154da
      mjs authored
      	- fixed 3050447 - Policy handlers have no way of telling client
      	that the proposed navigation is a form post
              * khtml/khtml_part.cpp:
              (KHTMLPart::submitForm): Call kwq->submitForm
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::openURL): Adjusted for bridge API change.
              (KWQKHTMLPart::openURLRequest): Removed POST handling.
      	(KWQKHTMLPart::submitForm): Added this back, because we need to
      	know what URL navigations are caused by form submission, even if
      	they are not POSTs.
              (KWQKHTMLPart::urlSelected): Adjusted for bridge API change.
              * kwq/WebCoreBridge.h: Add triggeringEvent: parameter to postURL:
      	and isFormSubmission: parameter to loadURL:.
      	- fixed 3050447 - Policy handlers have no way of telling client
      	that the proposed navigation is a form post
      	Now we pass form submissions through all the normal policy steps.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
              (-[WebBridge postWithURL:data:contentType:triggeringEvent:]):
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _setTriggeringAction:]):
              (-[WebDataSource _triggeringAction]):
              (-[WebDataSource _lastCheckedRequest]):
              (-[WebDataSource _setLastCheckedRequest:]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame setProvisionalDataSource:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _loadRequest:triggeringAction:]):
              (-[WebFrame _actionInformationForNavigationType:event:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _loadURL:intoChild:]):
              (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 12 Nov, 2002 10 commits
    • mjs's avatar
      WebKit: · 8e4ec943
      mjs authored
      	Combine click policy and URL policy into navigation policy.
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _actionInformationForNavigationType:event:]):
              (-[WebFrame _continueAfterFileURLPolicyForRequest:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]):
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
      	Combined click policy and URL policy into navigation policy.
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController navigationPolicyForAction:andRequest:inFrame:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 3032869, the background image for the body was being · de8798e2
      hyatt authored
      	propagated up to the root properly but was not being tiled over
      	the whole canvas.
              * khtml/rendering/render_box.cpp:
              * khtml/rendering/render_html.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with... · b613789e
      trey authored
      	fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _isLoadComplete]):  Set state=completed only after we tell the bridge to
      	end the load.  This allows client redirects to be processed before we think we're complete.
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
      	Only process client redirects as such if we are not already complete.  This makes JS driven
      	navigations after load-time work like the user would expect, as normal navigations.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix the top of moveabletype.org. The maxwidth/minwidth · 76b81603
      hyatt authored
      	calculation for blocks with inline content did not properly
      	deal with margins and padding on inline elements like <a>.
              * khtml/rendering/render_flow.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 2953367, padding is incorrectly inherited into table cells · 1e39e214
      hyatt authored
      	and also incorrectly overrides cellpadding on the table itself.
      	Fixes dailyf1.com.
              * khtml/css/html4.css:
              * khtml/html/html_tableimpl.cpp:
              * khtml/html/html_tableimpl.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      - fixed 3099487 - REGRESSION: dragging an image always puts it in · f07e9c04
      mjs authored
      	the download directory
              * WebView.subproj/WebControllerPrivate.h:
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path.
      	(-[WebController _downloadURL:toPath:]): New method that
      	predetermines the path to download to (needed for DnD).
              * WebView.subproj/WebHTMLView.m:
      	(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use
              * WebView.subproj/WebImageView.m:
      	(-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use
              * WebView.subproj/WebMainResourceClient.m:
      	(-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask
      	delegate for download path if we already have one.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fixed likely cause of 3099047 (and others). Width buffer could underrun in · b4635089
      rjw authored
              some situations.
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      For now make text/xml files use HTML parsing/documents. · 5b288376
      hyatt authored
      	This avoids the infinite loop we get into when loading
      	text/xml.  If/when we finally support XML, we can undo
      	this change.
              * khtml/khtml_part.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 3086321, stylesheets not loading if titles are · a40eb069
      hyatt authored
      	specified.  Note that 4 of the pages on the PLT were
      	affected by this, so I fully expect a slight performance
      	degradation (the boost from the regression was artificial).
              * khtml/xml/dom_docimpl.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      WebKit: · 8518f7bc
      sullivan authored
              * Misc.subproj/WebNSViewExtras.h:
              * Misc.subproj/WebNSViewExtras.m:
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
      	new method
              (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]):
      	now calls the new method, passing the default hysteresis values
      	- fixed 3096528 -- don't let initially-horizontal drags of
      	toolbar bookmarks escape from toolbar
      	Unfortunately I left behind a drawing glitch, recorded as
      	bug 3099488. Ideas to fix this are hereby solicited.
              * FavoritesBar.m:
              (-[FavoritesBar slideButtonsIntoPlace]):
      	renamed from repositionButtons for clarity
              (-[FavoritesBar maxButtonX]):
      	new method, extracted from _layOutButtons
              (-[FavoritesBar _layOutButtons]):
      	now calls maxButtonX
              (-[FavoritesBar setDropIndex:]):
      	updated for name change
              (-[FavoritesBar specialBookmarkSourcesCount]):
      	new method, extracted from duplicated code
              (-[FavoritesBar lastNonFavoriteIndex]):
      	new method, extracted from dropIndexFromDraggingInfo:
              (-[FavoritesBar dropIndexFromLocalPoint:]):
      	new method, extracted from dropIndexFromDraggingInfo:
              (-[FavoritesBar dropIndexFromDraggingInfo:]):
      	now calls dropIndexFromLocalPoint:
              (-[FavoritesBar addDroppedBookmarks:atIndex:]):
      	new method, extracted from performDragOperation:
              (-[FavoritesBar performDragOperation:]):
      	now calls addDroppedBookmarks:atIndex:
              (-[FavoritesBar _lastDraggedEventFollowing:]),
              (-[FavoritesBar _lastDraggedOrUpEventFollowing:]):
      	new methods, cribbed from AppKit
              (-[FavoritesBar constrainProposedButtonFrame:]):
      	new method
              (-[FavoritesBar reorderFavoriteButton:fromMouseDownEvent:]):
      	new method, drags (but not using CoreDragging stuff) button
      	horizontally within bar only
              * FavoritesBarView.h:
      	added definition of FavoritesBarReorderingDelegate informal protocol
              * FavoritesBarView.m:
              (-[FavoritesBarView reorderFavoriteButton:fromMouseDownEvent:]):
      	pass call through to delegate (FavoritesBar)
              * FavoriteButton.m:
              (-[FavoriteButton currentEventOffsetFromEvent:]):
      	new method, extracted from performDragFromEvent:
              (-[FavoriteButton performDragFromEvent:]):
      	now calls extracted method
              (-[FavoriteButton canDrag]):
      	renamed from canDragButton; now checks whether superview is a
              (-[FavoriteButton mouseDown:]):
      	checks whether initial dragging movement was primarily vertical or
      	horizontal; if horizontal, calls new reordering code; if vertical,
      	uses larger hysteresis to minimize accidental poofing
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2642 268f45cc-cd09-0410-ab3c-d52691b4dbfc