1. 27 Oct, 2007 20 commits
    • weinig's avatar
      WebCore: · 5e5675ed
      weinig authored
              Reviewed by Adam Roben.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=14953
              Implement window.console in WebCore
      
              - Adds a window.console object that has 4 methods (log, info, warn, and error)
                that send messages to the Chrome.  This moves functionality that was in the
                app down into WebCore.
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/scripts/CodeGeneratorJS.pm: Add extended attribute
              to mark attributes as [Replacable] which indicates they can 
              overridden when set.
              * page/Chrome.cpp:
              (WebCore::Chrome::addMessageToConsole): Allow all messages to go
              up to the ChromeClient.
              * page/Console.cpp: Added.
              (WebCore::Console::Console):
              (WebCore::Console::disconnectFrame):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::warn):
              * page/Console.h: Added.
              * page/Console.idl: Added.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::clear):
              (WebCore::DOMWindow::console):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
      
      LayoutTests:
      
              Reviewed by Adam Roben.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=14953
              Implement window.console in WebCore
      
              * fast/dom/Window/window-properties-expected.txt:
              * http/tests/security/cross-frame-access-put-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e5675ed
    • pewtermoose's avatar
      Update results · 3e8594fb
      pewtermoose authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e8594fb
    • aroben's avatar
      Speculative fix for an intermittently failing test · e10abcd7
      aroben authored
               Reviewed by Sam and Eric.
      
               * http/tests/local/style-access-before-stylesheet-loaded.html: Use
               waitUntilDone/notifyDone.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e10abcd7
    • eseidel's avatar
      2007-10-27 Eric Seidel <eric@webkit.org> · c0d7ffd8
      eseidel authored
              Reviewed by aroben.
              
              Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)
      
              No functional changes, thus no tests.
      
              * ksvg2/svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::filterEffect):
              * ksvg2/svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::filterEffect):
              * ksvg2/svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::filterEffect):
              * ksvg2/svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::filterEffect):
              * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::filterEffect):
              * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::filterEffect):
              * ksvg2/svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::filterEffect):
              * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::filterEffect):
              * ksvg2/svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::filterEffect):
              * ksvg2/svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::filterEffect):
              * ksvg2/svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::filterEffect):
              * ksvg2/svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::filterEffect):
              * ksvg2/svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::filterEffect):
              * ksvg2/svg/SVGFETurbulenceElement.cpp:
              (WebCore::SVGFETurbulenceElement::filterEffect):
              * platform/graphics/svg/SVGResourceFilter.h:
              * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
              * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
              * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0d7ffd8
    • aroben's avatar
      Add some more failing tests to the Windows Skipped file · f88d8471
      aroben authored
              Reviewed by NOBODY.
      
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f88d8471
    • kmccullo's avatar
      Reviewed by Adam. · ca291df3
      kmccullo authored
              - Stubbed out IWebScriptCallFrame for Drosera.
      
              * Interfaces/IWebScriptCallFrame.idl: Added function declarations.
              * WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
              * WebScriptCallFrame.cpp: Added.
              (WebScriptCallFrame::WebScriptCallFrame):
              (WebScriptCallFrame::~WebScriptCallFrame):
              (WebScriptCallFrame::createInstance):
              (WebScriptCallFrame::QueryInterface):
              (WebScriptCallFrame::AddRef):
              (WebScriptCallFrame::Release):
              (WebScriptCallFrame::caller):
              (WebScriptCallFrame::scopeChain):
              (WebScriptCallFrame::functionName):
              (WebScriptCallFrame::evaluateWebScript):
              * WebScriptCallFrame.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca291df3
    • mitz's avatar
      WebCore: · 1faee4ab
      mitz authored
              Reviewed by Darin Adler.
      
              - fix a crash when opening Zenoss server history view
                <rdar://problem/5530657>
      
              Test: fast/table/colgroup-relative.html
      
              * rendering/LayoutState.cpp:
              (WebCore::LayoutState::LayoutState): Added a hasLayer() check before
              accessing layer().
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/5530657>
      
              * fast/table/colgroup-relative-expected.txt: Added.
              * fast/table/colgroup-relative.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1faee4ab
    • kmccullo's avatar
      - BuildFix · 0e455366
      kmccullo authored
              - Forgot to change the build step when I changed the filename.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e455366
    • ggaren's avatar
      Reviewed by Darin Adler. · 699f4d42
      ggaren authored
              
              Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
              computedHash()"
              http://bugs.webkit.org/show_bug.cgi?id=15718
      
              * kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a 
              hash value. Also changed O(n) strlen to O(1) check for empty string.
              (KJS::Identifier::add):
      
              * kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string.
              (KJS::UString::UString):
              (KJS::UString::operator=):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      699f4d42
    • darin's avatar
      Reviewed by Eric. · deaf059b
      darin authored
              - a couple of Windows fixes
      
              * wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has
              a "pow" function that does not properly handle the case where arg1 is
              NaN and arg2 is 0.
      
              * kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity
              specify "::pow" -- just "pow" is fine.
      
              * wtf/ASCIICType.h: Check the compiler, not the OS, since it's the
              compiler/library that has the wchar_t that is just a typedef.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deaf059b
    • ap's avatar
      2007-10-27 Julien <julien.chaffraix@gmail.com> · fa1721f9
      ap authored
              Reviewed by Alexey.
      
              http://bugs.webkit.org/show_bug.cgi?id=13141
              XMLHttpRequest should set readyState to 0 after abort()
              
              Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::open):
              (WebCore::XMLHttpRequest::abort):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa1721f9
    • mitz's avatar
      WebCore: · 5de015e3
      mitz authored
              Reviewed by Dave Hyatt.
      
              - fix rotated border images by using a temporary subimage containing
                only the part we want to tile
      
              Test: fast/borders/border-image-rotate-transform.html
      
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::Image::drawPatternCallback):
              (WebCore::Image::drawPattern):
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - rotated border image test
      
              * fast/borders/border-image-rotate-transform.html: Added.
              * platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
              * platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
              * platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5de015e3
    • darin's avatar
      Reviewed by Maciej. · ebd074b2
      darin authored
              - http://bugs.webkit.org/show_bug.cgi?id=15711
                force JSImmediate to be inlined for roughly 1.2% SunSpider speedup
      
              * kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.
      
              * kjs/object.h: Removed redundant includes.
              * kjs/value.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebd074b2
    • mrowe@apple.com's avatar
      2007-10-27 Mark Ambachtsheer <mark.a@apple.com> · 935a797f
      mrowe@apple.com authored
              Reviewed by Darin.
      
              Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
              (0, 0) the clipping rectangle is not correct.
              Added the origin to the window clip rectangle coordinates to account for plugins that
              don't originate at (0,0); affects code for offscreen GWorlds only.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      935a797f
    • alp's avatar
      2007-10-27 Jan Michael Alonzo <jmalonzo@unpluggable.com> · be2af083
      alp authored
              Reviewed by Alp.
      
              http://bugs.webkit.org/show_bug.cgi?id=15722
              [GTK] Refactor gtk/RenderThemeGtk and implement a few more methods
      
              Refactor/enhance GTK RenderTheme
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances
              (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported
              (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports
              (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports
              (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton
              (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton
              (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so
              (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs
              (WebCore::RenderThemeGtk::adjustTextFieldStyle):
              (WebCore::RenderThemeGtk::getThemeData):
              * platform/gtk/RenderThemeGtk.h:
              (WebCore::RenderThemeGtk::supportsControlTints):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2af083
    • mjs's avatar
      Reviewed by Mark. · d895a10a
      mjs authored
              
              - fixed "ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash()"
              http://bugs.webkit.org/show_bug.cgi?id=15718
      
              * kjs/identifier.cpp:
              (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed,
              now that we count on all Identifiers already having one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d895a10a
    • ap's avatar
      Reviewed by Darin. · 7b67568d
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=15555
              XMLHttpRequest does not support charset "x-user-defined", which can
              facilitate loading of binary data
      
              Test: http/tests/xmlhttprequest/binary-x-user-defined.html
      
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/TextCodecUserDefined.cpp: Added.
              (WebCore::TextCodecUserDefined::registerEncodingNames):
              (WebCore::newStreamingTextDecoderUserDefined):
              (WebCore::TextCodecUserDefined::registerCodecs):
              (WebCore::TextCodecUserDefined::decode):
              (WebCore::encodeComplexUserDefined):
              (WebCore::TextCodecUserDefined::encode):
              * platform/TextCodecUserDefined.h: Added.
              * platform/TextEncodingRegistry.cpp:
              (WebCore::buildBaseTextCodecMaps):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b67568d
    • ap's avatar
      Reviewed by Darin. · 18018fbe
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=15467
              Setting innerHTML to blank string in application/xhtml+xml mode
              throws DOM Exception 7
      
              Test: fast/dom/blank-innerHTML.xhtml
      
              * dom/XMLTokenizer.cpp:
              (WebCore::parseXMLDocumentFragment): Bail out early if the input string is empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18018fbe
    • mrowe@apple.com's avatar
      2007-10-27 Mark Rowe <mrowe@apple.com> · 6cc8b9e0
      mrowe@apple.com authored
              Silence a warning.
      
              * kjs/SymbolTable.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cc8b9e0
    • mrowe@apple.com's avatar
      2007-10-27 Mark Rowe <mrowe@apple.com> · cc4826c6
      mrowe@apple.com authored
              Gtk build fix.
      
              * kjs/function.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc4826c6
  2. 26 Oct, 2007 20 commits
    • weinig's avatar
      Enable dragging the left sidebar using the separator. · 51806ed1
      weinig authored
              Reviewed by Anders (unless Mitz says otherwise).
      
              * page/inspector/DocumentPanel.js:
              * page/inspector/inspector.css:
              * page/inspector/inspector.html:
              * page/inspector/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51806ed1
    • weinig's avatar
      Fix an off by one error when resizing the Inspector find window. · 6c161d3d
      weinig authored
              Reviewed by Hyatt.
      
              * page/inspector/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c161d3d
    • honeycutt's avatar
      2007-10-26 Jon Honeycutt <jhoneycutt@apple.com> · 7704caa4
      honeycutt authored
              Reviewed by Adam.
      
              Fix fallout from r26072, which leads to all plugin streams for local
              resources being cancelled
      
              * loader/win/NetscapePlugInStreamLoaderWin.cpp:
              (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this
              is an HTTP response before checking the HTTP response code
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7704caa4
    • hyatt's avatar
      Fix for http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box... · a911ec3a
      hyatt authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
              when only translation changes.
      
              Move the updating of the transform to in between the old repaint and the new repaint.
      
              Reviewed by mitz
      
              fast/repaint/transform-translate.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPositions):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a911ec3a
    • kmccullo's avatar
      Rubber stamp by Adam. · 775f70a1
      kmccullo authored
              - Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the
              files contain are functions that operate on BSTRs.
      
              * API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
              * API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
              * API/JSStringRefCOM.cpp: Removed.
              * API/JSStringRefCOM.h: Removed.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      775f70a1
    • kmccullo's avatar
      Reviewed by Adam. · 0644cc65
      kmccullo authored
              - Implemented the WebScriptDebugListener functions now that the
              WebScriptDebugServer exists
      
              * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
              functions.
              (ServerConnection::currentFrame):
              (ServerConnection::didLoadMainResourceForDataSource):
              (ServerConnection::didParseSource):
              (ServerConnection::failedToParseSource):
              (ServerConnection::didEnterCallFrame):
              (ServerConnection::willExecuteStatement):
              (ServerConnection::willLeaveCallFrame):
              (ServerConnection::exceptionWasRaised):
              * Drosera/win/ServerConnection.h: Removed unused arguments from the
              members arguments list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0644cc65
    • kmccullo's avatar
      Reviewed by Adam. · 58153ea3
      kmccullo authored
              - Made JSStringCreateWithBSTR capable of handling null BSTRs.
      
              * API/JSStringRefCOM.cpp:
              (JSStringCreateWithBSTR):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58153ea3
    • weinig's avatar
      Windows build fix. · c45980a0
      weinig authored
              * kjs/SymbolTable.h: Add header gaurd.
              * kjs/nodes.h: #include "SymbolTable.h"
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c45980a0
    • ggaren's avatar
      Suggested by Anders Carlsson. · 3eac1ae8
      ggaren authored
              
              Fixed tyop.
      
              * kjs/function.cpp:
              (KJS::ActivationImp::getOwnPropertySlot):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eac1ae8
    • ggaren's avatar
      Suggested by Darin Adler. · ae003666
      ggaren authored
              
              Use computedHash(), which is safer than just directly accessing _hash.
      
              * kjs/lookup.cpp:
              (KJS::Lookup::findEntry):
              (KJS::Lookup::find):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae003666
    • honeycutt's avatar
      2007-10-26 Jon Honeycutt <jhoneycutt@apple.com> · 4cca0bee
      honeycutt authored
              Reviewed by Darin.
      
              <rdar://5557379> Crash in Silverlight when opening microsoft.com
      
              The crash is within Silverlight, and the latest version of the plugin
              does not exhibit this crash, so just avoid loading this version of the
              plugin.
      
              * plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and
              constants silverlightPluginMinRequiredVersionMSDWORD and
              silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from 
              the version info of Silverlight 1.0.20926.0, which is a version known
              not to exhibit this crash
              (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether
              this plugin is blacklisted
              * plugins/win/PluginDatabaseWin.h:
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion*
              (WebCore::PluginPackageWin::getFileVersion):
              (WebCore::PluginPackageWin::storeFileVersion): Read version info for
              the plugin, and store the file version
              (WebCore::PluginPackageWin::fetchInfo): After determining the name,
              description, and file version, determine whether this plug-in is
              blacklisted. If so, return false so this plug-in isn't loaded
              * plugins/win/PluginPackageWin.h:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cca0bee
    • ggaren's avatar
      Build fix: svn add SymbolTable.h · 4df29429
      ggaren authored
              * kjs/SymbolTable.h: Added.
              (KJS::SymbolTable::set):
              (KJS::SymbolTable::get):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4df29429
    • ggaren's avatar
      Build fix: export SymbolTable.h to WebCore. · f9582143
      ggaren authored
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9582143
    • ggaren's avatar
      Comment tweak suggested by Maciej. · ea81a88d
      ggaren authored
              * kjs/function.cpp:
              (KJS::ActivationImp::getOwnPropertySlot):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea81a88d
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · 01116dfb
      ggaren authored
              
              Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.
      
              * kjs/property_map.cpp: Use a special no branch accessor to the UString's
              hash value. Also, return immediately instead of branching to the end
              of the loop if the value is not found.
              (KJS::PropertyMap::get):
              (KJS::PropertyMap::getLocation):
              (KJS::PropertyMap::put):
              (KJS::PropertyMap::insert):
              (KJS::PropertyMap::remove):
              (KJS::PropertyMap::checkConsistency):
      
              * kjs/ustring.h:
              (KJS::UString::Rep::computedHash): Special no branch accessor to the
              UString's hash value. Used when the caller knows that the hash value
              has already been computed. (For example, if the caller got the UString
              from an Identifier.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01116dfb
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · 27238f33
      ggaren authored
              
              Switched ActivationImp to using a symbol table. For now, though, all
              clients take the slow path.
              
              Net .6% speedup on SunSpider.
              
              Slowdowns:
                  - ActivationImp now mallocs in its constructor
                  - Local variable hits use an extra level of indirection to retrieve 
                  data
                  - Local variable misses do two lookups
      
              Speedups:
                  - Fast initialization of local variables upon function entry
      
              * JavaScriptCore.xcodeproj/project.pbxproj: Added SymbolTable.h
              
              * kjs/function.cpp:
              (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold
              data that won't fit in a JSCell.
              (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for 
              lookup.
              (KJS::ActivationImp::getOwnPropertySlot): ditto
              (KJS::ActivationImp::deleteProperty): ditto
              (KJS::ActivationImp::put): ditto
              (KJS::ActivationImp::createArgumentsObject): ditto
      
              (KJS::ActivationImp::mark): Call JSObject::mark first so that one of
              our properties doesn't try to recursively mark us. (This caused a crash
              in earlier testing. Not sure why we haven't run into it before.)
      
              * kjs/nodes.cpp: Functions now build a symbol table the first time 
              they're called.
              (KJS::VarDeclNode::evaluate):
              (KJS::FunctionBodyNode::FunctionBodyNode):
              (KJS::FunctionBodyNode::initializeSymbolTable):
              (KJS::FunctionBodyNode::processDeclarations):
              (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
              (KJS::FunctionBodyNode::processDeclarationsForProgramCode):
      
              * kjs/nodes.h:
              (KJS::FunctionBodyNode::symbolTable):
      
              * wtf/Forward.h: Added Vector.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27238f33
    • weinig's avatar
      Reviewed by Adele Peterson. · 1590186e
      weinig authored
              Fix for <rdar://problem/5421754>
              m_frameName member variable in HTMLPlugInElement unnecessary
      
              - Refactor the willRemove() method down into HTMLFrameOwnerElement now that
                we no longer need to use the m_frameName variable.
      
              * html/HTMLFrameElementBase.cpp:
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.cpp:
              (WebCore::HTMLFrameOwnerElement::willRemove):
              * html/HTMLFrameOwnerElement.h:
              * html/HTMLPlugInElement.cpp:
              * html/HTMLPlugInElement.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1590186e
    • kmccullo's avatar
      - Corrected function name mistake in this changelog. · 22893d62
      kmccullo authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22893d62
    • kmccullo's avatar
      JavaScriptCore: · 8baf9b90
      kmccullo authored
              Reviewed by Sam and Steve.
      
              - Added convenience methods for converting between BSTR and JSStringRefs
      
              * API/JSStringRefCOM.cpp: Added.
              (JSStringCreateWithCFString):
              (JSStringCopyCFString):
              * API/JSStringRefCOM.h: Added.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      win:
      
              Reviewed by Sam and Steve.
      
              - Added convenience methods for converting between BSTR and JSSTringRefs
              - Added WebKit_debug.def to the project.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit.vcproj:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8baf9b90
    • adele's avatar
      Reverting an unintentional added symbol · ccb3d7a7
      adele authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccb3d7a7