1. 13 Feb, 2013 31 commits
    • commit-queue@webkit.org's avatar
      [GTK] Remove support for compiling with GStreamer 0.10 · 5e1db3b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109593
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
      Reviewed by Philippe Normand.
      
      Remove support for building WebKitGTK+ with GStreamer 0.10. We
      can simplify things greatly because we don't have to worry any
      longer about selecting one GStreamer API set.
      
      * Source/autotools/FindDependencies.m4:
      * Source/autotools/ReadCommandLineArguments.m4:
      * Source/autotools/SetupAutoconfHeader.m4:
      * Source/autotools/Versions.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e1db3b4
    • allan.jensen@digia.com's avatar
      [Qt] window.open passes height and width parameters even if not defined in a page · 9f89d496
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107705
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Do not override width or height of 0, as that indicates default size, and not minimum size.
      
      Tested by tst_qwebpage.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::adjustWindowRect):
      
      Source/WebKit/efl:
      
      Do not resize window when default size is requested.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::setWindowRect):
      
      Source/WebKit/gtk:
      
      Do not resize window when default size is requested.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::setWindowRect):
      
      Source/WebKit/qt:
      
      Test that minimum size is applied only when the requested size is too small,
      not when default is requested.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage):
      (TestPage):
      (TestPage::TestPage):
      (TestPage::createWindow):
      (TestPage::slotGeometryChangeRequested):
      (tst_QWebPage::openWindowDefaultSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f89d496
    • commit-queue@webkit.org's avatar
      The 2D Canvas functions fillText()/strokeText() should display nothing when... · 34ffc56f
      commit-queue@webkit.org authored
      The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero
      https://bugs.webkit.org/show_bug.cgi?id=102656
      
      Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-13
      Reviewed by Dirk Schulze.
      
      The functions fillText()/strokeText() should not display anything when
      maxWidth is less than or equal to zero, according to spec :
      http://www.w3.org/TR/2dcontext/#text-preparation-algorithm
      
      Source/WebCore:
      
      Test: fast/canvas/canvas-fillText-maxWidth-zero.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      
      LayoutTests:
      
      * fast/canvas/canvas-fillText-invalid-maxWidth-expected.txt: Added.
      * fast/canvas/canvas-fillText-invalid-maxWidth.html: Added.
      * fast/canvas/canvas-strokeText-invalid-maxWidth-expected.txt: Added.
      * fast/canvas/canvas-strokeText-invalid-maxWidth.html: Added.
      * fast/canvas/script-tests/canvas-fillText-invalid-maxWidth.js: Added.
      * fast/canvas/script-tests/canvas-strokeText-invalid-maxWidth.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34ffc56f
    • sergio@webkit.org's avatar
      Unreviewed GTK gardening. · d6b1e399
      sergio@webkit.org authored
      Provide the same custom expectations as all the other
      platforms. This likely means that there is a bug in the code or
      that the expected result is incorrect.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6b1e399
    • commit-queue@webkit.org's avatar
      [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents. · 25c41ef8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109611
      
      The deltas in mousewheel events generated by track can be accelerated (e.g. when
      scrolling repeatedly). Keep track of the ratio of the acceleration since that is
      useful for some tasks (e.g. overflow navigation gesture).
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2013-02-13
      Reviewed by Adam Barth.
      
      * public/WebInputEvent.h:
      (WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
      * src/WebInputEvent.cpp:
      (SameSizeAsWebMouseWheelEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c41ef8
    • zherczeg@webkit.org's avatar
      replaceWithJump should not decrease the offset by 1 on ARM traditional. · b98ba080
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109689
      
      Reviewed by Zoltan Herczeg.
      
      * assembler/ARMAssembler.h:
      (JSC::ARMAssembler::replaceWithJump):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b98ba080
    • ch.dumez@sisa.samsung.com's avatar
      [EFL][WK2] Introduce WKViewClient C API · 9109c0e2
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109559
      
      Reviewed by Anders Carlsson.
      
      This patch introduces the WKViewClient C API for EFL's WKView. The purpose of
      this new C API is to eventually remove the interdependency between EFL's
      PageClient and EwkView. When completed, PageClient should only interact with
      WebView and not be aware of EwkView so that we have a clean separation between
      internal WebKit2 classes and our EFL Ewk API implementation.
      
      This patch is only a first step towards this goal as there is a lot of work
      to do to achieve complete separation between EwkView and PageClient. The purpose
      of this patch is to introduce the needed architecture which will later be
      extended by introducing new WKViewClient callbacks.
      
      * PlatformEfl.cmake: Add new ViewClientEfl.cpp and WebViewClient.cpp to EFL's CMake
      configuration.
      * UIProcess/API/C/efl/WKView.cpp:
      (WKViewSetViewClient):
      * UIProcess/API/C/efl/WKView.h: Introduce new WKViewClient C API.
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::EwkView): Initialize ViewClientEfl.
      * UIProcess/API/efl/EwkView.h: Add new ViewClientEfl member.
      (WebKit):
      (EwkView):
      * UIProcess/API/efl/EwkViewCallbacks.h: Update ContentsSizeChanged smart callback to
      accept a WKSize in parameter instead of an IntRect.
      * UIProcess/efl/PageClientBase.cpp: Start calling WKViewClient callbacks instead of
      interacting directly with EwkView to avoid violating API layering.
      (WebKit::PageClientBase::view):
      (WebKit::PageClientBase::setViewNeedsDisplay):
      * UIProcess/efl/PageClientBase.h:
      (WebKit):
      (PageClientBase):
      * UIProcess/efl/PageClientDefaultImpl.cpp: Start calling WKViewClient callbacks instead of
      interacting directly with EwkView to avoid violating API layering.
      (WebKit::PageClientDefaultImpl::didChangeContentsSize):
      * UIProcess/efl/PageClientLegacyImpl.cpp: Start calling WKViewClient callbacks instead of
      interacting directly with EwkView to avoid violating API layering.
      (WebKit::PageClientLegacyImpl::didChangeContentsSize):
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit):
      (WebKit::ViewClientEfl::toEwkView):
      (WebKit::ViewClientEfl::viewNeedsDisplay):
      (WebKit::ViewClientEfl::didChangeContentsSize):
      (WebKit::ViewClientEfl::ViewClientEfl):
      (WebKit::ViewClientEfl::~ViewClientEfl):
      * UIProcess/efl/ViewClientEfl.h: Introduce new ViewClientEfl which handles WKViewClient callbacks
      and interacts with EwkView.
      (WebKit):
      (ViewClientEfl):
      (WebKit::ViewClientEfl::create):
      * UIProcess/efl/WebView.cpp:
      (WebKit::WebView::initializeClient):
      (WebKit):
      (WebKit::WebView::setViewNeedsDisplay):
      (WebKit::WebView::didChangeContentsSize):
      * UIProcess/efl/WebView.h: Add new WebViewClient member and corresponding methods to interact
      with it.
      (WebView):
      * UIProcess/efl/WebViewClient.cpp:
      (WebKit):
      (WebKit::WebViewClient::viewNeedsDisplay):
      (WebKit::WebViewClient::didChangeContentsSize):
      * UIProcess/efl/WebViewClient.h: Add new WebViewClient APIClient for WKViewClient.
      (WebCore):
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9109c0e2
    • commit-queue@webkit.org's avatar
      [GTK][AC] Implement basic transform animations with clutter ac backend · d6082a03
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109363
      
      Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-02-13
      Reviewed by Gustavo Noronha Silva.
      
      Implement basic transform animation with clutter ac backend.
      GraphicsLayerClutter is almost same with GraphicsLayerCA. And PlatformClutterAnimation
      interfaces are also similar with PlatformCAAnimation, but they are implemented
      with native clutter APIs. Clutter backend AC supports a basic single transform animation
      with this patch now, but additive animation combination and keyframe animation
      are not supported yet.
      
      Covered by existing animation tests.
      
      * platform/graphics/clutter/GraphicsLayerActor.cpp:
      (graphicsLayerActorSetTransform):
      * platform/graphics/clutter/GraphicsLayerClutter.cpp:
      (WebCore::isTransformTypeTransformationMatrix):
      (WebCore):
      (WebCore::isTransformTypeFloatPoint3D):
      (WebCore::isTransformTypeNumber):
      (WebCore::getTransformFunctionValue):
      (WebCore::getValueFunctionNameForTransformOperation):
      (WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
      (WebCore::GraphicsLayerClutter::appendToUncommittedAnimations):
      (WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
      * platform/graphics/clutter/GraphicsLayerClutter.h:
      (GraphicsLayerClutter):
      * platform/graphics/clutter/PlatformClutterAnimation.cpp:
      (WebCore::toClutterActorPropertyString):
      (WebCore):
      (WebCore::PlatformClutterAnimation::supportsValueFunction):
      (WebCore::PlatformClutterAnimation::duration):
      (WebCore::PlatformClutterAnimation::setDuration):
      (WebCore::PlatformClutterAnimation::setAdditive):
      (WebCore::PlatformClutterAnimation::valueFunction):
      (WebCore::PlatformClutterAnimation::setValueFunction):
      (WebCore::PlatformClutterAnimation::setFromValue):
      (WebCore::PlatformClutterAnimation::setToValue):
      (WebCore::PlatformClutterAnimation::timeline):
      (WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
      (WebCore::PlatformClutterAnimation::addOpacityTransition):
      (WebCore::PlatformClutterAnimation::addTransformTransition):
      (WebCore::PlatformClutterAnimation::addAnimationForKey):
      * platform/graphics/clutter/PlatformClutterAnimation.h:
      (PlatformClutterAnimation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6082a03
    • mikhail.pozdnyakov@intel.com's avatar
      [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit · 11e21f9e
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109456
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      WebView destructor now considers the situation if its WebPageProxy
      instance had been closed from outside the class (explicitly
      by client code).
      
      * UIProcess/efl/WebView.cpp:
      (WebKit::WebView::~WebView):
      
      Tools:
      
      WebView instance must not live longer than EwkView, as EwkView owns
      objects that page proxy refers to, doing otherwise leads to a crash.
      
      Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
      leads to evas objects deletion. So, the problem was that test controller was
      deleted after ewk_shutdown() had been called in main() function causing
      crashes on WTR exit.
      
      The patch introduces a scope for test controller so that it is deleted first.
      
      * WebKitTestRunner/efl/main.cpp:
      (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11e21f9e
    • loislo@chromium.org's avatar
      Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report... · 58ccdb4d
      loislo@chromium.org authored
      Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
      https://bugs.webkit.org/show_bug.cgi?id=109554
      
      In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
      can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
      
      Drive by fix: I introduced a client interface for the HeapGraphSerializer.
      It helps me to do the tests for the serializer.
      
      Reviewed by Yury Semikhatsky.
      
      It is covered by newly added tests in TestWebKitAPI.
      
      Source/WebCore:
      
      * inspector/HeapGraphSerializer.cpp:
      (WebCore::HeapGraphSerializer::HeapGraphSerializer):
      (WebCore::HeapGraphSerializer::pushUpdate):
      (WebCore::HeapGraphSerializer::reportNode):
      (WebCore::HeapGraphSerializer::toNodeId):
      (WebCore::HeapGraphSerializer::addRootNode):
      * inspector/HeapGraphSerializer.h:
      (HeapGraphSerializer):
      (Client):
      (WebCore::HeapGraphSerializer::Client::~Client):
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore):
      (WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
      
      Tools:
      
      * TestWebKitAPI/TestWebKitAPI.gypi:
      * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
      (TestWebKitAPI):
      (HeapGraphReceiver):
      (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
      (TestWebKitAPI::HeapGraphReceiver::printGraph):
      (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
      (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
      (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
      (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
      (TestWebKitAPI::HeapGraphReceiver::serializer):
      (TestWebKitAPI::HeapGraphReceiver::chunkPart):
      (TestWebKitAPI::HeapGraphReceiver::dumpPart):
      (TestWebKitAPI::HeapGraphReceiver::stringValue):
      (TestWebKitAPI::HeapGraphReceiver::intValue):
      (TestWebKitAPI::HeapGraphReceiver::nodeToString):
      (TestWebKitAPI::HeapGraphReceiver::edgeToString):
      (TestWebKitAPI::HeapGraphReceiver::printNode):
      (Helper):
      (TestWebKitAPI::Helper::Helper):
      (TestWebKitAPI::Helper::addNode):
      (TestWebKitAPI::Helper::addEdge):
      (TestWebKitAPI::Helper::done):
      (Object):
      (TestWebKitAPI::Helper::Object::Object):
      (TestWebKitAPI::TEST):
      (Owner):
      (TestWebKitAPI::Owner::Owner):
      (TestWebKitAPI::Owner::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58ccdb4d
    • yurys@chromium.org's avatar
      Web Inspector: add experimental native heap graph to Timeline panel · b693bef8
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109687
      
      Reviewed by Alexander Pavlov.
      
      Added experimentatl support for native heap graph on the Timeline panel.
      Native memory usage data is collected after each top level task and can
      be displayed instead of DOM counters graph on the Timeline panel if
      corresponding experiment is enabled in the inspector settings.
      
      * inspector/Inspector.json:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      * inspector/InspectorTimelineAgent.cpp:
      (TimelineAgentState):
      (WebCore::InspectorTimelineAgent::setIncludeDomCounters):
      (WebCore):
      (WebCore::InspectorTimelineAgent::setIncludeNativeMemoryStatistics):
      (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
      (WebCore::InspectorTimelineAgent::setDOMCounters):
      (WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
      (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
      * inspector/InspectorTimelineAgent.h:
      (WebCore):
      (WebCore::InspectorTimelineAgent::create):
      (InspectorTimelineAgent):
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      * inspector/front-end/MemoryStatistics.js:
      (WebInspector.MemoryStatistics):
      * inspector/front-end/NativeMemoryGraph.js:
      (WebInspector.NativeMemoryGraph):
      (WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
      (WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
      * inspector/front-end/Settings.js:
      (WebInspector.ExperimentsSettings):
      * inspector/front-end/TimelinePanel.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b693bef8
    • commit-queue@webkit.org's avatar
      Web Inspector: Fixed colorpicker editing and scrolling. · b4a12b39
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109434.
      
      Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
      Reviewed by Alexander Pavlov.
      
      The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
      SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
      Added a special CSS class to mark the scroll target.
      
      No new tests.
      
      * inspector/front-end/SplitView.js:
      (WebInspector.SplitView):
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
      * inspector/front-end/TabbedPane.js:
      (WebInspector.TabbedPane):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4a12b39
    • atwilson@chromium.org's avatar
      Unreviewed chromium expectation changes resulting from r142719. · 4e64b230
      atwilson@chromium.org authored
      * platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
      * platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
      * platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e64b230
    • commit-queue@webkit.org's avatar
      Web Inspector: fix js compilation warnings in TextPrompt · 179b12f5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109685
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-13
      Reviewed by Alexander Pavlov.
      
      Mark last argument of _applySuggestion function as optional.
      
      No new tests: no change in behaviour.
      
      * inspector/front-end/TextPrompt.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      179b12f5
    • thiago.santos@intel.com's avatar
      [EFL] Unreviewed gardening. · ce6e391e
      thiago.santos@intel.com authored
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce6e391e
    • atwilson@chromium.org's avatar
      Unreviewed chromium expectation changes. · e3b4bfe7
      atwilson@chromium.org authored
      Fallout from r142683.
      
      * platform/chromium-win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b4bfe7
    • commit-queue@webkit.org's avatar
      Implement css-conditional's CSS.supports() · 05ccd1f7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100324
      
      Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-13
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      http://dev.w3.org/csswg/css3-conditional/#the-css-interface
      
      The supports() method provides the css @supports rule's corresponding
      dom api.
      The patch also adds the CSS interface on DOMWindow, which holds "useful
      CSS-related functions that do not belong elsewhere". This is where
      supports() lives.
      
      Test: css3/supports-dom-api.html
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/gobject/GNUmakefile.am:
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipFunction):
          Add DOMWindowCSS.* to the build systems.
      
      * bindings/scripts/CodeGenerator.pm:
      (WK_lcfirst):
          Handle CSS prefixes correctly (s/cSS/css/).
      
      * css/CSSGrammar.y.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::CSSParser):
      (WebCore::CSSParser::parseSupportsCondition):
      (WebCore::CSSParser::detectAtToken):
      * css/CSSParser.h:
          webkit_supports_condition parses just the condition part of an
          @supports rule and evaluates it, outputting whether the condition
          is supported or not.
      
      * css/CSSAllInOne.cpp:
      * css/DOMWindowCSS.cpp: Added.
      * css/DOMWindowCSS.h: Added.
      * css/DOMWindowCSS.idl: Added.
          The CSS interface object.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::css):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
          window.CSS
      
      LayoutTests:
      
      * css3/supports-dom-api-expected.txt: Added.
      * css3/supports-dom-api.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05ccd1f7
    • commit-queue@webkit.org's avatar
      Web Inspector: Simplify SplitView to rely more on CSS · c9cc8460
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109426
      
      Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
      Reviewed by Vsevolod Vlasov.
      
      Simplified Javascript code by moving large part of the layout logic into CSS rules. The patch is larger than it
      should be because one of the clients (TimelinePanel) is breaking SplitView incapsulation by reparenting its
      resizer.
      
      No new tests.
      
      * inspector/front-end/SidebarView.js:
      (WebInspector.SidebarView):
      * inspector/front-end/SplitView.js:
      (WebInspector.SplitView):
      (WebInspector.SplitView.prototype._innerSetVertical):
      (WebInspector.SplitView.prototype.setSecondIsSidebar):
      (WebInspector.SplitView.prototype._showOnly):
      (WebInspector.SplitView.prototype._removeAllLayoutProperties):
      * inspector/front-end/TimelinePanel.js:
      * inspector/front-end/cssNamedFlows.css:
      (.css-named-flow-collections-view .split-view-sidebar):
      (.css-named-flow-collections-view .split-view-sidebar .sidebar-content):
      (.css-named-flow-collections-view .split-view-sidebar .selection):
      (.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before, .css-named-flow-collections-view .region-empty:before, .css-named-flow-collections-view .region-fit::before, .css-named-flow-collections-view .region-overset::before):
      (.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before):
      * inspector/front-end/splitView.css:
      (.split-view-contents.maximized):
      (.split-view-vertical .split-view-contents):
      (.split-view-vertical .split-view-contents-first):
      (.split-view-vertical .split-view-contents-first.maximized):
      (.split-view-vertical .split-view-contents-second):
      (.split-view-vertical .split-view-contents-second.maximized):
      (.split-view-horizontal .split-view-contents):
      (.split-view-horizontal .split-view-contents-first):
      (.split-view-horizontal .split-view-contents-first.maximized):
      (.split-view-horizontal .split-view-contents-second):
      (.split-view-horizontal .split-view-contents-second.maximized):
      (.split-view-vertical .split-view-sidebar.split-view-contents-first:not(.maximized)):
      (.split-view-vertical .split-view-sidebar.split-view-contents-second:not(.maximized)):
      (.split-view-horizontal .split-view-sidebar.split-view-contents-first:not(.maximized)):
      (.split-view-horizontal .split-view-sidebar.split-view-contents-second:not(.maximized)):
      (.split-view-vertical .split-view-resizer):
      (.split-view-horizontal .split-view-resizer):
      * inspector/front-end/timelinePanel.css:
      (.timeline.split-view-vertical .split-view-resizer):
      (#timeline-container .split-view-sidebar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9cc8460
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r142730. · b51d47a9
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/142730
      https://bugs.webkit.org/show_bug.cgi?id=109666
      
      chromium browser tests are failing
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateNormalAttrGetter):
      (GenerateNormalAttrSetter):
      (GenerateSingleBatchedAttribute):
      (GenerateImplementation):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (TestInterfaceV8Internal):
      (WebCore):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b51d47a9
    • gyuyoung.kim@samsung.com's avatar
      [WK2] Remove web intents callbacks · f37e879b
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109654
      
      Reviewed by Benjamin Poulain.
      
      Web intents was removed by r142549.
      
      Source/WebKit2:
      
      * Shared/APIClientTraits.cpp:
      (WebKit):
      * Shared/APIClientTraits.h:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      (attachLoaderClientToView):
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/qt/QtBuiltinBundlePage.cpp:
      (WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
      
      Tools:
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createWebViewWithOptions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f37e879b
    • commit-queue@webkit.org's avatar
      OpenCL implementation of Flood SVG filters. · 518520b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109580
      
      Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-13
      Reviewed by Zoltan Herczeg.
      
      * Target.pri:
      * platform/graphics/filters/FEFlood.h:
      (FEFlood):
      * platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:
      (WebCore):
      (WebCore::PROGRAM_STR):
      (WebCore::FilterContextOpenCL::compileFill):
      (WebCore::FilterContextOpenCL::fill):
      * platform/graphics/gpu/opencl/FilterContextOpenCL.h:
      (WebCore::FilterContextOpenCL::FilterContextOpenCL):
      (FilterContextOpenCL):
      * platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Added.
      (WebCore):
      (WebCore::FEFlood::platformApplyOpenCL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      518520b4
    • mkwst@chromium.org's avatar
      location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings · 3997c7fb
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43891
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Other browsers (IE, Firefox, and Opera) throw an exception when accessing
      properties of a Location object across origins, as the spec suggests[1].
      WebKit is currently the outlier.
      
      This has a few negative effects: developers are forced to hack around
      access violations in two ways rather than having a single code path, and
      (more annoyingly) developers are unable to avoid generating the error
      message. See every ad on the internet for the effect on the console. :)
      
      This patch adds a SECURITY_ERR exception to these access violations,
      which is the first step towards getting rid of the console spam. Getting
      rid of the message entirely will require a solution to
      http://wkbug.com/98050.
      
      A fairly inconclusive thread[2] on webkit-dev popped up in 2010 and
      trailed off without reaching conclusion. A more recent thread reached
      agreement that this patch seems like a reasonable thing to do[3].
      
      This is the JSC half of the patch. V8 is coming in http://wkbug.com/43892
      
      [1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location
      [2]: https://lists.webkit.org/pipermail/webkit-dev/2010-August/013880.html
      [2]: https://lists.webkit.org/pipermail/webkit-dev/2012-February/023636.html
      
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::getOwnPropertySlotDelegate):
      
      LayoutTests:
      
      * http/tests/plugins/resources/cross-frame-object-access.html:
      * http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
      * http/tests/security/cross-frame-access-location-get-expected.txt:
      * http/tests/security/cross-frame-access-location-get.html:
      * http/tests/security/resources/cross-frame-access.js:
      (accessThrowsException):
      * http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
      * http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:
          Adjusting tests to check for exceptions, and adjusting expectations to match.
      * platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt.
      * platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Added.
      * platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Copied from LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt.
          V8 fails at the moment: http://wkbug.com/43892
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3997c7fb
    • vsevik@chromium.org's avatar
      Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was... · 7ad45bcf
      vsevik@chromium.org authored
      Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was causing other test failures.
      
      * inspector/script-execution-state-change-notification.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ad45bcf
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 1dadbd7e
      zandobersek@gmail.com authored
      Rebaselining tests after the DOM4 Events constructors and CSS image-set
      support were enabled.
      
      * platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
      * platform/gtk/fast/events/constructors: Added.
      * platform/gtk/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
      * platform/gtk/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
      * platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
      * platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
      * platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt:
      * platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
      * platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt:
      * platform/gtk/fast/hidpi/image-set-simple-expected.txt:
      * platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dadbd7e
    • atwilson@chromium.org's avatar
      Unreviewed Chromium gyp-file cleanup after glib backend removal. · eddaf60b
      atwilson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109672
      
      Removed references to GLib unicode backend:
      
      Source/WebCore:
      
      * WebCore.gypi:
      
      Source/WebKit/gtk:
      
      * gyp/Configuration.gypi.in:
      * gyp/Dependencies.gyp:
      * gyp/JavaScriptCore.gyp:
      * gyp/WTF.gyp:
      
      Source/WTF:
      
      * WTF.gyp/WTF.gyp:
      * WTF.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eddaf60b
    • haraken@chromium.org's avatar
      [V8] Generate wrapper methods for custom getters/setters · fc3a5285
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109666
      
      Reviewed by Adam Barth.
      
      Currently V8 directly calls back custom getters/setters written
      in custom binding files. This makes it impossible for code generators
      to hook custom getters/setters (e.g. Code generators cannot insert a code
      for FeatureObservation into custom getters/setters). We should generate
      wrapper methods for custom getters/setters.
      
      In the future, I will insert TRACE_EVENT() macros into these wrapper methods
      to profile DOM getters/setters/methods.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateNormalAttrGetter):
      (GenerateNormalAttrSetter):
      (GenerateSingleBatchedAttribute):
      (GenerateImplementation):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
      (TestInterfaceV8Internal):
      (WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
      (WebCore):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::customAttrAttrGetter):
      (TestObjV8Internal):
      (WebCore::TestObjV8Internal::customAttrAttrSetter):
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc3a5285
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skip failing tests. · b34d594b
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b34d594b
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r142611. · 6f077689
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/142611
      https://bugs.webkit.org/show_bug.cgi?id=109668
      
      Suggest box is not shown anymore when user types "window." in
      inspector console. (Requested by vsevik on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
      
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPrompt.prototype.complete):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f077689
    • haraken@chromium.org's avatar
      [V8] There is no XXXConstructor that requires a custom getter · b8e556fd
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109667
      
      Reviewed by Adam Barth.
      
      Currently '[Custom] attribute XXXConstructor xxx' generates
      XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
      In addition, it does make no sense to generate XXXAttrGetter() for such cases.
      We can remove the logic from CodeGeneratorV8.pm.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateSingleBatchedAttribute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8e556fd
    • morrita@google.com's avatar
      [Internals] setShadowDOMEnabled() shouldn't be used except a few tests. · 5990b794
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109642
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      InternalSettings.setShadowDOMEnabled() shouldn't be called after
      any relevant DOM bindings are touched. However for fuzzers, it
      isn't trivial to regulate its behavior.
      
      This change whitelists the URL of running test for prevent
      unintended API calls. This doesn't hurt the Internals usability
      since the API is called from just a couple of tests and the number
      isn't expected to grow.
      
      Test: fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html
      
      * testing/InternalSettings.cpp:
      (WebCore::urlIsWhitelisted):
      (WebCore):
      (WebCore::InternalSettings::setShadowDOMEnabled):
      
      LayoutTests:
      
      * fast/dom/shadow/shadow-dom-enabled-flag-whitelist-expected.txt: Added.
      * fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5990b794
    • vsevik@chromium.org's avatar
      Web Inspector: Introduce version controller to migrate settings versions. · 0f57043b
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109553
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      This patch introduces version controller that could be used to migrate inspector settings.
      
      Test: inspector/version-controller.html
      
      * inspector/front-end/Settings.js:
      (WebInspector.Settings):
      (WebInspector.VersionController):
      (WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
      (WebInspector.VersionController.prototype._updateVersionFrom0To1):
      * inspector/front-end/inspector.js:
      
      LayoutTests:
      
      * inspector/version-controller-expected.txt: Added.
      * inspector/version-controller.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f57043b
  2. 12 Feb, 2013 9 commits
    • commit-queue@webkit.org's avatar
      [GTK] Remove the GLib unicode backend · f9b3c2e3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109627
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
      Reviewed by Benjamin Poulain.
      
      .:
      
      Remove references to the GLib unicode backend from configuration.
      
      * Source/autotools/FindDependencies.m4:
      * Source/autotools/ReadCommandLineArguments.m4:
      * Source/autotools/SetupAutoconfHeader.m4:
      * Source/autotools/SetupAutomake.m4:
      
      Source/WebCore:
      
      Remove references to the GLib unicode backend from WebCore.
      
      * GNUmakefile.list.am: Update the source list.
      * platform/text/gtk/TextBreakIteratorGtk.cpp: Removed.
      * platform/text/gtk/TextCodecGtk.cpp: Removed.
      * platform/text/gtk/TextCodecGtk.h: Removed.
      
      Source/WTF:
      
      Remove references to the GLib unicode backend from WTF.
      
      * GNUmakefile.list.am: Remove GLib unicode files from the source list.
      * wtf/unicode/glib/UnicodeGLib.cpp: Removed.
      * wtf/unicode/glib/UnicodeGLib.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9b3c2e3
    • fpizlo@apple.com's avatar
      Eradicate fast/js/dfg-poison-fuzz.html · 7f1ce6e7
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109660
      
      Unreviewed.
              
      I haven't seen this test fail in ages.  And I've seen a lot of DFG bugs!
      
      This is a super expensive test for one bug that used to be in the DFG but that has
      since been thoroughly eradicated. Likely the plethora of other DFG tests cover that
      bug. Heck, I'm not even sure if the code that this covers is even in the repository
      anymore.
      
      In the spirit of not having super expensive and mostly useless tests, I'm removing
      this test.
      
      * fast/js/dfg-poison-fuzz-expected.txt: Removed.
      * fast/js/dfg-poison-fuzz.html: Removed.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-poison-fuzz.js: Removed.
      * platform/chromium/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt-mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f1ce6e7
    • lforschler@apple.com's avatar
      Versioning. · 26cee0c4
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26cee0c4
    • cfleizach@apple.com's avatar
      AX: crash when accessing AccessibilityScrollbar after page has been unloaded · 0ba89b10
      cfleizach@apple.com authored
       https://bugs.webkit.org/show_bug.cgi?id=109524
      
       Reviewed by Ryosuke Niwa.
      
       AX clients can hold onto AccesibilityScrollbar references that reference parent
       AccessibilityScrollViews that have already gone away.
      
       AccessibilityScrollView is not calling detachFromParent after it is removed, which
       leads to a crash. The fix is to clearChildren() when an object is deallocated.
      
       I could not create a test because the crash only manifests over multiple page loads.
      
       * accessibility/AccessibilityObject.cpp:
       (WebCore::AccessibilityObject::detach):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ba89b10
    • hayato@chromium.org's avatar
      Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator. · 3fdf2dd7
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109650
      
      Reviewed by Dimitri Glazkov.
      
      Set FocusEvent.relatedTarget in its constructor so that each
      EventDispatchMediator can use FocusEvent.relatedTarget rather than
      its redundant m_{old,new}FocusedNode member variable.
      
      I've also removed FIXME comments, mentioning bug 109261, since I
      can not reproduce the issue.
      
      No new tests. No change in functionality.
      
      * dom/FocusEvent.cpp:
      (WebCore::FocusEventDispatchMediator::create):
      (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
      (WebCore::FocusEventDispatchMediator::dispatchEvent):
      (WebCore::BlurEventDispatchMediator::create):
      (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
      (WebCore::BlurEventDispatchMediator::dispatchEvent):
      (WebCore::FocusInEventDispatchMediator::create):
      (WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
      (WebCore::FocusInEventDispatchMediator::dispatchEvent):
      (WebCore::FocusOutEventDispatchMediator::create):
      (WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
      (WebCore::FocusOutEventDispatchMediator::dispatchEvent):
      * dom/FocusEvent.h:
      (FocusEventDispatchMediator):
      (BlurEventDispatchMediator):
      (FocusInEventDispatchMediator):
      (FocusOutEventDispatchMediator):
      * dom/Node.cpp:
      (WebCore::Node::dispatchFocusInEvent):
      (WebCore::Node::dispatchFocusOutEvent):
      (WebCore::Node::dispatchFocusEvent):
      (WebCore::Node::dispatchBlurEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fdf2dd7
    • commit-queue@webkit.org's avatar
      Remove unnecessary and confusing includes from StreamBuffer.h. · 73c8c59e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109652
      
      Patch by Takeshi Yoshino <tyoshino@google.com> on 2013-02-12
      Reviewed by Benjamin Poulain.
      
      StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
      FixedArray.h and PassOwnPtr.h are included but not used.
      
      VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
      So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
      is even slower).
      
      * wtf/StreamBuffer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73c8c59e
    • tasak@google.com's avatar
      [Refactoring] Make SelectorChecker::mode a constructor parameter. · 2ed5096c
      tasak@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109653
      
      Reviewed by Dimitri Glazkov.
      
      No new tests, because just refactoring.
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::SelectorChecker):
      Made mode a constructor parameter.
      * css/SelectorChecker.h:
      Removed setMode.
      (SelectorChecker):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::ruleMatches):
      (WebCore::StyleResolver::checkRegionSelector):
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorQuery::matches):
      (WebCore::SelectorQuery::queryAll):
      (WebCore::SelectorQuery::queryFirst):
      * html/shadow/ContentSelectorQuery.cpp:
      (WebCore::ContentSelectorChecker::ContentSelectorChecker):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ed5096c
    • commit-queue@webkit.org's avatar
      [Chromium] Rebaseline suggestion-picker layout tests · 10f3adff
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109647
      
      Unreviewed rebaseline.
      Text position differences, imperceptible to human sight.
      Test failures possibly caused by: http://trac.webkit.org/changeset/142659
      
      Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-12
      
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10f3adff
    • akling@apple.com's avatar
      Remove Element::ensureAttributeData(). · cc196e55
      akling@apple.com authored
      <http://webkit.org/b/109643>
      
      Reviewed by Anders Carlsson.
      
      * dom/Element.h:
      * dom/Element.cpp:
      (WebCore::Element::classAttributeChanged):
      (WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
      
          Use attributeData() instead of ensureAttributeData(), it's already guaranteed to exist in
          both these functions as they are called in response to attribute changes.
      
      * svg/SVGElement.h:
      (WebCore::SVGElement::invalidateSVGAttributes):
      
          Use mutableAttributeData() instead of ensureAttributeData() when invalidating animated
          SVG attributes. While I can't find any bugs caused by this, an element with property animations
          shouldn't share attribute data with other elements.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc196e55