1. 11 Jul, 2012 40 commits
    • fpizlo@apple.com's avatar
      DFG should have fast virtual calls · 5e135773
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90924
      
      Source/JavaScriptCore: 
      
      Reviewed by Gavin Barraclough.
              
      Implements virtual call support in the style of the old JIT, with the
      caveat that we still use the same slow path for both InternalFunction
      calls and JSFunction calls. Also rationalized the way that our
      CodeOrigin indices tie into exception checks (previously it was a
      strange one-to-one mapping with fairly limited assertions; now it's a
      one-to-many mapping for CodeOrigins to exception checks, respectively).
      I also took the opportunity to clean up
      CallLinkInfo::callReturnLocation, which previously was either a Call or
      a NearCall. Now it's just a NearCall. As well, exceptions during slow
      path call resolution are now handled by returning an exception throwing
      thunk rather than returning null. And finally, I made a few things
      public that were previously private-with-lots-of-friends, because I
      truly despise the thought of listing each thunk generating function as
      a friend of JSValue and friends.
              
      * bytecode/CallLinkInfo.cpp:
      (JSC::CallLinkInfo::unlink):
      * bytecode/CallLinkInfo.h:
      (CallLinkInfo):
      * bytecode/CodeOrigin.h:
      (JSC::CodeOrigin::CodeOrigin):
      (JSC::CodeOrigin::isSet):
      * dfg/DFGAssemblyHelpers.h:
      (JSC::DFG::AssemblyHelpers::AssemblyHelpers):
      * dfg/DFGCCallHelpers.h:
      (JSC::DFG::CCallHelpers::CCallHelpers):
      * dfg/DFGGPRInfo.h:
      (GPRInfo):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::link):
      (JSC::DFG::JITCompiler::compileFunction):
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::CallBeginToken::CallBeginToken):
      (JSC::DFG::CallBeginToken::~CallBeginToken):
      (CallBeginToken):
      (JSC::DFG::CallBeginToken::set):
      (JSC::DFG::CallBeginToken::registerWithExceptionCheck):
      (JSC::DFG::CallBeginToken::codeOrigin):
      (JSC::DFG::CallExceptionRecord::CallExceptionRecord):
      (CallExceptionRecord):
      (JSC::DFG::JITCompiler::currentCodeOriginIndex):
      (JITCompiler):
      (JSC::DFG::JITCompiler::beginCall):
      (JSC::DFG::JITCompiler::notifyCall):
      (JSC::DFG::JITCompiler::prepareForExceptionCheck):
      (JSC::DFG::JITCompiler::addExceptionCheck):
      (JSC::DFG::JITCompiler::addFastExceptionCheck):
      * dfg/DFGOperations.cpp:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::dfgLinkFor):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::emitCall):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::emitCall):
      * dfg/DFGThunks.cpp:
      (JSC::DFG::emitPointerValidation):
      (DFG):
      (JSC::DFG::throwExceptionFromCallSlowPathGenerator):
      (JSC::DFG::slowPathFor):
      (JSC::DFG::linkForThunkGenerator):
      (JSC::DFG::linkCallThunkGenerator):
      (JSC::DFG::linkConstructThunkGenerator):
      (JSC::DFG::virtualForThunkGenerator):
      (JSC::DFG::virtualCallThunkGenerator):
      (JSC::DFG::virtualConstructThunkGenerator):
      * dfg/DFGThunks.h:
      (DFG):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompile):
      (JSC::JIT::linkFor):
      * runtime/Executable.h:
      (ExecutableBase):
      (JSC::ExecutableBase::offsetOfJITCodeFor):
      (JSC::ExecutableBase::offsetOfNumParametersFor):
      * runtime/JSValue.h:
      (JSValue):
      
      LayoutTests: 
      
      Rubber stamped by Oliver Hunt.
      
      This changes which piece of code appears on top of the stack at the point of a stack
      overflow. As far as Oliver and I can tell, it doesn't matter, so I just rebased the
      test.
      
      * fast/js/stack-trace-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e135773
    • simon.fraser@apple.com's avatar
      Add an option to enter paginated mode in MiniBrowser · ca8621e4
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91035
      
      Reviewed by Dan Bernstein.
      
      Add an item to the Debug menu for MiniBrowser that puts
      the web view into paginated mode. For now, we only
      do left-to-right pagination, with a fixed column width.
      
      * MiniBrowser/mac/BrowserWindowController.h:
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController validateMenuItem:]): Update the checked
      state of the menu item.
      (-[BrowserWindowController isPaginated]): Return YES if paginated.
      (-[BrowserWindowController togglePaginationMode:]): Toggle in
      and out of pagination mode.
      * MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca8621e4
    • abarth@webkit.org's avatar
      commit-queue instances on Compute Engine are missing git-svn · cbe676cf
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91034
      
      Reviewed by Eric Seidel.
      
      git-svn is needed to actually commit to SVN from a git working copy.
      
      * EWSTools/cold-boot.sh:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbe676cf
    • shinyak@chromium.org's avatar
      SVGUseElement should not use Element::ensureShadowRoot(). · fff9e371
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90938
      
      Reviewed by Hajime Morita.
      
      We would like to remove Element::ensureShadowRoot() because we would like to stabilize the lifecycle of Shadow DOM.
      This patch rewrites SVGUseElement::create() not to use Element::ensureShadowRoot(). Since our convention to create
      a shadow subtree is to create a method createShadowSubtree(), I obeyed it.
      
      No new tests. Simple refactoring.
      
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::create):
      (WebCore::SVGUseElement::createShadowSubtree):
      (WebCore):
      * svg/SVGUseElement.h:
      (SVGUseElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fff9e371
    • fpizlo@apple.com's avatar
      Accidentally used the wrong license (3-clause instead of 2-clause) in some · 3a264a17
      fpizlo@apple.com authored
      files I just committed.
      
      Rubber stamped by Oliver Hunt.
      
      * bytecode/Watchpoint.cpp:
      * bytecode/Watchpoint.h:
      * jit/JumpReplacementWatchpoint.cpp:
      * jit/JumpReplacementWatchpoint.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a264a17
    • dpranke@chromium.org's avatar
      webkitpy: lint code in webkitpy.layout_tests.models · e0b150fc
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90416
      
      Reviewed by Ojan Vafai.
      
      Cleaning up errors reported from lint-webkitpy.
      
      Also, suppress the warnings about wildcard imports in pylintrc;
      we have nothing particularly against them.
      
      * Scripts/webkitpy/layout_tests/models/test_configuration.py:
      (TestConfigurationConverter.combinations):
      * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
      (TestConfigurationTest.test_hash.query_unknown_key):
      (TestConfigurationTest.test_eq):
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (ParseError.__init__):
      (TestExpectationLine.__init__):
      (TestExpectationsModel.get_expectations_string):
      (TestExpectationsModel):
      (TestExpectationsModel.expectation_to_string):
      (TestExpectationsModel.add_expectation_line):
      (TestExpectationsModel._clear_expectations_for_test):
      (TestExpectationsModel._remove_from_sets):
      (TestExpectations.get_expectations_string):
      (TestExpectations.expectation_to_string):
      (TestExpectations._report_warnings):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (Base.__init__):
      (parse_exp):
      (SkippedTests.check):
      (TestExpectationParserTests.test_parse_empty_string):
      * Scripts/webkitpy/layout_tests/models/test_failures.py:
      (FailureTimeout.__init__):
      (FailureCrash.__init__):
      (FailureImageHashMismatch.__init__):
      (FailureReftestMismatch.__init__):
      (FailureReftestMismatchDidNotOccur.__init__):
      (FailureReftestNoImagesGenerated.__init__):
      * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
      (TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
      (TestFailuresTest.test_unknown_failure_type):
      (TestFailuresTest):
      (TestFailuresTest.test_message_is_virtual):
      * Scripts/webkitpy/layout_tests/models/test_results.py:
      (TestResult.loads):
      (TestResult.has_failure_matching_types):
      * Scripts/webkitpy/pylintrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0b150fc
    • abarth@webkit.org's avatar
      Unreviewed. Remove empty directories. · 68ca2d8b
      abarth@webkit.org authored
      * http/tests/websocket/tests/resources: Removed.
      * http/tests/websocket/tests/script-tests: Removed.
      * http/tests/websocket/tests/workers: Removed.
      * http/tests/websocket/tests/workers/resources: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68ca2d8b
    • fpizlo@apple.com's avatar
      Watchpoints and jump replacement should be decoupled · 3d949155
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91016
      
      Reviewed by Oliver Hunt.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * assembler/AbstractMacroAssembler.h:
      (JSC):
      (Label):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::appendWatchpoint):
      (JSC::CodeBlock::watchpoint):
      (DFGData):
      * bytecode/Watchpoint.cpp:
      (JSC):
      * bytecode/Watchpoint.h:
      (JSC::Watchpoint::Watchpoint):
      (Watchpoint):
      (JSC::Watchpoint::fire):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::speculationWatchpoint):
      * jit/JumpReplacementWatchpoint.cpp: Added.
      (JSC):
      (JSC::JumpReplacementWatchpoint::correctLabels):
      (JSC::JumpReplacementWatchpoint::fireInternal):
      * jit/JumpReplacementWatchpoint.h: Added.
      (JSC):
      (JumpReplacementWatchpoint):
      (JSC::JumpReplacementWatchpoint::JumpReplacementWatchpoint):
      (JSC::JumpReplacementWatchpoint::setDestination):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d949155
    • dpranke@chromium.org's avatar
      nrwt: clean up names in worker.py · 033be8d2
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90510
      
      Reviewed by Ojan Vafai.
      
      This is the last patch in the series of refactoring worker.py;
      all this does is change some names of methods, instance
      variables, and method parameters to be clearer (it also changes
      some code in manager.py and manager_worker.py to be consistent).
      
      There are no functional changes in this patch and the existing
      tests should cover everything.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.__init__):
      (Manager.prepare_lists_and_print_output):
      (Manager._run_tests.worker_factory):
      (Manager._run_tests):
      (Manager._show_results_html_file):
      (Manager.handle_finished_test_list):
      (_WorkerState.__init__):
      * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
      (_Broker.post_message):
      (_Broker._dispatch_message):
      (AbstractWorker.__init__):
      (AbstractWorker.run):
      (AbstractWorker.yield_to_caller):
      (AbstractWorker.post):
      (_WorkerConnection.__init__):
      * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
      (_TestWorker.__init__):
      (_TestWorker.start):
      (_TestWorker.handle):
      (_TestWorker.stop):
      (_TestsMixin):
      (_TestsMixin.test_name):
      * Scripts/webkitpy/layout_tests/controllers/worker.py:
      (Worker.__init__):
      (Worker.__del__):
      (Worker.start):
      (Worker.handle):
      (Worker._run_test):
      (Worker.stop):
      (Worker._timeout):
      (Worker._kill_driver):
      (Worker._run_test_with_timeout):
      (Worker._clean_up_after_test):
      (Worker._run_test_in_another_thread.SingleTestThread.run):
      (Worker._run_test_in_this_thread):
      (Worker._run_single_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      033be8d2
    • commit-queue@webkit.org's avatar
      [chromium] Move compositor quads to Platform/chromium/public · 60dbc106
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90582
      
      Patch by Alexandre Elias <aelias@google.com> on 2012-07-11
      Reviewed by Adrienne Walker.
      
      This moves CCSharedQuadState, CCDrawQuad, and all but two CC*DrawQuad
      classes to the WebKit namespace, as a first step to pushing them
      across the process boundary for the ubercompositor.
      
      - The intent is to serialize the class hierarchy using the same
      mechanism as WebInputEvent.  In order to do this, there are three
      requirements: pure POD data, a method returning size, and a packing
      pragma.
      
      - Private data members are fine with this kind of serializer, and a
      default constructor is not needed.  Because of that, we can maintain
      the same encapsulation and convenient APIs (behind
      WEBKIT_IMPLEMENTATION) as the original classes.  To ease the
      transition, the original WebCore headers still exist and typedef to
      the new classes.
      
      - However, SharedQuadState will be serialized using the normal
      IPC_STRUCT_TRAITS macro, so I made its members public.  A custom
      serializer (on quad lists) will maintain the pointers from quads to
      SharedQuadStates.
      
      - I converted the Material casting mechanism to materialCast() methods
      living in the derived classes.  That way, the WebCompositorQuad header
      doesn't need to know about all its derived classes.
      
      - Quad classes not yet transitioned can still be used in
      non-ubercompositor mode.  CCRenderPassDrawQuad and CCYUVVideoDrawQuad
      are currently non-POD and I left them in their original files.
      
      This approach is the best I've found so far, since it preserves all
      WebCore-facing APIs and avoids unnecessary code duplication (new quad
      types or members can be added by modifying only one place).  There
      also should not be an unreasonable amount of custom serializer code
      required.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/WebCompositorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCDrawQuad.h.
      (WebKit):
      (WebCompositorQuad):
      (WebKit::WebCompositorQuad::quadRect):
      (WebKit::WebCompositorQuad::quadTransform):
      (WebKit::WebCompositorQuad::layerTransform):
      (WebKit::WebCompositorQuad::layerRect):
      (WebKit::WebCompositorQuad::scissorRect):
      (WebKit::WebCompositorQuad::opacity):
      (WebKit::WebCompositorQuad::needsBlending):
      (WebKit::WebCompositorQuad::isLayerAxisAlignedIntRect):
      (WebKit::WebCompositorQuad::quadVisibleRect):
      (WebKit::WebCompositorQuad::isDebugQuad):
      (WebKit::WebCompositorQuad::material):
      (WebKit::WebCompositorQuad::sharedQuadState):
      (WebKit::WebCompositorQuad::setSharedQuadState):
      * chromium/public/WebCompositorSharedQuadState.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.
      (WebKit):
      (WebCompositorSharedQuadState):
      * chromium/public/WebCompositorSolidColorQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.h.
      (WebKit):
      (WebCompositorSolidColorQuad):
      (WebKit::WebCompositorSolidColorQuad::color):
      * chromium/public/WebCompositorTextureQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.h.
      (WebKit):
      (WebCompositorTextureQuad):
      (WebKit::WebCompositorTextureQuad::uvRect):
      (WebKit::WebCompositorTextureQuad::textureId):
      (WebKit::WebCompositorTextureQuad::premultipliedAlpha):
      (WebKit::WebCompositorTextureQuad::flipped):
      
      Source/WebCore:
      
      No new tests. (No-op refactoring.)
      
      * WebCore.gypi:
      * platform/chromium/support/WebCompositorQuad.cpp: Added.
      (WebKit):
      (WebKit::WebCompositorQuad::WebCompositorQuad):
      (WebKit::WebCompositorQuad::opaqueRect):
      (WebKit::WebCompositorQuad::setQuadVisibleRect):
      (WebKit::WebCompositorQuad::size):
      * platform/chromium/support/WebCompositorSharedQuadState.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.cpp.
      (WebKit):
      (WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
      (WebKit::WebCompositorSharedQuadState::create):
      (WebKit::WebCompositorSharedQuadState::isLayerAxisAlignedIntRect):
      * platform/chromium/support/WebCompositorSolidColorQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp.
      (WebKit):
      (WebKit::WebCompositorSolidColorQuad::create):
      (WebKit::WebCompositorSolidColorQuad::WebCompositorSolidColorQuad):
      (WebKit::WebCompositorSolidColorQuad::materialCast):
      * platform/chromium/support/WebCompositorTextureQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureDrawQuad.cpp.
      (WebKit):
      (WebKit::WebCompositorTextureQuad::create):
      (WebKit::WebCompositorTextureQuad::WebCompositorTextureQuad):
      (WebKit::WebCompositorTextureQuad::setNeedsBlending):
      (WebKit::WebCompositorTextureQuad::materialCast):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawQuad):
      * platform/graphics/chromium/LayerRendererChromium.h:
      * platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp:
      (WebCore::CCCheckerboardDrawQuad::create):
      (WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
      (WebCore::CCCheckerboardDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:
      (CCCheckerboardDrawQuad):
      * platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
      (WebCore::CCDebugBorderDrawQuad::create):
      (WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
      (WebCore::CCDebugBorderDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:
      (CCDebugBorderDrawQuad):
      * platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
      * platform/graphics/chromium/cc/CCDrawQuad.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp:
      (WebCore::CCIOSurfaceDrawQuad::create):
      (WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):
      (WebCore::CCIOSurfaceDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:
      (CCIOSurfaceDrawQuad):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCRenderPass.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
      (WebCore::CCRenderPassDrawQuad::create):
      (WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
      (WebCore::CCRenderPassDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
      (CCRenderPassDrawQuad):
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCSharedQuadState.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp:
      (WebCore::CCStreamVideoDrawQuad::create):
      (WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):
      (WebCore::CCStreamVideoDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:
      (CCStreamVideoDrawQuad):
      * platform/graphics/chromium/cc/CCTextureDrawQuad.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
      (WebCore::CCTileDrawQuad::create):
      (WebCore::CCTileDrawQuad::CCTileDrawQuad):
      (WebCore::CCTileDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCTileDrawQuad.h:
      (CCTileDrawQuad):
      * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:
      (WebCore::CCYUVVideoDrawQuad::create):
      (WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
      (WebCore::CCYUVVideoDrawQuad::materialCast):
      (WebCore):
      * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:
      (CCYUVVideoDrawQuad):
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTestCommon.cpp:
      (CCLayerTestCommon::verifyQuadsExactlyCoverRect):
      * tests/CCSolidColorLayerImplTest.cpp:
      (CCLayerTestCommon::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60dbc106
    • rjkroege@chromium.org's avatar
      [chromium] [regression] Don't use ScrollByPrecisePixels on Chromium Mac. · 9c82f6d1
      rjkroege@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91020
      
      Reviewed by Adam Barth.
      
      A change in https://bugs.webkit.org/show_bug.cgi?id=87535 to
      improve the operation of smooth scrolling incorrectly caused
      Chromium Mac to use the wrong scroll granularity on
      hasPreciseScrollingDeltas() == true wheelevent scrolls.
      Exclude the change on the Chromium Mac platform.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::handleWheelEvent): Adjusted #ifdef to exclude Chromium
      Mac from ScrollByPrecisePixels change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c82f6d1
    • abarth@webkit.org's avatar
      The commit-queue needs some extra git config to be able to commit · 12c6be9d
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91025
      
      Reviewed by Eric Seidel.
      
      In order for the commit-queue to actually commit, it needs to know the
      location of the SVN server.
      
      * EWSTools/cold-boot.sh:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12c6be9d
    • jpu@apple.com's avatar
      On Mac, autocorrection sometimes fails to take place in Safari. · e6acfe93
      jpu@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89982
      
      Reviewed by Ryosuke Niwa.
      
      We should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
      early return in markAndReplaceFor(). Also, since we don't want autocorrection to happen when we only change selection,
      not the content, so we shouldn't set TextCheckingTypeCorrection flag in markMisspellingsAndBadGrammar() as this function
      is triggered only by selection change.
      
      * editing/Editor.cpp:
      (WebCore::Editor::markAndReplaceFor):
      (WebCore::Editor::markMisspellingsAndBadGrammar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6acfe93
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r122361. · 9ec3225c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/122361
      https://bugs.webkit.org/show_bug.cgi?id=91027
      
      Broke Windows build and fast/forms/state-restore-broken-
      state.html (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-11
      
      * testing/Internals.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ec3225c
    • abarth@webkit.org's avatar
      Teach EWSTools how to configure SVN auth credentials · d49d36e0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91021
      
      Reviewed by Eric Seidel.
      
      To move the commit-queue over to Google Compute Engine, we need a way
      to configure the commit-queue's credentials during the machine build
      process. There doesn't seem to be a nice command line way of
      configuring SVN auth credentials. I tried doing a bogus commit and
      supplying the credentials that way, but that's super hacky.
      
      The approach in this patch is to write the config file directly. The
      format of these configurations files is documented in the SVN book, so
      this approach doesn't see too sketchy.
      
      * EWSTools/configure-svn-auth.sh: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d49d36e0
    • simon.fraser@apple.com's avatar
      Assertion ASSERTION FAILED: enclosingIntRect(rendererMappedResult) ==... · 56e37049
      simon.fraser@apple.com authored
      Assertion ASSERTION FAILED: enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()) when compositing in paginated mode
      https://bugs.webkit.org/show_bug.cgi?id=90919
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      r121124 added a fast path for geometry mapping that goes via layers
      when possible. However, this broke paginated pages, which put
      the root (RenderView) layer into column mode, because it failed
      to check for columns on the ancestor layer.
      
      Rather than make a risky change to convertToLayerCoords(), add a local
      function canMapViaLayer(), which is like RenderLayer::canUseConvertToLayerCoords(),
      but doesn't check for compositing (compositing itself is not a reason
      to avoid convertToLayerCoords). Call canMapViaLayer() with the ancestorLayer
      to check whether the ancestor has columns, which fixes the bug.
      
      Test: compositing/columns/geometry-map-paginated-assert.html
      
      * rendering/RenderGeometryMap.cpp:
      (WebCore::canMapViaLayer):
      (WebCore::RenderGeometryMap::pushMappingsToAncestor):
      
      LayoutTests:
      
      Test with a composited element in a document which is put into paginated mode.
      
      * compositing/columns/geometry-map-paginated-assert-expected.txt: Added.
      * compositing/columns/geometry-map-paginated-assert.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e37049
    • ojan@chromium.org's avatar
      Dedupe suffixes passed to webkit-patch rebaseline · 823b7770
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91017
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (Rebaseline._suffixes_to_update):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (test_rebaseline_multiple_builders_and_tests_command_line):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      823b7770
    • ojan@chromium.org's avatar
      Simplify css3/flexbox/repaint-rtl-column.html · ad35c5bf
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91011
      
      Reviewed by Tony Chang.
      
      This test was doing something simple in a complicated way. Also, removing
      the text should make it so that more ports can fallback to the same png.
      
      * css3/flexbox/repaint-rtl-column-expected.txt:
      * css3/flexbox/repaint-rtl-column.html:
      * platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad35c5bf
    • danakj@chromium.org's avatar
      [chromium] Rename layerRect to contentRect for rects that live in content space · 87eeabf4
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90843
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Dropped the layerTransform() from CCSharedQuadState, as nothing should be
      using it to draw with. RenderPasses need a weird drawTransform right now
      which was stored in layerTransform, so moved this to the RenderPass quad.
      
      No new tests. No change in behaviour.
      
      * platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
      (WebCore::CanvasLayerTextureUpdater::paintContents):
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::update):
      (WebCore::ContentLayerChromium::needMoreUpdates):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerChromium::update):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::visibleContentOpaqueRegion):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::visibleContentRect):
      (WebCore::LayerChromium::setVisibleContentRect):
      (LayerChromium):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawRenderPassQuad):
      (WebCore::LayerRendererChromium::drawTileQuad):
      (WebCore::LayerRendererChromium::drawYUVVideoQuad):
      (WebCore::LayerRendererChromium::drawStreamVideoQuad):
      (WebCore::LayerRendererChromium::drawIOSurfaceQuad):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::updateBounds):
      (WebCore::TiledLayerChromium::setNeedsDisplayRect):
      (WebCore::TiledLayerChromium::invalidateContentRect):
      (WebCore::TiledLayerChromium::updateTiles):
      (WebCore::TiledLayerChromium::setTexturePriorities):
      (WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
      (WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
      (WebCore::TiledLayerChromium::updateContentRect):
      (WebCore::TiledLayerChromium::needsIdlePaint):
      (WebCore::TiledLayerChromium::idlePaintRect):
      * platform/graphics/chromium/TiledLayerChromium.h:
      (TiledLayerChromium):
      * platform/graphics/chromium/cc/CCDrawQuad.h:
      (WebCore::CCDrawQuad::visibleContentRect):
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::createSharedQuadState):
      (WebCore::CCLayerImpl::appendDebugBorderQuad):
      (WebCore::CCLayerImpl::visibleContentOpaqueRegion):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::visibleContentRect):
      (WebCore::CCLayerImpl::setVisibleContentRect):
      (CCLayerImpl):
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::contentRectToTileIndices):
      (WebCore::CCLayerTilingData::opaqueRegionInContentRect):
      (WebCore::CCLayerTilingData::setBounds):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      (CCLayerTilingData):
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
      (WebCore::calculateVisibleContentRect):
      (WebCore::layerShouldBeSkipped):
      (WebCore):
      (WebCore::calculateVisibleAndScissorRectsInternal):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
      * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
      (WebCore::addOcclusionBehindLayer):
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
      (WebCore::CCRenderPassDrawQuad::create):
      (WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
      * platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
      (CCRenderPassDrawQuad):
      (WebCore::CCRenderPassDrawQuad::drawTransform):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::createSharedQuadState):
      (WebCore::CCRenderSurface::createReplicaSharedQuadState):
      (WebCore::CCRenderSurface::appendQuads):
      * platform/graphics/chromium/cc/CCSharedQuadState.cpp:
      (WebCore::CCSharedQuadState::create):
      (WebCore::CCSharedQuadState::CCSharedQuadState):
      (WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):
      * platform/graphics/chromium/cc/CCSharedQuadState.h:
      (CCSharedQuadState):
      (WebCore::CCSharedQuadState::visibleContentRect):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::appendQuads):
      (WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
      
      Source/WebKit/chromium:
      
      * tests/CCLayerImplTest.cpp:
      (WebCore::TEST):
      * tests/CCLayerTreeHostCommonTest.cpp:
      * tests/CCLayerTreeHostImplTest.cpp:
      * tests/CCOcclusionTrackerTest.cpp:
      (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
      (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
      (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
      * tests/CCQuadCullerTest.cpp:
      * tests/CCRenderSurfaceTest.cpp:
      * tests/CCSolidColorLayerImplTest.cpp:
      (CCLayerTestCommon::TEST):
      * tests/CCTiledLayerImplTest.cpp:
      (CCLayerTestCommon::createLayer):
      (CCLayerTestCommon::TEST):
      (CCLayerTestCommon::getQuads):
      (CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
      (CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
      * tests/CCTiledLayerTestCommon.cpp:
      (WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
      (WebKitTests::FakeTiledLayerChromium::update):
      * tests/CCTiledLayerTestCommon.h:
      (FakeTiledLayerChromium):
      * tests/LayerChromiumTest.cpp:
      * tests/TiledLayerChromiumTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87eeabf4
    • cfleizach@apple.com's avatar
      ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole · 62e07f3e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77298
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      
      LayoutTests:
      
      * platform/mac/accessibility/aria-spinbutton-expected.txt:
      * platform/mac/accessibility/aria-spinbutton.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62e07f3e
    • commit-queue@webkit.org's avatar
      [BlackBerry] UserViewportArguments are not properly respected. · 0b37bdd8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91005
      
      Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-11
      Reviewed by Rob Buis.
      
      PR# 170088.
      Move scale and zooming reset on Committed before applying
      the user viewport to avoid overriding it immediately.
      
      Internal review by Konrad Piascik, Jacky Jiang.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b37bdd8
    • abarth@webkit.org's avatar
      Sorry, that wasn't supposed to actually land. · 143ec3e2
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      143ec3e2
    • commit-queue@webkit.org's avatar
      42b093a4
    • kseo@webkit.org's avatar
      BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized. · b0d57193
      kseo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90757
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-11
      Reviewed by Simon Fraser.
      
      The current code fortunately has worked so far because only
      BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation
      cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized.
      startAnimation returns at the first line becase shouldAnimate() always return
      false in this case.
      
          if (m_frameTimer || !shouldAnimate() || frameCount() <= 1)
              return;
      
      This change is needed because parallel image decoders call
      BitmapImage::frameIsCompleteAtIndex in other places too.
      
      No new tests, manually tested whether the caller exists or not that
      calls BitmapImage::frameIsCompleteAtIndex() before ImageDecoder is
      initialized.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::frameIsCompleteAtIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0d57193
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening, adding an expectation for a test failing on the · 66033d9a
      zandobersek@gmail.com authored
      64-bit Debug builder due to libxml2 2.8.0 being used and updating the
      bug handle for another test.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66033d9a
    • kevino@webkit.org's avatar
    • kevino@webkit.org's avatar
    • commit-queue@webkit.org's avatar
      [BlackBerry] Implement Date/Time picker · 03efc67e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90911
      
      Patch by Crystal Zhang <haizhang@rim.com> on 2012-07-11
      Reviewed by Rob Buis.
      
      Source/WebKit:
      
      Add files into make file.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Implement HTML Date/Time picker, also should delete popup when closing popup.
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::closePagePopup):
      * WebCoreSupport/DatePickerClient.cpp: Added.
      (WebCore):
      (WebCore::DatePickerClient::DatePickerClient):
      (WebCore::DatePickerClient::~DatePickerClient):
      (WebCore::DatePickerClient::generateHTML):
      (WebCore::DatePickerClient::closePopup):
      (WebCore::DatePickerClient::contentSize):
      (WebCore::DatePickerClient::htmlSource):
      (WebCore::DatePickerClient::setValueAndClosePopup):
      (WebCore::DatePickerClient::didClosePopup):
      (WebCore::DatePickerClient::writeDocument):
      * WebCoreSupport/DatePickerClient.h: Added.
      (WebKit):
      (WebCore):
      (DatePickerClient):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openDatePopup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03efc67e
    • kevino@webkit.org's avatar
      6fc6e4ee
    • kevino@webkit.org's avatar
      [wx] Unreviewed build fix. Ignore array and sequence types for attributes as well · 87c73db3
      kevino@webkit.org authored
      as functions since the CPP bindings do not yet support them.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87c73db3
    • kevino@webkit.org's avatar
    • danakj@chromium.org's avatar
      [chromium] Minimum size used for occlusion tracking should be a setting on CCLayerTreeHost · 82fca3eb
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90993
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Move the default minimum size used for occlusion tracking from the
      CCOcclusionTracker class into CCLayerTreeSettings. This value is then
      used on both threads as the lower limit for any occlusion to be
      remembered.
      
      This allows us to use (0, 0) as the minimum size for tests, allowing all
      occlusion to be tracked.
      
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::paintLayerContents):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
      (CCLayerTreeSettings):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
      * platform/graphics/chromium/cc/CCOcclusionTracker.h:
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTreeHostImplTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82fca3eb
    • abarth@webkit.org's avatar
      [Chromium] Enable LEGACY_VIEWPORT_ADAPTION · 2594d415
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90991
      
      Reviewed by Tony Chang.
      
      Source/WebKit/chromium:
      
      Chromium wishes to support LEGACY_VIEWPORT_ADAPTION. I actually thought
      this was enabled before, but the enable bit got lost in the shuffle.
      
      * features.gypi:
      
      LayoutTests:
      
      These tests pass now that we've enabled this feature.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2594d415
    • tony@chromium.org's avatar
      [chromium] Remove drag and drop API methods that are no longer used · 2eb83818
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90996
      
      Reviewed by Adam Barth.
      
      Source/WebKit/chromium:
      
      In r117327, we added a parameter for modifier keys to these methods.
      Chromium has since switched to using the methods that require the
      extra parameter so we can remove these methods.
      
      * public/WebView.h:
      (WebView):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::dragTargetDragEnter):
      (WebKit::WebViewImpl::dragTargetDragOver):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      Tools:
      
      Migrate DRT to use the methods that take modifier keys.
      
      * DumpRenderTree/chromium/EventSender.cpp:
      (EventSender::doDragDrop):
      (EventSender::doMouseUp):
      (EventSender::doMouseMove):
      (EventSender::beginDragWithFiles):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eb83818
    • commit-queue@webkit.org's avatar
      Add MIPS convertibleLoadPtr and other functions · d847b5ce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90714
      
      Patch by Chao-ying Fu <fu@mips.com> on 2012-07-11
      Reviewed by Oliver Hunt.
      
      * assembler/MIPSAssembler.h:
      (JSC::MIPSAssembler::labelIgnoringWatchpoints):
      (MIPSAssembler):
      (JSC::MIPSAssembler::replaceWithLoad):
      (JSC::MIPSAssembler::replaceWithAddressComputation):
      * assembler/MacroAssemblerMIPS.h:
      (JSC::MacroAssemblerMIPS::convertibleLoadPtr):
      (MacroAssemblerMIPS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d847b5ce
    • andersca@apple.com's avatar
      Add -Wtautological-compare and -Wsign-compare warning flags · e73df4cb
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90994
      
      Reviewed by Mark Rowe.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      
      Source/WTF:
      
      * Configurations/Base.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e73df4cb
    • noam.rosenthal@nokia.com's avatar
      [Qt][WK2] Test actual rendering results in API tests · 13713d4e
      noam.rosenthal@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=80609
      
      Reviewed by Alexis Menard.
      
      Added a very basic test to tst_QQuickWebView to make sure rendering actually occurs.
      
      * UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
      (tst_QQuickWebView):
      (tst_QQuickWebView::basicRenderingSanity):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13713d4e
    • dino@apple.com's avatar
      TileCache layers have wrong border debug color · 969c4f43
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90922
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Commit r122152 updated the layer hierarchy when a tile
      cache is being used by the view. As part of that, GraphicsLayerClient::shouldUseTileCache()
      was changed to return false in some situations (the idea was that it
      should only be called from the createGraphicsLayer method). However
      there were two other call points: one that sets the debug colors on
      borders, the other was a call that keeps the document background in sync.
      
      Add a new method usingTileCache() that returns the current state. Also fix
      a FIXME where the debug code always called into the client rather than
      caching the value on the GraphicsLayer.
      
      Test: compositing/document-background-color.html
      
      * platform/graphics/GraphicsLayer.cpp:
      (WebCore::GraphicsLayer::GraphicsLayer):
      (WebCore::GraphicsLayer::updateDebugIndicators): check the local variable when
      setting the debug colors.
      * platform/graphics/GraphicsLayer.h:
      (GraphicsLayer): new bool member variable m_usingTileCache.
      * platform/graphics/GraphicsLayerClient.h:
      (WebCore::GraphicsLayerClient::usingTileCache): new virtual method to query if
      this client is actually using the tile cache.
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::GraphicsLayerCA): set the member variable m_usingTileCache
      if the GraphicsLayerClient says we are.
      * rendering/RenderLayerBacking.h:
      (WebCore::RenderLayerBacking::usingTileCache):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::documentBackgroundColorDidChange): call usingTileCache()
      rather than shouldUseTileCache(), because the latter's value might not always reflect
      the existence of a cache.
      
      LayoutTests:
      
      Make sure that the document background color is updated
      when using a Tile Cache.
      
      * compositing/document-background-color-expected.html: Added.
      * compositing/document-background-color.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      969c4f43
    • rniwa@webkit.org's avatar
      Clang build fix after r122345. · 77c6f107
      rniwa@webkit.org authored
      Also let XCode do its own thing.
      
      * WebCore.xcodeproj/project.pbxproj:
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollectionWithArrayStorage::item):
      * html/HTMLCollection.h:
      (HTMLCollectionWithArrayStorage):
      * html/HTMLFormCollection.cpp:
      (WebCore::HTMLFormCollection::itemInArrayAfter):
      * html/HTMLFormCollection.h:
      (HTMLFormCollection):
      * html/HTMLPropertiesCollection.cpp:
      (WebCore::HTMLPropertiesCollection::itemInArrayAfter):
      * html/HTMLPropertiesCollection.h:
      (HTMLPropertiesCollection):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77c6f107
    • mrowe@apple.com's avatar
      Add a Mountain Lion version of libWebKitSystemInterface.a. · 7c00efcd
      mrowe@apple.com authored
      Source/WebKit/mac:
      
      Reviewed by John Sullivan.
      
      * Configurations/DebugRelease.xcconfig: Look for the library under its expected name.
      
      Source/WebKit2:
      
      Reviewed by John Sullivan.
      
      * Configurations/DebugRelease.xcconfig: Look for the library under its expected name.
      
      Tools:
      
      Reviewed by John Sullivan.
      
      * Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.
      
      WebKitLibraries:
      
      Update the WebKitSystemInterface header and binaries.
      
      Reviewed by John Sullivan.
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLion.a:
      * libWebKitSystemInterfaceMountainLion.a: Added.
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c00efcd