1. 09 Apr, 2013 2 commits
  2. 08 Apr, 2013 6 commits
    • benjamin@webkit.org's avatar
      Remove HTML Notification · de455ba7
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114231
      
      Reviewed by Ryosuke Niwa.
      
      Source/JavaScriptCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore: 
      
      The feature is dead. It was only kept in the tree because of chromium.
      
      * Configurations/FeatureDefines.xcconfig:
      * Modules/notifications/Notification.cpp:
      (WebCore):
      (WebCore::Notification::Notification):
      * Modules/notifications/Notification.h:
      (Notification):
      * Modules/notifications/NotificationCenter.h:
      (NotificationCenter):
      * Modules/notifications/NotificationCenter.idl:
      * page/FeatureObserver.h:
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::displayNotification):
      (WebCore::NotificationPresenterClientQt::cancel):
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
      (WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
      (WebCore::NotificationPresenterClientQt::dumpShowText):
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h:
      
      Tools: 
      
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests: 
      
      * fast/notifications/notifications-with-permission-expected.txt:
      * fast/notifications/notifications-with-permission.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de455ba7
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebPage: fix build due to type mismatches · 1f8b99ce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114148
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
      Reviewed by Darin Adler.
      
      Add explicit conversions between LayoutUnit and int, and between
      LayoutRect and IntRect.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::rectForNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f8b99ce
    • commit-queue@webkit.org's avatar
      [BlackBerry] Update BlackBerry JavaScript API · 583f6077
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114065
      
      Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      .:
      
      Internal PR 317350
      Export JSC symbols in BlackBerry build.
      
      * Source/cmake/OptionsBlackBerry.cmake:
      
      Source/WebKit:
      
      Internal PR 317350
      Remove obsolete files.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Internal PR 317350
      Add new API for determining if user gesture is being processed.
      Remove obsolete files.
      Properly expose JSC global context.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
      (BlackBerry::WebKit::WebPage::globalContext):
      (BlackBerry::WebKit::WebPage::isProcessingUserGesture):
      (WebKit):
      * Api/WebPage.h:
      * Api/WebPageClient.h:
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      * WebCoreSupport/ClientExtension.cpp: Removed.
      * WebCoreSupport/ClientExtension.h: Removed.
      * WebCoreSupport/ExternalExtension.cpp: Removed.
      * WebCoreSupport/ExternalExtension.h: Removed.
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      583f6077
    • commit-queue@webkit.org's avatar
      [BlackBerry] More null checks for m_mainFrame · 6dee1028
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114172
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      After r147744, some unit tests were crashing on WebPage
      shutdown, because BackingStorePrivate::repaint() now uses
      pixelContentsRect() (accessing m_webPage->contentsRect())
      instead of BackingStoreClient::contentsRect(). In m_webPage,
      m_mainFrame had already been set to 0.
      
      Make us more robust against these errors by checking
      the existence of m_mainFrame more diligently.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::contentsSize):
      (BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
      (BlackBerry::WebKit::WebPagePrivate::setViewMode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dee1028
    • commit-queue@webkit.org's avatar
      [BlackBerry] Force horizontal list to be horizontal scrollable. · ac437e0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114173
      
      Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      Force content to be horizontal/vertical overscrollable if it
      scrolls in horizontal/vertical way.
      
      PR 237440
      Internally Reviewed by Arvid Nilsson.
      
      * WebKitSupport/InRegionScrollableArea.cpp:
      (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac437e0d
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebPage: misc build fixes · 71485bf3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114152
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
      Reviewed by Carlos Garcia Campos.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
      (BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
      (BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
      (BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
      Remove unused parameters.
      
      (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
      (BlackBerry::WebKit::WebPage::blockZoom):
      Replace TAAUTO with TASTART (this changed in r120495).
      
      (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
      Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
      r142220).
      
      (BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
      Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
      r113514).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71485bf3
  3. 07 Apr, 2013 1 commit
    • ddkilzer@apple.com's avatar
      Remove the rest of SVG_DOM_OBJC_BINDINGS · 0cd46787
      ddkilzer@apple.com authored
      <http://webkit.org/b/114112>
      
      Reviewed by Geoffrey Garen.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      - Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Source/WebCore:
      
      * Configurations/WebCore.xcconfig:
      - Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS.  Note
        that DOMHTMLIFrameElementPrivate.h should not have been in
        this list because the class contained methods other than just
        -getSVGDocument.
      
      * WebCore.xcodeproj/project.pbxproj:
      - Remove DOMHTMLFrameElementPrivate.h since the only method it
        contained was -[DOMHTMLFrameElement getSVGDocument], which was
        part of the SVG DOM Objective-C bindings.
      
      * bindings/objc/DOM.mm:
      (kitClass):
      * bindings/objc/DOMEvents.mm:
      (kitClass):
      * bindings/objc/ExceptionHandlers.mm:
      (WebCore::raiseDOMException):
      - Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      - Remove reference to SVG_DOM_OBJC_BINDINGS.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      - Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      - Remove --svg-dom-objc-bindings switch.
      * qmake/mkspecs/features/features.pri:
      - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd46787
  4. 06 Apr, 2013 1 commit
    • zandobersek@gmail.com's avatar
      Remove the USE(SKIA_ON_MAC_CHROMIUM) guards · ccac1ab8
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114084
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore: 
      
      Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
      for the Chromium port via the features.gypi file that was removed in r147714.
      
      * platform/graphics/FloatPoint.h:
      (FloatPoint):
      * platform/graphics/FloatRect.h:
      (FloatRect):
      * platform/graphics/FloatSize.h:
      (FloatSize):
      * platform/graphics/FontPlatformData.cpp:
      (WebCore):
      * platform/graphics/FontPlatformData.h:
      (FontPlatformData):
      (WebCore::FontPlatformData::hash):
      * platform/graphics/IntPoint.h:
      (IntPoint):
      * platform/graphics/IntRect.h:
      (IntRect):
      (WebCore):
      * platform/graphics/IntSize.h:
      (IntSize):
      * platform/graphics/SimpleFontData.h:
      (SimpleFontData):
      (WebCore::SimpleFontData::widthForGlyph):
      * platform/graphics/cg/FloatPointCG.cpp:
      * platform/graphics/cg/FloatRectCG.cpp:
      * platform/graphics/cg/FloatSizeCG.cpp:
      * platform/graphics/cg/IntPointCG.cpp:
      * platform/graphics/cg/IntRectCG.cpp:
      * platform/graphics/cg/IntSizeCG.cpp:
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/FontCustomPlatformData.h:
      (WebCore::FontCustomPlatformData::FontCustomPlatformData):
      (FontCustomPlatformData):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccac1ab8
  5. 05 Apr, 2013 10 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] FatFingers Don't check the shadow tree for all elements. · ed89a9c6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114066
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-05
      Reviewed by Rob Buis.
      
      BlackBerry PR 263078
      Internally reviewed by Genevieve Mak.
      
      No need to check shadow tree since sliders use touch events.
      
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::isElementClickable):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed89a9c6
    • commit-queue@webkit.org's avatar
      Remove WTF_USE_GOOGLEURL-guarded code · 78805507
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114028
      
      Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-05
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      The only remaining usage of the USE(GOOGLEURL) guards is in LinkHashChromium.cpp that will
      get removed when purging the Source/WebCore/platform/chromium directory.
      
      * config.h: Remove the define that was Chromium-specific.
      * platform/KURL.cpp:
      (WebCore):
      (WebCore::KURL::reportMemoryUsage):
      (WebCore::KURL::isSafeToSendToAnotherThread):
      * platform/KURL.h:
      (KURL):
      * platform/KURLGoogle.cpp: Removed.
      * platform/KURLGooglePrivate.h: Removed.
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78805507
    • zhajiang@rim.com's avatar
      [BlackBerry] Blitting wrong rect during history navigations · dd4a990a
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113963
      
      Patch by Jacky Jiang <zhajiang@rim.com>.
      Reviewed by Rob Buis.
      Internally reviewed by Jakob Petsovits.
      
      On www.bbc.com/news, we blit wrong rect during the second restoration
      of the view states when we navigate back from stories to the main page.
      Update the contents size and scroll position before we render and blit
      if we failed to zoomAboutPoint so that UI thread can still get the
      correct rect during blit.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4a990a
    • commit-queue@webkit.org's avatar
      [BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor · 511c5019
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113449
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-05
      Reviewed by Rob Buis.
      
      This removes the WebPage/BackingStoreClient family of coordinate
      transformation functions, which were widely disliked for their
      naming, with ViewportAccessor API that had previously been
      introduced for limited use cases. This commit takes care of the
      remaining call sites and leaves us with a single API to use.
      
      No new tests, only a clean-up/refactor of existing code & functionality.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::repaint):
      (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
      (BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
      (BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
      (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
      (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
      * Api/InRegionScroller.cpp:
      (BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::init):
      (BlackBerry::WebKit::WebPagePrivate::scrollPosition):
      (BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
      (BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
      (BlackBerry::WebKit::WebPagePrivate::viewportSize):
      (BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
      (BlackBerry::WebKit::WebPagePrivate::layoutFinished):
      (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
      (BlackBerry::WebKit::WebPagePrivate::updateCursor):
      (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::blockZoom):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
      (BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
      (BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
      (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
      * WebKitSupport/BackingStoreClient.h:
      (BackingStoreClient):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
      (BlackBerry::WebKit::FatFingers::FatFingers):
      (BlackBerry::WebKit::FatFingers::findBestPoint):
      (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      * WebKitSupport/InRegionScrollableArea.cpp:
      (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
      * WebKitSupport/WebKitThreadViewportAccessor.cpp:
      (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
      (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
      (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      511c5019
    • commit-queue@webkit.org's avatar
      [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents() · 60a29804
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114022
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
      Reviewed by Carlos Garcia Campos.
      
      Naming the 'time' and 'inClip' unused parameters only produces
      compiler warnings.
      
      * Api/WebOverlay_p.h:
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
      (WebOverlayPrivateWebKitThread):
      * Api/WebPage_p.h:
      (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
      (BlackBerry::WebKit::WebPagePrivate::paintContents):
      * WebKitSupport/DefaultTapHighlight.h:
      (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      (BlackBerry::WebKit::InspectorOverlay::paintContents):
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.h:
      (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60a29804
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebOverlay: fix access to m_client · 6e2b90e2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114003
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
      Reviewed by Rob Buis.
      
      m_client was replace by m_overlay in r146058.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e2b90e2
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter() · 714fc378
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114009
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
      Reviewed by Carlos Garcia Campos.
      
      These methods were removed in r133517 but were accidentally
      introduced again in r145968.
      The previous patch didn't remove them all.
      
      * WebKitSupport/DefaultTapHighlight.cpp:
      * WebKitSupport/DefaultTapHighlight.h:
      (DefaultTapHighlight):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.cpp:
      * WebKitSupport/SelectionOverlay.h:
      (SelectionOverlay):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      714fc378
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter() · 11a9e473
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114009
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
      Reviewed by Carlos Garcia Campos.
      
      These methods were removed in r133517 but were accidentally
      introduced again in r145968.
      
      * Api/WebOverlay_p.h:
      (WebOverlayPrivateWebKitThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11a9e473
    • commit-queue@webkit.org's avatar
      [BlackBerry] WebOverlay: check if platformContext is null · ba09afaf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114005
      
      Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-05
      Reviewed by Carlos Garcia Campos.
      
      RIM PR 256522
      Internally reviewed by Mike Lattanzio.
      
      The pointer returned by lockBufferDrawable can be null, so it
      needs to be checked first before being used.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba09afaf
    • benjamin@webkit.org's avatar
      Remove WTFURL from WebKit · fee685df
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113994
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
      Reviewed by Ryosuke Niwa.
      
      .: 
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore: 
      
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/KURL.cpp:
      (WebCore):
      (WebCore::KURL::reportMemoryUsage):
      (WebCore::KURL::isSafeToSendToAnotherThread):
      * platform/KURL.h:
      (KURL):
      (WebCore):
      * platform/KURLWTFURL.cpp: Removed.
      * platform/KURLWTFURLImpl.h: Removed.
      * platform/cf/KURLCFNet.cpp:
      (WebCore::KURL::KURL):
      (WebCore::KURL::createCFURL):
      (WebCore):
      * platform/mac/KURLMac.mm:
      (WebCore::KURL::KURL):
      (WebCore::KURL::createCFURL):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataUseFeatures.in:
      
      Source/WTF: 
      
      Painful, but that is for the best now :(
      
      * GNUmakefile.list.am:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentationParsedURL.h: Removed.
      * wtf/url/api/ParsedURL.cpp: Removed.
      * wtf/url/api/ParsedURL.h: Removed.
      * wtf/url/api/URLBuffer.h: Removed.
      * wtf/url/api/URLQueryCharsetConverter.h: Removed.
      * wtf/url/api/URLString.cpp: Removed.
      * wtf/url/api/URLString.h: Removed.
      * wtf/url/src/RawURLBuffer.h: Removed.
      * wtf/url/src/URLCanon.h: Removed.
      * wtf/url/src/URLCanonEtc.cpp: Removed.
      * wtf/url/src/URLCanonFilesystemurl.cpp: Removed.
      * wtf/url/src/URLCanonFileurl.cpp: Removed.
      * wtf/url/src/URLCanonHost.cpp: Removed.
      * wtf/url/src/URLCanonICU.cpp: Removed.
      * wtf/url/src/URLCanonIP.cpp: Removed.
      * wtf/url/src/URLCanonInternal.cpp: Removed.
      * wtf/url/src/URLCanonInternal.h: Removed.
      * wtf/url/src/URLCanonMailto.cpp: Removed.
      * wtf/url/src/URLCanonPath.cpp: Removed.
      * wtf/url/src/URLCanonPathurl.cpp: Removed.
      * wtf/url/src/URLCanonQuery.cpp: Removed.
      * wtf/url/src/URLCanonRelative.cpp: Removed.
      * wtf/url/src/URLCanonStdURL.cpp: Removed.
      * wtf/url/src/URLCharacterTypes.cpp: Removed.
      * wtf/url/src/URLCharacterTypes.h: Removed.
      * wtf/url/src/URLComponent.h: Removed.
      * wtf/url/src/URLFile.h: Removed.
      * wtf/url/src/URLParse.cpp: Removed.
      * wtf/url/src/URLParse.h: Removed.
      * wtf/url/src/URLParseFile.cpp: Removed.
      * wtf/url/src/URLParseInternal.h: Removed.
      * wtf/url/src/URLSegments.cpp: Removed.
      * wtf/url/src/URLSegments.h: Removed.
      * wtf/url/src/URLUtil.cpp: Removed.
      * wtf/url/src/URLUtil.h: Removed.
      * wtf/url/src/URLUtilInternal.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fee685df
  6. 04 Apr, 2013 2 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops... · d163f0f7
      commit-queue@webkit.org authored
      [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
      https://bugs.webkit.org/show_bug.cgi?id=113944
      
      Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
      Reviewed by Rob Buis.
      Internally reviewed by Mike Fenton.
      
      Internal PR 320732.
      When checking whether a RenderObject is fixed position or has a fixed position
      ancestor, we traverse the render tree upwards.
      
      When we reach the root of the tree, check whether the root is an
      iframe and has an element owner. If so, we also need to continue iterating
      up the tree from the owner to see if the iframe is a descendant of a fixed
      position element.
      
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d163f0f7
    • commit-queue@webkit.org's avatar
      [BlackBerry] Adjust fatfinger result priority · a832f327
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113957
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
      Reviewed by Rob Buis.
      
      RIM PR 224781
      Internally Reviewed by Genevieve Mak.
      
      Change fatfigner algorithm, return the clickable element rather than
      its parent anchor. Modify taphighlight and context menu node selection
      accordingly.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::findBestPoint):
      * WebKitSupport/FatFingers.h:
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a832f327
  7. 03 Apr, 2013 2 commits
    • anilsson@rim.com's avatar
      [BlackBerry] Remove defaultViewportArguments check from call site of... · 6bbd2b1e
      anilsson@rim.com authored
      [BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
      https://bugs.webkit.org/show_bug.cgi?id=113872
      
      Reviewed by Carlos Garcia Campos.
      
      Carlos pointed out that recomputeVirtualViewportFromViewportArguments
      already contains the check, and returns an empty IntSize if it fails.
      So pick up on that to make the code a bit more DRY.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bbd2b1e
    • anilsson@rim.com's avatar
      [BlackBerry] Decouple layout viewport from visual viewport · 48e83dab
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113829
      
      Reviewed by Carlos Garcia Campos.
      
      Setting the visual viewport would force the layout viewport equal to
      the visual viewport. Decouple the viewports by allowing the user to
      specify a layout viewport when setting the viewport(s). The layout
      viewport could be the exact same value passed for visual viewport, if
      the old behavior is desired.
      
      Also reevaluate any viewport arguments when (only) the layout viewport
      changes in WebPage::setDefaultLayoutSize() since the layout viewport is
      used as input to the calculation.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
      (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
      (BlackBerry::WebKit::WebPage::setViewportSize):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
      (BlackBerry::WebKit::WebPage::defaultLayoutSize):
      * Api/WebPage.h:
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48e83dab
  8. 02 Apr, 2013 2 commits
  9. 01 Apr, 2013 1 commit
  10. 29 Mar, 2013 2 commits
  11. 28 Mar, 2013 3 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't cross editing boundary when touch hold selection expands · 73737236
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113537
      
      Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Set editing boundary crossing rule to make sure it won't cross
      editing boundary when selection expands.
      
      Reviewed Internally By Genevieve Mak and Mike Fenton.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
      (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73737236
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor. · d503b051
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113447
      Internal PR 313452
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Potential threading problems are avoided by moving from
      WebPage members and mapToTransformed() to the web page
      client's userInterfaceViewportAccessor().
      
      As part of this cleaning effort, the WebPageCompositor's
      render() method is changed to now take document instead of
      pixel coordinates.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::render):
      (BlackBerry::WebKit::WebPageCompositor::render):
      * Api/WebPageCompositor.h:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d503b051
    • falken@chromium.org's avatar
      Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl · 2113254c
      falken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113273
      
      Reviewed by Kent Tamura.
      
      Element::disabled is about form controls and Element::isEnabledFormControl
      is redundant with it, so replace them with a single function
      Element::isDisabledFormControl.
      
      Source/WebCore:
      
      No new tests, there should be no behavior change.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::isEnabled):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isEnabled):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithControl):
      * dom/Element.cpp:
      (WebCore::Element::isDisabledFormControl):
      * dom/Element.h:
      (Element):
      (WebCore::isDisabledFormControl): Add helper function for convenience.
      (WebCore):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchSimulatedClick):
      * dom/GestureEvent.cpp:
      (WebCore::GestureEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents):
      (WebCore::Node::willRespondToMouseMoveEvents):
      (WebCore::Node::willRespondToMouseClickEvents):
      (WebCore::Node::willRespondToTouchEvents):
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::disabledAttributeChanged):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::defaultEventHandler):
      (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
      (WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::updateAncestorDisabledState):
      (WebCore::HTMLFormControlElement::isDisabledFormControl):
      (WebCore::HTMLFormControlElement::supportsFocus):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isSuccessfulSubmitButton):
      (WebCore::HTMLInputElement::willRespondToMouseClickEvents):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::isDisabledFormControl):
      * html/HTMLOptGroupElement.h:
      (HTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      (WebCore::HTMLSelectElement::defaultEventHandler):
      (WebCore::HTMLSelectElement::optionAtIndex):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent):
      * html/ResetInputType.cpp:
      (WebCore::ResetInputType::handleDOMActivateEvent):
      * html/SubmitInputType.cpp:
      (WebCore::SubmitInputType::handleDOMActivateEvent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
      (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
      * html/shadow/SliderThumbElement.h:
      (SliderThumbElement):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextFieldDecorationElement.cpp:
      (WebCore::TextFieldDecorationElement::updateImage):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemIsEnabled):
      * rendering/RenderTextControl.cpp:
      (WebCore::updateUserModifyProperty):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      * rendering/RenderThemeMac.mm:
      (WebCore::getMediaUIPartStateFlags):
      * rendering/RenderThemeMacShared.mm:
      (WebCore::RenderThemeMacShared::adjustMenuListStyle):
      (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      Source/WebKit/chromium:
      
      * src/WebFormControlElement.cpp:
      (WebKit::WebFormControlElement::isEnabled):
      * src/WebOptionElement.cpp:
      (WebKit::WebOptionElement::isEnabled):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::findSuitableSearchInputElement):
      (HTMLNames::buildSearchString):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::disabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113254c
  12. 27 Mar, 2013 2 commits
  13. 26 Mar, 2013 6 commits
    • hayato@chromium.org's avatar
      Allow ShadowContents in HitTests by default. · af1544e8
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113171
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      HitTestRequest is widely used in WebCore, but AllowShadowContents
      flag is not turned on by default.  In most places, we can set the
      flag on.
      
      This change makes HitTests allow shadow contents by default.
      
      To track all existing HitTests which do not allow shadow contents,
      and discourage such a HitTest in the future, I've introduced
      disallowShadowContenet flag so that callers must turn on this flag
      explicitly if they want to disallow shadow contents in their HitTests.
      
      This change should be refactoring and should not include any
      behavior changes.  After this change, we'll investigate each place
      where disallowShadowContents is used step by step and get rid of
      the flag if it is okay to remove.
      
      No new tests, no behavior change.
      
      * dom/Document.h:
      (Document):
      * dom/TreeScope.cpp:
      (WebCore::nodeFromPoint):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::contains):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseDraggedEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::updateDragAndDrop):
      (WebCore::EventHandler::isInsideScrollbar):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureLongPress):
      (WebCore::EventHandler::handleGestureScrollBegin):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::hoverTimerFired):
      (WebCore::EventHandler::dragSourceEndedAt):
      (WebCore::EventHandler::handleDrag):
      (WebCore::EventHandler::handleTouchEvent):
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::disallowsShadowContent):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::hitTestClipContent):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTapNode):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_inspect_coordinates):
      * webkit/webkitwebview.cpp:
      (prepareMouseEventForFrame):
      (webkit_web_view_get_hit_test_result):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::gestureNotify):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1544e8
    • commit-queue@webkit.org's avatar
      [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry · 0a171184
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112996
      
      Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR 312552
      Internally Reviewed by Anthony Scian.
      
      NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
      but not deleted anywhere. Fixed by creating an OwnPtr for it.
      Also fixed some webkit-style errors.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      * Api/WebPage_p.h:
      (WebCore):
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a171184
    • commit-queue@webkit.org's avatar
      [BlackBerry] Include accelerated compositing layers in screen captures. · 6f270615
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113335
      
      Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR# 280374
      Include accelerated compositing layers in screen captures.
      Reviewed Internally By: Jakob Petsovits
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::renderContents):
      (BlackBerry::WebKit::BackingStore::drawContents):
      * Api/BackingStore_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f270615
    • commit-queue@webkit.org's avatar
      [BlackBerry] Set mouse document position for mouse event in updateCursor · 0e61ec9b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109094
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      Internally Reviewed by Jakob Petsovits.
      
      Mouse content position should be in document coordinate.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::updateCursor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e61ec9b
    • anilsson@rim.com's avatar
      [BlackBerry] Scrolling up and down can cause the screen to flash black · cd289bab
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113269
      
      Reviewed by Rob Buis.
      
      PR 296106
      
      Source/WebCore:
      
      The LayerRenderer should never clear before drawing the layers, from
      now on that's the responsibility of the caller.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::setViewport):
      * platform/graphics/blackberry/LayerRendererClient.h:
      (LayerRendererClient):
      
      Source/WebKit/blackberry:
      
      Various flaws in the code could conspire to make the screen cleared to
      black before rendering the web page. This only happened when the
      BackingStore was inactive, and the LayerTiler takes on the job of
      drawing the root layer. When tiles are missing, this made the
      "checkerboard" effect especially noticeable since black color was seen
      where the tile should have been. It would be better to clear to the web
      page background color.
      
      This was actually the intent of the code, but when the document
      background color was invalid, we would still use it instead of the
      background color from settings. Also, the LayerRenderer would clear to
      black when WebPageCompositorPrivate::drawsRootLayer() was true.
      
      Fixed by falling back to the settings background color when the
      document background color is invalid, and removing the clearing code
      from the LayerRenderer entirely. The appropriate clear already happens
      near the beginning of BackingStorePrivate::blitVisibleContents().
      
      Also slightly cleaned up the code for managing the background color.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
      * Api/WebPageCompositor.cpp:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd289bab
    • anilsson@rim.com's avatar
      [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates · 302250bc
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113263
      
      Reviewed by Rob Buis.
      
      PR 312404
      
      Source/WebCore:
      
      Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
      instead of the window rect. These are different if the web page is
      rendered starting at a window coordinate other than 0,0. The clip rect
      encodes the position we're rendered at, and can be used to translate
      the rect expressed in window coordinates to the pixel viewport
      coordinate system.
      
      Also perform some cleanup of related code.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::getTransformedHolePunchRect):
      (WebCore::LayerCompositingThread::drawTextures):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::toPixelCoordinates):
      (WebCore):
      (WebCore::LayerRenderer::toWindowCoordinates):
      (WebCore::LayerRenderer::toPixelViewportCoordinates):
      (WebCore::LayerRenderer::toDocumentViewportCoordinates):
      (WebCore::LayerRenderer::updateLayersRecursive):
      * platform/graphics/blackberry/LayerRenderer.h:
      (LayerRenderer):
      
      Source/WebKit/blackberry:
      
      Fixed by returning pixel viewport coordinates instead of window
      coordinates.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      302250bc