- 20 Jan, 2011 32 commits
-
-
jamesr@google.com authored
Reviewed by Eric Seidel. RenderTableSection's setNeedsCellRecalc needs to null check table() https://bugs.webkit.org/show_bug.cgi?id=52770 Tests ::-webkit-scrollbar-corner inside a table. * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added. * fast/css-generated-content/table-with-scrollbar-corner.html: Added. 2011-01-20 James Robinson <jamesr@chromium.org> Reviewed by Eric "Baller" Seidel. RenderTableSection's setNeedsCellRecalc needs to null check table() https://bugs.webkit.org/show_bug.cgi?id=52770 Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc. This can be null during detach(). Test constructed by Eric Seidel. Test: fast/css-generated-content/table-with-scrollbar-corner.html * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setNeedsCellRecalc): * rendering/RenderTableSection.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Rob Buis. SVG Pattern doesn't take preserveAspectRatio of references Pattern https://bugs.webkit.org/show_bug.cgi?id=52802 SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element. Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform): * svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::preserveAspectRatio): (WebCore::PatternAttributes::setPreserveAspectRatio): (WebCore::PatternAttributes::hasPreserveAspectRatio): * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes): 2011-01-20 Dirk Schulze <krit@webkit.org> Reviewed by Rob Buis. SVG Pattern doesn't take preserveAspectRatio of references Pattern https://bugs.webkit.org/show_bug.cgi?id=52802 Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account. * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added. * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added. * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added. * svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8765498mitz@apple.com authored
Reviewed by Adele Peterson. <rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com https://bugs.webkit.org/show_bug.cgi?id=52765 <rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup https://bugs.webkit.org/show_bug.cgi?id=52265 Source/WebCore: Test: fast/block/line-layout/negative-max-height.html Integer overflow detection led to a block having a huge height. This manifested as broken layout in the first bug and as extreme slowness in the latter bugs because of https://bugs.webkit.org/show_bug.cgi?id=52832 * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line cannot start above this line. The negative maxHeight also caused the integer overflow detection logic to give the block a huge height. LayoutTests: * fast/block/line-layout: Added. * fast/block/line-layout/negative-max-height-expected.checksum: Added. * fast/block/line-layout/negative-max-height-expected.png: Added. * fast/block/line-layout/negative-max-height-expected.txt: Added. * fast/block/line-layout/negative-max-height.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yi.4.shen@nokia.com authored
Reviewed by Eric Carlson. Clean up the Media Controls CSS for Qt https://bugs.webkit.org/show_bug.cgi?id=52822 Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx rules from mediaControlsQtFullscreen.css. * css/mediaControlsQt.css: (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button): (video::-webkit-media-controls-toggle-closed-captions-button): * css/mediaControlsQtFullscreen.css: (video::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-toggle-closed-captions-button): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken https://bugs.webkit.org/show_bug.cgi?id=52816 * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Qt] Fix Layering violation in MediaPlayerPrivateQt. https://bugs.webkit.org/show_bug.cgi?id=52733 No new tests. no behavioral change. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
Reviewed by Darin Fisher. [V8] Call malloc and memcpy directly instead of of strdup in convertV8ObjectToNPVariant() when converting strings. If there is a null character in the string, our use of strdup causes us to allocate too little memory, leading to out of bounds reads. https://bugs.webkit.org/show_bug.cgi?id=52631 * bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Ariya Hidayat. [Qt] Fill shadow scratch buffer with proper transparent pixels QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8) so doing QImage::fill(Qt::transparent) will actually fill all pixels with the RGBA value 0x00000013. * platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::scratchImage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
It wasn't doing anything. Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused Reviewed by Simon Fraser. * WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with the file. * platform/graphics/win/WKCACFContextFlusher.cpp: Removed. * platform/graphics/win/WKCACFContextFlusher.h: Removed. * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::layerTreeDidChange): Stop telling WKCACFContextFlusher about our context, since it never did anything with it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted changes get flushed whenever any composited page is resized Reviewed by Simon Fraser. * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts WKCACFContextFlusher knows about. After all, ours is the only one that just got resized! git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
This will be needed to handle cases where the client might release its reference to us while we're calling out to it. WKCACFLayerRenderer now has a setClient function, which is used rather than passing the client to create(). This allows clients to null out the client pointer when they're done with the renderer. Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be ref-counted Reviewed by Simon Fraser. Source/WebCore: * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Updated for WKCACFLayerRenderer changes. * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to create(). (WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now returns a PassOwnPtr. (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a WKCACFLayerRendererClient. * platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from RefCounted. (WebCore::WKCACFLayerRenderer::setClient): Added this simple setter. Source/WebKit/win: Update for WKCACFLayerRenderer changes * WebView.cpp: (WebView::~WebView): Added some assertions to make sure we've gotten rid of our compositing-related members. My biggest concern was making sure that m_layerRenderer was gone, which would also mean we had nulled out its client pointer. (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead of passing the client into create(), and to clear out the client before nulling out m_layerRenderer. * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* bindings/v8/ScriptCachedFrameData.h: Add missing include. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: enable resource agent upon request. https://bugs.webkit.org/show_bug.cgi?id=52815 We should not send network-related notifications unless front-end is interested. * inspector/Inspector.idl: * inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::resourceAgent): * inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::domAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveResourceAgent): * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::InspectorResourceAgent): * inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create): * inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): * inspector/InspectorState.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=49897 Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20 Reviewed by Csaba Osztrogonác. Source/JavaScriptCore: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. * wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro. Source/WebCore: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Source/WebKit: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Source/WebKit2: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. Tools: Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589). The modification replaces Noncopyable and FastAllocBase classes and these inherits with their equivalent macro implementation at the necessary places. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth. Profiles are now not cleared unless renderer instance was changed. https://bugs.webkit.org/show_bug.cgi?id=52807 * inspector/InspectorController.cpp: (WebCore::InspectorController::restoreProfiler): * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::resetFrontendProfiles): * inspector/InspectorProfilerAgent.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Unreviewed, add new JS file refs missing from r76116. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/WebKit.qrc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Crash when adding a rule for an ImageDocument https://bugs.webkit.org/show_bug.cgi?id=52811 * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: cleanup InspectorController's friends list. We have a plan to extract InspectorAgent from InspectorController. InspectorAgent will be accessible only from InspectorController. As result we can simply made some methods public and remove long friends list. https://bugs.webkit.org/show_bug.cgi?id=52806 * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend): * inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): * inspector/InspectorController.h: (WebCore::InspectorController::frontend): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent): (WebCore::InspectorInstrumentation::retrieveResourceAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model. https://bugs.webkit.org/show_bug.cgi?id=52723 Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane. * inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get data): (WebInspector.Breakpoint.prototype.remove): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.breakpointForId): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): * inspector/front-end/inspector.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Andreas Kling. SVG Pattern doesn't take the viewBox of a referenced Pattern https://bugs.webkit.org/show_bug.cgi?id=52804 SVGPattern element didn't use the viewBox of another SVGPattern element, referenced by xlink:href. Modified PatternAttributes, to take the value of the viewBox of the SVGPattern element as well, if the attribute was set. This gets checked by a W3C SVG test case. Test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform): * svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::viewBox): (WebCore::PatternAttributes::setViewBox): (WebCore::PatternAttributes::hasViewBox): * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes): 2011-01-20 Dirk Schulze <krit@webkit.org> Reviewed by Andreas Kling. SVG Pattern doesn't take the viewBox of a referenced Pattern https://bugs.webkit.org/show_bug.cgi?id=52804 Added a test case of the W3C SVG test suite to check, if we take the viewBox of a referenced SVGPattern. * svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg: Added. * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
[Re-land of r76159 with a compile fix for the Chromium linux shlib build.] Reviewed by James Robinson. Implement accelerated path drawing and clipping for the Canvas2D GPU path. https://bugs.webkit.org/show_bug.cgi?id=52627 This is done with a simple curve interpolator and the GLU tesselator, which is good enough for a 3-5X speedup on http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html. Covered by canvas/philip/2d.path.clip.basic.html, and many, many more. All tests canvas/philip and fast/canvas paths pass with no regressions, although two have minor pixel differences which require rebaselining. * WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build. * WebCore.gypi: Add internal_glu files to chromium build. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer. * platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer. * platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state. * platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused. * platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset): * platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil(). * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil): * platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable. * platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing. * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware. * thirdparty/glu/README.webkit: * thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build. * thirdparty/glu/libtess/geom.c: * thirdparty/glu/libtess/priorityq.c: * thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro. * thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build. 2011-01-19 Stephen White <senorblanco@chromium.org> Reviewed by James Robinson. Add two to-be-rebaselined tests for the GPU path. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Web Inspector: move releaseObjectGroup to the new Runtime agent. https://bugs.webkit.org/show_bug.cgi?id=52803 (accedentally landed as r76231) * inspector/InspectorContorller.h: * inspector/InspectorContorller.cpp: * inspector/InspectorRuntimeAgent.h: * inspector/InspectorRuntimeAgent.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: build fix. * inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: further simplify InspectorState. https://bugs.webkit.org/show_bug.cgi?id=52731 This change moves XHR logging flag into console agent, removes InspectorState pushing to the front-end. * inspector/Inspector.idl: * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage): * inspector/InspectorConsoleAgent.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorController.h: (WebCore::InspectorController::state): (WebCore::InspectorController::settings): * inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create): * inspector/InspectorState.h: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent): * inspector/front-end/inspector.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt][V8] Remove unnecessary files after r76224. * WebCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: prepare for extracting InspectorAgent from InspectorController. https://bugs.webkit.org/show_bug.cgi?id=52797 * inspector/CodeGeneratorInspector.pm: * inspector/InspectorController.h: (WebCore::InspectorController::inspectorAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::resourceAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::timelineAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent): (WebCore::InspectorController::browserDebuggerAgent): (WebCore::InspectorController::debuggerAgent): (WebCore::InspectorController::profilerAgent): (WebCore::InspectorController::applicationCacheAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Unreviewed, rolling out r76215. http://trac.webkit.org/changeset/76215 https://bugs.webkit.org/show_bug.cgi?id=52799 Caused regressions in Chromium; morrita is going to look at it tomrorow (Requested by jorlow on #webkit). * editing/inserting/insert-composition-whitespace-expected.txt: Removed. * editing/inserting/insert-composition-whitespace.html: Removed. 2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r76215. http://trac.webkit.org/changeset/76215 https://bugs.webkit.org/show_bug.cgi?id=52799 Caused regressions in Chromium; morrita is going to look at it tomrorow (Requested by jorlow on #webkit). * dom/TextEvent.h: * dom/TextEventInputType.h: * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): * editing/CompositeEditCommand.h: * editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition): * editing/Editor.h: * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): * editing/InsertTextCommand.h: * editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines): * editing/TypingCommand.h: (WebCore::TypingCommand::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Adam Barth. [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp https://bugs.webkit.org/show_bug.cgi?id=51044 * WebCore.gypi: * bindings/v8/V8ConsoleMessage.cpp: Removed. * bindings/v8/V8ConsoleMessage.h: Removed. * bindings/v8/V8DOMWindowShell.cpp: (WebCore::v8UncaughtExceptionHandler): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::initContextIfNeeded): * bindings/v8/V8Proxy.cpp: (WebCore::addMessageToConsole): (WebCore::logInfo): (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance): * bindings/v8/V8Proxy.h: * bindings/v8/WorkerContextExecutionProxy.cpp: * bindings/v8/specialization/V8BindingState.cpp: (WebCore::::immediatelyReportUnsafeAccessTo): 2010-12-14 Yury Semikhatsky <yurys@chromium.org> Reviewed by Adam Barth. [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp https://bugs.webkit.org/show_bug.cgi?id=51044 * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runJavaScriptAlert): * src/WebScriptController.cpp: (WebKit::WebScriptController::flushConsoleMessages): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Eric Seidel. ShadowElement::m_shadowParent should be removed https://bugs.webkit.org/show_bug.cgi?id=52558 No new tests. No behavioral change. * rendering/ShadowElement.h: (WebCore::ShadowElement::ShadowElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hans@chromium.org authored
Reviewed by Jeremy Orlow. IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror https://bugs.webkit.org/show_bug.cgi?id=52725 Update layout tests to expect the onsuccess handler to be fired when looking up non-existing objects. * storage/indexeddb/create-and-remove-object-store-expected.txt: * storage/indexeddb/create-and-remove-object-store.html: * storage/indexeddb/cursor-delete-expected.txt: * storage/indexeddb/cursor-delete.html: * storage/indexeddb/objectstore-removeobjectstore-expected.txt: * storage/indexeddb/objectstore-removeobjectstore.html: 2011-01-20 Hans Wennborg <hans@chromium.org> Reviewed by Jeremy Orlow. IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror https://bugs.webkit.org/show_bug.cgi?id=52725 Let IDBObjectStore.get() fire the onsuccess handler with the value 'undefined' for when an object does not exist in the store. Update SerializedScriptValue to provide such an undefined value. * bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue): * bindings/v8/SerializedScriptValue.h: * storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
reviewed by pavel feldman. webcore doesn't fire window.onerror event when uncaught javascript exceptions are thrown https://bugs.webkit.org/show_bug.cgi?id=8519 uncaught exceptions are propagated to window.onerror hander if one is present. the handler is expected to be a function accepting three arguments: error message, resource url and line number where the exception occured. it was decided to dispatch errorevent to all listeners/handlers no matter if they were created in the same isolated world where the exception occured or not. tests: fast/events/window-onerror1.html fast/events/window-onerror10.html fast/events/window-onerror11.html fast/events/window-onerror12.html fast/events/window-onerror2.html fast/events/window-onerror3.html fast/events/window-onerror4.html fast/events/window-onerror5.html fast/events/window-onerror6.html fast/events/window-onerror7.html fast/events/window-onerror8.html fast/events/window-onerror9.html http/tests/security/window-onerror-exception-in-iframe.html userscripts/window-onerror-for-isolated-world-1.html userscripts/window-onerror-for-isolated-world-2.html * android.jscbindings.mk: * cmakelists.txt: * gnumakefile.am: * webcore.gypi: * webcore.order: * webcore.pro: * webcore.vcproj/webcore.vcproj: * webcore.xcodeproj/project.pbxproj: * bindings/js/jsbindingsallinone.cpp: * bindings/js/jsdombinding.cpp: (webcore::reportexception): * bindings/js/jserrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.cpp. (webcore::jserrorhandler::jserrorhandler): (webcore::jserrorhandler::~jserrorhandler): (webcore::jserrorhandler::handleevent): * bindings/js/jserrorhandler.h: copied from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::jserrorhandler::create): (webcore::createjserrorhandler): * bindings/js/jseventlistener.h: * bindings/scripts/codegeneratorjs.pm: * bindings/scripts/codegeneratorv8.pm: * bindings/v8/v8consolemessage.cpp: (webcore::v8consolemessage::dispatchnow): (webcore::v8consolemessage::handler): the method was changed to use generic webcore exception reporting mechanism which is also used by jsc bindings. * bindings/v8/v8consolemessage.h: * bindings/v8/v8eventlistener.h: * bindings/v8/v8windowerrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::v8windowerrorhandler::v8windowerrorhandler): (webcore::v8windowerrorhandler::calllistenerfunction): * bindings/v8/v8windowerrorhandler.h: copied from webcore/dom/errorevent.cpp. (webcore::v8windowerrorhandler::create): * bindings/v8/workercontextexecutionproxy.cpp: (webcore::v8messagehandler): * bindings/v8/workerscriptcontroller.cpp: (webcore::workerscriptcontroller::evaluate): * dom/document.cpp: (webcore::document::erroreventtarget): (webcore::document::logexceptiontoconsole): (webcore::document::addmessage): * dom/document.h: * dom/errorevent.cpp: * dom/errorevent.h: * dom/event.cpp: (webcore::event::iserrorevent): * dom/event.h: * dom/scriptexecutioncontext.cpp: (webcore::scriptexecutioncontext::pendingexception::pendingexception): (webcore::scriptexecutioncontext::scriptexecutioncontext): (webcore::scriptexecutioncontext::reportexception): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in workercontext and in document. (webcore::scriptexecutioncontext::dispatcherrorevent): * dom/scriptexecutioncontext.h: * websockets/websocket.cpp: (webcore::websocket::connect): * websockets/websocketchannel.cpp: (webcore::websocketchannel::didopen): (webcore::websocketchannel::didfail): (webcore::websocketchannel::appendtobuffer): * websockets/websockethandshake.cpp: (webcore::websockethandshake::readserverhandshake): (webcore::websockethandshake::readstatusline): (webcore::websockethandshake::readhttpheaders): (webcore::websockethandshake::checkresponseheaders): * workers/defaultsharedworkerrepository.cpp: (webcore::postexceptiontask): (webcore::postconsolemessagetask): * workers/workercontext.cpp: (webcore::workercontext::workercontext): (webcore::workercontext::erroreventtarget): (webcore::workercontext::logexceptiontoconsole): (webcore::workercontext::addmessage): * workers/workercontext.h: * workers/workermessagingproxy.cpp: (webcore::workerexceptiontask::performtask): (webcore::postconsolemessagetask): * xml/xmlhttprequest.cpp: (webcore::reportunsafeusage): 2010-12-27 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown https://bugs.webkit.org/show_bug.cgi?id=8519 Uncaught exceptions are propagated to window.onerror hander if one is present. The handler is expected to be a function accepting three arguments: error message, resource url and line number where the exception occured. * fast/events/resources/window-onerror.js: Added. (throwException): * fast/events/window-onerror1-expected.txt: Added. * fast/events/window-onerror1.html: Added. * fast/events/window-onerror10-expected.txt: Added. * fast/events/window-onerror10.html: Added. * fast/events/window-onerror11-expected.txt: Added. * fast/events/window-onerror11.html: Added. * fast/events/window-onerror12-expected.txt: Added. * fast/events/window-onerror12.html: Added. * fast/events/window-onerror2-expected.txt: Added. * fast/events/window-onerror2.html: Added. * fast/events/window-onerror3-expected.txt: Added. * fast/events/window-onerror3.html: Added. * fast/events/window-onerror4-expected.txt: Added. * fast/events/window-onerror4.html: Added. * fast/events/window-onerror5-expected.txt: Added. * fast/events/window-onerror5.html: Added. * fast/events/window-onerror6-expected.txt: Added. * fast/events/window-onerror6.html: Added. * fast/events/window-onerror7-expected.txt: Added. * fast/events/window-onerror7.html: Added. * fast/events/window-onerror8-expected.txt: Added. * fast/events/window-onerror8.html: Added. * fast/events/window-onerror9-expected.txt: Added. * fast/events/window-onerror9.html: Added. * fast/workers/worker-script-error-expected.txt: * http/tests/security/resources/onerror-iframe.html: Added. * http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added. * http/tests/security/window-onerror-exception-in-iframe.html: Added. * platform/chromium-win/fast/workers/worker-script-error-expected.txt: * platform/chromium/fast/events/window-onerror1-expected.txt: Added. * platform/chromium/fast/events/window-onerror10-expected.txt: Added. * platform/chromium/fast/events/window-onerror11-expected.txt: Added. * platform/chromium/fast/events/window-onerror2-expected.txt: Added. * platform/chromium/fast/events/window-onerror3-expected.txt: Added. * platform/chromium/fast/events/window-onerror4-expected.txt: Added. * platform/chromium/fast/events/window-onerror5-expected.txt: Added. * platform/chromium/fast/events/window-onerror6-expected.txt: Added. * platform/chromium/fast/events/window-onerror7-expected.txt: Added. * platform/chromium/fast/events/window-onerror8-expected.txt: Added. * platform/chromium/fast/events/window-onerror9-expected.txt: Added. * platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added. * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added. * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added. * platform/gtk/Skipped: * userscripts/window-onerror-for-isolated-world-1-expected.txt: Added. * userscripts/window-onerror-for-isolated-world-1.html: Added. * userscripts/window-onerror-for-isolated-world-2-expected.txt: Added. * userscripts/window-onerror-for-isolated-world-2.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Ryosuke Niwa. Space and tab characters "sent" by an input method give totally different results than typing them directly. https://bugs.webkit.org/show_bug.cgi?id=5241 Added a test that exercises continous whitespace characters and tabs inserted by IME. * editing/inserting/insert-composition-whitespace-expected.txt: Added. * editing/inserting/insert-composition-whitespace.html: Added. 2011-01-19 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. Space and tab characters "sent" by an input method give totally different results than typing them directly https://bugs.webkit.org/show_bug.cgi?id=5241 * Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition. * Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that. Test: editing/inserting/insert-composition-whitespace.html * dom/TextEvent.h: (WebCore::TextEvent::isComposition): * dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType * editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string. * editing/CompositeEditCommand.h: * editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition): * editing/Editor.h: * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): * editing/InsertTextCommand.h: * editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines): * editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 Jan, 2011 8 commits
-
-
tkent@chromium.org authored
Reviewed by Kent Tamura. Make <keygen> no longer appear to be a <select> element to script. https://bugs.webkit.org/show_bug.cgi?id=52557 The intent is to put <keygen> options into shadow DOM. This change takes the first step by hiding the <select> element from JavaScript. Test: fast/dom/HTMLKeygenElement/keygen.html * CMakeLists.txt: Adds new IDL-derived wrapper. * DerivedSources.cpp: * DerivedSources.make: * GNUmakefile.am: * WebCore.gypi: * WebCore.pri: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/gobject/GNUmakefile.am: * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createKeygenWrapper): (WebKit::createHTMLElementWrapper): * bindings/objc/DOM.mm: (WebCore::createElementClassMap): Keygen no longer DOMHTMLSelectElement * html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Now public. * html/HTMLKeygenElement.idl: Added. * html/HTMLTagNames.in: Keygen's wrapper is HTMLKeygenElement. * page/DOMWindow.idl: Add HTMLKeygenElement constructor. 2011-01-19 Dominic Cooney <dominicc@google.com> Reviewed by Kent Tamura. Make <keygen> no longer appear to be a <select> element to script. https://bugs.webkit.org/show_bug.cgi?id=52557 * fast/dom/HTMLKeygenElement/keygen-expected.txt: Added. * fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Removed. * fast/dom/HTMLKeygenElement/keygen-option-select.html: Removed. * fast/dom/HTMLKeygenElement/keygen.html: Added. * fast/dom/Window/window-properties-expected.txt: * fast/dom/Window/window-property-descriptors-expected.txt: * fast/dom/prototype-inheritance-2-expected.txt: * fast/dom/prototype-inheritance-expected.txt: * fast/dom/wrapper-classes-expected.txt: * fast/dom/wrapper-classes.html: * fast/js/global-constructors-expected.txt: * platform/mac/fast/dom/wrapper-classes-objc-expected.txt: * platform/mac/fast/dom/wrapper-classes-objc.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
Unreviewed, rolling out r76203. http://trac.webkit.org/changeset/76203 https://bugs.webkit.org/show_bug.cgi?id=52784 Broke Win compile on Chromium bots (Requested by dimich on #webkit). * WebCore.gypi: * bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8): * page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): * platform/android/PlatformBridge.h: * platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile): * platform/chromium/ChromiumBridge.h: Added. * platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData): * platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL): * platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile): * platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage): * platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash): * platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): * platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): * platform/chromium/PlatformBridge.h: * platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect): * platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized): * platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString): * platform/chromium/ScrollbarThemeChromium.cpp: * platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength): * platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint): * platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize): * platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer): * platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination): * platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime): * platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData): * platform/graphics/chromium/CrossProcessFontLoading.mm: * platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont): * platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties): * platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle): * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): * platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource): * platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource): * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): * platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont): * platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): * platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS): * platform/qt/PlatformBridge.h: * platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize): * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess): * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: * plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins): * rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor): * rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): * rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar): * storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface): * storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath): 2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r76203. http://trac.webkit.org/changeset/76203 https://bugs.webkit.org/show_bug.cgi?id=52784 Broke Win compile on Chromium bots (Requested by dimich on #webkit). * WebKit.gyp: * src/AssertMatchingEnums.cpp: * src/ChromiumBridge.cpp: Renamed from Source/WebKit/chromium/src/PlatformBridge.cpp. (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::ChromiumBridge::cacheMetadata): (WebCore::ChromiumBridge::clipboardIsFormatAvailable): (WebCore::ChromiumBridge::clipboardReadPlainText): (WebCore::ChromiumBridge::clipboardReadHTML): (WebCore::ChromiumBridge::clipboardWriteSelection): (WebCore::ChromiumBridge::clipboardWritePlainText): (WebCore::ChromiumBridge::clipboardWriteURL): (WebCore::ChromiumBridge::clipboardWriteImage): (WebCore::ChromiumBridge::clipboardWriteData): (WebCore::ChromiumBridge::clipboardReadAvailableTypes): (WebCore::ChromiumBridge::clipboardReadData): (WebCore::ChromiumBridge::clipboardReadFilenames): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled): (WebCore::ChromiumBridge::prefetchDNS): (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::revealFolderInOS): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile): (WebCore::ChromiumBridge::ensureFontLoaded): (WebCore::ChromiumBridge::getFontFamilyForCharacters): (WebCore::ChromiumBridge::getRenderStyleForStrike): (WebCore::ChromiumBridge::loadFont): (WebCore::ChromiumBridge::databaseOpenFile): (WebCore::ChromiumBridge::databaseDeleteFile): (WebCore::ChromiumBridge::databaseGetFileAttributes): (WebCore::ChromiumBridge::databaseGetFileSize): (WebCore::ChromiumBridge::idbFactory): (WebCore::ChromiumBridge::idbShutdown): (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString): (WebCore::ChromiumBridge::computedDefaultLanguage): (WebCore::ChromiumBridge::layoutTestMode): (WebCore::ChromiumBridge::isSupportedImageMIMEType): (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType): (WebCore::ChromiumBridge::isSupportedNonImageMIMEType): (WebCore::ChromiumBridge::mimeTypeForExtension): (WebCore::ChromiumBridge::mimeTypeFromFile): (WebCore::ChromiumBridge::preferredExtensionForMIMEType): (WebCore::ChromiumBridge::plugins): (WebCore::ChromiumBridge::pluginScriptableObject): (WebCore::ChromiumBridge::loadPlatformImageResource): (WebCore::ChromiumBridge::loadPlatformAudioResource): (WebCore::ChromiumBridge::decodeAudioFileData): (WebCore::ChromiumBridge::sandboxEnabled): (WebCore::ChromiumBridge::setSharedTimerFiredFunction): (WebCore::ChromiumBridge::setSharedTimerFireTime): (WebCore::ChromiumBridge::stopSharedTimer): (WebCore::ChromiumBridge::decrementStatsCounter): (WebCore::ChromiumBridge::incrementStatsCounter): (WebCore::ChromiumBridge::histogramCustomCounts): (WebCore::ChromiumBridge::histogramEnumeration): (WebCore::ChromiumBridge::suddenTerminationChanged): (WebCore::ChromiumBridge::currentTime): (WebCore::ChromiumBridge::paintButton): (WebCore::ChromiumBridge::paintMenuList): (WebCore::ChromiumBridge::paintScrollbarArrow): (WebCore::ChromiumBridge::paintScrollbarThumb): (WebCore::ChromiumBridge::paintScrollbarTrack): (WebCore::ChromiumBridge::paintSpinButton): (WebCore::ChromiumBridge::paintTextField): (WebCore::ChromiumBridge::paintTrackbar): (WebCore::ChromiumBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::ChromiumBridge::getThemePartSize): (WebCore::ChromiumBridge::paintThemePart): (WebCore::ChromiumBridge::traceEventBegin): (WebCore::ChromiumBridge::traceEventEnd): (WebCore::ChromiumBridge::visitedLinkHash): (WebCore::ChromiumBridge::isLinkVisited): (WebCore::ChromiumBridge::notifyJSOutOfMemory): (WebCore::ChromiumBridge::memoryUsageMB): (WebCore::ChromiumBridge::actualMemoryUsageMB): (WebCore::ChromiumBridge::screenDepth): (WebCore::ChromiumBridge::screenDepthPerComponent): (WebCore::ChromiumBridge::screenIsMonochrome): (WebCore::ChromiumBridge::screenRect): (WebCore::ChromiumBridge::screenAvailableRect): (WebCore::ChromiumBridge::popupsAllowed): (WebCore::WorkerContextProxy::create): * src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha https://bugs.webkit.org/show_bug.cgi?id=52705 This is related to bug 52611. The shadow color alpha must be multiplied by the context pen alpha. Fixing this results in correct behavior for Canvas path stroke() and strokeRect() [which relies on stroke()]. * fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added. * fast/canvas/canvas-strokePath-alpha-shadow.html: Added. * fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added. * fast/canvas/canvas-strokeRect-alpha-shadow.html: Added. * fast/canvas/script-tests/canvas-strokePath-alpha-shadow.js: Added. * fast/canvas/script-tests/canvas-strokeRect-alpha-shadow.js: Added. 2011-01-19 Helder Correia <helder@sencha.com> Reviewed by Andreas Kling. [Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha https://bugs.webkit.org/show_bug.cgi?id=52705 This is related to bug 52611. The shadow color alpha must be multiplied by the context pen alpha. Fixing this results in correct behavior for Canvas path stroke() and strokeRect() [which relies on stroke()]. Tests: fast/canvas/canvas-strokePath-alpha-shadow.html fast/canvas/canvas-strokeRect-alpha-shadow.html * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@chromium.org authored
Reviewed by Mihai Parparita. Re-initialize the HistoryItem fully when navigating to a HistoryItem, or replacing a HistoryItem, results in a different URL. https://bugs.webkit.org/show_bug.cgi?id=49654 This patch also forces all HistoryItems to record the post-redirect URL. Previously, frames would remember the pre-redirect URL. This is problematic since other members of the HistoryItem correspond to the post-redirect URL. Tests: fast/history/history-replace-updates-current-item.html http/tests/navigation/redirect-on-back-updates-history-item.html http/tests/navigation/redirect-on-reload-updates-history-item.html * history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::reset): * history/HistoryItem.h: * loader/HistoryController.cpp: (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::initializeItem): (WebCore::HistoryController::createItem): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::updateCurrentItem): * loader/HistoryController.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Fisher. [chromium] Rename ChromiumBridge to PlatformBridge https://bugs.webkit.org/show_bug.cgi?id=52471 No tests added as this is a rename; no change in behavior. * WebCore.gypi: * bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8): * page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): * platform/android/PlatformBridge.h: * platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile): * platform/chromium/ChromiumBridge.h: Removed. * platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData): * platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL): * platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile): * platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage): * platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash): * platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): * platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): * platform/chromium/PlatformBridge.h: * platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect): * platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized): * platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString): * platform/chromium/ScrollbarThemeChromium.cpp: * platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength): * platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint): * platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize): * platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer): * platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination): * platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime): * platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData): * platform/graphics/chromium/CrossProcessFontLoading.mm: * platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont): * platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties): * platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle): * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): * platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource): * platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource): * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): * platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont): * platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie): * platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS): * platform/qt/PlatformBridge.h: * platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize): * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess): * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: * plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins): * rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor): * rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): * rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar): * storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface): * storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath): 2011-01-19 Adam Klein <adamk@chromium.org> Reviewed by Darin Fisher. [chromium] Rename ChromiumBridge to PlatformBridge https://bugs.webkit.org/show_bug.cgi?id=52471 * WebKit.gyp: * src/AssertMatchingEnums.cpp: * src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create): * src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
Unreviewed, rolling out r76187. http://trac.webkit.org/changeset/76187 https://bugs.webkit.org/show_bug.cgi?id=52778 Broke caret-showing tests on SnowLeopard and Chromium (Requested by dimich on #webkit). * editing/selection/caret-painting-in-overflowing-autowrap-content.html: Removed. * editing/selection/resources/iframe-positioning-caret-at-end.html: Removed. * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Removed. * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Removed. * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Removed. 2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r76187. http://trac.webkit.org/changeset/76187 https://bugs.webkit.org/show_bug.cgi?id=52778 Broke caret-showing tests on SnowLeopard and Chromium (Requested by dimich on #webkit). * rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Reviewed by Kent Tamura. Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks https://bugs.webkit.org/show_bug.cgi?id=52279 * fast/css/first-letter-anonymous-block-crash-expected.txt: Added. * fast/css/first-letter-anonymous-block-crash.html: Added. 2011-01-19 Yuzo Fujishima <yuzo@google.com> Reviewed by Kent Tamura. Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks https://bugs.webkit.org/show_bug.cgi?id=52279 In constructing text fragments to handle first-letter rule, first add the text for the non-first letters and then remove the original text, rather than the other way around. Otherwise, the text can be added to an anoymous block that is different from the original one. This breaks the assumption that a first letter render object has a non-null sibling for the non-first letters and causes a crash. Test: fast/css/first-letter-anonymous-block-crash.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
Unreviewed, rolling out r76194. http://trac.webkit.org/changeset/76194 https://bugs.webkit.org/show_bug.cgi?id=51218 Caused mysterious compile failure on the chromium win build.webkit.org bots * fast/animation/request-animation-frame-cancel-expected.txt: Removed. * fast/animation/request-animation-frame-cancel.html: Removed. * fast/animation/request-animation-frame-cancel2-expected.txt: Removed. * fast/animation/request-animation-frame-cancel2.html: Removed. * fast/animation/request-animation-frame-display-expected.txt: Removed. * fast/animation/request-animation-frame-display.html: Removed. * fast/animation/request-animation-frame-expected.txt: Removed. * fast/animation/request-animation-frame-within-callback-expected.txt: Removed. * fast/animation/request-animation-frame-within-callback.html: Removed. * fast/animation/request-animation-frame.html: Removed. * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2011-01-19 James Robinson <jamesr@chromium.org> Unreviewed, rolling out r76194. http://trac.webkit.org/changeset/76194 https://bugs.webkit.org/show_bug.cgi?id=51218 Caused mysterious compile failure on the chromium win build.webkit.org bots * WebCore.gypi: * dom/Document.cpp: (WebCore::Document::Document): * dom/Document.h: * dom/RequestAnimationFrameCallback.h: Removed. * dom/RequestAnimationFrameCallback.idl: Removed. * loader/EmptyClients.h: * page/Chrome.cpp: * page/Chrome.h: * page/ChromeClient.h: * page/DOMWindow.cpp: * page/DOMWindow.h: * page/DOMWindow.idl: * page/FrameView.cpp: * page/FrameView.h: * platform/HostWindow.h: 2011-01-19 James Robinson <jamesr@chromium.org> Unreviewed, rolling out r76194. http://trac.webkit.org/changeset/76194 https://bugs.webkit.org/show_bug.cgi?id=51218 Caused mysterious compile failure on the chromium win build.webkit.org bots * features.gypi: * public/WebWidget.h: * public/WebWidgetClient.h: * src/ChromeClientImpl.cpp: * src/ChromeClientImpl.h: * src/WebPopupMenuImpl.cpp: * src/WebPopupMenuImpl.h: * src/WebViewImpl.cpp: * src/WebViewImpl.h: 2011-01-19 James Robinson <jamesr@chromium.org> Unreviewed, rolling out r76194. http://trac.webkit.org/changeset/76194 https://bugs.webkit.org/show_bug.cgi?id=51218 Caused mysterious compile failure on the chromium win build.webkit.org bots * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion): * DumpRenderTree/chromium/WebViewHost.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-