1. 20 Jan, 2011 40 commits
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · 5ddfb04e
      jamesr@google.com authored
              Reviewed by Eric Seidel.
      
              RenderTableSection's setNeedsCellRecalc needs to null check table()
              https://bugs.webkit.org/show_bug.cgi?id=52770
      
              Tests ::-webkit-scrollbar-corner inside a table.
      
              * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
              * fast/css-generated-content/table-with-scrollbar-corner.html: Added.
      2011-01-20  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Eric "Baller" Seidel.
      
              RenderTableSection's setNeedsCellRecalc needs to null check table()
              https://bugs.webkit.org/show_bug.cgi?id=52770
      
              Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
              This can be null during detach().  Test constructed by Eric Seidel.
      
              Test: fast/css-generated-content/table-with-scrollbar-corner.html
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::setNeedsCellRecalc):
              * rendering/RenderTableSection.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ddfb04e
    • msaboff@apple.com's avatar
      2011-01-20 Michael Saboff <msaboff@apple.com> · 633f239b
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
              https://bugs.webkit.org/show_bug.cgi?id=52773
      
              Fixed case where an existing DataLabelPtr is overwritten.  The
              replacing DataLabelPtr is now resolved immediately in
              linkDataLabelToBacktrackIfExists().  Cleanup - eliminated bool
              return value for the routine as it was never used.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
      2011-01-20  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
              https://bugs.webkit.org/show_bug.cgi?id=52773
      
              New test to validate fix.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      633f239b
    • krit@webkit.org's avatar
      2011-01-20 Dirk Schulze <krit@webkit.org> · d7140cc3
      krit@webkit.org authored
              Reviewed by Rob Buis.
      
              SVG Pattern doesn't take preserveAspectRatio of references Pattern
              https://bugs.webkit.org/show_bug.cgi?id=52802
      
              SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
              in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.
      
              Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg
      
              * rendering/svg/RenderSVGResourcePattern.cpp:
              (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
              * svg/PatternAttributes.h:
              (WebCore::PatternAttributes::PatternAttributes):
              (WebCore::PatternAttributes::preserveAspectRatio):
              (WebCore::PatternAttributes::setPreserveAspectRatio):
              (WebCore::PatternAttributes::hasPreserveAspectRatio):
              * svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::collectPatternAttributes):
      2011-01-20  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Rob Buis.
      
              SVG Pattern doesn't take preserveAspectRatio of references Pattern
              https://bugs.webkit.org/show_bug.cgi?id=52802
      
              Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.
      
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
              * svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7140cc3
    • mitz@apple.com's avatar
      <rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1 · d557175d
      mitz@apple.com authored
      Reviewed by Adele Peterson.
      
      <rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
      https://bugs.webkit.org/show_bug.cgi?id=52765
      
      <rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
      https://bugs.webkit.org/show_bug.cgi?id=52265
      
      Source/WebCore: 
      
      Test: fast/block/line-layout/negative-max-height.html
      
      Integer overflow detection led to a block having a huge height. This manifested as broken layout
      in the first bug and as extreme slowness in the latter bugs because of
      https://bugs.webkit.org/show_bug.cgi?id=52832
      
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
      cannot start above this line. The negative maxHeight also caused the integer overflow detection
      logic to give the block a huge height.
      
      LayoutTests: 
      
      * fast/block/line-layout: Added.
      * fast/block/line-layout/negative-max-height-expected.checksum: Added.
      * fast/block/line-layout/negative-max-height-expected.png: Added.
      * fast/block/line-layout/negative-max-height-expected.txt: Added.
      * fast/block/line-layout/negative-max-height.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d557175d
    • yi.4.shen@nokia.com's avatar
      2011-01-20 Yi Shen <yi.4.shen@nokia.com> · b5cbaed7
      yi.4.shen@nokia.com authored
              Reviewed by Eric Carlson.
      
              Clean up the Media Controls CSS for Qt
              https://bugs.webkit.org/show_bug.cgi?id=52822
      
              Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
              in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
              rules from mediaControlsQtFullscreen.css.
      
              * css/mediaControlsQt.css:
              (audio::-webkit-media-controls-panel):
              (video::-webkit-media-controls-panel):
              (audio::-webkit-media-controls-mute-button):
              (video::-webkit-media-controls-mute-button):
              (audio::-webkit-media-controls-play-button):
              (video::-webkit-media-controls-play-button):
              (audio::-webkit-media-controls-timeline-container):
              (video::-webkit-media-controls-timeline-container):
              (audio::-webkit-media-controls-current-time-display):
              (video::-webkit-media-controls-current-time-display):
              (audio::-webkit-media-controls-time-remaining-display):
              (video::-webkit-media-controls-time-remaining-display):
              (audio::-webkit-media-controls-timeline):
              (video::-webkit-media-controls-timeline):
              (audio::-webkit-media-controls-volume-slider-container):
              (video::-webkit-media-controls-volume-slider-container):
              (audio::-webkit-media-controls-volume-slider):
              (video::-webkit-media-controls-volume-slider):
              (audio::-webkit-media-controls-seek-back-button):
              (video::-webkit-media-controls-seek-back-button):
              (audio::-webkit-media-controls-seek-forward-button):
              (video::-webkit-media-controls-seek-forward-button):
              (audio::-webkit-media-controls-fullscreen-button):
              (video::-webkit-media-controls-fullscreen-button):
              (audio::-webkit-media-controls-rewind-button):
              (video::-webkit-media-controls-rewind-button):
              (audio::-webkit-media-controls-return-to-realtime-button):
              (video::-webkit-media-controls-return-to-realtime-button):
              (audio::-webkit-media-controls-toggle-closed-captions-button):
              (video::-webkit-media-controls-toggle-closed-captions-button):
              * css/mediaControlsQtFullscreen.css:
              (video::-webkit-media-controls-time-remaining-display):
              (video::-webkit-media-controls-seek-back-button):
              (video::-webkit-media-controls-seek-forward-button):
              (video::-webkit-media-controls-rewind-button):
              (video::-webkit-media-controls-return-to-realtime-button):
              (video::-webkit-media-controls-toggle-closed-captions-button):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5cbaed7
    • ojan@chromium.org's avatar
      2011-01-20 Ojan Vafai <ojan@chromium.org> · c60e7f83
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              fix goofup in http://trac.webkit.org/changeset/76082
              https://bugs.webkit.org/show_bug.cgi?id=52830
      
              We were showing the revision number of the patch at the bottom
              of the diff and expanding from the bottom of the diff would fail.
      
              Also, removed an unused variable and scoped queries appropriatly
              to the file_diff they should have been operating on.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60e7f83
    • ojan@chromium.org's avatar
      2011-01-19 Ojan Vafai <ojan@chromium.org> · 1a0c4962
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              [reviewtool] Add a link for annotated trac page on review page
              https://bugs.webkit.org/show_bug.cgi?id=52747
      
              -add line numbers to all trac links to the first line in the file diff
              -add annotate/review log links
              -make file-diff links other than the file name only show when you mouseover the filediff
              -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a0c4962
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · d2fd033d
      rniwa@webkit.org authored
              Unreviewed Chromium rebaseline for r76236.
      
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2fd033d
    • ojan@chromium.org's avatar
      2011-01-14 Ojan Vafai <ojan@chromium.org> · 008dd4f2
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              make line selection have a extend only from where you start the selection in the code review tool
              https://bugs.webkit.org/show_bug.cgi?id=52485
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      008dd4f2
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · 562ac858
      kdecker@apple.com authored
              <rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
              https://bugs.webkit.org/show_bug.cgi?id=52823
              
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto.
              (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      562ac858
    • apavlov@chromium.org's avatar
      2011-01-20 Alexander Pavlov <apavlov@chromium.org> · b073cf74
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
              https://bugs.webkit.org/show_bug.cgi?id=52816
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b073cf74
    • commit-queue@webkit.org's avatar
      2011-01-20 Dawit Alemayehu <adawit@kde.org> · 6de04dae
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Fix Layering violation in MediaPlayerPrivateQt.
              https://bugs.webkit.org/show_bug.cgi?id=52733
      
              No new tests. no behavioral change.
      
             * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::commitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6de04dae
    • japhet@chromium.org's avatar
      2011-01-20 Nate Chapin <japhet@chromium.org> · 243ab97a
      japhet@chromium.org authored
              Reviewed by Darin Fisher.
      
              [V8] Call malloc and memcpy directly instead of
              of strdup in convertV8ObjectToNPVariant() when
              converting strings. If there is a null character
              in the string, our use of strdup causes us to allocate
              too little memory, leading to out of bounds reads.
      
              https://bugs.webkit.org/show_bug.cgi?id=52631
      
              * bindings/v8/V8NPUtils.cpp:
              (WebCore::convertV8ObjectToNPVariant):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243ab97a
    • abecsi@webkit.org's avatar
      2011-01-20 Andras Becsi <abecsi@webkit.org> · 30f524a6
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt][WK2] WebKit2 enabled build fails to link
      
              Work around undefined reference linking issues until the buildsystem gets redesigned.
              These issues first occured in minimal builds (see BUG 50519).
      
              * JavaScriptCore.pri: link as whole-archive for WebKit2 builds
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30f524a6
    • commit-queue@webkit.org's avatar
      2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> · ab8d0167
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Remove null ptr deref that happens when reattaching to
              a new web process.
      
              Implement didRelaunchProcess that sets the drawing area size
              after the drawing area is re-instantiated.
      
              [Qt][WK2] Null ptr deref in UI process after web process has crashed
              https://bugs.webkit.org/show_bug.cgi?id=52796
      
              * UIProcess/API/qt/qgraphicswkview.cpp:
              (QGraphicsWKView::QGraphicsWKView):
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::QWKPagePrivate):
              (QWKPagePrivate::init):
              (QWKPagePrivate::createDrawingAreaProxy):
              (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
              * UIProcess/API/qt/qwkpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8d0167
    • philn@webkit.org's avatar
      2011-01-20 Philippe Normand <pnormand@igalia.com> · 75e55b2f
      philn@webkit.org authored
              Unreviewed, remove GTK result for window-onerror2 as it's the same
              as the generic results file.
      
              * platform/gtk/fast/events/window-onerror2-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e55b2f
    • andreas.kling@nokia.com's avatar
      2011-01-20 Andreas Kling <kling@webkit.org> · ff7f5455
      andreas.kling@nokia.com authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Fill shadow scratch buffer with proper transparent pixels
      
              QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
              so doing QImage::fill(Qt::transparent) will actually fill all pixels with
              the RGBA value 0x00000013.
      
              * platform/graphics/qt/ContextShadowQt.cpp:
              (WebCore::ShadowBuffer::scratchImage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7f5455
    • mjs@apple.com's avatar
      2011-01-20 Maciej Stachowiak <mjs@apple.com> · 7977a528
      mjs@apple.com authored
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
      
              * platform/mac-wk2/Skipped: Unskip the tests that needed this.
      2011-01-20  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
              
              Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
              that corresponds to a JSContextRef (or null if none).
      
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame
              static method.
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
              * WebProcess/WebPage/WebFrame.h:
      2011-01-20  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
      
              * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
              for methods that take their normal arguments but also a JSContextRef.
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
              for evaluateScriptInIsolatedWorld.
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
              this call is for an isolated world.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::worldMap): Helper to create a world map.
              (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
              (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
              added LayoutTestController API.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7977a528
    • aroben@apple.com's avatar
      Remove WKCACFContextFlusher · bc7c2770
      aroben@apple.com authored
      It wasn't doing anything.
      
      Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused
      
      Reviewed by Simon Fraser.
      
      * WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with
      the file.
      
      * platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
      * platform/graphics/win/WKCACFContextFlusher.h: Removed.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
      (WebCore::WKCACFLayerRenderer::layerTreeDidChange):
      Stop telling WKCACFContextFlusher about our context, since it never did anything with it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc7c2770
    • aroben@apple.com's avatar
      Only flush our own context when we get resized · 862e3837
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
      changes get flushed whenever any composited page is resized
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
      WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      862e3837
    • aroben@apple.com's avatar
      Make WKCACFLayerRenderer ref-counted · a60ce714
      aroben@apple.com authored
      This will be needed to handle cases where the client might release its reference to us while
      we're calling out to it.
      
      WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
      client to create(). This allows clients to null out the client pointer when they're done
      with the renderer.
      
      Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
      ref-counted
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
      Updated for WKCACFLayerRenderer changes.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
      create().
      (WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
      returns a PassOwnPtr.
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
      WKCACFLayerRendererClient.
      
      * platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from
      RefCounted.
      (WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.
      
      Source/WebKit/win:
      
      Update for WKCACFLayerRenderer changes
      
      * WebView.cpp:
      (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
      compositing-related members. My biggest concern was making sure that m_layerRenderer was
      gone, which would also mean we had nulled out its client pointer.
      (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
      of passing the client into create(), and to clear out the client before nulling out
      m_layerRenderer.
      
      * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60ce714
    • aroben@apple.com's avatar
      Convert paths in environment variables back to msys-style inside commit-log-editor · 16f98219
      aroben@apple.com authored
      When this script gets run from inside git commit, msys-style paths in the environment will
      have been turned into Windows-style paths with forward slashes. This screws up functions
      like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
      the paths back to msys-style before doing anything else.
      
      Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
      using msysgit's Perl and multiple ChangeLogs have been edited
      
      Reviewed by David Kilzer.
      
      * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
      (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
      inside git commit), convert Windows-style paths in the environment back to msys-style paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16f98219
    • aroben@apple.com's avatar
      Teach WebView::scrollBackingStore about compositing mode · 622c8364
      aroben@apple.com authored
      Test:
          compositing/scroll-painted-composited-content.html
      
      Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
      WebView::scrollBackingStore when scrolling page with composited content
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
      mode, rather than incorrectly asserting that this function is never called in that case. For
      now we just repaint the entire scrolled region; someday hopefully we can avoid having to
      repaint the areas that have just been moved.
      
      LayoutTests:
      
      Add a test that scrolls composited content that has already been painted
      
      * compositing/scroll-painted-composited-content.html: Added.
      * compositing/scroll-painted-composited-content-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622c8364
    • zoltan@webkit.org's avatar
      [Win] Unreviewed build fix after r76248. · 18a6fc4c
      zoltan@webkit.org authored
      * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a6fc4c
    • alex@webkit.org's avatar
      2011-01-20 Alejandro G. Castro <alex@igalia.com> · 252fa1d3
      alex@webkit.org authored
              Fix compilation error in GTK WebKit2.
      
              * Platform/CoreIPC/gtk/ConnectionGtk.cpp:
              (CoreIPC::readBytesFromSocket):
              (CoreIPC::writeBytesToSocket):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      252fa1d3
    • ossy@webkit.org's avatar
      [Qt][V8] Unreviewed buildfix after r76248. · 82a91a41
      ossy@webkit.org authored
      * bindings/v8/ScriptCachedFrameData.h: Add missing include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82a91a41
    • alex@webkit.org's avatar
      2011-01-20 Alejandro G. Castro <alex@igalia.com> · 24aecf5f
      alex@webkit.org authored
              Reviewed by Andreas Kling.
      
              [GTK] Fix typo in the webkit2 section of the configure.ac file
              https://bugs.webkit.org/show_bug.cgi?id=52801
      
              Fixed typo in the GTK WebKit2 compilation.
      
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24aecf5f
    • pfeldman@chromium.org's avatar
      2011-01-20 Pavel Feldman <pfeldman@chromium.org> · 0d1b5034
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: enable resource agent upon request.
              https://bugs.webkit.org/show_bug.cgi?id=52815
      
              We should not send network-related notifications unless front-end
              is interested.
      
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::resourceAgent):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::consoleAgent):
              (WebCore::InspectorController::cssAgent):
              (WebCore::InspectorController::domAgent):
              (WebCore::InspectorController::injectedScriptAgent):
              (WebCore::InspectorController::runtimeAgent):
              (WebCore::InspectorController::databaseAgent):
              (WebCore::InspectorController::domStorageAgent):
              (WebCore::InspectorController::fileSystemAgent):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::retrieveResourceAgent):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::restore):
              (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
              (WebCore::InspectorResourceAgent::InspectorResourceAgent):
              * inspector/InspectorResourceAgent.h:
              (WebCore::InspectorResourceAgent::create):
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d1b5034
    • ossy@webkit.org's avatar
      Refactoring of the custom allocation framework · 95c1bc42
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49897
      
      Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
      Reviewed by Csaba Osztrogonác.
      
      Source/JavaScriptCore:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      * wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.
      
      Source/WebCore:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the necessary places.
      
      Source/WebKit:
      
      Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
      The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
      equivalent macro implementation at the n...
      95c1bc42
    • mnaganov@chromium.org's avatar
      2011-01-20 Mikhail Naganov <mnaganov@chromium.org> · 57fe9f7f
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.
      
              Profiles are now not cleared unless renderer instance was changed.
      
              https://bugs.webkit.org/show_bug.cgi?id=52807
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreProfiler):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
              * inspector/InspectorProfilerAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57fe9f7f
    • apavlov@chromium.org's avatar
      2011-01-20 Alexander Pavlov <apavlov@chromium.org> · 561c2269
      apavlov@chromium.org authored
              Unreviewed, add new JS file refs missing from r76116.
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/WebKit.qrc:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      561c2269
    • apavlov@chromium.org's avatar
      2011-01-20 Alexander Pavlov <apavlov@chromium.org> · d41cebd0
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Crash when adding a rule for an ImageDocument
              https://bugs.webkit.org/show_bug.cgi?id=52811
      
              * inspector/InspectorCSSAgent.cpp:
              (WebCore::InspectorCSSAgent::addRule2):
              (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d41cebd0
    • yurys@chromium.org's avatar
      2011-01-20 Yury Semikhatsky <yurys@chromium.org> · 51223959
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Make fast/events/window-onerror2.html throw exception in deterministic order
              https://bugs.webkit.org/show_bug.cgi?id=52813
      
              * fast/events/window-onerror2-expected.txt:
              * fast/events/window-onerror2.html: call setTimeout from onload handler to make sure exception
              in the onload handler will be processed before the one in the setTimeout callback
              * platform/chromium/fast/events/window-onerror2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51223959
    • yi.4.shen@nokia.com's avatar
      2011-01-20 Yi Shen <yi.4.shen@nokia.com> · 64ea938b
      yi.4.shen@nokia.com authored
              Unreviewed. 
      
              Adding myself to committers.py.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ea938b
    • philn@webkit.org's avatar
      2011-01-20 Philippe Normand <pnormand@igalia.com> · 25fcf7cf
      philn@webkit.org authored
              Unreviewed, new GTK svg test baselines as follow-up of r76236.
      
              * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25fcf7cf
    • philn@webkit.org's avatar
      2011-01-20 Philippe Normand <pnormand@igalia.com> · 3384be0c
      philn@webkit.org authored
              Unreviewed, update window-onerror2.html baselines as follow-up of r76216.
      
              * platform/gtk/fast/events/window-onerror2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3384be0c
    • loislo@chromium.org's avatar
      2011-01-20 Ilya Tikhonovsky <loislo@chromium.org> · a167d475
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: cleanup InspectorController's friends list.
              We have a plan to extract InspectorAgent from InspectorController.
              InspectorAgent will be accessible only from InspectorController.
              As result we can simply made some methods public and remove long
              friends list.
      
              https://bugs.webkit.org/show_bug.cgi?id=52806
      
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              (WebCore::InjectedScriptHost::frontend):
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::frontend):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didFailLoadingImpl):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
              (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
              (WebCore::InspectorInstrumentation::retrieveResourceAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a167d475
    • podivilov@chromium.org's avatar
      2011-01-19 Pavel Podivilov <podivilov@chromium.org> · 48a73855
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
              https://bugs.webkit.org/show_bug.cgi?id=52723
      
              Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
      
              * inspector/front-end/Breakpoint.js:
              (WebInspector.Breakpoint):
              (WebInspector.Breakpoint.prototype.get data):
              (WebInspector.Breakpoint.prototype.remove):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.JavaScriptBreakpointsSidebarPane):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint):
              (WebInspector.NativeBreakpointsSidebarPane):
              (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.removeBreakpoint):
              (WebInspector.DebuggerModel.prototype.breakpointForId):
              (WebInspector.DebuggerModel.prototype._pausedScript):
              (WebInspector.DebuggerModel.prototype._resumedScript):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48a73855
    • philn@webkit.org's avatar
      2011-01-20 Philippe Normand <pnormand@igalia.com> · 6b50f1db
      philn@webkit.org authored
              Unreviewed, new GTK baselines for 2 new tests.
      
              * platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
              * platform/gtk/svg/css/text-gradient-shadow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b50f1db
    • yurys@chromium.org's avatar
      2011-01-20 Yury Semikhatsky <yurys@chromium.org> · 5ee99bfa
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations.
      
              * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
              * platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
              * platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ee99bfa