1. 15 Jun, 2012 40 commits
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in networkinformation, perf,... · 5cf7fa8a
      rniwa@webkit.org authored
      Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
      https://bugs.webkit.org/show_bug.cgi?id=89181
      
      Reviewed by Kent Tamura.
      
      * perf/clone-with-focus.html:
      * perf/nested-combined-selectors.html:
      * perf/table-rows-length-caching.html:
      * platform/chromium/plugins/call-as-function.html:
      * platform/chromium/plugins/get-url-with-blank-target2.html:
      * platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
      * platform/chromium/printing/custom-page-size-style-expected.txt:
      * platform/chromium/printing/custom-page-size-style.html:
      * platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
      * platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
      * platform/mac-wk2/plugins/contents-scale-factor.html:
      * platform/mac-wk2/plugins/mouse-events-scaled.html:
      * platform/mac/plugins/bindings-array-apply-crash.html:
      * platform/mac/plugins/bindings-objc-long-method-name.html:
      * platform/mac/plugins/bindings-objc-method-name-conversion.html:
      * platform/mac/plugins/bindings-test-objc.html:
      * platform/mac/plugins/call-as-function-test.html:
      * platform/mac/plugins/convert-point.html:
      * platform/mac/plugins/disable-plugins.html:
      * platform/mac/plugins/jsobjc-dom-wrappers.html:
      * platform/mac/plugins/jsobjc-simple.html:
      * platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
      * platform/mac/plugins/root-object-premature-delete-crash.html:
      * platform/mac/plugins/supports-carbon-event-model.html:
      * platform/mac/plugins/testplugin-onnew-onpaint.html:
      * platform/mac/plugins/throw-on-dealloc.html:
      * platform/mac/plugins/undefined-property-crash.html:
      * platform/mac/plugins/update-widget-from-style-recalc.html:
      * platform/mac/plugins/webScriptObject-exception-deadlock.html:
      * platform/mac/scrollbars/key-window-not-first-responder.html:
      * platform/qt/plugins/application-plugin-plugins-disabled.html:
      * platform/win/plugins/call-javascript-that-destroys-plugin.html:
      * platform/win/plugins/get-value-netscape-window.html:
      * platform/win/plugins/iframe-inside-overflow.html:
      * platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
      * platform/win/plugins/visibility-hidden.html:
      * platform/win/plugins/window-geometry-initialized-before-set-window.html:
      * platform/win/plugins/window-region-is-set-to-clip-rect.html:
      * platform/win/plugins/windowless-paint-rect-coordinates.html:
      * plugins/:
      * pointer-lock/lock-fail-responses-expected.txt:
      * pointer-lock/lock-fail-responses.html:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      * pointer-lock/pointerlocklost-event-expected.txt:
      * pointer-lock/pointerlocklost-event.html:
      * printing/compositing-layer-printing.html:
      * printing/css2.1/README.txt:
      * printing/css2.1/page-break-after-000.html:
      * printing/css2.1/page-break-after-001.html:
      * printing/css2.1/page-break-after-002.html:
      * printing/css2.1/page-break-after-003.html:
      * printing/css2.1/page-break-after-004.html:
      * printing/css2.1/page-break-before-000.html:
      * printing/css2.1/page-break-before-001.html:
      * printing/css2.1/page-break-before-002.html:
      * printing/css2.1/page-break-inside-000.html:
      * printing/iframe-print.html:
      * printing/media-queries-print.html:
      * printing/numberOfPages-expected.txt:
      * printing/page-count-layout-overflow.html:
      * printing/page-count-relayout-shrink.html:
      * printing/page-count-with-one-word.html:
      * printing/page-format-data-display-none.html:
      * printing/page-format-data-expected.txt:
      * printing/page-format-data.html:
      * printing/page-rule-css-text.html:
      * printing/page-rule-in-media-query.html:
      * printing/page-rule-selection-expected.txt:
      * printing/page-rule-selection.html:
      * printing/pageNumerForElementById-expected.txt:
      * printing/print-close-crash.html:
      * printing/pseudo-class-outside-page.html:
      * printing/resources/paged-media-test-utils.js:
      (pageNumberForElementShouldBe):
      (numberOfPagesShouldBe):
      (runPrintingTest):
      * printing/return-from-printing-mode.html:
      * printing/script-tests/numberOfPages.js:
      * printing/script-tests/pageNumerForElementById.js:
      * printing/setPrinting.html:
      * printing/simultaneous-position-float-change.html:
      * printing/single-line-must-not-be-split-into-two-pages.html:
      * printing/width-overflow.html:
      * printing/zoomed-document.html:
      * scrollbars/hidden-iframe-scrollbar-crash.html:
      * scrollbars/hidden-iframe-scrollbar-crash2.html:
      * scrollbars/hidden-scrollbar-prevents-layout.html:
      * scrollbars/overflow-custom-scrollbar-crash.html:
      * scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
      * scrollbars/scroll-rtl-or-bt-layer.html:
      * scrollbars/scrollable-iframe-remove-crash.html:
      * scrollbars/scrollbar-click-does-not-blur-content.html:
      * scrollbars/scrollbar-crash-on-refresh.html:
      * scrollbars/scrollbar-drag-thumb-with-large-content.html:
      * scrollbars/scrollbar-gradient-crash.html:
      * scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
      * scrollbars/scrollbar-initial-position.html:
      * scrollbars/scrollbar-middleclick-nopaste.html:
      * scrollbars/scrollbar-miss-mousemove-disabled.html:
      * scrollbars/scrollbar-miss-mousemove.html:
      * scrollbars/scrollbar-owning-renderer-crash.html:
      * scrollbars/scrollbar-part-created-with-no-parent-crash.html:
      * scrollbars/scrollbar-percent-padding-crash.html:
      * scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
      * scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
      * scrollbars/scrollevent-iframe-no-scrolling.html:
      * security/autocomplete-cleared-on-back.html:
      * security/block-test-no-port.html:
      * security/block-test.html:
      * security/set-form-autocomplete-attribute.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cf7fa8a
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in ietestcenter, inspector,... · 08372332
      rniwa@webkit.org authored
      Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
      https://bugs.webkit.org/show_bug.cgi?id=89176
      
      Reviewed by Kent Tamura.
      
      * ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
      * inspector/audits/resources/audits-style1.css:
      * inspector/console/console-long-eval-crash.html:
      * inspector/extensions/extensions-audits-content-script.html:
      * inspector/extensions/extensions-eval-content-script.html:
      * inspector/profiler/cpu-profiler-profiling-without-inspector.html:
      * inspector/timeline/timeline-animation-frame.html:
      * inspector/timeline/timeline-paint.html:
      * inspector/timeline/timeline-receive-response-event.html:
      * inspector/timeline/timeline-timer.html:
      * java/argument-to-object-type.html:
      * java/array-return.html:
      * java/array-sort.html:
      * java/embedding-java-with-object.html:
      * java/inaccessible-class.html:
      * java/inline-applet-crash.html:
      * java/java-and-plugins.html:
      * java/lc3/:
      * jquery/resources/helper.js:
      * loader/go-back-to-different-window-size.html:
      * loader/load-defer-resume-crash.html:
      * loader/navigation-while-deferring-loads.html:
      * loader/reload-subresource-when-type-changes.html:
      * mathml/EmptyMFracCrash.xhtml:
      * mathml/EmptyMunderOverCrash.xhtml:
      * mathml/empty-mroot-crash.xhtml:
      * mathml/empty-msubsup-crash.html:
      * mathml/fenced-whitespace-separators-crash.html:
      * mathml/msub-anonymous-child-render-crash.html:
      * mathml/msubsup-no-grandchild.xhtml:
      * mathml/msubsup-remove-children.xhtml:
      * mathml/munderover-remove-children.html:
      * mathml/operator-hijacks-fenced-node.xhtml:
      * mathml/wbr-in-mroot-crash.html:
      * media/W3C/w3cwrapper.js:
      (test):
      (async_test.t.done):
      (async_test):
      * media/adopt-node-crash.html:
      * media/audio-controls-do-not-fade-out.html:
      * media/audio-controls-rendering.html:
      * media/audio-delete-while-slider-thumb-clicked.html:
      * media/audio-delete-while-step-button-clicked.html:
      * media/audio-garbage-collect.html:
      * media/audio-no-installed-engines.html:
      * media/audio-only-video-intrinsic-size.html:
      * media/audio-repaint.html:
      * media/context-menu-actions.html:
      * media/controls-after-reload.html:
      * media/controls-drag-timebar.html:
      * media/controls-layout-direction.html:
      * media/controls-right-click-on-timebar.html:
      * media/controls-without-preload.html:
      * media/crash-closing-page-with-media-as-plugin-fallback.html:
      * media/fallback.html:
      * media/media-blocked-by-beforeload.html:
      * media/media-blocked-by-willsendrequest.html:
      * media/media-controls-clone-crash.html:
      * media/media-controls-invalid-url.html:
      * media/media-document-audio-repaint.html:
      * media/media-document-audio-size.html:
      * media/media-fullscreen.js:
      (canplaythrough):
      * media/media-volume-slider-rendered-normal.html:
      * media/no-auto-play-in-sandbox.html:
      * media/remove-from-document-before-load.html:
      * media/resources/foreignobject-media.svg:
      * media/restore-from-page-cache.html:
      * media/svg-as-image-with-media-blocked.html:
      * media/video-beforeload-remove-source.html:
      * media/video-canvas-alpha.html:
      * media/video-canvas.html-disabled:
      * media/video-click-dblckick-standalone.html:
      * media/video-controls-in-media-document.html:
      * media/video-controls-no-scripting.html:
      * media/video-controls-toggling.html:
      * media/video-controls-visible-audio-only.html:
      * media/video-controls-with-mutation-event-handler.html:
      * media/video-delay-load-event.html:
      * media/video-display-toggle.html:
      * media/video-document-types.html:
      * media/video-element-other-namespace-crash.html:
      * media/video-empty-source.html:
      * media/video-no-audio.html:
      * media/video-paint-test.js:
      (init.waitForMultipleEvents):
      (initAndPause.waitForMultipleEvents):
      (initAndPause):
      * media/video-plays-past-end-of-test.html:
      * media/video-poster-blocked-by-willsendrequest.html:
      * media/video-replaces-poster.html:
      * media/video-source-inserted.html:
      * media/video-test.js:
      (endTest):
      * media/video-volume-slider.html:
      * media/video-zoom.html:
      * mhtml/check_domain.mht:
      * mhtml/multi_frames.html_original:
      * mhtml/multi_frames_binary.mht:
      * mhtml/multi_frames_ie.mht:
      * mhtml/multi_frames_unmht.mht:
      * mhtml/page_with_css_and_js_ie.mht:
      * mhtml/page_with_css_and_js_unmht.mht:
      * mhtml/page_with_image.html_original:
      * mhtml/page_with_image_ie.mht:
      * mhtml/page_with_image_unmht.mht:
      * mhtml/simple_page.html_original:
      * mhtml/simple_page_ie.mht:
      * mhtml/simple_page_unmht.mht:
      * networkinformation/resources/event-after-navigation-new.html:
      * networkinformation/script-tests/event-after-navigation.js:
      * platform/chromium/media/video-frame-size-change.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08372332
    • eae@chromium.org's avatar
      Unreviewed chromium win and mac rebaseline for r120403. · 55b0e113
      eae@chromium.org authored
      * platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55b0e113
    • commit-queue@webkit.org's avatar
      Add fullscreen button to Chrome video controls for video. · 2e7d38cd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88818
      
      Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
      Reviewed by Eric Carlson.
      
      No new tests, final patch will contain the rebaselined tests.
      
      The Chrome video controls are receiving a visual update.
      This patch includes a fullscreen button for video elements and the rendering of the controls
      in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
      and not moved.
      
      * css/fullscreen.css:
      (video:-webkit-full-screen, audio:-webkit-full-screen):
      Add audio to the default fullscreen styling rules.
      * css/mediaControlsChromium.css:
      (video:-webkit-full-page-media::-webkit-media-controls-panel):
      Align controls to the bottom of the fullscreen page.
      (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
      Include styling for the fullscreen button.
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore):
      Add a constant for when to hide the controls in fullscreen.
      (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
      Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
      (WebCore::MediaControlRootElementChromium::create):
      Add fullscreen button element to the visual layout.
      (WebCore::MediaControlRootElementChromium::setMediaController):
      Add fullscreen button element to the media controller.
      (WebCore::MediaControlRootElementChromium::reset):
      Show the fullscreen button if the controller supports fullscreen.
      (WebCore::MediaControlRootElementChromium::playbackStarted):
      Start the timer to hide the controls in fullscreen.
      (WebCore::MediaControlRootElementChromium::playbackStopped):
      Don't hide the controls when the video is paused in fullscreen.
      (WebCore::MediaControlRootElementChromium::reportedError):
      Hide the fullscreen button when we hit an error.
      (WebCore::MediaControlRootElementChromium::defaultEventHandler):
      Add logic for mouse events in fullscreen to start/stop the hiding timer.
      (WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
      Start the fullscreen hiding timer.
      (WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
      Timer fired: hide the video controls in fullscreen.
      (WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
      Reset the fullscreen hiding timer.
      (WebCore::MediaControlRootElementChromium::enteredFullscreen):
      Add logic to enter fullscreen.
      (WebCore::MediaControlRootElementChromium::exitedFullscreen):
      Add logic to exit fullscreen.
      * html/shadow/MediaControlRootElementChromium.h:
      (MediaControlRootElementChromium):
      Add declaration of member functions and fields for fullscreen.
      * rendering/RenderMediaControlsChromium.cpp:
      (WebCore::paintMediaFullscreenButton):
      Use the new image for the fullscreen button.
      * rendering/RenderThemeChromiumMac.h:
      (RenderThemeChromiumMac):
      Declare the fullscreen painting function for Chrome Mac.
      * rendering/RenderThemeChromiumMac.mm:
      (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
      Hook up the fullscreen paining function for Chrome Mac.
      * rendering/RenderThemeChromiumSkia.cpp:
      (WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
      Hook up the fullscreen paining function for Chrome Skia.
      * rendering/RenderThemeChromiumSkia.h:
      (RenderThemeChromiumSkia):
      Declare the fullscreen painting function for Chrome Skia.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e7d38cd
    • tkent@chromium.org's avatar
      Unreviewed, rolling out r110340. · 9ab4959d
      tkent@chromium.org authored
      http://trac.webkit.org/changeset/110340
      https://bugs.webkit.org/show_bug.cgi?id=88749
      
      Source/WebCore:
      
      r110340 added a broken implementation of
      HTMLSelectElement::selectedOptions. This roll out removes
      HTMLSelectElement::selectedOptions.
      
      * html/CollectionType.h:
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollection::shouldIncludeChildren):
      (WebCore::HTMLCollection::isAcceptableElement):
      * html/HTMLSelectElement.cpp:
      * html/HTMLSelectElement.h:
      (HTMLSelectElement):
      * html/HTMLSelectElement.idl:
      
      LayoutTests:
      
      * fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Removed.
      * fast/dom/HTMLSelectElement/select-selectedOptions.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ab4959d
    • morrita@google.com's avatar
      Unreviewed typo fix for r120405. · 1a49b74d
      morrita@google.com authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a49b74d
    • keishi@webkit.org's avatar
      Add color property to input type=range · 5724c2ae
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89067
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Adding color property to input type=range in preparation for
      supporting tick marks for datalist for input type=range.
      
      * css/html.css:
      (input[type="range"]): Setting color property for input type=range.
      This will set the color of tick mark when we implement <datalist>.
      * css/themeChromiumLinux.css:
      (input[type=range]):
      * css/themeWin.css:
      (input[type="range"]):
      
      LayoutTests:
      
      * fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
      * fast/repaint/slider-thumb-float-expected.txt:
      * platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
      * platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
      * platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
      * platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
      * platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
      * platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt.
      * platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/fast/repaint/slider-thumb-float-expected.txt.
      * platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
      * platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
      * platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
      * platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
      * platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
      * platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
      * platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
      * platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
      * platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
      * platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
      * platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
      * platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
      * platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
      * platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
      * platform/mac/fast/forms/range/slider-padding-expected.txt:
      * platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
      * platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt:
      * platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5724c2ae
    • tkent@chromium.org's avatar
      Support file extensions in HTMLInputElement::accept · addf705e
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88298
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      The WHATWG specification added file extensions supoprt for
      HTMLInputElement::accept recently.
      
      In the WebCore FileChooser interface, we rejected invalid MIME type
      strings in HTMLInputElement::acceptMIMETypes(), and platform file
      choosers don't expect that it containts file extensions. So, this patch
      introduces additional member "acceptFileExtensions" to
      FileChooserSettings, and it contains only file extensions specified by
      an accept attribute.
      
      * html/FileInputType.cpp:
      Sets HTMLInputElement::acceptFileExtensions() to
      FileChooserSettings::acceptFileExtensions.
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::receiveDropForDirectoryUpload):
      * html/HTMLInputElement.cpp:
      (WebCore::isValidFileExtension): Added.
      (WebCore::parseAcceptAttribute):
      Common part for acceptMIMETyps() and acceptFileExtensions().
      (WebCore::HTMLInputElement::acceptMIMETypes):
      Uses parseAcceptAttribute() with isValidMIMEType().
      (WebCore::HTMLInputElement::acceptFileExtensions):
      Added. Uses parseAcceptAttribute() with isValidFileExtension().
      * html/HTMLInputElement.h:
      (HTMLInputElement): Add acceptFileExtensions().
      * platform/FileChooser.h:
      (FileChooserSettings): Add acceptFileExtensions and acceptTypes().
      * platform/FileChooser.cpp:
      (WebCore::FileChooserSettings::acceptTypes): Added.
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::runOpenPanel):
      Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      addf705e
    • eae@chromium.org's avatar
      Unreviewed rebaseline for mac chromium following r120403. · 9034f5e2
      eae@chromium.org authored
      * platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9034f5e2
    • kaustubh@motorola.com's avatar
      Remove support for counterValueForElementById from chromium port · bdc9f094
      kaustubh@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88851
      
      Reviewed by Adam Barth.
      
      Moved the counterValueForElementById from LayoutTestCotroller to Internals so
      remove the old platform specific implementations as it exclusively tests WebCore functionality.
      
      * public/WebFrame.h:
      (WebFrame):
      * src/WebFrameImpl.cpp:
      (WebKit):
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdc9f094
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in battery status and canvas tests · bade82e6
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88761
      
      Reviewed by Tony Chang.
      
      * batterystatus/resources/event-after-navigation-new.html:
      * batterystatus/script-tests/event-after-navigation.js:
      * canvas/philip/tests.js:
      (_addTest.endTest):
      (_addTest.window.onload):
      (_addTest):
      * canvas/philip/tests/2d.text-custom-font-load-crash.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bade82e6
    • commit-queue@webkit.org's avatar
      [chromium] Remove unused CanvasLayerChromium.h/cpp from the tree · 668c8511
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89152
      
      Patch by James Robinson <jamesr@chromium.org> on 2012-06-14
      Reviewed by Adrienne Walker.
      
      These files have been unused and not in the build system since r119769
      
      * platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
      * platform/graphics/chromium/CanvasLayerChromium.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      668c8511
    • morrita@google.com's avatar
      Cast paddings to int in RenderTableCell · c810a842
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88918
      
      Patch by Emil A Eklund <eae@chromium.org> on 2012-06-14
      Reviewed by Levi Weintraub.
      
      Add test ensuring that table cells does not wrap when using fractional
      paddings.
      
      * fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
      * fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
      * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c810a842
    • commit-queue@webkit.org's avatar
      [BlackBerry] Selection - Crash when manipulating selection by dragging handle · a49cec95
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89160
      
      RIMBUG:164970
      Avoid to set position in shadow tree to the new selection's base. It
      crashes when setting a shadow position to a selection' base.
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-06-14
      Reviewed by Antonio Gomes.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a49cec95
    • eae@chromium.org's avatar
      Cast paddings to int in RenderTableCell · 045cb6b5
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88918
      
      Reviewed by Levi Weintraub.
      
      Source/WebCore: 
      
      Table layout uses integers throughout yet the TableCell paddingLeft/
      Right/Top/Bottom methods returns LayoutUnits. This causes inconsistent
      rounding as some call sites cast the numbers to ints before doing
      computation and others do computation before casting.
      
      By changing the methods to always cast the padding values to int we
      ensure consistent padding calculations.
      
      Ideally we'd change the type of the return value for the methods but as
      they are overriden that would likely cause more confusion.
      
      Test: fast/sub-pixel/table-cells-with-padding-do-not-wrap.html
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paddingTop):
      (WebCore::RenderTableCell::paddingBottom):
      (WebCore::RenderTableCell::paddingLeft):
      (WebCore::RenderTableCell::paddingRight):
      (WebCore::RenderTableCell::paddingBefore):
      (WebCore::RenderTableCell::paddingAfter):
      
      LayoutTests: 
      
      Add test ensuring that table cells does not wrap when using fractional
      paddings.
      
      * fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
      * fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
      * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
      * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      045cb6b5
    • bashi@chromium.org's avatar
      [Chromium] Check the result of FontCache::getCachedFontPlatformData() · 8e4c3bec
      bashi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89141
      
      Reviewed by Kent Tamura.
      
      The value of FontCache::getCachedFontPlatformData() could be invalid,
      so we should check the value before use it.
      
      No new tests. No new functionality.
      
      * platform/graphics/skia/FontCacheSkia.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e4c3bec
    • commit-queue@webkit.org's avatar
      Fix framebuffer completeness test · 78990d10
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89127
      
      Patch by Gregg Tavares <gman@google.com> on 2012-06-14
      Reviewed by Kenneth Russell.
      
      No new tests just fixing failing tests.
      
      * html/canvas/WebGLFramebuffer.cpp:
      (WebCore::WebGLFramebuffer::initializeAttachments):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
      * platform/graphics/GraphicsContext3D.cpp:
      (WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
      (WebCore):
      (WebCore::GraphicsContext3D::getClearBitsByFormat):
      (WebCore::GraphicsContext3D::getChannelBitsByFormat):
      * platform/graphics/GraphicsContext3D.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78990d10
    • morrita@google.com's avatar
      Unreviewed expectation update. · 15cdfce0
      morrita@google.com authored
      - Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15cdfce0
    • mary.wu@torchmobile.com.cn's avatar
      [BlackBerry] empty plugin cause browser hang · 88fdf980
      mary.wu@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=89091
      
      Reviewed by Rob Buis.
      
      Add check before clean pluginView in FrameLoaderBlackBerry in case
      it didn't have any content.
      RIM PR# 165336
      Reviewed internally by George Staikos
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::finishedLoading):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88fdf980
    • enne@google.com's avatar
      [chromium] Make TiledLayerChromium robust to unexpected null tiles · 67b4c316
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89143
      
      Reviewed by James Robinson.
      
      Although there shouldn't ever be null tiles in the map, it appears to
      be occurring frequently enough to show up in crash reports. In the
      short term, be robust to this so the tiler doesn't crash. This should
      eventually be reverted.
      
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::pushPropertiesTo):
      (WebCore::TiledLayerChromium::setLayerTreeHost):
      (WebCore::TiledLayerChromium::invalidateRect):
      (WebCore::TiledLayerChromium::updateTiles):
      (WebCore::TiledLayerChromium::resetUpdateState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67b4c316
    • tkent@chromium.org's avatar
      Validate form state strings in FormController::setStateForNewFormElements() · bcc71634
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88768
      
      Reviewed by Hajime Morita.
      
      .:
      
      * Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.
      
      Source/WebCore:
      
      Reject invalid form state vectors. This state vectors are generated by
      WebKit itself. However it can be invalid because
      - Serialized state vectors can be corrupted
      - A future version of WebKit might change the format
      
      So we had better reject unexpected state vectors as possible.
      
      Test: fast/forms/state-restore-broken-state.html
      
      * WebCore.exp.in: Expose some symbols used by Internals.cpp.
      * html/FormController.cpp:
      (WebCore::isNotFormControlTypeCharacter): A helper for state validation.
      (WebCore::FormController::setStateForNewFormElements):
      Reject state vectors of which size is not a multiple of 3, or a type name is invalid.
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      Returns a form state vector of the previous document.
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      Sets a form state vector for the previous document.
      * testing/Internals.h: Declare new functions.
      * testing/Internals.idl: ditto.
      
      Source/WebKit2:
      
      * win/WebKit2.def: Expose some symbols used by Internals.cpp.
      * win/WebKit2CFLite.def: ditto.
      
      LayoutTests:
      
      * fast/forms/resources/state-restore-broken-state-1.html: Added.
      * fast/forms/resources/state-restore-broken-state-2.html: Added.
      * fast/forms/state-restore-broken-state-expected.txt: Added.
      * fast/forms/state-restore-broken-state.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcc71634
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r120393. · 9efc2af6
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/120393
      https://bugs.webkit.org/show_bug.cgi?id=89163
      
      breaks cr-mac build (Requested by morrita on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-14
      
      Source/WebCore:
      
      * WebCore.gyp/WebCore.gyp:
      * platform/image-decoders/ImageDecoder.h:
      (ImageFrame):
      (ImageDecoder):
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      (turboSwizzled):
      (WebCore::JPEGImageReader::JPEGImageReader):
      (WebCore::JPEGImageReader::close):
      (WebCore::JPEGImageReader::decode):
      (JPEGImageReader):
      (WebCore::JPEGImageDecoder::outputScanlines):
      * platform/image-decoders/png/PNGImageDecoder.cpp:
      (WebCore::PNGImageReader::PNGImageReader):
      (WebCore::PNGImageReader::close):
      (WebCore::PNGImageReader::currentBufferSize):
      (PNGImageReader):
      (WebCore::PNGImageReader::decodingSizeOnly):
      (WebCore::PNGImageReader::interlaceBuffer):
      (WebCore::PNGImageReader::hasAlpha):
      (WebCore::PNGImageReader::setHasAlpha):
      (WebCore::PNGImageDecoder::headerAvailable):
      (WebCore::PNGImageDecoder::rowAvailable):
      * platform/image-decoders/skia/ImageDecoderSkia.cpp:
      (WebCore):
      (WebCore::resolveColorSpace):
      (WebCore::createColorSpace):
      (WebCore::ImageFrame::setColorProfile):
      (WebCore::ImageFrame::setStatus):
      
      Source/WTF:
      
      * wtf/Platform.h:
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9efc2af6
    • jchaffraix@webkit.org's avatar
      RenderLayer subtrees without any self-painting layer shouldn't be walked during painting · a3588081
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88888
      
      Reviewed by Simon Fraser.
      
      Performance optimization, covered by existing tests.
      
      The gist of this change is to add a has-self-painting-layer-descendant flag (including an
      invalidation logic) that is used to avoid walking subtrees without any self-painting layer.
      
      On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
      by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms
      on my machine. The test case is a pathologic example here but the optimization should
      apply in other cases.
      
      The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that
      got repurposed and renamed as part of this change.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::addChild):
      (WebCore::RenderLayer::removeChild):
      (WebCore::RenderLayer::styleChanged):
      These functions were updated to dirty / set the new flag.
      
      (WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus):
      (WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
      Added those functions to handle setting / invalidating the new flag.
      
      (WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange):
      Added this function to handle style update.
      
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintLayerContentsAndReflection):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::paintList):
      Changed this logic to bail out if we have no self-painting descendants. This is what
      is giving the performance improvement. Also added some performance ASSERTs to ensure
      the methods are not called when they shouldn't.
      
      (WebCore::RenderLayer::updateDescendantDependentFlags):
      Renamed from updateVisibilityStatus to account for the new usage.
      
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
      (WebCore::RenderLayer::collectLayers):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      Updated after updateVisibilityStatus rename.
      
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::hasSelfPaintingLayerDescendant):
      Added the declaration of the new functions as well as the new flag and dirty bit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3588081
    • wangxianzhu@chromium.org's avatar
      [Chromium-Android] Initialize font rendering in DumpRenderTree · 939410ae
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89133
      
      Reviewed by Adam Barth.
      
      Source/WebKit/chromium:
      
      * src/linuxish/WebFontRendering.cpp:
      (WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.
      
      Tools:
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::reset):
      (LayoutTestController::setTextSubpixelPositioning):
      * DumpRenderTree/chromium/TestShellAndroid.cpp:
      (platformInit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      939410ae
    • commit-queue@webkit.org's avatar
      Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port · 02f1ea9c
      commit-queue@webkit.org authored
             https://bugs.webkit.org/show_bug.cgi?id=81974
      
             Reviewed by Adam Barth.
      
             Covered by existing layout tests which will be rebaselined.
      
             * WebCore.gyp/WebCore.gyp: Add qcms to the build.
             * platform/image-decoders/ImageDecoder.h:
             (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
             On OSX, return the default RGB profile. Add FIXME to use the user's
             monitor profile and verify that profile for other platforms.
      
             * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
             (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
             two known output color spaces for which the decoder uses a data swizzle.
             (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
             libjpeg-turbo, alpha may be present in the swizzled output color space.
      
             (WebCore::JPEGImageReader::JPEGImageReader):
             (WebCore::JPEGImageReader::close):
             (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
             to use during decoding, and ensure we switch to inputing RGBA data to qcms
             even if the desired output data is BGRA: outputScanlines() sends BGRA data
             to the frame buffer following color correction if needed.
             (JPEGImageReader):
             (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
             (WebCore::JPEGImageReader::createColorTransform): Create color transform.
             Release the existing transform (if any) and assign to the color transform
             created from the color profile data.
             (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
             transform to each decoded image row.
      
             * platform/image-decoders/png/PNGImageDecoder.cpp:
             (WebCore::PNGImageReader::PNGImageReader):
             (WebCore::PNGImageReader::close):
             (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
             setters and getters.
             (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
             (WebCore::PNGImageReader::setHasAlpha): Ditto.
             (WebCore::PNGImageReader::hasAlpha): Ditto.
             (WebCore::PNGImageReader::interlaceBuffer): Ditto.
             (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
             used when a color transform is applied to the decoded image pixels.
             (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
             (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
             (WebCore::PNGImageReader::createColorTransform): Create color transform.
             Release the existing transform (if any) and assign to the color transform
             created from the color profile data.
             (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
             transform to use for decoding. Clear m_colorProfile (not used anymore).
             (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
             a color transform is needed for decoding. Apply color transform to each
             decoded image row.
      
             * platform/image-decoders/skia/ImageDecoderSkia.cpp:
             (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
             longer used. Add a FIXME to remove the old implementation.
             (WebCore::ImageFrame::setStatus): Remove old color correction code.
      
      Patch by Tony Payne <tpayne@chromium.org> on 2012-06-14
      
      Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
      https://bugs.webkit.org/show_bug.cgi?id=81974
      
      Patch by Tony Payne <tpayne@chromium.org> on 2012-06-14
      
      * wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
      to each Chromium platform, excluding Android.
      
      Reviewed by Adam Barth.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f1ea9c
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r120384. · 9693b398
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/120384
      https://bugs.webkit.org/show_bug.cgi?id=89157
      
      breaks create-blob-url-from-data-url.html (Requested by
      morrita on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-14
      
      Source/WebCore:
      
      * fileapi/Blob.cpp:
      (WebCore::Blob::Blob):
      * fileapi/BlobURL.cpp:
      (WebCore::BlobURL::createBlobURL):
      * fileapi/BlobURL.h:
      (BlobURL):
      * fileapi/FileReaderLoader.cpp:
      (WebCore::FileReaderLoader::start):
      * fileapi/ThreadableBlobRegistry.cpp:
      (WebCore):
      (WebCore::ThreadableBlobRegistry::registerBlobURL):
      (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
      * fileapi/ThreadableBlobRegistry.h:
      (WebCore):
      (ThreadableBlobRegistry):
      * html/DOMURL.cpp:
      (WebCore::DOMURL::createObjectURL):
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::create):
      
      LayoutTests:
      
      * fast/files/file-reader-file-url-expected.txt: Removed.
      * fast/files/file-reader-file-url.html: Removed.
      * fast/files/resources/file-reader-file-url-iframe.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9693b398
    • tony@chromium.org's avatar
      [chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests · 0f147f7f
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89132
      
      Reviewed by Adam Barth.
      
      This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
      and uses test_shell's layoutTestController. Moving this will make
      it easier to get rid of layoutTestController in test_shell.
      
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      (WebKit):
      * tests/data/iframe_redirect.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f147f7f
    • yosin@chromium.org's avatar
      [Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h} · 9e101362
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89155
      
      Reviewed by Kent Tamura.
      
      This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
      and .h with just "cp" code. New files aren't compiled until bug 88980.
      
      No new tests. This patch doesn't change behavior.
      
      * rendering/RenderSearchField.cpp: Added.
      (WebCore::RenderTextControlInnerBlock::positionForPoint):
      (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
      (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
      (WebCore::RenderTextControlSingleLine::containerElement):
      (WebCore::RenderTextControlSingleLine::innerBlockElement):
      (WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
      (WebCore::RenderTextControlSingleLine::resultsButtonElement):
      (WebCore::RenderTextControlSingleLine::cancelButtonElement):
      (WebCore::RenderTextControlSingleLine::textBaseStyle):
      (WebCore::RenderTextControlSingleLine::addSearchResult):
      (WebCore::RenderTextControlSingleLine::showPopup):
      (WebCore::RenderTextControlSingleLine::hidePopup):
      (WebCore::RenderTextControlSingleLine::paint):
      (WebCore::RenderTextControlSingleLine::layout):
      (WebCore::RenderTextControlSingleLine::nodeAtPoint):
      (WebCore::RenderTextControlSingleLine::styleDidChange):
      (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
      (WebCore::RenderTextControlSingleLine::hasControlClip):
      (WebCore::RenderTextControlSingleLine::controlClipRect):
      (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      (WebCore::RenderTextControlSingleLine::computeControlHeight):
      (WebCore::RenderTextControlSingleLine::updateFromElement):
      (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
      (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
      (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
      (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
      (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
      (WebCore::RenderTextControlSingleLine::autosaveName):
      (WebCore::RenderTextControlSingleLine::valueChanged):
      (WebCore::RenderTextControlSingleLine::itemText):
      (WebCore::RenderTextControlSingleLine::itemLabel):
      (WebCore::RenderTextControlSingleLine::itemIcon):
      (WebCore::RenderTextControlSingleLine::itemIsEnabled):
      (WebCore::RenderTextControlSingleLine::itemStyle):
      (WebCore::RenderTextControlSingleLine::menuStyle):
      (WebCore::RenderTextControlSingleLine::clientInsetLeft):
      (WebCore::RenderTextControlSingleLine::clientInsetRight):
      (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
      (WebCore::RenderTextControlSingleLine::clientPaddingRight):
      (WebCore::RenderTextControlSingleLine::listSize):
      (WebCore::RenderTextControlSingleLine::selectedIndex):
      (WebCore::RenderTextControlSingleLine::popupDidHide):
      (WebCore::RenderTextControlSingleLine::itemIsSeparator):
      (WebCore::RenderTextControlSingleLine::itemIsLabel):
      (WebCore::RenderTextControlSingleLine::itemIsSelected):
      (WebCore::RenderTextControlSingleLine::setTextFromItem):
      (WebCore::RenderTextControlSingleLine::fontSelector):
      (WebCore::RenderTextControlSingleLine::hostWindow):
      (WebCore::RenderTextControlSingleLine::autoscroll):
      (WebCore::RenderTextControlSingleLine::scrollWidth):
      (WebCore::RenderTextControlSingleLine::scrollHeight):
      (WebCore::RenderTextControlSingleLine::scrollLeft):
      (WebCore::RenderTextControlSingleLine::scrollTop):
      (WebCore::RenderTextControlSingleLine::setScrollLeft):
      (WebCore::RenderTextControlSingleLine::setScrollTop):
      (WebCore::RenderTextControlSingleLine::scroll):
      (WebCore::RenderTextControlSingleLine::logicalScroll):
      (WebCore::RenderTextControlSingleLine::createScrollbar):
      (WebCore::RenderTextControlSingleLine::inputElement):
      * rendering/RenderSearchField.h: Added.
      (RenderTextControlSingleLine):
      (WebCore::RenderTextControlSingleLine::popupIsVisible):
      (WebCore::RenderTextControlSingleLine::isTextField):
      (WebCore::toRenderTextControlSingleLine):
      (RenderTextControlInnerBlock):
      (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
      (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e101362
    • tkent@chromium.org's avatar
      [JSC/V8] "DOMString[]" for function return values should not be null · eeabc8c0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89151
      
      Reviewed by Kentaro Hara.
      
      jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
      we should not return JavaScript null object.
      
      No new tests. We have no plan to use this code in production code for
      now. It will be used for window.internals functions.
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::jsArray): For null input, returns an empty array, not null.
      * bindings/v8/V8Binding.cpp:
      (WebCore::v8Array): Implement DOMStringList -> JavaScript array conversion.
      Like jsArray(), we don't return null object.
      * bindings/v8/V8Binding.h:
      (WebCore): Declare v8Array().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eeabc8c0
    • commit-queue@webkit.org's avatar
      Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms. · 924afa2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89129
      
      Source/WebCore:
      
      As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium.  A
      long standing issue (~3 years) has been to disable this feature.
      
      Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
      Reviewed by Eric Carlson.
      
      Uses existing click/double-click test.
      
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::defaultEventHandler):
      
      LayoutTests:
      
      Fixes layout test to actually test what it says it tests.  Previously it was
      testing the opposite behavior and passing because MediaDocument auto-plays.
      
      Additionally failing one half of the test would still allow you to pass the
      other half.  Both issues have been fixed.
      
      Updates the test expectations for Chromium to reflect a failure.
      
      Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
      Reviewed by Eric Carlson.
      
      * media/video-click-dblckick-standalone-expected.txt:
      * media/video-click-dblckick-standalone.html:
      * platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      924afa2f
    • jianli@chromium.org's avatar
      Unreviewed. Skip the failed test due to r120384 for future investigation. · a3c5ac5a
      jianli@chromium.org authored
      * platform/chromium/TestExpectations:
      * platform/efl/Skipped:
      * platform/gtk/TestExpectations:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3c5ac5a
    • commit-queue@webkit.org's avatar
      [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree · af3c681f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88622
      
      Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-14
      Reviewed by Philippe Normand.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
      (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af3c681f
    • wangxianzhu@chromium.org's avatar
      [Chromium-Android] Should retry a few times when failed to start DumpRenderTree · 60641eef
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89124
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/port/chromium_android.py:
      (ChromiumAndroidDriver._start):
      (ChromiumAndroidDriver):
      (ChromiumAndroidDriver._start_once):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60641eef
    • jianli@chromium.org's avatar
      FileReader is dysfunctional in documents with "null" origin string · aa1eb7ab
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78648
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      The fix is to keep in-memory map from blob URL to SecurityOrigin for the
      unique origin case.
      
      Test: fast/files/file-reader-file-url.html
      
      * fileapi/Blob.cpp:
      (WebCore::Blob::Blob):
      * fileapi/BlobURL.cpp:
      (WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
      (WebCore):
      (WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
      * fileapi/BlobURL.h:
      (BlobURL):
      * fileapi/FileReaderLoader.cpp:
      (WebCore::FileReaderLoader::start):
      * fileapi/ThreadableBlobRegistry.cpp:
      (WebCore):
      (WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
      (WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
      (WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
      (WebCore::ThreadableBlobRegistry::cachedOrigin): Retrieve the origin associated with the blob URL.
      * fileapi/ThreadableBlobRegistry.h:
      (WebCore):
      (ThreadableBlobRegistry):
      * html/DOMURL.cpp:
      (WebCore::DOMURL::createObjectURL):
      * page/SecurityOrigin.cpp:
      (WebCore::cachedOrigin): Return the cached origin for the blob URL if it exists.
      (WebCore):
      (WebCore::SecurityOrigin::create): Call cachedOrigin to get the cached origin first.
      
      LayoutTests:
      
      * fast/files/file-reader-file-url-expected.txt: Added.
      * fast/files/file-reader-file-url.html: Added.
      * fast/files/resources/file-reader-file-url-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa1eb7ab
    • commit-queue@webkit.org's avatar
      Add test cases for header/footer elements' AXRoleDescription · df8bec6f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88911
      
      Header and footer elements change their accessibility roles depending
      on the elements which contain them. Specifically, they are described
      as "banner" or "footer" in the general case, and fall back to
      generic "group" role descriptions when contained in either article or
      section elements. This patch simply tests that existing behavior on
      Mac.
      
      Patch by Mike West <mkwst@chromium.org> on 2012-06-14
      Reviewed by Chris Fleizach.
      
      * platform/mac/accessibility/footer-expected.txt: Added.
      * platform/mac/accessibility/footer.html: Added.
      * platform/mac/accessibility/header-expected.txt: Added.
      * platform/mac/accessibility/header.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df8bec6f
    • commit-queue@webkit.org's avatar
      [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake · deb8307c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89015
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-14
      Reviewed by Antonio Gomes.
      
      Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake
      instead of CMakeLists.txt.
      
      No change in functionality so no new tests.
      
      * CMakeLists.txt:
      * UseJSC.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb8307c
    • commit-queue@webkit.org's avatar
      [Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background. · 3c182dfa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89033
      
      Patch by David Reveman <reveman@chromium.org> on 2012-06-14
      Reviewed by James Robinson.
      
      Add canvas background argument to PageWidgetDelegate::paint and call
      PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel
      rendering is only used when WebView has opaque background.
      
      * src/PageWidgetDelegate.cpp:
      (WebKit::PageWidgetDelegate::paint):
      * src/PageWidgetDelegate.h:
      * src/WebPagePopupImpl.cpp:
      (WebKit::WebPagePopupImpl::paint):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c182dfa
    • shawnsingh@chromium.org's avatar
      [chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug · aed43c1b
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89065
      
      Reviewed by James Robinson.
      
      A debug assertion was being triggered in the hit-testing unit
      tests because I accidentally forgot to set the
      DebugScopedSetImplThread for the tests.
      
      This patch also re-enables the disabled broken test.
      
      * tests/CCLayerTreeHostCommonTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed43c1b
    • wangxianzhu@chromium.org's avatar
      [Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering · 41e15b93
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89014
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      No new tests because of no change of functionality.
      
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
      (WebCore):
      (WebCore::FontPlatformData::setAutoHint):
      (WebCore::FontPlatformData::setUseBitmaps):
      (WebCore::FontPlatformData::setAntiAlias):
      (WebCore::FontPlatformData::setupPaint):
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
      (FontPlatformData):
      
      Source/WebKit/chromium:
      
      * public/linuxish/WebFontRendering.h:
      (WebFontRendering):
      * src/linuxish/WebFontRendering.cpp:
      (WebKit):
      (WebKit::WebFontRendering::setAutoHint):
      (WebKit::WebFontRendering::setUseBitmaps):
      (WebKit::WebFontRendering::setAntiAlias):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41e15b93
    • timothy_horton@apple.com's avatar
      DrawingArea: Painting is being resumed while the view is not visible · 988799b0
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88940
      <rdar://problem/11652545>
      
      Reviewed by Dean Jackson.
      
      Using requestAnimationFrame and the fullscreen API on a DrawingArea-backed window would cause
      rAF to permanently suspend animations after entering full-screen mode, because of the following:
      
      0. JavaScript causes fullscreen transition to start.
      1. Painting (and rAF) are suspended.
      2. The page changes size.
          a. DrawingAreaProxyImpl::sizeDidChange() calls DrawingAreaImpl::updateBackingStoreState, which calls DrawingAreaImpl::resumePainting.
          b. DrawingAreaImpl::resumePainting resumes painting, but does *not* resume rAF, because windowIsVisible is (legitimately) false.
      3. The view becomes visible, windowIsVisible is updated to true.
      4. visibilityDidChange() calls resumePainting again, but this time it early exits because painting is not suspended.
      
      Notice that because of the early exit in 4, rAF is never resumed.
      
      To solve this and prevent any further bugs caused by these unnecessary calls to resume/suspendPainting,
      temporarily stop sending SuspendPainting/ResumePainting messages from DrawingAreaProxyImpl::visibilityDidChange
      during the window animations that occur while entering and exiting full-screen.
      
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/API/mac/WKView.mm:
      (-[WKView setAutomaticallySuspendAndResumePainting:]):
      (-[WKView automaticallySuspendAndResumePainting]):
      * UIProcess/DrawingAreaProxyImpl.cpp:
      (WebKit::DrawingAreaProxyImpl::visibilityDidChange):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::setShouldSuspendAndResumePainting):
      (WebKit::WebPageProxy::shouldSuspendAndResumePainting):
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController enterFullScreen:]):
      (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      988799b0