Commits · 5c6ee64451beaa4977f0f7b0b26eea5b69bd9e90 · App_Technologies / webkit

30 Nov, 2009 22 commits

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5c6ee644

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove obsolete PLATFORM(KDE) code
        https://bugs.webkit.org/show_bug.cgi?id=31958

        KDE is now using unpatched QtWebKit.

        * parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
        * wtf/Platform.h: Remove PLATFORM(KDE) definition and code
        section that is guarded with it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5c6ee644

Skipping test that fails because of broken DND, and some tests · f4d1ccff

kov@webkit.org authored Nov 30, 2009

requiring new results.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4d1ccff

Rubber-stamped by Xan Lopez. · 2a1f73ca

kov@webkit.org authored Nov 30, 2009

Make sure we distribute and install GObject Introspection files.

* GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2a1f73ca

2009-11-30 Erik Arvidsson <arv@chromium.org> · 10fcdba8

eric@webkit.org authored Nov 30, 2009

        Reviewed by Adam Barth.

        Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=31895

        No new tests. This is already covered by:
                fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                fast/dom/CSSStyleDeclaration/css-style-item.html

        * bindings/v8/V8Collection.h:
        (WebCore::collectionStringIndexedPropertyGetter):
        (WebCore::setCollectionStringIndexedGetter):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10fcdba8

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld... · 18e1477d

sfalken@apple.com authored Nov 30, 2009

WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18e1477d

Reviewed by Simon Fraser. · a9abbee5

kov@webkit.org authored Nov 30, 2009

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a9abbee5

2009-11-30 Steve Block <steveblock@google.com> · 2b92f0e3

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
        https://bugs.webkit.org/show_bug.cgi?id=31932

        Build fix only, no new tests.

        * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2b92f0e3

2009-11-30 Steve Block <steveblock@google.com> · 4caafb76

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds PassOwnPtr include to ScriptExecutionContext.h.
        https://bugs.webkit.org/show_bug.cgi?id=31929

        Build fix only, no new tests.

        * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4caafb76

2009-11-30 Dirk Schulze <krit@webkit.org> · 5b0c5989

eric@webkit.org authored Nov 30, 2009

Reviewed by Nikolas Zimmermann.

Complex test of mask with every combination of maskUnits and maskContentUnits
as well as different values for size and position of the mask and it's content.

* platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
* platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
* platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
* svg/custom/mask-with-all-units.svg: Added.
2009-11-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
[https://bugs.webkit.org/show_bug.cgi?id=31980]

It turns out, that we did not handle maskUnits="userSpaceOnUse"
correctly. We just need to move the context of the maskImage
if maskContentUnits="objectBoundingBox". The context gets scaled
on this unit combination, so we have to substract the position of
the targetRect. On userSpaceOnUse the position just depends on the
position of the mask element.
I added a test with some senseless and reasonable values for size
and postion of the mask and it's contents. I also used every
combination of maskUnits and maskContentUnits to be sure, that it
is fixed this time.

Test: svg/custom/mask-with-all-units.svg

* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5b0c5989

2009-11-30 Steve Block <steveblock@google.com> · 54abffc6

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31928

        Build fix only, no new tests.

        * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

54abffc6

2009-11-30 Yaar Schnitman <yaar@chromium.org> · 1c1a18c1

eric@webkit.org authored Nov 30, 2009

        Reviewed by Dimitri Glazkov.

        update-webkit --chromium forces gclient sync

        https://bugs.webkit.org/show_bug.cgi?id=31967

        * Scripts/update-webkit-chromium:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1c1a18c1

2009-11-30 Steve Block <steveblock@google.com> · 70a4bba4

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=31926

        Build fix only, no new tests.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

70a4bba4

2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com> · 9c8c379e

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        Chrome::contentsSizeChanged() is called when the content size has not changed
        https://bugs.webkit.org/show_bug.cgi?id=31978

        Do not trigger contentsSizeChaned() is the new size is the same as the old one.

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9c8c379e

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9e1d35df

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix minor waning in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=31963

        * tests/qwebpage/tst_qwebpage.cpp:
        (ErrorPage::extension): Remove info wariable as it is
        not used.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9e1d35df

2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com> · b6de04f4

eric@webkit.org authored Nov 30, 2009

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix some compiler warnings seen on QtWebKit/Mac
        https://bugs.webkit.org/show_bug.cgi?id=31962

        No new tests as there is no functional change.

        * platform/network/ResourceHandle.h: Make destructor virtual as
        after r50772 ResourceHandle has virtual functions.

        * plugins/mac/PluginPackageMac.cpp:
        (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
        not a label

        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
        specifier

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b6de04f4

Versioning. · e2f9debf

mrowe@apple.com authored Nov 30, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e2f9debf

Build fix. Make sure JSCore-1.0.gir is added to the distributed · 60affd13
kov@webkit.org authored Nov 30, 2009
```
tarball.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
60affd13

2009-11-30 Xan Lopez <xlopez@igalia.com> · 22674493

xan@webkit.org authored Nov 30, 2009

        Reviewed by Gustavo Noronha.

        Bump versions for 1.1.17 release.

        * configure.ac:

WebCore:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add new headers to sources list.

        * GNUmakefile.am:

WebKit/gtk:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Prepare for 1.1.17 release.

        * NEWS:
        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22674493

[Qt] Mac Plugins : Get context menu to work in QGraphicsView · 9efe23b6

girish@forwardbias.in authored Nov 30, 2009

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

https://bugs.webkit.org/show_bug.cgi?id=31979

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9efe23b6

[Qt] Fix compilation with win32-icc · 6eb95ffc

hausmann@webkit.org authored Nov 30, 2009

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

* WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the __has_trivial_constructor type
trait.  The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

* wtf/TypeTraits.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6eb95ffc

Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController. · 021719e4

steveblock@google.com authored Nov 30, 2009

https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

* bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

021719e4

[Qt] Put tests into skiplist because of missing features. · 1fd3cff0

ossy@webkit.org authored Nov 30, 2009

* platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1fd3cff0

29 Nov, 2009 16 commits

Build fix. · 4af99e8b

bfulgham@webkit.org authored Nov 30, 2009

Correct draw signature used in ImageCairoWin.cpp.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4af99e8b

postMessage should serialize File objects · 88ed9c19

oliver@apple.com authored Nov 30, 2009

https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

88ed9c19

2009-11-29 Eric Seidel <eric@webkit.org> · 521f502c

eric@webkit.org authored Nov 30, 2009

        Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.

        * Scripts/modules/committers.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

521f502c

2009-11-29 Simon Fraser <simon.fraser@apple.com> · 1f07c2f1

simon.fraser@apple.com authored Nov 30, 2009

        Rubber-stamped by Eric Seidel.

        Fix up some compositing layout tests.

        * compositing/layers-inside-overflow-scroll.html:
        * compositing/self-painting-layers.html:
        Use the 'loadeddata' event, instead of 'load', to know when the video loads.

        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.png:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.png:
        * platform/mac/compositing/self-painting-layers-expected.checksum:
        * platform/mac/compositing/self-painting-layers-expected.png:
        Update with correct pixel results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1f07c2f1

2009-11-29 Eric Seidel <eric@webkit.org> · 49015777

eric@webkit.org authored Nov 30, 2009

        No review, just adding missing svn property.

        Set svn:executable property on new scripts.
        These were added by commit-queue commits, but the executable
        property was lost due to a bug in svn-apply:
        https://bugs.webkit.org/show_bug.cgi?id=27204

        * Scripts/update-webkit-chromium: Added property svn:executable.
        * Scripts/validate-committer-lists: Added property svn:executable.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

49015777

2009-11-29 Simon Fraser <simon.fraser@apple.com> · 90c94a14

simon.fraser@apple.com authored Nov 30, 2009

        Reviewed by Dan Bernstein.

        Optimize the hierarchy rebuilding of compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=31879

        When updating the compositing layer hierarchy, instead of removing all
        child layers and then re-adding them one by one, build a vector of child
        layers, and set them in one go.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
        GraphicsLayers.

        * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
        * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to
        set the bit that notes that sublayers changed.
        * platform/graphics/win/GraphicsLayerCACF.cpp:
        (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to
        udpate sublayers, with a note that this is not efficient.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        When updating compositing layers, use the faster updateLayerTreeGeometry() if
        we know that no layer hierarchy changes are needed, and, at the root, use
        the vector returned from rebuildCompositingLayerTree() to attach the root
        layer.
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
        collect child layers into Vectors of GraphicsLayers, which can be set as
        layer children in one go.
        (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
        rebuildCompositingLayerTree() for simplicity, and called when we just need to
        update layer geometry, without doing any reparenting.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

90c94a14

2009-11-29 Eric Seidel <eric@webkit.org> · 1e31f292

eric@webkit.org authored Nov 30, 2009

        Reviewed by Adam Barth.

        Need a way to validate that committers.py includes all committers/reviewers
        https://bugs.webkit.org/show_bug.cgi?id=30970

        Add a script which knows how to compare our public committer/reviewer
        lists and show discrepancies between them.

        Validates mailing lists vs. committers.py:
        - committers.py committers missing from webkit-committers@lists
        - webkit-committers@lists members missing from committers.py
        - committers.py reviewers missing from webkit-reviewers@lists
        - webkit-reviewers@lists members missing from committers.py
        - webkit-reviewers@lists members missing from committers.py reviewer list

        Validates committers.py vs. trunk/ SVN history:
        - committers who have not committed in over a year
        - SVN committers missing from committers.py
        - committers.py members who have no record in SVN.

        All of these lists still show "false positives" until a few more committers.py updates are made, like:
        https://bugs.webkit.org/show_bug.cgi?id=31366

        * Scripts/validate-committer-lists: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1e31f292

2009-11-29 Daniel Bates <dbates@webkit.org> · fb093c3f

dbates@webkit.org authored Nov 30, 2009

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31971

        Updated comment to reflect latest XSSAuditor bindings.

        No functionality was changed. So, no new tests.

        * page/XSSAuditor.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fb093c3f

2009-11-29 Daniel Bates <dbates@webkit.org> · e88d68df

dbates@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31969

        Removes unnecessary #include files.

        No functionality was changed. So, no new tests.

        * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
        Pair.h
        * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
        * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
        * css/CSSFontSelector.cpp: Removed include NodeList.h
        * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
        * css/CSSImageValue.cpp: Removed include RenderStyle.h
        * css/CSSImportRule.cpp: Removed include MediaList.h
        * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
        * css/CSSRule.cpp: Removed include CSSStyleSheet.h
        * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
        CSSFontFaceSource.h, and CSSProperty.h
        * page/EventSource.h: Removed include EventListener.h


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e88d68df

2009-11-29 Daniel Bates <dbates@webkit.org> · 57aa8dee

dbates@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31965

        Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
        forward declared it.

        As a side effect, we need to #include KeyframeList.h in
        RenderLayerBacking.cpp.

        No functionality was changed. So, no new tests.

        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h: Removed #include KeyframeList.h
        * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

57aa8dee

2009-11-29 Shu Chang <Chang.Shu@nokia.com> · 1862c84e

eric@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        Test using Id as index of node list.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        * fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
        * fast/dom/Element/id-in-node-list-index01.html: Added.
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Continue to search for matching node in the case where multiple nodes
        have the same id.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        Test: fast/dom/Element/id-in-node-list-index01.html

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1862c84e

2009-11-29 Daniel Bates <dbates@webkit.org> · e25945e4

dbates@webkit.org authored Nov 30, 2009

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31966

        Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
        forward declared it.

        No functionality was changed. So, no new tests.

        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e25945e4

2009-11-29 Daniel Bates <dbates@webkit.org> · 3928c53e

dbates@webkit.org authored Nov 30, 2009

Unreviewed, fix change log entry date.

For some reason, bugzilla-tool did not update the date in the change
log entry for my last commit (r51468). So, this commit fixes the date
of that entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3928c53e

2009-11-28 Daniel Bates <dbates@webkit.org> · 8efd417d

dbates@webkit.org authored Nov 29, 2009

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=31964

        Removed #include StringImpl, StyleImage. Instead, forward declared them.
        Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
        since it seems we only really used it to include PassRefPtr.h.

        No functionality was changed. So, no new tests.

        * rendering/style/ContentData.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8efd417d

2009-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> · febbbc20

eric@webkit.org authored Nov 29, 2009

        Reviewed by Eric Seidel.

        [Qt] Mac build has JIT disabled
        https://bugs.webkit.org/show_bug.cgi?id=31828

        * wtf/Platform.h: Enable JIT for Qt Mac builds

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

febbbc20

2009-11-29 Zoltan Horvath <zoltan@webkit.org> · e56ee8a1

eric@webkit.org authored Nov 29, 2009

Reviewed by Eric Seidel.

Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31906

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SQLTransactionClient - storage/DatabaseThread.cpp:45
class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
class OriginUsageRecord - storage/OriginQuotaManager.cpp:66
class DatabaseTracker - storage/DatabaseTracker.cpp:62
class ScrollbarTheme - (its child class) rendering/RenderScrollbarTheme.cpp:35
class RenderSelectionInfoBase - (its child class) rendering/RenderView.cpp:310
class RenderOverflow - rendering/RenderBox.cpp:2846

In...

e56ee8a1

28 Nov, 2009 2 commits

2009-11-28 Adam Barth <abarth@webkit.org> · bb9493a2

abarth@webkit.org authored Nov 29, 2009

        Reviewed by Eric Seidel.

        [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31950

        Now we cache the last status that we get back from QueueStatusServer.
        Eventually we'll have to do something more fancy if we want to support
        a "try again" button on QueueStatusServer, but we can cross that bridge
        when we come to it.

        * Scripts/modules/patchcollection.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bb9493a2

2009-11-28 Adam Barth <abarth@webkit.org> · 93552042

abarth@webkit.org authored Nov 29, 2009

        Reviewed by Eric Seidel.

        StyleQueue scans ~100 bug pages every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31947

        Instead of getting the pending-review attachment ids by scanning each
        bug (which results in a network request), we should just get them all
        from webkit.org/pending-review in one shot.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queries_unittest.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

93552042