1. 16 Sep, 2005 7 commits
    • sullivan's avatar
      Reviewed by Tim Omernick · 5c30a54c
      sullivan authored
              - fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at
              com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
      
              * WebView.subproj/WebImageView.m:
              (-[WebImageView copy:]):
              declare types to pasteboard before starting to set their data
              (-[WebImageView writeSelectionToPasteboard:types:]):
              ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c30a54c
    • justing's avatar
      Reviewed by geoff · 3e85ba16
      justing authored
              Removed a script that is only used by apple internal developers
      
              * Scripts/update-webkitsysteminterface: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e85ba16
    • adele's avatar
      WebCore: · c8f4d22d
      adele authored
              Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
                  QPainter should use CGContext as much as possible rather than NSGraphicsContext
              since it caused a performance regression.
      
      WebKit:
      
              Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
                  QPainter should use CGContext as much as possible rather than NSGraphicsContext
              since it caused a performance regression.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8f4d22d
    • adele's avatar
      Reviewed by Maciej. · b15de0af
      adele authored
              * Scripts/prepare-ChangeLog: Allow semicolons for protocols too.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b15de0af
    • adele's avatar
      JavaScriptCore: · 704e8bb4
      adele authored
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              * bindings/c/c_class.h:
              (KJS::Bindings::CClass::constructorAt):
              (KJS::Bindings::CClass::numConstructors):
              * bindings/c/c_runtime.h:
              (KJS::Bindings::CMethod::numParameters):
              * bindings/jni/jni_class.cpp:
              (JavaClass::JavaClass):
              * bindings/jni/jni_class.h:
              (KJS::Bindings::JavaClass::constructorAt):
              (KJS::Bindings::JavaClass::numConstructors):
              * bindings/jni/jni_instance.cpp:
              (JavaInstance::invokeMethod):
              * bindings/jni/jni_jsobject.cpp:
              (JSObject::convertJObjectToValue):
              (JSObject::listFromJArray):
              * bindings/jni/jni_runtime.cpp:
              (JavaMethod::JavaMethod):
              * bindings/jni/jni_runtime.h:
              (KJS::Bindings::JavaConstructor::_commonCopy):
              (KJS::Bindings::JavaConstructor::parameterAt):
              (KJS::Bindings::JavaConstructor::numParameters):
              (KJS::Bindings::JavaMethod::_commonCopy):
              (KJS::Bindings::JavaMethod::parameterAt):
              (KJS::Bindings::JavaMethod::numParameters):
              * bindings/npapi.h:
              * bindings/objc/WebScriptObject.mm:
              (listFromNSArray):
              * bindings/objc/objc_class.h:
              (KJS::Bindings::ObjcClass::constructorAt):
              (KJS::Bindings::ObjcClass::numConstructors):
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_runtime.h:
              * bindings/objc/objc_runtime.mm:
              (ObjcMethod::numParameters):
              * bindings/runtime.h:
              * kjs/identifier.h:
              * kjs/internal.h:
              * kjs/property_slot.h:
              (KJS::PropertySlot::setCustomIndex):
              (KJS::PropertySlot::index):
              (KJS::PropertySlot::):
              * kjs/regexp_object.cpp:
              (RegExpObjectImp::backrefGetter):
              (RegExpObjectImp::getOwnPropertySlot):
              * kjs/simple_number.h:
              (KJS::SimpleNumber::):
              (KJS::SimpleNumber::value):
              (KJS::SimpleNumber::fits):
              (KJS::SimpleNumber::integerFits):
              (KJS::SimpleNumber::make):
              * kjs/string_object.cpp:
              (substituteBackreferences):
              * kjs/ustring.cpp:
              (KJS::UString::from):
              (KJS::UString::toUInt32):
              (KJS::UString::find):
              (KJS::UString::rfind):
              * kjs/ustring.h:
              * kjs/value.cpp:
              (KJS::jsNumber):
              * kjs/value.h:
      
      WebCore:
      
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              Changed longs (which IDL files use as 32-bit) to ints
      
              * ForwardingHeaders/khtml_pagecache.h:
              * khtml/css/css_base.h:
              (DOM::StyleListImpl::length):
              (DOM::StyleListImpl::item):
              * khtml/css/css_computedstyle.cpp:
              (DOM::CSSComputedStyleDeclarationImpl::length):
              (DOM::CSSComputedStyleDeclarationImpl::item):
              * khtml/css/css_computedstyle.h:
              * khtml/css/css_ruleimpl.cpp:
              (CSSMediaRuleImpl::append):
              (CSSMediaRuleImpl::insertRule):
              (CSSMediaRuleImpl::cssText):
              (CSSRuleListImpl::CSSRuleListImpl):
              (CSSRuleListImpl::deleteRule):
              (CSSRuleListImpl::insertRule):
              * khtml/css/css_ruleimpl.h:
              (DOM::CSSRuleListImpl::length):
              (DOM::CSSRuleListImpl::item):
              (DOM::CSSMediaRuleImpl::deleteRule):
              * khtml/css/css_stylesheetimpl.cpp:
              (CSSStyleSheetImpl::insertRule):
              (CSSStyleSheetImpl::addRule):
              (CSSStyleSheetImpl::deleteRule):
              (StyleSheetListImpl::length):
              (StyleSheetListImpl::item):
              * khtml/css/css_stylesheetimpl.h:
              (DOM::MediaListImpl::length):
              (DOM::MediaListImpl::item):
              * khtml/css/css_valueimpl.cpp:
              (DOM::CSSMutableStyleDeclarationImpl::length):
              (DOM::CSSMutableStyleDeclarationImpl::item):
              * khtml/css/css_valueimpl.h:
              (DOM::CSSValueListImpl::length):
              (DOM::CSSValueListImpl::item):
              * khtml/dom/css_rule.h:
              * khtml/dom/css_stylesheet.h:
              * khtml/dom/css_value.h:
              * khtml/dom/dom2_events.cpp:
              (DOM::UIEvent::detail):
              (DOM::UIEvent::initUIEvent):
              (DOM::MouseEvent::screenX):
              (DOM::MouseEvent::screenY):
              (DOM::MouseEvent::clientX):
              (DOM::MouseEvent::clientY):
              (DOM::MouseEvent::initMouseEvent):
              (DOM::KeyboardEvent::keyLocation):
              (DOM::KeyboardEvent::initKeyboardEvent):
              * khtml/dom/dom2_events.h:
              * khtml/dom/dom2_range.h:
              * khtml/dom/dom2_traversal.cpp:
              (DOM::NodeIterator::whatToShow):
              (DOM::TreeWalker::whatToShow):
              * khtml/dom/dom2_traversal.h:
              * khtml/dom/dom_node.h:
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::getOwnPropertySlot):
              (KJS::DOMStyleSheetList::getOwnPropertySlot):
              (KJS::DOMMediaList::getOwnPropertySlot):
              (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
              (KJS::DOMCSSRuleList::getOwnPropertySlot):
              (KJS::DOMCSSValueList::getOwnPropertySlot):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNodeList::getOwnPropertySlot):
              (KJS::DOMNodeList::callAsFunction):
              (KJS::DOMNamedNodeMap::getOwnPropertySlot):
              (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
              * khtml/ecma/kjs_events.cpp:
              (KJS::DOMEvent::getValueProperty):
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElement::getOwnPropertySlot):
              (KJS::KJS::HTMLElement::put):
              (KJS::HTMLCollection::getOwnPropertySlot):
              (KJS::KJS::HTMLCollection::callAsFunction):
              (KJS::KJS::HTMLSelectCollection::put):
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::Plugins::getOwnPropertySlot):
              (KJS::MimeTypes::getOwnPropertySlot):
              (KJS::Plugin::getOwnPropertySlot):
              * khtml/editing/apply_style_command.cpp:
              (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              * khtml/editing/break_blockquote_command.cpp:
              (khtml::BreakBlockquoteCommand::doApply):
              * khtml/editing/composite_edit_command.cpp:
              (khtml::CompositeEditCommand::insertNodeAt):
              (khtml::CompositeEditCommand::splitTextNode):
              (khtml::CompositeEditCommand::splitTextNodeContainingElement):
              (khtml::CompositeEditCommand::insertTextIntoNode):
              (khtml::CompositeEditCommand::deleteTextFromNode):
              (khtml::CompositeEditCommand::replaceTextInNode):
              (khtml::CompositeEditCommand::deleteInsignificantText):
              * khtml/editing/composite_edit_command.h:
              * khtml/editing/delete_from_text_node_command.cpp:
              (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * khtml/editing/delete_from_text_node_command.h:
              (khtml::DeleteFromTextNodeCommand::offset):
              (khtml::DeleteFromTextNodeCommand::count):
              * khtml/editing/insert_into_text_node_command.cpp:
              (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * khtml/editing/insert_into_text_node_command.h:
              (khtml::InsertIntoTextNodeCommand::offset):
              * khtml/editing/insert_paragraph_separator_command.cpp:
              (khtml::InsertParagraphSeparatorCommand::doApply):
              * khtml/editing/insert_text_command.cpp:
              (khtml::InsertTextCommand::input):
              (khtml::InsertTextCommand::insertSpace):
              * khtml/editing/insert_text_command.h:
              (khtml::InsertTextCommand::charactersAdded):
              * khtml/editing/join_text_nodes_command.h:
              * khtml/editing/markup.cpp:
              (khtml::startMarkup):
              (khtml::completeURLs):
              * khtml/editing/move_selection_command.cpp:
              (khtml::MoveSelectionCommand::doApply):
              * khtml/editing/rebalance_whitespace_command.cpp:
              (khtml::RebalanceWhitespaceCommand::doApply):
              * khtml/editing/rebalance_whitespace_command.h:
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
              * khtml/editing/replace_selection_command.h:
              * khtml/editing/selection.cpp:
              (khtml::Selection::debugPosition):
              * khtml/editing/split_text_node_command.cpp:
              (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
              * khtml/editing/split_text_node_command.h:
              (khtml::SplitTextNodeCommand::offset):
              * khtml/editing/split_text_node_containing_element.cpp:
              (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * khtml/editing/split_text_node_containing_element_command.h:
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::VisiblePosition):
              (khtml::VisiblePosition::deepEquivalent):
              (khtml::VisiblePosition::rangeCompliantEquivalent):
              (khtml::VisiblePosition::maxOffset):
              (khtml::VisiblePosition::character):
              (khtml::VisiblePosition::debugPosition):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_range.h:
              * khtml/editing/visible_text.cpp:
              (khtml::CircularSearchBuffer::length):
              (khtml::TextIterator::TextIterator):
              (khtml::TextIterator::handleTextNode):
              (khtml::TextIterator::handleTextBox):
              (khtml::TextIterator::emitCharacter):
              (khtml::TextIterator::range):
              (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
              (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement):
              (khtml::SimplifiedBackwardsTextIterator::emitCharacter):
              (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText):
              (khtml::CharacterIterator::range):
              (khtml::CharacterIterator::advance):
              (khtml::CharacterIterator::string):
              (khtml::WordAwareIterator::length):
              (khtml::CircularSearchBuffer::append):
              (khtml::CircularSearchBuffer::neededCharacters):
              (khtml::CircularSearchBuffer::isMatch):
              (khtml::TextIterator::rangeLength):
              (khtml::TextIterator::rangeFromLocationAndLength):
              (khtml::plainText):
              (khtml::findPlainText):
              * khtml/editing/visible_text.h:
              (khtml::TextIterator::length):
              (khtml::SimplifiedBackwardsTextIterator::length):
              (khtml::CharacterIterator::length):
              (khtml::CharacterIterator::characterOffset):
              * khtml/editing/visible_units.cpp:
              (khtml::startOfLine):
              (khtml::endOfLine):
              (khtml::startOfParagraph):
              (khtml::endOfParagraph):
              * khtml/html/html_blockimpl.cpp:
              (HTMLPreElementImpl::width):
              (HTMLPreElementImpl::setWidth):
              * khtml/html/html_blockimpl.h:
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::length):
              (DOM::HTMLGenericFormElementImpl::tabIndex):
              (DOM::HTMLGenericFormElementImpl::setTabIndex):
              (DOM::HTMLInputElementImpl::selectionStart):
              (DOM::HTMLInputElementImpl::selectionEnd):
              (DOM::HTMLInputElementImpl::setSelectionStart):
              (DOM::HTMLInputElementImpl::setSelectionEnd):
              (DOM::HTMLInputElementImpl::setSelectionRange):
              (DOM::HTMLInputElementImpl::setMaxLength):
              (DOM::HTMLInputElementImpl::setSize):
              (DOM::HTMLSelectElementImpl::selectedIndex):
              (DOM::HTMLSelectElementImpl::setSelectedIndex):
              (DOM::HTMLSelectElementImpl::length):
              (DOM::HTMLSelectElementImpl::remove):
              (DOM::HTMLSelectElementImpl::setSize):
              (DOM::HTMLOptionElementImpl::index):
              (DOM::HTMLOptionElementImpl::setIndex):
              (DOM::HTMLTextAreaElementImpl::selectionStart):
              (DOM::HTMLTextAreaElementImpl::selectionEnd):
              (DOM::HTMLTextAreaElementImpl::setSelectionStart):
              (DOM::HTMLTextAreaElementImpl::setSelectionEnd):
              (DOM::HTMLTextAreaElementImpl::setSelectionRange):
              (DOM::HTMLTextAreaElementImpl::setCols):
              (DOM::HTMLTextAreaElementImpl::setRows):
              (DOM::HTMLOptionsCollectionImpl::length):
              (DOM::HTMLOptionsCollectionImpl::setLength):
              (DOM::HTMLOptionsCollectionImpl::item):
              * khtml/html/html_formimpl.h:
              (DOM::HTMLInputElementImpl::maxLength):
              (DOM::HTMLInputElementImpl::maxResults):
              (DOM::HTMLSelectElementImpl::minWidth):
              (DOM::HTMLSelectElementImpl::size):
              (DOM::HTMLTextAreaElementImpl::cols):
              (DOM::HTMLTextAreaElementImpl::rows):
              * khtml/html/html_imageimpl.cpp:
              (HTMLImageElementImpl::width):
              (HTMLImageElementImpl::height):
              (HTMLImageElementImpl::border):
              (HTMLImageElementImpl::setBorder):
              (HTMLImageElementImpl::setHeight):
              (HTMLImageElementImpl::hspace):
              (HTMLImageElementImpl::setHspace):
              (HTMLImageElementImpl::vspace):
              (HTMLImageElementImpl::setVspace):
              (HTMLImageElementImpl::setWidth):
              (HTMLImageElementImpl::x):
              (HTMLImageElementImpl::y):
              (HTMLAreaElementImpl::tabIndex):
              (HTMLAreaElementImpl::setTabIndex):
              * khtml/html/html_imageimpl.h:
              * khtml/html/html_inlineimpl.cpp:
              (DOM::HTMLAnchorElementImpl::tabIndex):
              (DOM::HTMLAnchorElementImpl::setTabIndex):
              * khtml/html/html_inlineimpl.h:
              * khtml/html/html_listimpl.cpp:
              (DOM::HTMLOListElementImpl::setStart):
              (DOM::HTMLLIElementImpl::value):
              (DOM::HTMLLIElementImpl::setValue):
              * khtml/html/html_listimpl.h:
              (DOM::HTMLUListElementImpl::start):
              (DOM::HTMLOListElementImpl::start):
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::calcLength):
              (DOM::HTMLCollectionImpl::length):
              (DOM::HTMLCollectionImpl::item):
              (DOM::HTMLFormCollectionImpl::calcLength):
              (DOM::HTMLFormCollectionImpl::item):
              * khtml/html/html_miscimpl.h:
              * khtml/html/html_objectimpl.cpp:
              (DOM::HTMLObjectElementImpl::tabIndex):
              (DOM::HTMLObjectElementImpl::setTabIndex):
              * khtml/html/html_objectimpl.h:
              * khtml/html/html_tableimpl.cpp:
              (DOM::HTMLTableElementImpl::insertRow):
              (DOM::HTMLTableElementImpl::deleteRow):
              (DOM::HTMLTableSectionElementImpl::insertRow):
              (DOM::HTMLTableSectionElementImpl::deleteRow):
              (DOM::HTMLTableRowElementImpl::rowIndex):
              (DOM::HTMLTableRowElementImpl::sectionRowIndex):
              (DOM::HTMLTableRowElementImpl::insertCell):
              (DOM::HTMLTableRowElementImpl::deleteCell):
              (DOM::HTMLTableCellElementImpl::cellIndex):
              (DOM::HTMLTableCellElementImpl::setColSpan):
              (DOM::HTMLTableCellElementImpl::setRowSpan):
              (DOM::HTMLTableColElementImpl::setSpan):
              * khtml/html/html_tableimpl.h:
              (DOM::HTMLTableColElementImpl::span):
              * khtml/html/htmlparser.cpp:
              (HTMLParser::handleError):
              * khtml/html/htmltokenizer.cpp:
              (khtml::HTMLTokenizer::processToken):
              * khtml/khtml_events.cpp:
              (khtml::MouseEvent::offset):
              * khtml/khtml_events.h:
              (khtml::MouseReleaseEvent::MouseReleaseEvent):
              * khtml/khtml_part.cpp:
              (KHTMLPart::restoreURL):
              (KHTMLPart::stopLoading):
              (KHTMLPart::receivedFirstData):
              (KHTMLPart::slotFinished):
              (KHTMLPart::begin):
              (KHTMLPart::slotViewFrameSource):
              (KHTMLPart::selectFrameElementInParentIfFullySelected):
              * khtml/khtml_part.h:
              * khtml/khtmlpart_p.h:
              (KHTMLPartPrivate::KHTMLPartPrivate):
              * khtml/misc/loader.h:
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::positionForRenderer):
              * khtml/rendering/render_br.cpp:
              (RenderBR::caretMinOffset):
              (RenderBR::caretMaxOffset):
              (RenderBR::caretMaxRenderedOffset):
              (RenderBR::inlineBox):
              * khtml/rendering/render_br.h:
              * khtml/rendering/render_form.cpp:
              (RenderLineEdit::selectionStart):
              (RenderLineEdit::selectionEnd):
              (RenderLineEdit::setSelectionStart):
              (RenderLineEdit::setSelectionEnd):
              (RenderLineEdit::setSelectionRange):
              (RenderTextArea::calcMinMaxWidth):
              (RenderTextArea::selectionStart):
              (RenderTextArea::selectionEnd):
              (RenderTextArea::setSelectionStart):
              (RenderTextArea::setSelectionEnd):
              (RenderTextArea::setSelectionRange):
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_frames.cpp:
              (RenderPartObject::updateWidget):
              * khtml/rendering/render_line.cpp:
              (khtml::InlineBox::caretMinOffset):
              (khtml::InlineBox::caretMaxOffset):
              (khtml::InlineBox::caretMaxRenderedOffset):
              * khtml/rendering/render_line.h:
              * khtml/rendering/render_list.cpp:
              (RenderListMarker::calcMinMaxWidth):
              * khtml/rendering/render_list.h:
              (khtml::RenderListItem::value):
              (khtml::RenderListItem::setValue):
              * khtml/rendering/render_object.cpp:
              (RenderObject::caretMinOffset):
              (RenderObject::caretMaxOffset):
              (RenderObject::caretMaxRenderedOffset):
              (RenderObject::previousOffset):
              (RenderObject::nextOffset):
              (RenderObject::inlineBox):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              (RenderReplaced::caretMinOffset):
              (RenderReplaced::caretMaxOffset):
              (RenderReplaced::caretMaxRenderedOffset):
              * khtml/rendering/render_replaced.h:
              * khtml/rendering/render_table.h:
              (khtml::RenderTableCell::cellIndex):
              (khtml::RenderTableCell::setCellIndex):
              * khtml/rendering/render_text.cpp:
              (InlineTextBox::paintMarker):
              (InlineTextBox::paintMarkedTextUnderline):
              (InlineTextBox::caretMinOffset):
              (InlineTextBox::caretMaxOffset):
              (InlineTextBox::caretMaxRenderedOffset):
              (RenderText::previousOffset):
              (RenderText::nextOffset):
              (InlineTextBox::positionForOffset):
              (RenderText::caretMinOffset):
              (RenderText::caretMaxOffset):
              (RenderText::caretMaxRenderedOffset):
              (RenderText::inlineBox):
              * khtml/rendering/render_text.h:
              * khtml/xml/dom2_eventsimpl.cpp:
              (DOM::EventImpl::timeStamp):
              (DOM::UIEventImpl::UIEventImpl):
              (DOM::UIEventImpl::initUIEvent):
              (DOM::UIEventImpl::layerX):
              (DOM::UIEventImpl::layerY):
              (DOM::UIEventImpl::pageX):
              (DOM::UIEventImpl::pageY):
              (DOM::UIEventImpl::which):
              (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl):
              (DOM::MouseRelatedEventImpl::pageX):
              (DOM::MouseRelatedEventImpl::pageY):
              (DOM::MouseEventImpl::MouseEventImpl):
              (DOM::MouseEventImpl::initMouseEvent):
              (DOM::MouseEventImpl::which):
              (DOM::KeyboardEventImpl::KeyboardEventImpl):
              (DOM::KeyboardEventImpl::initKeyboardEvent):
              (DOM::KeyboardEventImpl::which):
              (DOM::WheelEventImpl::WheelEventImpl):
              * khtml/xml/dom2_eventsimpl.h:
              (DOM::UIEventImpl::detail):
              (DOM::UIEventWithKeyStateImpl::UIEventWithKeyStateImpl):
              (DOM::MouseRelatedEventImpl::screenX):
              (DOM::MouseRelatedEventImpl::screenY):
              (DOM::MouseRelatedEventImpl::clientX):
              (DOM::MouseRelatedEventImpl::clientY):
              (DOM::MouseRelatedEventImpl::layerX):
              (DOM::MouseRelatedEventImpl::layerY):
              (DOM::KeyboardEventImpl::keyLocation):
              (DOM::WheelEventImpl::wheelDelta):
              * khtml/xml/dom2_rangeimpl.cpp:
              (DOM::RangeImpl::RangeImpl):
              (DOM::RangeImpl::startOffset):
              (DOM::RangeImpl::endOffset):
              (DOM::RangeImpl::setStart):
              (DOM::RangeImpl::setEnd):
              (DOM::RangeImpl::compareBoundaryPoints):
              (DOM::RangeImpl::processContents):
              (DOM::RangeImpl::checkNodeWOffset):
              * khtml/xml/dom2_rangeimpl.h:
              * khtml/xml/dom2_traversalimpl.cpp:
              (DOM::TraversalImpl::TraversalImpl):
              (DOM::TreeWalkerImpl::TreeWalkerImpl):
              * khtml/xml/dom2_traversalimpl.h:
              (DOM::TraversalImpl::whatToShow):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::createNodeIterator):
              (DocumentImpl::createTreeWalker):
              (DocumentImpl::processHttpEquiv):
              (DocumentImpl::removeMarkers):
              (DocumentImpl::copyMarkers):
              (DocumentImpl::markersForNode):
              (DocumentImpl::shiftMarkers):
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::openTagStartToString):
              (NamedAttrMapImpl::item):
              (NamedAttrMapImpl::getAttributeItem):
              (NamedAttrMapImpl::removeAttribute):
              * khtml/xml/dom_elementimpl.h:
              (DOM::NamedAttrMapImpl::length):
              (DOM::NamedAttrMapImpl::attributeItem):
              (DOM::NamedMappedAttrMapImpl::attributeItem):
              * khtml/xml/dom_nodeimpl.cpp:
              (DOM::NodeImpl::normalize):
              (DOM::NodeImpl::nodeIndex):
              (DOM::NodeImpl::childNodeCount):
              (DOM::NodeImpl::childNode):
              (DOM::NodeImpl::maxOffset):
              (DOM::NodeImpl::maxDeepOffset):
              (DOM::NodeImpl::caretMinOffset):
              (DOM::NodeImpl::caretMaxOffset):
              (DOM::NodeImpl::caretMaxRenderedOffset):
              (DOM::NodeImpl::previousOffset):
              (DOM::NodeImpl::nextOffset):
              (DOM::ContainerNodeImpl::childNodeCount):
              (DOM::ContainerNodeImpl::childNode):
              (DOM::NodeListImpl::recursiveLength):
              (DOM::NodeListImpl::recursiveItem):
              (DOM::NodeListImpl::itemById):
              (DOM::ChildNodeListImpl::length):
              (DOM::ChildNodeListImpl::item):
              (DOM::TagNodeListImpl::length):
              (DOM::TagNodeListImpl::item):
              (DOM::NameNodeListImpl::length):
              (DOM::NameNodeListImpl::item):
              * khtml/xml/dom_nodeimpl.h:
              * khtml/xml/dom_position.cpp:
              (DOM::Position::Position):
              (DOM::Position::previous):
              (DOM::Position::next):
              (DOM::Position::renderedOffset):
              (DOM::Position::equivalentRangeCompliantPosition):
              (DOM::Position::rendersInDifferentPosition):
              (DOM::Position::trailingWhitespacePosition):
              (DOM::Position::debugPosition):
              * khtml/xml/dom_position.h:
              (DOM::Position::offset):
              * khtml/xml/dom_textimpl.cpp:
              (CharacterDataImpl::length):
              (CharacterDataImpl::substringData):
              (CharacterDataImpl::insertData):
              (CharacterDataImpl::deleteData):
              (CharacterDataImpl::replaceData):
              (CharacterDataImpl::checkCharDataOperation):
              (CharacterDataImpl::maxOffset):
              (CharacterDataImpl::caretMinOffset):
              (CharacterDataImpl::caretMaxOffset):
              (CharacterDataImpl::caretMaxRenderedOffset):
              (TextImpl::splitText):
              * khtml/xml/dom_textimpl.h:
              * kwq/DOM-CSS.mm:
              (-[DOMStyleSheetList length]):
              (-[DOMStyleSheetList item:]):
              (-[DOMCSSStyleSheet insertRule::]):
              (-[DOMCSSStyleSheet deleteRule:]):
              (-[DOMMediaList length]):
              (-[DOMMediaList item:]):
              (-[DOMCSSRuleList length]):
              (-[DOMCSSRuleList item:]):
              (-[DOMCSSMediaRule insertRule::]):
              (-[DOMCSSMediaRule deleteRule:]):
              (-[DOMCSSStyleDeclaration length]):
              (-[DOMCSSStyleDeclaration item:]):
              (-[DOMCSSValueList length]):
              (-[DOMCSSValueList item:]):
              * kwq/DOM.mm:
              (-[DOMNamedNodeMap item:]):
              (-[DOMNamedNodeMap length]):
              (-[DOMNodeList item:]):
              (-[DOMNodeList length]):
              (-[DOMCharacterData length]):
              (-[DOMCharacterData substringData::]):
              (-[DOMCharacterData insertData::]):
              (-[DOMCharacterData deleteData::]):
              (-[DOMCharacterData replaceData:::]):
              (-[DOMText splitText:]):
              (-[DOMRange description]):
              (-[DOMRange startOffset]):
              (-[DOMRange endOffset]):
              (-[DOMRange setStart::]):
              (-[DOMRange setEnd::]):
              (-[DOMNodeIterator whatToShow]):
              (-[DOMTreeWalker whatToShow]):
              (-[DOMDocument createNodeIterator::::]):
              (-[DOMDocument createTreeWalker::::]):
              * kwq/DOMCSS.h:
              * kwq/DOMCore.h:
              * kwq/DOMEvents.h:
              (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
              * kwq/DOMEvents.mm:
              (-[DOMMouseEvent screenX]):
              (-[DOMMouseEvent screenY]):
              (-[DOMMouseEvent clientX]):
              (-[DOMMouseEvent clientY]):
              (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
              (-[DOMUIEvent detail]):
              (-[DOMUIEvent initUIEvent:::::]):
              * kwq/DOMExtensions.h:
              * kwq/DOMHTML.h:
              * kwq/DOMHTML.mm:
              (-[DOMHTMLCollection length]):
              (-[DOMHTMLCollection item:]):
              (-[DOMHTMLOptionsCollection length]):
              (-[DOMHTMLOptionsCollection setLength:]):
              (-[DOMHTMLOptionsCollection item:]):
              (-[DOMHTMLFormElement length]):
              (-[DOMHTMLSelectElement selectedIndex]):
              (-[DOMHTMLSelectElement setSelectedIndex:]):
              (-[DOMHTMLSelectElement length]):
              (-[DOMHTMLSelectElement setLength:]):
              (-[DOMHTMLSelectElement size]):
              (-[DOMHTMLSelectElement setSize:]):
              (-[DOMHTMLSelectElement tabIndex]):
              (-[DOMHTMLSelectElement setTabIndex:]):
              (-[DOMHTMLSelectElement remove:]):
              (-[DOMHTMLOptionElement index]):
              (-[DOMHTMLInputElement maxLength]):
              (-[DOMHTMLInputElement setMaxLength:]):
              (-[DOMHTMLInputElement size]):
              (-[DOMHTMLInputElement setSize:]):
              (-[DOMHTMLInputElement tabIndex]):
              (-[DOMHTMLInputElement setTabIndex:]):
              (-[DOMHTMLTextAreaElement cols]):
              (-[DOMHTMLTextAreaElement setCols:]):
              (-[DOMHTMLTextAreaElement rows]):
              (-[DOMHTMLTextAreaElement setRows:]):
              (-[DOMHTMLTextAreaElement tabIndex]):
              (-[DOMHTMLTextAreaElement setTabIndex:]):
              (-[DOMHTMLButtonElement tabIndex]):
              (-[DOMHTMLButtonElement setTabIndex:]):
              (-[DOMHTMLOListElement start]):
              (-[DOMHTMLOListElement setStart:]):
              (-[DOMHTMLLIElement value]):
              (-[DOMHTMLLIElement setValue:]):
              (-[DOMHTMLPreElement width]):
              (-[DOMHTMLPreElement setWidth:]):
              (-[DOMHTMLAnchorElement tabIndex]):
              (-[DOMHTMLAnchorElement setTabIndex:]):
              (-[DOMHTMLImageElement height]):
              (-[DOMHTMLImageElement setHeight:]):
              (-[DOMHTMLImageElement hspace]):
              (-[DOMHTMLImageElement setHspace:]):
              (-[DOMHTMLImageElement vspace]):
              (-[DOMHTMLImageElement setVspace:]):
              (-[DOMHTMLImageElement width]):
              (-[DOMHTMLImageElement setWidth:]):
              (-[DOMHTMLObjectElement hspace]):
              (-[DOMHTMLObjectElement setHspace:]):
              (-[DOMHTMLObjectElement tabIndex]):
              (-[DOMHTMLObjectElement setTabIndex:]):
              (-[DOMHTMLObjectElement vspace]):
              (-[DOMHTMLObjectElement setVspace:]):
              (-[DOMHTMLAppletElement hspace]):
              (-[DOMHTMLAppletElement setHspace:]):
              (-[DOMHTMLAppletElement vspace]):
              (-[DOMHTMLAppletElement setVspace:]):
              (-[DOMHTMLAreaElement tabIndex]):
              (-[DOMHTMLAreaElement setTabIndex:]):
              (-[DOMHTMLTableSectionElement insertRow:]):
              (-[DOMHTMLTableSectionElement deleteRow:]):
              (-[DOMHTMLTableElement insertRow:]):
              (-[DOMHTMLTableElement deleteRow:]):
              (-[DOMHTMLTableColElement span]):
              (-[DOMHTMLTableColElement setSpan:]):
              (-[DOMHTMLTableRowElement rowIndex]):
              (-[DOMHTMLTableRowElement sectionRowIndex]):
              (-[DOMHTMLTableRowElement insertCell:]):
              (-[DOMHTMLTableRowElement deleteCell:]):
              (-[DOMHTMLTableCellElement cellIndex]):
              (-[DOMHTMLTableCellElement colSpan]):
              (-[DOMHTMLTableCellElement setColSpan:]):
              (-[DOMHTMLTableCellElement rowSpan]):
              (-[DOMHTMLTableCellElement setRowSpan:]):
              (-[DOMHTMLEmbedElement height]):
              (-[DOMHTMLEmbedElement setHeight:]):
              (-[DOMHTMLEmbedElement width]):
              (-[DOMHTMLEmbedElement setWidth:]):
              * kwq/DOMRange.h:
              * kwq/DOMStylesheets.h:
              * kwq/DOMTraversal.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::advanceToNextMisspelling):
              (KWQKHTMLPart::openURLFromPageCache):
              (KWQKHTMLPart::markMisspellings):
              * kwq/KWQString.h:
              * kwq/KWQString.mm:
              (QString::toShort):
              (QString::toUShort):
              (QString::toInt):
              (QString::toUInt):
              * kwq/KWQTextEdit.h:
              * kwq/KWQTextEdit.mm:
              (QTextEdit::selectionStart):
              (QTextEdit::selectionEnd):
              (QTextEdit::setSelectionStart):
              (QTextEdit::setSelectionEnd):
              (QTextEdit::setSelectionRange):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge convertToNSRange:DOM::]):
      
      WebKit:
      
              Change by Darin, reviewed by me and Maciej.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
              use int instead of long for 32-bit (to prepare for LP64 compiling)
      
              * Plugins.subproj/npapi.m: changed types to match those defined in npapi.h
              (NPN_MemAlloc):
              (NPN_MemFlush):
              (NPN_PostURLNotify):
              (NPN_PostURL):
              (NPN_Write):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      704e8bb4
    • tomernic's avatar
      Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley. · 24ba9376
      tomernic authored
      	<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)
      
              Test cases added:
              * manual-tests/show-hide-object.html: Added.
              * manual-tests/resources/spinbox.swf: Added.
      
              * khtml/html/html_objectimpl.cpp:
              (DOM::HTMLObjectElementImpl::detach):
      	Set needWidgetUpdate to true so that the widget is updated on the next attach().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24ba9376
    • eseidel's avatar
      Bug #: 4907 · 74df03e4
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              * khtml/xml/dom_textimpl.cpp:
              (TextImpl::rendererIsNeeded):
              One line change to prevent adding text objects as direct
              children to FrameSet objects in the render tree.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74df03e4
  2. 15 Sep, 2005 1 commit
    • harrison's avatar
      Reviewed by Dave Hyatt. · fb1a91a8
      harrison authored
              <rdar://problem/4244976> reproducible hang at ocharleys.com in VisiblePosition::initDownstream
      
              Problem is that RenderText::nextOffset() passes an empty string the UBreakIterator, which returns
              UBRK_DONE (-1) from ubrk_following, and that -1 is used without question as return result of
              nextOffset().  Fixed by checking for UBRK_DONE and returning offset+1 in that case.  Similar
              change in RenderText::previousOffset().
      
              Test cases added:
              * layout-tests/editing/selection/extend-by-word-002-expected.checksum: Added.
              * layout-tests/editing/selection/extend-by-word-002-expected.png: Added.
              * layout-tests/editing/selection/extend-by-word-002-expected.txt: Added.
              * layout-tests/editing/selection/extend-by-word-002.html: Added.
      
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::updateFirstLetter):
              Added comments.  Slight format adjustments.
      
              * khtml/rendering/render_text.cpp:
              (getCharacterBreakIterator):
              Slight format adjustment.
      
              (RenderText::previousOffset):
              (RenderText::nextOffset):
              Check for UBRK_DONE.
      
              (RenderTextFragment::RenderTextFragment)
              (RenderTextFragment::RenderTextFragment)
              Fixed parameter names.
      
              (m_generatedContentStr):
              * khtml/rendering/render_text.h:
              Fixed parameter names in the two RenderTextFragment constructors.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb1a91a8
  3. 14 Sep, 2005 10 commits
    • darin's avatar
      Reviewed, tweaked, and landed by Darin. · e14e6483
      darin authored
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3809
                Should default to UTF-8 or UTF-16 for application/xml documents with omitted charset and encoding declaration
      
              Test cases added:
              * layout-tests/fast/encoding/xml-utf-8-default.xml: Added.
              * layout-tests/fast/encoding/xml-utf-8-default-expected.txt: Added.
      
              * khtml/misc/decoder.cpp: (Decoder::decode): Always set encoding when we see an XML header.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e14e6483
    • darin's avatar
      * layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test... · 791e3f5f
      darin authored
              * layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now that DumpRenderTree handles
              this case properly. The old expected result just had the word "error"!
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      791e3f5f
    • darin's avatar
      - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4291 · bb993895
      darin authored
                dumpAsText doesn't work with XHTML documents
      
              * DumpRenderTree/DumpRenderTree.m: (dump): Dump the innerText of the document element
              rather than of the body element. This works with typical XHTML documents. We can probably
              do something even better in the long run, but this fixes the immediate issue.
      
              - separate tweak
      
              * Scripts/run-webkit-tests: Show the results in the current built Safari by using
              run-safari instead of just using "open", which often runs another copy of Safari instead.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb993895
    • justing's avatar
      Reviewed by john · cb221b0d
      justing authored
              Fixes <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload
              We were adding the movie to the document twice after the changes were added to handle fallback content.
              There are some errors for which we should not render fall back content
      
              * Misc.subproj/WebKitErrorsPrivate.h:
              Introduced WebKitErrorPlugInWillHandleLoad to represent the cancel we do
              to prevent loading plugin content twice
      
              * Plugins.subproj/WebPluginDocumentView.m:
              (-[WebPluginDocumentView dataSourceUpdated:]): Ditto
      
              * WebView.subproj/WebDataSource.m:
              (-[WebDataSource _receivedMainResourceError:complete:]):
              Don't handleFallbackContent on WebKitErrorPlugInWillHandleLoad or on a user cancel
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb221b0d
    • justing's avatar
      Reviewed by john · bbfac8be
      justing authored
              Test cases added: none, method rename
      
              Part of fix for <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload
      
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge handleFallbackContent]):
              Renamed bridge method mainResourceError to handleFallbackContent, since there are some
              main resource errors for which we should not render fallback content.  E.G user cancels
              and the cancel we do to prevent loading plugin content twice (see <rdar://problem/4258008>)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbfac8be
    • harrison's avatar
      Reviewed by Eric. · 41a177ec
      harrison authored
              <rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)
      
              Test cases added: None.  Manual testing is way to awkward, and automated testing
              is not possible.  Filed following bug to get automation.
              <rdar://problem/4256882> Need automated testing support for accessibility APIs
      
              * kwq/KWQAccObject.mm:
              (AXAttributedStringAppendText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41a177ec
    • vicki's avatar
      Reviewed by Dave Hyatt. · 7f31e453
      vicki authored
      	- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)
      
              * khtml/xml/dom_nodeimpl.cpp:
              (DOM::ContainerNodeImpl::getUpperLeftCorner):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f31e453
    • thatcher's avatar
      Reviewed by Eric. · b445dea7
      thatcher authored
              * WebKit.xcodeproj/project.pbxproj:
              made WebDashboardRegion.h a private header
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b445dea7
    • darin's avatar
      Reviewed by John. · 24610a11
      darin authored
              No easy way to test this in layout tests, so no test added.
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4984
                REGRESSION placeholder border left behind after image finishes loading
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4985
                REGRESSION assertion failure in KWQPainter.mm:841
      
              * kwq/KWQPainter.mm:
              (QPainter::save): Do nothing if painting is disabled.
              (QPainter::restore): Ditto.
              (QPainter::drawRect): Inset so that we "frame" the rectangle rather than "stroking" the
              rectangle. The former draws inside the rectangle but the latter draws centered on the
              edge of the rectangle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24610a11
    • darin's avatar
      WebCore: · 79ec5083
      darin authored
              Reviewed by Maciej.
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
                QPainter should use CGContext as much as possible rather than NSGraphicsContext
      
              * kwq/KWQPainter.h: Made no-op xForm be an inline. Reformatted to remove extraneous spaces.
              Removed clearFocusRing. Changed the name of various private functions to remove underscore
              prefix, and reorganize them.
      
              * kwq/KWQPainter.mm:
              (QPainterPrivate::QPainterPrivate): Remove the NSBezierPath for focus.
              (QPainterPrivate::~QPainterPrivate): Ditto.
              (QPainter::save): Use CGContext instead of NSGraphicsContext.
              (QPainter::restore): Ditto.
              (QPainter::drawRect): Use CGContextFillRect instead of _fillRectXX, and
              CGContextStrokeRect instead of NSFrameRect.
              (QPainter::setFillColor): Added. Sets CGContext fill color based on brush.
              (QPainter::setFillColorFromCurrentBrush): Added. Sets CGContext fill color based on QPainter's
              current brush.
              (QPainter::setFillColorFromCurrentPen): Added. Sets CGContext fill color based on QPainter's
              current pen.
              (QPainter::setStrokeColorAndLineWidthFromCurrentPen): Added. Set CGContext stroke color and
              line width based on QPainter's current pen.
              (QPainter::drawLine): Use CGContextStrokeLineSegments instead of NSBezierPath.
              (QPainter::drawEllipse): Use CGContextFillEllipseInRect instead of CGContextFillPath and
              CGContextStrokeEllipseInRect instead of CGContextStrokePath.
              (QPainter::drawArc): Removed some uneeded type casts, changed to call the new private functions,
              currentContext and setStrokeColorAndLineWidthFromCurrentPen.
              (QPainter::drawConvexPolygon): Use new private functions, also use CGContextDrawPath in the
              case where we want to both fill and stroke the polygon.
              (QPainter::getCompositeOperation): Remove unneeded cast.
              (QPainter::setCompositeOperation): Map from name to operation here rather than relying on the
              code on the WebKit side to do it (allows us to remove names entirely from the WebKit side).
              (QPainter::compositeOperatorFromString): Remove a local variable and some casts.
              (getBlendedColorComponent): Rewrote to do the same computation without any conversion to float.
              (QPainter::fillRect): Use CGContextFillRect instead of _fillRectXXX.
              (QPainter::addClip): Use CGContextClipToRect instead of NSBezierPath.
              (QPainter::addRoundedRectClip): Add missing call to CGContextBeginPath.
              (QPainter::beginTransparencyLayer): Use CGContextSaveGState instead of NSGraphicsContext.
              (QPainter::endTransparencyLayer): Use CGContextRestoreGState instead of NSGraphicsContext.
              (QPainter::initFocusRing): Use CGContextBeginPath instead of creating an NSBezierPath.
              (QPainter::addFocusRingRect): Use CGContextAddRect instead of NSBezierPath.
              (QPainter::drawFocusRing): Use CGContextFillPath instead of NSBezierPath.
      
              * khtml/rendering/render_flow.cpp: (RenderFlow::paintFocusRing): Remove call to clearFocusRing. No longer exists.
              * khtml/rendering/render_object.cpp: (RenderObject::paintOutline): Ditto.
      
              * kwq/WebCoreImageRendererFactory.h: Remove setCGCompositeOperationFromString method.
      
      WebKit:
      
              Reviewed by Maciej.
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
                QPainter should use CGContext as much as possible rather than NSGraphicsContext
      
              * WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString
              method, no longer needed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79ec5083
  4. 13 Sep, 2005 2 commits
    • harrison's avatar
      Reviewed by Justin. · 77d8db91
      harrison authored
              <rdar://problem/4204892> Correcting incorrect spelling in Mail causes others to lose their red squiggles
      
              Fixed by having SplitTextNodeCommand::doApply copy the markers to the new node, and having SplitTextNodeCommand::doUnapply
              copy the markers from the merged-in node to the combined node.
      
              btw - filed <rdar://problem/4256492> "WebCore editing automated layout tests verify spelling markers"
              so that we can automate tests for this.
      
              Test cases added:
              * manual-tests/keep_spelling_markers.html: Added.
      
              * khtml/editing/split_text_node_command.cpp:
              (khtml::SplitTextNodeCommand::doApply):
              (khtml::SplitTextNodeCommand::doUnapply):
              Call new copyMarkers() function.
      
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::removeMarkers):
              (DocumentImpl::addMarker):
              (DocumentImpl::copyMarkers):
              (DocumentImpl::markersForNode):
              (DocumentImpl::shiftMarkers):
              * khtml/xml/dom_docimpl.h:
              (DOM::DocumentMarker::):
              Added copyMarkers() function.  Reorganized code for clarity.
      
              * khtml/xml/dom_textimpl.cpp:
              (CharacterDataImpl::setData):
              (CharacterDataImpl::deleteData):
              (CharacterDataImpl::replaceData):
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::respondToChangedSelection):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge unmarkAllMisspellings]):
              Update calls to marker functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d8db91
    • tomernic's avatar
      Reviewed by Justin Garcia, Darin Adler. · d4c8b134
      tomernic authored
      	- <rdar://problem/3163393> Safari does not support Windowless mode in Flash
      
              * Plugins.subproj/WebBaseNetscapePluginView.h:
      	Added 'isTransparent' instance variable.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
      	When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
      	region of the opaque ancestor.  This means that a partially-transparent plugin, which
      	by definition does not clear its port on redraw, will not overdraw the valid parts
      	of its port.
              (-[WebBaseNetscapePluginView sendEvent:]):
      	Disabled the "green debug background" for transparent plugins -- since they are not
      	expected to cover their entire port every redraw, this debug code makes no sense.
              (-[WebBaseNetscapePluginView setVariable:value:]):
      	Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
      	unimplemented).
      	Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
      	plugin variables, then we may do so here.
              * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
      	Added SPI for -[WebBaseNetscapePluginView setVariable:value].
              * Plugins.subproj/npapi.m:
              (NPN_SetValue):
      	Implemented this function so that plugins may set state (such as window mode).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c8b134
  5. 12 Sep, 2005 1 commit
    • eseidel's avatar
      Bug #: none · 8efd2b15
      eseidel authored
      Submitted by: eseidel
      Reviewed by: none, build fix only for svg.
              Fixes build after qstring() -> string() rename this weekend.
      
              * kdom/Helper.cpp:
              (parseLength):
              * kdom/core/DOMStringImpl.cpp:
              (DOMStringImpl::toInt):
              * kdom/core/DocumentImpl.cpp:
              (DocumentImpl::getId):
              * kdom/css/CSSStyleSelector.cpp:
              (checkPseudoState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8efd2b15
  6. 11 Sep, 2005 7 commits
    • darin's avatar
      Reviewed by John Sullivan. · bded90a8
      darin authored
              - fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent
      
              Test cases added:
              * layout-tests/fast/events/access-key-self-destruct.html: Added.
              * layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.
      
              * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration
              with a SharedPtr; this helps in cases where the last reference to the node goes away inside the
              event handler.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bded90a8
    • darin's avatar
      Forgot to check this in (was mentioned in ChangeLog). · 02bed308
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bed308
    • darin's avatar
      Reviewed by Eric. · 2eba085a
      darin authored
              - changed back the name of a couple of string() functions that were renamed to qstring() by accident
      
              * kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring().
              This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.
      
              * khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current
              AtomicString to string() back from qstring()!
      
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring().
              (khtml::checkPseudoState): Ditto.
              (khtml::CSSStyleSelector::checkOneSelector): Ditto.
              * khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
              * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
              * khtml/xml/dom_stringimpl.cpp:
              (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed
              boolean instead of re-checking a couple of data members.
              (DOM::parseLength): Use string() instead of qstring().
              (DOM::DOMStringImpl::toInt): Ditto.
      
              - removed some dead code
      
              * khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eba085a
    • darin's avatar
      WebKit: · 316d66fd
      darin authored
              Reviewed, tweaked, and landed by Darin.
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4286
                .Mac prefpane crashes when Safari using CVS WebKit is running
      
              * WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]):
              If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
              is set in the environment, then unset DYLD_FRAMEWORK_PATH.
      
              * WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
              in configurations other than Default -- we don't want that code in production
              builds, but we want it in builds we do ourselves and nightly builds.
      
      WebKitTools:
      
              Reviewed, tweaked, and landed by Darin.
      
              - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4286
                .Mac prefpane crashes when Safari using CVS WebKit is running
      
              * Scripts/run-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH.
              * Scripts/run-webkit-app: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      316d66fd
    • eseidel's avatar
      Bug #: 4932 · 29ffe3ea
      eseidel authored
      Submitted by: eseidel
      Reviewed by: self, only affects SVG; build fix.
              * JavaScriptCore.xcodeproj/project.pbxproj: Fixed JSC+SVG
              Fixed JavaScriptCore+SVG after PCRE 6.1 merger.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4932
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29ffe3ea
    • darin's avatar
      * Scripts/run-webkit-tests: Oops. Use spaces, not tabs. · 606ab5c7
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      606ab5c7
    • darin's avatar
      Reviewed by Eric. · c44887eb
      darin authored
              * Scripts/run-webkit-tests: Sort tests with a new "pathcmp" function that's better in
              two ways: 1) puts all files in a directory before any files in a subdirectory, and
              2) sort file names with numeric digits in them in a logical way, so test-33 will come
              before test-3.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c44887eb
  7. 10 Sep, 2005 11 commits
  8. 09 Sep, 2005 1 commit
    • tomernic's avatar
      Reviewed by John Sullivan. · 7eea642d
      tomernic authored
              * History.subproj/WebBackForwardList.m:
              (-[WebBackForwardList removeItem:]):
      	SPI to remove a given WebHistoryItem.
      
              * History.subproj/WebBackForwardListPrivate.h: Added.
      
              * WebKit.xcodeproj/project.pbxproj:
      	Added WebBackForwardListPrivate.h as a private header.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@10506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eea642d